[jira] [Commented] (RANGER-4672) Tagsync log file name is not containing hostname and user

[Himanshu Maurya (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-4672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825155#comment-17825155
 ] 

Himanshu Maurya commented on RANGER-4672:
-

Hi [~madhan] 

Kindly review and merge this

Thanks & Regards

> Tagsync log file name is not containing hostname and user
> -
>
> Key: RANGER-4672
> URL: https://issues.apache.org/jira/browse/RANGER-4672
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger, tagsync
>Reporter: Himanshu Maurya
>Assignee: Himanshu Maurya
>Priority: Major
> Fix For: 3.0.0
>
>
> Ranger admin and usersync logs file name is containing hostname and user but 
> tagsync is missing that



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/
---

(Updated March 10, 2024, 6:28 p.m.)


Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
Subhrat Chaudhary.


Changes
---

addressed the review comments.


Bugs: RANGER-4741
https://issues.apache.org/jira/browse/RANGER-4741


Repository: ranger


Description
---

updated Ranger Hive authorizer to get owner of a table only once per query


Diffs (updated)
-

  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
 9b25e2b8a 


Diff: https://reviews.apache.org/r/74929/diff/3/

Changes: https://reviews.apache.org/r/74929/diff/2-3/


Testing
---

- verified that the optimization results in significantly reduced time to 
authorize access to tables with large number of columns. For a table with 4000 
columns, the time taked reduced from 100 seconds to 1.5 seconds
- verified that all existing tests pass successfully


Thanks,

Madhan Neethiraj

Re: Review Request 74935: RANGER-4653: [addendum] Use Name validation regex instead of service name validation regex for Display name

[Kishor Gollapalliwar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74935/#review226312
---


Ship it!




Ship It!

- Kishor Gollapalliwar


On March 8, 2024, 3:48 p.m., Abhishek Patil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74935/
> ---
> 
> (Updated March 8, 2024, 3:48 p.m.)
> 
> 
> Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Madhan Neethiraj, 
> Mehul Parikh, Mugdha Varadkar, and Ramesh Mani.
> 
> 
> Bugs: RANGER-4653
> https://issues.apache.org/jira/browse/RANGER-4653
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently, in the Service creation / edit form in Ranger react UI, there is a 
> validation for display name which does not allow spaces in displayName. The 
> validation has to be modified to include spaces, otherwise it won't allow 
> edit of Service from UI if the display name contains a space
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx
>  be179a981 
> 
> 
> Diff: https://reviews.apache.org/r/74935/diff/1/
> 
> 
> Testing
> ---
> 
> Applied the patch on a cluster and tested the following scenarios :-
> 1. Ensured that service creation is allowed for a display name containing a 
> space
> 2. Ensured that service update operation is allowed for a display name 
> containing a space
> 3. Ensured that service creation / update fails if service display name 
> contains a special character / if the name is longer than 255 characters.
> 
> 
> Thanks,
> 
> Abhishek Patil
> 
>

Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

[Kishor Gollapalliwar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/#review226311
---




hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
Lines 3181 (patched)


LOG.info() ==> LOG.debug()


- Kishor Gollapalliwar


On March 8, 2024, 11:10 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74929/
> ---
> 
> (Updated March 8, 2024, 11:10 p.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
> Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4741
> https://issues.apache.org/jira/browse/RANGER-4741
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> updated Ranger Hive authorizer to get owner of a table only once per query
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  9b25e2b8a 
> 
> 
> Diff: https://reviews.apache.org/r/74929/diff/2/
> 
> 
> Testing
> ---
> 
> - verified that the optimization results in significantly reduced time to 
> authorize access to tables with large number of columns. For a table with 
> 4000 columns, the time taked reduced from 100 seconds to 1.5 seconds
> - verified that all existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74929: RANGER-4741: Hive plugin optimization to avoid excessive metastore API calls

[Kishor Gollapalliwar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74929/#review226310
---


Ship it!




Ship It!

- Kishor Gollapalliwar


On March 8, 2024, 11:10 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74929/
> ---
> 
> (Updated March 8, 2024, 11:10 p.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
> Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4741
> https://issues.apache.org/jira/browse/RANGER-4741
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> updated Ranger Hive authorizer to get owner of a table only once per query
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  9b25e2b8a 
> 
> 
> Diff: https://reviews.apache.org/r/74929/diff/2/
> 
> 
> Testing
> ---
> 
> - verified that the optimization results in significantly reduced time to 
> authorize access to tables with large number of columns. For a table with 
> 4000 columns, the time taked reduced from 100 seconds to 1.5 seconds
> - verified that all existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>