[jira] [Commented] (RANGER-3409) Update Jackson and remove Codehaus version

2024-05-21 Thread Bhavik Patel (Jira) 


[ 
https://issues.apache.org/jira/browse/RANGER-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848127#comment-17848127
 ] 

Bhavik Patel commented on RANGER-3409:
--

[~sercan.tekin]  I have reviewed your PR but i can see still the usage of 
"codehaus" package. 

> Update Jackson and remove Codehaus version
> --
>
> Key: RANGER-3409
> URL: https://issues.apache.org/jira/browse/RANGER-3409
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: 3.0.0
>Reporter: Andrew Charneski
>Priority: Blocker
> Attachments: ranger-modify-policy.png
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> An old version of Jackson (Codehaus Jackson 1.9.13) is still being used. 
> Jackson has since moved namespaces with a reorganized library structure. 
> Update all references to the older version to use the newer version (which is 
> currently used in some modules).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4795) Add validation in API to check emptyness on policyitem while creating policy.

2024-05-21 Thread Rakesh Gupta (Jira) 
Rakesh Gupta created RANGER-4795:


 Summary: Add validation in API to check emptyness on policyitem 
while creating policy.
 Key: RANGER-4795
 URL: https://issues.apache.org/jira/browse/RANGER-4795
 Project: Ranger
  Issue Type: Task
  Components: Ranger
Reporter: Rakesh Gupta
Assignee: Rakesh Gupta


There is an inconsistency between Ranger API and UI not doing the same 
validation for Policy creation. 

Policy creation API should fail when a policy with all empty values and along 
with  [""]  or  ["null"] in policyItem --> users, groups and roles.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Review Request 75004: RANGER-4795: Add validation in API to check emptyness on policyitem while creating policy.

2024-05-21 Thread Rakesh Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75004/
---

Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Mehul 
Parikh, Pradeep Agrawal, and sanket shelar.


Bugs: RANGER-4795
https://issues.apache.org/jira/browse/RANGER-4795


Repository: ranger


Description
---

There is an inconsistency between Ranger API and UI not doing the same 
validation for Policy creation. 

Policy creation API should fail when a policy with all empty values and along 
with  [""]  or  ["null"] in policyItem --> users, groups and roles.


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
 462246a3e 


Diff: https://reviews.apache.org/r/75004/diff/1/


Testing
---

Verified while creating/updating Policy API fails, when users/groups/roles 
fields are all empty values or contain arrays with empty strings (e.g. [""]) 
within the policy items.


Thanks,

Rakesh Gupta

[jira] [Commented] (RANGER-3409) Update Jackson and remove Codehaus version

2024-05-21 Thread Sercan Tekin (Jira) 


[ 
https://issues.apache.org/jira/browse/RANGER-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848223#comment-17848223
 ] 

Sercan Tekin commented on RANGER-3409:
--

[~bpatel], you're correct. My intention was only to address the camel-case 
conflict in the first place.

But now, I've incorporated [~n.blagodarny]'s solution (crediting as the 
author), and then cherry-picked the solution for the conflict on top of it in 
my PR.

Could you folks review and test this now? -> 
https://github.com/apache/ranger/pull/252

> Update Jackson and remove Codehaus version
> --
>
> Key: RANGER-3409
> URL: https://issues.apache.org/jira/browse/RANGER-3409
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: 3.0.0
>Reporter: Andrew Charneski
>Priority: Blocker
> Attachments: ranger-modify-policy.png
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> An old version of Jackson (Codehaus Jackson 1.9.13) is still being used. 
> Jackson has since moved namespaces with a reorganized library structure. 
> Update all references to the older version to use the newer version (which is 
> currently used in some modules).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (RANGER-3409) Update Jackson and remove Codehaus version

2024-05-21 Thread Sercan Tekin (Jira) 


[ 
https://issues.apache.org/jira/browse/RANGER-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848223#comment-17848223
 ] 

Sercan Tekin edited comment on RANGER-3409 at 5/21/24 2:26 PM:
---

[~bpatel], you're correct. My intention was only to address the camel-case 
conflict in the first place.

But now, I've incorporated [~n.blagodarny]'s solution (crediting as the 
author), and then cherry-picked the solution for the conflict on top of it in 
my PR.

Could you folks please review and test this now? -> 
https://github.com/apache/ranger/pull/252


was (Author: JIRAUSER283532):
[~bpatel], you're correct. My intention was only to address the camel-case 
conflict in the first place.

But now, I've incorporated [~n.blagodarny]'s solution (crediting as the 
author), and then cherry-picked the solution for the conflict on top of it in 
my PR.

Could you folks review and test this now? -> 
https://github.com/apache/ranger/pull/252

> Update Jackson and remove Codehaus version
> --
>
> Key: RANGER-3409
> URL: https://issues.apache.org/jira/browse/RANGER-3409
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: 3.0.0
>Reporter: Andrew Charneski
>Priority: Blocker
> Attachments: ranger-modify-policy.png
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> An old version of Jackson (Codehaus Jackson 1.9.13) is still being used. 
> Jackson has since moved namespaces with a reorganized library structure. 
> Update all references to the older version to use the newer version (which is 
> currently used in some modules).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (RANGER-3409) Update Jackson and remove Codehaus version

2024-05-21 Thread Sercan Tekin (Jira) 


[ 
https://issues.apache.org/jira/browse/RANGER-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848223#comment-17848223
 ] 

Sercan Tekin edited comment on RANGER-3409 at 5/21/24 2:32 PM:
---

[~bpatel], you're correct. My intention was only to address the camel-case 
conflict in the first place.

But now, I've incorporated [~n.blagodarny]'s solution (crediting as the 
author), and then cherry-picked the solution for the conflict on top of it in 
my PR.

Could you folks please review and test this now? -> 
https://github.com/apache/ranger/pull/252

PS: [~n.blagodarny], have you changed your user name or email address in your 
git account> None of the below options link you as an author to your github 
account:
{code:java}
git commit --amend --author="Nikita Blagodarnyi "
git commit --amend --author="nblagodarnyi "
git commit --amend --author="n.blagodarny "
{code}
Even in your own PR, in the commit details, your name is not linked to your 
account.




was (Author: JIRAUSER283532):
[~bpatel], you're correct. My intention was only to address the camel-case 
conflict in the first place.

But now, I've incorporated [~n.blagodarny]'s solution (crediting as the 
author), and then cherry-picked the solution for the conflict on top of it in 
my PR.

Could you folks please review and test this now? -> 
https://github.com/apache/ranger/pull/252

> Update Jackson and remove Codehaus version
> --
>
> Key: RANGER-3409
> URL: https://issues.apache.org/jira/browse/RANGER-3409
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: 3.0.0
>Reporter: Andrew Charneski
>Priority: Blocker
> Attachments: ranger-modify-policy.png
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> An old version of Jackson (Codehaus Jackson 1.9.13) is still being used. 
> Jackson has since moved namespaces with a reorganized library structure. 
> Update all references to the older version to use the newer version (which is 
> currently used in some modules).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74953: RANGER-4769: removed code duplication in generation of admin audit logs

2024-05-21 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74953/#review226474
---


Fix it, then Ship it!





security-admin/src/main/java/org/apache/ranger/service/AbstractAuditedResourceService.java
Lines 187 (patched)


Consider rewriting this as 

if (StringUtils.isBlank(value) && (action == OPERATION_CREATE_CONTEXT || 
action == OPERATION_DELETE_CONTEXT) {
   return null;
} else if (skipTrxLogForAttribute(obj, oldObj, trxLogAttr)) {
   return null;
} else if (StringUtils.equals(prevValue, newValue)) {
   return null;
} else {
   ret = new XXTrxLog(classType, obj.getId(), objName, actionString, 
trxLogAttr.getAttribUserFriendlyName(), prevValue, newValue);
   ret.setParentObjectClassType(parentClassType);
   ret.setParentObjectId(parentObjId);
   ret.setParentObjectName(parentObjName);
}



security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java
Lines 109 (patched)


This class duplicates many methods in AbstractAuditedResourceService class. 
Please review and see if the common methods can be moved to a base class.


- Abhay Kulkarni


On April 5, 2024, 10:56 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74953/
> ---
> 
> (Updated April 5, 2024, 10:56 p.m.)
> 
> 
> Review request for ranger, Anand Nadar, Asit Vadhavkar, Abhay Kulkarni, Mehul 
> Parikh, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, Subhrat Chaudhary, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4769
> https://issues.apache.org/jira/browse/RANGER-4769
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - replaced getTransactionLog() implementation in 13 classes with 
> implementations in following base classes
> -- AbstractAuditedResourceService.createTransactionLog()
> -- RangerAuditedModelService.createTransactionLog()
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 
> 40d4c4043 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 
> 0aa03e7c2 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 
> 9e2f28716 
>   security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java 
> 42943946c 
>   
> security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneRefUpdater.java
>  10bbfcd32 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> 47fbe 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java d5393603e 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java d202b2184 
>   security-admin/src/main/java/org/apache/ranger/common/view/VTrxLogAttr.java 
> 8c86a92c6 
>   security-admin/src/main/java/org/apache/ranger/entity/XXTrxLog.java 
> c308fba7b 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4bfaa862c 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> a6c759234 
>   
> security-admin/src/main/java/org/apache/ranger/service/AbstractAuditedResourceService.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java
>  1f2659d4b 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsBaseModelService.java
>  421646d86 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareInDatasetService.java
>  a76cb2a99 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareService.java
>  55c4b3633 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetInProjectService.java
>  62074cfd7 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetService.java
>  a82672a37 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsProjectService.java
>  d70da154e 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java
>  b1b5a841a 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
>  b59b94f43 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java
>  a2929f3c1 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 
> 7e0b29c89 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java
>  39755da1d 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceBase.java
>  586a6b705 
>   
> security-ad

Re: Review Request 74953: RANGER-4769: removed code duplication in generation of admin audit logs

2024-05-21 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74953/
---

(Updated May 21, 2024, 7:03 p.m.)


Review request for ranger, Anand Nadar, Asit Vadhavkar, Abhay Kulkarni, Mehul 
Parikh, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, Subhrat Chaudhary, 
and Velmurugan Periasamy.


Changes
---

addressed review comments


Bugs: RANGER-4769
https://issues.apache.org/jira/browse/RANGER-4769


Repository: ranger


Description
---

- replaced getTransactionLog() implementation in 13 classes with 
implementations in following base classes
-- AbstractAuditedResourceService.createTransactionLog()
-- RangerAuditedModelService.createTransactionLog()


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 
40d4c4043 
  security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 0aa03e7c2 
  security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 
9e2f28716 
  security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java 
42943946c 
  
security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneRefUpdater.java 
10bbfcd32 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
38b95543e 
  security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java d5393603e 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e0623e0c2 
  security-admin/src/main/java/org/apache/ranger/common/view/VTrxLogAttr.java 
8c86a92c6 
  security-admin/src/main/java/org/apache/ranger/entity/XXTrxLog.java c308fba7b 
  security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4bfaa862c 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
d0649ab1a 
  
security-admin/src/main/java/org/apache/ranger/service/AbstractAuditedResourceService.java
 PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java
 1f2659d4b 
  
security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java
 PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/service/RangerGdsBaseModelService.java
 421646d86 
  
security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareInDatasetService.java
 a76cb2a99 
  
security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareService.java
 55c4b3633 
  
security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetInProjectService.java
 62074cfd7 
  
security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetService.java
 a82672a37 
  
security-admin/src/main/java/org/apache/ranger/service/RangerGdsProjectService.java
 d70da154e 
  
security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java
 b1b5a841a 
  
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 
b59b94f43 
  
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java
 a2929f3c1 
  security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 
7e0b29c89 
  
security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java
 39755da1d 
  
security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceBase.java
 586a6b705 
  
security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java
 a4b7616e1 
  
security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
 3acbfd55d 
  
security-admin/src/main/java/org/apache/ranger/service/RangerServiceServiceBase.java
 fa23b96d7 
  
security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java 
4d96df6ea 
  security-admin/src/main/java/org/apache/ranger/service/XAssetService.java 
b937cff04 
  security-admin/src/main/java/org/apache/ranger/service/XAssetServiceBase.java 
6855a0b63 
  security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java 
3fe0832e2 
  
security-admin/src/main/java/org/apache/ranger/service/XAuditMapServiceBase.java
 0eb7d9bc7 
  security-admin/src/main/java/org/apache/ranger/service/XGroupService.java 
1f033b33d 
  security-admin/src/main/java/org/apache/ranger/service/XGroupServiceBase.java 
3b50ed5fe 
  security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 
5cfcb785c 
  
security-admin/src/main/java/org/apache/ranger/service/XGroupUserServiceBase.java
 feaaa20dd 
  security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java 
2fa22fa68 
  
security-admin/src/main/java/org/apache/ranger/service/XPermMapServiceBase.java 
d3d2e9a8c 
  security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java 
00b902f1a 
  
security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java 
eb97bab9f 
  
security-admin/src/main/java/org/apache/ranger/service/XPortalUserServiceBase.java
 4d2e9d74a 
  security-admin/s

Re: Review Request 74953: RANGER-4769: removed code duplication in generation of admin audit logs

2024-05-21 Thread Madhan Neethiraj 


> On May 21, 2024, 4:16 p.m., Abhay Kulkarni wrote:
> > security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java
> > Lines 109 (patched)
> > 
> >
> > This class duplicates many methods in AbstractAuditedResourceService 
> > class. Please review and see if the common methods can be moved to a base 
> > class.

Abhay - both AbstractAuditedResourceService and RangerAuditedModelService deal 
with persisting entity objects (derived from XXDBBase). However 
AbstractAuditedResourceService deals with view classes deriving from 
VXDataObject, while RangerAuditedModelService deals with view classes deriving 
from  RangerBaseModelObject. Given this, carving out few common methods into a 
separate class will likely result in many more classes to be updated. If 
necessary, I suggest tracking that via a separate JIRA.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74953/#review226474
---


On May 21, 2024, 7:03 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74953/
> ---
> 
> (Updated May 21, 2024, 7:03 p.m.)
> 
> 
> Review request for ranger, Anand Nadar, Asit Vadhavkar, Abhay Kulkarni, Mehul 
> Parikh, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, Subhrat Chaudhary, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4769
> https://issues.apache.org/jira/browse/RANGER-4769
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - replaced getTransactionLog() implementation in 13 classes with 
> implementations in following base classes
> -- AbstractAuditedResourceService.createTransactionLog()
> -- RangerAuditedModelService.createTransactionLog()
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 
> 40d4c4043 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 
> 0aa03e7c2 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 
> 9e2f28716 
>   security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java 
> 42943946c 
>   
> security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneRefUpdater.java
>  10bbfcd32 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> 38b95543e 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java d5393603e 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e0623e0c2 
>   security-admin/src/main/java/org/apache/ranger/common/view/VTrxLogAttr.java 
> 8c86a92c6 
>   security-admin/src/main/java/org/apache/ranger/entity/XXTrxLog.java 
> c308fba7b 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4bfaa862c 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> d0649ab1a 
>   
> security-admin/src/main/java/org/apache/ranger/service/AbstractAuditedResourceService.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java
>  1f2659d4b 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsBaseModelService.java
>  421646d86 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareInDatasetService.java
>  a76cb2a99 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareService.java
>  55c4b3633 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetInProjectService.java
>  62074cfd7 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetService.java
>  a82672a37 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsProjectService.java
>  d70da154e 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java
>  b1b5a841a 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
>  b59b94f43 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java
>  a2929f3c1 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 
> 7e0b29c89 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java
>  39755da1d 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceBase.java
>  586a6b705 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java
>  a4b7616e1 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  3acbfd55d 
>   
> security-admin/src/main/j

Re: Review Request 74953: RANGER-4769: removed code duplication in generation of admin audit logs

2024-05-21 Thread Madhan Neethiraj 


> On May 21, 2024, 4:16 p.m., Abhay Kulkarni wrote:
> > security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java
> > Lines 109 (patched)
> > 
> >
> > This class duplicates many methods in AbstractAuditedResourceService 
> > class. Please review and see if the common methods can be moved to a base 
> > class.

Abhay - both AbstractAuditedResourceService and RangerAuditedModelService deal 
with persisting entity objects (derived from XXDBBase). However 
AbstractAuditedResourceService deals with view classes deriving from 
VXDataObject, while RangerAuditedModelService deals with view classes deriving 
from  RangerBaseModelObject. Given this, carving out few common methods into a 
separate class will likely result in many more classes to be updated. If 
necessary, I suggest tracking that via a separate JIRA.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74953/#review226474
---


On May 21, 2024, 7:03 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74953/
> ---
> 
> (Updated May 21, 2024, 7:03 p.m.)
> 
> 
> Review request for ranger, Anand Nadar, Asit Vadhavkar, Abhay Kulkarni, Mehul 
> Parikh, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, Subhrat Chaudhary, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4769
> https://issues.apache.org/jira/browse/RANGER-4769
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - replaced getTransactionLog() implementation in 13 classes with 
> implementations in following base classes
> -- AbstractAuditedResourceService.createTransactionLog()
> -- RangerAuditedModelService.createTransactionLog()
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 
> 40d4c4043 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 
> 0aa03e7c2 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 
> 9e2f28716 
>   security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java 
> 42943946c 
>   
> security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneRefUpdater.java
>  10bbfcd32 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> 38b95543e 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java d5393603e 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e0623e0c2 
>   security-admin/src/main/java/org/apache/ranger/common/view/VTrxLogAttr.java 
> 8c86a92c6 
>   security-admin/src/main/java/org/apache/ranger/entity/XXTrxLog.java 
> c308fba7b 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4bfaa862c 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> d0649ab1a 
>   
> security-admin/src/main/java/org/apache/ranger/service/AbstractAuditedResourceService.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java
>  1f2659d4b 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsBaseModelService.java
>  421646d86 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareInDatasetService.java
>  a76cb2a99 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareService.java
>  55c4b3633 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetInProjectService.java
>  62074cfd7 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetService.java
>  a82672a37 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsProjectService.java
>  d70da154e 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java
>  b1b5a841a 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
>  b59b94f43 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java
>  a2929f3c1 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 
> 7e0b29c89 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java
>  39755da1d 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceBase.java
>  586a6b705 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java
>  a4b7616e1 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  3acbfd55d 
>   
> security-admin/src/main/j

[jira] [Assigned] (RANGER-4748) Admin audits UI is slow when x_trx_log table has large numer of rows

2024-05-21 Thread Madhan Neethiraj (Jira) 


 [ 
https://issues.apache.org/jira/browse/RANGER-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj reassigned RANGER-4748:


Assignee: Madhan Neethiraj

> Admin audits UI is slow when x_trx_log table has large numer of rows 
> -
>
> Key: RANGER-4748
> URL: https://issues.apache.org/jira/browse/RANGER-4748
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
>
> Admin tab in Ranger audit UI lists changes performed on 
> policies/users/groups/security-zones/service - one row for each object. 
> Details of changes to an object (like old and new value of attributes) are 
> available in a dialog box that pops up on clicking the row.
> API to retrieve list of admin audit log can take a long time when large 
> number of rows exists in that database table that stores change details i.e. 
> table named x_trx_log. This is due to the use of database view, vx_trx_log, 
> on top of table x_trx_log, which performs a group-by operation that would 
> require a full-table scan. This view is necessary since x_trx_log can have 
> multiple rows for one change to an object - one row for each changed 
> attribute.
> To avoid this issue, one option to consider is store changes to all 
> attributes of an object in a single row (instead of one row per changed 
> attribute). This will eliminate the need for a view that performs group by.
>  
> CC: [~siddheshphatak] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)