[jira] [Created] (RANGER-4814) Ranger - Upgrade Aircompressor to 0.27

[Dineshkumar Yadav (Jira)]

Dineshkumar Yadav created RANGER-4814:
-

 Summary: Ranger - Upgrade Aircompressor to 0.27
 Key: RANGER-4814
 URL: https://issues.apache.org/jira/browse/RANGER-4814
 Project: Ranger
  Issue Type: Task
  Components: Ranger
Reporter: Dineshkumar Yadav
Assignee: Dineshkumar Yadav


Ranger - Upgrade Aircompressor to 0.27



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 75033: RANGER-4811: updated Trino plugin code to be compliant with coding standards of Trino project

[Pradeep Agrawal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75033/#review226523
---


Ship it!




Ship It!

- Pradeep Agrawal


On June 6, 2024, 9:13 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75033/
> ---
> 
> (Updated June 6, 2024, 9:13 p.m.)
> 
> 
> Review request for ranger, Abhishek  Kumar, Fateh Singh, Abhay Kulkarni, 
> Mugdha Varadkar, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4811
> https://issues.apache.org/jira/browse/RANGER-4811
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Trino project has several requirements for the code in their repo, including:
> - placement of '{' in different contexts
> - ordering of items in pom.xml
> - use of white spaces
> 
> This patch has updates to the Trino plugin to be complaint with such 
> requirements.
> 
> 
> Diffs
> -
> 
>   plugin-trino/pom.xml 1cd35e987 
>   
> plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java
>  c440bf394 
>   
> plugin-trino/src/main/java/org/apache/ranger/services/trino/RangerServiceTrino.java
>  bead9e0c9 
>   
> plugin-trino/src/main/java/org/apache/ranger/services/trino/client/TrinoClient.java
>  1567b2d1d 
>   
> plugin-trino/src/main/java/org/apache/ranger/services/trino/client/TrinoConnectionManager.java
>  6afd8f417 
>   
> plugin-trino/src/main/java/org/apache/ranger/services/trino/client/TrinoResourceManager.java
>  2d32068a6 
>   
> plugin-trino/src/test/java/org/apache/ranger/authorization/trino/authorizer/RangerAdminClientImpl.java
>  af74fc642 
>   
> plugin-trino/src/test/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlTest.java
>  eda87db4e 
>   ranger-trino-plugin-shim/pom.xml 9e166dd1e 
>   
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerConfig.java
>  8fc6d5c1b 
>   
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java
>  10418dabb 
>   
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlFactory.java
>  2d694ac17 
>   
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/TrinoRangerPlugin.java
>  aa6ce8620 
> 
> 
> Diff: https://reviews.apache.org/r/75033/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that the updated plugin code builds in Trino repo
> - verified using docker setup that Trino server starts successfully with the 
> updated Trino plugin, and the plugin enforces Ranger policies
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[jira] [Assigned] (RANGER-4813) update audit UI to retrieve V2 trx log record

[Abhishek (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek reassigned RANGER-4813:


Assignee: Abhishek

> update audit UI to retrieve V2 trx log record
> -
>
> Key: RANGER-4813
> URL: https://issues.apache.org/jira/browse/RANGER-4813
> Project: Ranger
>  Issue Type: Sub-task
>  Components: admin
>Reporter: Madhan Neethiraj
>Assignee: Abhishek
>Priority: Major
>
> Currently admin audit UI retrieves multiple V1 trx logs to gather details of 
> an update (REST API: service/assets//report/\{transactionId}). This should be 
> optimized to retrieve a single V2 trx log record (introduced in RANGER-4803) 
> to render in UI. A new API should be added to retrieve V2 trx log record.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (RANGER-4812) database schema patch to create x_trx_log_v2 table

[Abhishek (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek reassigned RANGER-4812:


Assignee: Abhishek

> database schema patch to create x_trx_log_v2 table
> --
>
> Key: RANGER-4812
> URL: https://issues.apache.org/jira/browse/RANGER-4812
> Project: Ranger
>  Issue Type: Sub-task
>  Components: admin
>Reporter: Madhan Neethiraj
>Assignee: Abhishek
>Priority: Major
>
> RANGER-4803 introduced new table named x_trx_log_v2. A database schema patch 
> will be needed to create x_trx_log_v2 table in existing Ranger deployments.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4813) update audit UI to retrieve V2 trx log record

[Madhan Neethiraj (Jira)]

Madhan Neethiraj created RANGER-4813:


 Summary: update audit UI to retrieve V2 trx log record
 Key: RANGER-4813
 URL: https://issues.apache.org/jira/browse/RANGER-4813
 Project: Ranger
  Issue Type: Sub-task
  Components: admin
Reporter: Madhan Neethiraj


Currently admin audit UI retrieves multiple V1 trx logs to gather details of an 
update (REST API: service/assets//report/\{transactionId}). This should be 
optimized to retrieve a single V2 trx log record (introduced in RANGER-4803) to 
render in UI. A new API should be added to retrieve V2 trx log record.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4812) database schema patch to create x_trx_log_v2 table

[Madhan Neethiraj (Jira)]

Madhan Neethiraj created RANGER-4812:


 Summary: database schema patch to create x_trx_log_v2 table
 Key: RANGER-4812
 URL: https://issues.apache.org/jira/browse/RANGER-4812
 Project: Ranger
  Issue Type: Sub-task
  Components: admin
Reporter: Madhan Neethiraj


RANGER-4803 introduced new table named x_trx_log_v2. A database schema patch 
will be needed to create x_trx_log_v2 table in existing Ranger deployments.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 75012: RANGER-4803: create a single x_trx_log_v2 record instead of multiple x_trx_log records

[Abhay Kulkarni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75012/#review226522
---


Ship it!




Ship It!

- Abhay Kulkarni


On June 7, 2024, 12:42 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75012/
> ---
> 
> (Updated June 7, 2024, 12:42 a.m.)
> 
> 
> Review request for ranger, Abhishek  Kumar, Asit Vadhavkar, Fateh Singh, 
> Abhay Kulkarni, Mehul Parikh, Ramesh Mani, Siddhesh Phatak, Sailaja 
> Polavarapu, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4803
> https://issues.apache.org/jira/browse/RANGER-4803
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - introduced table x_trx_log_v2 to store object change details, including all 
> changed attributes
> - updated to create a single x_trx_log_v2 row instead of multiple rows in 
> x_trx_log
> - updated APIs used by UI to retrieve admin audit logs to read from 
> x_trx_log_v2
> -- /assets/report
> -- /assets/report/{transactionId}
> - removed classes that reference x_trx_log table: XTrxLogService, 
> XTrxLogServiceBase, XXTrxLogDao, XXTrxLogUpdateUtil
> 
> 
> Diffs
> -
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 
> fa72ef2ea 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 772514610 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> e177d44d7 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  32cfed7ae 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 831aad66d 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 6f1bcc40e 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 
> 5534c8056 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> 7ac16a9ee 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 6bcc19c0c 
>   security-admin/src/main/java/org/apache/ranger/biz/XAuditMgrBase.java 
> c90296cf6 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 3a1cb17f2 
>   
> security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java
>  a9ec94e1c 
>   security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
> 08bcfd57b 
>   security-admin/src/main/java/org/apache/ranger/db/XXTrxLogDao.java 
> 13372ab4a 
>   security-admin/src/main/java/org/apache/ranger/db/XXTrxLogV2Dao.java 
> PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/entity/XXTrxLogV2.java 
> PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/entity/view/VXXTrxLog.java 
> 1dec97747 
>   
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/XXTrxLogUpdateUtil.java
>  cc30fde9b 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 
> be077e789 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java b35b8af65 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> cc762aefa 
>   security-admin/src/main/java/org/apache/ranger/rest/XAuditREST.java 
> a7047e897 
>   
> security-admin/src/main/java/org/apache/ranger/service/AbstractAuditedResourceService.java
>  b57979805 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java
>  b8c4fb31c 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerTrxLogV2Service.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java
>  7856671a2 
>   security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 
> 676552e6e 
>   
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogServiceBase.java
>  d6f23db40 
>   security-admin/src/main/java/org/apache/ranger/view/VXTrxLogV2.java 
> PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/view/VXTrxLogV2List.java 
> PRE-CREATION 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml bb93947b5 
>   security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 
> 23fbb8494 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java 
> 5cf21d5b0 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXKeyREST.java 
> c0a858d81 
> 
> 
> Diff: https://reviews.apache.org/r/75012/diff/6/
> 
> 
> Testing
> ---
> 
> - verified that admin audits are stored in x_trx_log_v2, one entry for each 
> object
> - Admin audits UI continues to work with data in x_trx_log_v2 table
> - verified that all existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 75012: RANGER-4803: create a single x_trx_log_v2 record instead of multiple x_trx_log records

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75012/
---

(Updated June 7, 2024, 12:42 a.m.)


Review request for ranger, Abhishek  Kumar, Asit Vadhavkar, Fateh Singh, Abhay 
Kulkarni, Mehul Parikh, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, and 
Subhrat Chaudhary.


Changes
---

removed x_trx_log table and vx_trx_log view


Bugs: RANGER-4803
https://issues.apache.org/jira/browse/RANGER-4803


Repository: ranger


Description
---

- introduced table x_trx_log_v2 to store object change details, including all 
changed attributes
- updated to create a single x_trx_log_v2 row instead of multiple rows in 
x_trx_log
- updated APIs used by UI to retrieve admin audit logs to read from x_trx_log_v2
-- /assets/report
-- /assets/report/{transactionId}
- removed classes that reference x_trx_log table: XTrxLogService, 
XTrxLogServiceBase, XXTrxLogDao, XXTrxLogUpdateUtil


Diffs (updated)
-

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql fa72ef2ea 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
772514610 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
e177d44d7 
  
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 
32cfed7ae 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
831aad66d 
  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 6f1bcc40e 
  security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 
5534c8056 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
7ac16a9ee 
  security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 6bcc19c0c 
  security-admin/src/main/java/org/apache/ranger/biz/XAuditMgrBase.java 
c90296cf6 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 3a1cb17f2 
  
security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java
 a9ec94e1c 
  security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
08bcfd57b 
  security-admin/src/main/java/org/apache/ranger/db/XXTrxLogDao.java 13372ab4a 
  security-admin/src/main/java/org/apache/ranger/db/XXTrxLogV2Dao.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/entity/XXTrxLogV2.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/entity/view/VXXTrxLog.java 
1dec97747 
  
security-admin/src/main/java/org/apache/ranger/patch/cliutil/XXTrxLogUpdateUtil.java
 cc30fde9b 
  security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java be077e789 
  security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java b35b8af65 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
cc762aefa 
  security-admin/src/main/java/org/apache/ranger/rest/XAuditREST.java a7047e897 
  
security-admin/src/main/java/org/apache/ranger/service/AbstractAuditedResourceService.java
 b57979805 
  
security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java
 b8c4fb31c 
  
security-admin/src/main/java/org/apache/ranger/service/RangerTrxLogV2Service.java
 PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java 
7856671a2 
  security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 
676552e6e 
  
security-admin/src/main/java/org/apache/ranger/service/XTrxLogServiceBase.java 
d6f23db40 
  security-admin/src/main/java/org/apache/ranger/view/VXTrxLogV2.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/view/VXTrxLogV2List.java 
PRE-CREATION 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml bb93947b5 
  security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 
23fbb8494 
  security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java 
5cf21d5b0 
  security-admin/src/test/java/org/apache/ranger/rest/TestXKeyREST.java 
c0a858d81 


Diff: https://reviews.apache.org/r/75012/diff/6/

Changes: https://reviews.apache.org/r/75012/diff/5-6/


Testing
---

- verified that admin audits are stored in x_trx_log_v2, one entry for each 
object
- Admin audits UI continues to work with data in x_trx_log_v2 table
- verified that all existing tests pass successfully


Thanks,

Madhan Neethiraj

Re: Review Request 75012: RANGER-4803: create a single x_trx_log_v2 record instead of multiple x_trx_log records

[Madhan Neethiraj]

> On June 6, 2024, 9:17 p.m., Abhay Kulkarni wrote:
> > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java
> > Lines 1172 (patched)
> > 
> >
> > Why would xTrxLog be null? Please review. Also, is it expected that 
> > only one transaction will be created for each user action? If so, does this 
> > API need to take a list of transaction logs?

xTrxLog will not be null here. Updated to address this.

There are scenarios where a single action from an user can result multiple 
records; for example, changing resources in a data-share will require recording 
the impact on all associated datasets. We should revisit though, to find if 
there are better ways to capture such scenario. I suggest to retain current 
signature till then.


> On June 6, 2024, 9:17 p.m., Abhay Kulkarni wrote:
> > security-admin/src/main/java/org/apache/ranger/service/AbstractAuditedResourceService.java
> > Line 106 (original), 121 (patched)
> > 
> >
> > If only one XXTrxLogV2 object is created by every caller, then consider 
> > changing the return type to XXTrxLogV2 (rather than a list of XXTrxLogV2).
> > 
> > Please review other APIs that accept (or return) list of XXTrxLogV2 
> > objects to see they are necessary here and in RangerAuditedModelService 
> > class.

Multiple trxLog entries might be created for a given change (see the comment in 
RangerBizUtil.java:1172).


> On June 6, 2024, 9:17 p.m., Abhay Kulkarni wrote:
> > security-admin/src/main/java/org/apache/ranger/service/RangerTrxLogV2Service.java
> > Lines 108 (patched)
> > 
> >
> > Please see if uidNameCache needs to be created here. There may be 
> > always only one VXTrxLogV2 object for a given transactionId.

There could be multiple trxLog entries for a given transaction ID (see the 
comment in RangerBizUtil.java:1172). Hence caching userId=>name mapping will 
help avoid excessive calls to the database.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75012/#review226519
---


On June 6, 2024, 11:15 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75012/
> ---
> 
> (Updated June 6, 2024, 11:15 p.m.)
> 
> 
> Review request for ranger, Abhishek  Kumar, Asit Vadhavkar, Fateh Singh, 
> Abhay Kulkarni, Mehul Parikh, Ramesh Mani, Siddhesh Phatak, Sailaja 
> Polavarapu, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4803
> https://issues.apache.org/jira/browse/RANGER-4803
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - introduced table x_trx_log_v2 to store object change details, including all 
> changed attributes
> - updated to create a single x_trx_log_v2 row instead of multiple rows in 
> x_trx_log
> - updated APIs used by UI to retrieve admin audit logs to read from 
> x_trx_log_v2
> -- /assets/report
> -- /assets/report/{transactionId}
> - removed classes that reference x_trx_log table: XTrxLogService, 
> XTrxLogServiceBase, XXTrxLogDao, XXTrxLogUpdateUtil
> 
> 
> Diffs
> -
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 
> fa72ef2ea 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 772514610 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> e177d44d7 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  32cfed7ae 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 831aad66d 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 6f1bcc40e 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 
> 5534c8056 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> 7ac16a9ee 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 6bcc19c0c 
>   security-admin/src/main/java/org/apache/ranger/biz/XAuditMgrBase.java 
> c90296cf6 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 3a1cb17f2 
>   
> security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java
>  a9ec94e1c 
>   security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
> 08bcfd57b 
>   security-admin/src/main/java/org/apache/ranger/db/XXTrxLogDao.java 
> 13372ab4a 
>   security-admin/src/main/java/org/apache/ranger/db/XXTrxLogV2Dao.java 
> PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/entity/XXTrxLogV2.java 
> PRE-CREATION 
>   
> 

Re: Review Request 75012: RANGER-4803: create a single x_trx_log_v2 record instead of multiple x_trx_log records

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75012/
---

(Updated June 6, 2024, 11:15 p.m.)


Review request for ranger, Abhishek  Kumar, Asit Vadhavkar, Fateh Singh, Abhay 
Kulkarni, Mehul Parikh, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, and 
Subhrat Chaudhary.


Changes
---

addressed review comments


Bugs: RANGER-4803
https://issues.apache.org/jira/browse/RANGER-4803


Repository: ranger


Description
---

- introduced table x_trx_log_v2 to store object change details, including all 
changed attributes
- updated to create a single x_trx_log_v2 row instead of multiple rows in 
x_trx_log
- updated APIs used by UI to retrieve admin audit logs to read from x_trx_log_v2
-- /assets/report
-- /assets/report/{transactionId}
- removed classes that reference x_trx_log table: XTrxLogService, 
XTrxLogServiceBase, XXTrxLogDao, XXTrxLogUpdateUtil


Diffs (updated)
-

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql fa72ef2ea 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
772514610 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
e177d44d7 
  
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 
32cfed7ae 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
831aad66d 
  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 6f1bcc40e 
  security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 
5534c8056 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
7ac16a9ee 
  security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 6bcc19c0c 
  security-admin/src/main/java/org/apache/ranger/biz/XAuditMgrBase.java 
c90296cf6 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 3a1cb17f2 
  
security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java
 a9ec94e1c 
  security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
08bcfd57b 
  security-admin/src/main/java/org/apache/ranger/db/XXTrxLogDao.java 13372ab4a 
  security-admin/src/main/java/org/apache/ranger/db/XXTrxLogV2Dao.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/entity/XXTrxLogV2.java 
PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/patch/cliutil/XXTrxLogUpdateUtil.java
 cc30fde9b 
  security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java be077e789 
  security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java b35b8af65 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
cc762aefa 
  security-admin/src/main/java/org/apache/ranger/rest/XAuditREST.java a7047e897 
  
security-admin/src/main/java/org/apache/ranger/service/AbstractAuditedResourceService.java
 b57979805 
  
security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java
 b8c4fb31c 
  
security-admin/src/main/java/org/apache/ranger/service/RangerTrxLogV2Service.java
 PRE-CREATION 
  
security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java 
7856671a2 
  security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 
676552e6e 
  
security-admin/src/main/java/org/apache/ranger/service/XTrxLogServiceBase.java 
d6f23db40 
  security-admin/src/main/java/org/apache/ranger/view/VXTrxLogV2.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/view/VXTrxLogV2List.java 
PRE-CREATION 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml bb93947b5 
  security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 
23fbb8494 
  security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java 
5cf21d5b0 
  security-admin/src/test/java/org/apache/ranger/rest/TestXKeyREST.java 
c0a858d81 


Diff: https://reviews.apache.org/r/75012/diff/5/

Changes: https://reviews.apache.org/r/75012/diff/4-5/


Testing
---

- verified that admin audits are stored in x_trx_log_v2, one entry for each 
object
- Admin audits UI continues to work with data in x_trx_log_v2 table
- verified that all existing tests pass successfully


Thanks,

Madhan Neethiraj

[jira] [Updated] (RANGER-4811) update Trino plugin code to be compliant with coding standards of Trino project

[Madhan Neethiraj (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated RANGER-4811:
-
Attachment: RANGER-4811.patch

> update Trino plugin code to be compliant with coding standards of Trino 
> project
> ---
>
> Key: RANGER-4811
> URL: https://issues.apache.org/jira/browse/RANGER-4811
> Project: Ranger
>  Issue Type: Sub-task
>  Components: plugins
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: RANGER-4811.patch
>
>
> Trino project has several requirements for the code in Trino repo, including 
> placement of '{' in different contexts, ordering of items in pom.xml, use of 
> white spaces, and more. This Jira tracks preparing the Trino plugin 
> implementation to be compliant with coding standards of Trino project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 75012: RANGER-4803: create a single x_trx_log_v2 record instead of multiple x_trx_log records

[Abhay Kulkarni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75012/#review226519
---




security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java
Lines 1172 (patched)


Why would xTrxLog be null? Please review. Also, is it expected that only 
one transaction will be created for each user action? If so, does this API need 
to take a list of transaction logs?



security-admin/src/main/java/org/apache/ranger/service/AbstractAuditedResourceService.java
Line 106 (original), 121 (patched)


If only one XXTrxLogV2 object is created by every caller, then consider 
changing the return type to XXTrxLogV2 (rather than a list of XXTrxLogV2).

Please review other APIs that accept (or return) list of XXTrxLogV2 objects 
to see they are necessary here and in RangerAuditedModelService class.



security-admin/src/main/java/org/apache/ranger/service/RangerTrxLogV2Service.java
Lines 108 (patched)


Please see if uidNameCache needs to be created here. There may be always 
only one VXTrxLogV2 object for a given transactionId.


- Abhay Kulkarni


On May 26, 2024, 7:37 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75012/
> ---
> 
> (Updated May 26, 2024, 7:37 a.m.)
> 
> 
> Review request for ranger, Abhishek  Kumar, Asit Vadhavkar, Fateh Singh, 
> Abhay Kulkarni, Mehul Parikh, Ramesh Mani, Siddhesh Phatak, Sailaja 
> Polavarapu, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4803
> https://issues.apache.org/jira/browse/RANGER-4803
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - introduced table x_trx_log_v2 to store object change details, including all 
> changed attributes
> - updated to create a single x_trx_log_v2 row instead of multiple rows in 
> x_trx_log
> - updated APIs used by UI to retrieve admin audit logs to read from 
> x_trx_log_v2
> -- /assets/report
> -- /assets/report/{transactionId}
> - removed classes that reference x_trx_log table: XTrxLogService, 
> XTrxLogServiceBase, XXTrxLogDao, XXTrxLogUpdateUtil
> 
> 
> Diffs
> -
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 
> fa72ef2ea 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 772514610 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> e177d44d7 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  32cfed7ae 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 831aad66d 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 6f1bcc40e 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 
> 5534c8056 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> 7ac16a9ee 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 6bcc19c0c 
>   security-admin/src/main/java/org/apache/ranger/biz/XAuditMgrBase.java 
> c90296cf6 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 3a1cb17f2 
>   
> security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java
>  a9ec94e1c 
>   security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
> 08bcfd57b 
>   security-admin/src/main/java/org/apache/ranger/db/XXTrxLogDao.java 
> 13372ab4a 
>   security-admin/src/main/java/org/apache/ranger/db/XXTrxLogV2Dao.java 
> PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/entity/XXTrxLogV2.java 
> PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/XXTrxLogUpdateUtil.java
>  cc30fde9b 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 
> be077e789 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java b35b8af65 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> cc762aefa 
>   security-admin/src/main/java/org/apache/ranger/rest/XAuditREST.java 
> a7047e897 
>   
> security-admin/src/main/java/org/apache/ranger/service/AbstractAuditedResourceService.java
>  b57979805 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java
>  b8c4fb31c 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerTrxLogV2Service.java
>  PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java
>  7856671a2 
>   security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 
> 676552e6e 
>   
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogServiceBase.java

[jira] [Updated] (RANGER-4811) update Trino plugin code to be compliant with coding standards of Trino project

[Madhan Neethiraj (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated RANGER-4811:
-
Summary: update Trino plugin code to be compliant with coding standards of 
Trino project  (was: updated Trino plugin code to be compliant with coding 
standards for Trino project)

> update Trino plugin code to be compliant with coding standards of Trino 
> project
> ---
>
> Key: RANGER-4811
> URL: https://issues.apache.org/jira/browse/RANGER-4811
> Project: Ranger
>  Issue Type: Sub-task
>  Components: plugins
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
>
> Trino project has several requirements for the code in Trino repo, including 
> placement of '{' in different contexts, ordering of items in pom.xml, use of 
> white spaces, and more. This Jira tracks preparing the Trino plugin 
> implementation to be compliant with coding standards of Trino project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 75033: RANGER-4811: updated Trino plugin code to be compliant with coding standards of Trino project

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75033/
---

(Updated June 6, 2024, 9:13 p.m.)


Review request for ranger, Abhishek  Kumar, Fateh Singh, Abhay Kulkarni, Mugdha 
Varadkar, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan 
Periasamy.


Summary (updated)
-

RANGER-4811: updated Trino plugin code to be compliant with coding standards of 
Trino project


Bugs: RANGER-4811
https://issues.apache.org/jira/browse/RANGER-4811


Repository: ranger


Description
---

Trino project has several requirements for the code in their repo, including:
- placement of '{' in different contexts
- ordering of items in pom.xml
- use of white spaces

This patch has updates to the Trino plugin to be complaint with such 
requirements.


Diffs
-

  plugin-trino/pom.xml 1cd35e987 
  
plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java
 c440bf394 
  
plugin-trino/src/main/java/org/apache/ranger/services/trino/RangerServiceTrino.java
 bead9e0c9 
  
plugin-trino/src/main/java/org/apache/ranger/services/trino/client/TrinoClient.java
 1567b2d1d 
  
plugin-trino/src/main/java/org/apache/ranger/services/trino/client/TrinoConnectionManager.java
 6afd8f417 
  
plugin-trino/src/main/java/org/apache/ranger/services/trino/client/TrinoResourceManager.java
 2d32068a6 
  
plugin-trino/src/test/java/org/apache/ranger/authorization/trino/authorizer/RangerAdminClientImpl.java
 af74fc642 
  
plugin-trino/src/test/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlTest.java
 eda87db4e 
  ranger-trino-plugin-shim/pom.xml 9e166dd1e 
  
ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerConfig.java
 8fc6d5c1b 
  
ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java
 10418dabb 
  
ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlFactory.java
 2d694ac17 
  
ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/TrinoRangerPlugin.java
 aa6ce8620 


Diff: https://reviews.apache.org/r/75033/diff/1/


Testing
---

- verified that the updated plugin code builds in Trino repo
- verified using docker setup that Trino server starts successfully with the 
updated Trino plugin, and the plugin enforces Ranger policies


Thanks,

Madhan Neethiraj

[jira] [Created] (RANGER-4811) updated Trino plugin code to be compliant with coding standards for Trino project

[Madhan Neethiraj (Jira)]

Madhan Neethiraj created RANGER-4811:


 Summary: updated Trino plugin code to be compliant with coding 
standards for Trino project
 Key: RANGER-4811
 URL: https://issues.apache.org/jira/browse/RANGER-4811
 Project: Ranger
  Issue Type: Sub-task
  Components: plugins
Reporter: Madhan Neethiraj
Assignee: Madhan Neethiraj


Trino project has several requirements for the code in Trino repo, including 
placement of '{' in different contexts, ordering of items in pom.xml, use of 
white spaces, and more. This Jira tracks preparing the Trino plugin 
implementation to be compliant with coding standards of Trino project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4810) Move Trino authorizer implementation from Ranger git repo to Trino repo

[Madhan Neethiraj (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated RANGER-4810:
-
Description: 
Moving Trino authorizer implementation from Ranger git repo to Trino repo has 
several advantages, including:
 # Keeping the authorizer in sync with the updates in SystemAccessControl 
interface. For example, following changes in the latest Trino repo are not 
compatible with the Trino authorizer in Ranger repo:
 ## SystemAccessControl.checkCanAccessCatalog(): removed
 ## SystemAccessControl.getRowFilter(): replaced with getRowFilters()
 ## SystemAccessControl.getColumnMasks(): replaced with getColumnMask()
 ## SystemAccessControl.checkCanSetSystemSessionProperty(): removed
 ## SystemAccessControl.checkCanImpersonateUser(): signature changed
 ## SystemAccessControl.checkCanAccessCatalog(): removed
 ## SystemAccessControl.checkCanCreateSchema(): signature changed
 ## SystemAccessControl.checkCanExecuteQuery(): removed
 ## SystemAccessControl.checkCanViewQueryOwnedBy(): removed
 ## SystemAccessControl.filterViewQueryOwnedBy(): signature changed
 ## SystemAccessControl.checkCanKillQueryOwnedBy(): removed
 ## SystemAccessControl.checkCanGrantExecuteFunctionPrivilege(): 
removed/replaced
 ## SystemAccessControl.checkCanExecuteFunction(): signature changed
 ## ViewExpression(): constructor changed
 ## AccessDeniedException.denyGrantExecuteFunctionPrivilege(): removed
 # Trino requires more recent JDK versions (currently JDK 22) than Ranger repo 
(which still supports JDK 8). Trino authorizer is built separately, as a second 
phase, in Ranger repo using higher JDK versions. Moving the authorizer to Trino 
repo will avoid this additional step.

 

Trino seems to have a class loader isolation in place for its plugins, which 
can eliminate the need for the shim layer used in Ranger plugin. This needs to 
be considered along with this move.

Though the authorizer implementation would move to Trino repp, Ranger repo will 
continue to have modules used in Ranger admin server for resource look up and 
default policy creation (class RangerServiceTrino).

  was:
Moving Trino authorizer implementation from Ranger git repo to Trino repo has 
several advantages, including:
 # Keeping the authorizer in sync with the updates in SystemAccessControl 
interface. For example, following changes in the latest Trino repo are not 
compatible with the Trino authorizer in Ranger repo:
 ## SystemAccessControl.checkCanAccessCatalog(): removed
 ## 
SystemAccessControl.getRowFilter(): replaced with getRowFilters()
 ## 
 SystemAccessControl.getColumnMasks(): replaced with getColumnMask()
 ## 
SystemAccessControl.checkCanSetSystemSessionProperty(): removed
 ## 
SystemAccessControl.checkCanImpersonateUser(): signature changed
 ## 
SystemAccessControl.checkCanAccessCatalog(): removed
 ## SystemAccessControl.checkCanCreateSchema(): signature changed
 ## 
SystemAccessControl.checkCanExecuteQuery(): removed
 ## 
SystemAccessControl.checkCanViewQueryOwnedBy(): removed
 ## 
SystemAccessControl.filterViewQueryOwnedBy(): signature changed
 ## 
SystemAccessControl.checkCanKillQueryOwnedBy(): removed
 ## 
SystemAccessControl.checkCanGrantExecuteFunctionPrivilege(): removed/replaced
 ## 
SystemAccessControl.checkCanExecuteFunction(): signature changed
 ## 
ViewExpression(): constructor changed
 ## 
AccessDeniedException.denyGrantExecuteFunctionPrivilege(): removed
 # Trino requires more recent JDK versions (currently JDK 22) than Ranger repo 
(which still supports JDK 8). Trino authorizer is built separately, as a second 
phase, in Ranger repo using higher JDK versions. Moving the authorizer to Trino 
repo will avoid this additional step.

 

Trino seems to have a class loader isolation in place for its plugins, which 
can eliminate the need for the shim layer used in Ranger plugin. This needs to 
be considered along with this move.

Though the authorizer implementation would move to Trino repp, Ranger repo will 
continue to have modules used in Ranger admin server for resource look up and 
default policy creation (class RangerServiceTrino).


> Move Trino authorizer implementation from Ranger git repo to Trino repo
> ---
>
> Key: RANGER-4810
> URL: https://issues.apache.org/jira/browse/RANGER-4810
> Project: Ranger
>  Issue Type: Improvement
>  Components: plugins
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
>
> Moving Trino authorizer implementation from Ranger git repo to Trino repo has 
> several advantages, including:
>  # Keeping the authorizer in sync with the updates in SystemAccessControl 
> interface. For example, following changes in the latest Trino repo are not 
> compatible with the Trino authorizer in Ranger repo:
>  ## 

[jira] [Created] (RANGER-4810) Move Trino authorizer implementation from Ranger git repo to Trino repo

[Madhan Neethiraj (Jira)]

Madhan Neethiraj created RANGER-4810:


 Summary: Move Trino authorizer implementation from Ranger git repo 
to Trino repo
 Key: RANGER-4810
 URL: https://issues.apache.org/jira/browse/RANGER-4810
 Project: Ranger
  Issue Type: Improvement
  Components: plugins
Reporter: Madhan Neethiraj
Assignee: Madhan Neethiraj


Moving Trino authorizer implementation from Ranger git repo to Trino repo has 
several advantages, including:
 # Keeping the authorizer in sync with the updates in SystemAccessControl 
interface. For example, following changes in the latest Trino repo are not 
compatible with the Trino authorizer in Ranger repo:
 ## SystemAccessControl.checkCanAccessCatalog(): removed
 ## 
SystemAccessControl.getRowFilter(): replaced with getRowFilters()
 ## 
 SystemAccessControl.getColumnMasks(): replaced with getColumnMask()
 ## 
SystemAccessControl.checkCanSetSystemSessionProperty(): removed
 ## 
SystemAccessControl.checkCanImpersonateUser(): signature changed
 ## 
SystemAccessControl.checkCanAccessCatalog(): removed
 ## SystemAccessControl.checkCanCreateSchema(): signature changed
 ## 
SystemAccessControl.checkCanExecuteQuery(): removed
 ## 
SystemAccessControl.checkCanViewQueryOwnedBy(): removed
 ## 
SystemAccessControl.filterViewQueryOwnedBy(): signature changed
 ## 
SystemAccessControl.checkCanKillQueryOwnedBy(): removed
 ## 
SystemAccessControl.checkCanGrantExecuteFunctionPrivilege(): removed/replaced
 ## 
SystemAccessControl.checkCanExecuteFunction(): signature changed
 ## 
ViewExpression(): constructor changed
 ## 
AccessDeniedException.denyGrantExecuteFunctionPrivilege(): removed
 # Trino requires more recent JDK versions (currently JDK 22) than Ranger repo 
(which still supports JDK 8). Trino authorizer is built separately, as a second 
phase, in Ranger repo using higher JDK versions. Moving the authorizer to Trino 
repo will avoid this additional step.

 

Trino seems to have a class loader isolation in place for its plugins, which 
can eliminate the need for the shim layer used in Ranger plugin. This needs to 
be considered along with this move.

Though the authorizer implementation would move to Trino repp, Ranger repo will 
continue to have modules used in Ranger admin server for resource look up and 
default policy creation (class RangerServiceTrino).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (RANGER-4774) Ranger react UI some modules shown hardcoded time zone string "Indian Standard Time"

[Dhaval Rajpara (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852741#comment-17852741
 ] 

Dhaval Rajpara commented on RANGER-4774:


Patch committed to [Apache 
master|https://github.com/apache/ranger/commit/65fad025d908b280440dbca4c7a61de3fa8ef943]
 branch.

> Ranger react UI some modules shown hardcoded  time zone string "Indian 
> Standard Time"
> -
>
> Key: RANGER-4774
> URL: https://issues.apache.org/jira/browse/RANGER-4774
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Dhaval Rajpara
>Assignee: Dhaval Rajpara
>Priority: Major
> Attachments: 0001-RANGER-4774.patch
>
>
> 1) UI popup showing details of an admin audit log seems to have hardcoded 
> string “Indian Standard Time” 
> 2)Some logs table header also have hardcoded string “Indian Standard Time” 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4774) Ranger react UI some modules shown hardcoded time zone string "Indian Standard Time"

[Dhaval Rajpara (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dhaval Rajpara updated RANGER-4774:
---
Fix Version/s: 3.0.0

> Ranger react UI some modules shown hardcoded  time zone string "Indian 
> Standard Time"
> -
>
> Key: RANGER-4774
> URL: https://issues.apache.org/jira/browse/RANGER-4774
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Dhaval Rajpara
>Assignee: Dhaval Rajpara
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: 0001-RANGER-4774.patch
>
>
> 1) UI popup showing details of an admin audit log seems to have hardcoded 
> string “Indian Standard Time” 
> 2)Some logs table header also have hardcoded string “Indian Standard Time” 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74976: RANGER-4782: Implement best coding practices for validating service configs

[Rakesh Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74976/
---

(Updated June 6, 2024, 11:09 a.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Mehul 
Parikh, Pradeep Agrawal, and sanket shelar.


Changes
---

Addressed review comments.


Bugs: RANGER-4782
https://issues.apache.org/jira/browse/RANGER-4782


Repository: ranger


Description
---

Implement best coding practices for validating service configs


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java b9d51602e 
  
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx
 668de52e7 


Diff: https://reviews.apache.org/r/74976/diff/5/

Changes: https://reviews.apache.org/r/74976/diff/4-5/


Testing
---

Validated Service Connection failed, when using 'localhost' or '127.0.0.1' as 
the hostname in the service configuration.

Tested If a service configuration contains a null value, it won't be added to 
the service.


Thanks,

Rakesh Gupta

Re: Review Request 75013: RANGER-4774 : Ranger react UI some modules shown hardcoded time zone string "Indian Standard Time"

[Brijesh Bhalala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75013/#review226516
---


Ship it!




Ship It!

- Brijesh Bhalala


On June 6, 2024, 11:07 a.m., Dhaval Rajpara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75013/
> ---
> 
> (Updated June 6, 2024, 11:07 a.m.)
> 
> 
> Review request for ranger, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, 
> Kishor Gollapalliwar, Madhan Neethiraj, Mugdha Varadkar, Pradeep Agrawal, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4774
> https://issues.apache.org/jira/browse/RANGER-4774
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> 1) UI popup showing details of an admin audit log seems to have hardcoded 
> string “Indian Standard Time” 
> 2)Some logs table header also have hardcoded string “Indian Standard Time”
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js d189e4aeb 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx
>  47407fd08 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx
>  9ebc90290 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx
>  c67369e84 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx
>  6b2143adb 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx
>  d7aabf8dc 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx
>  08c0082c1 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx
>  5f3552954 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx
>  1372f2258 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx
>  aa358fd95 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx
>  81b7ce486 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx
>  d7ee72db9 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx
>  a2b24f089 
>   
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx
>  105659759 
> 
> 
> Diff: https://reviews.apache.org/r/75013/diff/1/
> 
> 
> Testing
> ---
> 
> In the Ranger React UI, several modules displayed hardcoded time zone strings 
> ("Indian Standard Time"). Tests were conducted to ensure audit logs across 
> different operations display the correct timestamps reflecting the 
> appropriate time zone. The verification included:
> 
> 1) Services: Timestamps for created, updated, and deleted services.
> 2) Policies: Timestamps for created, updated, and deleted access, masking, 
> row-level, and tag policies.
> 3) Users/Groups/Roles: Timestamps for created, updated, and deleted users, 
> groups, and roles, including user password changes.
> 4)Security Zones: Timestamps for created, updated, and deleted security zones.
> 5) Audits: Correct time zone display in the admin, login session, and plugins 
> tabs, as well as Usersync's sync time.
> 6) Export/Import: Correct times and time zones in logs for exported and 
> imported policies.
> 7) Reports: Export times in various file formats adapting to the selected 
> time zone, and consistency of log times across different time zones.
> 
> 
> Thanks,
> 
> Dhaval Rajpara
> 
>

Re: Review Request 75013: RANGER-4774 : Ranger react UI some modules shown hardcoded time zone string "Indian Standard Time"

[Dhaval Rajpara]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75013/
---

(Updated June 6, 2024, 11:07 a.m.)


Review request for ranger, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, 
Kishor Gollapalliwar, Madhan Neethiraj, Mugdha Varadkar, Pradeep Agrawal, and 
Velmurugan Periasamy.


Bugs: RANGER-4774
https://issues.apache.org/jira/browse/RANGER-4774


Repository: ranger


Description
---

1) UI popup showing details of an admin audit log seems to have hardcoded 
string “Indian Standard Time” 
2)Some logs table header also have hardcoded string “Indian Standard Time”


Diffs
-

  security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js d189e4aeb 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx 
47407fd08 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx
 9ebc90290 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx
 c67369e84 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx
 6b2143adb 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx
 d7aabf8dc 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx
 08c0082c1 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx
 5f3552954 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx
 1372f2258 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx
 aa358fd95 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx 
81b7ce486 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx
 d7ee72db9 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx 
a2b24f089 
  
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx
 105659759 


Diff: https://reviews.apache.org/r/75013/diff/1/


Testing (updated)
---

In the Ranger React UI, several modules displayed hardcoded time zone strings 
("Indian Standard Time"). Tests were conducted to ensure audit logs across 
different operations display the correct timestamps reflecting the appropriate 
time zone. The verification included:

1) Services: Timestamps for created, updated, and deleted services.
2) Policies: Timestamps for created, updated, and deleted access, masking, 
row-level, and tag policies.
3) Users/Groups/Roles: Timestamps for created, updated, and deleted users, 
groups, and roles, including user password changes.
4)Security Zones: Timestamps for created, updated, and deleted security zones.
5) Audits: Correct time zone display in the admin, login session, and plugins 
tabs, as well as Usersync's sync time.
6) Export/Import: Correct times and time zones in logs for exported and 
imported policies.
7) Reports: Export times in various file formats adapting to the selected time 
zone, and consistency of log times across different time zones.


Thanks,

Dhaval Rajpara

Re: Review Request 75001: RANGER-4673 : Pagination on the Ranger Admin - Plugin Status page

[Brijesh Bhalala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75001/#review226515
---


Ship it!




Ship It!

- Brijesh Bhalala


On June 6, 2024, 11:01 a.m., Dhaval Rajpara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75001/
> ---
> 
> (Updated June 6, 2024, 11:01 a.m.)
> 
> 
> Review request for ranger, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, 
> Kishor Gollapalliwar, Mehul Parikh, Mugdha Varadkar, Nitin Galave, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4673
> https://issues.apache.org/jira/browse/RANGER-4673
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> The Ranger Admin UI's "Plugin Status" page does not offer pagination.
> The UI shows only (the first random) 200 entries, we have no way to go to 
> next pages, and the ordering/sorting on columns is only a "client side" 
> sorting so some entries cannot be seen easily. (only if we search by Host 
> Name for example)
> This is a usability issue with bigger clusters.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx
>  955e28152 
> 
> 
> Diff: https://reviews.apache.org/r/75001/diff/1/
> 
> 
> Testing
> ---
> 
> 1) Checked that pagination has been added to the plugin status tab and 
> confirmed that it is working properly.
> 2) Also verified the sorting functionality on the plugin status tab.
> 
> 
> Thanks,
> 
> Dhaval Rajpara
> 
>

Re: Review Request 75001: RANGER-4673 : Pagination on the Ranger Admin - Plugin Status page

[Dhaval Rajpara]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75001/
---

(Updated June 6, 2024, 11:01 a.m.)


Review request for ranger, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, 
Kishor Gollapalliwar, Mehul Parikh, Mugdha Varadkar, Nitin Galave, and 
Velmurugan Periasamy.


Bugs: RANGER-4673
https://issues.apache.org/jira/browse/RANGER-4673


Repository: ranger


Description
---

The Ranger Admin UI's "Plugin Status" page does not offer pagination.
The UI shows only (the first random) 200 entries, we have no way to go to next 
pages, and the ordering/sorting on columns is only a "client side" sorting so 
some entries cannot be seen easily. (only if we search by Host Name for example)
This is a usability issue with bigger clusters.


Diffs
-

  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx
 955e28152 


Diff: https://reviews.apache.org/r/75001/diff/1/


Testing (updated)
---

1) Checked that pagination has been added to the plugin status tab and 
confirmed that it is working properly.
2) Also verified the sorting functionality on the plugin status tab.


Thanks,

Dhaval Rajpara

[jira] [Resolved] (RANGER-4744) Ranger Admin startup using JDK17 gives ERROR in catalina.out due to missing jaxb dependencies

[Rakesh Gupta (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh Gupta resolved RANGER-4744.
--
Resolution: Duplicate

> Ranger Admin startup using JDK17 gives ERROR in catalina.out due to missing 
> jaxb dependencies
> -
>
> Key: RANGER-4744
> URL: https://issues.apache.org/jira/browse/RANGER-4744
> Project: Ranger
>  Issue Type: Task
>  Components: Ranger
>Reporter: Rakesh Gupta
>Assignee: Rakesh Gupta
>Priority: Major
>
> When we try to start Ranger Admin using JDK17, the Ranger Admin startup gives 
> ERROR "javax.xml.bind.JAXBException Implementation of JAXB-API has not been 
> found on module path or classpath" in catalina.out due to missing jaxb 
> dependencies.
> The jaxb classes were part of rt.jar in jdk8, but were removed in later 
> versions of JDK.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)