[jira] [Updated] (RANGER-2144) Refactor DAO usage
[ https://issues.apache.org/jira/browse/RANGER-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2144: --- Attachment: RANGER-2144-3.patch > Refactor DAO usage > -- > > Key: RANGER-2144 > URL: https://issues.apache.org/jira/browse/RANGER-2144 > Project: Ranger > Issue Type: Improvement > Components: admin >Affects Versions: 1.0.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Labels: code-cleanup > Attachments: RANGER-2144-3.patch > > > Currently, RangerDaoManagerBase is used to construct new DAO instances, > instead of relying on Spring to provide one for it. This would reduce the > code to write and run, and make it less interdependent, and simplifies the > tests, as less code would be needed to mock. > As RangerDaoManagerBase is used everywhere, and to avoid having huge > patches, it would be better do it in smaller steps. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-2144) Refactor DAO usage
[ https://issues.apache.org/jira/browse/RANGER-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2144: --- Attachment: (was: RANGER-2144.patch) > Refactor DAO usage > -- > > Key: RANGER-2144 > URL: https://issues.apache.org/jira/browse/RANGER-2144 > Project: Ranger > Issue Type: Improvement > Components: admin >Affects Versions: 1.0.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Labels: code-cleanup > Attachments: RANGER-2144-3.patch > > > Currently, RangerDaoManagerBase is used to construct new DAO instances, > instead of relying on Spring to provide one for it. This would reduce the > code to write and run, and make it less interdependent, and simplifies the > tests, as less code would be needed to mock. > As RangerDaoManagerBase is used everywhere, and to avoid having huge > patches, it would be better do it in smaller steps. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RANGER-2307) Native code can segfault or return misleading error messages
Zsombor Gegesy created RANGER-2307: -- Summary: Native code can segfault or return misleading error messages Key: RANGER-2307 URL: https://issues.apache.org/jira/browse/RANGER-2307 Project: Ranger Issue Type: Bug Components: usersync Affects Versions: 1.2.0 Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Currently credValidator and pamCredValidator don't handle well configuration problems - when the user doesn't have permission to read /etc/shadow or access pam, or when the shadow file is not filled properly. This could cause 'core dumps', and hard to fix deployment issues -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-2307) Native code can segfault or return misleading error messages
[ https://issues.apache.org/jira/browse/RANGER-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2307: --- Attachment: RANGER-2307-native-fixes.patch > Native code can segfault or return misleading error messages > > > Key: RANGER-2307 > URL: https://issues.apache.org/jira/browse/RANGER-2307 > Project: Ranger > Issue Type: Bug > Components: usersync >Affects Versions: 1.2.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Labels: native, pam, unix > Attachments: RANGER-2307-native-fixes.patch > > > Currently credValidator and pamCredValidator don't handle well configuration > problems - when the user doesn't have permission to read /etc/shadow or > access pam, or when the shadow file is not filled properly. This could cause > 'core dumps', and hard to fix deployment issues -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RANGER-2317) Enable compilation on JDK11
Zsombor Gegesy created RANGER-2317: -- Summary: Enable compilation on JDK11 Key: RANGER-2317 URL: https://issues.apache.org/jira/browse/RANGER-2317 Project: Ranger Issue Type: Improvement Components: admin, plugins Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Fix For: master Currently, Ranger can be compiled only with JDK 8, however JDK 11 is the current LTS release for Java, it is essential to support it. As a first step, we need to ensure that Ranger can be compiled on JDK 11. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-2317) Enable compilation on JDK11
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2317: --- Attachment: RANGER-2317.patch > Enable compilation on JDK11 > --- > > Key: RANGER-2317 > URL: https://issues.apache.org/jira/browse/RANGER-2317 > Project: Ranger > Issue Type: Improvement > Components: admin, plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Fix For: master > > Attachments: RANGER-2317.patch > > > Currently, Ranger can be compiled only with JDK 8, however JDK 11 is the > current LTS release for Java, it is essential to support it. As a first step, > we need to ensure that Ranger can be compiled on JDK 11. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RANGER-2318) Incorrect git url on the homepage
Zsombor Gegesy created RANGER-2318: -- Summary: Incorrect git url on the homepage Key: RANGER-2318 URL: https://issues.apache.org/jira/browse/RANGER-2318 Project: Ranger Issue Type: Bug Components: documentation Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy On http://ranger.apache.org/ the link for the git repository is pointing to https://git.apache.org/ranger.git/ instead of gitbox and github. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-2318) Incorrect git url on the homepage
[ https://issues.apache.org/jira/browse/RANGER-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2318: --- Attachment: RANGER-2318.patch > Incorrect git url on the homepage > - > > Key: RANGER-2318 > URL: https://issues.apache.org/jira/browse/RANGER-2318 > Project: Ranger > Issue Type: Bug > Components: documentation >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Minor > Labels: homepage > Attachments: RANGER-2318.patch > > > On http://ranger.apache.org/ the link for the git repository is pointing to > https://git.apache.org/ranger.git/ instead of gitbox and github. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RANGER-2318) Incorrect git url on the homepage
[ https://issues.apache.org/jira/browse/RANGER-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734101#comment-16734101 ] Zsombor Gegesy commented on RANGER-2318: Commited to [master|https://github.com/apache/ranger/commit/ead451a3383f33630f59c1996c478ddb6f6fb39f] > Incorrect git url on the homepage > - > > Key: RANGER-2318 > URL: https://issues.apache.org/jira/browse/RANGER-2318 > Project: Ranger > Issue Type: Bug > Components: documentation >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Minor > Labels: homepage > Fix For: master > > Attachments: RANGER-2318.patch > > > On http://ranger.apache.org/ the link for the git repository is pointing to > https://git.apache.org/ranger.git/ instead of gitbox and github. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (RANGER-2255) Add JavaScript unit tests
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy resolved RANGER-2255. Resolution: Fixed Commited to [master|https://github.com/apache/ranger/commit/e1b0105eee67bb73c56b66b2dda1c3424555ab3e], thanks for your contribution [~Koncz] ! > Add JavaScript unit tests > - > > Key: RANGER-2255 > URL: https://issues.apache.org/jira/browse/RANGER-2255 > Project: Ranger > Issue Type: Wish > Components: admin >Affects Versions: 0.7.0, 2.0.0, 1.2.1 >Reporter: Csaba Koncz >Assignee: Csaba Koncz >Priority: Minor > Fix For: 2.0.0 > > > It would be nice if the admin-ui project would have JavaScript unit tests. > As with RANGER-2220 JavaScript minification was introduced, that can lead to > new type of loading errors that were not seen before. > It would be nice if there was an automatic check that validates the minified > output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-2317) Enable compilation on JDK11
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2317: --- Attachment: RANGER-2317-2.patch > Enable compilation on JDK11 > --- > > Key: RANGER-2317 > URL: https://issues.apache.org/jira/browse/RANGER-2317 > Project: Ranger > Issue Type: Improvement > Components: admin, plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Fix For: master > > Attachments: RANGER-2317-2.patch > > > Currently, Ranger can be compiled only with JDK 8, however JDK 11 is the > current LTS release for Java, it is essential to support it. As a first step, > we need to ensure that Ranger can be compiled on JDK 11. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-2317) Enable compilation on JDK11
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2317: --- Attachment: (was: RANGER-2317.patch) > Enable compilation on JDK11 > --- > > Key: RANGER-2317 > URL: https://issues.apache.org/jira/browse/RANGER-2317 > Project: Ranger > Issue Type: Improvement > Components: admin, plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Fix For: master > > Attachments: RANGER-2317-2.patch > > > Currently, Ranger can be compiled only with JDK 8, however JDK 11 is the > current LTS release for Java, it is essential to support it. As a first step, > we need to ensure that Ranger can be compiled on JDK 11. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (RANGER-2319) Remove deprecated phantomjs NPM package
[
https://issues.apache.org/jira/browse/RANGER-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy resolved RANGER-2319.
Resolution: Fixed
Fix Version/s: 2.0.0
Thanks for the patch, applied to
[master|https://github.com/apache/ranger/commit/a3394a19f98cea04dc2824fdaa4e3a3fdbd6beb3]
> Remove deprecated phantomjs NPM package
> ---
>
> Key: RANGER-2319
> URL: https://issues.apache.org/jira/browse/RANGER-2319
> Project: Ranger
> Issue Type: Wish
> Components: admin
>Affects Versions: 2.0.0
>Reporter: Csaba Koncz
>Assignee: Csaba Koncz
>Priority: Major
> Fix For: 2.0.0
>
>
> [Phantomjs|https://github.com/apache/ranger/blob/e1b0105eee67bb73c56b66b2dda1c3424555ab3e/security-admin/src/main/webapp/package.json#L15]
> NPM package is deprecated.
> {code:java}
> $ npm show phantomjs
> phantomjs@2.1.7 | Apache-2.0 | deps: 8 | versions: 81
> Headless WebKit with JS API
> https://github.com/Medium/phantomjs
> DEPRECATED ⚠️ - Package renamed to phantomjs-prebuilt. Please update
> 'phantomjs' package references to 'phantomjs-prebuilt'{code}
> Worse, karma-phantomjs-launcher brings in its version as phantomjs-prebuilt
> which results in Phantomjs binaries being downloaded twice.
> Build would speed up if only one Phantomjs version is downloaded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (RANGER-2321) Docker build fails due to PhantomJS dependency
[
https://issues.apache.org/jira/browse/RANGER-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy resolved RANGER-2321.
Resolution: Fixed
Thanks for the patch, it has been merged to
[master|https://github.com/apache/ranger/commit/2a7782db30f983ddacf9ea3fa53302a37a8b965c]
> Docker build fails due to PhantomJS dependency
> --
>
> Key: RANGER-2321
> URL: https://issues.apache.org/jira/browse/RANGER-2321
> Project: Ranger
> Issue Type: Bug
> Components: admin
>Affects Versions: 2.0.0
>Reporter: Csaba Koncz
>Assignee: Csaba Koncz
>Priority: Major
> Attachments:
> 0001-RANGER-2321-Docker-build-fails-due-to-PhantomJS-depe.patch
>
>
> Docker build fails in an early phase do to the PhantomJS dependency
> introduced in RANGER-2255. E.g. running
> {code:java}
> ./build_ranger_using_docker.sh mvn clean verify -am -pl security-admin{code}
> results in
> {code:java}
> [INFO] < org.apache.ranger:security-admin-web
> >
> [INFO] Building Security Admin Web Application 2.0.0-SNAPSHOT [7/7]
> [INFO] [ war
> ]-
> [INFO]
> [INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-versions) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.7:copy-resources (copy-resources) @
> security-admin-web ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 2 resources
> [INFO]
> [INFO] --- maven-remote-resources-plugin:1.5:process
> (process-resource-bundles) @ security-admin-web ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.7:resources (default-resources) @
> security-admin-web ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 22 resources
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-antrun-plugin:1.7:run (default) @ security-admin-web ---
> [INFO] Executing tasks
> main:
> [INFO] Executed tasks
> [INFO]
> [INFO] --- frontend-maven-plugin:1.6:install-node-and-npm (install node and
> npm) @ security-admin-web ---
> [INFO] Installing node version v8.12.0
> [INFO] Unpacking
> /home/builder/.m2/repository/com/github/eirslett/node/8.12.0/node-8.12.0-linux-x64.tar.gz
> into /ranger/security-admin/target/node/tmp
> [INFO] Copying node binary from
> /ranger/security-admin/target/node/tmp/node-v8.12.0-linux-x64/bin/node to
> /ranger/security-admin/target/node/node
> [INFO] Installed node locally.
> [INFO] Installing npm version 6.4.1
> [INFO] Unpacking
> /home/builder/.m2/repository/com/github/eirslett/npm/6.4.1/npm-6.4.1.tar.gz
> into /ranger/security-admin/target/node/node_modules
> [INFO] Installed npm locally.
> [INFO]
> [INFO] --- frontend-maven-plugin:1.6:npm (npm install) @ security-admin-web
> ---
> [INFO] Running 'npm install' in /ranger/security-admin/target
> [INFO]
> [INFO] > phantomjs-prebuilt@2.1.16 install
> /ranger/security-admin/target/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt
> [INFO] > node install.js
> [INFO]
> [INFO] PhantomJS not found on PATH
> [INFO] Downloading
> https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [INFO] Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [INFO] Receiving...
> [INFO]
> [INFO] Received 22866K total.
> [INFO] Extracting tar contents (via spawned process)
> [ERROR] Error extracting archive
> [ERROR] Phantom installation failed { Error: Command failed: tar jxf
> /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [ERROR] tar (child): bzip2: Cannot exec: No such file or directory
> [ERROR] tar (child): Error is not recoverable: exiting now
> [ERROR] tar: Child returned status 2
> [ERROR] tar: Error is not recoverable: exiting now
> [ERROR]
> [ERROR] at ChildProcess.exithandler (child_process.js:276:12)
> [ERROR] at emitTwo (events.js:126:13)
> [ERROR] at ChildProcess.emit (events.js:214:7)
> [ERROR] at maybeClose (internal/child_process.js:915:16)
> [ERROR] at Socket.stream.socket.on (internal/child_process.js:336:11)
> [ERROR] at emitOne (events.js:116:13)
> [ERROR] at Socket.emit (events.js:211:7)
> [ERROR] at Pipe._handle.close [as _onclose] (net.js:561:12)
> [ERROR] killed: false,
> [ERROR] code: 2,
> [ERROR] signal: null,
> [ERROR] cmd: 'tar jxf /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2' }
> Error: Command failed: tar jxf
> /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [ERROR] tar (child): bzip2: Cannot exec: No such file or directory
> [ERROR] tar (child): Error is not recoverable: exiting now
> [ERROR] tar: Child returned st
[jira] [Updated] (RANGER-2321) Docker build fails due to PhantomJS dependency
[
https://issues.apache.org/jira/browse/RANGER-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-2321:
---
Fix Version/s: 2.0.0
> Docker build fails due to PhantomJS dependency
> --
>
> Key: RANGER-2321
> URL: https://issues.apache.org/jira/browse/RANGER-2321
> Project: Ranger
> Issue Type: Bug
> Components: admin
>Affects Versions: 2.0.0
>Reporter: Csaba Koncz
>Assignee: Csaba Koncz
>Priority: Major
> Fix For: 2.0.0
>
> Attachments:
> 0001-RANGER-2321-Docker-build-fails-due-to-PhantomJS-depe.patch
>
>
> Docker build fails in an early phase do to the PhantomJS dependency
> introduced in RANGER-2255. E.g. running
> {code:java}
> ./build_ranger_using_docker.sh mvn clean verify -am -pl security-admin{code}
> results in
> {code:java}
> [INFO] < org.apache.ranger:security-admin-web
> >
> [INFO] Building Security Admin Web Application 2.0.0-SNAPSHOT [7/7]
> [INFO] [ war
> ]-
> [INFO]
> [INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-versions) @
> security-admin-web ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.7:copy-resources (copy-resources) @
> security-admin-web ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 2 resources
> [INFO]
> [INFO] --- maven-remote-resources-plugin:1.5:process
> (process-resource-bundles) @ security-admin-web ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.7:resources (default-resources) @
> security-admin-web ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 22 resources
> [INFO] Copying 3 resources
> [INFO]
> [INFO] --- maven-antrun-plugin:1.7:run (default) @ security-admin-web ---
> [INFO] Executing tasks
> main:
> [INFO] Executed tasks
> [INFO]
> [INFO] --- frontend-maven-plugin:1.6:install-node-and-npm (install node and
> npm) @ security-admin-web ---
> [INFO] Installing node version v8.12.0
> [INFO] Unpacking
> /home/builder/.m2/repository/com/github/eirslett/node/8.12.0/node-8.12.0-linux-x64.tar.gz
> into /ranger/security-admin/target/node/tmp
> [INFO] Copying node binary from
> /ranger/security-admin/target/node/tmp/node-v8.12.0-linux-x64/bin/node to
> /ranger/security-admin/target/node/node
> [INFO] Installed node locally.
> [INFO] Installing npm version 6.4.1
> [INFO] Unpacking
> /home/builder/.m2/repository/com/github/eirslett/npm/6.4.1/npm-6.4.1.tar.gz
> into /ranger/security-admin/target/node/node_modules
> [INFO] Installed npm locally.
> [INFO]
> [INFO] --- frontend-maven-plugin:1.6:npm (npm install) @ security-admin-web
> ---
> [INFO] Running 'npm install' in /ranger/security-admin/target
> [INFO]
> [INFO] > phantomjs-prebuilt@2.1.16 install
> /ranger/security-admin/target/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt
> [INFO] > node install.js
> [INFO]
> [INFO] PhantomJS not found on PATH
> [INFO] Downloading
> https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [INFO] Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [INFO] Receiving...
> [INFO]
> [INFO] Received 22866K total.
> [INFO] Extracting tar contents (via spawned process)
> [ERROR] Error extracting archive
> [ERROR] Phantom installation failed { Error: Command failed: tar jxf
> /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [ERROR] tar (child): bzip2: Cannot exec: No such file or directory
> [ERROR] tar (child): Error is not recoverable: exiting now
> [ERROR] tar: Child returned status 2
> [ERROR] tar: Error is not recoverable: exiting now
> [ERROR]
> [ERROR] at ChildProcess.exithandler (child_process.js:276:12)
> [ERROR] at emitTwo (events.js:126:13)
> [ERROR] at ChildProcess.emit (events.js:214:7)
> [ERROR] at maybeClose (internal/child_process.js:915:16)
> [ERROR] at Socket.stream.socket.on (internal/child_process.js:336:11)
> [ERROR] at emitOne (events.js:116:13)
> [ERROR] at Socket.emit (events.js:211:7)
> [ERROR] at Pipe._handle.close [as _onclose] (net.js:561:12)
> [ERROR] killed: false,
> [ERROR] code: 2,
> [ERROR] signal: null,
> [ERROR] cmd: 'tar jxf /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2' }
> Error: Command failed: tar jxf
> /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
> [ERROR] tar (child): bzip2: Cannot exec: No such file or directory
> [ERROR] tar (child): Error is not recoverable: exiting now
> [ERROR] tar: Child returned status 2
> [ERROR] tar: Error is not recoverable: exiting now
> [ERROR]
> [ERROR] at ChildProcess.exithand
[jira] [Commented] (RANGER-2287) Improve and optimize db_setup.py file code
[ https://issues.apache.org/jira/browse/RANGER-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749768#comment-16749768 ] Zsombor Gegesy commented on RANGER-2287: Awesome, you removed nearly 4000 lines of code, I'm impressed ! > Improve and optimize db_setup.py file code > -- > > Key: RANGER-2287 > URL: https://issues.apache.org/jira/browse/RANGER-2287 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Pradeep Agrawal >Assignee: Pradeep Agrawal >Priority: Major > Fix For: 2.0.0 > > Attachments: > 0001-RANGER-2287-Improve-and-optimize-db_setup.py-file-co.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-2317) Enable compilation on JDK11
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2317: --- Attachment: RANGER-2317-3.patch > Enable compilation on JDK11 > --- > > Key: RANGER-2317 > URL: https://issues.apache.org/jira/browse/RANGER-2317 > Project: Ranger > Issue Type: Improvement > Components: admin, plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Fix For: master > > Attachments: RANGER-2317-2.patch, RANGER-2317-3.patch > > > Currently, Ranger can be compiled only with JDK 8, however JDK 11 is the > current LTS release for Java, it is essential to support it. As a first step, > we need to ensure that Ranger can be compiled on JDK 11. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RANGER-2336) Ranger HBase plugin should pack guava lib as a dependency.
[
https://issues.apache.org/jira/browse/RANGER-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778605#comment-16778605
]
Zsombor Gegesy commented on RANGER-2336:
In [this
commit|https://github.com/apache/ranger/commit/092320830f89bc426e68e4fe8a3e5e3255693571]
(for RANGER-2232), all the MoreObjects usage was removed - so I think, the
original
[fix|https://github.com/apache/ranger/commit/a5d212871588211870b711cd6ec5f3650c14079d]
can be reverted.
> Ranger HBase plugin should pack guava lib as a dependency.
> --
>
> Key: RANGER-2336
> URL: https://issues.apache.org/jira/browse/RANGER-2336
> Project: Ranger
> Issue Type: Bug
> Components: Ranger
>Affects Versions: master, 2.0.0
>Reporter: Ramesh Mani
>Assignee: Ramesh Mani
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments:
> 0001-RANGER-2336-Ranger-HBase-plugin-should-pack-guava-li.patch
>
>
> Ranger HBase plugin should pack guava lib as a dependency. This is avoid run
> time exception in debug mode, which crashes HBase
>
> {code:java}
> ABORTING region server
> ctr-e139-1542663976389-66118-01-09.hwx.site,16020,1550008218797: The
> coprocessor
> org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor threw
> java.lang.NoClassDefFoundError: com/google/common/base/MoreObjects *
> Cause:
> java.lang.NoClassDefFoundError: com/google/common/base/MoreObjects
> at
> org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor$ColumnFamilyAccessResult.toString(RangerAuthorizationCoprocessor.java:288)
> at
> org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.evaluateAccess(RangerAuthorizationCoprocessor.java:330)
> at
> org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.authorizeAccess(RangerAuthorizationCoprocessor.java:531)
> at
> org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.preGetOp(RangerAuthorizationCoprocessor.java:1130)
> at
> org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.preGetOp(RangerAuthorizationCoprocessor.java:927)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$19.call(RegionCoprocessorHost.java:831)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$19.call(RegionCoprocessorHost.java:828)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:540)
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:614)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.preGet(RegionCoprocessorHost.java:828)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2530)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2470)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:131)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> Caused by: java.lang.ClassNotFoundException:
> com.google.common.base.MoreObjects
> at java.lang.ClassLoader.findClass(ClassLoader.java:530)
> at
> org.apache.ranger.plugin.classloader.RangerPluginClassLoader$MyClassLoader.findClass(RangerPluginClassLoader.java:272)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at
> org.apache.ranger.plugin.classloader.RangerPluginClassLoader.loadClass(RangerPluginClassLoader.java:125)
> .{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (RANGER-2356) External user's email address can be edited
[ https://issues.apache.org/jira/browse/RANGER-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy resolved RANGER-2356. Resolution: Fixed Merged to [master|https://github.com/apache/ranger/commit/3e04f089c9ad5b8e749c3faa08447cbe04be6dba] - Thanks for the fix ! > External user's email address can be edited > --- > > Key: RANGER-2356 > URL: https://issues.apache.org/jira/browse/RANGER-2356 > Project: Ranger > Issue Type: Bug > Components: admin >Affects Versions: master >Reporter: László Dénes Terjéki >Priority: Major > Labels: email > Attachments: > 0001-RANGER-2356-Ranger-UI-disable-email-editing-for-Exte.patch, Screenshot > 2019-03-12 at 13.30.46.png > > > In Settings -> Users/Groups clicking on an external user the email field is > editable while the "User Name", "First Name" and "Last Name" fields are > disabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (RANGER-2317) Enable compilation on JDK11
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy resolved RANGER-2317. Resolution: Fixed Merged to [master|https://github.com/apache/ranger/commit/08f32cd35824399eaac573f47338fbe8433ed97e] > Enable compilation on JDK11 > --- > > Key: RANGER-2317 > URL: https://issues.apache.org/jira/browse/RANGER-2317 > Project: Ranger > Issue Type: Improvement > Components: admin, plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Fix For: master > > Attachments: RANGER-2317-2.patch, RANGER-2317-3.patch > > > Currently, Ranger can be compiled only with JDK 8, however JDK 11 is the > current LTS release for Java, it is essential to support it. As a first step, > we need to ensure that Ranger can be compiled on JDK 11. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RANGER-2378) KeySecure HSM Integration is not compatible with Java9
Zsombor Gegesy created RANGER-2378:
--
Summary: KeySecure HSM Integration is not compatible with Java9
Key: RANGER-2378
URL: https://issues.apache.org/jira/browse/RANGER-2378
Project: Ranger
Issue Type: Bug
Components: kms
Reporter: Zsombor Gegesy
The patch introduced in RANGER-2331 relies on internal
sun.security.pkcs11.SunPKCS11 class, unfortunately this class changed between
Java 8 and 9, so the code no longer compiles on Java9+.
The Java8 way of doing (documented
[here|https://docs.oracle.com/javase/8/docs/technotes/guides/security/p11guide.html]
) is:
{code}
Provider p = new sun.security.pkcs11.SunPKCS11(configName);
Security.addProvider(p);
{code}
However, in Java 9, sun.security.pkcs11.SunPKCS11 doesn't have a constructor
with a String parameter, and the documentation
[suggests|https://docs.oracle.com/javase/9/security/pkcs11-reference-guide1.htm]
suggest to use:
{code}
Provider p = Security.getProvider("SunPKCS11");
p = p.configure(configName);
Security.addProvider(p);
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (RANGER-2386) Code duplication due to RangerCredentialProvider.getCredentialString returns char[]
Zsombor Gegesy created RANGER-2386: -- Summary: Code duplication due to RangerCredentialProvider.getCredentialString returns char[] Key: RANGER-2386 URL: https://issues.apache.org/jira/browse/RANGER-2386 Project: Ranger Issue Type: Improvement Components: plugins Affects Versions: master Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Fix For: 2.0.0 The same code appears in lot's of places, because RangerCredentialProvider.getCredentialString returns a char array, which needs to be converted to String. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-2386) Code duplication due to RangerCredentialProvider.getCredentialString returns char[]
[ https://issues.apache.org/jira/browse/RANGER-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2386: --- Attachment: RANGER-2386.patch > Code duplication due to RangerCredentialProvider.getCredentialString returns > char[] > --- > > Key: RANGER-2386 > URL: https://issues.apache.org/jira/browse/RANGER-2386 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Fix For: 2.0.0 > > Attachments: RANGER-2386.patch > > > The same code appears in lot's of places, because > RangerCredentialProvider.getCredentialString returns a char array, which > needs to be converted to String. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RANGER-2394) Filter/exclude multiple users in audit search
Zsombor Gegesy created RANGER-2394: -- Summary: Filter/exclude multiple users in audit search Key: RANGER-2394 URL: https://issues.apache.org/jira/browse/RANGER-2394 Project: Ranger Issue Type: Improvement Components: admin Affects Versions: master Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Fix For: 2.0.0 Currently the audit search only allows to: * filter to one user's activity * exclude all 'service users' from every user's activity. If there were way to search for multiple users or exclude multiple users from the search list, it would make debugging complex interactions simpler, for example only look for actions for 'alice' and 'hive' and 'yarn' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-2394) Filter/exclude multiple users in audit search
[ https://issues.apache.org/jira/browse/RANGER-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2394: --- Attachment: RANGER-2394.patch > Filter/exclude multiple users in audit search > - > > Key: RANGER-2394 > URL: https://issues.apache.org/jira/browse/RANGER-2394 > Project: Ranger > Issue Type: Improvement > Components: admin >Affects Versions: master >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Labels: admin, solr > Fix For: 2.0.0 > > Attachments: RANGER-2394.patch > > > Currently the audit search only allows to: > * filter to one user's activity > * exclude all 'service users' from every user's activity. > If there were way to search for multiple users or exclude multiple users from > the search list, it would make debugging complex interactions simpler, for > example only look for actions for 'alice' and 'hive' and 'yarn' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RANGER-2421) Solr audit fails in Atlas plugin
Zsombor Gegesy created RANGER-2421:
--
Summary: Solr audit fails in Atlas plugin
Key: RANGER-2421
URL: https://issues.apache.org/jira/browse/RANGER-2421
Project: Ranger
Issue Type: Bug
Components: audit, plugins
Reporter: Zsombor Gegesy
Assignee: Zsombor Gegesy
Due to http client version difference, and the lack of httpclient-4.5.3.jar
inside the ranger-atlas-plugin/lib/ranger-atlas-plugin-impl/ folder, the
following exception can be seen:
{code}
ava.lang.NoSuchMethodError:
org.apache.http.impl.client.HttpClientBuilder.evictIdleConnections(JLjava/util/concurrent/TimeUnit;)Lorg/apache/http/impl/client/HttpClientBuilder;
at
org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:311)
at
org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:330)
at
org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:268)
at
org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:255)
at
org.apache.solr.client.solrj.impl.CloudSolrClient.(CloudSolrClient.java:280)
at
org.apache.solr.client.solrj.impl.CloudSolrClient$Builder.build(CloudSolrClient.java:1600)
at
org.apache.ranger.audit.destination.SolrAuditDestination$1.run(SolrAuditDestination.java:126)
at
org.apache.ranger.audit.destination.SolrAuditDestination$1.run(SolrAuditDestination.java:123)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
at
org.apache.ranger.audit.provider.MiscUtil.executePrivilegedAction(MiscUtil.java:516)
at
org.apache.ranger.audit.destination.SolrAuditDestination.connect(SolrAuditDestination.java:123)
at
org.apache.ranger.audit.destination.SolrAuditDestination.init(SolrAuditDestination.java:72)
at
org.apache.ranger.audit.provider.AuditProviderFactory.init(AuditProviderFactory.java:179)
at
org.apache.ranger.plugin.service.RangerBasePlugin.init(RangerBasePlugin.java:217)
{code}
Atlas has a httpclient-4.4.x, which lacks the needed method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (RANGER-2421) Solr audit fails in Atlas plugin
[
https://issues.apache.org/jira/browse/RANGER-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-2421:
---
Attachment: RANGER-2421.patch
> Solr audit fails in Atlas plugin
>
>
> Key: RANGER-2421
> URL: https://issues.apache.org/jira/browse/RANGER-2421
> Project: Ranger
> Issue Type: Bug
> Components: audit, plugins
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
>Priority: Major
> Labels: atlas, audit, plugin
> Attachments: RANGER-2421.patch
>
>
> Due to http client version difference, and the lack of httpclient-4.5.3.jar
> inside the ranger-atlas-plugin/lib/ranger-atlas-plugin-impl/ folder, the
> following exception can be seen:
> {code}
> ava.lang.NoSuchMethodError:
> org.apache.http.impl.client.HttpClientBuilder.evictIdleConnections(JLjava/util/concurrent/TimeUnit;)Lorg/apache/http/impl/client/HttpClientBuilder;
> at
> org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:311)
> at
> org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:330)
> at
> org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:268)
> at
> org.apache.solr.client.solrj.impl.HttpClientUtil.createClient(HttpClientUtil.java:255)
> at
> org.apache.solr.client.solrj.impl.CloudSolrClient.(CloudSolrClient.java:280)
> at
> org.apache.solr.client.solrj.impl.CloudSolrClient$Builder.build(CloudSolrClient.java:1600)
> at
> org.apache.ranger.audit.destination.SolrAuditDestination$1.run(SolrAuditDestination.java:126)
> at
> org.apache.ranger.audit.destination.SolrAuditDestination$1.run(SolrAuditDestination.java:123)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
> at
> org.apache.ranger.audit.provider.MiscUtil.executePrivilegedAction(MiscUtil.java:516)
> at
> org.apache.ranger.audit.destination.SolrAuditDestination.connect(SolrAuditDestination.java:123)
> at
> org.apache.ranger.audit.destination.SolrAuditDestination.init(SolrAuditDestination.java:72)
> at
> org.apache.ranger.audit.provider.AuditProviderFactory.init(AuditProviderFactory.java:179)
> at
> org.apache.ranger.plugin.service.RangerBasePlugin.init(RangerBasePlugin.java:217)
> {code}
> Atlas has a httpclient-4.4.x, which lacks the needed method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (RANGER-2394) Filter/exclude multiple users in audit search
[ https://issues.apache.org/jira/browse/RANGER-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2394: --- Attachment: RANGER-2394-5.patch > Filter/exclude multiple users in audit search > - > > Key: RANGER-2394 > URL: https://issues.apache.org/jira/browse/RANGER-2394 > Project: Ranger > Issue Type: Improvement > Components: admin >Affects Versions: master >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Labels: admin, solr > Fix For: 2.0.0 > > Attachments: RANGER-2394-5.patch, RANGER-2394.patch > > > Currently the audit search only allows to: > * filter to one user's activity > * exclude all 'service users' from every user's activity. > If there were way to search for multiple users or exclude multiple users from > the search list, it would make debugging complex interactions simpler, for > example only look for actions for 'alice' and 'hive' and 'yarn' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-2394) Filter/exclude multiple users in audit search
[ https://issues.apache.org/jira/browse/RANGER-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-2394: --- Attachment: RANGER-2394-6.patch > Filter/exclude multiple users in audit search > - > > Key: RANGER-2394 > URL: https://issues.apache.org/jira/browse/RANGER-2394 > Project: Ranger > Issue Type: Improvement > Components: admin >Affects Versions: master >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Labels: admin, solr > Fix For: 2.0.0 > > Attachments: RANGER-2394-5.patch, RANGER-2394-6.patch, > RANGER-2394.patch > > > Currently the audit search only allows to: > * filter to one user's activity > * exclude all 'service users' from every user's activity. > If there were way to search for multiple users or exclude multiple users from > the search list, it would make debugging complex interactions simpler, for > example only look for actions for 'alice' and 'hive' and 'yarn' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (RANGER-2394) Filter/exclude multiple users in audit search
[ https://issues.apache.org/jira/browse/RANGER-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy resolved RANGER-2394. Resolution: Fixed Merged into [master|https://github.com/apache/ranger/commit/444db6edb092f23de89813503dae04f909e5325e] > Filter/exclude multiple users in audit search > - > > Key: RANGER-2394 > URL: https://issues.apache.org/jira/browse/RANGER-2394 > Project: Ranger > Issue Type: Improvement > Components: admin >Affects Versions: master >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Labels: admin, solr > Fix For: 2.0.0 > > Attachments: RANGER-2394-5.patch, RANGER-2394-6.patch, > RANGER-2394.patch > > > Currently the audit search only allows to: > * filter to one user's activity > * exclude all 'service users' from every user's activity. > If there were way to search for multiple users or exclude multiple users from > the search list, it would make debugging complex interactions simpler, for > example only look for actions for 'alice' and 'hive' and 'yarn' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-2599) Add more audit data to HBase grant/revoke events
[
https://issues.apache.org/jira/browse/RANGER-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-2599:
---
Affects Version/s: 2.0.0
> Add more audit data to HBase grant/revoke events
>
>
> Key: RANGER-2599
> URL: https://issues.apache.org/jira/browse/RANGER-2599
> Project: Ranger
> Issue Type: Improvement
> Components: audit
>Affects Versions: 2.0.0
>Reporter: Andor Molnar
>Priority: Major
>
> Currently {{RangerAuthorizationCoprocessor}} correctly captures all data from
> HBase grant and revoke events, but {{RangerBasePlugin}} only copies certain
> fields to RangerAccessEvent.
> {{RequestData}} is one the fields which are copied to the final entity and
> currently not being used by the co-processor. I'd like to add some missing
> information to this field and make it available on the UI similarly how Hive
> queries are shown in a small pop-up.
> First, I change the co-processor to populate {{RequestData}} with additional
> grant/revoke information.
> Second, I modify JS to show the RequestData pop-up on HBase audit events too.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (RANGER-2599) Add more audit data to HBase grant/revoke events
[
https://issues.apache.org/jira/browse/RANGER-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941845#comment-16941845
]
Zsombor Gegesy commented on RANGER-2599:
Sorry, I can't assign this ticket to you, Andor.
> Add more audit data to HBase grant/revoke events
>
>
> Key: RANGER-2599
> URL: https://issues.apache.org/jira/browse/RANGER-2599
> Project: Ranger
> Issue Type: Improvement
> Components: audit
>Affects Versions: 2.0.0
>Reporter: Andor Molnar
>Priority: Major
> Fix For: 2.1.0
>
>
> Currently {{RangerAuthorizationCoprocessor}} correctly captures all data from
> HBase grant and revoke events, but {{RangerBasePlugin}} only copies certain
> fields to RangerAccessEvent.
> {{RequestData}} is one the fields which are copied to the final entity and
> currently not being used by the co-processor. I'd like to add some missing
> information to this field and make it available on the UI similarly how Hive
> queries are shown in a small pop-up.
> First, I change the co-processor to populate {{RequestData}} with additional
> grant/revoke information.
> Second, I modify JS to show the RequestData pop-up on HBase audit events too.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (RANGER-2599) Add more audit data to HBase grant/revoke events
[
https://issues.apache.org/jira/browse/RANGER-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-2599:
---
Fix Version/s: 2.1.0
> Add more audit data to HBase grant/revoke events
>
>
> Key: RANGER-2599
> URL: https://issues.apache.org/jira/browse/RANGER-2599
> Project: Ranger
> Issue Type: Improvement
> Components: audit
>Affects Versions: 2.0.0
>Reporter: Andor Molnar
>Priority: Major
> Fix For: 2.1.0
>
>
> Currently {{RangerAuthorizationCoprocessor}} correctly captures all data from
> HBase grant and revoke events, but {{RangerBasePlugin}} only copies certain
> fields to RangerAccessEvent.
> {{RequestData}} is one the fields which are copied to the final entity and
> currently not being used by the co-processor. I'd like to add some missing
> information to this field and make it available on the UI similarly how Hive
> queries are shown in a small pop-up.
> First, I change the co-processor to populate {{RequestData}} with additional
> grant/revoke information.
> Second, I modify JS to show the RequestData pop-up on HBase audit events too.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (RANGER-2599) Add more audit data to HBase grant/revoke events
[
https://issues.apache.org/jira/browse/RANGER-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945922#comment-16945922
]
Zsombor Gegesy commented on RANGER-2599:
Thanks for your patch, the commit is merged to
[master|https://github.com/apache/ranger/commit/0011a441d0151c9eeec78ab1e5b9e3e3262129b8]
> Add more audit data to HBase grant/revoke events
>
>
> Key: RANGER-2599
> URL: https://issues.apache.org/jira/browse/RANGER-2599
> Project: Ranger
> Issue Type: Improvement
> Components: audit
>Affects Versions: 2.0.0
>Reporter: Andor Molnar
>Priority: Major
> Labels: patch-available
> Fix For: 2.1.0
>
>
> Currently {{RangerAuthorizationCoprocessor}} correctly captures all data from
> HBase grant and revoke events, but {{RangerBasePlugin}} only copies certain
> fields to RangerAccessEvent.
> {{RequestData}} is one the fields which are copied to the final entity and
> currently not being used by the co-processor. I'd like to add some missing
> information to this field and make it available on the UI similarly how Hive
> queries are shown in a small pop-up.
> First, I change the co-processor to populate {{RequestData}} with additional
> grant/revoke information.
> Second, I modify JS to show the RequestData pop-up on HBase audit events too.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (RANGER-1262) Setting up database on MacOS is not working
[ https://issues.apache.org/jira/browse/RANGER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1262: --- Attachment: (was: 0001-Make-the-db-setup-scripts-compatible-with-MacOS.patch) > Setting up database on MacOS is not working > --- > > Key: RANGER-1262 > URL: https://issues.apache.org/jira/browse/RANGER-1262 > Project: Ranger > Issue Type: Improvement > Components: admin >Affects Versions: Ranger >Reporter: Zsombor Gegesy >Priority: Minor > Labels: patch > Fix For: 0.7.0 > > Attachments: > 0001-Make-the-db-setup-scripts-compatible-with-MacOS.patch > > > Currently it's pretty hard to setup the dev environment, for example the > scripts which are creating and updating the db schema have a lot's of linux > and windows specific steps, which is not executed on MacOS (or any other OS), > as MacOS is very similar to Linux, most of the Linux steps could work well on > Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (RANGER-1262) Setting up database on MacOS is not working
[ https://issues.apache.org/jira/browse/RANGER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1262: --- Attachment: 0001-Make-the-db-setup-scripts-compatible-with-MacOS.patch Updated version of the patch > Setting up database on MacOS is not working > --- > > Key: RANGER-1262 > URL: https://issues.apache.org/jira/browse/RANGER-1262 > Project: Ranger > Issue Type: Improvement > Components: admin >Affects Versions: Ranger >Reporter: Zsombor Gegesy >Priority: Minor > Labels: patch > Fix For: 0.7.0 > > Attachments: > 0001-Make-the-db-setup-scripts-compatible-with-MacOS.patch > > > Currently it's pretty hard to setup the dev environment, for example the > scripts which are creating and updating the db schema have a lot's of linux > and windows specific steps, which is not executed on MacOS (or any other OS), > as MacOS is very similar to Linux, most of the Linux steps could work well on > Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (RANGER-1350) Generic types are not used correctly
Zsombor Gegesy created RANGER-1350:
--
Summary: Generic types are not used correctly
Key: RANGER-1350
URL: https://issues.apache.org/jira/browse/RANGER-1350
Project: Ranger
Issue Type: Improvement
Components: Ranger
Reporter: Zsombor Gegesy
In the security-admin webapp, the generic types are not correctly used in the
services, which cause lot's of compiler warnings and
SuppressWarning("unchecked") annotations.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1350) Generic types are not used correctly
[
https://issues.apache.org/jira/browse/RANGER-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1350:
---
Attachment: 0001-RANGER-1350-Fix-generic-types-removing-a-lot-of-Supp.patch
> Generic types are not used correctly
>
>
> Key: RANGER-1350
> URL: https://issues.apache.org/jira/browse/RANGER-1350
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Reporter: Zsombor Gegesy
> Labels: code-cleanup
> Attachments:
> 0001-RANGER-1350-Fix-generic-types-removing-a-lot-of-Supp.patch
>
>
> In the security-admin webapp, the generic types are not correctly used in the
> services, which cause lot's of compiler warnings and
> SuppressWarning("unchecked") annotations.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (RANGER-1351) loggers should be "private final static" fields
Zsombor Gegesy created RANGER-1351: -- Summary: loggers should be "private final static" fields Key: RANGER-1351 URL: https://issues.apache.org/jira/browse/RANGER-1351 Project: Ranger Issue Type: Improvement Components: Ranger Reporter: Zsombor Gegesy Priority: Minor There are lot's of places, where the logger is defined either public, or non-final, however the general recommendation is to use as private static final fields. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (RANGER-1370) createdByUserId is stored in public static field
Zsombor Gegesy created RANGER-1370: -- Summary: createdByUserId is stored in public static field Key: RANGER-1370 URL: https://issues.apache.org/jira/browse/RANGER-1370 Project: Ranger Issue Type: Improvement Components: Ranger Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Fix For: 0.7.0 In the security-admin webapp, the createdByUserId is stored in many places as public static variable, instead of private final instance variable. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1370) createdByUserId is stored in public static field
[ https://issues.apache.org/jira/browse/RANGER-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1370: --- Attachment: 0001-RANGER-1370-Add-method-to-get-longs-from-the-Propert.patch > createdByUserId is stored in public static field > > > Key: RANGER-1370 > URL: https://issues.apache.org/jira/browse/RANGER-1370 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: code-cleanup > Fix For: 0.7.0 > > Attachments: > 0001-RANGER-1370-Add-method-to-get-longs-from-the-Propert.patch > > > In the security-admin webapp, the createdByUserId is stored in many places as > public static variable, instead of private final instance variable. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (RANGER-1370) createdByUserId is stored in public static field
[ https://issues.apache.org/jira/browse/RANGER-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859510#comment-15859510 ] Zsombor Gegesy commented on RANGER-1370: Review request : https://reviews.apache.org/r/56496/ > createdByUserId is stored in public static field > > > Key: RANGER-1370 > URL: https://issues.apache.org/jira/browse/RANGER-1370 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: code-cleanup > Fix For: 0.7.0 > > Attachments: > 0001-RANGER-1370-Add-method-to-get-longs-from-the-Propert.patch > > > In the security-admin webapp, the createdByUserId is stored in many places as > public static variable, instead of private final instance variable. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (RANGER-1371) No need to write field initializers for default values, and types where the diamond operator could suffice
Zsombor Gegesy created RANGER-1371:
--
Summary: No need to write field initializers for default values,
and types where the diamond operator could suffice
Key: RANGER-1371
URL: https://issues.apache.org/jira/browse/RANGER-1371
Project: Ranger
Issue Type: Improvement
Components: Ranger
Reporter: Zsombor Gegesy
Assignee: Zsombor Gegesy
Lot's of places the fields are initialized to their default values, which is
unnecessary verbose:
{code}
long value = 0L;
String str = null;
{code}
which is equivalent with:
{code}
long value;
String str;
{code}
And similarly the type specification can be omitted, as the compiler can
calculate it automatically, so instead of
{code}
List conditions = new
ArrayList();
{code}
it is suffice to write:
{code}
List conditions = new ArrayList<>();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1371) No need to write field initializers for default values, and types where the diamond operator could suffice
[
https://issues.apache.org/jira/browse/RANGER-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1371:
---
Attachment: 0001-RANGER-1371-Remove-unneded-field-initializers-and-un.patch
Patch for the agents-common module
> No need to write field initializers for default values, and types where the
> diamond operator could suffice
> --
>
> Key: RANGER-1371
> URL: https://issues.apache.org/jira/browse/RANGER-1371
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
> Labels: code-cleanup
> Attachments:
> 0001-RANGER-1371-Remove-unneded-field-initializers-and-un.patch
>
>
> Lot's of places the fields are initialized to their default values, which is
> unnecessary verbose:
> {code}
> long value = 0L;
> String str = null;
> {code}
> which is equivalent with:
> {code}
> long value;
> String str;
> {code}
> And similarly the type specification can be omitted, as the compiler can
> calculate it automatically, so instead of
> {code}
> List conditions = new
> ArrayList();
> {code}
> it is suffice to write:
> {code}
> List conditions = new ArrayList<>();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (RANGER-1376) Several different jersey/jackson library is used
Zsombor Gegesy created RANGER-1376: -- Summary: Several different jersey/jackson library is used Key: RANGER-1376 URL: https://issues.apache.org/jira/browse/RANGER-1376 Project: Ranger Issue Type: Improvement Components: Ranger Affects Versions: 0.7.0 Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Fix For: 1.0.0 It seems, that ranger currently use several different versions from the jersey library: * 1.19 - sun-jersey-bundle.version (also inherited from hadoop-common) * 1.4 - sun.jersey.bundle.version,sun.jersey.core.version, sun.jersey.spring.version * 1.9 - jersey-server.version * 1.17.1 - jersey-bundle.version This could cause incompatibilities and confusions - during development and during build, so it's worth to upgrade jersey, consistently to 1.19.3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (RANGER-1376) Several different jersey/jackson library is used
[ https://issues.apache.org/jira/browse/RANGER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862792#comment-15862792 ] Zsombor Gegesy commented on RANGER-1376: Review request : https://reviews.apache.org/r/56578/ > Several different jersey/jackson library is used > > > Key: RANGER-1376 > URL: https://issues.apache.org/jira/browse/RANGER-1376 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: upgrade > Fix For: 1.0.0 > > > It seems, that ranger currently use several different versions from the > jersey library: > * 1.19 - sun-jersey-bundle.version (also inherited from hadoop-common) > * 1.4 - sun.jersey.bundle.version,sun.jersey.core.version, > sun.jersey.spring.version > * 1.9 - jersey-server.version > * 1.17.1 - jersey-bundle.version > This could cause incompatibilities and confusions - during development and > during build, so it's worth to upgrade jersey, consistently to 1.19.3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1376) Several different jersey/jackson library is used
[ https://issues.apache.org/jira/browse/RANGER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1376: --- Attachment: 0001-RANGER-1376-Upgrade-jersey-to-1.19.3-and-trying-to-r.patch > Several different jersey/jackson library is used > > > Key: RANGER-1376 > URL: https://issues.apache.org/jira/browse/RANGER-1376 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: upgrade > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1376-Upgrade-jersey-to-1.19.3-and-trying-to-r.patch > > > It seems, that ranger currently use several different versions from the > jersey library: > * 1.19 - sun-jersey-bundle.version (also inherited from hadoop-common) > * 1.4 - sun.jersey.bundle.version,sun.jersey.core.version, > sun.jersey.spring.version > * 1.9 - jersey-server.version > * 1.17.1 - jersey-bundle.version > This could cause incompatibilities and confusions - during development and > during build, so it's worth to upgrade jersey, consistently to 1.19.3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (RANGER-1377) Improve codestyle, java api usage
Zsombor Gegesy created RANGER-1377:
--
Summary: Improve codestyle, java api usage
Key: RANGER-1377
URL: https://issues.apache.org/jira/browse/RANGER-1377
Project: Ranger
Issue Type: Improvement
Components: Ranger
Reporter: Zsombor Gegesy
Assignee: Zsombor Gegesy
There are several generally considered best practice writing Java code, it is
better to follow them.
Instead of:
* var.equals("somestring") use "somestring".equals(var)
* collection.size() > 0 use !collection.isEmpty()
* instead of using a for loop to add items to a collection, use 'addAll'
* str.indexOf("something") >= 0 use str.contains("something")
* "" + var use String.valueOf(var)
* stringBuilder.append("a" + b + "c") use
stringBuilder.append("a").append(b).append("c")
* "something "+ a.toString() use "something " + a
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1377) Improve codestyle, java api usage
[
https://issues.apache.org/jira/browse/RANGER-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1377:
---
Fix Version/s: 1.0.0
> Improve codestyle, java api usage
> -
>
> Key: RANGER-1377
> URL: https://issues.apache.org/jira/browse/RANGER-1377
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Affects Versions: 0.7.0
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
> Labels: code-cleanup
> Fix For: 1.0.0
>
>
> There are several generally considered best practice writing Java code, it is
> better to follow them.
> Instead of:
> * var.equals("somestring") use "somestring".equals(var)
> * collection.size() > 0 use !collection.isEmpty()
> * instead of using a for loop to add items to a collection, use 'addAll'
> * str.indexOf("something") >= 0 use str.contains("something")
> * "" + var use String.valueOf(var)
> * stringBuilder.append("a" + b + "c") use
> stringBuilder.append("a").append(b).append("c")
> * "something "+ a.toString() use "something " + a
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1377) Improve codestyle, java api usage
[
https://issues.apache.org/jira/browse/RANGER-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1377:
---
Affects Version/s: 0.7.0
> Improve codestyle, java api usage
> -
>
> Key: RANGER-1377
> URL: https://issues.apache.org/jira/browse/RANGER-1377
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Affects Versions: 0.7.0
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
> Labels: code-cleanup
> Fix For: 1.0.0
>
>
> There are several generally considered best practice writing Java code, it is
> better to follow them.
> Instead of:
> * var.equals("somestring") use "somestring".equals(var)
> * collection.size() > 0 use !collection.isEmpty()
> * instead of using a for loop to add items to a collection, use 'addAll'
> * str.indexOf("something") >= 0 use str.contains("something")
> * "" + var use String.valueOf(var)
> * stringBuilder.append("a" + b + "c") use
> stringBuilder.append("a").append(b).append("c")
> * "something "+ a.toString() use "something " + a
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1377) Improve codestyle, java api usage
[
https://issues.apache.org/jira/browse/RANGER-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1377:
---
Attachment: 0002-RANGER-1377-code-cleanup-in-security-admin-module.patch
0001-RANGER-1377-code-cleanup-in-agents-common-module.patch
> Improve codestyle, java api usage
> -
>
> Key: RANGER-1377
> URL: https://issues.apache.org/jira/browse/RANGER-1377
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Affects Versions: 0.7.0
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
> Labels: code-cleanup
> Fix For: 1.0.0
>
> Attachments:
> 0001-RANGER-1377-code-cleanup-in-agents-common-module.patch,
> 0002-RANGER-1377-code-cleanup-in-security-admin-module.patch
>
>
> There are several generally considered best practice writing Java code, it is
> better to follow them.
> Instead of:
> * var.equals("somestring") use "somestring".equals(var)
> * collection.size() > 0 use !collection.isEmpty()
> * instead of using a for loop to add items to a collection, use 'addAll'
> * str.indexOf("something") >= 0 use str.contains("something")
> * "" + var use String.valueOf(var)
> * stringBuilder.append("a" + b + "c") use
> stringBuilder.append("a").append(b).append("c")
> * "something "+ a.toString() use "something " + a
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1376) Several different jersey/jackson library is used
[ https://issues.apache.org/jira/browse/RANGER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1376: --- Attachment: 0002-RANGER-1376-fix-jackson-version-number.patch 0001-RANGER-1376-Upgrade-jersey-to-1.19.3.patch The splitted patch > Several different jersey/jackson library is used > > > Key: RANGER-1376 > URL: https://issues.apache.org/jira/browse/RANGER-1376 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: upgrade > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1376-Upgrade-jersey-to-1.19.3.patch, > 0002-RANGER-1376-fix-jackson-version-number.patch > > > It seems, that ranger currently use several different versions from the > jersey library: > * 1.19 - sun-jersey-bundle.version (also inherited from hadoop-common) > * 1.4 - sun.jersey.bundle.version,sun.jersey.core.version, > sun.jersey.spring.version > * 1.9 - jersey-server.version > * 1.17.1 - jersey-bundle.version > This could cause incompatibilities and confusions - during development and > during build, so it's worth to upgrade jersey, consistently to 1.19.3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1376) Several different jersey/jackson library is used
[ https://issues.apache.org/jira/browse/RANGER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1376: --- Attachment: (was: 0001-RANGER-1376-Upgrade-jersey-to-1.19.3-and-trying-to-r.patch) > Several different jersey/jackson library is used > > > Key: RANGER-1376 > URL: https://issues.apache.org/jira/browse/RANGER-1376 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: upgrade > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1376-Upgrade-jersey-to-1.19.3.patch, > 0002-RANGER-1376-fix-jackson-version-number.patch > > > It seems, that ranger currently use several different versions from the > jersey library: > * 1.19 - sun-jersey-bundle.version (also inherited from hadoop-common) > * 1.4 - sun.jersey.bundle.version,sun.jersey.core.version, > sun.jersey.spring.version > * 1.9 - jersey-server.version > * 1.17.1 - jersey-bundle.version > This could cause incompatibilities and confusions - during development and > during build, so it's worth to upgrade jersey, consistently to 1.19.3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1377) Improve codestyle, java api usage
[
https://issues.apache.org/jira/browse/RANGER-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1377:
---
Attachment: 0001-RANGER-1377-code-cleanup-in-security-admin-module.patch
> Improve codestyle, java api usage
> -
>
> Key: RANGER-1377
> URL: https://issues.apache.org/jira/browse/RANGER-1377
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Affects Versions: 0.7.0
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
> Labels: code-cleanup
> Fix For: 1.0.0
>
> Attachments:
> 0001-RANGER-1377-code-cleanup-in-agents-common-module.patch,
> 0001-RANGER-1377-code-cleanup-in-security-admin-module.patch
>
>
> There are several generally considered best practice writing Java code, it is
> better to follow them.
> Instead of:
> * var.equals("somestring") use "somestring".equals(var)
> * collection.size() > 0 use !collection.isEmpty()
> * instead of using a for loop to add items to a collection, use 'addAll'
> * str.indexOf("something") >= 0 use str.contains("something")
> * "" + var use String.valueOf(var)
> * stringBuilder.append("a" + b + "c") use
> stringBuilder.append("a").append(b).append("c")
> * "something "+ a.toString() use "something " + a
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1377) Improve codestyle, java api usage
[
https://issues.apache.org/jira/browse/RANGER-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1377:
---
Attachment: (was:
0002-RANGER-1377-code-cleanup-in-security-admin-module.patch)
> Improve codestyle, java api usage
> -
>
> Key: RANGER-1377
> URL: https://issues.apache.org/jira/browse/RANGER-1377
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Affects Versions: 0.7.0
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
> Labels: code-cleanup
> Fix For: 1.0.0
>
> Attachments:
> 0001-RANGER-1377-code-cleanup-in-agents-common-module.patch,
> 0001-RANGER-1377-code-cleanup-in-security-admin-module.patch
>
>
> There are several generally considered best practice writing Java code, it is
> better to follow them.
> Instead of:
> * var.equals("somestring") use "somestring".equals(var)
> * collection.size() > 0 use !collection.isEmpty()
> * instead of using a for loop to add items to a collection, use 'addAll'
> * str.indexOf("something") >= 0 use str.contains("something")
> * "" + var use String.valueOf(var)
> * stringBuilder.append("a" + b + "c") use
> stringBuilder.append("a").append(b).append("c")
> * "something "+ a.toString() use "something " + a
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (RANGER-1393) RangerAuditFields generic type is incorrectly specified
Zsombor Gegesy created RANGER-1393: -- Summary: RangerAuditFields generic type is incorrectly specified Key: RANGER-1393 URL: https://issues.apache.org/jira/browse/RANGER-1393 Project: Ranger Issue Type: Improvement Components: Ranger Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Priority: Minor Fix For: 1.0.0 RangerAuditFields has a class level generic parameter instead of a method level generic parameter. Because this, otherwise unnecessary casts are needs to be written -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1393) RangerAuditFields generic type is incorrectly specified
[ https://issues.apache.org/jira/browse/RANGER-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1393: --- Attachment: 0001-RANGER-1393-Fix-generic-types-in-RangerAuditFields.patch > RangerAuditFields generic type is incorrectly specified > --- > > Key: RANGER-1393 > URL: https://issues.apache.org/jira/browse/RANGER-1393 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Minor > Labels: code-cleanup > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1393-Fix-generic-types-in-RangerAuditFields.patch > > > RangerAuditFields has a class level generic parameter instead of a method > level generic parameter. Because this, otherwise unnecessary casts are needs > to be written -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1377) Improve codestyle, java api usage
[
https://issues.apache.org/jira/browse/RANGER-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1377:
---
Attachment: (was:
0001-RANGER-1377-code-cleanup-in-security-admin-module.patch)
> Improve codestyle, java api usage
> -
>
> Key: RANGER-1377
> URL: https://issues.apache.org/jira/browse/RANGER-1377
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Affects Versions: 0.7.0
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
> Labels: code-cleanup
> Fix For: 1.0.0
>
> Attachments:
> 0001-RANGER-1377-code-cleanup-in-agents-common-module.patch
>
>
> There are several generally considered best practice writing Java code, it is
> better to follow them.
> Instead of:
> * var.equals("somestring") use "somestring".equals(var)
> * collection.size() > 0 use !collection.isEmpty()
> * instead of using a for loop to add items to a collection, use 'addAll'
> * str.indexOf("something") >= 0 use str.contains("something")
> * "" + var use String.valueOf(var)
> * stringBuilder.append("a" + b + "c") use
> stringBuilder.append("a").append(b).append("c")
> * "something "+ a.toString() use "something " + a
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1377) Improve codestyle, java api usage
[
https://issues.apache.org/jira/browse/RANGER-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1377:
---
Attachment: 0003-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch
0002-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch
0001-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch
Separated to 3 patches
> Improve codestyle, java api usage
> -
>
> Key: RANGER-1377
> URL: https://issues.apache.org/jira/browse/RANGER-1377
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Affects Versions: 0.7.0
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
> Labels: code-cleanup
> Fix For: 1.0.0
>
> Attachments:
> 0001-RANGER-1377-code-cleanup-in-agents-common-module.patch,
> 0001-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch,
> 0002-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch,
> 0003-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch
>
>
> There are several generally considered best practice writing Java code, it is
> better to follow them.
> Instead of:
> * var.equals("somestring") use "somestring".equals(var)
> * collection.size() > 0 use !collection.isEmpty()
> * instead of using a for loop to add items to a collection, use 'addAll'
> * str.indexOf("something") >= 0 use str.contains("something")
> * "" + var use String.valueOf(var)
> * stringBuilder.append("a" + b + "c") use
> stringBuilder.append("a").append(b).append("c")
> * "something "+ a.toString() use "something " + a
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1393) RangerAuditFields generic type is incorrectly specified
[ https://issues.apache.org/jira/browse/RANGER-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1393: --- Attachment: 0001-RANGER-1393-Fix-generic-types-in-RangerAuditFields.patch Updated patch > RangerAuditFields generic type is incorrectly specified > --- > > Key: RANGER-1393 > URL: https://issues.apache.org/jira/browse/RANGER-1393 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Minor > Labels: code-cleanup > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1393-Fix-generic-types-in-RangerAuditFields.patch, > 0001-RANGER-1393-Fix-generic-types-in-RangerAuditFields.patch > > > RangerAuditFields has a class level generic parameter instead of a method > level generic parameter. Because this, otherwise unnecessary casts are needs > to be written -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1393) RangerAuditFields generic type is incorrectly specified
[ https://issues.apache.org/jira/browse/RANGER-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1393: --- Attachment: (was: 0001-RANGER-1393-Fix-generic-types-in-RangerAuditFields.patch) > RangerAuditFields generic type is incorrectly specified > --- > > Key: RANGER-1393 > URL: https://issues.apache.org/jira/browse/RANGER-1393 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Minor > Labels: code-cleanup > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1393-Fix-generic-types-in-RangerAuditFields.patch > > > RangerAuditFields has a class level generic parameter instead of a method > level generic parameter. Because this, otherwise unnecessary casts are needs > to be written -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (RANGER-1427) Remove dead code from XResourceService
Zsombor Gegesy created RANGER-1427: -- Summary: Remove dead code from XResourceService Key: RANGER-1427 URL: https://issues.apache.org/jira/browse/RANGER-1427 Project: Ranger Issue Type: Bug Components: admin Affects Versions: 0.7.0 Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Fix For: 1.0.0 During code review, I've noticed that XResourceService calls Boolean.getBoolean, which is usually a very suspicious signal - it is rarely used, and can be easily confused with Boolean.valueOf. After more investigation, I figured out that that code is never called, so it can be removed -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1427) Remove dead code from XResourceService
[ https://issues.apache.org/jira/browse/RANGER-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1427: --- Attachment: 0001-RANGER-1428-Remove-a-lot-of-not-used-code-found-beca.patch > Remove dead code from XResourceService > -- > > Key: RANGER-1427 > URL: https://issues.apache.org/jira/browse/RANGER-1427 > Project: Ranger > Issue Type: Bug > Components: admin >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: code-cleanup > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1428-Remove-a-lot-of-not-used-code-found-beca.patch > > > During code review, I've noticed that XResourceService calls > Boolean.getBoolean, which is usually a very suspicious signal - it is rarely > used, and can be easily confused with Boolean.valueOf. After more > investigation, I figured out that that code is never called, so it can be > removed -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (RANGER-1478) Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many times
Zsombor Gegesy created RANGER-1478: -- Summary: Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many times Key: RANGER-1478 URL: https://issues.apache.org/jira/browse/RANGER-1478 Project: Ranger Issue Type: Improvement Components: plugins Affects Versions: 0.7.0 Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Priority: Minor Fix For: 1.0.0 RangerPolicyEngineOptions has a lot of public fields, which is written from various places from the code base, which should be avoided. That object is configured from RangerConfiguration, but in the middle of the plugin initialization code, which makes this a bit more complex, than it should be. Suggestions: * RangerConfiguration should be treated as an object, not a static facade for a couple of config values * RangerPolicyEngineOptions should get his configuration from directly the RangerConfiguration, in an explicit, encapsulated way. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1478) Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many times
[ https://issues.apache.org/jira/browse/RANGER-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1478: --- Attachment: 0001-RANGER-1478-Small-refactor-in-RangerPolicyEngineCach.patch > Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many > times > --- > > Key: RANGER-1478 > URL: https://issues.apache.org/jira/browse/RANGER-1478 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Minor > Labels: code-cleanup > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1478-Small-refactor-in-RangerPolicyEngineCach.patch > > > RangerPolicyEngineOptions has a lot of public fields, which is written from > various places from the code base, which should be avoided. That object is > configured from RangerConfiguration, but in the middle of the plugin > initialization code, which makes this a bit more complex, than it should be. > Suggestions: > * RangerConfiguration should be treated as an object, not a static facade for > a couple of config values > * RangerPolicyEngineOptions should get his configuration from directly the > RangerConfiguration, in an explicit, encapsulated way. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (RANGER-1479) Plugins couldnt load settings xml files from the classpath, if they are inside a jar
Zsombor Gegesy created RANGER-1479: -- Summary: Plugins couldnt load settings xml files from the classpath, if they are inside a jar Key: RANGER-1479 URL: https://issues.apache.org/jira/browse/RANGER-1479 Project: Ranger Issue Type: Bug Components: plugins Affects Versions: 0.7.0 Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Fix For: 1.0.0 RangerConfiguration first checks, if the necessary xml files are on the classpath, and after it tries to convert it to a file path, check that file is on the filesystem, and convert that path to back to URL. If the configurations are inside a jar, then this will fail very badly (the resource url will be something file://config.jar!/ranger-services.xml ) If the conversion is removed, it would work pretty nicely -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (RANGER-1480) Implement plugin for Druid
Zsombor Gegesy created RANGER-1480: -- Summary: Implement plugin for Druid Key: RANGER-1480 URL: https://issues.apache.org/jira/browse/RANGER-1480 Project: Ranger Issue Type: New Feature Components: admin, plugins Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Druid is a high-performance, column-oriented, distributed data store, which has an extension mechanism to incorporate various functionalities, for example an external authorization system - just like ranger. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1480) Implement plugin for Druid
[ https://issues.apache.org/jira/browse/RANGER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1480: --- Attachment: 0001-RANGER-1480-First-version-of-the-druid-plugin.-Only-.patch > Implement plugin for Druid > -- > > Key: RANGER-1480 > URL: https://issues.apache.org/jira/browse/RANGER-1480 > Project: Ranger > Issue Type: New Feature > Components: admin, plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Attachments: > 0001-RANGER-1480-First-version-of-the-druid-plugin.-Only-.patch > > > Druid is a high-performance, column-oriented, distributed data store, which > has an extension mechanism to incorporate various functionalities, for > example an external authorization system - just like ranger. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1479) Plugins couldnt load settings xml files from the classpath, if they are inside a jar
[ https://issues.apache.org/jira/browse/RANGER-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1479: --- Attachment: 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch > Plugins couldnt load settings xml files from the classpath, if they are > inside a jar > > > Key: RANGER-1479 > URL: https://issues.apache.org/jira/browse/RANGER-1479 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: configuration, plugins > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch > > > RangerConfiguration first checks, if the necessary xml files are on the > classpath, and after it tries to convert it to a file path, check that file > is on the filesystem, and convert that path to back to URL. If the > configurations are inside a jar, then this will fail very badly (the > resource url will be something file://config.jar!/ranger-services.xml ) > If the conversion is removed, it would work pretty nicely -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1479) Plugins couldnt load settings xml files from the classpath, if they are inside a jar
[ https://issues.apache.org/jira/browse/RANGER-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1479: --- Attachment: 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch > Plugins couldnt load settings xml files from the classpath, if they are > inside a jar > > > Key: RANGER-1479 > URL: https://issues.apache.org/jira/browse/RANGER-1479 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: configuration, plugins > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch > > > RangerConfiguration first checks, if the necessary xml files are on the > classpath, and after it tries to convert it to a file path, check that file > is on the filesystem, and convert that path to back to URL. If the > configurations are inside a jar, then this will fail very badly (the > resource url will be something file://config.jar!/ranger-services.xml ) > If the conversion is removed, it would work pretty nicely -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1479) Plugins couldnt load settings xml files from the classpath, if they are inside a jar
[ https://issues.apache.org/jira/browse/RANGER-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1479: --- Attachment: (was: 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch) > Plugins couldnt load settings xml files from the classpath, if they are > inside a jar > > > Key: RANGER-1479 > URL: https://issues.apache.org/jira/browse/RANGER-1479 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: configuration, plugins > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch > > > RangerConfiguration first checks, if the necessary xml files are on the > classpath, and after it tries to convert it to a file path, check that file > is on the filesystem, and convert that path to back to URL. If the > configurations are inside a jar, then this will fail very badly (the > resource url will be something file://config.jar!/ranger-services.xml ) > If the conversion is removed, it would work pretty nicely -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1479) Plugins couldnt load settings xml files from the classpath, if they are inside a jar
[ https://issues.apache.org/jira/browse/RANGER-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1479: --- Attachment: 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch > Plugins couldnt load settings xml files from the classpath, if they are > inside a jar > > > Key: RANGER-1479 > URL: https://issues.apache.org/jira/browse/RANGER-1479 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: configuration, plugins > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch > > > RangerConfiguration first checks, if the necessary xml files are on the > classpath, and after it tries to convert it to a file path, check that file > is on the filesystem, and convert that path to back to URL. If the > configurations are inside a jar, then this will fail very badly (the > resource url will be something file://config.jar!/ranger-services.xml ) > If the conversion is removed, it would work pretty nicely -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1479) Plugins couldnt load settings xml files from the classpath, if they are inside a jar
[ https://issues.apache.org/jira/browse/RANGER-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1479: --- Attachment: (was: 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch) > Plugins couldnt load settings xml files from the classpath, if they are > inside a jar > > > Key: RANGER-1479 > URL: https://issues.apache.org/jira/browse/RANGER-1479 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: configuration, plugins > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1479-Fix-bug-in-ranger-security-audit-.xml-lo.patch > > > RangerConfiguration first checks, if the necessary xml files are on the > classpath, and after it tries to convert it to a file path, check that file > is on the filesystem, and convert that path to back to URL. If the > configurations are inside a jar, then this will fail very badly (the > resource url will be something file://config.jar!/ranger-services.xml ) > If the conversion is removed, it would work pretty nicely -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1478) Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many times
[ https://issues.apache.org/jira/browse/RANGER-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1478: --- Attachment: 0001-RANGER-1478-Small-refactor-in-RangerPolicyEngineCach.patch > Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many > times > --- > > Key: RANGER-1478 > URL: https://issues.apache.org/jira/browse/RANGER-1478 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Minor > Labels: code-cleanup > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1478-Small-refactor-in-RangerPolicyEngineCach.patch > > > RangerPolicyEngineOptions has a lot of public fields, which is written from > various places from the code base, which should be avoided. That object is > configured from RangerConfiguration, but in the middle of the plugin > initialization code, which makes this a bit more complex, than it should be. > Suggestions: > * RangerConfiguration should be treated as an object, not a static facade for > a couple of config values > * RangerPolicyEngineOptions should get his configuration from directly the > RangerConfiguration, in an explicit, encapsulated way. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1478) Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many times
[ https://issues.apache.org/jira/browse/RANGER-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1478: --- Attachment: (was: 0001-RANGER-1478-Small-refactor-in-RangerPolicyEngineCach.patch) > Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many > times > --- > > Key: RANGER-1478 > URL: https://issues.apache.org/jira/browse/RANGER-1478 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Minor > Labels: code-cleanup > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1478-Small-refactor-in-RangerPolicyEngineCach.patch > > > RangerPolicyEngineOptions has a lot of public fields, which is written from > various places from the code base, which should be avoided. That object is > configured from RangerConfiguration, but in the middle of the plugin > initialization code, which makes this a bit more complex, than it should be. > Suggestions: > * RangerConfiguration should be treated as an object, not a static facade for > a couple of config values > * RangerPolicyEngineOptions should get his configuration from directly the > RangerConfiguration, in an explicit, encapsulated way. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1377) Improve codestyle, java api usage
[
https://issues.apache.org/jira/browse/RANGER-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1377:
---
Attachment: (was:
0001-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch)
> Improve codestyle, java api usage
> -
>
> Key: RANGER-1377
> URL: https://issues.apache.org/jira/browse/RANGER-1377
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Affects Versions: 0.7.0
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
> Labels: code-cleanup
> Fix For: 1.0.0
>
> Attachments:
> 0001-RANGER-1377-code-cleanup-in-agents-common-module.patch,
> 0001-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch,
> 0002-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch,
> 0003-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch
>
>
> There are several generally considered best practice writing Java code, it is
> better to follow them.
> Instead of:
> * var.equals("somestring") use "somestring".equals(var)
> * collection.size() > 0 use !collection.isEmpty()
> * instead of using a for loop to add items to a collection, use 'addAll'
> * str.indexOf("something") >= 0 use str.contains("something")
> * "" + var use String.valueOf(var)
> * stringBuilder.append("a" + b + "c") use
> stringBuilder.append("a").append(b).append("c")
> * "something "+ a.toString() use "something " + a
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1377) Improve codestyle, java api usage
[
https://issues.apache.org/jira/browse/RANGER-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1377:
---
Attachment: 0001-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch
Updated patch about string-comparisons
> Improve codestyle, java api usage
> -
>
> Key: RANGER-1377
> URL: https://issues.apache.org/jira/browse/RANGER-1377
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Affects Versions: 0.7.0
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
> Labels: code-cleanup
> Fix For: 1.0.0
>
> Attachments:
> 0001-RANGER-1377-code-cleanup-in-agents-common-module.patch,
> 0001-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch,
> 0002-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch,
> 0003-RANGER-1377-code-cleanup-in-the-security-admin-modul.patch
>
>
> There are several generally considered best practice writing Java code, it is
> better to follow them.
> Instead of:
> * var.equals("somestring") use "somestring".equals(var)
> * collection.size() > 0 use !collection.isEmpty()
> * instead of using a for loop to add items to a collection, use 'addAll'
> * str.indexOf("something") >= 0 use str.contains("something")
> * "" + var use String.valueOf(var)
> * stringBuilder.append("a" + b + "c") use
> stringBuilder.append("a").append(b).append("c")
> * "something "+ a.toString() use "something " + a
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1478) Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many times
[ https://issues.apache.org/jira/browse/RANGER-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1478: --- Attachment: (was: 0001-RANGER-1478-Small-refactor-in-RangerPolicyEngineCach.patch) > Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many > times > --- > > Key: RANGER-1478 > URL: https://issues.apache.org/jira/browse/RANGER-1478 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Minor > Labels: code-cleanup > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1478-Small-refactor-in-RangerPolicyEngineCach.patch > > > RangerPolicyEngineOptions has a lot of public fields, which is written from > various places from the code base, which should be avoided. That object is > configured from RangerConfiguration, but in the middle of the plugin > initialization code, which makes this a bit more complex, than it should be. > Suggestions: > * RangerConfiguration should be treated as an object, not a static facade for > a couple of config values > * RangerPolicyEngineOptions should get his configuration from directly the > RangerConfiguration, in an explicit, encapsulated way. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1478) Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many times
[ https://issues.apache.org/jira/browse/RANGER-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1478: --- Attachment: 0001-RANGER-1478-Small-refactor-in-RangerPolicyEngineCach.patch > Refactor RangerPolicyEngineOptions, RangerConfiguration is looked up too many > times > --- > > Key: RANGER-1478 > URL: https://issues.apache.org/jira/browse/RANGER-1478 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Minor > Labels: code-cleanup > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1478-Small-refactor-in-RangerPolicyEngineCach.patch > > > RangerPolicyEngineOptions has a lot of public fields, which is written from > various places from the code base, which should be avoided. That object is > configured from RangerConfiguration, but in the middle of the plugin > initialization code, which makes this a bit more complex, than it should be. > Suggestions: > * RangerConfiguration should be treated as an object, not a static facade for > a couple of config values > * RangerPolicyEngineOptions should get his configuration from directly the > RangerConfiguration, in an explicit, encapsulated way. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (RANGER-1431) Do some code improvement in Java method AuthSessionService.mapEntityToViewBean
[
https://issues.apache.org/jira/browse/RANGER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994706#comment-15994706
]
Zsombor Gegesy commented on RANGER-1431:
This should be added to the 0.7 branch as well, I've created a review request
for it :
https://reviews.apache.org/r/58959/
> Do some code improvement in Java method AuthSessionService.mapEntityToViewBean
> --
>
> Key: RANGER-1431
> URL: https://issues.apache.org/jira/browse/RANGER-1431
> Project: Ranger
> Issue Type: Bug
> Components: admin
>Affects Versions: master
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Minor
> Labels: patch
> Fix For: 1.0.0
>
> Attachments:
> 0001-RANGER-1431-Do-some-code-improvement-in-Java-method-.patch
>
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> In method mapEntityToViewBean of class
> \security-admin\src\main\java\org\apache\ranger\service\AuthSessionService.java,
> there is some code can be improved:
> 1.The following code is repated twice, remove one of them.
> {code}
> viewObj.setLastName(gjUser.getLastName());
> {code}
> 2.Check null before using gjUser.
> {code}
> XXPortalUser gjUser = daoMgr.getXXPortalUser().getById(resource.getUserId());
> {code}
> 3.Family name should be last name instead of email address.
> {code}
> viewObj.setFamilyScreenName(gjUser.getEmailAddress());
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1480) Implement plugin for Druid
[ https://issues.apache.org/jira/browse/RANGER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1480: --- Attachment: 0001-RANGER-1480-Second-version-of-the-druid-plugin.patch > Implement plugin for Druid > -- > > Key: RANGER-1480 > URL: https://issues.apache.org/jira/browse/RANGER-1480 > Project: Ranger > Issue Type: New Feature > Components: admin, plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Attachments: > 0001-RANGER-1480-First-version-of-the-druid-plugin.-Only-.patch, > 0001-RANGER-1480-Second-version-of-the-druid-plugin.patch > > > Druid is a high-performance, column-oriented, distributed data store, which > has an extension mechanism to incorporate various functionalities, for > example an external authorization system - just like ranger. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1480) Implement plugin for Druid
[ https://issues.apache.org/jira/browse/RANGER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1480: --- Attachment: (was: 0001-RANGER-1480-First-version-of-the-druid-plugin.-Only-.patch) > Implement plugin for Druid > -- > > Key: RANGER-1480 > URL: https://issues.apache.org/jira/browse/RANGER-1480 > Project: Ranger > Issue Type: New Feature > Components: admin, plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1480-Second-version-of-the-druid-plugin.patch > > > Druid is a high-performance, column-oriented, distributed data store, which > has an extension mechanism to incorporate various functionalities, for > example an external authorization system - just like ranger. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1480) Implement plugin for Druid
[ https://issues.apache.org/jira/browse/RANGER-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1480: --- Fix Version/s: 1.0.0 > Implement plugin for Druid > -- > > Key: RANGER-1480 > URL: https://issues.apache.org/jira/browse/RANGER-1480 > Project: Ranger > Issue Type: New Feature > Components: admin, plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1480-Second-version-of-the-druid-plugin.patch > > > Druid is a high-performance, column-oriented, distributed data store, which > has an extension mechanism to incorporate various functionalities, for > example an external authorization system - just like ranger. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (RANGER-1618) PasswordUtil is not thread-safe
Zsombor Gegesy created RANGER-1618: -- Summary: PasswordUtil is not thread-safe Key: RANGER-1618 URL: https://issues.apache.org/jira/browse/RANGER-1618 Project: Ranger Issue Type: Bug Components: plugins Affects Versions: master Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Fix For: 1.0.0 As the PasswordUtil has a couple of static variables, which is modified during the encryptPassword/decyptPassword calls - there is a possibility that concurrent calls overwrites the values, resulting in a hard to debug errors. And it would be nice to add a couple of tests for this utility. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RANGER-1618) PasswordUtil is not thread-safe
[ https://issues.apache.org/jira/browse/RANGER-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1618: --- Attachment: 0001-RANGER-1618-Static-mutable-variables-are-a-way-to-in.patch > PasswordUtil is not thread-safe > --- > > Key: RANGER-1618 > URL: https://issues.apache.org/jira/browse/RANGER-1618 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: master >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: concurrency, security, thread-safety > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1618-Static-mutable-variables-are-a-way-to-in.patch > > > As the PasswordUtil has a couple of static variables, which is modified > during the encryptPassword/decyptPassword calls - there is a possibility that > concurrent calls overwrites the values, resulting in a hard to debug errors. > And it would be nice to add a couple of tests for this utility. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (RANGER-1646) Error messages in RangerRESTClient aren't helpful
Zsombor Gegesy created RANGER-1646: -- Summary: Error messages in RangerRESTClient aren't helpful Key: RANGER-1646 URL: https://issues.apache.org/jira/browse/RANGER-1646 Project: Ranger Issue Type: Bug Components: plugins Affects Versions: 0.7.1 Reporter: Zsombor Gegesy Fix For: 1.0.0 Currently, if the user accidentally configures the SSL settings incorrectly, or the keystore/truststore is not exists or not readable, then the user will receive a not too helpful 'SSLContext must not be null' coming from the com.sun.jersey.client.urlconnection.HTTPSProperties This happens, because RangerRESTClient.getKeyManagers / getTrustManagers / getSSLContext methods are catching the exceptions, and are returning null, instead of failing fast, so the user could easily act and fix the issues -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (RANGER-1646) Error messages in RangerRESTClient aren't helpful
[ https://issues.apache.org/jira/browse/RANGER-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy reassigned RANGER-1646: -- Assignee: Zsombor Gegesy > Error messages in RangerRESTClient aren't helpful > - > > Key: RANGER-1646 > URL: https://issues.apache.org/jira/browse/RANGER-1646 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 0.7.1 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: exception-handling, plugins, ssl > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1646-Instead-of-catching-the-errors.patch > > > Currently, if the user accidentally configures the SSL settings incorrectly, > or the keystore/truststore is not exists or not readable, then the user will > receive a not too helpful 'SSLContext must not be null' coming from the > com.sun.jersey.client.urlconnection.HTTPSProperties > This happens, because RangerRESTClient.getKeyManagers / getTrustManagers / > getSSLContext methods are catching the exceptions, and are returning null, > instead of failing fast, so the user could easily act and fix the issues -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1646) Error messages in RangerRESTClient aren't helpful
[ https://issues.apache.org/jira/browse/RANGER-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1646: --- Attachment: 0001-RANGER-1646-Instead-of-catching-the-errors.patch > Error messages in RangerRESTClient aren't helpful > - > > Key: RANGER-1646 > URL: https://issues.apache.org/jira/browse/RANGER-1646 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 0.7.1 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: exception-handling, plugins, ssl > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1646-Instead-of-catching-the-errors.patch > > > Currently, if the user accidentally configures the SSL settings incorrectly, > or the keystore/truststore is not exists or not readable, then the user will > receive a not too helpful 'SSLContext must not be null' coming from the > com.sun.jersey.client.urlconnection.HTTPSProperties > This happens, because RangerRESTClient.getKeyManagers / getTrustManagers / > getSSLContext methods are catching the exceptions, and are returning null, > instead of failing fast, so the user could easily act and fix the issues -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1646) Error messages in RangerRESTClient aren't helpful
[ https://issues.apache.org/jira/browse/RANGER-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1646: --- Attachment: (was: 0001-RANGER-1646-Instead-of-catching-the-errors.patch) > Error messages in RangerRESTClient aren't helpful > - > > Key: RANGER-1646 > URL: https://issues.apache.org/jira/browse/RANGER-1646 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 0.7.1 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: exception-handling, plugins, ssl > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1646-Instead-of-catching-the-errors.patch > > > Currently, if the user accidentally configures the SSL settings incorrectly, > or the keystore/truststore is not exists or not readable, then the user will > receive a not too helpful 'SSLContext must not be null' coming from the > com.sun.jersey.client.urlconnection.HTTPSProperties > This happens, because RangerRESTClient.getKeyManagers / getTrustManagers / > getSSLContext methods are catching the exceptions, and are returning null, > instead of failing fast, so the user could easily act and fix the issues -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1646) Error messages in RangerRESTClient aren't helpful
[ https://issues.apache.org/jira/browse/RANGER-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1646: --- Attachment: 0001-RANGER-1646-Instead-of-catching-the-errors.patch The last, reviewed version > Error messages in RangerRESTClient aren't helpful > - > > Key: RANGER-1646 > URL: https://issues.apache.org/jira/browse/RANGER-1646 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 0.7.1 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: exception-handling, plugins, ssl > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1646-Instead-of-catching-the-errors.patch > > > Currently, if the user accidentally configures the SSL settings incorrectly, > or the keystore/truststore is not exists or not readable, then the user will > receive a not too helpful 'SSLContext must not be null' coming from the > com.sun.jersey.client.urlconnection.HTTPSProperties > This happens, because RangerRESTClient.getKeyManagers / getTrustManagers / > getSSLContext methods are catching the exceptions, and are returning null, > instead of failing fast, so the user could easily act and fix the issues -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (RANGER-1706) Running CI on Travis
Zsombor Gegesy created RANGER-1706: -- Summary: Running CI on Travis Key: RANGER-1706 URL: https://issues.apache.org/jira/browse/RANGER-1706 Project: Ranger Issue Type: Improvement Components: Ranger Reporter: Zsombor Gegesy It would be good, if there were a continuous build/tests were executed on the branches, so test failures could be detected more easily. For this, travis provides a free service for OS projects, just a travis.yml needs to be added to the repository. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (RANGER-1706) Running CI on Travis
[ https://issues.apache.org/jira/browse/RANGER-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy reassigned RANGER-1706: -- Assignee: Zsombor Gegesy > Running CI on Travis > > > Key: RANGER-1706 > URL: https://issues.apache.org/jira/browse/RANGER-1706 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: building, ci > > It would be good, if there were a continuous build/tests were executed on the > branches, so test failures could be detected more easily. > For this, travis provides a free service for OS projects, just a travis.yml > needs to be added to the repository. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1706) Running CI on Travis
[ https://issues.apache.org/jira/browse/RANGER-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1706: --- Attachment: 0001-RANGER-1707-Add-travis.yml-for-validating-Ranger-wit.patch > Running CI on Travis > > > Key: RANGER-1706 > URL: https://issues.apache.org/jira/browse/RANGER-1706 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: building, ci > Attachments: > 0001-RANGER-1707-Add-travis.yml-for-validating-Ranger-wit.patch > > > It would be good, if there were a continuous build/tests were executed on the > branches, so test failures could be detected more easily. > For this, travis provides a free service for OS projects, just a travis.yml > needs to be added to the repository. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (RANGER-1707) Traverse check in RangerHdfsAuthorizer works incorrectly
Zsombor Gegesy created RANGER-1707: -- Summary: Traverse check in RangerHdfsAuthorizer works incorrectly Key: RANGER-1707 URL: https://issues.apache.org/jira/browse/RANGER-1707 Project: Ranger Issue Type: Bug Components: plugins Affects Versions: 1.0.0 Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Fix For: 1.0.0 Traversal check in RangerHdfsAuthorizer works incorrectly, when it is asked for access to /a/b/c.txt, it only checks that if there are a policy which grants EXEC to /a/b, but if it there aren't any, then it doesn't check, if there is a policy which grants READ, WRITE or EXEC to /a/b/c.txt explicitly, which would mean, that the path is accessible to the user. This hasn't noticed by the current unit tests, because HDFS before 2.8.0 doesn't called the traversal check before reading or writing a file, however it will cause problem with 2.8.0, where FSDirectory.resolvePath will perform a mandatory traversal check. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1707) Traverse check in RangerHdfsAuthorizer works incorrectly
[ https://issues.apache.org/jira/browse/RANGER-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1707: --- Attachment: 0001-RANGER-1707-Fix-hdfs-traverse-check-which-problem-wa.patch > Traverse check in RangerHdfsAuthorizer works incorrectly > > > Key: RANGER-1707 > URL: https://issues.apache.org/jira/browse/RANGER-1707 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: 1.0.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: hdfs-2.8 > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1707-Fix-hdfs-traverse-check-which-problem-wa.patch > > > Traversal check in RangerHdfsAuthorizer works incorrectly, when it is asked > for access to /a/b/c.txt, it only checks that if there are a policy which > grants EXEC to /a/b, but if it there aren't any, then it doesn't check, if > there is a policy which grants READ, WRITE or EXEC to /a/b/c.txt explicitly, > which would mean, that the path is accessible to the user. > This hasn't noticed by the current unit tests, because HDFS before 2.8.0 > doesn't called the traversal check before reading or writing a file, however > it will cause problem with 2.8.0, where FSDirectory.resolvePath will perform > a mandatory traversal check. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1706) Running CI on Travis
[ https://issues.apache.org/jira/browse/RANGER-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1706: --- Attachment: 0001-RANGER-1706-Add-travis.yml-for-validating-Ranger-wit.patch > Running CI on Travis > > > Key: RANGER-1706 > URL: https://issues.apache.org/jira/browse/RANGER-1706 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: building, ci > Attachments: > 0001-RANGER-1706-Add-travis.yml-for-validating-Ranger-wit.patch > > > It would be good, if there were a continuous build/tests were executed on the > branches, so test failures could be detected more easily. > For this, travis provides a free service for OS projects, just a travis.yml > needs to be added to the repository. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1706) Running CI on Travis
[ https://issues.apache.org/jira/browse/RANGER-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1706: --- Attachment: (was: 0001-RANGER-1707-Add-travis.yml-for-validating-Ranger-wit.patch) > Running CI on Travis > > > Key: RANGER-1706 > URL: https://issues.apache.org/jira/browse/RANGER-1706 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: building, ci > Attachments: > 0001-RANGER-1706-Add-travis.yml-for-validating-Ranger-wit.patch > > > It would be good, if there were a continuous build/tests were executed on the > branches, so test failures could be detected more easily. > For this, travis provides a free service for OS projects, just a travis.yml > needs to be added to the repository. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (RANGER-1721) HBase plugins use deprecated code
Zsombor Gegesy created RANGER-1721: -- Summary: HBase plugins use deprecated code Key: RANGER-1721 URL: https://issues.apache.org/jira/browse/RANGER-1721 Project: Ranger Issue Type: Improvement Components: plugins Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Fix For: 1.0.0 HBase plugin use Cell.getFamily and Cell.getQualifier method, which is deprecated - and they are not simple getters, but they are creating and copying buffers, to return the values. It would be better, if this could be omitted. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (RANGER-1722) Duplicate code for exception wrapping in BaseClient
Zsombor Gegesy created RANGER-1722: -- Summary: Duplicate code for exception wrapping in BaseClient Key: RANGER-1722 URL: https://issues.apache.org/jira/browse/RANGER-1722 Project: Ranger Issue Type: Improvement Components: plugins Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Priority: Minor Fix For: 1.0.0 The exception creation code is duplicated unnecessarily, which can be easily refactored to a simpler solution -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1721) HBase plugins use deprecated code
[ https://issues.apache.org/jira/browse/RANGER-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1721: --- Attachment: 0001-RANGER-1721-Remove-deprecated-and-unused-code-from-t.patch > HBase plugins use deprecated code > - > > Key: RANGER-1721 > URL: https://issues.apache.org/jira/browse/RANGER-1721 > Project: Ranger > Issue Type: Improvement > Components: plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: code-cleanup, hbase > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1721-Remove-deprecated-and-unused-code-from-t.patch > > > HBase plugin use Cell.getFamily and Cell.getQualifier method, which is > deprecated - and they are not simple getters, but they are creating and > copying buffers, to return the values. > It would be better, if this could be omitted. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
