[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11
[ https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437002#comment-17437002 ] Martin Tzvetanov Grigorov commented on RANGER-3243: --- Closed it! > Build fails on JDK 8 and 11 > --- > > Key: RANGER-3243 > URL: https://issues.apache.org/jira/browse/RANGER-3243 > Project: Ranger > Issue Type: Task > Components: build-infra >Affects Versions: 3.0.0, 2.2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: 0001-RANGER-3243-Build-fails-on-JDK-8-and-11.patch > > Time Spent: 40m > Remaining Estimate: 0h > > The build of current master branch fails - > [https://travis-ci.com/github/apache/ranger/builds/223139469] > There are several issues: > [Issue 1|https://reviews.apache.org/r/73281/bugs/1/]) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > [Issue 2|https://reviews.apache.org/r/73281/bugs/2/]) > RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a > class that is not available in Java 9+ and this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of > JDK 11+ > [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4 > Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11
[ https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436227#comment-17436227 ] Abhishek Kumar commented on RANGER-3243: Hi [~mgrigorov], Could you please close the review: [https://reviews.apache.org/r/73281/] Thanks! > Build fails on JDK 8 and 11 > --- > > Key: RANGER-3243 > URL: https://issues.apache.org/jira/browse/RANGER-3243 > Project: Ranger > Issue Type: Task > Components: build-infra >Affects Versions: 3.0.0, 2.2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: 0001-RANGER-3243-Build-fails-on-JDK-8-and-11.patch > > Time Spent: 40m > Remaining Estimate: 0h > > The build of current master branch fails - > [https://travis-ci.com/github/apache/ranger/builds/223139469] > There are several issues: > [Issue 1|https://reviews.apache.org/r/73281/bugs/1/]) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > [Issue 2|https://reviews.apache.org/r/73281/bugs/2/]) > RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a > class that is not available in Java 9+ and this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of > JDK 11+ > [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4 > Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11
[ https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419570#comment-17419570 ] Martin Tzvetanov Grigorov commented on RANGER-3243: --- Thanks for merging it, [~rmani] ! Please also take a look at RANGER-3245: it updates .travisci.yml to test on JDK 8 and 11, on both x86_64 and arm64! This will prevent regressions in the future! > Build fails on JDK 8 and 11 > --- > > Key: RANGER-3243 > URL: https://issues.apache.org/jira/browse/RANGER-3243 > Project: Ranger > Issue Type: Task > Components: build-infra >Affects Versions: 3.0.0, 2.2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: 0001-RANGER-3243-Build-fails-on-JDK-8-and-11.patch > > Time Spent: 20m > Remaining Estimate: 0h > > The build of current master branch fails - > [https://travis-ci.com/github/apache/ranger/builds/223139469] > There are several issues: > [Issue 1|https://reviews.apache.org/r/73281/bugs/1/]) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > [Issue 2|https://reviews.apache.org/r/73281/bugs/2/]) > RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a > class that is not available in Java 9+ and this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of > JDK 11+ > [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4 > Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11
[ https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419373#comment-17419373 ] Ramesh Mani commented on RANGER-3243: - [~mgrigorov] This is committed into 2.20 and 3.0.0 branch. Thank you! > Build fails on JDK 8 and 11 > --- > > Key: RANGER-3243 > URL: https://issues.apache.org/jira/browse/RANGER-3243 > Project: Ranger > Issue Type: Task > Components: build-infra >Affects Versions: 3.0.0, 2.2.0 >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: 0001-RANGER-3243-Build-fails-on-JDK-8-and-11.patch > > Time Spent: 20m > Remaining Estimate: 0h > > The build of current master branch fails - > [https://travis-ci.com/github/apache/ranger/builds/223139469] > There are several issues: > [Issue 1|https://reviews.apache.org/r/73281/bugs/1/]) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > [Issue 2|https://reviews.apache.org/r/73281/bugs/2/]) > RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a > class that is not available in Java 9+ and this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of > JDK 11+ > [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4 > Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11
[ https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417951#comment-17417951 ] Martin Tzvetanov Grigorov commented on RANGER-3243: --- I've updated the PR and reviewboard to latest master. > Build fails on JDK 8 and 11 > --- > > Key: RANGER-3243 > URL: https://issues.apache.org/jira/browse/RANGER-3243 > Project: Ranger > Issue Type: Task > Components: build-infra >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The build of current master branch fails - > [https://travis-ci.com/github/apache/ranger/builds/223139469] > There are several issues: > [Issue 1|https://reviews.apache.org/r/73281/bugs/1/]) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > [Issue 2|https://reviews.apache.org/r/73281/bugs/2/]) > RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a > class that is not available in Java 9+ and this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of > JDK 11+ > [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4 > Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11
[
https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354296#comment-17354296
]
Martin Tzvetanov Grigorov commented on RANGER-3243:
---
JDK: build 11.0.11+9-Ubuntu-0ubuntu2.20.04
{code:java}
[INFO] Apache Ranger Distribution . SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 01:18 min
[INFO] Finished at: 2021-05-31T09:26:59+01:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on
project ranger-kms: Compilation failure
[ERROR]
/home/ubuntu/git/apache/ranger/kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java:[72,49]
error: incompatible types: String cannot be converted to Config
[ERROR]
[ERROR] -> [Help 1]
{code}
This is fixed with
https://github.com/apache/ranger/pull/96/files#diff-bc06b20fcb395424f2541febad5ba131085d2959eb99335da036f390188dd5eeR72
> Build fails on JDK 8 and 11
> ---
>
> Key: RANGER-3243
> URL: https://issues.apache.org/jira/browse/RANGER-3243
> Project: Ranger
> Issue Type: Task
> Components: build-infra
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The build of current master branch fails -
> [https://travis-ci.com/github/apache/ranger/builds/223139469]
> There are several issues:
> [Issue 1|https://reviews.apache.org/r/73281/bugs/1/])
> org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory
> was not able to import com.google.common.base.Throwables.throwIfUnchecked
> because it was coming from an old copy of Guava's Throwables shaded in
> hive-exec.
> By replacing hive-exec with orc-core in agents-audit module all depending
> modules use their preferred version of Guava (26.0-jre)
> [Issue 2|https://reviews.apache.org/r/73281/bugs/2/])
> RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a
> class that is not available in Java 9+ and this breaks the compilation.
> This should use reflection to load SunPKCS11 class dynamically.
> [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of
> JDK 11+
> [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4
> Assert.assertThat() is deprecated in favour of Hamcrest's
> MatcherAssert.assertThat(). This fixes a compilation issue with JDK11.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11
[ https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354279#comment-17354279 ] Martin Tzvetanov Grigorov commented on RANGER-3243: --- I was not able to find the problem, so I just disabled the example-distro module and the build passed for JDK 1.8. The only problem is with the UI build for security-admin because PhantomJS project does not provide ARM64 binaries. I will create a separate issue for this! > Build fails on JDK 8 and 11 > --- > > Key: RANGER-3243 > URL: https://issues.apache.org/jira/browse/RANGER-3243 > Project: Ranger > Issue Type: Task > Components: build-infra >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The build of current master branch fails - > [https://travis-ci.com/github/apache/ranger/builds/223139469] > There are several issues: > [Issue 1|https://reviews.apache.org/r/73281/bugs/1/]) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > [Issue 2|https://reviews.apache.org/r/73281/bugs/2/]) > RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a > class that is not available in Java 9+ and this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of > JDK 11+ > [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4 > Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11
[
https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354272#comment-17354272
]
Martin Tzvetanov Grigorov commented on RANGER-3243:
---
[~pradeep] I am trying to build Ranger on Linux ARM64
OS: Ubuntu 20.04.2
JDK: 1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Ranger: current master (3af3415f6fae4f655d46ffd80dd8c2ad1c8c1dec)
Maven command: mvn clean install -DskipJSTests
Today's build fails with:
{code:java}
[INFO] --- maven-assembly-plugin:2.6:single (default) @ ranger-examples-distro
---
[INFO] Reading assembly descriptor: src/main/assembly/sampleapp.xml
[INFO] Reading assembly descriptor: src/main/assembly/plugin-sampleapp.xml
[INFO] Reading assembly descriptor: src/main/assembly/sample-client.xml
[WARNING] The following patterns were never triggered in this artifact
inclusion filter:
o 'org.apache.ranger:sampleapp'[INFO]
[INFO] Reactor Summary for Ranger Examples - SampleApp 3.0.0-SNAPSHOT:
[INFO]
[INFO] Ranger Examples - SampleApp SUCCESS [ 4.472 s]
[INFO] Ranger Examples - Ranger Plugin for SampleApp .. SUCCESS [ 4.626 s]
[INFO] sample-client .. SUCCESS [ 2.798 s]
[INFO] Apache Ranger Examples Distribution FAILURE [ 1.291 s]
[INFO] Ranger Tools ... SKIPPED
[INFO] Atlas Security Plugin .. SKIPPED
[INFO] SchemaRegistry Security Plugin . SKIPPED
[INFO] Sqoop Security Plugin .. SKIPPED
[INFO] Sqoop Security Plugin Shim . SKIPPED
[INFO] Kylin Security Plugin .. SKIPPED
[INFO] Kylin Security Plugin Shim . SKIPPED
[INFO] Presto Security Plugin . SKIPPED
[INFO] Presto Security Plugin Shim SKIPPED
[INFO] Elasticsearch Security Plugin Shim . SKIPPED
[INFO] Elasticsearch Security Plugin .. SKIPPED
[INFO] Apache Ranger Distribution . SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 13.817 s
[INFO] Finished at: 2021-05-31T08:51:11+01:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-assembly-plugin:2.6:single (default) on project
ranger-examples-distro: Failed to create assembly: Error creating assembly
archive sampleapp: You must set at least one file. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
{code}
I will try to solve this problem and finish the build.
After that I will paste the Maven output for JDK 11!
> Build fails on JDK 8 and 11
> ---
>
> Key: RANGER-3243
> URL: https://issues.apache.org/jira/browse/RANGER-3243
> Project: Ranger
> Issue Type: Task
> Components: build-infra
>Reporter: Martin Tzvetanov Grigorov
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The build of current master branch fails -
> [https://travis-ci.com/github/apache/ranger/builds/223139469]
> There are several issues:
> [Issue 1|https://reviews.apache.org/r/73281/bugs/1/])
> org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory
> was not able to import com.google.common.base.Throwables.throwIfUnchecked
> because it was coming from an old copy of Guava's Throwables shaded in
> hive-exec.
> By replacing hive-exec with orc-core in agents-audit module all depending
> modules use their preferred version of Guava (26.0-jre)
> [Issue 2|https://reviews.apache.org/r/73281/bugs/2/])
> RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a
> class that is not available in Java 9+ and this breaks the compilation.
> This should use reflection to load SunPKCS11 class dynamically.
> [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of
> JDK 11+
> [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4
> Assert.assertThat() is deprecated in favour of Hamcrest's
> MatcherAssert.assertThat(). This fixes a compilation issue with JDK11.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11
[ https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354213#comment-17354213 ] Pradeep Agrawal commented on RANGER-3243: - [~mgrigorov] : Which command did you use for build and in which environment you tried the build. > Build fails on JDK 8 and 11 > --- > > Key: RANGER-3243 > URL: https://issues.apache.org/jira/browse/RANGER-3243 > Project: Ranger > Issue Type: Task > Components: build-infra >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The build of current master branch fails - > [https://travis-ci.com/github/apache/ranger/builds/223139469] > There are several issues: > [Issue 1|https://reviews.apache.org/r/73281/bugs/1/]) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > [Issue 2|https://reviews.apache.org/r/73281/bugs/2/]) > RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a > class that is not available in Java 9+ and this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of > JDK 11+ > [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4 > Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11
[ https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342395#comment-17342395 ] Martin Tzvetanov Grigorov commented on RANGER-3243: --- Hello Ranger devs, do you have any feedback on the proposed improvements ? > Build fails on JDK 8 and 11 > --- > > Key: RANGER-3243 > URL: https://issues.apache.org/jira/browse/RANGER-3243 > Project: Ranger > Issue Type: Task > Components: build-infra >Reporter: Martin Tzvetanov Grigorov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The build of current master branch fails - > [https://travis-ci.com/github/apache/ranger/builds/223139469] > There are several issues: > [Issue 1|https://reviews.apache.org/r/73281/bugs/1/]) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > [Issue 2|https://reviews.apache.org/r/73281/bugs/2/]) > RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a > class that is not available in Java 9+ and this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of > JDK 11+ > [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4 > Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11
[ https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335204#comment-17335204 ] Martin Tzvetanov Grigorov commented on RANGER-3243: --- Thanks for the update here, [~chia7712] ! I've updated [https://reviews.apache.org/r/73281/] by rebasing it to latest master. Now it contains only the fixes for 2), 3) and 4). > Build fails on JDK 8 and 11 > --- > > Key: RANGER-3243 > URL: https://issues.apache.org/jira/browse/RANGER-3243 > Project: Ranger > Issue Type: Task > Components: build-infra >Reporter: Martin Tzvetanov Grigorov >Priority: Major > > The build of current master branch fails - > [https://travis-ci.com/github/apache/ranger/builds/223139469] > There are several issues: > [Issue 1|https://reviews.apache.org/r/73281/bugs/1/]) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > [Issue 2|https://reviews.apache.org/r/73281/bugs/2/]) > RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a > class that is not available in Java 9+ and this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of > JDK 11+ > [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4 > Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11
[ https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334820#comment-17334820 ] Chia-Ping Tsai commented on RANGER-3243: the issue 1 is already fixed by RANGER-3235 > Build fails on JDK 8 and 11 > --- > > Key: RANGER-3243 > URL: https://issues.apache.org/jira/browse/RANGER-3243 > Project: Ranger > Issue Type: Task > Components: build-infra >Reporter: Martin Tzvetanov Grigorov >Priority: Major > > The build of current master branch fails - > [https://travis-ci.com/github/apache/ranger/builds/223139469] > There are several issues: > [Issue 1|https://reviews.apache.org/r/73281/bugs/1/]) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > [Issue 2|https://reviews.apache.org/r/73281/bugs/2/]) > RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a > class that is not available in Java 9+ and this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of > JDK 11+ > [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4 > Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-3243) Build fails on JDK 8 and 11
[ https://issues.apache.org/jira/browse/RANGER-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322721#comment-17322721 ] Martin Tzvetanov Grigorov commented on RANGER-3243: --- https://reviews.apache.org/r/73281/ > Build fails on JDK 8 and 11 > --- > > Key: RANGER-3243 > URL: https://issues.apache.org/jira/browse/RANGER-3243 > Project: Ranger > Issue Type: Task > Components: build-infra >Reporter: Martin Tzvetanov Grigorov >Priority: Major > > The build of current master branch fails - > [https://travis-ci.com/github/apache/ranger/builds/223139469] > There are several issues: > [Issue 1|https://reviews.apache.org/r/73281/bugs/1/]) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > [Issue 2|https://reviews.apache.org/r/73281/bugs/2/]) > RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a > class that is not available in Java 9+ and this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > [Issue 3|https://reviews.apache.org/r/73281/bugs/3/]) JAXB is no more part of > JDK 11+ > [Issue 4|https://reviews.apache.org/r/73281/bugs/4/]) JUnit 4 > Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
