[jira] [Commented] (RANGER-3636) Plugin classloader should use classloader of shim class as parent
[ https://issues.apache.org/jira/browse/RANGER-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564313#comment-17564313 ] Madhan Neethiraj commented on RANGER-3636: -- [~sneethiraj] - yes. This update didn't make to 2.3.0 release. I updated the fix version. Thanks! > Plugin classloader should use classloader of shim class as parent > - > > Key: RANGER-3636 > URL: https://issues.apache.org/jira/browse/RANGER-3636 > Project: Ranger > Issue Type: Bug > Components: plugins >Reporter: Madhan Neethiraj >Assignee: Madhan Neethiraj >Priority: Major > Fix For: 3.0.0 > > Attachments: RANGER-3636.patch > > > Ranger uses plugin-classloader to avoid libraries needed by plugin > implementation to be visible in component's CLASSPATH (RANGER-586). For > classes/resources that are not found in plugin-impl directory, the > classloader uses component's (service's) classloader. Currently, current > thread's classloader is used as the component's classloader. However, this > may not work for services that use class isolation themselves, in which case > the current thread's classloader might be different from component's > classloader. A better option will be to use the classloader that loaded the > plugin shim class as the component classloader. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RANGER-3636) Plugin classloader should use classloader of shim class as parent
[ https://issues.apache.org/jira/browse/RANGER-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564253#comment-17564253 ] Selvamohan Neethiraj commented on RANGER-3636: -- [~madhan] - This commit did not seems to make it to 2.3.0 release, should we remove the fix version 2.3.0 out of the release to have cleaner Release Notes ? cc: [~rmani] > Plugin classloader should use classloader of shim class as parent > - > > Key: RANGER-3636 > URL: https://issues.apache.org/jira/browse/RANGER-3636 > Project: Ranger > Issue Type: Bug > Components: plugins >Reporter: Madhan Neethiraj >Assignee: Madhan Neethiraj >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: RANGER-3636.patch > > > Ranger uses plugin-classloader to avoid libraries needed by plugin > implementation to be visible in component's CLASSPATH (RANGER-586). For > classes/resources that are not found in plugin-impl directory, the > classloader uses component's (service's) classloader. Currently, current > thread's classloader is used as the component's classloader. However, this > may not work for services that use class isolation themselves, in which case > the current thread's classloader might be different from component's > classloader. A better option will be to use the classloader that loaded the > plugin shim class as the component classloader. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RANGER-3636) Plugin classloader should use classloader of shim class as parent
[ https://issues.apache.org/jira/browse/RANGER-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496419#comment-17496419 ] Abhay Kulkarni commented on RANGER-3636: If the component uses class isolation, how does the new scheme know (and hence guarantee) the correct classloader to use among many possible? Why would shim class's loader a better choice than the context class loader for current thread? > Plugin classloader should use classloader of shim class as parent > - > > Key: RANGER-3636 > URL: https://issues.apache.org/jira/browse/RANGER-3636 > Project: Ranger > Issue Type: Bug > Components: plugins >Reporter: Madhan Neethiraj >Assignee: Madhan Neethiraj >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: RANGER-3636.patch > > > Ranger uses plugin-classloader to avoid libraries needed by plugin > implementation to be visible in component's CLASSPATH (RANGER-586). For > classes/resources that are not found in plugin-impl directory, the > classloader uses component's (service's) classloader. Currently, current > thread's classloader is used as the component's classloader. However, this > may not work for services that use class isolation themselves, in which case > the current thread's classloader might be different from component's > classloader. A better option will be to use the classloader that loaded the > plugin shim class as the component classloader. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (RANGER-3636) Plugin classloader should use classloader of shim class as parent
[ https://issues.apache.org/jira/browse/RANGER-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496410#comment-17496410 ] kirby zhou commented on RANGER-3636: It seems reasonable. > Plugin classloader should use classloader of shim class as parent > - > > Key: RANGER-3636 > URL: https://issues.apache.org/jira/browse/RANGER-3636 > Project: Ranger > Issue Type: Bug > Components: plugins >Reporter: Madhan Neethiraj >Assignee: Madhan Neethiraj >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: RANGER-3636.patch > > > Ranger uses plugin-classloader to avoid libraries needed by plugin > implementation to be visible in component's CLASSPATH (RANGER-586). For > classes/resources that are not found in plugin-impl directory, the > classloader uses component's (service's) classloader. Currently, current > thread's classloader is used as the component's classloader. However, this > may not work for services that use class isolation themselves, in which case > the current thread's classloader might be different from component's > classloader. A better option will be to use the classloader that loaded the > plugin shim class as the component classloader. -- This message was sent by Atlassian Jira (v8.20.1#820001)
