Re: Review Request 63870: RANGER-1861:There are errors when the "ranger-kms start" command was executed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63870/#review191551 --- Ship it! Ship It! - Qiang Zhang On Nov. 16, 2017, 10:03 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63870/ > --- > > (Updated Nov. 16, 2017, 10:03 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1861 > https://issues.apache.org/jira/browse/RANGER-1861 > > > Repository: ranger > > > Description > --- > > There are errors when the "ranger-kms start" command was executed. > > 2017-10-28 23:23:33,339 ERROR XMLUtils - Error loading : > java.lang.IllegalArgumentException: InputStream cannot be null > at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:117) > at org.apache.ranger.plugin.util.XMLUtils.loadConfig(XMLUtils.java:64) > at org.apache.ranger.plugin.util.XMLUtils.loadConfig(XMLUtils.java:48) > at > org.apache.ranger.server.tomcat.EmbeddedServer.(EmbeddedServer.java:77) > at > org.apache.ranger.server.tomcat.EmbeddedServer.main(EmbeddedServer.java:69) > > > Diffs > - > > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > 40eed861 > > > Diff: https://reviews.apache.org/r/63870/diff/1/ > > > Testing > --- > > > Thanks, > > pengjianhua > >
Re: Review Request 63870: RANGER-1861:There are errors when the "ranger-kms start" command was executed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63870/#review191494 --- Ship it! Ship It! - Colm O hEigeartaigh On Nov. 16, 2017, 10:03 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63870/ > --- > > (Updated Nov. 16, 2017, 10:03 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1861 > https://issues.apache.org/jira/browse/RANGER-1861 > > > Repository: ranger > > > Description > --- > > There are errors when the "ranger-kms start" command was executed. > > 2017-10-28 23:23:33,339 ERROR XMLUtils - Error loading : > java.lang.IllegalArgumentException: InputStream cannot be null > at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:117) > at org.apache.ranger.plugin.util.XMLUtils.loadConfig(XMLUtils.java:64) > at org.apache.ranger.plugin.util.XMLUtils.loadConfig(XMLUtils.java:48) > at > org.apache.ranger.server.tomcat.EmbeddedServer.(EmbeddedServer.java:77) > at > org.apache.ranger.server.tomcat.EmbeddedServer.main(EmbeddedServer.java:69) > > > Diffs > - > > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > 40eed861 > > > Diff: https://reviews.apache.org/r/63870/diff/1/ > > > Testing > --- > > > Thanks, > > pengjianhua > >
Re: Review Request 63870: RANGER-1861:There are errors when the "ranger-kms start" command was executed.
> On 十一月 16, 2017, 11:47 a.m., Colm O hEigeartaigh wrote: > > How does your change prevent the error? From what I can see the change is > > that it doesn't load the DEFAULT_CONFIG_FILENAME if an argument is > > specified. The EmbeddedServer class is only called by the security admin and KMS. The ranger-admin does not pass parameters to EmbeddedServer class. The ranger-kms will pass a parameter to EmbeddedServer class. The kms does not have the ranger-admin-default-site.xml file. The ranger-admin-default-site.xml file should not be load when the ranger-kms call EmbeddedServer class. - pengjianhua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63870/#review191172 --- On 十一月 16, 2017, 10:03 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63870/ > --- > > (Updated 十一月 16, 2017, 10:03 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1861 > https://issues.apache.org/jira/browse/RANGER-1861 > > > Repository: ranger > > > Description > --- > > There are errors when the "ranger-kms start" command was executed. > > 2017-10-28 23:23:33,339 ERROR XMLUtils - Error loading : > java.lang.IllegalArgumentException: InputStream cannot be null > at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:117) > at org.apache.ranger.plugin.util.XMLUtils.loadConfig(XMLUtils.java:64) > at org.apache.ranger.plugin.util.XMLUtils.loadConfig(XMLUtils.java:48) > at > org.apache.ranger.server.tomcat.EmbeddedServer.(EmbeddedServer.java:77) > at > org.apache.ranger.server.tomcat.EmbeddedServer.main(EmbeddedServer.java:69) > > > Diffs > - > > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > 40eed861 > > > Diff: https://reviews.apache.org/r/63870/diff/1/ > > > Testing > --- > > > Thanks, > > pengjianhua > >
Re: Review Request 63870: RANGER-1861:There are errors when the "ranger-kms start" command was executed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63870/#review191209 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 16, 2017, 10:03 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63870/ > --- > > (Updated Nov. 16, 2017, 10:03 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1861 > https://issues.apache.org/jira/browse/RANGER-1861 > > > Repository: ranger > > > Description > --- > > There are errors when the "ranger-kms start" command was executed. > > 2017-10-28 23:23:33,339 ERROR XMLUtils - Error loading : > java.lang.IllegalArgumentException: InputStream cannot be null > at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:117) > at org.apache.ranger.plugin.util.XMLUtils.loadConfig(XMLUtils.java:64) > at org.apache.ranger.plugin.util.XMLUtils.loadConfig(XMLUtils.java:48) > at > org.apache.ranger.server.tomcat.EmbeddedServer.(EmbeddedServer.java:77) > at > org.apache.ranger.server.tomcat.EmbeddedServer.main(EmbeddedServer.java:69) > > > Diffs > - > > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > 40eed861 > > > Diff: https://reviews.apache.org/r/63870/diff/1/ > > > Testing > --- > > > Thanks, > > pengjianhua > >
Re: Review Request 63870: RANGER-1861:There are errors when the "ranger-kms start" command was executed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63870/#review191172 --- How does your change prevent the error? From what I can see the change is that it doesn't load the DEFAULT_CONFIG_FILENAME if an argument is specified. - Colm O hEigeartaigh On Nov. 16, 2017, 10:03 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63870/ > --- > > (Updated Nov. 16, 2017, 10:03 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1861 > https://issues.apache.org/jira/browse/RANGER-1861 > > > Repository: ranger > > > Description > --- > > There are errors when the "ranger-kms start" command was executed. > > 2017-10-28 23:23:33,339 ERROR XMLUtils - Error loading : > java.lang.IllegalArgumentException: InputStream cannot be null > at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:117) > at org.apache.ranger.plugin.util.XMLUtils.loadConfig(XMLUtils.java:64) > at org.apache.ranger.plugin.util.XMLUtils.loadConfig(XMLUtils.java:48) > at > org.apache.ranger.server.tomcat.EmbeddedServer.(EmbeddedServer.java:77) > at > org.apache.ranger.server.tomcat.EmbeddedServer.main(EmbeddedServer.java:69) > > > Diffs > - > > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > 40eed861 > > > Diff: https://reviews.apache.org/r/63870/diff/1/ > > > Testing > --- > > > Thanks, > > pengjianhua > >
