Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

[bhavik patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63919/#review191995
---


Ship it!




Ship It!

- bhavik patel


On Nov. 27, 2017, 3:27 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63919/
> ---
> 
> (Updated Nov. 27, 2017, 3:27 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1895
> https://issues.apache.org/jira/browse/RANGER-1895
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> This task is to simplify the Apache Storm dependencies for Ranger. We are 
> shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid 
> explicitly listing some of the dependencies, as they get pulled in via other 
> dependencies.
> 
> 
> Diffs
> -
> 
>   ranger-storm-plugin-shim/pom.xml de1972d4 
>   storm-agent/pom.xml 6e74e5b3 
> 
> 
> Diff: https://reviews.apache.org/r/63919/diff/3/
> 
> 
> Testing
> ---
> 
> Tested the plugin works OK with Apache Storm 1.1.1. The only change in the 
> distribution is that it doesn't include the Hadoop HDFS jar.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

[Ramesh Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63919/#review191925
---


Ship it!




Ship It!

- Ramesh Mani


On Nov. 27, 2017, 3:27 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63919/
> ---
> 
> (Updated Nov. 27, 2017, 3:27 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1895
> https://issues.apache.org/jira/browse/RANGER-1895
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> This task is to simplify the Apache Storm dependencies for Ranger. We are 
> shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid 
> explicitly listing some of the dependencies, as they get pulled in via other 
> dependencies.
> 
> 
> Diffs
> -
> 
>   ranger-storm-plugin-shim/pom.xml de1972d4 
>   storm-agent/pom.xml 6e74e5b3 
> 
> 
> Diff: https://reviews.apache.org/r/63919/diff/3/
> 
> 
> Testing
> ---
> 
> Tested the plugin works OK with Apache Storm 1.1.1. The only change in the 
> distribution is that it doesn't include the Hadoop HDFS jar.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

[Colm O hEigeartaigh]

> On Nov. 27, 2017, 6:49 p.m., Ramesh Mani wrote:
> > storm-agent/pom.xml
> > Lines 95-96 (original)
> > 
> >
> > Colm, did you verify that audit to solr is working as expected? We may 
> > need this solr jar for Ranger audit dependency

Yes I did. The solr jar comes in via the org.apache.ranger:ranger-plugins-audit 
dependency, so it is still there on the classpath. The distribution still 
contains the Solr jar in the lib directory as before.


- Colm


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63919/#review191915
---


On Nov. 27, 2017, 3:27 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63919/
> ---
> 
> (Updated Nov. 27, 2017, 3:27 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1895
> https://issues.apache.org/jira/browse/RANGER-1895
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> This task is to simplify the Apache Storm dependencies for Ranger. We are 
> shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid 
> explicitly listing some of the dependencies, as they get pulled in via other 
> dependencies.
> 
> 
> Diffs
> -
> 
>   ranger-storm-plugin-shim/pom.xml de1972d4 
>   storm-agent/pom.xml 6e74e5b3 
> 
> 
> Diff: https://reviews.apache.org/r/63919/diff/3/
> 
> 
> Testing
> ---
> 
> Tested the plugin works OK with Apache Storm 1.1.1. The only change in the 
> distribution is that it doesn't include the Hadoop HDFS jar.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

[Ramesh Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63919/#review191915
---




storm-agent/pom.xml
Lines 95-96 (original)


Colm, did you verify that audit to solr is working as expected? We may need 
this solr jar for Ranger audit dependency


- Ramesh Mani


On Nov. 27, 2017, 3:27 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63919/
> ---
> 
> (Updated Nov. 27, 2017, 3:27 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1895
> https://issues.apache.org/jira/browse/RANGER-1895
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> This task is to simplify the Apache Storm dependencies for Ranger. We are 
> shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid 
> explicitly listing some of the dependencies, as they get pulled in via other 
> dependencies.
> 
> 
> Diffs
> -
> 
>   ranger-storm-plugin-shim/pom.xml de1972d4 
>   storm-agent/pom.xml 6e74e5b3 
> 
> 
> Diff: https://reviews.apache.org/r/63919/diff/3/
> 
> 
> Testing
> ---
> 
> Tested the plugin works OK with Apache Storm 1.1.1. The only change in the 
> distribution is that it doesn't include the Hadoop HDFS jar.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63919/
---

(Updated Nov. 27, 2017, 3:27 p.m.)


Review request for ranger.


Bugs: RANGER-1895
https://issues.apache.org/jira/browse/RANGER-1895


Repository: ranger


Description
---

This task is to simplify the Apache Storm dependencies for Ranger. We are 
shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid 
explicitly listing some of the dependencies, as they get pulled in via other 
dependencies.


Diffs (updated)
-

  ranger-storm-plugin-shim/pom.xml de1972d4 
  storm-agent/pom.xml 6e74e5b3 


Diff: https://reviews.apache.org/r/63919/diff/3/

Changes: https://reviews.apache.org/r/63919/diff/2-3/


Testing
---

Tested the plugin works OK with Apache Storm 1.1.1. The only change in the 
distribution is that it doesn't include the Hadoop HDFS jar.


Thanks,

Colm O hEigeartaigh

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

[Colm O hEigeartaigh]

> On Nov. 24, 2017, 5:07 a.m., bhavik patel wrote:
> > @Colm : Can you please also confirm audit to solr& audit to hdfs logs are 
> > writing properly?

Hi Bhavik,


Auditing to Solr works fine, but auditing to HDFS fails due to the missing HDFS 
jar. I will update the patch to put this jar back in. I think it would be 
better to put a dependency on HDFS in the audit module instead, but I'll deal 
with that through another patch.


- Colm


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63919/#review191824
---


On Nov. 23, 2017, 12:02 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63919/
> ---
> 
> (Updated Nov. 23, 2017, 12:02 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1895
> https://issues.apache.org/jira/browse/RANGER-1895
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> This task is to simplify the Apache Storm dependencies for Ranger. We are 
> shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid 
> explicitly listing some of the dependencies, as they get pulled in via other 
> dependencies.
> 
> 
> Diffs
> -
> 
>   ranger-storm-plugin-shim/pom.xml de1972d4 
>   src/main/assembly/storm-agent.xml 64224ec7 
>   storm-agent/pom.xml 6e74e5b3 
> 
> 
> Diff: https://reviews.apache.org/r/63919/diff/2/
> 
> 
> Testing
> ---
> 
> Tested the plugin works OK with Apache Storm 1.1.1. The only change in the 
> distribution is that it doesn't include the Hadoop HDFS jar.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

[bhavik patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63919/#review191824
---



@Colm : Can you please also confirm audit to solr& audit to hdfs logs are 
writing properly?

- bhavik patel


On Nov. 23, 2017, 12:02 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63919/
> ---
> 
> (Updated Nov. 23, 2017, 12:02 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1895
> https://issues.apache.org/jira/browse/RANGER-1895
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> This task is to simplify the Apache Storm dependencies for Ranger. We are 
> shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid 
> explicitly listing some of the dependencies, as they get pulled in via other 
> dependencies.
> 
> 
> Diffs
> -
> 
>   ranger-storm-plugin-shim/pom.xml de1972d4 
>   src/main/assembly/storm-agent.xml 64224ec7 
>   storm-agent/pom.xml 6e74e5b3 
> 
> 
> Diff: https://reviews.apache.org/r/63919/diff/2/
> 
> 
> Testing
> ---
> 
> Tested the plugin works OK with Apache Storm 1.1.1. The only change in the 
> distribution is that it doesn't include the Hadoop HDFS jar.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

[Colm O hEigeartaigh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63919/
---

(Updated Nov. 23, 2017, 12:02 p.m.)


Review request for ranger.


Bugs: RANGER-1895
https://issues.apache.org/jira/browse/RANGER-1895


Repository: ranger


Description
---

This task is to simplify the Apache Storm dependencies for Ranger. We are 
shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid 
explicitly listing some of the dependencies, as they get pulled in via other 
dependencies.


Diffs (updated)
-

  ranger-storm-plugin-shim/pom.xml de1972d4 
  src/main/assembly/storm-agent.xml 64224ec7 
  storm-agent/pom.xml 6e74e5b3 


Diff: https://reviews.apache.org/r/63919/diff/2/

Changes: https://reviews.apache.org/r/63919/diff/1-2/


Testing
---

Tested the plugin works OK with Apache Storm 1.1.1. The only change in the 
distribution is that it doesn't include the Hadoop HDFS jar.


Thanks,

Colm O hEigeartaigh

Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies

[Zsombor Gegesy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63919/#review191356
---


Ship it!




Makes sense, less dependency is always better.

- Zsombor Gegesy


On Nov. 17, 2017, 3:23 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63919/
> ---
> 
> (Updated Nov. 17, 2017, 3:23 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1895
> https://issues.apache.org/jira/browse/RANGER-1895
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> This task is to simplify the Apache Storm dependencies for Ranger. We are 
> shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid 
> explicitly listing some of the dependencies, as they get pulled in via other 
> dependencies.
> 
> 
> Diffs
> -
> 
>   src/main/assembly/storm-agent.xml 64224ec7 
>   storm-agent/pom.xml 6e74e5b3 
> 
> 
> Diff: https://reviews.apache.org/r/63919/diff/1/
> 
> 
> Testing
> ---
> 
> Tested the plugin works OK with Apache Storm 1.1.1. The only change in the 
> distribution is that it doesn't include the Hadoop HDFS jar.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>