Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-10-12 Thread Csaba Koncz 


> On Oct. 10, 2018, 3:39 p.m., Velmurugan Periasamy wrote:
> > pom.xml
> > Lines 608 (patched)
> > 
> >
> > Could you please make sure this is merged in 1.x branches? Thanks.
> 
> Csaba Koncz wrote:
> Do I have to do anything in this matter? Shall I provide patches for the 
> ranger-1.x branches (4 in total)?
> 
> Mehul Parikh wrote:
> Vel is asking to verify that, whether same patch applies on all 1.x 
> branches. It does apply for all 1.x branches and I have committed your patch 
> on Master and all 1.x branches. You can close this review request as 
> submitted.

Great, thank you!


- Csaba


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review209413
---


On Oct. 4, 2018, 7:50 p.m., Csaba Koncz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Oct. 4, 2018, 7:50 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modified so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   pom.xml d8e3a5da9 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/minify.build.js PRE-CREATION 
>   security-admin/src/main/webapp/package-lock.json PRE-CREATION 
>   security-admin/src/main/webapp/package.json PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/4/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-10-12 Thread Mehul Parikh 


> On Oct. 10, 2018, 3:39 p.m., Velmurugan Periasamy wrote:
> > pom.xml
> > Lines 608 (patched)
> > 
> >
> > Could you please make sure this is merged in 1.x branches? Thanks.
> 
> Csaba Koncz wrote:
> Do I have to do anything in this matter? Shall I provide patches for the 
> ranger-1.x branches (4 in total)?

Vel is asking to verify that, whether same patch applies on all 1.x branches. 
It does apply for all 1.x branches and I have committed your patch on Master 
and all 1.x branches. You can close this review request as submitted.


- Mehul


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review209413
---


On Oct. 4, 2018, 7:50 p.m., Csaba Koncz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Oct. 4, 2018, 7:50 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modified so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   pom.xml d8e3a5da9 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/minify.build.js PRE-CREATION 
>   security-admin/src/main/webapp/package-lock.json PRE-CREATION 
>   security-admin/src/main/webapp/package.json PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/4/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-10-11 Thread Csaba Koncz 


> On Oct. 10, 2018, 3:39 p.m., Velmurugan Periasamy wrote:
> > pom.xml
> > Lines 608 (patched)
> > 
> >
> > Could you please make sure this is merged in 1.x branches? Thanks.

Do I have to do anything in this matter? Shall I provide patches for the 
ranger-1.x branches (4 in total)?


- Csaba


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review209413
---


On Oct. 4, 2018, 7:50 p.m., Csaba Koncz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Oct. 4, 2018, 7:50 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modified so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   pom.xml d8e3a5da9 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/minify.build.js PRE-CREATION 
>   security-admin/src/main/webapp/package-lock.json PRE-CREATION 
>   security-admin/src/main/webapp/package.json PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/4/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-10-10 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review209413
---


Fix it, then Ship it!





pom.xml
Lines 608 (patched)


Could you please make sure this is merged in 1.x branches? Thanks.


- Velmurugan Periasamy


On Oct. 4, 2018, 7:50 p.m., Csaba Koncz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Oct. 4, 2018, 7:50 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modified so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   pom.xml d8e3a5da9 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/minify.build.js PRE-CREATION 
>   security-admin/src/main/webapp/package-lock.json PRE-CREATION 
>   security-admin/src/main/webapp/package.json PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/4/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-10-05 Thread Nitin Galave 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review209260
---


Ship it!




Ship It!

- Nitin Galave


On Oct. 4, 2018, 7:50 p.m., Csaba Koncz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Oct. 4, 2018, 7:50 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modified so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   pom.xml d8e3a5da9 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/minify.build.js PRE-CREATION 
>   security-admin/src/main/webapp/package-lock.json PRE-CREATION 
>   security-admin/src/main/webapp/package.json PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/4/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-10-04 Thread Csaba Koncz 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/
---

(Updated Oct. 4, 2018, 7:50 p.m.)


Review request for ranger.


Changes
---

Moved npm-related files to src/main/webapp as per review comments. Changed 
maven-frontend-plugin working directory to security-admin/target.


Bugs: RANGER-2220
https://issues.apache.org/jira/browse/RANGER-2220


Repository: ranger


Description
---

Maven build modified so that the admin UI JavaScript resources are 
concatenated/compressed using the RequireJS Optimizer.
During the packaging phase index.html is rewritten so that it loads the 
compressed JS file instead of the JS source tree.


Diffs (updated)
-

  pom.xml d8e3a5da9 
  security-admin/pom.xml 84bbd6650 
  security-admin/src/main/webapp/index.html 60ef5a75b 
  security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
276175505 
  
security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
 6cd05b03d 
  security-admin/src/main/webapp/minify.build.js PRE-CREATION 
  security-admin/src/main/webapp/package-lock.json PRE-CREATION 
  security-admin/src/main/webapp/package.json PRE-CREATION 
  security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
  security-admin/src/main/webapp/scripts/Main.js d518afbf2 


Diff: https://reviews.apache.org/r/68770/diff/4/

Changes: https://reviews.apache.org/r/68770/diff/3-4/


Testing
---

Performed:

mvn package -pl security-admin -am
cd security-admin/
cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
http-server
# opened http://localhost:8080 and inspected browser network tab and console:
# network tab lists only 26 requests
# console contains no packaging related errors (it contains 4 errors due to 
missing backend service)


Thanks,

Csaba Koncz

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-10-04 Thread Nitin Galave 


> On Sept. 24, 2018, 1:03 p.m., Nitin Galave wrote:
> > security-admin/package.json
> > Lines 1 (patched)
> > 
> >
> > To maintain consistency it is better if we move this file(npm code) to 
> > src/main/webapp directory as we have all UI related code.
> > 
> > Thanks for contribution!!

Please let me know if you are taking care of clean up thing.


- Nitin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review208940
---


On Sept. 26, 2018, 8:58 a.m., Csaba Koncz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Sept. 26, 2018, 8:58 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modified so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   pom.xml d8e3a5da9 
>   security-admin/.gitignore 5a3a67338 
>   security-admin/package-lock.json PRE-CREATION 
>   security-admin/package.json PRE-CREATION 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/minify.build.js PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/3/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-26 Thread Csaba Koncz 


> On Sept. 24, 2018, 1:03 p.m., Nitin Galave wrote:
> > security-admin/pom.xml
> > Lines 562 (patched)
> > 
> >
> > maven build stuck after appyinng this patch
> 
> Csaba Koncz wrote:
> The first maven build takes longer because nodejs needs to be downloaded 
> by the frontend plugin.
> 
> Could you post the console output?
> Can you locate the line belonging to the nodejs download?
> 
> In my case, this is the command I issue:
> 
> mvn package -DskipTests -pl security-admin -am
> 
> And this is how the frontend plugin executions start: 
> ...
> [INFO]
> [INFO] --- frontend-maven-plugin:1.6:install-node-and-npm (install node 
> and npm) @ security-admin-web ---
> [INFO] Node v8.12.0 is already installed.
> [INFO] NPM 6.4.1 is already installed.
> [INFO]
> ...
> 
> Nitin Galave wrote:
> For compiling and packaging we use 
> mvn clean compile package assembly:assembly install
> and it excute the rat-plugin 
> 
> 
> maven build success if we ignore rat-plugin in pom.xml
> I think we should exclude npm and node_modeuls directory for rat-plugin 
> (root dir : pom.xml).

Oh, thank you. I overlooked the excludeSubProjects setting in the parent pom 
(https://github.com/apache/ranger/blob/master/pom.xml#L569).

This is a bit silly because now the files are checked twice for licenses during 
the verify phase: both in the submodules and at the end by the parent module.
And the exclusions must contain wildcards so that they work even when evaluated 
in different locations.

I updated the patch, the nodejs exclusions are in the parent pom now.
In the long run it might be worth setting excludeSubProjects=true and move the 
submodule-specific rat exclusions to the sobmodule poms.


- Csaba


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review208940
---


On Sept. 26, 2018, 8:58 a.m., Csaba Koncz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Sept. 26, 2018, 8:58 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modified so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   pom.xml d8e3a5da9 
>   security-admin/.gitignore 5a3a67338 
>   security-admin/package-lock.json PRE-CREATION 
>   security-admin/package.json PRE-CREATION 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/minify.build.js PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/3/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-26 Thread Csaba Koncz 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/
---

(Updated Sept. 26, 2018, 8:58 a.m.)


Review request for ranger.


Changes
---

Moved rat exclusions to the parent pom.


Bugs: RANGER-2220
https://issues.apache.org/jira/browse/RANGER-2220


Repository: ranger


Description
---

Maven build modified so that the admin UI JavaScript resources are 
concatenated/compressed using the RequireJS Optimizer.
During the packaging phase index.html is rewritten so that it loads the 
compressed JS file instead of the JS source tree.


Diffs (updated)
-

  pom.xml d8e3a5da9 
  security-admin/.gitignore 5a3a67338 
  security-admin/package-lock.json PRE-CREATION 
  security-admin/package.json PRE-CREATION 
  security-admin/pom.xml 84bbd6650 
  security-admin/src/main/webapp/index.html 60ef5a75b 
  security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
276175505 
  
security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
 6cd05b03d 
  security-admin/src/main/webapp/minify.build.js PRE-CREATION 
  security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
  security-admin/src/main/webapp/scripts/Main.js d518afbf2 


Diff: https://reviews.apache.org/r/68770/diff/3/

Changes: https://reviews.apache.org/r/68770/diff/2-3/


Testing
---

Performed:

mvn package -pl security-admin -am
cd security-admin/
cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
http-server
# opened http://localhost:8080 and inspected browser network tab and console:
# network tab lists only 26 requests
# console contains no packaging related errors (it contains 4 errors due to 
missing backend service)


Thanks,

Csaba Koncz

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-25 Thread Nitin Galave 


> On Sept. 24, 2018, 1:03 p.m., Nitin Galave wrote:
> > security-admin/pom.xml
> > Lines 562 (patched)
> > 
> >
> > maven build stuck after appyinng this patch
> 
> Csaba Koncz wrote:
> The first maven build takes longer because nodejs needs to be downloaded 
> by the frontend plugin.
> 
> Could you post the console output?
> Can you locate the line belonging to the nodejs download?
> 
> In my case, this is the command I issue:
> 
> mvn package -DskipTests -pl security-admin -am
> 
> And this is how the frontend plugin executions start: 
> ...
> [INFO]
> [INFO] --- frontend-maven-plugin:1.6:install-node-and-npm (install node 
> and npm) @ security-admin-web ---
> [INFO] Node v8.12.0 is already installed.
> [INFO] NPM 6.4.1 is already installed.
> [INFO]
> ...

For compiling and packaging we use 
mvn clean compile package assembly:assembly install
and it excute the rat-plugin 


maven build success if we ignore rat-plugin in pom.xml
I think we should exclude npm and node_modeuls directory for rat-plugin (root 
dir : pom.xml).


- Nitin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review208940
---


On Sept. 21, 2018, 5:21 p.m., Csaba Koncz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Sept. 21, 2018, 5:21 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modified so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   security-admin/.gitignore 5a3a67338 
>   security-admin/package-lock.json PRE-CREATION 
>   security-admin/package.json PRE-CREATION 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/minify.build.js PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/2/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-24 Thread Csaba Koncz 


> On Sept. 24, 2018, 1:03 p.m., Nitin Galave wrote:
> > security-admin/pom.xml
> > Lines 562 (patched)
> > 
> >
> > maven build stuck after appyinng this patch

The first maven build takes longer because nodejs needs to be downloaded by the 
frontend plugin.

Could you post the console output?
Can you locate the line belonging to the nodejs download?

In my case, this is the command I issue:

mvn package -DskipTests -pl security-admin -am

And this is how the frontend plugin executions start: 
...
[INFO]
[INFO] --- frontend-maven-plugin:1.6:install-node-and-npm (install node and 
npm) @ security-admin-web ---
[INFO] Node v8.12.0 is already installed.
[INFO] NPM 6.4.1 is already installed.
[INFO]
...


- Csaba


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review208940
---


On Sept. 21, 2018, 5:21 p.m., Csaba Koncz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Sept. 21, 2018, 5:21 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modified so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   security-admin/.gitignore 5a3a67338 
>   security-admin/package-lock.json PRE-CREATION 
>   security-admin/package.json PRE-CREATION 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/minify.build.js PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/2/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-24 Thread Nitin Galave 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review208940
---




security-admin/package.json
Lines 1 (patched)


To maintain consistency it is better if we move this file(npm code) to 
src/main/webapp directory as we have all UI related code.

Thanks for contribution!!



security-admin/package.json
Lines 1 (patched)


To maintain consistency it is better if we move this file(npm code) to 
src/main/webapp directory as we have all UI related code.

Thanks for contribution!!



security-admin/pom.xml
Lines 562 (patched)


maven build stuck after appyinng this patch


- Nitin Galave


On Sept. 21, 2018, 5:21 p.m., Csaba Koncz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Sept. 21, 2018, 5:21 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modified so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   security-admin/.gitignore 5a3a67338 
>   security-admin/package-lock.json PRE-CREATION 
>   security-admin/package.json PRE-CREATION 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/minify.build.js PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/2/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-21 Thread Csaba Koncz 


> On Sept. 21, 2018, 12:01 a.m., Velmurugan Periasamy wrote:
> >

Reworked the patch so that it uses nodejs instead of jjs/Nashorn. RequireJS 
optimizer (r.js) does not need to be versioned, instead it is downloaded using 
npm during the build.


> On Sept. 21, 2018, 12:01 a.m., Velmurugan Periasamy wrote:
> > security-admin/scripts-js/minify.build.js
> > Lines 1 (patched)
> > 
> >
> > Can this be used? This will fail rat plugin with unapproved license.

Correct, will add the license.


> On Sept. 21, 2018, 12:01 a.m., Velmurugan Periasamy wrote:
> > security-admin/scripts-js/r.js
> > Lines 1 (patched)
> > 
> >
> > Can this be used? This will fail rat plugin with unapproved license.

This file is similar to the ones in src/main/webapp/lib which are excluded in 
the rat plugin config.
Shall I do the same? (i.e. exclude it just like bootstrap.min.js is excluded 
here: https://github.com/apache/ranger/blob/master/pom.xml#L574)

Another option would be to remove this file from version control and download 
it during runtime using npm.
That implies introducing the frontend maven plugin to donwload node and npm. 
It seems a bit of hassle, but probably it is the right thing to do. 
The benefits would be faster JavaScript minification and not depending on JDK8 
and presence of jjs
(which will be deprecated in Java 11 http://openjdk.java.net/jeps/335)


- Csaba


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review208826
---


On Sept. 21, 2018, 5:21 p.m., Csaba Koncz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Sept. 21, 2018, 5:21 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modified so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   security-admin/.gitignore 5a3a67338 
>   security-admin/package-lock.json PRE-CREATION 
>   security-admin/package.json PRE-CREATION 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/minify.build.js PRE-CREATION 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/2/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-21 Thread Csaba Koncz 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/
---

(Updated Sept. 21, 2018, 5:21 p.m.)


Review request for ranger.


Bugs: RANGER-2220
https://issues.apache.org/jira/browse/RANGER-2220


Repository: ranger


Description
---

Maven build modified so that the admin UI JavaScript resources are 
concatenated/compressed using the RequireJS Optimizer.
During the packaging phase index.html is rewritten so that it loads the 
compressed JS file instead of the JS source tree.


Diffs (updated)
-

  security-admin/.gitignore 5a3a67338 
  security-admin/package-lock.json PRE-CREATION 
  security-admin/package.json PRE-CREATION 
  security-admin/pom.xml 84bbd6650 
  security-admin/src/main/webapp/index.html 60ef5a75b 
  security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
276175505 
  
security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
 6cd05b03d 
  security-admin/src/main/webapp/minify.build.js PRE-CREATION 
  security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
  security-admin/src/main/webapp/scripts/Main.js d518afbf2 


Diff: https://reviews.apache.org/r/68770/diff/2/

Changes: https://reviews.apache.org/r/68770/diff/1-2/


Testing
---

Performed:

mvn package -pl security-admin -am
cd security-admin/
cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
http-server
# opened http://localhost:8080 and inspected browser network tab and console:
# network tab lists only 26 requests
# console contains no packaging related errors (it contains 4 errors due to 
missing backend service)


Thanks,

Csaba Koncz

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-20 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review208826
---




security-admin/scripts-js/minify.build.js
Lines 1 (patched)


Can this be used? This will fail rat plugin with unapproved license.



security-admin/scripts-js/r.js
Lines 1 (patched)


Can this be used? This will fail rat plugin with unapproved license.


- Velmurugan Periasamy


On Sept. 19, 2018, 9 p.m., Csaba Koncz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Sept. 19, 2018, 9 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modified so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/scripts-js/minify.build.js PRE-CREATION 
>   security-admin/scripts-js/r.js PRE-CREATION 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/1/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-19 Thread Csaba Koncz 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/
---

(Updated Sept. 19, 2018, 9 p.m.)


Review request for ranger.


Bugs: RANGER-2220
https://issues.apache.org/jira/browse/RANGER-2220


Repository: ranger


Description (updated)
---

Maven build modified so that the admin UI JavaScript resources are 
concatenated/compressed using the RequireJS Optimizer.
During the packaging phase index.html is rewritten so that it loads the 
compressed JS file instead of the JS source tree.


Diffs
-

  security-admin/pom.xml 84bbd6650 
  security-admin/scripts-js/minify.build.js PRE-CREATION 
  security-admin/scripts-js/r.js PRE-CREATION 
  security-admin/src/main/webapp/index.html 60ef5a75b 
  security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
276175505 
  
security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
 6cd05b03d 
  security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
  security-admin/src/main/webapp/scripts/Main.js d518afbf2 


Diff: https://reviews.apache.org/r/68770/diff/1/


Testing
---

Performed:

mvn package -pl security-admin -am
cd security-admin/
cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
http-server
# opened http://localhost:8080 and inspected browser network tab and console:
# network tab lists only 26 requests
# console contains no packaging related errors (it contains 4 errors due to 
missing backend service)


Thanks,

Csaba Koncz

Re: Review Request 68770: RANGER-2220 minify JavaScript files during packaging

2018-09-19 Thread Csaba Koncz 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/#review208773
---




security-admin/pom.xml
Line 563 (original), 564 (patched)


these old includes had no effect (pat



security-admin/pom.xml
Lines 572 (patched)


lines staring with  are commented out



security-admin/pom.xml
Lines 576 (patched)


lines in the form  are transformed into  
CONTENT, i.e. the CONTENT becomes uncommented.



security-admin/pom.xml
Lines 607 (patched)


Assume JDK8 (Nashorn interpreter (jjs) should be available)



security-admin/scripts-js/minify.build.js
Lines 1 (patched)


This file is only for manually testing the minification without running mvn 
package. It is not used by the maven build.



security-admin/scripts-js/r.js
Lines 1 (patched)


RequireJS Optimizer included unchanged.



security-admin/src/main/webapp/index.html
Lines 129 (patched)


The line starting with  loads the individual JS files



security-admin/src/main/webapp/index.html
Lines 130 (patched)


The " This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68770/
> ---
> 
> (Updated Sept. 19, 2018, 8:33 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2220
> https://issues.apache.org/jira/browse/RANGER-2220
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Maven build modifies so that the admin UI JavaScript resources are 
> concatenated/compressed using the RequireJS Optimizer.
> During the packaging phase index.html is rewritten so that it loads the 
> compressed JS file instead of the JS source tree.
> 
> 
> Diffs
> -
> 
>   security-admin/pom.xml 84bbd6650 
>   security-admin/scripts-js/minify.build.js PRE-CREATION 
>   security-admin/scripts-js/r.js PRE-CREATION 
>   security-admin/src/main/webapp/index.html 60ef5a75b 
>   security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js 
> 276175505 
>   
> security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
>  6cd05b03d 
>   security-admin/src/main/webapp/scripts/Init.js 4493f62e0 
>   security-admin/src/main/webapp/scripts/Main.js d518afbf2 
> 
> 
> Diff: https://reviews.apache.org/r/68770/diff/1/
> 
> 
> Testing
> ---
> 
> Performed:
> 
> mvn package -pl security-admin -am
> cd security-admin/
> cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
> http-server
> # opened http://localhost:8080 and inspected browser network tab and console:
> # network tab lists only 26 requests
> # console contains no packaging related errors (it contains 4 errors due to 
> missing backend service)
> 
> 
> Thanks,
> 
> Csaba Koncz
> 
>