Re: Review Request 58733: RANGER-1471 : Remember filters on all tabs of Ranger Audits page

2017-04-27 Thread Velmurugan Periasamy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58733/#review173202
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 26, 2017, 9:41 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58733/
> ---
> 
> (Updated April 26, 2017, 9:41 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan 
> Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1471
> https://issues.apache.org/jira/browse/RANGER-1471
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently, when we apply filter for anything in Ranger Audit page for any of 
> the tabs. It resets the filter on change of tab or if we move to any other 
> page in Ranger.
> Planning to add feature of remembering latest filters on all Tabs of Audits 
> page. That will help users to stay focused on what they are looking for in 
> audits tab and users will not have to apply for filters again and again to 
> check audit events of a particular service.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java 
> f4fcfb2 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java ed34525 
>   security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 0776021 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java fc58c7d 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> 3eda870 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 7a35ce3 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 1277334 
>   security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js 
> 6f1069d 
>   security-admin/src/main/webapp/styles/xa.css 7a5ec2e 
>   
> security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html
>  ea2f198 
>   security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 
> 028fdbf 
>   
> security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html 
> ddd6e3d 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java 
> c544832 
> 
> 
> Diff: https://reviews.apache.org/r/58733/diff/1/
> 
> 
> Testing
> ---
> 
> Tested multiple search is working correctly in "Audit" tab.
> Tested search remains the same when we navigate from one tab to other.
> Tested search is working correctly for different user role.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>



Review Request 58733: RANGER-1471 : Remember filters on all tabs of Ranger Audits page

2017-04-26 Thread bhavik patel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58733/
---

Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1471
https://issues.apache.org/jira/browse/RANGER-1471


Repository: ranger


Description
---

Currently, when we apply filter for anything in Ranger Audit page for any of 
the tabs. It resets the filter on change of tab or if we move to any other page 
in Ranger.
Planning to add feature of remembering latest filters on all Tabs of Audits 
page. That will help users to stay focused on what they are looking for in 
audits tab and users will not have to apply for filters again and again to 
check audit events of a particular service.


Diffs
-

  security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java f4fcfb2 
  security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java ed34525 
  security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 0776021 
  security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java fc58c7d 
  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
3eda870 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js 7a35ce3 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 1277334 
  security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js 
6f1069d 
  security-admin/src/main/webapp/styles/xa.css 7a5ec2e 
  
security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html 
ea2f198 
  security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 
028fdbf 
  security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html 
ddd6e3d 
  security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java 
c544832 


Diff: https://reviews.apache.org/r/58733/diff/1/


Testing
---

Tested multiple search is working correctly in "Audit" tab.
Tested search remains the same when we navigate from one tab to other.
Tested search is working correctly for different user role.


Thanks,

bhavik patel