Re: Review Request 59479: RangerUI: Include / Exclude toggle not working for same level resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59479/#review175780 --- Ship it! Ship It! - Velmurugan Periasamy On May 23, 2017, 6:13 a.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59479/ > --- > > (Updated May 23, 2017, 6:13 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Ramesh > Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-1602 > https://issues.apache.org/jira/browse/RANGER-1602 > > > Repository: ranger > > > Description > --- > > Include / Exclude toggle is shown on the UI even if one of the resource at > the same level contains excludeSupport flag as true in service def. > Ideally, it should honor the flag and show the toggle only if its set to true. > > > Diffs > - > > security-admin/src/main/webapp/scripts/modules/XAOverrides.js fb2f67b > > > Diff: https://reviews.apache.org/r/59479/diff/1/ > > > Testing > --- > > 1. Include/exclude option not available when the user tried to create a > policy using URL resource as per service def. > 2. Include/exclude option is available when the user tries to create a policy > using database resource. > 3. All components policy screens showing/hiding include/exclude toggle as per > service def. > 4. Policy CRUD is working fine. > > > Thanks, > > Nitin Galave > >
Re: Review Request 59479: RangerUI: Include / Exclude toggle not working for same level resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59479/#review175779 --- Ship it! Ship It! - Ankita Sinha On May 23, 2017, 6:13 a.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59479/ > --- > > (Updated May 23, 2017, 6:13 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Ramesh > Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-1602 > https://issues.apache.org/jira/browse/RANGER-1602 > > > Repository: ranger > > > Description > --- > > Include / Exclude toggle is shown on the UI even if one of the resource at > the same level contains excludeSupport flag as true in service def. > Ideally, it should honor the flag and show the toggle only if its set to true. > > > Diffs > - > > security-admin/src/main/webapp/scripts/modules/XAOverrides.js fb2f67b > > > Diff: https://reviews.apache.org/r/59479/diff/1/ > > > Testing > --- > > 1. Include/exclude option not available when the user tried to create a > policy using URL resource as per service def. > 2. Include/exclude option is available when the user tries to create a policy > using database resource. > 3. All components policy screens showing/hiding include/exclude toggle as per > service def. > 4. Policy CRUD is working fine. > > > Thanks, > > Nitin Galave > >
Review Request 59479: RangerUI: Include / Exclude toggle not working for same level resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59479/ --- Review request for ranger, Ankita Sinha, Gautam Borad, Ramesh Mani, and Velmurugan Periasamy. Bugs: RANGER-1602 https://issues.apache.org/jira/browse/RANGER-1602 Repository: ranger Description --- Include / Exclude toggle is shown on the UI even if one of the resource at the same level contains excludeSupport flag as true in service def. Ideally, it should honor the flag and show the toggle only if its set to true. Diffs - security-admin/src/main/webapp/scripts/modules/XAOverrides.js fb2f67b Diff: https://reviews.apache.org/r/59479/diff/1/ Testing --- 1. Include/exclude option not available when the user tried to create a policy using URL resource as per service def. 2. Include/exclude option is available when the user tries to create a policy using database resource. 3. All components policy screens showing/hiding include/exclude toggle as per service def. 4. Policy CRUD is working fine. Thanks, Nitin Galave
