Re: Review Request 62947: Update Ranger to use 0.8.1 Atlas version

2017-10-27 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62947/
---

(Updated Oct. 27, 2017, 10:31 p.m.)


Review request for ranger and Madhan Neethiraj.


Changes
---

Addressed review comment


Bugs: RANGER-1833
https://issues.apache.org/jira/browse/RANGER-1833


Repository: ranger


Description
---

Update Ranger to use 0.8.1 Atlas version


Diffs (updated)
-

  pom.xml 0c968c5 
  
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java
 12b02d9 


Diff: https://reviews.apache.org/r/62947/diff/2/

Changes: https://reviews.apache.org/r/62947/diff/1-2/


Testing
---

Ensured that tagsync starts up without any errors.


Thanks,

Abhay Kulkarni

Re: Review Request 62947: Update Ranger to use 0.8.1 Atlas version

2017-10-27 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62947/#review189453
---


Fix it, then Ship it!





tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java
Lines 174 (patched)


It will be useful to include notification type in the warning log.


- Madhan Neethiraj


On Oct. 12, 2017, 7:27 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62947/
> ---
> 
> (Updated Oct. 12, 2017, 7:27 p.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-1833
> https://issues.apache.org/jira/browse/RANGER-1833
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Update Ranger to use 0.8.1 Atlas version
> 
> 
> Diffs
> -
> 
>   pom.xml 3958014 
>   
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java
>  12b02d9 
> 
> 
> Diff: https://reviews.apache.org/r/62947/diff/1/
> 
> 
> Testing
> ---
> 
> Ensured that tagsync starts up without any errors.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Re: Review Request 62947: Update Ranger to use 0.8.1 Atlas version

2017-10-12 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62947/#review187858
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 12, 2017, 7:27 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62947/
> ---
> 
> (Updated Oct. 12, 2017, 7:27 p.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-1833
> https://issues.apache.org/jira/browse/RANGER-1833
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Update Ranger to use 0.8.1 Atlas version
> 
> 
> Diffs
> -
> 
>   pom.xml 3958014 
>   
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java
>  12b02d9 
> 
> 
> Diff: https://reviews.apache.org/r/62947/diff/1/
> 
> 
> Testing
> ---
> 
> Ensured that tagsync starts up without any errors.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Review Request 62947: Update Ranger to use 0.8.1 Atlas version

2017-10-12 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62947/
---

Review request for ranger and Madhan Neethiraj.


Bugs: RANGER-1833
https://issues.apache.org/jira/browse/RANGER-1833


Repository: ranger


Description
---

Update Ranger to use 0.8.1 Atlas version


Diffs
-

  pom.xml 3958014 
  
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java
 12b02d9 


Diff: https://reviews.apache.org/r/62947/diff/1/


Testing
---

Ensured that tagsync starts up without any errors.


Thanks,

Abhay Kulkarni