Re: Review Request 63834: RANGER-1893 - Update HBase dependency to 1.2.6

2017-12-07 Thread Qiang Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63834/#review193108
---


Ship it!




Ship It!

- Qiang Zhang


On Dec. 7, 2017, 11:21 a.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63834/
> ---
> 
> (Updated Dec. 7, 2017, 11:21 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1893
> https://issues.apache.org/jira/browse/RANGER-1893
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> We currently rely on an old HBase dependency (1.1.3). This task is to upgrade 
> it to 1.2.6. The plugin works correctly with no changes since 1.1.x.
> 
> 
> Diffs
> -
> 
>   pom.xml c603d663 
> 
> 
> Diff: https://reviews.apache.org/r/63834/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>



Re: Review Request 63834: RANGER-1893 - Update HBase dependency to 1.2.6

2017-12-07 Thread Colm O hEigeartaigh


> On Dec. 7, 2017, 1:11 a.m., Qiang Zhang wrote:
> > error: patch failed: pom.xml:215
> > error: pom.xml: patch does not apply
> > 
> > Please fix it before merged the issue.
> 
> Colm O hEigeartaigh wrote:
> Thanks, I updated the patch.
> 
> Qiang Zhang wrote:
> Maybe you updated wrong file. This error still exists.

Could you try downloading the patch from this URL instead? 
https://reviews.apache.org/r/63834/diff/3/


- Colm


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63834/#review193074
---


On Dec. 7, 2017, 11:21 a.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63834/
> ---
> 
> (Updated Dec. 7, 2017, 11:21 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1893
> https://issues.apache.org/jira/browse/RANGER-1893
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> We currently rely on an old HBase dependency (1.1.3). This task is to upgrade 
> it to 1.2.6. The plugin works correctly with no changes since 1.1.x.
> 
> 
> Diffs
> -
> 
>   pom.xml c603d663 
> 
> 
> Diff: https://reviews.apache.org/r/63834/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>



Re: Review Request 63834: RANGER-1893 - Update HBase dependency to 1.2.6

2017-12-07 Thread Qiang Zhang


> On Dec. 7, 2017, 1:11 a.m., Qiang Zhang wrote:
> > error: patch failed: pom.xml:215
> > error: pom.xml: patch does not apply
> > 
> > Please fix it before merged the issue.
> 
> Colm O hEigeartaigh wrote:
> Thanks, I updated the patch.

Maybe you updated wrong file. This error still exists.


- Qiang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63834/#review193074
---


On Dec. 7, 2017, 11:21 a.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63834/
> ---
> 
> (Updated Dec. 7, 2017, 11:21 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1893
> https://issues.apache.org/jira/browse/RANGER-1893
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> We currently rely on an old HBase dependency (1.1.3). This task is to upgrade 
> it to 1.2.6. The plugin works correctly with no changes since 1.1.x.
> 
> 
> Diffs
> -
> 
>   pom.xml c603d663 
> 
> 
> Diff: https://reviews.apache.org/r/63834/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>



Re: Review Request 63834: RANGER-1893 - Update HBase dependency to 1.2.6

2017-12-07 Thread Colm O hEigeartaigh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63834/
---

(Updated Dec. 7, 2017, 11:21 a.m.)


Review request for ranger.


Bugs: RANGER-1893
https://issues.apache.org/jira/browse/RANGER-1893


Repository: ranger


Description
---

We currently rely on an old HBase dependency (1.1.3). This task is to upgrade 
it to 1.2.6. The plugin works correctly with no changes since 1.1.x.


Diffs (updated)
-

  pom.xml c603d663 


Diff: https://reviews.apache.org/r/63834/diff/3/

Changes: https://reviews.apache.org/r/63834/diff/2-3/


Testing
---


Thanks,

Colm O hEigeartaigh



Re: Review Request 63834: RANGER-1893 - Update HBase dependency to 1.2.6

2017-12-07 Thread Colm O hEigeartaigh


> On Dec. 7, 2017, 1:11 a.m., Qiang Zhang wrote:
> > error: patch failed: pom.xml:215
> > error: pom.xml: patch does not apply
> > 
> > Please fix it before merged the issue.

Thanks, I updated the patch.


- Colm


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63834/#review193074
---


On Dec. 7, 2017, 11:21 a.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63834/
> ---
> 
> (Updated Dec. 7, 2017, 11:21 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1893
> https://issues.apache.org/jira/browse/RANGER-1893
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> We currently rely on an old HBase dependency (1.1.3). This task is to upgrade 
> it to 1.2.6. The plugin works correctly with no changes since 1.1.x.
> 
> 
> Diffs
> -
> 
>   pom.xml c603d663 
> 
> 
> Diff: https://reviews.apache.org/r/63834/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>



Re: Review Request 63834: RANGER-1893 - Update HBase dependency to 1.2.6

2017-12-06 Thread Qiang Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63834/#review193074
---



error: patch failed: pom.xml:215
error: pom.xml: patch does not apply

Please fix it before merged the issue.

- Qiang Zhang


On Nov. 15, 2017, 3:14 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63834/
> ---
> 
> (Updated Nov. 15, 2017, 3:14 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1893
> https://issues.apache.org/jira/browse/RANGER-1893
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> We currently rely on an old HBase dependency (1.1.3). This task is to upgrade 
> it to 1.2.6. The plugin works correctly with no changes since 1.1.x.
> 
> 
> Diffs
> -
> 
>   pom.xml 589cd6ac 
> 
> 
> Diff: https://reviews.apache.org/r/63834/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>



Re: Review Request 63834: RANGER-1893 - Update HBase dependency to 1.2.6

2017-12-06 Thread Qiang Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63834/#review193033
---


Ship it!




Ship It!

- Qiang Zhang


On 十一月 15, 2017, 3:14 p.m., Colm O hEigeartaigh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63834/
> ---
> 
> (Updated 十一月 15, 2017, 3:14 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1893
> https://issues.apache.org/jira/browse/RANGER-1893
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> We currently rely on an old HBase dependency (1.1.3). This task is to upgrade 
> it to 1.2.6. The plugin works correctly with no changes since 1.1.x.
> 
> 
> Diffs
> -
> 
>   pom.xml 589cd6ac 
> 
> 
> Diff: https://reviews.apache.org/r/63834/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>



Re: Review Request 63834: RANGER-1893 - Update HBase dependency to 1.2.6

2017-11-15 Thread Colm O hEigeartaigh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63834/
---

(Updated Nov. 15, 2017, 3:14 p.m.)


Review request for ranger.


Changes
---

Also removing some unused properties


Bugs: RANGER-1893
https://issues.apache.org/jira/browse/RANGER-1893


Repository: ranger


Description
---

We currently rely on an old HBase dependency (1.1.3). This task is to upgrade 
it to 1.2.6. The plugin works correctly with no changes since 1.1.x.


Diffs (updated)
-

  pom.xml 589cd6ac 


Diff: https://reviews.apache.org/r/63834/diff/2/

Changes: https://reviews.apache.org/r/63834/diff/1-2/


Testing
---


Thanks,

Colm O hEigeartaigh



Review Request 63834: RANGER-1893 - Update HBase dependency to 1.2.6

2017-11-15 Thread Colm O hEigeartaigh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63834/
---

Review request for ranger.


Bugs: RANGER-1893
https://issues.apache.org/jira/browse/RANGER-1893


Repository: ranger


Description
---

We currently rely on an old HBase dependency (1.1.3). This task is to upgrade 
it to 1.2.6. The plugin works correctly with no changes since 1.1.x.


Diffs
-

  pom.xml 589cd6ac 


Diff: https://reviews.apache.org/r/63834/diff/1/


Testing
---


Thanks,

Colm O hEigeartaigh