Re: Review Request 65829: Improvement on permission module for listing modules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65829/#review198385 --- Ship it! Ship It! - Gautam Borad On Feb. 28, 2018, 7:35 a.m., Fatima Khan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65829/ > --- > > (Updated Feb. 28, 2018, 7:35 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and > Sailaja Polavarapu. > > > Bugs: RANGER-1993 > https://issues.apache.org/jira/browse/RANGER-1993 > > > Repository: ranger > > > Description > --- > > 1.On permission listing page, if there are many users/group added in modules > and we do partial search then it gives pagination even when number of modules > are 7. > 2.On Policy Listing Page, we don't have partial search for users and groups. > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractPredicateUtil.java > 7583864 > > security-admin/src/main/java/org/apache/ranger/service/XModuleDefServiceBase.java > 57cc694 > > > Diff: https://reviews.apache.org/r/65829/diff/1/ > > > Testing > --- > > 1.Tested on permission listing module: to show proper results even after > applying filters. > 2.Tested for all allowed filters on policy listing page, verified results > after applying filters for user's name and group name . > > > Thanks, > > Fatima Khan > >
Re: Review Request 65829: Improvement on permission module for listing modules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65829/#review198383 --- Ship it! Ship It! - Zsombor Gegesy On Feb. 28, 2018, 7:35 a.m., Fatima Khan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65829/ > --- > > (Updated Feb. 28, 2018, 7:35 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and > Sailaja Polavarapu. > > > Bugs: RANGER-1993 > https://issues.apache.org/jira/browse/RANGER-1993 > > > Repository: ranger > > > Description > --- > > 1.On permission listing page, if there are many users/group added in modules > and we do partial search then it gives pagination even when number of modules > are 7. > 2.On Policy Listing Page, we don't have partial search for users and groups. > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractPredicateUtil.java > 7583864 > > security-admin/src/main/java/org/apache/ranger/service/XModuleDefServiceBase.java > 57cc694 > > > Diff: https://reviews.apache.org/r/65829/diff/1/ > > > Testing > --- > > 1.Tested on permission listing module: to show proper results even after > applying filters. > 2.Tested for all allowed filters on policy listing page, verified results > after applying filters for user's name and group name . > > > Thanks, > > Fatima Khan > >
Review Request 65829: Improvement on permission module for listing modules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65829/ --- Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu. Bugs: RANGER-1993 https://issues.apache.org/jira/browse/RANGER-1993 Repository: ranger Description --- 1.On permission listing page, if there are many users/group added in modules and we do partial search then it gives pagination even when number of modules are 7. 2.On Policy Listing Page, we don't have partial search for users and groups. Diffs - agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractPredicateUtil.java 7583864 security-admin/src/main/java/org/apache/ranger/service/XModuleDefServiceBase.java 57cc694 Diff: https://reviews.apache.org/r/65829/diff/1/ Testing --- 1.Tested on permission listing module: to show proper results even after applying filters. 2.Tested for all allowed filters on policy listing page, verified results after applying filters for user's name and group name . Thanks, Fatima Khan
