Re: Review Request 66089: RANGER-2018: Upgrade to Spring 4

2018-03-20 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66089/#review199527
---


Ship it!




Ship It!

- Zsombor Gegesy


On March 20, 2018, 7:39 a.m., Pradeep Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66089/
> ---
> 
> (Updated March 20, 2018, 7:39 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul 
> Parikh, suja s, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2018
> https://issues.apache.org/jira/browse/RANGER-2018
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Here I am proposing to change Spring Security to 4.2.4 and Spring Framework 
> to 4.3.14.
> 
> 
> Diffs
> -
> 
>   pom.xml 1df5f2c 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java
>  d9c2bcf 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java
>  370df70 
>   security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
> 0dda56b 
>   security-admin/src/main/webapp/META-INF/applicationContext.xml de1dc67 
>   security-admin/src/main/webapp/META-INF/asynctask-applicationContext.xml 
> 10f1a84 
>   security-admin/src/main/webapp/META-INF/scheduler-applicationContext.xml 
> a9fb632 
>   security-admin/src/main/webapp/scripts/mgrs/SessionMgr.js 529a589 
>   security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js eb65283 
>   security-admin/src/main/webapp/scripts/views/common/ProfileBar.js c6301c3 
>   
> security-admin/src/test/java/org/apache/ranger/service/PasswordComparisonAuthenticator.java
>  3dc6413 
> 
> 
> Diff: https://reviews.apache.org/r/66089/diff/2/
> 
> 
> Testing
> ---
> 
> Tested the Ranger admin installation, user login, ldap authentication , 
> usersync and other crud operations on service, policy, user and group module.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>

Re: Review Request 66089: RANGER-2018: Upgrade to Spring 4

2018-03-20 Thread Pradeep Agrawal 


> On March 19, 2018, 2:21 p.m., Zsombor Gegesy wrote:
> > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java
> > Line 63 (original), 64 (patched)
> > 
> >
> > This "Value" annotation is not needed, isn't it? The loginFormUrl is 
> > specified in the XML, this value would be used only if the 
> > RangerAuthenticationEntryPoint would be initialized by some other 
> > auto-magic. Honestly, I would love if everything could be configured 
> > without XML, but this is a bit confusing now.

Yes, its not needed. The change was aligned with XML. There is no change in the 
working of Ranger with or without @Value annotation so it can be removed.


- Pradeep


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66089/#review199415
---


On March 20, 2018, 7:39 a.m., Pradeep Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66089/
> ---
> 
> (Updated March 20, 2018, 7:39 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul 
> Parikh, suja s, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2018
> https://issues.apache.org/jira/browse/RANGER-2018
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Here I am proposing to change Spring Security to 4.2.4 and Spring Framework 
> to 4.3.14.
> 
> 
> Diffs
> -
> 
>   pom.xml 1df5f2c 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java
>  d9c2bcf 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java
>  370df70 
>   security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
> 0dda56b 
>   security-admin/src/main/webapp/META-INF/applicationContext.xml de1dc67 
>   security-admin/src/main/webapp/META-INF/asynctask-applicationContext.xml 
> 10f1a84 
>   security-admin/src/main/webapp/META-INF/scheduler-applicationContext.xml 
> a9fb632 
>   security-admin/src/main/webapp/scripts/mgrs/SessionMgr.js 529a589 
>   security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js eb65283 
>   security-admin/src/main/webapp/scripts/views/common/ProfileBar.js c6301c3 
>   
> security-admin/src/test/java/org/apache/ranger/service/PasswordComparisonAuthenticator.java
>  3dc6413 
> 
> 
> Diff: https://reviews.apache.org/r/66089/diff/2/
> 
> 
> Testing
> ---
> 
> Tested the Ranger admin installation, user login, ldap authentication , 
> usersync and other crud operations on service, policy, user and group module.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>

Re: Review Request 66089: RANGER-2018: Upgrade to Spring 4

2018-03-20 Thread Pradeep Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66089/
---

(Updated March 20, 2018, 7:39 a.m.)


Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul 
Parikh, suja s, and Velmurugan Periasamy.


Changes
---

Addressed review comments.


Bugs: RANGER-2018
https://issues.apache.org/jira/browse/RANGER-2018


Repository: ranger


Description
---

Here I am proposing to change Spring Security to 4.2.4 and Spring Framework to 
4.3.14.


Diffs (updated)
-

  pom.xml 1df5f2c 
  
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java
 d9c2bcf 
  
security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java
 370df70 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
0dda56b 
  security-admin/src/main/webapp/META-INF/applicationContext.xml de1dc67 
  security-admin/src/main/webapp/META-INF/asynctask-applicationContext.xml 
10f1a84 
  security-admin/src/main/webapp/META-INF/scheduler-applicationContext.xml 
a9fb632 
  security-admin/src/main/webapp/scripts/mgrs/SessionMgr.js 529a589 
  security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js eb65283 
  security-admin/src/main/webapp/scripts/views/common/ProfileBar.js c6301c3 
  
security-admin/src/test/java/org/apache/ranger/service/PasswordComparisonAuthenticator.java
 3dc6413 


Diff: https://reviews.apache.org/r/66089/diff/2/

Changes: https://reviews.apache.org/r/66089/diff/1-2/


Testing
---

Tested the Ranger admin installation, user login, ldap authentication , 
usersync and other crud operations on service, policy, user and group module.


Thanks,

Pradeep Agrawal

Re: Review Request 66089: RANGER-2018: Upgrade to Spring 4

2018-03-19 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66089/#review199415
---




security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java
Line 63 (original), 64 (patched)


This "Value" annotation is not needed, isn't it? The loginFormUrl is 
specified in the XML, this value would be used only if the 
RangerAuthenticationEntryPoint would be initialized by some other auto-magic. 
Honestly, I would love if everything could be configured without XML, but this 
is a bit confusing now.


- Zsombor Gegesy


On March 15, 2018, 1:54 p.m., Pradeep Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66089/
> ---
> 
> (Updated March 15, 2018, 1:54 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul 
> Parikh, suja s, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2018
> https://issues.apache.org/jira/browse/RANGER-2018
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Here I am proposing to change Spring Security to 4.2.4 and Spring Framework 
> to 4.3.14.
> 
> 
> Diffs
> -
> 
>   pom.xml 1df5f2c 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java
>  d9c2bcf 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java
>  370df70 
>   security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
> 0dda56b 
>   security-admin/src/main/webapp/META-INF/applicationContext.xml de1dc67 
>   security-admin/src/main/webapp/META-INF/asynctask-applicationContext.xml 
> 10f1a84 
>   security-admin/src/main/webapp/META-INF/scheduler-applicationContext.xml 
> a9fb632 
>   security-admin/src/main/webapp/scripts/mgrs/SessionMgr.js 529a589 
>   security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js eb65283 
>   security-admin/src/main/webapp/scripts/views/common/ProfileBar.js c6301c3 
>   
> security-admin/src/test/java/org/apache/ranger/service/PasswordComparisonAuthenticator.java
>  3dc6413 
> 
> 
> Diff: https://reviews.apache.org/r/66089/diff/1/
> 
> 
> Testing
> ---
> 
> Tested the Ranger admin installation, user login, ldap authentication , 
> usersync and other crud operations on service, policy, user and group module.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>

Review Request 66089: RANGER-2018: Upgrade to Spring 4

2018-03-15 Thread Pradeep Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66089/
---

Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul 
Parikh, suja s, and Velmurugan Periasamy.


Bugs: RANGER-2018
https://issues.apache.org/jira/browse/RANGER-2018


Repository: ranger


Description
---

Here I am proposing to change Spring Security to 4.2.4 and Spring Framework to 
4.3.14.


Diffs
-

  pom.xml 1df5f2c 
  
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java
 d9c2bcf 
  
security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java
 370df70 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
0dda56b 
  security-admin/src/main/webapp/META-INF/applicationContext.xml de1dc67 
  security-admin/src/main/webapp/META-INF/asynctask-applicationContext.xml 
10f1a84 
  security-admin/src/main/webapp/META-INF/scheduler-applicationContext.xml 
a9fb632 
  security-admin/src/main/webapp/scripts/mgrs/SessionMgr.js 529a589 
  security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js eb65283 
  security-admin/src/main/webapp/scripts/views/common/ProfileBar.js c6301c3 
  
security-admin/src/test/java/org/apache/ranger/service/PasswordComparisonAuthenticator.java
 3dc6413 


Diff: https://reviews.apache.org/r/66089/diff/1/


Testing
---

Tested the Ranger admin installation, user login, ldap authentication , 
usersync and other crud operations on service, policy, user and group module.


Thanks,

Pradeep Agrawal