Re: Review Request 66105: tagsync updates to handle hbase namespace entity notification

[Abhay Kulkarni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66105/
---

(Updated March 18, 2018, 9:15 p.m.)


Review request for ranger, Madhan Neethiraj and Ramesh Mani.


Changes
---

Addressed review comment


Bugs: RANGER-2025
https://issues.apache.org/jira/browse/RANGER-2025


Repository: ranger


Description
---

Updated tagsync to handle notification about a Hbase namespace is associated 
with a classification (tag).


Diffs (updated)
-

  
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHbaseResourceMapper.java
 33e804a20 
  
tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java
 499247c41 


Diff: https://reviews.apache.org/r/66105/diff/2/

Changes: https://reviews.apache.org/r/66105/diff/1-2/


Testing
---

Developed and passed unit tests.


Thanks,

Abhay Kulkarni

Re: Review Request 66105: tagsync updates to handle hbase namespace entity notification

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66105/#review199378
---


Fix it, then Ship it!





tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHbaseResourceMapper.java
Lines 73 (patched)


tblName => nameSpaceName


- Madhan Neethiraj


On March 15, 2018, 10:25 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66105/
> ---
> 
> (Updated March 15, 2018, 10:25 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
> 
> 
> Bugs: RANGER-2025
> https://issues.apache.org/jira/browse/RANGER-2025
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Updated tagsync to handle notification about a Hbase namespace is associated 
> with a classification (tag).
> 
> 
> Diffs
> -
> 
>   
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHbaseResourceMapper.java
>  33e804a20 
>   
> tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java
>  499247c41 
> 
> 
> Diff: https://reviews.apache.org/r/66105/diff/1/
> 
> 
> Testing
> ---
> 
> Developed and passed unit tests.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Review Request 66105: tagsync updates to handle hbase namespace entity notification

[Abhay Kulkarni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66105/
---

Review request for ranger, Madhan Neethiraj and Ramesh Mani.


Bugs: RANGER-2025
https://issues.apache.org/jira/browse/RANGER-2025


Repository: ranger


Description
---

Updated tagsync to handle notification about a Hbase namespace is associated 
with a classification (tag).


Diffs
-

  
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHbaseResourceMapper.java
 33e804a20 
  
tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java
 499247c41 


Diff: https://reviews.apache.org/r/66105/diff/1/


Testing
---

Developed and passed unit tests.


Thanks,

Abhay Kulkarni