Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

2018-08-02 Thread pengjianhua 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68010/#review206829
---


Ship it!




Ship It!

- pengjianhua


On Aug. 2, 2018, 7:42 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68010/
> ---
> 
> (Updated Aug. 2, 2018, 7:42 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2153
> https://issues.apache.org/jira/browse/RANGER-2153
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Supply the function of reverting policy history version.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> 1e3554f03 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  83253e43a 
> 
> 
> Diff: https://reviews.apache.org/r/68010/diff/3/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> 0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch
>   
> https://reviews.apache.org/media/uploaded/files/2018/08/02/25f26bf2-db4f-491e-9757-757803679d57__0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

2018-08-02 Thread Nitin Galave 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68010/#review206795
---


Ship it!




Ship It!

- Nitin Galave


On Aug. 2, 2018, 7:42 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68010/
> ---
> 
> (Updated Aug. 2, 2018, 7:42 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2153
> https://issues.apache.org/jira/browse/RANGER-2153
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Supply the function of reverting policy history version.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> 1e3554f03 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  83253e43a 
> 
> 
> Diff: https://reviews.apache.org/r/68010/diff/3/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> 0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch
>   
> https://reviews.apache.org/media/uploaded/files/2018/08/02/25f26bf2-db4f-491e-9757-757803679d57__0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

2018-08-02 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68010/
---

(Updated 八月 2, 2018, 7:42 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, 
Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, 
sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.


Changes
---

Fix an issue that the table is not loaded


Bugs: RANGER-2153
https://issues.apache.org/jira/browse/RANGER-2153


Repository: ranger


Description
---

Supply the function of reverting policy history version.


Diffs (updated)
-

  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
1e3554f03 
  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
 83253e43a 


Diff: https://reviews.apache.org/r/68010/diff/3/

Changes: https://reviews.apache.org/r/68010/diff/2-3/


Testing
---


File Attachments


0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch
  
https://reviews.apache.org/media/uploaded/files/2018/08/02/25f26bf2-db4f-491e-9757-757803679d57__0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch


Thanks,

Qiang Zhang

Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

2018-08-01 Thread Nitin Galave 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68010/#review206783
---




File Attachment: 
0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch - 
0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch


We also need to re-render policy listing table layout(view) as well right?
else policy reverted changes will not reflect to policy listing page.


- Nitin Galave


On Aug. 2, 2018, 2:32 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68010/
> ---
> 
> (Updated Aug. 2, 2018, 2:32 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2153
> https://issues.apache.org/jira/browse/RANGER-2153
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Supply the function of reverting policy history version.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> a0b46fdf6 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  206bb96ac 
> 
> 
> Diff: https://reviews.apache.org/r/68010/diff/2/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> 0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch
>   
> https://reviews.apache.org/media/uploaded/files/2018/08/02/25f26bf2-db4f-491e-9757-757803679d57__0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

2018-08-01 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68010/
---

(Updated 八月 2, 2018, 2:32 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, 
Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, 
sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.


Changes
---

Fix the page reload issue.


Bugs: RANGER-2153
https://issues.apache.org/jira/browse/RANGER-2153


Repository: ranger


Description
---

Supply the function of reverting policy history version.


Diffs
-

  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
a0b46fdf6 
  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
 206bb96ac 


Diff: https://reviews.apache.org/r/68010/diff/2/


Testing
---


File Attachments (updated)


0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch
  
https://reviews.apache.org/media/uploaded/files/2018/08/02/25f26bf2-db4f-491e-9757-757803679d57__0002-RANGER-2153-Supply-the-function-of-reverting-policy-.patch


Thanks,

Qiang Zhang

Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

2018-08-01 Thread Nitin Galave 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68010/#review206733
---




security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js
Lines 300 (patched)


Why are we reloading the page here? any specific reason
if reloading page is for getting the newly updated collection for policies 
then we should manually get updated collection(policies) by using backbone's  
collection.fetch method.

We should avoid such action(reload) in single page application (SPA)


- Nitin Galave


On July 27, 2018, 6:45 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68010/
> ---
> 
> (Updated July 27, 2018, 6:45 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2153
> https://issues.apache.org/jira/browse/RANGER-2153
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Supply the function of reverting policy history version.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> a0b46fdf6 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  206bb96ac 
> 
> 
> Diff: https://reviews.apache.org/r/68010/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

2018-07-30 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68010/#review206634
---


Ship it!




Ship It!

- Qiang Zhang


On 七月 27, 2018, 6:45 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68010/
> ---
> 
> (Updated 七月 27, 2018, 6:45 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2153
> https://issues.apache.org/jira/browse/RANGER-2153
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Supply the function of reverting policy history version.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> a0b46fdf6 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  206bb96ac 
> 
> 
> Diff: https://reviews.apache.org/r/68010/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

2018-07-29 Thread pengjianhua 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68010/#review206584
---


Ship it!




- pengjianhua


On July 27, 2018, 6:45 a.m., Qiang Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68010/
> ---
> 
> (Updated July 27, 2018, 6:45 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2153
> https://issues.apache.org/jira/browse/RANGER-2153
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Supply the function of reverting policy history version.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
> a0b46fdf6 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  206bb96ac 
> 
> 
> Diff: https://reviews.apache.org/r/68010/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

2018-07-26 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68010/
---

(Updated 七月 27, 2018, 6:45 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, 
Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, 
sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.


Bugs: RANGER-2153
https://issues.apache.org/jira/browse/RANGER-2153


Repository: ranger


Description
---

Supply the function of reverting policy history version.


Diffs (updated)
-

  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 
a0b46fdf6 
  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
 206bb96ac 


Diff: https://reviews.apache.org/r/68010/diff/2/

Changes: https://reviews.apache.org/r/68010/diff/1-2/


Testing
---


Thanks,

Qiang Zhang

Review Request 68010: RANGER-2153 Supply the function of reverting policy history version.

2018-07-22 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68010/
---

Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, 
Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, 
sam  rome, Venkat Ranganathan, and Velmurugan Periasamy.


Bugs: RANGER-2153
https://issues.apache.org/jira/browse/RANGER-2153


Repository: ranger


Description
---

Supply the function of reverting policy history version.


Diffs
-

  
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
 1afd92e3d 


Diff: https://reviews.apache.org/r/68010/diff/1/


Testing
---


Thanks,

Qiang Zhang