Re: Review Request 68290: RANGER-2185:when user has access to some of Hive databases, execute command 'show databases' will show the access databases

2018-08-22 Thread dhomme via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68290/
---

(Updated 八月 22, 2018, 5:40 p.m.)


Review request for ranger.


Bugs: RANGER-2185
https://issues.apache.org/jira/browse/RANGER-2185


Repository: ranger


Description
---

When a user execute 'show databases;' via hive, ranger hive plugin should check 
if the user has any databases to access but not all(*).


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java
 189dc2c84 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
 f8241c5dd 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
 333a2e13e 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java
 eb6ad9218 
  
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
 aad783402 
  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
 3ed79df83 
  
hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java
 7dc5c54b0 
  hive-agent/src/test/resources/hive-policies.json 361320680 


Diff: https://reviews.apache.org/r/68290/diff/5/

Changes: https://reviews.apache.org/r/68290/diff/4-5/


Testing
---

Tesetd with local env.


Thanks,

dhomme

Re: Review Request 68290: RANGER-2185:when user has access to some of Hive databases, execute command 'show databases' will show the access databases

2018-08-22 Thread dhomme via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68290/
---

(Updated 八月 22, 2018, 9:44 a.m.)


Review request for ranger.


Changes
---

fix invasive code and add unit test


Bugs: RANGER-2185
https://issues.apache.org/jira/browse/RANGER-2185


Repository: ranger


Description
---

When a user execute 'show databases;' via hive, ranger hive plugin should check 
if the user has any databases to access but not all(*).


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java
 189dc2c84 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
 f8241c5dd 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
 333a2e13e 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java
 eb6ad9218 
  
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
 aad783402 
  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
 3ed79df83 
  
hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java
 7dc5c54b0 
  hive-agent/src/test/resources/hive-policies.json 361320680 


Diff: https://reviews.apache.org/r/68290/diff/4/

Changes: https://reviews.apache.org/r/68290/diff/3-4/


Testing
---

Tesetd with local env.


Thanks,

dhomme

Re: Review Request 68290: RANGER-2185:when user has access to some of Hive databases, execute command 'show databases' will show the access databases

2018-08-11 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68290/#review207109
---




agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResource.java
Lines 52 (patched)


Hive specific items should not be brought into common plugin classes.



agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java
Lines 40 (patched)


Hive specific items should not be brought into common plugin classes.



agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceReadOnly.java
Lines 74 (patched)


Hive specific items should not be brought into common plugin classes.



agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java
Line 579 (original), 579 (patched)


Hive specific items should not be brought into common plugin classes.


- Velmurugan Periasamy


On Aug. 10, 2018, 11:14 a.m., dhomme wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68290/
> ---
> 
> (Updated Aug. 10, 2018, 11:14 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2185
> https://issues.apache.org/jira/browse/RANGER-2185
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> When a user execute 'show databases;' via hive, ranger hive plugin should 
> check if the user has any databases to access but not all(*).
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResource.java
>  2ee616a1b 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java
>  580048627 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceReadOnly.java
>  18bb1f44f 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
>  23d1efa15 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java
>  415263eef 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  3ed79df83 
> 
> 
> Diff: https://reviews.apache.org/r/68290/diff/3/
> 
> 
> Testing
> ---
> 
> Tesetd with local env.
> 
> 
> Thanks,
> 
> dhomme
> 
>

Re: Review Request 68290: RANGER-2185:when user has access to some of Hive databases, execute command 'show databases' will show the access databases

2018-08-10 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68290/#review207069
---



I don't think, this is a good solution - Hive specific changes shoudn't be 
added to the generic plugin code.
There is already a HiveAccessType.USE, and a RangerHiveAccessRequest is created 
if hiveOpType == HiveOperationType.SHOWDATABASES. I would rather see this 
accessType added to the UI, so users can create policies with database=* and  
accessType=USE. 
 Adding unit test would be nice too.

- Zsombor Gegesy


On Aug. 10, 2018, 11:14 a.m., dhomme wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68290/
> ---
> 
> (Updated Aug. 10, 2018, 11:14 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2185
> https://issues.apache.org/jira/browse/RANGER-2185
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> When a user execute 'show databases;' via hive, ranger hive plugin should 
> check if the user has any databases to access but not all(*).
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResource.java
>  2ee616a1b 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java
>  580048627 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceReadOnly.java
>  18bb1f44f 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
>  23d1efa15 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java
>  415263eef 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  3ed79df83 
> 
> 
> Diff: https://reviews.apache.org/r/68290/diff/3/
> 
> 
> Testing
> ---
> 
> Tesetd with local env.
> 
> 
> Thanks,
> 
> dhomme
> 
>

Re: Review Request 68290: RANGER-2185:when user has access to some of Hive databases, execute command 'show databases' will show the access databases

2018-08-10 Thread misaki mei via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68290/
---

(Updated 八月 10, 2018, 11:14 a.m.)


Review request for ranger.


Bugs: RANGER-2185
https://issues.apache.org/jira/browse/RANGER-2185


Repository: ranger


Description
---

When a user execute 'show databases;' via hive, ranger hive plugin should check 
if the user has any databases to access but not all(*).


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResource.java
 2ee616a1b 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java
 580048627 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceReadOnly.java
 18bb1f44f 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
 23d1efa15 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java
 415263eef 
  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
 3ed79df83 


Diff: https://reviews.apache.org/r/68290/diff/3/

Changes: https://reviews.apache.org/r/68290/diff/2-3/


Testing
---

Tesetd with local env.


Thanks,

misaki mei

Re: Review Request 68290: RANGER-2185:when user has access to some of Hive databases, execute command 'show databases' will show the access databases

2018-08-10 Thread misaki mei via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68290/
---

(Updated 八月 10, 2018, 11:06 a.m.)


Review request for ranger.


Bugs: RANGER-2185
https://issues.apache.org/jira/browse/RANGER-2185


Repository: ranger


Description
---

When a user execute 'show databases;' via hive, ranger hive plugin should check 
if the user has any databases to access but not all(*).


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResource.java
 2ee616a1b 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java
 580048627 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceReadOnly.java
 18bb1f44f 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
 23d1efa15 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java
 415263eef 
  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
 3ed79df83 


Diff: https://reviews.apache.org/r/68290/diff/2/

Changes: https://reviews.apache.org/r/68290/diff/1-2/


Testing
---

Tesetd with local env.


Thanks,

misaki mei

Review Request 68290: RANGER-2185:when user has access to some of Hive databases, execute command 'show databases' will show the access databases

2018-08-10 Thread misaki mei via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68290/
---

Review request for ranger.


Bugs: RANGER-2185
https://issues.apache.org/jira/browse/RANGER-2185


Repository: ranger


Description
---

When a user execute 'show databases;' via hive, ranger hive plugin should check 
if the user has any databases to access but not all(*).


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResource.java
 2ee616a1b 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java
 580048627 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceReadOnly.java
 18bb1f44f 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
 23d1efa15 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java
 415263eef 
  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
 3ed79df83 


Diff: https://reviews.apache.org/r/68290/diff/1/


Testing
---

Tesetd with local env.


Thanks,

misaki mei