Re: Review Request 72705: RANGER-2907: modified to use default TrustManager if a trustmanager is not specified in ranger-policymgr-ssl.xml

2020-07-24 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72705/#review221371
---


Ship it!




Ship It!

- Madhan Neethiraj


On July 23, 2020, 11:17 p.m., Selvamohan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72705/
> ---
> 
> (Updated July 23, 2020, 11:17 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Pradeep 
> Agrawal, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2907
> https://issues.apache.org/jira/browse/RANGER-2907
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> When the policymgr-ssl.xml does not have trustmanager file info, currently it 
> fails with an assertion failure. Added to get default JVM trustmanager when 
> the trustmanager is not specified for ranger-policymgr-ssl.xml file.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java
>  1c02d3d35 
> 
> 
> Diff: https://reviews.apache.org/r/72705/diff/1/
> 
> 
> Testing
> ---
> 
> tested locally on linux box with no ranger-policymgr-ssl.xml entries.
> 
> 
> Thanks,
> 
> Selvamohan Neethiraj
> 
>



Re: Review Request 72705: RANGER-2907: modified to use default TrustManager if a trustmanager is not specified in ranger-policymgr-ssl.xml

2020-07-24 Thread Pradeep Agrawal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72705/#review221370
---


Ship it!




Ship It!

- Pradeep Agrawal


On July 23, 2020, 11:17 p.m., Selvamohan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72705/
> ---
> 
> (Updated July 23, 2020, 11:17 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Pradeep 
> Agrawal, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2907
> https://issues.apache.org/jira/browse/RANGER-2907
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> When the policymgr-ssl.xml does not have trustmanager file info, currently it 
> fails with an assertion failure. Added to get default JVM trustmanager when 
> the trustmanager is not specified for ranger-policymgr-ssl.xml file.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java
>  1c02d3d35 
> 
> 
> Diff: https://reviews.apache.org/r/72705/diff/1/
> 
> 
> Testing
> ---
> 
> tested locally on linux box with no ranger-policymgr-ssl.xml entries.
> 
> 
> Thanks,
> 
> Selvamohan Neethiraj
> 
>



Review Request 72705: RANGER-2907: modified to use default TrustManager if a trustmanager is not specified in ranger-policymgr-ssl.xml

2020-07-23 Thread Selvamohan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72705/
---

Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Pradeep Agrawal, 
Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-2907
https://issues.apache.org/jira/browse/RANGER-2907


Repository: ranger


Description
---

When the policymgr-ssl.xml does not have trustmanager file info, currently it 
fails with an assertion failure. Added to get default JVM trustmanager when the 
trustmanager is not specified for ranger-policymgr-ssl.xml file.


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 
1c02d3d35 


Diff: https://reviews.apache.org/r/72705/diff/1/


Testing
---

tested locally on linux box with no ranger-policymgr-ssl.xml entries.


Thanks,

Selvamohan Neethiraj