Re: Review Request 73055: RANGER-3097: updated HDFS plugin to make operationName available to policy engine

2020-12-03 Thread Abhay Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73055/#review84
---


Ship it!




Ship It!

- Abhay Kulkarni


On Dec. 1, 2020, 11:30 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73055/
> ---
> 
> (Updated Dec. 1, 2020, 11:30 p.m.)
> 
> 
> Review request for ranger, deepak sharma, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-3097
> https://issues.apache.org/jira/browse/RANGER-3097
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> minor refactoring to wrap parameters passed to many methods into a context 
> object, and include operationName in the context
> 
> 
> Diffs
> -
> 
>   
> hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java
>  347abe742 
> 
> 
> Diff: https://reviews.apache.org/r/73055/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that operationName is recorded correctly in HDFS audit logs, as 
> before
> - verified that operationName is used in filtering audit logs based on 
> 'action'
> - all tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Review Request 73055: RANGER-3097: updated HDFS plugin to make operationName available to policy engine

2020-12-01 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73055/
---

Review request for ranger, deepak sharma, Kishor Gollapalliwar, Abhay Kulkarni, 
Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3097
https://issues.apache.org/jira/browse/RANGER-3097


Repository: ranger


Description
---

minor refactoring to wrap parameters passed to many methods into a context 
object, and include operationName in the context


Diffs
-

  
hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java
 347abe742 


Diff: https://reviews.apache.org/r/73055/diff/1/


Testing
---

- verified that operationName is recorded correctly in HDFS audit logs, as 
before
- verified that operationName is used in filtering audit logs based on 'action'
- all tests pass successfully


Thanks,

Madhan Neethiraj