Re: Review Request 73281: Fix compilation problems for Java 8 and Java 11.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73281/#review223527 --- Ship it! Ship It! - Ramesh Mani On Sept. 21, 2021, 7:18 a.m., Martin Grigorov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73281/ > --- > > (Updated Sept. 21, 2021, 7:18 a.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > --- > > Fix build due to hive exec and JDK 8 specific class > > > Diffs > - > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java > 371e367c1 > pom.xml 36036a6ad > ugsync-util/pom.xml aa992cabf > ugsync/pom.xml 07e0c5872 > > ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java > 30820ce33 > > > Diff: https://reviews.apache.org/r/73281/diff/4/ > > > Testing > --- > > Issue 1) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > > Issue 2) RangerSafenetKeySecure.java uses directly > sun.security.pkcs11.SunPKCS11 - a class that is not available in Java 9+ and > this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > > Issue 3) JAXB is no more part of JDK 11+ > > Issue 4) JUnit 4 Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. > > > Thanks, > > Martin Grigorov > >
Re: Review Request 73281: Fix compilation problems for Java 8 and Java 11.
> On Sept. 23, 2021, 10:11 a.m., Dhaval Shah wrote: > > Build succeeded with patch on java 8 and java 11. Thanks for the review, Dhaval Shah! - Martin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73281/#review223524 --- On Sept. 21, 2021, 7:18 a.m., Martin Grigorov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73281/ > --- > > (Updated Sept. 21, 2021, 7:18 a.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > --- > > Fix build due to hive exec and JDK 8 specific class > > > Diffs > - > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java > 371e367c1 > pom.xml 36036a6ad > ugsync-util/pom.xml aa992cabf > ugsync/pom.xml 07e0c5872 > > ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java > 30820ce33 > > > Diff: https://reviews.apache.org/r/73281/diff/4/ > > > Testing > --- > > Issue 1) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > > Issue 2) RangerSafenetKeySecure.java uses directly > sun.security.pkcs11.SunPKCS11 - a class that is not available in Java 9+ and > this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > > Issue 3) JAXB is no more part of JDK 11+ > > Issue 4) JUnit 4 Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. > > > Thanks, > > Martin Grigorov > >
Re: Review Request 73281: Fix compilation problems for Java 8 and Java 11.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73281/#review223524 --- Ship it! Build succeeded with patch on java 8 and java 11. - Dhaval Shah On Sept. 21, 2021, 7:18 a.m., Martin Grigorov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73281/ > --- > > (Updated Sept. 21, 2021, 7:18 a.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > --- > > Fix build due to hive exec and JDK 8 specific class > > > Diffs > - > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java > 371e367c1 > pom.xml 36036a6ad > ugsync-util/pom.xml aa992cabf > ugsync/pom.xml 07e0c5872 > > ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java > 30820ce33 > > > Diff: https://reviews.apache.org/r/73281/diff/4/ > > > Testing > --- > > Issue 1) > org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory > was not able to import com.google.common.base.Throwables.throwIfUnchecked > because it was coming from an old copy of Guava's Throwables shaded in > hive-exec. > By replacing hive-exec with orc-core in agents-audit module all depending > modules use their preferred version of Guava (26.0-jre) > > Issue 2) RangerSafenetKeySecure.java uses directly > sun.security.pkcs11.SunPKCS11 - a class that is not available in Java 9+ and > this breaks the compilation. > This should use reflection to load SunPKCS11 class dynamically. > > Issue 3) JAXB is no more part of JDK 11+ > > Issue 4) JUnit 4 Assert.assertThat() is deprecated in favour of Hamcrest's > MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. > > > Thanks, > > Martin Grigorov > >
Re: Review Request 73281: Fix compilation problems for Java 8 and Java 11.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73281/ --- (Updated Sept. 21, 2021, 7:18 a.m.) Review request for ranger. Repository: ranger Description --- Fix build due to hive exec and JDK 8 specific class Diffs (updated) - kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java 371e367c1 pom.xml 36036a6ad ugsync-util/pom.xml aa992cabf ugsync/pom.xml 07e0c5872 ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java 30820ce33 Diff: https://reviews.apache.org/r/73281/diff/4/ Changes: https://reviews.apache.org/r/73281/diff/3-4/ Testing --- Issue 1) org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory was not able to import com.google.common.base.Throwables.throwIfUnchecked because it was coming from an old copy of Guava's Throwables shaded in hive-exec. By replacing hive-exec with orc-core in agents-audit module all depending modules use their preferred version of Guava (26.0-jre) Issue 2) RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a class that is not available in Java 9+ and this breaks the compilation. This should use reflection to load SunPKCS11 class dynamically. Issue 3) JAXB is no more part of JDK 11+ Issue 4) JUnit 4 Assert.assertThat() is deprecated in favour of Hamcrest's MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. Thanks, Martin Grigorov
Re: Review Request 73281: Fix compilation problems for Java 8 and Java 11.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73281/ --- (Updated April 29, 2021, 7:43 a.m.) Review request for ranger. Changes --- Update to latest master where issue 1) is fixed. Repository: ranger Description --- Fix build due to hive exec and JDK 8 specific class Diffs (updated) - kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java 371e367c1 pom.xml e508dd1f8 ugsync-util/pom.xml aa992cabf ugsync/pom.xml 07e0c5872 ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java 30820ce33 Diff: https://reviews.apache.org/r/73281/diff/3/ Changes: https://reviews.apache.org/r/73281/diff/2-3/ Testing --- Issue 1) org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory was not able to import com.google.common.base.Throwables.throwIfUnchecked because it was coming from an old copy of Guava's Throwables shaded in hive-exec. By replacing hive-exec with orc-core in agents-audit module all depending modules use their preferred version of Guava (26.0-jre) Issue 2) RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a class that is not available in Java 9+ and this breaks the compilation. This should use reflection to load SunPKCS11 class dynamically. Issue 3) JAXB is no more part of JDK 11+ Issue 4) JUnit 4 Assert.assertThat() is deprecated in favour of Hamcrest's MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. Thanks, Martin Grigorov
Re: Review Request 73281: Fix compilation problems for Java 8 and Java 11.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73281/ --- (Updated April 16, 2021, 8:08 a.m.) Review request for ranger. Repository: ranger Description --- Fix build due to hive exec and JDK 8 specific class Diffs (updated) - agents-audit/pom.xml 06ed81f55 kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java 371e367c1 pom.xml fe7812bd7 ugsync-util/pom.xml aa992cabf ugsync/pom.xml 07e0c5872 ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java 30820ce33 Diff: https://reviews.apache.org/r/73281/diff/2/ Changes: https://reviews.apache.org/r/73281/diff/1-2/ Testing (updated) --- Issue 1) org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory was not able to import com.google.common.base.Throwables.throwIfUnchecked because it was coming from an old copy of Guava's Throwables shaded in hive-exec. By replacing hive-exec with orc-core in agents-audit module all depending modules use their preferred version of Guava (26.0-jre) Issue 2) RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a class that is not available in Java 9+ and this breaks the compilation. This should use reflection to load SunPKCS11 class dynamically. Issue 3) JAXB is no more part of JDK 11+ Issue 4) JUnit 4 Assert.assertThat() is deprecated in favour of Hamcrest's MatcherAssert.assertThat(). This fixes a compilation issue with JDK11. Thanks, Martin Grigorov
Review Request 73281: Fix compilation problems for Java 8 and Java 11.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73281/ --- Review request for ranger. Repository: ranger Description --- Fix build due to hive exec and JDK 8 specific class Diffs - agents-audit/pom.xml 06ed81f55c kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java 371e367c18 pom.xml fe7812bd72 Diff: https://reviews.apache.org/r/73281/diff/1/ Testing --- Issue 1) org.apache.ranger.authorization.presto.authorizer.RangerSystemAccessControlFactory was not able to import com.google.common.base.Throwables.throwIfUnchecked because it was coming from an old copy of Guava's Throwables shaded in hive-exec. By replacing hive-exec with orc-core in agents-audit module all depending modules use their preferred version of Guava (26.0-jre) Issue 2) RangerSafenetKeySecure.java uses directly sun.security.pkcs11.SunPKCS11 - a class that is not available in Java 9+ and this breaks the compilation. This should use reflection to load SunPKCS11 class dynamically. Thanks, Martin Grigorov
