Re: Review Request 73794: RANGER-3387: Ranger Admin Header Validation

2022-06-24 Thread Pradeep Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73794/#review224526
---


Ship it!




Ship It!

- Pradeep Agrawal


On April 20, 2022, 6:02 a.m., Sailaja Polavarapu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73794/
> ---
> 
> (Updated April 20, 2022, 6:02 a.m.)
> 
> 
> Review request for ranger, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, 
> and Ramesh Mani.
> 
> 
> Bugs: RANGER-3387
> https://issues.apache.org/jira/browse/RANGER-3387
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Added extra validation for handling PUT/POST requests coming from KNOX proxy 
> with different CSRF header than the one set by the client.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java
>  e02813fec 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java
>  2d3308b99 
> 
> 
> Diff: https://reviews.apache.org/r/73794/diff/2/
> 
> 
> Testing
> ---
> 
> 1. Verified functionality with Knox trusted proxy on both HA and non-HA 
> clusters.
> 2. Also verified couple of regression test cases.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>

Re: Review Request 73794: RANGER-3387: Ranger Admin Header Validation

2022-04-20 Thread Sailaja Polavarapu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73794/
---

(Updated April 20, 2022, 6:02 a.m.)


Review request for ranger, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, and 
Ramesh Mani.


Changes
---

Added null checks as per the review comments


Bugs: RANGER-3387
https://issues.apache.org/jira/browse/RANGER-3387


Repository: ranger


Description
---

Added extra validation for handling PUT/POST requests coming from KNOX proxy 
with different CSRF header than the one set by the client.


Diffs (updated)
-

  
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java
 e02813fec 
  
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java
 2d3308b99 


Diff: https://reviews.apache.org/r/73794/diff/2/

Changes: https://reviews.apache.org/r/73794/diff/1-2/


Testing
---

1. Verified functionality with Knox trusted proxy on both HA and non-HA 
clusters.
2. Also verified couple of regression test cases.


Thanks,

Sailaja Polavarapu

Re: Review Request 73794: RANGER-3387: Ranger Admin Header Validation

2022-03-10 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73794/#review224154
---




security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java
Line 181 (original), 189 (patched)


Can this httpRequest.getAttribute("spnegoEnabled") be null?


- Ramesh Mani


On Jan. 8, 2022, 12:55 a.m., Sailaja Polavarapu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73794/
> ---
> 
> (Updated Jan. 8, 2022, 12:55 a.m.)
> 
> 
> Review request for ranger, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, 
> and Ramesh Mani.
> 
> 
> Bugs: RANGER-3387
> https://issues.apache.org/jira/browse/RANGER-3387
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Added extra validation for handling PUT/POST requests coming from KNOX proxy 
> with different CSRF header than the one set by the client.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java
>  254f225d4 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java
>  2d3308b99 
> 
> 
> Diff: https://reviews.apache.org/r/73794/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Verified functionality with Knox trusted proxy on both HA and non-HA 
> clusters.
> 2. Also verified couple of regression test cases.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>

Re: Review Request 73794: RANGER-3387: Ranger Admin Header Validation

2022-03-10 Thread Mateen Mansoori 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73794/#review224153
---


Ship it!




Ship It!

- Mateen Mansoori


On Jan. 8, 2022, 12:55 a.m., Sailaja Polavarapu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73794/
> ---
> 
> (Updated Jan. 8, 2022, 12:55 a.m.)
> 
> 
> Review request for ranger, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, 
> and Ramesh Mani.
> 
> 
> Bugs: RANGER-3387
> https://issues.apache.org/jira/browse/RANGER-3387
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Added extra validation for handling PUT/POST requests coming from KNOX proxy 
> with different CSRF header than the one set by the client.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java
>  254f225d4 
>   
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java
>  2d3308b99 
> 
> 
> Diff: https://reviews.apache.org/r/73794/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Verified functionality with Knox trusted proxy on both HA and non-HA 
> clusters.
> 2. Also verified couple of regression test cases.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>

Review Request 73794: RANGER-3387: Ranger Admin Header Validation

2022-01-07 Thread Sailaja Polavarapu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73794/
---

Review request for ranger, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, and 
Ramesh Mani.


Bugs: RANGER-3387
https://issues.apache.org/jira/browse/RANGER-3387


Repository: ranger


Description
---

Added extra validation for handling PUT/POST requests coming from KNOX proxy 
with different CSRF header than the one set by the client.


Diffs
-

  
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java
 254f225d4 
  
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java
 2d3308b99 


Diff: https://reviews.apache.org/r/73794/diff/1/


Testing
---

1. Verified functionality with Knox trusted proxy on both HA and non-HA 
clusters.
2. Also verified couple of regression test cases.


Thanks,

Sailaja Polavarapu