Re: Review Request 74134: RANGER-3888, RANGER-3887, RANGER-3886, RANGER-3931: Validity Scheduler , recurrence schedule: added validation

2022-10-10 Thread Mehul Parikh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74134/#review224772
---


Ship it!




Ship It!

- Mehul Parikh


On Sept. 28, 2022, 8:20 a.m., Dineshkumar Yadav wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74134/
> ---
> 
> (Updated Sept. 28, 2022, 8:20 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Jayendra Parab, Kishor Gollapalliwar, 
> Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3886, RANGER-3887, RANGER-3888, and RANGER-3931
> https://issues.apache.org/jira/browse/RANGER-3886
> https://issues.apache.org/jira/browse/RANGER-3887
> https://issues.apache.org/jira/browse/RANGER-3888
> https://issues.apache.org/jira/browse/RANGER-3931
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> below validation is added for Validity Scheduler and recurrence schedule.
> 1. When there is no interval but schedule is specified , policy is created
> 2. Ranger accepts invalid start/endTime
> 3. Ranger reports overlapping ranges though there are no overlapping values
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java
>  2b4b049fa 
> 
> 
> Diff: https://reviews.apache.org/r/74134/diff/2/
> 
> 
> Testing
> ---
> 
> tested using curl request.
> 
> 
> Thanks,
> 
> Dineshkumar Yadav
> 
>



Re: Review Request 74134: RANGER-3888, RANGER-3887, RANGER-3886, RANGER-3931: Validity Scheduler , recurrence schedule: added validation

2022-10-03 Thread Abhay Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74134/#review224731
---


Ship it!




Ship It!

- Abhay Kulkarni


On Sept. 28, 2022, 8:20 a.m., Dineshkumar Yadav wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74134/
> ---
> 
> (Updated Sept. 28, 2022, 8:20 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Jayendra Parab, Kishor Gollapalliwar, 
> Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3886, RANGER-3887, RANGER-3888, and RANGER-3931
> https://issues.apache.org/jira/browse/RANGER-3886
> https://issues.apache.org/jira/browse/RANGER-3887
> https://issues.apache.org/jira/browse/RANGER-3888
> https://issues.apache.org/jira/browse/RANGER-3931
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> below validation is added for Validity Scheduler and recurrence schedule.
> 1. When there is no interval but schedule is specified , policy is created
> 2. Ranger accepts invalid start/endTime
> 3. Ranger reports overlapping ranges though there are no overlapping values
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java
>  2b4b049fa 
> 
> 
> Diff: https://reviews.apache.org/r/74134/diff/2/
> 
> 
> Testing
> ---
> 
> tested using curl request.
> 
> 
> Thanks,
> 
> Dineshkumar Yadav
> 
>



Re: Review Request 74134: RANGER-3888, RANGER-3887, RANGER-3886, RANGER-3931: Validity Scheduler , recurrence schedule: added validation

2022-09-28 Thread Dineshkumar Yadav

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74134/
---

(Updated Sept. 28, 2022, 8:20 a.m.)


Review request for ranger, Dhaval Shah, Jayendra Parab, Kishor Gollapalliwar, 
Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-3886, RANGER-3887, RANGER-3888, and RANGER-3931
https://issues.apache.org/jira/browse/RANGER-3886
https://issues.apache.org/jira/browse/RANGER-3887
https://issues.apache.org/jira/browse/RANGER-3888
https://issues.apache.org/jira/browse/RANGER-3931


Repository: ranger


Description
---

below validation is added for Validity Scheduler and recurrence schedule.
1. When there is no interval but schedule is specified , policy is created
2. Ranger accepts invalid start/endTime
3. Ranger reports overlapping ranges though there are no overlapping values


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java
 2b4b049fa 


Diff: https://reviews.apache.org/r/74134/diff/2/


Testing
---

tested using curl request.


Thanks,

Dineshkumar Yadav