Re: Review Request 74153: RANGER-3796: updated policy change logs to handle additionalResources field

2022-10-05 Thread Selvamohan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74153/#review224753
---


Ship it!




Ship It!

- Selvamohan Neethiraj


On Oct. 3, 2022, 3:33 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74153/
> ---
> 
> (Updated Oct. 3, 2022, 3:33 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, 
> Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3796
> https://issues.apache.org/jira/browse/RANGER-3796
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Updated policy change logs to handle additionalResources field
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
>  92aaaebdc 
> 
> 
> Diff: https://reviews.apache.org/r/74153/diff/1/
> 
> 
> Testing
> ---
> 
> - validated that admin audits generated during policy create/update captures 
> changes in policy.additionalResources
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 74153: RANGER-3796: updated policy change logs to handle additionalResources field

2022-10-05 Thread Selvamohan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74153/#review224752
---



Reviewed ; Ship It!

- Selvamohan Neethiraj


On Oct. 3, 2022, 3:33 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74153/
> ---
> 
> (Updated Oct. 3, 2022, 3:33 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, 
> Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3796
> https://issues.apache.org/jira/browse/RANGER-3796
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Updated policy change logs to handle additionalResources field
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
>  92aaaebdc 
> 
> 
> Diff: https://reviews.apache.org/r/74153/diff/1/
> 
> 
> Testing
> ---
> 
> - validated that admin audits generated during policy create/update captures 
> changes in policy.additionalResources
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Review Request 74153: RANGER-3796: updated policy change logs to handle additionalResources field

2022-10-03 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74153/
---

Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, 
Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat 
Chaudhary, and Velmurugan Periasamy.


Bugs: RANGER-3796
https://issues.apache.org/jira/browse/RANGER-3796


Repository: ranger


Description
---

Updated policy change logs to handle additionalResources field


Diffs
-

  
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 
92aaaebdc 


Diff: https://reviews.apache.org/r/74153/diff/1/


Testing
---

- validated that admin audits generated during policy create/update captures 
changes in policy.additionalResources


Thanks,

Madhan Neethiraj