Re: Review Request 74367: RANGER-4157: fixed handling of implicit addition of expression condition

2023-03-29 Thread Abhay Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74367/#review225309
---


Ship it!




Ship It!

- Abhay Kulkarni


On March 28, 2023, 9:33 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74367/
> ---
> 
> (Updated March 28, 2023, 9:33 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay 
> Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, 
> Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4157
> https://issues.apache.org/jira/browse/RANGER-4157
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> moved from RangerServiceDefService.mapEntityToViewBean() to 
> RangerServiceDefServiceBase.populateViewBean() many fields are overwriten in 
> populateViewBean() method
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefService.java
>  328d8baa6 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java
>  656bc0184 
> 
> 
> Diff: https://reviews.apache.org/r/74367/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that expression condition is added to all service-defs, including 
> knox/kafka/solr
> - verified that existing tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Review Request 74367: RANGER-4157: fixed handling of implicit addition of expression condition

2023-03-28 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74367/
---

Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, 
Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat 
Chaudhary, and Velmurugan Periasamy.


Bugs: RANGER-4157
https://issues.apache.org/jira/browse/RANGER-4157


Repository: ranger


Description
---

moved from RangerServiceDefService.mapEntityToViewBean() to 
RangerServiceDefServiceBase.populateViewBean() many fields are overwriten in 
populateViewBean() method


Diffs
-

  
security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefService.java
 328d8baa6 
  
security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java
 656bc0184 


Diff: https://reviews.apache.org/r/74367/diff/1/


Testing
---

- verified that expression condition is added to all service-defs, including 
knox/kafka/solr
- verified that existing tests pass successfully


Thanks,

Madhan Neethiraj