Re: Review Request 74530: RANGER-4336: added configurations to enable status logging in audit framework

2023-08-03 Thread Ramesh Mani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74530/#review225626
---


Ship it!




Ship It!

- Ramesh Mani


On July 28, 2023, 12:07 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74530/
> ---
> 
> (Updated July 28, 2023, 12:07 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Monika 
> Kachhadiya, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, and Subhrat 
> Chaudhary.
> 
> 
> Bugs: RANGER-4336
> https://issues.apache.org/jira/browse/RANGER-4336
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - added configurations to enable status logging in audit framework
> - audit status are logged at INFO level
> - updated unit test to avoid retaining of unncessary objects in memory
> 
> 
> Diffs
> -
> 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java
>  8511ce9cb 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditAsyncQueue.java 
> 68527d37d 
>   security-admin/src/test/java/org/apache/ranger/audit/TestConsumer.java 
> 579485663 
> 
> 
> Diff: https://reviews.apache.org/r/74530/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that audit status is logged when 
> xasecure.audit.log.status.log.enabled is set to true
> - verified that all unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 74530: RANGER-4336: added configurations to enable status logging in audit framework

2023-08-01 Thread Selvamohan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74530/#review225622
---


Ship it!




Ship It!

- Selvamohan Neethiraj


On July 27, 2023, 8:07 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74530/
> ---
> 
> (Updated July 27, 2023, 8:07 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Monika 
> Kachhadiya, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, and Subhrat 
> Chaudhary.
> 
> 
> Bugs: RANGER-4336
> https://issues.apache.org/jira/browse/RANGER-4336
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - added configurations to enable status logging in audit framework
> - audit status are logged at INFO level
> - updated unit test to avoid retaining of unncessary objects in memory
> 
> 
> Diffs
> -
> 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java
>  8511ce9cb 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditAsyncQueue.java 
> 68527d37d 
>   security-admin/src/test/java/org/apache/ranger/audit/TestConsumer.java 
> 579485663 
> 
> 
> Diff: https://reviews.apache.org/r/74530/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that audit status is logged when 
> xasecure.audit.log.status.log.enabled is set to true
> - verified that all unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Review Request 74530: RANGER-4336: added configurations to enable status logging in audit framework

2023-07-27 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74530/
---

Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Monika Kachhadiya, 
Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, and Subhrat Chaudhary.


Bugs: RANGER-4336
https://issues.apache.org/jira/browse/RANGER-4336


Repository: ranger


Description
---

- added configurations to enable status logging in audit framework
- audit status are logged at INFO level
- updated unit test to avoid retaining of unncessary objects in memory


Diffs
-

  
agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java
 8511ce9cb 
  agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditAsyncQueue.java 
68527d37d 
  security-admin/src/test/java/org/apache/ranger/audit/TestConsumer.java 
579485663 


Diff: https://reviews.apache.org/r/74530/diff/1/


Testing
---

- verified that audit status is logged when 
xasecure.audit.log.status.log.enabled is set to true
- verified that all unit tests pass successfully


Thanks,

Madhan Neethiraj