Re: Review Request 74572: RANGER-4347 : User name with comma split in old Ranger admin UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74572/#review226000 --- Ship it! Ship It! - Dineshkumar Yadav On Nov. 22, 2023, 5:21 a.m., Dhaval Rajpara wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74572/ > --- > > (Updated Nov. 22, 2023, 5:21 a.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, > Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nitin > Galave, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-4347 > https://issues.apache.org/jira/browse/RANGER-4347 > > > Repository: ranger > > > Description > --- > > when using Ranger Audit filter to filter out the audit for a specific user: > Usually, if we input a username, it would be no issue, but if we input the > user like: “CN=SZH-C-004VX,CN=Machine,CN=PKI,DC=Bosch,DC=com”. > We found that once we saved the audit filter policy, the user was split into > “CN=SZH-C-004VX”, “CN=Machine”, “CN=PKI”, “DC=Bosch”, “DC=com” > It happens because Ranger UI recognize “,” to be separate items. > > Same scenario is present in : > 1) Security Zone Form > 2) Permission modules > 3) Role Form > > > Diffs > - > > security-admin/src/main/webapp/libs/fsOverrides/BBFOverrides.js 469f4aa9c > security-admin/src/main/webapp/scripts/models/RangerZone.js 08d118132 > security-admin/src/main/webapp/scripts/utils/XAUtils.js 3c5907099 > > security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionForm.js > 7b8c4c809 > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js > 118dfe215 > security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js > ebdd2a0b2 > security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js > a4885e379 > > security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreateForm.js > cbfb8da2d > security-admin/src/main/webapp/scripts/views/service/AuditFilterConfig.js > 27e2aaecb > security-admin/src/main/webapp/scripts/views/users/AddUsersOrGroupsList.js > 26a62e67d > security-admin/src/main/webapp/styles/xa.css f5544cca0 > > security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html > 68737 > > security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html > 2ddfc3927 > security-admin/src/main/webapp/templates/users/RoleForm_tmpl.html 7686c3fd1 > > > Diff: https://reviews.apache.org/r/74572/diff/2/ > > > Testing > --- > > Validated below scenarios with adding comman in name on old UI > 1. Tested Resource Based/Tag Based/ KMS Service CRUD. > 2. Tested Zone & Unzone policy CRUD. > 3. Tested User/Group/ Role CRUD. > 4. Tested Zone CRUD. > 5. Tested Resource Based/Tag Based/ KMS Policy CRUD. > 6. Tested reports/permissions/audits tab. > 7. Tested Export and import feature. > > > Thanks, > > Dhaval Rajpara > >
Re: Review Request 74572: RANGER-4347 : User name with comma split in old Ranger admin UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74572/#review225995 --- Ship it! Ship It! - Mugdha Varadkar On Nov. 22, 2023, 5:21 a.m., Dhaval Rajpara wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74572/ > --- > > (Updated Nov. 22, 2023, 5:21 a.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, > Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nitin > Galave, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-4347 > https://issues.apache.org/jira/browse/RANGER-4347 > > > Repository: ranger > > > Description > --- > > when using Ranger Audit filter to filter out the audit for a specific user: > Usually, if we input a username, it would be no issue, but if we input the > user like: “CN=SZH-C-004VX,CN=Machine,CN=PKI,DC=Bosch,DC=com”. > We found that once we saved the audit filter policy, the user was split into > “CN=SZH-C-004VX”, “CN=Machine”, “CN=PKI”, “DC=Bosch”, “DC=com” > It happens because Ranger UI recognize “,” to be separate items. > > Same scenario is present in : > 1) Security Zone Form > 2) Permission modules > 3) Role Form > > > Diffs > - > > security-admin/src/main/webapp/libs/fsOverrides/BBFOverrides.js 469f4aa9c > security-admin/src/main/webapp/scripts/models/RangerZone.js 08d118132 > security-admin/src/main/webapp/scripts/utils/XAUtils.js 3c5907099 > > security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionForm.js > 7b8c4c809 > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js > 118dfe215 > security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js > ebdd2a0b2 > security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js > a4885e379 > > security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreateForm.js > cbfb8da2d > security-admin/src/main/webapp/scripts/views/service/AuditFilterConfig.js > 27e2aaecb > security-admin/src/main/webapp/scripts/views/users/AddUsersOrGroupsList.js > 26a62e67d > security-admin/src/main/webapp/styles/xa.css f5544cca0 > > security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html > 68737 > > security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html > 2ddfc3927 > security-admin/src/main/webapp/templates/users/RoleForm_tmpl.html 7686c3fd1 > > > Diff: https://reviews.apache.org/r/74572/diff/2/ > > > Testing > --- > > Validated below scenarios with adding comman in name on old UI > 1. Tested Resource Based/Tag Based/ KMS Service CRUD. > 2. Tested Zone & Unzone policy CRUD. > 3. Tested User/Group/ Role CRUD. > 4. Tested Zone CRUD. > 5. Tested Resource Based/Tag Based/ KMS Policy CRUD. > 6. Tested reports/permissions/audits tab. > 7. Tested Export and import feature. > > > Thanks, > > Dhaval Rajpara > >
Re: Review Request 74572: RANGER-4347 : User name with comma split in old Ranger admin UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74572/ --- (Updated Nov. 22, 2023, 5:21 a.m.) Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nitin Galave, Pradeep Agrawal, and Velmurugan Periasamy. Bugs: RANGER-4347 https://issues.apache.org/jira/browse/RANGER-4347 Repository: ranger Description --- when using Ranger Audit filter to filter out the audit for a specific user: Usually, if we input a username, it would be no issue, but if we input the user like: “CN=SZH-C-004VX,CN=Machine,CN=PKI,DC=Bosch,DC=com”. We found that once we saved the audit filter policy, the user was split into “CN=SZH-C-004VX”, “CN=Machine”, “CN=PKI”, “DC=Bosch”, “DC=com” It happens because Ranger UI recognize “,” to be separate items. Same scenario is present in : 1) Security Zone Form 2) Permission modules 3) Role Form Diffs (updated) - security-admin/src/main/webapp/libs/fsOverrides/BBFOverrides.js 469f4aa9c security-admin/src/main/webapp/scripts/models/RangerZone.js 08d118132 security-admin/src/main/webapp/scripts/utils/XAUtils.js 3c5907099 security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionForm.js 7b8c4c809 security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 118dfe215 security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js ebdd2a0b2 security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js a4885e379 security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreateForm.js cbfb8da2d security-admin/src/main/webapp/scripts/views/service/AuditFilterConfig.js 27e2aaecb security-admin/src/main/webapp/scripts/views/users/AddUsersOrGroupsList.js 26a62e67d security-admin/src/main/webapp/styles/xa.css f5544cca0 security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 68737 security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html 2ddfc3927 security-admin/src/main/webapp/templates/users/RoleForm_tmpl.html 7686c3fd1 Diff: https://reviews.apache.org/r/74572/diff/2/ Changes: https://reviews.apache.org/r/74572/diff/1-2/ Testing --- Validated below scenarios with adding comman in name on old UI 1. Tested Resource Based/Tag Based/ KMS Service CRUD. 2. Tested Zone & Unzone policy CRUD. 3. Tested User/Group/ Role CRUD. 4. Tested Zone CRUD. 5. Tested Resource Based/Tag Based/ KMS Policy CRUD. 6. Tested reports/permissions/audits tab. 7. Tested Export and import feature. Thanks, Dhaval Rajpara
Re: Review Request 74572: RANGER-4347 : User name with comma split in old Ranger admin UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74572/ --- (Updated Nov. 20, 2023, 6:30 a.m.) Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nitin Galave, Pradeep Agrawal, and Velmurugan Periasamy. Bugs: RANGER-4347 https://issues.apache.org/jira/browse/RANGER-4347 Repository: ranger Description --- when using Ranger Audit filter to filter out the audit for a specific user: Usually, if we input a username, it would be no issue, but if we input the user like: “CN=SZH-C-004VX,CN=Machine,CN=PKI,DC=Bosch,DC=com”. We found that once we saved the audit filter policy, the user was split into “CN=SZH-C-004VX”, “CN=Machine”, “CN=PKI”, “DC=Bosch”, “DC=com” It happens because Ranger UI recognize “,” to be separate items. Same scenario is present in : 1) Security Zone Form 2) Permission modules 3) Role Form Diffs - security-admin/src/main/webapp/libs/fsOverrides/BBFOverrides.js 469f4aa9c security-admin/src/main/webapp/scripts/models/RangerZone.js 08d118132 security-admin/src/main/webapp/scripts/utils/XAUtils.js 3c5907099 security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionForm.js 7b8c4c809 security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js ebdd2a0b2 security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js a4885e379 security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreateForm.js cbfb8da2d security-admin/src/main/webapp/scripts/views/service/AuditFilterConfig.js 27e2aaecb security-admin/src/main/webapp/scripts/views/users/AddUsersOrGroupsList.js 26a62e67d security-admin/src/main/webapp/styles/xa.css f5544cca0 security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 68737 security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html 2ddfc3927 security-admin/src/main/webapp/templates/users/RoleForm_tmpl.html 7686c3fd1 Diff: https://reviews.apache.org/r/74572/diff/1/ Testing (updated) --- Validated below scenarios with adding comman in name on old UI 1. Tested Resource Based/Tag Based/ KMS Service CRUD. 2. Tested Zone & Unzone policy CRUD. 3. Tested User/Group/ Role CRUD. 4. Tested Zone CRUD. 5. Tested Resource Based/Tag Based/ KMS Policy CRUD. 6. Tested reports/permissions/audits tab. 7. Tested Export and import feature. Thanks, Dhaval Rajpara
Review Request 74572: RANGER-4347 : User name with comma split in old Ranger admin UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74572/ --- Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nitin Galave, Pradeep Agrawal, and Velmurugan Periasamy. Bugs: RANGER-4347 https://issues.apache.org/jira/browse/RANGER-4347 Repository: ranger Description --- when using Ranger Audit filter to filter out the audit for a specific user: Usually, if we input a username, it would be no issue, but if we input the user like: “CN=SZH-C-004VX,CN=Machine,CN=PKI,DC=Bosch,DC=com”. We found that once we saved the audit filter policy, the user was split into “CN=SZH-C-004VX”, “CN=Machine”, “CN=PKI”, “DC=Bosch”, “DC=com” It happens because Ranger UI recognize “,” to be separate items. Same scenario is present in : 1) Security Zone Form 2) Permission modules 3) Role Form Diffs - security-admin/src/main/webapp/libs/fsOverrides/BBFOverrides.js 469f4aa9c security-admin/src/main/webapp/scripts/models/RangerZone.js 08d118132 security-admin/src/main/webapp/scripts/utils/XAUtils.js 3c5907099 security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionForm.js 7b8c4c809 security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js ebdd2a0b2 security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js a4885e379 security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreateForm.js cbfb8da2d security-admin/src/main/webapp/scripts/views/service/AuditFilterConfig.js 27e2aaecb security-admin/src/main/webapp/scripts/views/users/AddUsersOrGroupsList.js 26a62e67d security-admin/src/main/webapp/styles/xa.css f5544cca0 security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 68737 security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html 2ddfc3927 security-admin/src/main/webapp/templates/users/RoleForm_tmpl.html 7686c3fd1 Diff: https://reviews.apache.org/r/74572/diff/1/ Testing --- Thanks, Dhaval Rajpara
