Re: Review Request 74667: RANGER-4376: Need to show Tag Policies for user when it has permission in "Tag Based Policies" module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74667/#review225970 --- Ship it! Ship It! - Dhaval Rajpara On Oct. 25, 2023, 10:17 a.m., Brijesh Bhalala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74667/ > --- > > (Updated Oct. 25, 2023, 10:17 a.m.) > > > Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan > Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave. > > > Bugs: RANGER-4376 > https://issues.apache.org/jira/browse/RANGER-4376 > > > Repository: ranger > > > Description > --- > > By default user with user-role doesn't have permission on Tag Based Policies > modules. > > If in some case where user with user-role is given permission on Tag Based > Policies module and not on Resource Based Policies, then need to show tag > policies. > > Need to fix this corner case in Ranger Admin UI with react JS. > > > Diffs > - > > security-admin/src/main/webapp/react-webapp/src/App.jsx bc3cf9a7a > > security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx > 5e51faf27 > > security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx > e3d09c51e > > > Diff: https://reviews.apache.org/r/74667/diff/2/ > > > Testing > --- > > Tested changes on a cluster setup with Ranger Admin build with React JS code > base. > > > Verified the "Tag Based Policies" Module with all user-role. > > > Thanks, > > Brijesh Bhalala > >
Re: Review Request 74667: RANGER-4376: Need to show Tag Policies for user when it has permission in "Tag Based Policies" module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74667/#review225892 --- Ship it! Ship It! - Mugdha Varadkar On Oct. 25, 2023, 10:17 a.m., Brijesh Bhalala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74667/ > --- > > (Updated Oct. 25, 2023, 10:17 a.m.) > > > Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan > Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave. > > > Bugs: RANGER-4376 > https://issues.apache.org/jira/browse/RANGER-4376 > > > Repository: ranger > > > Description > --- > > By default user with user-role doesn't have permission on Tag Based Policies > modules. > > If in some case where user with user-role is given permission on Tag Based > Policies module and not on Resource Based Policies, then need to show tag > policies. > > Need to fix this corner case in Ranger Admin UI with react JS. > > > Diffs > - > > security-admin/src/main/webapp/react-webapp/src/App.jsx bc3cf9a7a > > security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx > 5e51faf27 > > security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx > e3d09c51e > > > Diff: https://reviews.apache.org/r/74667/diff/2/ > > > Testing > --- > > Tested changes on a cluster setup with Ranger Admin build with React JS code > base. > > > Verified the "Tag Based Policies" Module with all user-role. > > > Thanks, > > Brijesh Bhalala > >
Re: Review Request 74667: RANGER-4376: Need to show Tag Policies for user when it has permission in "Tag Based Policies" module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74667/ --- (Updated Oct. 25, 2023, 10:17 a.m.) Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave. Bugs: RANGER-4376 https://issues.apache.org/jira/browse/RANGER-4376 Repository: ranger Description --- By default user with user-role doesn't have permission on Tag Based Policies modules. If in some case where user with user-role is given permission on Tag Based Policies module and not on Resource Based Policies, then need to show tag policies. Need to fix this corner case in Ranger Admin UI with react JS. Diffs (updated) - security-admin/src/main/webapp/react-webapp/src/App.jsx bc3cf9a7a security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx 5e51faf27 security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx e3d09c51e Diff: https://reviews.apache.org/r/74667/diff/2/ Changes: https://reviews.apache.org/r/74667/diff/1-2/ Testing --- Tested changes on a cluster setup with Ranger Admin build with React JS code base. Verified the "Tag Based Policies" Module with all user-role. Thanks, Brijesh Bhalala
Review Request 74667: RANGER-4376: Need to show Tag Policies for user when it has permission in "Tag Based Policies" module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74667/ --- Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave. Bugs: RANGER-4376 https://issues.apache.org/jira/browse/RANGER-4376 Repository: ranger Description --- By default user with user-role doesn't have permission on Tag Based Policies modules. If in some case where user with user-role is given permission on Tag Based Policies module and not on Resource Based Policies, then need to show tag policies. Need to fix this corner case in Ranger Admin UI with react JS. Diffs - security-admin/src/main/webapp/react-webapp/src/App.jsx bc3cf9a7a Diff: https://reviews.apache.org/r/74667/diff/1/ Testing --- Tested changes on a cluster setup with Ranger Admin build with React JS code base. Verified the "Tag Based Policies" Module with all user-role. Thanks, Brijesh Bhalala
