Re: Review Request 74860: RANGER-4684 : Need to update createdBy , updatedBy field for gds objects in case the creator is deleted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74860/#review226198 --- Ship it! Ship It! - Dineshkumar Yadav On Jan. 31, 2024, 7:45 a.m., Prashant Satam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74860/ > --- > > (Updated Jan. 31, 2024, 7:45 a.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, > Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita Ubale. > > > Bugs: RANGER-4684 > https://issues.apache.org/jira/browse/RANGER-4684 > > > Repository: ranger > > > Description > --- > > Currently when the creator of dataset or any gds Object is deleted from > ranger we get Error as cannot Delete the user because the mapping exist for > the Gds objects for the column addedById, so when the delete operation will > be performed the values for fields createdBy and updatedBy should be changed > from the creator to the Ranger Admin (the seeded Ranger Admin having Id 1 ) > > > Diffs > - > > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java > a0ff18948 > > security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java > 85e457efa > > > Diff: https://reviews.apache.org/r/74860/diff/1/ > > > Testing > --- > > Steps to check > 1) Create user User1 > 2) create a dataset by the User1 account so the createdBy,updatedBy field > will have login Id of user1 > 3) delete this User1 from ranger > 4) Now the values for field createdBy,updatedBy for dataset will change to > "Admin" > > > Thanks, > > Prashant Satam > >
Re: Review Request 74860: RANGER-4684 : Need to update createdBy , updatedBy field for gds objects in case the creator is deleted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74860/#review226193 --- Ship it! Ship It! - Asit Vadhavkar On Jan. 31, 2024, 7:45 a.m., Prashant Satam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74860/ > --- > > (Updated Jan. 31, 2024, 7:45 a.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, > Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita Ubale. > > > Bugs: RANGER-4684 > https://issues.apache.org/jira/browse/RANGER-4684 > > > Repository: ranger > > > Description > --- > > Currently when the creator of dataset or any gds Object is deleted from > ranger we get Error as cannot Delete the user because the mapping exist for > the Gds objects for the column addedById, so when the delete operation will > be performed the values for fields createdBy and updatedBy should be changed > from the creator to the Ranger Admin (the seeded Ranger Admin having Id 1 ) > > > Diffs > - > > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java > a0ff18948 > > security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java > 85e457efa > > > Diff: https://reviews.apache.org/r/74860/diff/1/ > > > Testing > --- > > Steps to check > 1) Create user User1 > 2) create a dataset by the User1 account so the createdBy,updatedBy field > will have login Id of user1 > 3) delete this User1 from ranger > 4) Now the values for field createdBy,updatedBy for dataset will change to > "Admin" > > > Thanks, > > Prashant Satam > >
Review Request 74860: RANGER-4684 : Need to update createdBy , updatedBy field for gds objects in case the creator is deleted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74860/ --- Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita Ubale. Bugs: RANGER-4684 https://issues.apache.org/jira/browse/RANGER-4684 Repository: ranger Description --- Currently when the creator of dataset or any gds Object is deleted from ranger we get Error as cannot Delete the user because the mapping exist for the Gds objects for the column addedById, so when the delete operation will be performed the values for fields createdBy and updatedBy should be changed from the creator to the Ranger Admin (the seeded Ranger Admin having Id 1) Diffs - security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java a0ff18948 security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java 85e457efa Diff: https://reviews.apache.org/r/74860/diff/1/ Testing --- Steps to check 1) Create user User1 2) create a dataset by the User1 account so the createdBy,updatedBy field will have login Id of user1 3) delete this User1 from ranger 4) Now the values for field createdBy,updatedBy for dataset will change to "Admin" Thanks, Prashant Satam
