Re: Review Request 74880: RANGER-4698: Audit UI improvements with respect to values overflowing into other columns

2024-02-29 Thread Dhaval Rajpara

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74880/#review226272
---


Ship it!




Ship It!

- Dhaval Rajpara


On Feb. 14, 2024, 3:32 a.m., Abhishek Patil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74880/
> ---
> 
> (Updated Feb. 14, 2024, 3:32 a.m.)
> 
> 
> Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Madhan Neethiraj, 
> Mehul Parikh, Mugdha Varadkar, and Ramesh Mani.
> 
> 
> Bugs: RANGER-4698
> https://issues.apache.org/jira/browse/RANGER-4698
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> In the Ranger react UI, in the audits, if the length of certain fields is 
> long, the value is overflowing into other columns.
> In such scenarios, the value must be clipped in the audit display tables.
> Improvements have to be added in :-
> 1. Access Audits - Service Name and Cluster Name fields
> 2. Plugin Status Audits - Service Name field
> 3. Login sessions Audits - Login Id field
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx
>  8e12ec654 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx
>  37aa0e01e 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx
>  d798a5fd5 
> 
> 
> Diff: https://reviews.apache.org/r/74880/diff/1/
> 
> 
> Testing
> ---
> 
> Applied the patch on a cluster and ensured that the values are clipped when 
> the value is long,
> and ensured that the text is not overflowing into other columns
> 
> 
> Thanks,
> 
> Abhishek Patil
> 
>



Re: Review Request 74880: RANGER-4698: Audit UI improvements with respect to values overflowing into other columns

2024-02-13 Thread Abhishek Patil

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74880/
---

(Updated Feb. 14, 2024, 3:32 a.m.)


Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Madhan Neethiraj, 
Mehul Parikh, Mugdha Varadkar, and Ramesh Mani.


Bugs: RANGER-4698
https://issues.apache.org/jira/browse/RANGER-4698


Repository: ranger


Description
---

In the Ranger react UI, in the audits, if the length of certain fields is long, 
the value is overflowing into other columns.
In such scenarios, the value must be clipped in the audit display tables.
Improvements have to be added in :-
1. Access Audits - Service Name and Cluster Name fields
2. Plugin Status Audits - Service Name field
3. Login sessions Audits - Login Id field


Diffs
-

  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx 
8e12ec654 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx
 37aa0e01e 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx
 d798a5fd5 


Diff: https://reviews.apache.org/r/74880/diff/1/


Testing
---

Applied the patch on a cluster and ensured that the values are clipped when the 
value is long,
and ensured that the text is not overflowing into other columns


Thanks,

Abhishek Patil