Re: Review Request 74881: RANGER-4697 : Increment GDS version when security zone is updated

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74881/#review226214
---


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 14, 2024, 7:47 p.m., Anand Nadar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74881/
> ---
> 
> (Updated Feb. 14, 2024, 7:47 p.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Madhan Neethiraj, Monika 
> Kachhadiya, Prashant Satam, Siddhesh Phatak, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4697
> https://issues.apache.org/jira/browse/RANGER-4697
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> When a security zone is modified, if its services are associated with any 
> datashare then the service specific GDS version needs to be incremented.
> 
> 
> Diffs
> -
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/GdsStore.java 
> 0dad263d9 
>   security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 
> 4fa9c48df 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java
>  25567c727 
> 
> 
> Diff: https://reviews.apache.org/r/74881/diff/2/
> 
> 
> Testing
> ---
> 
> Verified that global gds version and service specific gds version are 
> incremented when zone is updated and it is associated with a datashare.
> Verified that if the zone and service are not associated with a datashare 
> then the gds versions are not incremented.
> 
> 
> Thanks,
> 
> Anand Nadar
> 
>

Re: Review Request 74881: RANGER-4697 : Increment GDS version when security zone is updated

[Anand Nadar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74881/
---

(Updated Feb. 14, 2024, 7:47 p.m.)


Review request for ranger, Asit Vadhavkar, Madhan Neethiraj, Monika Kachhadiya, 
Prashant Satam, Siddhesh Phatak, and Subhrat Chaudhary.


Changes
---

updated code to implement logic of update and delete services of security-zone 
inside same method


Bugs: RANGER-4697
https://issues.apache.org/jira/browse/RANGER-4697


Repository: ranger


Description
---

When a security zone is modified, if its services are associated with any 
datashare then the service specific GDS version needs to be incremented.


Diffs (updated)
-

  agents-common/src/main/java/org/apache/ranger/plugin/store/GdsStore.java 
0dad263d9 
  security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 4fa9c48df 
  
security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java
 25567c727 


Diff: https://reviews.apache.org/r/74881/diff/2/

Changes: https://reviews.apache.org/r/74881/diff/1-2/


Testing
---

Verified that global gds version and service specific gds version are 
incremented when zone is updated and it is associated with a datashare.
Verified that if the zone and service are not associated with a datashare then 
the gds versions are not incremented.


Thanks,

Anand Nadar

Re: Review Request 74881: RANGER-4697 : Increment GDS version when security zone is updated

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74881/#review226213
---




agents-common/src/main/java/org/apache/ranger/plugin/store/GdsStore.java
Lines 142 (patched)


Instead of introducing new method 
updateGDSVersionIfAssociatedWithDatashare(), consider updating 
deleteAllGdsObjectsForServicesInSecurityZone() as below to handle both updated 
and deleted services:

- rename deleteAllGdsObjectsForServicesInSecurityZone() => 
onSecurityZoneUpdate(Long zoneId, Collection updatedServices, 
Collection deletedServices);


- Madhan Neethiraj


On Feb. 13, 2024, 11:16 a.m., Anand Nadar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74881/
> ---
> 
> (Updated Feb. 13, 2024, 11:16 a.m.)
> 
> 
> Review request for ranger, Asit Vadhavkar, Madhan Neethiraj, Monika 
> Kachhadiya, Prashant Satam, Siddhesh Phatak, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4697
> https://issues.apache.org/jira/browse/RANGER-4697
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> When a security zone is modified, if its services are associated with any 
> datashare then the service specific GDS version needs to be incremented.
> 
> 
> Diffs
> -
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/GdsStore.java 
> 0dad263d9 
>   security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 
> 4fa9c48df 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java
>  25567c727 
> 
> 
> Diff: https://reviews.apache.org/r/74881/diff/1/
> 
> 
> Testing
> ---
> 
> Verified that global gds version and service specific gds version are 
> incremented when zone is updated and it is associated with a datashare.
> Verified that if the zone and service are not associated with a datashare 
> then the gds versions are not incremented.
> 
> 
> Thanks,
> 
> Anand Nadar
> 
>

Review Request 74881: RANGER-4697 : Increment GDS version when security zone is updated

[Anand Nadar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74881/
---

Review request for ranger, Asit Vadhavkar, Madhan Neethiraj, Monika Kachhadiya, 
Prashant Satam, Siddhesh Phatak, and Subhrat Chaudhary.


Bugs: RANGER-4697
https://issues.apache.org/jira/browse/RANGER-4697


Repository: ranger


Description
---

When a security zone is modified, if its services are associated with any 
datashare then the service specific GDS version needs to be incremented.


Diffs
-

  agents-common/src/main/java/org/apache/ranger/plugin/store/GdsStore.java 
0dad263d9 
  security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 4fa9c48df 
  
security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java
 25567c727 


Diff: https://reviews.apache.org/r/74881/diff/1/


Testing
---

Verified that global gds version and service specific gds version are 
incremented when zone is updated and it is associated with a datashare.
Verified that if the zone and service are not associated with a datashare then 
the gds versions are not incremented.


Thanks,

Anand Nadar