Re: Review Request 74884: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

2024-03-05 Thread Rakesh Gupta


> On March 5, 2024, 10:11 p.m., Madhan Neethiraj wrote:
> > Rakesh - thank you for this enhancement. Ability to sort based on various 
> > timestamps will be of big help in troubleshooting. I see that you discarded 
> > this review; are you planning any further updates to this patch?

Hi Madhan,
Currently I am working on new design approach, I will share the approach on 
Jira.


- Rakesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74884/#review226285
---


On Feb. 20, 2024, 9:02 a.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74884/
> ---
> 
> (Updated Feb. 20, 2024, 9:02 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4692
> https://issues.apache.org/jira/browse/RANGER-4692
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently there are different type like (Policy, Role, Tag, UserStore and 
> GDS) on plugin status.
> 
> when we have plugins(large enough to accommodate in single page), It will be 
> helpful to identify any out-of-sync plugins based on download times, sorting 
> them by policyDownloadTime, tagDownloadTime, roleDownloadTime, 
> userstoreDownloadTime and gdsDownloadTime.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java
>  6d3d17d9e 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 
> fa72ef2ea 
>   security-admin/db/mysql/patches/073-create-view-plugin-info.sql 
> PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 772514610 
>   security-admin/db/oracle/patches/067-create-view-plugin-info.sql 
> PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> e177d44d7 
>   security-admin/db/postgres/patches/073-create-view-plugin-info.sql 
> PRE-CREATION 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  32cfed7ae 
>   security-admin/db/sqlanywhere/patches/067-create-view-plugin-info.sql 
> PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 831aad66d 
>   security-admin/db/sqlserver/patches/067-create-view-plugin-info.sql 
> PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java 
> a15d8d056 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java
>  9dc26ceb7 
> 
> 
> Diff: https://reviews.apache.org/r/74884/diff/2/
> 
> 
> Testing
> ---
> 
> I have verified that new columns have been successfully added to the 
> x_plugin_info table(for fresh installment), through which we can now sort by 
> event(Download,Activation).
> I have tested and confirmed that data can be inserted into these new columns 
> in upgrade scenario, through which we can now use them for sorting the data 
> based on events(Download,Activation).
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>



Re: Review Request 74884: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

2024-03-05 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74884/#review226285
---



Rakesh - thank you for this enhancement. Ability to sort based on various 
timestamps will be of big help in troubleshooting. I see that you discarded 
this review; are you planning any further updates to this patch?

- Madhan Neethiraj


On Feb. 20, 2024, 9:02 a.m., Rakesh Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74884/
> ---
> 
> (Updated Feb. 20, 2024, 9:02 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, 
> sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4692
> https://issues.apache.org/jira/browse/RANGER-4692
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently there are different type like (Policy, Role, Tag, UserStore and 
> GDS) on plugin status.
> 
> when we have plugins(large enough to accommodate in single page), It will be 
> helpful to identify any out-of-sync plugins based on download times, sorting 
> them by policyDownloadTime, tagDownloadTime, roleDownloadTime, 
> userstoreDownloadTime and gdsDownloadTime.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java
>  6d3d17d9e 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 
> fa72ef2ea 
>   security-admin/db/mysql/patches/073-create-view-plugin-info.sql 
> PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
> 772514610 
>   security-admin/db/oracle/patches/067-create-view-plugin-info.sql 
> PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
> e177d44d7 
>   security-admin/db/postgres/patches/073-create-view-plugin-info.sql 
> PRE-CREATION 
>   
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql
>  32cfed7ae 
>   security-admin/db/sqlanywhere/patches/067-create-view-plugin-info.sql 
> PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
> 831aad66d 
>   security-admin/db/sqlserver/patches/067-create-view-plugin-info.sql 
> PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java 
> a15d8d056 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java
>  9dc26ceb7 
> 
> 
> Diff: https://reviews.apache.org/r/74884/diff/2/
> 
> 
> Testing
> ---
> 
> I have verified that new columns have been successfully added to the 
> x_plugin_info table(for fresh installment), through which we can now sort by 
> event(Download,Activation).
> I have tested and confirmed that data can be inserted into these new columns 
> in upgrade scenario, through which we can now use them for sorting the data 
> based on events(Download,Activation).
> 
> 
> Thanks,
> 
> Rakesh Gupta
> 
>



Re: Review Request 74884: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

2024-02-20 Thread Rakesh Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74884/
---

(Updated Feb. 20, 2024, 9:02 a.m.)


Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket 
shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
---

Added Sorting by pluginIpAddress


Bugs: RANGER-4692
https://issues.apache.org/jira/browse/RANGER-4692


Repository: ranger


Description
---

Currently there are different type like (Policy, Role, Tag, UserStore and GDS) 
on plugin status.

when we have plugins(large enough to accommodate in single page), It will be 
helpful to identify any out-of-sync plugins based on download times, sorting 
them by policyDownloadTime, tagDownloadTime, roleDownloadTime, 
userstoreDownloadTime and gdsDownloadTime.


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java
 6d3d17d9e 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql fa72ef2ea 
  security-admin/db/mysql/patches/073-create-view-plugin-info.sql PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
772514610 
  security-admin/db/oracle/patches/067-create-view-plugin-info.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
e177d44d7 
  security-admin/db/postgres/patches/073-create-view-plugin-info.sql 
PRE-CREATION 
  
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 
32cfed7ae 
  security-admin/db/sqlanywhere/patches/067-create-view-plugin-info.sql 
PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
831aad66d 
  security-admin/db/sqlserver/patches/067-create-view-plugin-info.sql 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java 
a15d8d056 
  
security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java
 9dc26ceb7 


Diff: https://reviews.apache.org/r/74884/diff/2/

Changes: https://reviews.apache.org/r/74884/diff/1-2/


Testing
---

I have verified that new columns have been successfully added to the 
x_plugin_info table(for fresh installment), through which we can now sort by 
event(Download,Activation).
I have tested and confirmed that data can be inserted into these new columns in 
upgrade scenario, through which we can now use them for sorting the data based 
on events(Download,Activation).


Thanks,

Rakesh Gupta



Review Request 74884: RANGER-4692: Sorting on the Ranger Admin - Plugin Status page by event(Download, Activation)

2024-02-14 Thread Rakesh Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74884/
---

Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket 
shelar, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4692
https://issues.apache.org/jira/browse/RANGER-4692


Repository: ranger


Description
---

Currently there are different type like (Policy, Role, Tag, UserStore and GDS) 
on plugin status.

when we have plugins(large enough to accommodate in single page), It will be 
helpful to identify any out-of-sync plugins based on download times, sorting 
them by policyDownloadTime, tagDownloadTime, roleDownloadTime, 
userstoreDownloadTime and gdsDownloadTime.


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java
 6d3d17d9e 
  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql fa72ef2ea 
  security-admin/db/mysql/patches/073-create-view-plugin-info.sql PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 
772514610 
  security-admin/db/oracle/patches/067-create-view-plugin-info.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 
e177d44d7 
  security-admin/db/postgres/patches/073-create-view-plugin-info.sql 
PRE-CREATION 
  
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 
32cfed7ae 
  security-admin/db/sqlanywhere/patches/067-create-view-plugin-info.sql 
PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 
831aad66d 
  security-admin/db/sqlserver/patches/067-create-view-plugin-info.sql 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java 
a15d8d056 
  
security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java
 9dc26ceb7 


Diff: https://reviews.apache.org/r/74884/diff/1/


Testing
---

I have verified that new columns have been successfully added to the 
x_plugin_info table(for fresh installment), through which we can now sort by 
event(Download,Activation).
I have tested and confirmed that data can be inserted into these new columns in 
upgrade scenario, through which we can now use them for sorting the data based 
on events(Download,Activation).


Thanks,

Rakesh Gupta