Re: Review Request 74952: RANGER-4767: Deleted policies are still taking effect if all policies for a security zone are deleted

2024-04-04 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74952/#review226378
---


Ship it!




Ship It!

- Madhan Neethiraj


On April 4, 2024, 5:04 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74952/
> ---
> 
> (Updated April 4, 2024, 5:04 p.m.)
> 
> 
> Review request for ranger, Abhishek Patil, madhan, Madhan Neethiraj, and 
> Pradeep Agrawal.
> 
> 
> Bugs: RANGER-4767
> https://issues.apache.org/jira/browse/RANGER-4767
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> If all the policies for a security zone are deleted, then still the previous 
> policies are taking effect.
> If there are no policies in the repo, then the following error is seen in the 
> logs
> while syncing the policies, and the previously existing policies are still 
> taking effect and operations are allowed through those policies.
> 
> The policy-engine creation failed with a NPE when processing the set of 
> policies containing a security zone with no policies in it.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
>  6a3d59dae 
> 
> 
> Diff: https://reviews.apache.org/r/74952/diff/1/
> 
> 
> Testing
> ---
> 
> Compiled and ran all unit tests successfully.
> 
> Verified by manually testing the scenario in the cluster.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>



Review Request 74952: RANGER-4767: Deleted policies are still taking effect if all policies for a security zone are deleted

2024-04-04 Thread Abhay Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74952/
---

Review request for ranger, Abhishek Patil, madhan, Madhan Neethiraj, and 
Pradeep Agrawal.


Bugs: RANGER-4767
https://issues.apache.org/jira/browse/RANGER-4767


Repository: ranger


Description
---

If all the policies for a security zone are deleted, then still the previous 
policies are taking effect.
If there are no policies in the repo, then the following error is seen in the 
logs
while syncing the policies, and the previously existing policies are still 
taking effect and operations are allowed through those policies.

The policy-engine creation failed with a NPE when processing the set of 
policies containing a security zone with no policies in it.


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
 6a3d59dae 


Diff: https://reviews.apache.org/r/74952/diff/1/


Testing
---

Compiled and ran all unit tests successfully.

Verified by manually testing the scenario in the cluster.


Thanks,

Abhay Kulkarni