[GitHub] vongosling closed pull request #28: [ROCKETMQ-27]Add store commitlog path online
vongosling closed pull request #28: [ROCKETMQ-27]Add store commitlog path online URL: https://github.com/apache/rocketmq/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vongosling commented on issue #28: [ROCKETMQ-27]Add store commitlog path online
vongosling commented on issue #28: [ROCKETMQ-27]Add store commitlog path online URL: https://github.com/apache/rocketmq/pull/28#issuecomment-353023792 @lizhanhui I close this pr. If you have free time to pick up this issue, we could continue to discuss it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vongosling commented on issue #85: [ROCKETMQ-158]Remove logback dependency for rocketmq-tools
vongosling commented on issue #85: [ROCKETMQ-158]Remove logback dependency for rocketmq-tools URL: https://github.com/apache/rocketmq/pull/85#issuecomment-353024032 @Jaskey Could you pick up this pr This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [ANNOUNCE] Release Apache RocketMQ 4.2.0
Hi sebb and justin, thanks to your suggestion. I have polished our quick start doc and provided simple steps to build from official Apache release. Also, we will use the mirror site link in our next release announcement. Regards, yukon On Tue, Dec 19, 2017 at 10:57 AM, Von Gosling wrote: > Thanks sebb and justin suggestion. I have looked at some other Apache > TLPs, including justin’s link[1]. We will consider to polish quick-start > guide using ASF proved release :-) > > > [1] http://www.apache.org/legal/release-policy.html#host-rc < > http://www.apache.org/legal/release-policy.html#host-rc> > > > Best Regards, > Von Gosling > > > 在 2017年12月19日，08:06，sebb 写道： > > > > On 18 December 2017 at 23:13, Justin Mclean > wrote: > >> Hi, > >> > >> Also, the quickstart page > >> https://rocketmq.apache.org/docs/quick-start/ > >> says to clone the development branch of the code. > >> > >> Only source that has been formally approved by the PMC should be > advertised. > >> > >> > >> I’m not sure that applies to source code just to unproved releases. > i.e. you > > > > Source code is the primary output of ASF projects. > > > >> can’t post links to unproved releases like nightly builds and the like > [1] > >> (and even some projects do this) e.g. [3] but make it clear it’s not an > >> official build. Many top level projects I’ve looked at include links to > the > >> work in progress repo and some projects have no distinction between > master > >> and develop. > > > > That does not make it right. > > It also depends which part of the website has the links. > > It's OK to link to the repo from pages intended for developers, but > > not from pages intended for the general public. > > > >> Perhaps just change that page and suggest that people use the download > page > >> [2] to get an official release above where that the repo information is > >> listed and note that the develop branch may contain code that is not in > an > >> official release? > >> > >> Thanks, > >> Justin > >> > >> 1. http://www.apache.org/legal/release-policy.html#host-rc > >> 2. https://rocketmq.apache.org/dowloading/releases/ > >> 3. https://ant.apache.org/nightlies.html > >
[GitHub] lindzh opened a new pull request #209: [ROCKETMQ-339] Specify consume thread pool for different topic
lindzh opened a new pull request #209: [ROCKETMQ-339] Specify consume thread pool for different topic URL: https://github.com/apache/rocketmq/pull/209 ## What is the purpose of the change When a consumer group consumes many topics, it use only one consume thread pool to submit consume tasks.When one topic callback process cost much time,it may block other topic consume and cause message delay. ## Brief changelog add consumeThreadExecutor when subscribe a topic. ## Verifying this change This is a trivial change. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ROCKETMQ-XXX] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [x] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fuyou001 opened a new pull request #210: [ROCKETMQ-340] improve code for avoid ClassCastException.
fuyou001 opened a new pull request #210: [ROCKETMQ-340] improve code for avoid ClassCastException. URL: https://github.com/apache/rocketmq/pull/210 ## What is the purpose of the change improve code for avoid ClassCastException ## Brief changelog sometimes BrokerFastFailuru#castRunnable throw ClassCastException , so fix it . improve code for avoid ClassCastException ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[ROCKETMQ-XXX] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #209: [ROCKETMQ-339] Specify consume thread pool for different topic
coveralls commented on issue #209: [ROCKETMQ-339] Specify consume thread pool for different topic URL: https://github.com/apache/rocketmq/pull/209#issuecomment-353075141 [](https://coveralls.io/builds/14741815) Coverage increased (+0.03%) to 39.993% when pulling **925a5867db5284431bbf8625c21255ddfb151f9e on lindzh:consume_thread_pool** into **cc0b3d091814a390107b8e733dd8a5427ff49296 on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #210: [ROCKETMQ-340] improve code for avoid ClassCastException.
coveralls commented on issue #210: [ROCKETMQ-340] improve code for avoid ClassCastException. URL: https://github.com/apache/rocketmq/pull/210#issuecomment-353080221 [](https://coveralls.io/builds/14742133) Coverage increased (+0.07%) to 40.025% when pulling **9f0ef6d011811fc016ec94ab3c385b90f7d94643 on fuyou001:ROCKETMQ-340** into **cc0b3d091814a390107b8e733dd8a5427ff49296 on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fucongchan commented on issue #206: [ROCKETMQ-334] spinlock performance improvement
fucongchan commented on issue #206: [ROCKETMQ-334] spinlock performance improvement URL: https://github.com/apache/rocketmq/pull/206#issuecomment-353117942 @zhouxinyu @dongeforever @lizhanhui, Please take a look This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vsair commented on issue #206: [ROCKETMQ-334] spinlock performance improvement
vsair commented on issue #206: [ROCKETMQ-334] spinlock performance improvement URL: https://github.com/apache/rocketmq/pull/206#issuecomment-353237087 Hi, could you please show some performance report about this improvement? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
