[GitHub] iamzhoug37 commented on issue #249: master-slave sync model performance improve
iamzhoug37 commented on issue #249: master-slave sync model performance improve URL: https://github.com/apache/rocketmq/issues/249#issuecomment-376781318 并不是这样的，只是处理线程返回了(处理线程返回了，就可以处理下一个写入，提高吞吐)，请求的响应是由GroupTransferService线程进行的，这段时间我会把pr完善下，发出来 我这个是日志是我们公司的监控组件，叫cat(https://github.com/dianping/cat) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] iamzhoug37 commented on issue #249: master-slave sync model performance improve
iamzhoug37 commented on issue #249: master-slave sync model performance improve URL: https://github.com/apache/rocketmq/issues/249#issuecomment-376781318 并不是这样的，只是处理线程返回了，请求的响应是由GroupTransferService进行的，这段时间我会把pr完善下，发出来 我这个是日志是我们公司的监控组件，叫cat(https://github.com/dianping/cat) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gaoyf commented on issue #249: master-slave sync model performance improve
gaoyf commented on issue #249: master-slave sync model performance improve URL: https://github.com/apache/rocketmq/issues/249#issuecomment-376779981 我理解的 `SYNC_MASTER` 是同步双写，即，**消息同步写给slave才算成功，消息发送方需要根据返回状态决定消息是否重发**。 而你 @iamzhoug37 所说的改进，只是主发送线程不再等待同步消息给slave的状态，这样消息发送方就不知道是否同步成功了。 如果你不在乎是否同步给slave，只在乎是否写入本地硬盘，应该用`flushDiskType=SYNC_FLUSH brokerRole=ASYNC_MASTER`模式。 这个存储层高可用我已经进行过分析了，参考我的分析：https://blog.csdn.net/a417930422/article/details/52585204 另外咨询你一下，你的日志解析的图使用什么工具？多谢 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] iamzhoug37 commented on issue #249: master-slave sync model performance improve
iamzhoug37 commented on issue #249: master-slave sync model performance improve URL: https://github.com/apache/rocketmq/issues/249#issuecomment-376752421 I'm willing to provide code for this issue. I'm wrting standard code that conforms to the specification. This is my first time to participate in open source project,so I need some more time... Thank you for your comment :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lindzh commented on issue #249: master-slave sync model performance improve
lindzh commented on issue #249: master-slave sync model performance improve URL: https://github.com/apache/rocketmq/issues/249#issuecomment-376751390 Glad to see such improvement for RocketMQ. Could you please create a pull request to contribute your code? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #223: [ROCKETMQ-365] Add consume times stat and fix client log
coveralls commented on issue #223: [ROCKETMQ-365] Add consume times stat and fix client log URL: https://github.com/apache/rocketmq/pull/223#issuecomment-376737476 [](https://coveralls.io/builds/16215683) Coverage decreased (-0.07%) to 41.42% when pulling **78ea43c93dcd51e53b7cd2623a60a36d9beb4ebf on lindzh:fix_invalid_log** into **5db240f39208374117342c5852b3a32061c8e6ef on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [GSOC|ROCKETMQ-122] Support Global Ordered Messaging
Cool, thanks for your efforts. On Wed, Mar 28, 2018 at 9:02 AM, sowmya s wrote: > Hello Yukon, > I've submitted my final proposal addressing your comments as well. Hoping > to work on this project for the summer. In the meantime i'm working on > prototyping the global ordering approach i talked about in my proposal. > > thanks, > Sowmya > > On Fri, Mar 23, 2018 at 4:48 AM, yukon wrote: > > > Hi, > > > > I added some comments, but it seems your google doc link isn't shared: > > > > ``` > > To resolve this issue, we need a global ordered messaging mechanism to > have > > a good scalability without hot-pot issue. > > > > A practical proposal is that sending messages to distributed > > queue/partition with an ordered key. Messages are ordered in the same > > queue, then implement an OrderConsumer to pull messages from these queues > > then perform merge sort, finally deliver these ordered messages to users. > > ``` > > As mentioned in ROCKETMQ-122, we should address the hot-pot issue. > > > > That means the messages can be sent to multiple distributed > > queues/partitions and still can be consumed in order manner. > > > > A simple explanation of hot-pot issue: > > > > Assume that all the generated messages in a hot shop of taobao/amazon > > should be consumed in order, in the current state, these massive messages > > should be sent to a fixed queue/partition, surely to a fixed server which > > may cause high pressure in this server. You can easily infer that we > can't > > resolve this issue through extending the scale of broker cluster. > > > > Could your arch resolve this hot-pot issue? > > > > Regards, > > yukon > > > > > > On Thu, Mar 22, 2018 at 2:15 PM, sowmya s wrote: > > > > > It's going great. > > > In the DefaultMessageStore, there is a class > > > CommitLogDispatcherBuildConsumeQueue, I think that a variant of that > > class > > > or another implementation which are merged from the commitlog, > > > Since the DispachRequest has a store timestamp, the queue can be > > populated > > > based on that time stamp. > > > > > > Also, I have some more questions, > > > Does the fleet of broker slaves all store the various commit logs that > > are > > > received by them or is the commit log store, replication managed by the > > > broker controller? > > > > > > The other direction I was thinking about is adding/modifying the > > > PullAPIWrapper, since the DefaultMQPushConsumerImpl uses the > > > DefaultMQPullConsumerImpl and that uses the PullAPIWrapper, maybe > adding > > > this change there will solve the merge issue for the consumers. > > > > > > Do you think I am on the right track? > > > > > > thanks, > > > Sowmya > > > > > > > > > > > > On Mon, Mar 19, 2018 at 8:15 PM, yukon wrote: > > > > > > > Hi, > > > > > > > > Sorry for the late reply. > > > > > > > > As for: > > > > > > > > ``` > > > > I'm looking at the BrokerController and MessageStore implementation > and > > > > hooks to understand where the merge logic will best fit. > > > > ``` > > > > > > > > how is it going? > > > > > > > > Regards > > > > > > > > On Sat, Mar 17, 2018 at 11:30 AM, sowmya s > > wrote: > > > > > > > > > Thank you yukon, > > > > > > > > > > I'm done with my coursework for this semester and have more time > now > > to > > > > > improve my proposal. > > > > > I'm looking at the BrokerController and MessageStore implementation > > and > > > > > hooks to understand where the merge logic will best fit. So far > I've > > > > looked > > > > > at the codebase from a Producer and Consumer perspective and looked > > at > > > > the > > > > > DefaultMQProducerImpl and DefaultMQPushConsumerImpl for > > understanding > > > > the > > > > > link between how Producers send and Consumers receive messages. > > > > > > > > > > thanks, > > > > > Sowmya > > > > > > > > > > On Fri, Mar 16, 2018 at 8:07 PM, yukon wrote: > > > > > > > > > > > Cool, let's focus on it and see whether is there anything can be > > > > > polished. > > > > > > > > > > > > Regards > > > > > > > > > > > > On Fri, Mar 16, 2018 at 11:54 PM, sowmya s > > > > > wrote: > > > > > > > > > > > > > Hey yukon, > > > > > > > I submitted my draft on the summer of code homepage a couple of > > > days > > > > > ago, > > > > > > > also attaching the link here for reference, > > > > > > > > > > > > > > https://docs.google.com/file/d/1nXktUO_TF9- > > > > rSHSnGj5z5QZoHzMhosxm/edit? > > > > > > > usp=docslist_api&filetype=msword > > > > > > > > > > > > > > Thanks, > > > > > > > Sowmya > > > > > > > > > > > > > > On Thu, Mar 15, 2018 at 2:08 AM yukon > wrote: > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > Of course, we can work together to finetune your design > draft. > > > > > > > > > > > > > > > > Regards, > > > > > > > > yukon > > > > > > > > > > > > > > > > On Thu, Mar 15, 2018 at 5:33 AM, sowmya s < > > sowmya9...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > > > Hello, yukon and Von, > > > > > > > > > > > > > > > > > > I've shared my GSOC - 18
Passed: apache/rocketmq#1077 (develop - 5db240f)
Build Update for apache/rocketmq - Build: #1077 Status: Passed Duration: 21 minutes and 46 seconds Commit: 5db240f (develop) Author: lindzh Message: Add slf4j-api pom for nameserver and broker (#257) View the changeset: https://github.com/apache/rocketmq/compare/06d63076e0f2...5db240f39208 View the full build log and details: https://travis-ci.org/apache/rocketmq/builds/358846468?utm_source=email&utm_medium=notification -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications This email was sent to dev@rocketmq.apache.org (mailto:dev@rocketmq.apache.org) unsubscribe from this list (http://clicks.travis-ci.com/track/unsub.php?u=14313403&id=85599e444a21438e84aaec9f2259e678.C6CyiskYEqUTWt2tKavsnQLKBBE%3D&r=https%3A%2F%2Fmandrillapp.com%2Funsub%3Fmd_email%3Ddev%2540rocketmq.apache.org)
Re: [GSoC][ROCKETMQ-386] Provide an integration plugin with apache hbase
Hi, You can pick up an issue from our JIRA system, the JIRA system is disabled now but there are many existing issues need to be resolved. Regards, yukon On Wed, Mar 28, 2018 at 2:17 AM, Madhushika Jayasinghe < madhushikajayasinghe91...@gmail.com> wrote: > Hi Yukon, > > I would like to fix an issue that is related to this project, to getting > familiar with the project. It would be appreciated if you could point out > any issue related to this. > > Thank you, > > Best Regards, > Madhushika Jayasinghe. > > > > On Tue, Mar 27, 2018 at 3:41 PM Madhushika Jayasinghe < > madhushikajayasinghe91...@gmail.com> wrote: > >> Hi Yukon, >> >> I have uploaded the final proposal in PDF format. I'm looking forward to >> working with you in summer. >> >> Thank you, >> >> Best Regards, >> Madhushika Jayasinghe. >> >> On Tue, Mar 27, 2018 at 7:39 AM yukon wrote: >> >>> Hi, your proposal looks great, we can forward it. >>> >>> On Mon, Mar 26, 2018 at 9:28 PM, Madhushika Jayasinghe < >>> madhushikajayasinghe91...@gmail.com> wrote: >>> Hi Yukon, I hope I could proceed with my original proposal. If there are any concerns please let me know. Regrads, Madhushika On Sat, Mar 24, 2018 at 3:13 PM Madhushika Jayasinghe < madhushikajayasinghe91...@gmail.com> wrote: > Hi Yukon, > I have drafted proposal targeting the project "provide an integration > plug-in with apache HBase". If you got free time please share your > feedback > and views regarding this. > > Proposal: https://docs.google.com/document/d/ > 1NjWaJcJQd1ex0Zc5bJ1NKRiQH4L2Wh7Lx1Un2qI498c/edit?usp=sharing > > Thank you. > > > On Thu, Mar 22, 2018 at 7:38 AM yukon wrote: > >> Please refer to here: >> https://dev.mysql.com/doc/refman/5.7/en/binary-log.html >> >> On Thu, Mar 22, 2018 at 1:55 AM, Madhushika Jayasinghe < >> madhushikajayasinghe91...@gmail.com> wrote: >> >> > Hi, >> > In my proposal I am going to suggest a method quite similar to MySQL >> > plug-in. There is a replicator class which acts as a interface for >> push and >> > pull requests. Internally it will communicate with HBase and store >> required >> > data. >> > In MySQL repo it has heavily mentioned about binlog. What is this >> binlog >> > and how is it related to RocketMQ? >> > Thanks >> > >> > Regards, >> > Madhushika >> > >> > On Wed, Mar 21, 2018 at 8:10 AM yukon wrote: >> > >> > > Hi, >> > > >> > > Sorry to have misled you, I mean the plugin could bring the >> ability of >> > > off-line storage to RocketMQ. >> > > >> > > As for the plugin, should contain sink and source connectors to >> send and >> > > pull data from HBase. >> > > >> > > Regards, >> > > yukon >> > > >> > > On Wed, Mar 21, 2018 at 1:28 AM, Madhushika Jayasinghe < >> > > madhushikajayasinghe91...@gmail.com> wrote: >> > > >> > >> Hi, >> > >> I am Madhushika Jayasinghe, a final year undergraduate from >> Computer >> > >> Science and Engineering Department, University of Moratuwa. As I >> > previously >> > >> mentioned in the JIRA I am working for the above project as GSoC >> > Project. >> > >> Currently I have cloned the RocketMQ Repo and followed some >> > documentation >> > >> to be familiar with RocketMQ. Now I am in the process of >> drafting a >> > >> proposal and got few questions. >> > >> In the JIRA it is mentioned that the "plugin should have the >> capability >> > >> of off-line storage". Here what is meant by off-line storage? >> And how >> > can I >> > >> tackle this case? >> > >> >> > >> >> > >> Thanks >> > >> >> > >> Regards, >> > >> Madhushika >> > >> >> > > >> > > >> > >> > >>>
Re: [GSOC|ROCKETMQ-122] Support Global Ordered Messaging
Hello Yukon, I've submitted my final proposal addressing your comments as well. Hoping to work on this project for the summer. In the meantime i'm working on prototyping the global ordering approach i talked about in my proposal. thanks, Sowmya On Fri, Mar 23, 2018 at 4:48 AM, yukon wrote: > Hi, > > I added some comments, but it seems your google doc link isn't shared: > > ``` > To resolve this issue, we need a global ordered messaging mechanism to have > a good scalability without hot-pot issue. > > A practical proposal is that sending messages to distributed > queue/partition with an ordered key. Messages are ordered in the same > queue, then implement an OrderConsumer to pull messages from these queues > then perform merge sort, finally deliver these ordered messages to users. > ``` > As mentioned in ROCKETMQ-122, we should address the hot-pot issue. > > That means the messages can be sent to multiple distributed > queues/partitions and still can be consumed in order manner. > > A simple explanation of hot-pot issue: > > Assume that all the generated messages in a hot shop of taobao/amazon > should be consumed in order, in the current state, these massive messages > should be sent to a fixed queue/partition, surely to a fixed server which > may cause high pressure in this server. You can easily infer that we can't > resolve this issue through extending the scale of broker cluster. > > Could your arch resolve this hot-pot issue? > > Regards, > yukon > > > On Thu, Mar 22, 2018 at 2:15 PM, sowmya s wrote: > > > It's going great. > > In the DefaultMessageStore, there is a class > > CommitLogDispatcherBuildConsumeQueue, I think that a variant of that > class > > or another implementation which are merged from the commitlog, > > Since the DispachRequest has a store timestamp, the queue can be > populated > > based on that time stamp. > > > > Also, I have some more questions, > > Does the fleet of broker slaves all store the various commit logs that > are > > received by them or is the commit log store, replication managed by the > > broker controller? > > > > The other direction I was thinking about is adding/modifying the > > PullAPIWrapper, since the DefaultMQPushConsumerImpl uses the > > DefaultMQPullConsumerImpl and that uses the PullAPIWrapper, maybe adding > > this change there will solve the merge issue for the consumers. > > > > Do you think I am on the right track? > > > > thanks, > > Sowmya > > > > > > > > On Mon, Mar 19, 2018 at 8:15 PM, yukon wrote: > > > > > Hi, > > > > > > Sorry for the late reply. > > > > > > As for: > > > > > > ``` > > > I'm looking at the BrokerController and MessageStore implementation and > > > hooks to understand where the merge logic will best fit. > > > ``` > > > > > > how is it going? > > > > > > Regards > > > > > > On Sat, Mar 17, 2018 at 11:30 AM, sowmya s > wrote: > > > > > > > Thank you yukon, > > > > > > > > I'm done with my coursework for this semester and have more time now > to > > > > improve my proposal. > > > > I'm looking at the BrokerController and MessageStore implementation > and > > > > hooks to understand where the merge logic will best fit. So far I've > > > looked > > > > at the codebase from a Producer and Consumer perspective and looked > at > > > the > > > > DefaultMQProducerImpl and DefaultMQPushConsumerImpl for > understanding > > > the > > > > link between how Producers send and Consumers receive messages. > > > > > > > > thanks, > > > > Sowmya > > > > > > > > On Fri, Mar 16, 2018 at 8:07 PM, yukon wrote: > > > > > > > > > Cool, let's focus on it and see whether is there anything can be > > > > polished. > > > > > > > > > > Regards > > > > > > > > > > On Fri, Mar 16, 2018 at 11:54 PM, sowmya s > > > wrote: > > > > > > > > > > > Hey yukon, > > > > > > I submitted my draft on the summer of code homepage a couple of > > days > > > > ago, > > > > > > also attaching the link here for reference, > > > > > > > > > > > > https://docs.google.com/file/d/1nXktUO_TF9- > > > rSHSnGj5z5QZoHzMhosxm/edit? > > > > > > usp=docslist_api&filetype=msword > > > > > > > > > > > > Thanks, > > > > > > Sowmya > > > > > > > > > > > > On Thu, Mar 15, 2018 at 2:08 AM yukon wrote: > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > Of course, we can work together to finetune your design draft. > > > > > > > > > > > > > > Regards, > > > > > > > yukon > > > > > > > > > > > > > > On Thu, Mar 15, 2018 at 5:33 AM, sowmya s < > sowmya9...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > > > Hello, yukon and Von, > > > > > > > > > > > > > > > > I've shared my GSOC - 18 draft of the project. I'm looking > > > forward > > > > to > > > > > > > > working with all of you to finetune the proposal. I will be > > > > > allocating > > > > > > 20 > > > > > > > > hours per week from now to the proposal acceptance phase to > > > address > > > > > > > > questions and dive deep into any suggestions that you > provide. > > > > > > > > I am really looking forward to work on t
Re: [GSoC][ROCKETMQ-377] Implement a openwhisk-package-rocketmq to support serverless function
Hi Yukon, I have submitted the final proposal: https://drive.google.com/open?id=1jRWwNK4kw4Wv9gdsEERxW9nlEicon-_H I am looking forward to work with you. Thanks! Mayar On 2018/03/27 02:46:44, yukon wrote: > Hi, > > I looked through your proposal, that's exactly what the issue needed, let's > move forward it. > > Regards, > yukon > > > On Tue, Mar 27, 2018 at 8:48 AM, mayar.abdelaziz1...@gmail.com < > mayar.abdelaziz1...@gmail.com> wrote: > > > Hi Yukon and Von, > > > > I have investigated the issue well and prepared a draft proposal. I am > > keen to work on this project and I am sorry for submitting the draft > > proposal late (it took from me some time to define the project on which I'd > > like to work). > > > > If you can review the proposal and inform me of any changes before the > > final submission date, I will be thankful to you. > > > > Here is a read and edit version of the proposal (developed in LaTeX): > > https://www.overleaf.com/15067483crttdvhcttnj > > > > Here is a read-only version of the proposal: > > https://drive.google.com/open?id=1LoeFaNvse1_k8v0hej_7T6rXzTPJhTzW > > > > I am looking forward to hearing from you.. > > > > Thanks! > > Mayar > > > > On 2018/03/25 08:22:38, mayar.abdelaziz1...@gmail.com < > > mayar.abdelaziz1...@gmail.com> wrote: > > > > > > The objective of providing this package is to add RocketMQ as a new > > source of events, right? > > > > > > If so, Could you please guide me on how to start working on the project? > > > > > > > > > On 2018/03/25 05:22:27, yukon wrote: > > > > Hi, > > > > > > > > ``` > > > > Do you want to replace the message passing system Kafka with RocketMQ > > in > > > > the OpenWhisk implementation? > > > > ``` > > > > > > > > No, we want to provide a third-party package for OpenWhisk platform, > > like > > > > https://github.com/apache/incubator-openwhisk-package-kafka > > > > > > > > On Sun, Mar 25, 2018 at 9:02 AM, mayar.abdelaziz1...@gmail.com < > > > > mayar.abdelaziz1...@gmail.com> wrote: > > > > > > > > > Hi, > > > > > > > > > > I am Mayar Abd Elaziz, final year Computer Engineering student at > > Faculty > > > > > of Engineering, Alexandria university, Egypt. I am interested in > > working on > > > > > that project https://issues.apache.org/jira/browse/ROCKETMQ-377. I > > have > > > > > good knowledge on OpenWhisk because I am working in my graduation > > project > > > > > on it. I would like to get more understanding on the requirements of > > the > > > > > project as it's not so clear to me. Do you want to replace the > > message > > > > > passing system Kafka with RocketMQ in the OpenWhisk implementation? > > > > > > > > > > > > > > >
Re: [GSoC][ROCKETMQ-386] Provide an integration plugin with apache hbase
Hi Yukon, I would like to fix an issue that is related to this project, to getting familiar with the project. It would be appreciated if you could point out any issue related to this. Thank you, Best Regards, Madhushika Jayasinghe. On Tue, Mar 27, 2018 at 3:41 PM Madhushika Jayasinghe < madhushikajayasinghe91...@gmail.com> wrote: > Hi Yukon, > > I have uploaded the final proposal in PDF format. I'm looking forward to > working with you in summer. > > Thank you, > > Best Regards, > Madhushika Jayasinghe. > > On Tue, Mar 27, 2018 at 7:39 AM yukon wrote: > >> Hi, your proposal looks great, we can forward it. >> >> On Mon, Mar 26, 2018 at 9:28 PM, Madhushika Jayasinghe < >> madhushikajayasinghe91...@gmail.com> wrote: >> >>> Hi Yukon, >>> I hope I could proceed with my original proposal. If there are any >>> concerns please let me know. >>> >>> Regrads, >>> Madhushika >>> >>> >>> On Sat, Mar 24, 2018 at 3:13 PM Madhushika Jayasinghe < >>> madhushikajayasinghe91...@gmail.com> wrote: >>> Hi Yukon, I have drafted proposal targeting the project "provide an integration plug-in with apache HBase". If you got free time please share your feedback and views regarding this. Proposal: https://docs.google.com/document/d/1NjWaJcJQd1ex0Zc5bJ1NKRiQH4L2Wh7Lx1Un2qI498c/edit?usp=sharing Thank you. On Thu, Mar 22, 2018 at 7:38 AM yukon wrote: > Please refer to here: > https://dev.mysql.com/doc/refman/5.7/en/binary-log.html > > On Thu, Mar 22, 2018 at 1:55 AM, Madhushika Jayasinghe < > madhushikajayasinghe91...@gmail.com> wrote: > > > Hi, > > In my proposal I am going to suggest a method quite similar to MySQL > > plug-in. There is a replicator class which acts as a interface for > push and > > pull requests. Internally it will communicate with HBase and store > required > > data. > > In MySQL repo it has heavily mentioned about binlog. What is this > binlog > > and how is it related to RocketMQ? > > Thanks > > > > Regards, > > Madhushika > > > > On Wed, Mar 21, 2018 at 8:10 AM yukon wrote: > > > > > Hi, > > > > > > Sorry to have misled you, I mean the plugin could bring the > ability of > > > off-line storage to RocketMQ. > > > > > > As for the plugin, should contain sink and source connectors to > send and > > > pull data from HBase. > > > > > > Regards, > > > yukon > > > > > > On Wed, Mar 21, 2018 at 1:28 AM, Madhushika Jayasinghe < > > > madhushikajayasinghe91...@gmail.com> wrote: > > > > > >> Hi, > > >> I am Madhushika Jayasinghe, a final year undergraduate from > Computer > > >> Science and Engineering Department, University of Moratuwa. As I > > previously > > >> mentioned in the JIRA I am working for the above project as GSoC > > Project. > > >> Currently I have cloned the RocketMQ Repo and followed some > > documentation > > >> to be familiar with RocketMQ. Now I am in the process of drafting > a > > >> proposal and got few questions. > > >> In the JIRA it is mentioned that the "plugin should have the > capability > > >> of off-line storage". Here what is meant by off-line storage? And > how > > can I > > >> tackle this case? > > >> > > >> > > >> Thanks > > >> > > >> Regards, > > >> Madhushika > > >> > > > > > > > > > >>
[GitHub] coveralls commented on issue #255: [ISSUE #254] Add dlq message stat log for security audit
coveralls commented on issue #255: [ISSUE #254] Add dlq message stat log for security audit URL: https://github.com/apache/rocketmq/pull/255#issuecomment-376506165 [](https://coveralls.io/builds/16199492) Coverage increased (+0.02%) to 41.508% when pulling **8caec26a54b36c6db1cc1cbe5396e3bac4be819d on lindzh:add_dlq_stat_log** into **5db240f39208374117342c5852b3a32061c8e6ef on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lindzh closed issue #256: Fix Broker and NameServer startup
lindzh closed issue #256: Fix Broker and NameServer startup URL: https://github.com/apache/rocketmq/issues/256 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhouxinyu closed pull request #257: [ISSUE #256] Fix Broker and NameServer startup
zhouxinyu closed pull request #257: [ISSUE #256] Fix Broker and NameServer startup URL: https://github.com/apache/rocketmq/pull/257 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/broker/pom.xml b/broker/pom.xml index 3da70fa33..e3787c365 100644 --- a/broker/pom.xml +++ b/broker/pom.xml @@ -68,6 +68,10 @@ org.javassist javassist + +org.slf4j +slf4j-api + diff --git a/namesrv/pom.xml b/namesrv/pom.xml index 02ed402bf..959814cc2 100644 --- a/namesrv/pom.xml +++ b/namesrv/pom.xml @@ -48,5 +48,9 @@ ch.qos.logback logback-core + +org.slf4j +slf4j-api + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lindzh opened a new pull request #257: [ISSUE #256] Fix Broker and NameServer startup
lindzh opened a new pull request #257: [ISSUE #256] Fix Broker and NameServer startup URL: https://github.com/apache/rocketmq/pull/257 Please do not create a Pull Request without creating an issue first. ## What is the purpose of the change Fix broker and nameserver startup of develop branch.More information see https://github.com/apache/rocketmq/issues/256 ## Brief changelog Add slf4j dependency to broker and nameserver. ## Verifying this change There is no test case in this case. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [x] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lindzh opened a new issue #256: Fix Broker and NameServer
lindzh opened a new issue #256: Fix Broker and NameServer URL: https://github.com/apache/rocketmq/issues/256 The issue tracker is **ONLY** used for bug report and feature request. Keep in mind, please check whether there is an existing same report before your raise a new one. Alternately (especially if your communication is not a bug report), you can send mail to our [mailing lists](http://rocketmq.apache.org/about/contact/). We welcome any friendly suggestions, bug fixes, collaboration and other improvements. Please ensure that your bug report is clear and that it is complete. Otherwise, we may be unable to understand it or to reproduce it, either of which would prevent us from fixing the bug. We strongly recommend the report(bug report or feature request) could include some hints as the following: **BUG REPORT** 1. Please describe the issue you observed: Broker and NameServer start failed because less of slf4j. - What did you do (The steps to reproduce)? change branch to develop ,and release as follow: ``` mvn -Prelease-all -DskipTests clean install -U ``` install apache rocketmq.and run with `sh mqnamesrv & ` - What did you expect to see? Start success. - What did you see instead? ``` java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory at org.apache.rocketmq.namesrv.NamesrvStartup.main0(NamesrvStartup.java:94) at org.apache.rocketmq.namesrv.NamesrvStartup.main(NamesrvStartup.java:47) Caused by: java.lang.ClassNotFoundException: org.slf4j.LoggerFactory at java.net.URLClassLoader.findClass(URLClassLoader.java:381) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 2 more ``` 2. Please tell us about your environment: Mac pro. jdk8 3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc): This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lindzh opened a new issue #254: Add dlq message stat log for security audit
lindzh opened a new issue #254: Add dlq message stat log for security audit URL: https://github.com/apache/rocketmq/issues/254 The issue tracker is **ONLY** used for bug report and feature request. Keep in mind, please check whether there is an existing same report before your raise a new one. Alternately (especially if your communication is not a bug report), you can send mail to our [mailing lists](http://rocketmq.apache.org/about/contact/). We welcome any friendly suggestions, bug fixes, collaboration and other improvements. Please ensure that your bug report is clear and that it is complete. Otherwise, we may be unable to understand it or to reproduce it, either of which would prevent us from fixing the bug. We strongly recommend the report(bug report or feature request) could include some hints as the following: **FEATURE REQUEST** 1. Please describe the feature you are requesting. Add dlq message stat log for security audit which contains topic,consumerGroup and msgId. 2. Provide any additional detail on your proposed use case for this feature. When consumeMessage failed, we need to confirm the accurate scope of influence which depend on the log rather than printmsg. 2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? should-have 4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task: - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here, - no sub task This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lindzh opened a new pull request #255: [Issues-254] Add dlq message stat log for security audit
lindzh opened a new pull request #255: [Issues-254] Add dlq message stat log for security audit URL: https://github.com/apache/rocketmq/pull/255 Please do not create a Pull Request without creating an issue first. ## What is the purpose of the change When consumeMessage failed, we need to confirm the accurate scope of influence which depend on the log rather than printmsg. So adding dlq message stat log for security audit which contains topic,consumerGroup and msgId is a good choice. ## Brief changelog Add dlq message log in consumeSendBack. ## Verifying this change This is a trivial change. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [x] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
