Broken: apache/rocketmq-externals#220 (master - bbd6cff)

[Travis CI]

Build Update for apache/rocketmq-externals
-

Build: #220
Status: Broken

Duration: 27 secs
Commit: bbd6cff (master)
Author: vongosling
Message: Remove it

View the changeset: 
https://github.com/apache/rocketmq-externals/compare/bb0e305cb8b1...bbd6cff9b8fd

View the full build log and details: 
https://app.travis-ci.com/github/apache/rocketmq-externals/builds/238525255?utm_medium=notification&utm_source=email


--

You can unsubscribe from build emails from the apache/rocketmq-externals 
repository going to 
https://app.travis-ci.com/account/preferences/unsubscribe?repository=16807676&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at 
https://app.travis-ci.com/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.

[DISCUSS]Release Apache rocketmq-client-go 2.1.1

[ShannonDing]

Hello RocketMQ Community,




Apache RocketMQ team is about to release Apache rocketmq-client-go 2.1.1 and we 
will stop merge PR.

 If your PR has not been merged and needs further attention, please reply to 
this email and we will review it as soon as possible.




Best Regards,

Apache RocketMQ Team.

[GitHub] [rocketmq] codecov-commenter commented on pull request #3385: [ISSUE #3384] Add SendBack message to SCHEDULE_TOPIC_XXXX stats

[GitBox]

codecov-commenter commented on pull request #3385:
URL: https://github.com/apache/rocketmq/pull/3385#issuecomment-927508665


   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/3385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#3385](https://codecov.io/gh/apache/rocketmq/pull/3385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (f5229b4) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/daf1b9df79aea5614d740cc46e6d7dd95ce038c4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (daf1b9d) will **increase** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/rocketmq/pull/3385/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/3385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#3385  +/-   ##
   =
   + Coverage  48.22%   48.24%   +0.01% 
   - Complexity  4603 4605   +2 
   =
 Files555  555  
 Lines  3675136756   +5 
 Branches4840 4841   +1 
   =
   + Hits   1772517732   +7 
   + Misses 1679616790   -6 
   - Partials2230 2234   +4 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/3385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ocketmq/broker/processor/SendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/3385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1NlbmRNZXNzYWdlUHJvY2Vzc29yLmphdmE=)
 | `39.69% <0.00%> (-0.52%)` | :arrow_down: |
   | 
[...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/3385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh)
 | `59.13% <0.00%> (-2.16%)` | :arrow_down: |
   | 
[...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/3385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==)
 | `58.11% <0.00%> (-1.71%)` | :arrow_down: |
   | 
[...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=)
 | `29.50% <0.00%> (-0.66%)` | :arrow_down: |
   | 
[...mq/client/impl/producer/DefaultMQProducerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==)
 | `45.23% <0.00%> (-0.37%)` | :arrow_down: |
   | 
[...etmq/client/latency/LatencyFaultToleranceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvbGF0ZW5jeS9MYXRlbmN5RmF1bHRUb2xlcmFuY2VJbXBsLmphdmE=)
 | `50.00% <0.00%> (ø)` | |
   | 
[...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/3385/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtc

[GitHub] [rocketmq] coveralls commented on pull request #3385: [ISSUE #3384] Add SendBack message to SCHEDULE_TOPIC_XXXX stats

[GitBox]

coveralls commented on pull request #3385:
URL: https://github.com/apache/rocketmq/pull/3385#issuecomment-927508569


   
   [![Coverage 
Status](https://coveralls.io/builds/43076955/badge)](https://coveralls.io/builds/43076955)
   
   Coverage increased (+0.02%) to 54.503% when pulling 
**f5229b4e0fc5bfe481e946307db403c2e827a1e1 on Git-Yang:develop_stats_v2** into 
**daf1b9df79aea5614d740cc46e6d7dd95ce038c4 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] speak2me commented on pull request #70: session window implementation

[GitBox]

speak2me commented on pull request #70:
URL: https://github.com/apache/rocketmq-streams/pull/70#issuecomment-927506087


   #74 refer to org.apache.rocketmq.streams.client.WindowTest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] speak2me commented on pull request #71: Commit 20210923

[GitBox]

speak2me commented on pull request #71:
URL: https://github.com/apache/rocketmq-streams/pull/71#issuecomment-927505903


   #74 refer to org.apache.rocketmq.streams.client.WindowTest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-dashboard] StyleTang merged pull request #23: [ISSUE #22]Optimizing the ops page.

[GitBox]

StyleTang merged pull request #23:
URL: https://github.com/apache/rocketmq-dashboard/pull/23


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-dashboard] StyleTang closed issue #22: Optimizing the ops page

[GitBox]

StyleTang closed issue #22:
URL: https://github.com/apache/rocketmq-dashboard/issues/22


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Git-Yang opened a new pull request #3385: [ISSUE #3384] Add SendBack message to SCHEDULE_TOPIC_XXXX stats

[GitBox]

Git-Yang opened a new pull request #3385:
URL: https://github.com/apache/rocketmq/pull/3385


   ## What is the purpose of the change
   
   #3384
   
   ## Brief changelog
   - Add SendBack message to SCHEDULE_TOPIC_ stats
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Git-Yang opened a new issue #3384: [statistics] SCHEDULE_TOPIC_XXXX statistics are missing SendBack messages

[GitBox]

Git-Yang opened a new issue #3384:
URL: https://github.com/apache/rocketmq/issues/3384


   ⁣Associated patch： https://github.com/apache/rocketmq/issues/3296
   
   1. Please describe the issue you observed:
   - SCHEDULE_TOPIC_ statistics are missing SendBack messages
   
   2. Please tell us about your environment:
   rmq version 4.8 , backport #3302.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] loyili opened a new pull request #3383: [ISSUE #3288] Fix producer always timeouts while sending first message

[GitBox]

loyili opened a new pull request #3383:
URL: https://github.com/apache/rocketmq/pull/3383


   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   Fix issue #3288
   
   ## Brief changelog
   
   cache **UtilAll#getPid** result to avoid duplicate calls. 
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-externals] liyubin117 closed issue #816: [rocketmq-flink] convertToRowTypeInfo() should return field name

[GitBox]

liyubin117 closed issue #816:
URL: https://github.com/apache/rocketmq-externals/issues/816


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-flink] liyubin117 opened a new issue #7: convertToRowTypeInfo() should return field name

[GitBox]

liyubin117 opened a new issue #7:
URL: https://github.com/apache/rocketmq-flink/issues/7


   `RocketMQDynamicTableSink#convertToRowTypeInfo()`
   now just return field type information, so we don`t have the neccessary 
information to serialize field name to body, or use real field name instead of 
f0/f1.. relying on the field order to identify the key column
   
   I have enhanced the function in our department, if it`s neccessary, I will 
create a merge request


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] loyili commented on issue #3288: Producer always fails while sending first message.

[GitBox]

loyili commented on issue #3288:
URL: https://github.com/apache/rocketmq/issues/3288#issuecomment-927458735


   Yes, i will submit it later.  @yuz10 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-externals] duhenglucky commented on issue #816: [rocketmq-flink] convertToRowTypeInfo() should return field name

[GitBox]

duhenglucky commented on issue #816:
URL: 
https://github.com/apache/rocketmq-externals/issues/816#issuecomment-927458062


   @liyubin117 rocketmq-flink  has been moved to this 
[repo](https://github.com/apache/rocketmq-flink), welcome to submit an issue 
and PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-externals] liyubin117 commented on issue #816: [rocketmq-flink] convertToRowTypeInfo() should return field name

[GitBox]

liyubin117 commented on issue #816:
URL: 
https://github.com/apache/rocketmq-externals/issues/816#issuecomment-927456793


   I have enhanced the function in our department, if it`s neccessary, I will 
create a merge request


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-externals] liyubin117 opened a new issue #816: [rocketmq-flink] convertToRowTypeInfo() should return field name

[GitBox]

liyubin117 opened a new issue #816:
URL: https://github.com/apache/rocketmq-externals/issues/816


   `RocketMQDynamicTableSink#convertToRowTypeInfo()`
   now just return field type information, so we don`t have the neccessary 
information to serialize field name to body, or use real field name instead of 
f0/f1.. to identify the key column


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] yuz10 commented on issue #3288: Producer always fails while sending first message.

[GitBox]

yuz10 commented on issue #3288:
URL: https://github.com/apache/rocketmq/issues/3288#issuecomment-927452937


   @loyili perfect solution, could you submit a pr to resolve the problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] panzhi33 commented on a change in pull request #3149: [ISSUE #3148]Support metadata export

[GitBox]

panzhi33 commented on a change in pull request #3149:
URL: https://github.com/apache/rocketmq/pull/3149#discussion_r716305997



##
File path: distribution/bin/export.sh
##
@@ -0,0 +1,102 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+checkCmd() {
+  if ! command -v wget > /dev/null 2>&1; then
+echo -e '[ERROR] This system does not contains wget command, please 
install it!'
+exit 1
+  fi
+}
+
+download() {
+  if [[ -e /tmp/rocketmq/ ]]; then
+rm -rf /tmp/rocketmq/
+  fi
+
+  wget --no-check-certificate -P /tmp/rocketmq/ 
https://ons-migration.oss-cn-hangzhou.aliyuncs.com/rocketmq-for-export.tar.gz
+  if [[ $? -ne 0 ]]; then
+echo -e "[ERROR] Download rocketmq error, please make sure this file 
exists"
+exit 1
+  else
+echo -e "[INFO] Download rocketmq completed，file path: 
$(pwd)/rocketmq-for-export.tar.gz"
+  fi
+
+  tar -zxvf /tmp/rocketmq/rocketmq-for-export.tar.gz -C /tmp/rocketmq/ > 
/dev/null 2>&1
+
+  echo -e "[INFO] Unzip rocketmq-for-export.tar.gz completed"
+}

Review comment:
   has been deleted about oss




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-externals] duhenglucky closed issue #815: sink哪里用到的了负载均衡

[GitBox]

duhenglucky closed issue #815:
URL: https://github.com/apache/rocketmq-externals/issues/815


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-dashboard] zhangjidi2016 opened a new pull request #23: [ISSUE #22]Optimizing the ops page.

[GitBox]

zhangjidi2016 opened a new pull request #23:
URL: https://github.com/apache/rocketmq-dashboard/pull/23


   ## What is the purpose of the change
   
   #22
   
   ## Brief changelog
   
   Use md-chips of Angular Material instead of input elements,each namesrv 
address is an md-chip element that is easy to add and remove.
   
   
![image](https://user-images.githubusercontent.com/18254437/134833020-8ec72436-ccca-4407-af9c-212e0f170850.png)
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-dashboard] zhangjidi2016 opened a new issue #22: Optimizing the ops page

[GitBox]

zhangjidi2016 opened a new issue #22:
URL: https://github.com/apache/rocketmq-dashboard/issues/22


   When updating the Namesrv address, the width of the input element is fixed 
and the page display is not user-friendly.
   
   
![image](https://user-images.githubusercontent.com/18254437/134831374-1023fc84-ff50-4e15-9478-8c4114d065bd.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] vongosling closed issue #503: 消息已经消费成功,而且消费了1 次,但是在rocketmq-console中 NOT_CONSUME_YET

[GitBox]

vongosling closed issue #503:
URL: https://github.com/apache/rocketmq/issues/503


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] vongosling removed a comment on pull request #3091: [ISSUE #503] NOT_CONSUME_YET not righht in RocketMQ Console

[GitBox]

vongosling removed a comment on pull request #3091:
URL: https://github.com/apache/rocketmq/pull/3091#issuecomment-927281831


   Ping @StyleTang


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] vongosling merged pull request #3091: [ISSUE #503] NOT_CONSUME_YET not righht in RocketMQ Console

[GitBox]

vongosling merged pull request #3091:
URL: https://github.com/apache/rocketmq/pull/3091


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] vongosling commented on a change in pull request #3149: [ISSUE #3148]Support metadata export

[GitBox]

vongosling commented on a change in pull request #3149:
URL: https://github.com/apache/rocketmq/pull/3149#discussion_r716293535



##
File path: distribution/bin/export.sh
##
@@ -0,0 +1,102 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+checkCmd() {
+  if ! command -v wget > /dev/null 2>&1; then
+echo -e '[ERROR] This system does not contains wget command, please 
install it!'
+exit 1
+  fi
+}
+
+download() {
+  if [[ -e /tmp/rocketmq/ ]]; then
+rm -rf /tmp/rocketmq/
+  fi
+
+  wget --no-check-certificate -P /tmp/rocketmq/ 
https://ons-migration.oss-cn-hangzhou.aliyuncs.com/rocketmq-for-export.tar.gz
+  if [[ $? -ne 0 ]]; then
+echo -e "[ERROR] Download rocketmq error, please make sure this file 
exists"
+exit 1
+  else
+echo -e "[INFO] Download rocketmq completed，file path: 
$(pwd)/rocketmq-for-export.tar.gz"
+  fi
+
+  tar -zxvf /tmp/rocketmq/rocketmq-for-export.tar.gz -C /tmp/rocketmq/ > 
/dev/null 2>&1
+
+  echo -e "[INFO] Unzip rocketmq-for-export.tar.gz completed"
+}

Review comment:
   Any update for here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] vongosling merged pull request #3278: [ISSUE #2667] Repair 'file doesn't exist on this path'

[GitBox]

vongosling merged pull request #3278:
URL: https://github.com/apache/rocketmq/pull/3278


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-client-cpp] bersler opened a new pull request #368: fixed incorrect delete operator

[GitBox]

bersler opened a new pull request #368:
URL: https://github.com/apache/rocketmq-client-cpp/pull/368


   ## What is the purpose of the change
   
   Fix error - incorrect memory free - (operator new [] vs operator delete)
   
   
   ## Brief changelog
   
   When version variable is allocated using new [] operator the memory release 
should be done using delete[] operator.
   
   ## Verifying this change
   
   Line 228 of CProducer.cpp is:
 defaultMQProducer->version = new char[MAX_SDK_VERSION_LENGTH];
   
   Memory release is in line 276:
   delete defaultMQProducer->version;
   
   Should be:
   delete[] defaultMQProducer->version;
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when a cross-module dependency exists.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #3149: [ISSUE #3148]Support metadata export

[GitBox]

coveralls edited a comment on pull request #3149:
URL: https://github.com/apache/rocketmq/pull/3149#issuecomment-880750487


   
   [![Coverage 
Status](https://coveralls.io/builds/43072536/badge)](https://coveralls.io/builds/43072536)
   
   Coverage increased (+0.3%) to 54.484% when pulling 
**75271df6250932072df1b32c1238b228723461d4 on panzhi33:develop** into 
**ec985ee67354a55607c3b5fde2e110dfb1268fea on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Git-Yang commented on issue #2667: DLeger模式下broker.log 一直抛出 Error when measuring disk space usage, file doesn't exist on this path: /root/store/commitlog

[GitBox]

Git-Yang commented on issue #2667:
URL: https://github.com/apache/rocketmq/issues/2667#issuecomment-927317515


   > > > @maixiaohai 就是按照 官方文档 步骤来的:
   > > > https://rocketmq.apache.org/docs/quick-start/
   > > > 启动 broker 前 需要 手工创建 2个目录 才能 不 一直 报错:
   > > > ```
   > > > mkdir -p ~/store/commitlog/
   > > > mkdir -p ~/store/consumequeue/
   > > > ```
   > > > 
   > > > 
   > > > 
   > > >   
   > > > 
   > > > 
   > > >   
   > > > 
   > > > 
   > > > 
   > > >   
   > > > 如果 实际步骤 和 文档 不符, 请 更新 文档 说明.
   > > 
   > > 
   > > 我本地测试了一下，这个报错不影响使用，程序默认会创建目录；
   > > 另外，官方文档里直接启动的不是 DLedger 的部署模式
   > 
   > Java version: java 8
   > OS: mac
   > 没有默认创建目录，然后一直报错，确实需要手动创建两个目录才会停止报错
   
   Fixed this issue in PR#3278


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] dingshuangxi888 commented on a change in pull request #3149: [ISSUE #3148]Support metadata export

[GitBox]

dingshuangxi888 commented on a change in pull request #3149:
URL: https://github.com/apache/rocketmq/pull/3149#discussion_r716214481



##
File path: 
tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java
##
@@ -955,12 +973,49 @@ public SubscriptionGroupWrapper 
getAllSubscriptionGroup(final String brokerAddr,
 }
 
 @Override
-public TopicConfigSerializeWrapper getAllTopicGroup(final String 
brokerAddr,
+public SubscriptionGroupWrapper getUserSubscriptionGroup(final String 
brokerAddr,
+long timeoutMillis) throws InterruptedException,
+RemotingTimeoutException, RemotingSendRequestException, 
RemotingConnectException, MQBrokerException {
+SubscriptionGroupWrapper subscriptionGroupWrapper = 
this.mqClientInstance.getMQClientAPIImpl()
+.getAllSubscriptionGroup(brokerAddr, timeoutMillis);
+
+Iterator> iterator = 
subscriptionGroupWrapper.getSubscriptionGroupTable()
+.entrySet().iterator();
+while (iterator.hasNext()) {
+Map.Entry configEntry = 
iterator.next();
+if (MixAll.isSysConsumerGroup(configEntry.getKey()) || 
SYSTEM_GROUP_SET.contains(configEntry.getKey())) {
+iterator.remove();
+}
+}
+
+return subscriptionGroupWrapper;
+}
+
+@Override
+public TopicConfigSerializeWrapper getAllTopicConfig(final String 
brokerAddr,
 long timeoutMillis) throws InterruptedException,
 RemotingTimeoutException, RemotingSendRequestException, 
RemotingConnectException, MQBrokerException {
 return 
this.mqClientInstance.getMQClientAPIImpl().getAllTopicConfig(brokerAddr, 
timeoutMillis);
 }
 
+@Override
+public TopicConfigSerializeWrapper getUserTopicConfig(final String 
brokerAddr, final boolean specialTopic,
+long timeoutMillis) throws InterruptedException, RemotingException,
+MQBrokerException, MQClientException {
+TopicConfigSerializeWrapper topicConfigSerializeWrapper = 
this.getAllTopicConfig(brokerAddr, timeoutMillis);
+TopicList topicList = 
this.mqClientInstance.getMQClientAPIImpl().getSystemTopicListFromBroker(brokerAddr,
+timeoutMillis);
+Iterator> iterator = 
topicConfigSerializeWrapper.getTopicConfigTable().entrySet()
+.iterator();
+while (iterator.hasNext()) {
+String topic = iterator.next().getKey();
+if (topicList.getTopicList().contains(topic) || !specialTopic && 
(topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) || 
topic.startsWith(MixAll.DLQ_GROUP_TOPIC_PREFIX))) {

Review comment:
   嗯嗯，逻辑清晰一点，未来加个条件也不会出bug




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] maixiaohai closed issue #2436: DLQ topic default perm change to read & write

[GitBox]

maixiaohai closed issue #2436:
URL: https://github.com/apache/rocketmq/issues/2436


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] panzhi33 commented on a change in pull request #3149: [ISSUE #3148]Support metadata export

[GitBox]

panzhi33 commented on a change in pull request #3149:
URL: https://github.com/apache/rocketmq/pull/3149#discussion_r716211821



##
File path: 
tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java
##
@@ -955,12 +973,49 @@ public SubscriptionGroupWrapper 
getAllSubscriptionGroup(final String brokerAddr,
 }
 
 @Override
-public TopicConfigSerializeWrapper getAllTopicGroup(final String 
brokerAddr,
+public SubscriptionGroupWrapper getUserSubscriptionGroup(final String 
brokerAddr,
+long timeoutMillis) throws InterruptedException,
+RemotingTimeoutException, RemotingSendRequestException, 
RemotingConnectException, MQBrokerException {
+SubscriptionGroupWrapper subscriptionGroupWrapper = 
this.mqClientInstance.getMQClientAPIImpl()
+.getAllSubscriptionGroup(brokerAddr, timeoutMillis);
+
+Iterator> iterator = 
subscriptionGroupWrapper.getSubscriptionGroupTable()
+.entrySet().iterator();
+while (iterator.hasNext()) {
+Map.Entry configEntry = 
iterator.next();
+if (MixAll.isSysConsumerGroup(configEntry.getKey()) || 
SYSTEM_GROUP_SET.contains(configEntry.getKey())) {
+iterator.remove();
+}
+}
+
+return subscriptionGroupWrapper;
+}
+
+@Override
+public TopicConfigSerializeWrapper getAllTopicConfig(final String 
brokerAddr,
 long timeoutMillis) throws InterruptedException,
 RemotingTimeoutException, RemotingSendRequestException, 
RemotingConnectException, MQBrokerException {
 return 
this.mqClientInstance.getMQClientAPIImpl().getAllTopicConfig(brokerAddr, 
timeoutMillis);
 }
 
+@Override
+public TopicConfigSerializeWrapper getUserTopicConfig(final String 
brokerAddr, final boolean specialTopic,
+long timeoutMillis) throws InterruptedException, RemotingException,
+MQBrokerException, MQClientException {
+TopicConfigSerializeWrapper topicConfigSerializeWrapper = 
this.getAllTopicConfig(brokerAddr, timeoutMillis);
+TopicList topicList = 
this.mqClientInstance.getMQClientAPIImpl().getSystemTopicListFromBroker(brokerAddr,
+timeoutMillis);
+Iterator> iterator = 
topicConfigSerializeWrapper.getTopicConfigTable().entrySet()
+.iterator();
+while (iterator.hasNext()) {
+String topic = iterator.next().getKey();
+if (topicList.getTopicList().contains(topic) || !specialTopic && 
(topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) || 
topic.startsWith(MixAll.DLQ_GROUP_TOPIC_PREFIX))) {

Review comment:
   这里加不加括号，逻辑都是一样的，但是为了方便理解，我还是加上去了




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] gaochengyidlmu commented on issue #2667: DLeger模式下broker.log 一直抛出 Error when measuring disk space usage, file doesn't exist on this path: /root/store/commitlog

[GitBox]

gaochengyidlmu commented on issue #2667:
URL: https://github.com/apache/rocketmq/issues/2667#issuecomment-927310633


   > > @maixiaohai 就是按照 官方文档 步骤来的:
   > > https://rocketmq.apache.org/docs/quick-start/
   > > 启动 broker 前 需要 手工创建 2个目录 才能 不 一直 报错:
   > > ```
   > > mkdir -p ~/store/commitlog/
   > > mkdir -p ~/store/consumequeue/
   > > ```
   > > 
   > > 
   > > 
   > >   
   > > 
   > > 
   > >   
   > > 
   > > 
   > > 
   > >   
   > > 如果 实际步骤 和 文档 不符, 请 更新 文档 说明.
   > 
   > 我本地测试了一下，这个报错不影响使用，程序默认会创建目录；
   > 另外，官方文档里直接启动的不是 DLedger 的部署模式
   
   Java version: java 8
   OS: mac 
   没有默认创建目录，然后一直报错，确实需要手动创建两个目录才会停止报错


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] dingshuangxi888 commented on a change in pull request #3149: [ISSUE #3148]Support metadata export

[GitBox]

dingshuangxi888 commented on a change in pull request #3149:
URL: https://github.com/apache/rocketmq/pull/3149#discussion_r716204820



##
File path: 
tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java
##
@@ -955,12 +973,49 @@ public SubscriptionGroupWrapper 
getAllSubscriptionGroup(final String brokerAddr,
 }
 
 @Override
-public TopicConfigSerializeWrapper getAllTopicGroup(final String 
brokerAddr,
+public SubscriptionGroupWrapper getUserSubscriptionGroup(final String 
brokerAddr,
+long timeoutMillis) throws InterruptedException,
+RemotingTimeoutException, RemotingSendRequestException, 
RemotingConnectException, MQBrokerException {
+SubscriptionGroupWrapper subscriptionGroupWrapper = 
this.mqClientInstance.getMQClientAPIImpl()
+.getAllSubscriptionGroup(brokerAddr, timeoutMillis);
+
+Iterator> iterator = 
subscriptionGroupWrapper.getSubscriptionGroupTable()
+.entrySet().iterator();
+while (iterator.hasNext()) {
+Map.Entry configEntry = 
iterator.next();
+if (MixAll.isSysConsumerGroup(configEntry.getKey()) || 
SYSTEM_GROUP_SET.contains(configEntry.getKey())) {
+iterator.remove();
+}
+}
+
+return subscriptionGroupWrapper;
+}
+
+@Override
+public TopicConfigSerializeWrapper getAllTopicConfig(final String 
brokerAddr,
 long timeoutMillis) throws InterruptedException,
 RemotingTimeoutException, RemotingSendRequestException, 
RemotingConnectException, MQBrokerException {
 return 
this.mqClientInstance.getMQClientAPIImpl().getAllTopicConfig(brokerAddr, 
timeoutMillis);
 }
 
+@Override
+public TopicConfigSerializeWrapper getUserTopicConfig(final String 
brokerAddr, final boolean specialTopic,
+long timeoutMillis) throws InterruptedException, RemotingException,
+MQBrokerException, MQClientException {
+TopicConfigSerializeWrapper topicConfigSerializeWrapper = 
this.getAllTopicConfig(brokerAddr, timeoutMillis);
+TopicList topicList = 
this.mqClientInstance.getMQClientAPIImpl().getSystemTopicListFromBroker(brokerAddr,
+timeoutMillis);
+Iterator> iterator = 
topicConfigSerializeWrapper.getTopicConfigTable().entrySet()
+.iterator();
+while (iterator.hasNext()) {
+String topic = iterator.next().getKey();
+if (topicList.getTopicList().contains(topic) || !specialTopic && 
(topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) || 
topic.startsWith(MixAll.DLQ_GROUP_TOPIC_PREFIX))) {

Review comment:
   !specialTopic && (topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) || 
topic.startsWith(MixAll.DLQ_GROUP_TOPIC_PREFIX))
   
   这段逻辑应该再加个括号




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] dingshuangxi888 commented on a change in pull request #3149: [ISSUE #3148]Support metadata export

[GitBox]

dingshuangxi888 commented on a change in pull request #3149:
URL: https://github.com/apache/rocketmq/pull/3149#discussion_r716204820



##
File path: 
tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java
##
@@ -955,12 +973,49 @@ public SubscriptionGroupWrapper 
getAllSubscriptionGroup(final String brokerAddr,
 }
 
 @Override
-public TopicConfigSerializeWrapper getAllTopicGroup(final String 
brokerAddr,
+public SubscriptionGroupWrapper getUserSubscriptionGroup(final String 
brokerAddr,
+long timeoutMillis) throws InterruptedException,
+RemotingTimeoutException, RemotingSendRequestException, 
RemotingConnectException, MQBrokerException {
+SubscriptionGroupWrapper subscriptionGroupWrapper = 
this.mqClientInstance.getMQClientAPIImpl()
+.getAllSubscriptionGroup(brokerAddr, timeoutMillis);
+
+Iterator> iterator = 
subscriptionGroupWrapper.getSubscriptionGroupTable()
+.entrySet().iterator();
+while (iterator.hasNext()) {
+Map.Entry configEntry = 
iterator.next();
+if (MixAll.isSysConsumerGroup(configEntry.getKey()) || 
SYSTEM_GROUP_SET.contains(configEntry.getKey())) {
+iterator.remove();
+}
+}
+
+return subscriptionGroupWrapper;
+}
+
+@Override
+public TopicConfigSerializeWrapper getAllTopicConfig(final String 
brokerAddr,
 long timeoutMillis) throws InterruptedException,
 RemotingTimeoutException, RemotingSendRequestException, 
RemotingConnectException, MQBrokerException {
 return 
this.mqClientInstance.getMQClientAPIImpl().getAllTopicConfig(brokerAddr, 
timeoutMillis);
 }
 
+@Override
+public TopicConfigSerializeWrapper getUserTopicConfig(final String 
brokerAddr, final boolean specialTopic,
+long timeoutMillis) throws InterruptedException, RemotingException,
+MQBrokerException, MQClientException {
+TopicConfigSerializeWrapper topicConfigSerializeWrapper = 
this.getAllTopicConfig(brokerAddr, timeoutMillis);
+TopicList topicList = 
this.mqClientInstance.getMQClientAPIImpl().getSystemTopicListFromBroker(brokerAddr,
+timeoutMillis);
+Iterator> iterator = 
topicConfigSerializeWrapper.getTopicConfigTable().entrySet()
+.iterator();
+while (iterator.hasNext()) {
+String topic = iterator.next().getKey();
+if (topicList.getTopicList().contains(topic) || !specialTopic && 
(topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) || 
topic.startsWith(MixAll.DLQ_GROUP_TOPIC_PREFIX))) {

Review comment:
   !specialTopic && (topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) || 
topic.startsWith(MixAll.DLQ_GROUP_TOPIC_PREFIX))
   
   这段逻辑是不是应该再加个括号




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [DISCUSS] Support KV semantic storage

[yukon]

kv can be an effective complement to the message model, the rocketmq with
kv support will provide more lightweight features for our users.

As for the implementation, we actually need more discussion and research to
help us reach a consensus. It would be nice if any community contributor
wants to do some research between the compact topic and the kv way.

On Fri, Sep 24, 2021 at 9:01 PM heng du  wrote:

> Glad to see everyone’s discussion，Er, the compact topic is also a way to
> implement the KV semantic storage, but If the compact index is introduced,
> In fact, different from messaging products, it cannot be used as a log
> cleaner，and will only be used to reduce the cost of message replay, and if
> we want to make the compact topic to be a way to clean up messages like
> other messaging products, the changes to the storage layer will also be
> very large.
>
> dongeforever  于2021年9月24日周五 下午8:41写道：
>
> > keep calm.
> > Every RocketMQ contributor has the responsibility to maintain and develop
> > the architecture.
> > Integrating RocksDB has its pros and cons, so does the compaction(not
> > compression) topic.
> > It's better to continue the discussion if each could show the details
> > without emotion.
> > It is also ok to start a meeting about this proposal.
> >
> > In my opinion, KV feature is important for RocketMQ, the question is in
> > what a way.
> >
> > vongosling  于2021年9月24日周五 下午3:58写道：
> >
> > > I just wonder if we could not open a new kV module, we really could not
> > > solve the question you're mentioned? we could introduce a compression
> > topic
> > > for the last effective replay. Do we know how hard it is to maintain a
> > > RocksDB, which my Facebook friends have talked to me a lot about,
> > > their various kV production around RocksDB?
> > >
> > > Since we open-source RocketMQ, I've tried to help keep the architecture
> > as
> > > simple as possible, and I've warned you to learn to subtract while
> adding
> > > things. While the code scale is still under control, I think the first
> > > thing to really do is to design a good pluggable system that replaces
> the
> > > existing simple SPI and API approach, but unfortunately, I haven't seen
> > any
> > > progress in that regard so far.
> > >
> > > Therefore, I think we should carefully examine our technical solutions.
> > We
> > > should not let the technical solutions just only for streams :-)
> > >
> > > heng du  于2021年9月24日周五 下午12:43写道：
> > >
> > > > Totally agree with this proposal. The KV semantic storage can not
> only
> > > > provide better support for streaming and connect, especially the
> > storage
> > > of
> > > > checkpoints but also can be used to better manage metadata in the
> > future.
> > > > At the same time, compared to the compact topic, this proposal can
> > > > significantly reduce user replay costs and save failure recovery
> time,
> > > and
> > > > KV semantic storage can actually be regarded as another index similar
> > to
> > > > CQ, which can be loaded on demand. In addition, there seems to be an
> > > > unvoted RIP-22 proposal, but please don’t care :)
> > > >
> > > >
> > > > vongosling  于2021年9月23日周四 下午8:35写道：
> > > >
> > > > > Thanks for your clarify. I have been confused by RIP 22, It seems
> we
> > > have
> > > > > occupied 22, right[1]?
> > > > >
> > > > >
> > > > > [1] https://github.com/apache/rocketmq/issues/2937
> > > > >
> > > > > Amber Liu  于2021年9月23日周四 下午3:29写道：
> > > > >
> > > > > > Sorry about the format problem, below is the correct one.
> > > > > > RIP-22 Support KV semantic storageStatus
> > > > > >
> > > > > >- Current Status: Draft
> > > > > >- Authors: ltamber 
> > > > > >
> > > > > >
> > > > > >- Shepherds: duhengforever 
> > > > > >- Mailing List discussion: dev@rocketmq.apache.org
> > > > > >
> > > > > >
> > > > > >- Pull Request: #PR_NUMBER
> > > > > >- Released: 
> > > > > >
> > > > > > Background & Motivationwhat do we need to do
> > > > > >
> > > > > >- will we add a new module? *no*.
> > > > > >- will we add new APIs? *yes*.
> > > > > >
> > > > > >
> > > > > >- will we add new feature? *yes*.
> > > > > >
> > > > > > Why should we do that
> > > > > >
> > > > > >- Are there any problems of our current project?
> > > > > >  Currently, we can't get/put key-value from/into rocketmq, so
> > if
> > > we
> > > > > use
> > > > > >connector ,
> like
> > > > > >FileSource, BinlogSource, we can't persist current read
> > > > position/dump
> > > > > >position to rocketmq rather than an external meta store like
> > > > > >zookeeper/mysql, this will bring more operator risk by
> introduce
> > > > > another
> > > > > >component. this issue was also in streaming
> > > > > > scenarios when
> > > > developer
> > > > > >want to persist meta info like checkpoint.
> > > > > >- What can we benefit proposed changes

[GitHub] [rocketmq] iamqq23ue commented on pull request #2707: [ISSUE #2706] Fix the problem of returning SEND_OK after flush failed

[GitBox]

iamqq23ue commented on pull request #2707:
URL: https://github.com/apache/rocketmq/pull/2707#issuecomment-927297099


   The new pull request is #3382。The code is basically unchanged, slightly 
adjusted according to the new version 。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] iamqq23ue commented on issue #3349: issue #2706 is still exists in version 4.9.1

[GitBox]

iamqq23ue commented on issue #3349:
URL: https://github.com/apache/rocketmq/issues/3349#issuecomment-927296936


   > @RongtongJin @zongtanghu
   
   The new pull request is #3382。The code is basically unchanged, slightly 
adjusted according to the new version 。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] iamqq23ue opened a new pull request #3382: ISSUE#2706 FIX

[GitBox]

iamqq23ue opened a new pull request #3382:
URL: https://github.com/apache/rocketmq/pull/3382


   ISSUE #2706 
   
   The original pull request was #2707。 
   
   You can see from the code below. When flush fails, only an error is 
reported, but the client is not notified 。
   If there is an error, a try catch will be performed .Then log.error("Error 
occurred when force data to disk.", e);
   But there is no error code returned to the client, and the client still 
thinks that the send is successful.
   
   public int flush(final int flushLeastPages) {
   if (this.isAbleToFlush(flushLeastPages)) {
 if (this.hold()) {
 int value = getReadPosition();
   try {
   //We only append data to fileChannel or mappedByteBuffer, 
never both.
   if (writeBuffer != null || this.fileChannel.position() != 0) 
{
   this.fileChannel.force(false);
   } else {
   this.mappedByteBuffer.force();
   }
   } **catch (Throwable e) {
   log.error("Error occurred when force data to disk.", e);
   }**
   
   this.flushedPosition.set(value);
   this.release();
   } else {
   log.warn("in flush, hold failed, flush offset = " + 
this.flushedPosition.get());
   this.flushedPosition.set(getReadPosition());
   }
   }
   return this.getFlushedPosition();
   }
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] speak2me commented on pull request #70: session window implementation

[GitBox]

speak2me commented on pull request #70:
URL: https://github.com/apache/rocketmq-streams/pull/70#issuecomment-927295746


   #73 same with another pr #71 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-exporter] maixiaohai closed issue #69: failed to convert java.lang.String to long

[GitBox]

maixiaohai closed issue #69:
URL: https://github.com/apache/rocketmq-exporter/issues/69


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-exporter] maixiaohai merged pull request #71: add default value of outOfTimeSeconds

[GitBox]

maixiaohai merged pull request #71:
URL: https://github.com/apache/rocketmq-exporter/pull/71


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] vongosling closed issue #3375: [Optimize] lazy init GetMessageResult only when find message.

[GitBox]

vongosling closed issue #3375:
URL: https://github.com/apache/rocketmq/issues/3375


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] vongosling merged pull request #3374: [ISSUE #3375] Lazy init GetMessageResult only when find message.

[GitBox]

vongosling merged pull request #3374:
URL: https://github.com/apache/rocketmq/pull/3374


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] vongosling commented on pull request #3091: [ISSUE #503] NOT_CONSUME_YET not righht in RocketMQ Console

[GitBox]

vongosling commented on pull request #3091:
URL: https://github.com/apache/rocketmq/pull/3091#issuecomment-927281831


   Ping @StyleTang


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] vongosling commented on issue #3369: Fetch Cluster information json data when parse in golang occure:invalid character '0' looking for beginning of object key string

[GitBox]

vongosling commented on issue #3369:
URL: https://github.com/apache/rocketmq/issues/3369#issuecomment-927281323


   I re-opened this issue for optimization preparation. Any guys are welcome to 
contribute it:-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Cczzzz opened a new issue #3381: BUG , when role change but not register again

[GitBox]

Cc opened a new issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381


   I run rocket with 
   
   #版本号的方式注册
   forceRegister=false
   #预先设定好的leader
   preferredLeaderId=n0
   
   if i kill the master and leader， n0 will become again leader.
   
   n0's brokerId = 1,not 0.
Because role change  will not  register again 
   
   

   
![image](https://user-images.githubusercontent.com/32947555/134804262-4de63d00-8d30-41cf-88a2-a5cdee596bb2.png)
   
   
   
   BrokerOuterAPI # 281 ，only compare topicConfigWrapper.getDataVersion.
   
 switch (response.getCode()) {
   case ResponseCode.SUCCESS: {
   QueryDataVersionResponseHeader 
queryDataVersionResponseHeader =
   (QueryDataVersionResponseHeader) 
response.decodeCommandCustomHeader(QueryDataVersionResponseHeader.class);
   changed = 
queryDataVersionResponseHeader.getChanged();
   byte[] body = response.getBody();
   if (body != null) {
   nameServerDataVersion = 
DataVersion.decode(body, DataVersion.class);
   if 
(!topicConfigWrapper.getDataVersion().equals(nameServerDataVersion)) {
   changed = true;
   }
   }
   if (changed == null || changed) {
   changedList.add(Boolean.TRUE);
   }
   }
   default:
   break;
   }
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-exporter] ZhaoUncle commented on issue #69: failed to convert java.lang.String to long

[GitBox]

ZhaoUncle commented on issue #69:
URL: 
https://github.com/apache/rocketmq-exporter/issues/69#issuecomment-927276219


   #71  it fix this problem,I check. @maixiaohai 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] ShannonDing commented on issue #3349: issue #2706 is still exists in version 4.9.1

[GitBox]

ShannonDing commented on issue #3349:
URL: https://github.com/apache/rocketmq/issues/3349#issuecomment-927272327


   @RongtongJin @zongtanghu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] ShannonDing commented on issue #503: 消息已经消费成功,而且消费了1 次,但是在rocketmq-console中 NOT_CONSUME_YET

[GitBox]

ShannonDing commented on issue #503:
URL: https://github.com/apache/rocketmq/issues/503#issuecomment-927271653


   link #518, #406


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] ShannonDing commented on pull request #3091: [ISSUE #503] NOT_CONSUME_YET not righht in RocketMQ Console

[GitBox]

ShannonDing commented on pull request #3091:
URL: https://github.com/apache/rocketmq/pull/3091#issuecomment-927271563


   link #518, #406


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] BiggerBrain edited a comment on issue #3377: can we use single thread to doAppend msg to DefaultMappedFile？

[GitBox]

BiggerBrain edited a comment on issue #3377:
URL: https://github.com/apache/rocketmq/issues/3377#issuecomment-927270225


   I mean multi-threaded submission of writing tasks, the operation of writing 
the commit log is written by one background  thread


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] BiggerBrain commented on issue #3377: can we use single thread to doAppend msg to DefaultMappedFile？

[GitBox]

BiggerBrain commented on issue #3377:
URL: https://github.com/apache/rocketmq/issues/3377#issuecomment-927270225


   I mean multi-threaded submission of writing tasks, the operation of writing 
the commit log is written by one thread


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] BiggerBrain removed a comment on issue #3377: can we use single thread to doAppend msg to DefaultMappedFile？

[GitBox]

BiggerBrain removed a comment on issue #3377:
URL: https://github.com/apache/rocketmq/issues/3377#issuecomment-927265090


   thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] ShannonDing commented on pull request #3091: [ISSUE #503] NOT_CONSUME_YET not righht in RocketMQ Console

[GitBox]

ShannonDing commented on pull request #3091:
URL: https://github.com/apache/rocketmq/pull/3091#issuecomment-927269132


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] ShannonDing commented on pull request #3380: [ISSUE #3379] Fix formatting errors

[GitBox]

ShannonDing commented on pull request #3380:
URL: https://github.com/apache/rocketmq/pull/3380#issuecomment-927265491


   any other changes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] BiggerBrain commented on issue #3377: can we use single thread to doAppend msg to DefaultMappedFile？

[GitBox]

BiggerBrain commented on issue #3377:
URL: https://github.com/apache/rocketmq/issues/3377#issuecomment-927265090


   thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] ShannonDing commented on issue #3377: can we use single thread to doAppend msg to DefaultMappedFile？

[GitBox]

ShannonDing commented on issue #3377:
URL: https://github.com/apache/rocketmq/issues/3377#issuecomment-927264986


   yes, if you want, single thread works because of lock.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] RongtongJin closed issue #3379: [Format] Fix formatting errors

[GitBox]

RongtongJin closed issue #3379:
URL: https://github.com/apache/rocketmq/issues/3379


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on issue #3377: can we use single thread to doAppend msg to DefaultMappedFile？

[GitBox]

RongtongJin commented on issue #3377:
URL: https://github.com/apache/rocketmq/issues/3377#issuecomment-927264511


   Although there are multiple threads doAppend msg to DefaultMappedFile, but 
because of putMessageLock, there is only one thread writing at the same time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] RongtongJin closed issue #3377: can we use single thread to doAppend msg to DefaultMappedFile？

[GitBox]

RongtongJin closed issue #3377:
URL: https://github.com/apache/rocketmq/issues/3377


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #3374: [ISSUE #3375] Lazy init GetMessageResult only when find message.

[GitBox]

RongtongJin commented on pull request #3374:
URL: https://github.com/apache/rocketmq/pull/3374#issuecomment-927264047


   LGTM~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] liuxuzxx commented on issue #3369: Fetch Cluster information json data when parse in golang occure:invalid character '0' looking for beginning of object key string

[GitBox]

liuxuzxx commented on issue #3369:
URL: https://github.com/apache/rocketmq/issues/3369#issuecomment-927259713


   > 感谢@liuxuzxx 
对这个问题的“不一不孬“，非常棒~这个问题目前只能Go兼容下这个非标的字符了，请Go客户端几位maintainer也看下该问题，后续如何改进优化？ 
@ShannonDing @wenfengwang
   
   还有获取consumeStats信息的时候，也是JSON不规范的问题，示例JSON如下:
   ```json
   
{"consumeTps":0.0,"offsetTable":{{"brokerName":"broker_37_master","queueId":1,"topic":"MT_MQ_L4"}:{"brokerOffset":2,"consumerOffset":0,"lastTimestamp":0},{"brokerName":"broker_37_master","queueId":0,"topic":"MT_MQ_L4"}:{"brokerOffset":5,"consumerOffset":0,"lastTimestamp":0},{"brokerName":"broker_37_master","queueId":3,"topic":"MT_MQ_L4"}:{"brokerOffset":2,"consumerOffset":0,"lastTimestamp":0},{"brokerName":"broker_37_master","queueId":2,"topic":"MT_MQ_L4"}:{"brokerOffset":2,"consumerOffset":0,"lastTimestamp":0}}}
   ```
   这次和上一个问题的key没有携带双引号还有很大区别，这个是直接一个对象的JSON串当做一个key了


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Fixed: apache/rocketmq#5361 (develop - 6d78d79)

[Travis CI]

Build Update for apache/rocketmq
-

Build: #5361
Status: Fixed

Duration: 27 mins and 5 secs
Commit: 6d78d79 (develop)
Author: yuz10
Message: fix apache rat failure because of test result files

View the changeset: 
https://github.com/apache/rocketmq/compare/a83cdc5fa3e2...6d78d7954c2e

View the full build log and details: 
https://app.travis-ci.com/github/apache/rocketmq/builds/238495538?utm_medium=notification&utm_source=email


--

You can unsubscribe from build emails from the apache/rocketmq repository going 
to 
https://app.travis-ci.com/account/preferences/unsubscribe?repository=16807623&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at 
https://app.travis-ci.com/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.

Still Failing: apache/rocketmq#5360 (develop - a83cdc5)

[Travis CI]

Build Update for apache/rocketmq
-

Build: #5360
Status: Still Failing

Duration: 17 mins and 47 secs
Commit: a83cdc5 (develop)
Author: Git_Yang
Message: [format] Fix formatting errors (#3380)

Signed-off-by: zhangyang 

View the changeset: 
https://github.com/apache/rocketmq/compare/4dbdbf0a2581...a83cdc5fa3e2

View the full build log and details: 
https://app.travis-ci.com/github/apache/rocketmq/builds/238495521?utm_medium=notification&utm_source=email


--

You can unsubscribe from build emails from the apache/rocketmq repository going 
to 
https://app.travis-ci.com/account/preferences/unsubscribe?repository=16807623&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at 
https://app.travis-ci.com/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.

[GitHub] [rocketmq] talen0702 removed a comment on issue #3370: Exception print in sendDefaultImpl function in DefaultMQProducerImpl.

[GitBox]

talen0702 removed a comment on issue #3370:
URL: https://github.com/apache/rocketmq/issues/3370#issuecomment-927249916


The same question exists in the class DefaultMQProducerImpl at line 
914~931,version 4.9.2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] yuz10 merged pull request #3380: [ISSUE #3379] Fix formatting errors

[GitBox]

yuz10 merged pull request #3380:
URL: https://github.com/apache/rocketmq/pull/3380


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-spring] zhangjidi2016 opened a new pull request #397: [ISSUE #396]support namespace

[GitBox]

zhangjidi2016 opened a new pull request #397:
URL: https://github.com/apache/rocketmq-spring/pull/397


   ## What is the purpose of the change
   
   #396
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. 
   - [] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] talen0702 commented on issue #3370: Exception print in sendDefaultImpl function in DefaultMQProducerImpl.

[GitBox]

talen0702 commented on issue #3370:
URL: https://github.com/apache/rocketmq/issues/3370#issuecomment-927249916


The same question exists in the class DefaultMQProducerImpl at line 
914~931,version 4.9.2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org