[GitHub] [rocketmq] RongtongJin opened a new issue #3798: [RIP-31] Support RocketMQ BrokerContainer

2022-01-26 Thread GitBox


RongtongJin opened a new issue #3798:
URL: https://github.com/apache/rocketmq/issues/3798


   The issue tracker is **ONLY** used for bug report(feature request need to 
follow [RIP 
process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal)).
 Keep in mind, please check whether there is an existing same report before 
your raise a new one.
   
   Alternately (especially if your communication is not a bug report), you can 
send mail to our [mailing lists](http://rocketmq.apache.org/about/contact/). We 
welcome any friendly suggestions, bug fixes, collaboration and other 
improvements.
   
   Please ensure that your bug report is clear and that it is complete. 
Otherwise, we may be unable to understand it or to reproduce it, either of 
which would prevent us from fixing the bug. We strongly recommend the 
report(bug report or feature request) could include some hints as the following:
   
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   
   Currently, a RocketMQ process has only one broker. However, the slave costs 
fewer resources than the master. So I want to provide a new BrokerContainer 
mode, in which multiple brokers can be added or removed to a BrokerContainer 
process and reuse some resources such as the transport layer. And it can 
improve the utilization of a single node. So I would like to start an RIP to 
support RocketMQ BrokerContainer.
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   Refer to 
[wiki](https://github.com/apache/rocketmq/wiki/RIP-31-Support-RocketMQ-BrokerContainer)
   
   2. Indicate the importance of this issue to you (blocker, must-have, 
should-have, nice-to-have). Are you currently using any workarounds to address 
this issue?
   
   nice-to-have
   
   4. If there are some sub-tasks using -[] for each subtask and create a 
corresponding issue to map to the sub task:
   
   - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 
description here, 
   - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 
description here,
   - ...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: [DISCUSS][RIP-33] RocketMQ MQTT

2022-01-26 Thread dongeforever
+1

yukon  于2022年1月26日周三 15:38写道:

> Great!!!
>
> A big step of the RocketMQ community toward the IoT ecosystem.
>
> On Wed, Jan 26, 2022 at 2:22 PM heng du  wrote:
>
> > long-awaited feature
> >
> > Ping Jack  于2022年1月26日周三 14:15写道:
> >
> > > Hi, RocketMQ Community:
> > >
> > > I want to start a RIP to support MQTT protocol architecture model so
> that
> > > RocketMQ can better support messages from terminals such as IoT devices
> > and
> > > mobile APP. Based on the RocketMQ message unified storage engine, it
> > > supports both MQTT terminal and server message sending and receiving.
> > >
> > > I have written my proposal and you can click on the link below:
> > >
> > >
> > >
> >
> https://docs.google.com/document/d/1AD1GkV9mqE_YFA97uVem4SmB8ZJSXiJZvzt7-K6Jons/edit#heading=h.i42fwfxz62gw
> > >
> > >
> > >
> > > If you have any questions or suggestions, please reply to this email or
> > > comment on the proposal.
> > >
> > >
> > >
> > >
> > > Thanks
> > > Ping Wang
> > > …
> > >
> >
>


Re: [DISSCUSS][RIP-32] Slave Acting Master Mode

2022-01-26 Thread dongeforever
+1.
The second-level message, such as scheduled/transactional message, should
not be bound to the master.

heng du  于2022年1月26日周三 12:54写道:

> Great improvement, whether in terms of usability or complexity of the
> operation, it is a very big improvement to the master-slave architecture.
>
> Thank,
> Henry
>
> jinrongtong  于2022年1月26日周三 11:51写道:
>
> > Hi, RocketMQ Community:
> >
> > I want to start a RIP to support a slave acting master mode which
> enhances
> > the slave capability after the master goes offline. This mode can solve
> the
> > consumption interruption of order messages, delay messages, transaction
> > messages after the master goes offline, as well as the metadata rollback
> > after the master goes online again.
> >
> > I have written my proposal and you can click on the link below:
> >
> >
> >
> https://docs.google.com/document/d/1LCTkfem6wcV-PqWjzPAvaxgqFMCj3ymPakDrcodX9ic/edit?usp=sharing
> >
> > Chinese version:
> >
> > https://shimo.im/docs/6CqVccXgtWgXCYwv/
> >
> >
> >
> > If you have any questions or suggestions, please reply to this email or
> > comment on the proposal.
> >
> >
> >
> >
> > Thanks
> > RongtongJin
>


Re: [DISSCUSS][RIP-32] Slave Acting Master Mode

2022-01-26 Thread yukon
+1
Enhance the ability of RocketMQ native HA service.

On Wed, Jan 26, 2022 at 4:20 PM dongeforever 
wrote:

> +1.
> The second-level message, such as scheduled/transactional message, should
> not be bound to the master.
>
> heng du  于2022年1月26日周三 12:54写道:
>
> > Great improvement, whether in terms of usability or complexity of the
> > operation, it is a very big improvement to the master-slave architecture.
> >
> > Thank,
> > Henry
> >
> > jinrongtong  于2022年1月26日周三 11:51写道:
> >
> > > Hi, RocketMQ Community:
> > >
> > > I want to start a RIP to support a slave acting master mode which
> > enhances
> > > the slave capability after the master goes offline. This mode can solve
> > the
> > > consumption interruption of order messages, delay messages, transaction
> > > messages after the master goes offline, as well as the metadata
> rollback
> > > after the master goes online again.
> > >
> > > I have written my proposal and you can click on the link below:
> > >
> > >
> > >
> >
> https://docs.google.com/document/d/1LCTkfem6wcV-PqWjzPAvaxgqFMCj3ymPakDrcodX9ic/edit?usp=sharing
> > >
> > > Chinese version:
> > >
> > > https://shimo.im/docs/6CqVccXgtWgXCYwv/
> > >
> > >
> > >
> > > If you have any questions or suggestions, please reply to this email or
> > > comment on the proposal.
> > >
> > >
> > >
> > >
> > > Thanks
> > > RongtongJin
> >
>


[RESULT][VOTE][RIP-30] Support Compaction topic

2022-01-26 Thread Amber Liu
Hello RocketMQ Community,


This is the vote result for the kickoff of RIP-30 Support Compaction topic,
and it has been passed with [4] binding +1s, [3] non-binding:

*Binding votes +1s:*

heng du 
dongeforever 
Rongtong Jin >
ShannonDing 


*Non-binding votes +1s:*

bozhou 
Ze Ni 
git_yang 


This RIP will be accepted and its status will be updated to RocketMQ wiki
soon.

Thanks.


Re: [DISCUSS][RIP-33] RocketMQ MQTT

2022-01-26 Thread vongosling
LGTM, +1

Go ahead ~~~

Ping Jack  于2022年1月26日周三 14:15写道:

> Hi, RocketMQ Community:
>
> I want to start a RIP to support MQTT protocol architecture model so that
> RocketMQ can better support messages from terminals such as IoT devices and
> mobile APP. Based on the RocketMQ message unified storage engine, it
> supports both MQTT terminal and server message sending and receiving.
>
> I have written my proposal and you can click on the link below:
>
>
> https://docs.google.com/document/d/1AD1GkV9mqE_YFA97uVem4SmB8ZJSXiJZvzt7-K6Jons/edit#heading=h.i42fwfxz62gw
>
>
>
> If you have any questions or suggestions, please reply to this email or
> comment on the proposal.
>
>
>
>
> Thanks
> Ping Wang
> …
>


-- 
Best Regards :-)


[GitHub] [rocketmq] ltamber opened a new issue #3799: [RIP-30] Support Compaction topic

2022-01-26 Thread GitBox


ltamber opened a new issue #3799:
URL: https://github.com/apache/rocketmq/issues/3799


   The issue tracker is **ONLY** used for bug report(feature request need to 
follow [RIP 
process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal)).
 Keep in mind, please check whether there is an existing same report before 
your raise a new one.
   
   Alternately (especially if your communication is not a bug report), you can 
send mail to our [mailing lists](http://rocketmq.apache.org/about/contact/). We 
welcome any friendly suggestions, bug fixes, collaboration and other 
improvements.
   
   Please ensure that your bug report is clear and that it is complete. 
Otherwise, we may be unable to understand it or to reproduce it, either of 
which would prevent us from fixing the bug. We strongly recommend the 
report(bug report or feature request) could include some hints as the following:
   
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   
   Currently RocketMQ does not support the compaction topic, which results in 
that if the application(such as connector/streams) uses messages to store state 
and only needs the latest state data at a certain time , it needs to pull all 
the messages from the broker, this process will consume a lot of time; At the 
same time, a lot of data is not required by the client. Therefore, we need a 
special data cleaning mechanism, which is to compress the same type of data 
(same key), and only keep the latest data, In this way, only a small amount of 
data is loaded when the application starts.
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   refer to 
[dev-maillist](https://lists.apache.org/thread/c85oj18whdjnxc331n1fxqhb8z50bpnm)
   
   3. Indicate the importance of this issue to you (blocker, must-have, 
should-have, nice-to-have). Are you currently using any workarounds to address 
this issue?
   
   4. If there are some sub-tasks using -[] for each subtask and create a 
corresponding issue to map to the sub task:
   
   - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 
description here, 
   - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 
description here,
   - ...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] Kvicii commented on issue #3714: [Feature] More Precise Range Definition about minOffsetInQueue and maxOffsetInQueue.

2022-01-26 Thread GitBox


Kvicii commented on issue #3714:
URL: https://github.com/apache/rocketmq/issues/3714#issuecomment-1022170655


   @Erik1288 @duhenglucky Has this feature been voted on?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] coveralls edited a comment on pull request #3718: [ISSUE #3717][RIP-27] Auto batching in producer

2022-01-26 Thread GitBox


coveralls edited a comment on pull request #3718:
URL: https://github.com/apache/rocketmq/pull/3718#issuecomment-1008516873


   
   [![Coverage 
Status](https://coveralls.io/builds/45976121/badge)](https://coveralls.io/builds/45976121)
   
   Coverage increased (+0.2%) to 51.313% when pulling 
**a72c5c68eeb43d6a968025cd3b3eb3039b5846dc on 
guyinyou:develop_feature_client_autoBatch** into 
**8ce2cdb004a6b968ad51a985fa262b84fa97d041 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] 18205097282 opened a new issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


18205097282 opened a new issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800


   
   
![image](https://user-images.githubusercontent.com/53631755/151275650-21934f23-44ba-494f-9de7-854d13f497b5.png)
   请问本页面的Broker 5min trend的数值是如何计算的,我研究了一个星期了,无论带入怎么样的数值都算不出来这个结果,非常疑惑。
   恳请大佬解答。
   有大佬 @duhengforever 回答是
   broker's message count (broker total message count/5 min trend)
   请问什么是broker's message count
   什么是broker total message count
   或者是别的什么计算公式?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] dragon-zhang edited a comment on issue #2937: [RIP-22] RocketMQ Logic Ordered Message

2022-01-26 Thread GitBox


dragon-zhang edited a comment on issue #2937:
URL: https://github.com/apache/rocketmq/issues/2937#issuecomment-1010973029


   > @dragon-zhang 
看下最新的[RIP-26](https://github.com/apache/rocketmq/wiki/RIP-26-Improve-Batch-Message-Processing-Throughput)
 是不是也能满足这个issue 的诉求
   
   
[RIP-26](https://github.com/apache/rocketmq/wiki/RIP-26-Improve-Batch-Message-Processing-Throughput)和[RIP-27](https://github.com/apache/rocketmq/wiki/RIP-27-Auto-batching-in-producer)都做完,再补充个`异步发送顺序化`:
   1.异步发送同步化(走异步发送,但是用单线程异步发,发送失败就重试);
   2.完全异步,但是聚批发送前,做排序操作,这样也能保证顺序;
   希望这`2`个点能为`RIP27`提供新的思路。
   
另外我仔细想过一点,就算做了RIP22的queue细分,消费的时候,由于java的`线程模型`,还是在固定的`几十个`线程里消费(除非引入`协程`,如`loom`、`AJDK`),因此除了`异步发送顺序化`,`RIP-22`的其他逻辑意义不大。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] XiaoyiPeng opened a new issue #3801: The document 'CLITools.md' may be better.

2022-01-26 Thread GitBox


XiaoyiPeng opened a new issue #3801:
URL: https://github.com/apache/rocketmq/issues/3801


   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   This document is a little flawed,for example:
   
   
![image](https://user-images.githubusercontent.com/8653312/151277813-99f70b39-01be-4746-961f-8e5725297599.png)
   - What did you see instead?
   
   
![image](https://user-images.githubusercontent.com/8653312/151277905-94e91925-9735-446d-a5b9-b230801b1a76.png)
   
   
   2. Please tell us about your environment:
   
   OS:  Windows10
   branch: develop


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] XiaoyiPeng opened a new pull request #3802: [ISSUE #3801] Polish the document 'CLITools.md'.

2022-01-26 Thread GitBox


XiaoyiPeng opened a new pull request #3802:
URL: https://github.com/apache/rocketmq/pull/3802


   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   For issue #3801 
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] coveralls commented on pull request #3802: [ISSUE #3801] Polish the document 'CLITools.md'.

2022-01-26 Thread GitBox


coveralls commented on pull request #3802:
URL: https://github.com/apache/rocketmq/pull/3802#issuecomment-1022783726


   
   [![Coverage 
Status](https://coveralls.io/builds/45987299/badge)](https://coveralls.io/builds/45987299)
   
   Coverage increased (+0.03%) to 51.174% when pulling 
**9150f9069a80f585b43700a53183c7982b0f5385 on XiaoyiPeng:polish_docs_cli_tool** 
into **8ce2cdb004a6b968ad51a985fa262b84fa97d041 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] codecov-commenter commented on pull request #3802: [ISSUE #3801] Polish the document 'CLITools.md'.

2022-01-26 Thread GitBox


codecov-commenter commented on pull request #3802:
URL: https://github.com/apache/rocketmq/pull/3802#issuecomment-1022783886


   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/3802?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#3802](https://codecov.io/gh/apache/rocketmq/pull/3802?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (9150f90) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/8ce2cdb004a6b968ad51a985fa262b84fa97d041?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (8ce2cdb) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/rocketmq/pull/3802/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/3802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#3802  +/-   ##
   =
   + Coverage  47.07%   47.09%   +0.01% 
   - Complexity  4867 4870   +3 
   =
 Files636  636  
 Lines  4245342453  
 Branches5549 5549  
   =
   + Hits   1998619993   +7 
   + Misses 1996319951  -12 
   - Partials2504 2509   +5 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/3802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/3802/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=)
 | `43.28% <0.00%> (-8.96%)` | :arrow_down: |
   | 
[...ketmq/common/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/3802/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9Db25zdW1lckNvbm5lY3Rpb24uamF2YQ==)
 | `95.83% <0.00%> (-4.17%)` | :arrow_down: |
   | 
[...rocketmq/common/message/MessageClientIDSetter.java](https://codecov.io/gh/apache/rocketmq/pull/3802/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbWVzc2FnZS9NZXNzYWdlQ2xpZW50SURTZXR0ZXIuamF2YQ==)
 | `71.42% <0.00%> (-2.39%)` | :arrow_down: |
   | 
[...rg/apache/rocketmq/remoting/netty/NettyLogger.java](https://codecov.io/gh/apache/rocketmq/pull/3802/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5TG9nZ2VyLmphdmE=)
 | `14.96% <0.00%> (-1.37%)` | :arrow_down: |
   | 
[...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/3802/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==)
 | `59.63% <0.00%> (-0.92%)` | :arrow_down: |
   | 
[...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3802/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=)
 | `28.66% <0.00%> (-0.66%)` | :arrow_down: |
   | 
[...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/3802/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2Fw

[GitHub] [rocketmq] dongeforever commented on issue #3714: [Feature] More Precise Range Definition about minOffsetInQueue and maxOffsetInQueue.

2022-01-26 Thread GitBox


dongeforever commented on issue #3714:
URL: https://github.com/apache/rocketmq/issues/3714#issuecomment-1022788165


   @Erik1288 You could raise a discuss in the dev mailing list.
   
   BTW,  this is not a feature, more like a  bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] dongeforever commented on issue #3634: [RIP-26] Improve Batch Message Processing Throughput

2022-01-26 Thread GitBox


dongeforever commented on issue #3634:
URL: https://github.com/apache/rocketmq/issues/3634#issuecomment-1022792299


   The broker side is backward compatible, but the client side is not backward 
compatible currently.
   Not only batch, other features such as Pop, has a similar problem too.
   Currently, the client uses the broker version to control the SQL filter 
feature. 
   We may need to extend this mechanism to solve this problem.
   @Erik1288 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] guyinyou commented on pull request #3718: [ISSUE #3717][RIP-27] Auto batching in producer

2022-01-26 Thread GitBox


guyinyou commented on pull request #3718:
URL: https://github.com/apache/rocketmq/pull/3718#issuecomment-1022793052


   @yuz10 There is no lamda expression in jdk1.6. For compatibility with it, 
replace computeIfAbsent with putIfAbsent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] guyinyou commented on pull request #3718: [ISSUE #3717][RIP-27] Auto batching in producer

2022-01-26 Thread GitBox


guyinyou commented on pull request #3718:
URL: https://github.com/apache/rocketmq/pull/3718#issuecomment-1022793591


   > Whether there will be a performance improvement report in the future when 
using this feature
   
   I plan to do some benchmarks after Chinese New Year, now here I wish you a 
happy new year.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] caigy commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


caigy commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022808023


   It is calculate by the metric `getTotalTps`, which shows the tps of 
_getMessage_ call.
   
   1. When `org.apache.rocketmq.store.DefaultMessageStore#getMessage` is 
called, `getMessageTimesTotalFound` or `getMessageTimesTotalMiss` is 
incremented. 
   2. `org.apache.rocketmq.store.StoreStatsService#sampling` is executed every 
second, and tag the current `getMessageTimesTotalFound`  or  
`getMessageTimesTotalMiss` with current timestamp, and put them in 
`getTimesFoundList` or `getTimesMissList` separately. 
   3. So each list contains a time series record of the number of _getMessage_ 
operation, and each the timestamp between two consecutive item is about 1 
second. The interval is NOT precise, because the generation of record is 
triggered by scheduled service in step 2. 
   4. If you get the last X items in the list, sum the number of call times and 
divide the result by X, you can get the `getTotalTps` in the last X seconds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] 18205097282 commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


18205097282 commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022812232


   不好意思  再麻烦您一下
   您说把最后X个数值相加处以X 就得到最后X时间内的getTotalTps。
   
   
   
   我的这段曲线是新建的broker。仅仅只在10:40处消费了2个message,其他时间均没有消费也没有生产消息。 为何之后它会一直有大于0的值呢?
   
   
   
   
   
   
   -- 原始邮件 --
   发件人: 
   "apache/rocketmq"

***@***.***>;
   发送时间: 2022年1月27日(星期四) 中午11:16
   ***@***.***>;
   ***@***.**@***.***>;
   主题: Re: [apache/rocketmq] console dashboard 页面疑问 (Issue #3800)
   
   
   
   
   

   It is calculate by the metric getTotalTps, which shows the tps of getMessage 
call.
 
   When org.apache.rocketmq.store.DefaultMessageStore#getMessage is called, 
getMessageTimesTotalFound or getMessageTimesTotalMiss is incremented.

   org.apache.rocketmq.store.StoreStatsService#sampling is executed every 
second, and tag the current getMessageTimesTotalFound  or  
getMessageTimesTotalMiss with current timestamp, and put them in 
getTimesFoundList or getTimesMissList separately.

   So each list contains a time series record of the number of getMessage 
operation, and each the timestamp between two consecutive item is about 1 
second. The interval is NOT precise, because the generation of record is 
triggered by scheduled service in step 2.

   If you get the last X items in the list, sum the number of call times and 
divide the result by X, you can get the getTotalTps in the last X seconds.
 
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android. 
   You are receiving this because you authored the thread.Message ID: 
***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] dongeforever commented on issue #3747: Reduce election time

2022-01-26 Thread GitBox


dongeforever commented on issue #3747:
URL: https://github.com/apache/rocketmq/issues/3747#issuecomment-1022815171


   If the new leader has a smaller offset of the queue, it causes an "out of 
range" problem, which will make the client reset the consumed offsets to the 
earliest  or the latest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] ni-ze commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


ni-ze commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022816444


   This chart is show average tps of broker. But it does has some problem. 
   
   The result is calculated following formula
   
   ```
   brokerTps = [(10s avg tps of broker) + (1min avg tps of broker) + (10min avg 
tps of broker)]/3
   ```
   
   but obviously, it is not incorrect for 5min trend.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] 18205097282 commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


18205097282 commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022817822


   @ni-ze 
   
![image](https://user-images.githubusercontent.com/53631755/151287747-3c12dd17-941d-4a1a-a036-7df763726574.png)
   您好,我这段曲线仅仅只在10:40处消费了2个message,其他时间均没有消费也没有生产消息。 
   为何之后它会一直有大于0的值呢?
   按照您的
   brokerTps = [(10s avg tps of broker) + (1min avg tps of broker) + (10min avg 
tps of broker)]/3
   公式,10分钟后,它的值应该回归到0呀
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] ni-ze commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


ni-ze commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022822449


   
   
   
   
   > @ni-ze 
![image](https://user-images.githubusercontent.com/53631755/151287747-3c12dd17-941d-4a1a-a036-7df763726574.png)
 您好,我这段曲线仅仅只在10:40处消费了2个message,其他时间均没有消费也没有生产消息。 为何之后它会一直有大于0的值呢? 按照您的 
brokerTps = [(10s avg tps of broker) + (1min avg tps of broker) + (10min avg 
tps of broker)]/3 公式,10分钟后,它的值应该回归到0呀
   
   
这个不必在意,客户端没有消息发送,broker自身也有很小的tps,因为这个tps是统计store层的,不是统计client接口请求的。有定时任务检查事务半消息topic
 RMQ_SYS_TRANS_HALF_TOPIC是否有消息,会查询store这里会产生tps


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] ni-ze edited a comment on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


ni-ze edited a comment on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022822449


   
   
   
   > @ni-ze 
![image](https://user-images.githubusercontent.com/53631755/151287747-3c12dd17-941d-4a1a-a036-7df763726574.png)
 您好,我这段曲线仅仅只在10:40处消费了2个message,其他时间均没有消费也没有生产消息。 为何之后它会一直有大于0的值呢? 按照您的 
brokerTps = [(10s avg tps of broker) + (1min avg tps of broker) + (10min avg 
tps of broker)]/3 公式,10分钟后,它的值应该回归到0呀
   
   
这个不必在意,客户端没有拉取消息,broker自身也有很小的tps,因为这个tps是统计store层的,不是统计client接口请求的。有定时任务检查事务半消息topic
 RMQ_SYS_TRANS_HALF_TOPIC是否有消息,会查询store这里会产生tps


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] ni-ze edited a comment on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


ni-ze edited a comment on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022822449


   
   
   > @ni-ze 
![image](https://user-images.githubusercontent.com/53631755/151287747-3c12dd17-941d-4a1a-a036-7df763726574.png)
 您好,我这段曲线仅仅只在10:40处消费了2个message,其他时间均没有消费也没有生产消息。 为何之后它会一直有大于0的值呢? 按照您的 
brokerTps = [(10s avg tps of broker) + (1min avg tps of broker) + (10min avg 
tps of broker)]/3 公式,10分钟后,它的值应该回归到0呀
   
   
这个不必在意,客户端没有消费消息,(这个图不统计生产消息tps),broker自身也有很小的tps,因为这个tps是统计store层的,不是统计client接口请求的。有定时任务检查事务半消息topic
 RMQ_SYS_TRANS_HALF_TOPIC是否有消息,会查询store这里会产生tps


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] ni-ze edited a comment on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


ni-ze edited a comment on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022816444


   This chart is show average tps of broker. But it does has some problem. 
   
   The result is calculated following formula
   
   ```
   brokerTps = [(10s avg tps of broker) + (1min avg tps of broker) + (10min avg 
tps of broker)]/3
   ```
   
   but obviously, it is not correct for 5min trend.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] 18205097282 commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


18205097282 commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022878555


   @ni-ze 
   大佬您好,请问您说的客户端没有消费消息,broker自身也有很小的tps。
   这个broker本身很小的tps会随着topic的增多而增多吗?我们的系统中有500个topic,每日消费消息数大约是6万个,但broker 5min 
trend值一直在400左右,请问这正常吗?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] Kvicii commented on pull request #3793: [ISSUE #3785] MQClientAPIImpl improvement

2022-01-26 Thread GitBox


Kvicii commented on pull request #3793:
URL: https://github.com/apache/rocketmq/pull/3793#issuecomment-1022881094


   Can anyone help me review the code?
   thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] caigy commented on issue #3797: DefaultMQProducerImpl code improvement

2022-01-26 Thread GitBox


caigy commented on issue #3797:
URL: https://github.com/apache/rocketmq/issues/3797#issuecomment-1022888981


   @Kvicii Looking forward to more detailed description of this improvement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] duhenglucky merged pull request #3802: [ISSUE #3801] Polish the document 'CLITools.md'.

2022-01-26 Thread GitBox


duhenglucky merged pull request #3802:
URL: https://github.com/apache/rocketmq/pull/3802


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] duhenglucky closed issue #3801: The document 'CLITools.md' may be better.

2022-01-26 Thread GitBox


duhenglucky closed issue #3801:
URL: https://github.com/apache/rocketmq/issues/3801


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] 18205097282 commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


18205097282 commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022890840


   @ni-ze 
   大佬,我好想理解了算法公式了,最后一个问题,什么是MissTPS 和FoundTPS呀


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] Kvicii commented on issue #3797: DefaultMQProducerImpl code improvement

2022-01-26 Thread GitBox


Kvicii commented on issue #3797:
URL: https://github.com/apache/rocketmq/issues/3797#issuecomment-1022892174


   @caigy As I said before, I think these invalid calls should be removed. For 
some verbose methods, we should do refactoring to ensure code readability.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] 18205097282 opened a new issue #3803: 关于Message和TPS有Miss和Found的区分,请问什么是Miss什么是Found呀

2022-01-26 Thread GitBox


18205097282 opened a new issue #3803:
URL: https://github.com/apache/rocketmq/issues/3803


   存在以下参数名
   getMessageTimesTotalFound 和 getMessageTimesTotalMiss
   getMissTPS  和  getFoundTPS
   请问以上的Miss和Found是什么意思呢


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] Kvicii commented on issue #3797: DefaultMQProducerImpl code improvement

2022-01-26 Thread GitBox


Kvicii commented on issue #3797:
URL: https://github.com/apache/rocketmq/issues/3797#issuecomment-1022893279


   @caigy I'm thinking about this right now, if you can tell me when this kind 
of code can be removed, I'll ignore the question


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] 18205097282 closed issue #3803: 关于Message和TPS有Miss和Found的区分,请问什么是Miss什么是Found呀

2022-01-26 Thread GitBox


18205097282 closed issue #3803:
URL: https://github.com/apache/rocketmq/issues/3803


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] caigy commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


caigy commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022897078


   > @ni-ze 大佬您好,请问您说的客户端没有消费消息,broker自身也有很小的tps。 
这个broker本身很小的tps会随着topic的增多而增多吗?我们的系统中有500个topic,每日消费消息数大约是6万个,但broker 5min 
trend值一直在400左右,请问这正常吗?
   
   @18205097282 
这个指标是基于`org.apache.rocketmq.store.DefaultMessageStore#getMessage`的调用次数计算的,如果这个指标一直在400,反映出来的情况是一直持续在消费消息,这个是否与你们系统的情况相符?此外,由于一条消息可能被多个消费组消费,“每日消费消息数大约是6万个”是指消费被消费的总次数,还是待消费的消息条数?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] caigy commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


caigy commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022898997


   > @ni-ze 大佬,我好想理解了算法公式了,最后一个问题,什么是MissTPS 和FoundTPS呀
   
   
简单理解是从MessageStore查到消息是Found,否则是Miss,具体判断逻辑可以看看`org.apache.rocketmq.store.DefaultMessageStore#getMessage`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] 18205097282 commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


18205097282 commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022900641


@caigy @ni-ze  
“每日消费消息数大约是6万个”指代消息被消费总数,反应在参数中是todayConsumeCount和yesterdayConsumeCount。
   我就很疑惑 指标是400  俺400*60*24 每天应该是差不多60W条消息被消费,  但实际情况只有6万


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] 18205097282 edited a comment on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


18205097282 edited a comment on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022900641


@caigy @ni-ze  
“每日消费消息数大约是6万个”指代消息被消费总数,反应在参数中是todayConsumeCount和yesterdayConsumeCount。
   我就很疑惑 指标是400  俺400\*60\*24 每天应该是差不多60W条消息被消费,  但实际情况只有6万


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] 18205097282 edited a comment on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


18205097282 edited a comment on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022900641


@caigy @ni-ze  
“每日消费消息数大约是6万个”指代消息被消费总数,反应在参数中是todayConsumeCount和yesterdayConsumeCount。
   我就很疑惑 指标是400  按400\*60\*24 每天应该是差不多60W条消息被消费,  但实际情况只有6万


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] duhenglucky merged pull request #3795: [ISSUE #3789] optimize: Tag the name of consuming thread whith consumeGroup.

2022-01-26 Thread GitBox


duhenglucky merged pull request #3795:
URL: https://github.com/apache/rocketmq/pull/3795


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] duhenglucky closed issue #3789: It is better to tag the name of consuming thread with the consumeGroup info.

2022-01-26 Thread GitBox


duhenglucky closed issue #3789:
URL: https://github.com/apache/rocketmq/issues/3789


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] ni-ze commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


ni-ze commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022904442


   从存储中查询消息,如果能找到就算在FoundTPS中,找不到就算在MissTPS中。
   
   > @ni-ze 大佬您好,请问您说的客户端没有消费消息,broker自身也有很小的tps。 
这个broker本身很小的tps会随着topic的增多而增多吗?我们的系统中有500个topic,每日消费消息数大约是6万个,但broker 5min 
trend值一直在400左右,请问这正常吗?
   
   
broker自身带的tps几乎没有影响,只有0.0几。正常不正常不是很好估算,每日消息数6万,可能被不同groupId消费了很多次,还可能6万消息在很短时间内消费的tps就很高。图上的broker
 5min trend本身也不是很准确。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] caigy commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


caigy commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022905302


   > @caigy @ni-ze 
“每日消费消息数大约是6万个”指代消息被消费总数,反应在参数中是todayConsumeCount和yesterdayConsumeCount。 我就很疑惑 
指标是400 按400*60*24 每天应该是差不多60W条消息被消费, 但实际情况只有6万
   @18205097282 可以看下stats.log中'Stats In One Minute'的记录,这里有按分钟统计的指标可供印证。
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] caigy edited a comment on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


caigy edited a comment on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022905302


   > @caigy @ni-ze 
“每日消费消息数大约是6万个”指代消息被消费总数,反应在参数中是todayConsumeCount和yesterdayConsumeCount。 我就很疑惑 
指标是400 按400*60*24 每天应该是差不多60W条消息被消费, 但实际情况只有6万
   
   @18205097282 可以看下stats.log中'Stats In One Minute'的记录,这里有按分钟统计的指标可供印证。
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq-exporter] caorong opened a new issue #91: cached metric cause bug.

2022-01-26 Thread GitBox


caorong opened a new issue #91:
URL: https://github.com/apache/rocketmq-exporter/issues/91


   **Describe the bug**
   A clear and concise description of what the bug is.
   
   in latest version, topicOffset, topicRetryOffset, topicDLQOffset are wrapped 
with guava cache with expire
   
   but this 3 metric contains lastUpdateTimestamp in tags
   
   so in grafana,it is overlap in the cache expire time,which will cause 
ConsumerFallingBehind rule bug,  rule mistake。
   
   
![Xnip2022-01-27_15-12-04](https://user-images.githubusercontent.com/3087340/151309565-1785e718-141a-47c3-95ad-99d6a7f1914d.jpg)
   
   lastUpdateTimestamp is used in which scene?  can it be delete?
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Go to '...'
   2. Click on ''
   3. Scroll down to ''
   4. See error
   
   **Expected behavior**
   A clear and concise description of what you expected to happen.
   
   **Screenshots**
   If applicable, add screenshots to help explain your problem.
   
   **Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
   
   **Smartphone (please complete the following information):**
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]
   
   **Additional context**
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] 18205097282 commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


18205097282 commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022915628


   @ni-ze 
   我查了,我的指标是400,基本上全是MissTPS 造成的,FoundTPS值很小。
   
   “从存储中查询消息,如果能找到就算在FoundTPS中,找不到就算在MissTPS中。”
   When org.apache.rocketmq.store.DefaultMessageStore#getMessage is called, 
getMessageTimesTotalFound or getMessageTimesTotalMiss is incremented.
   
   对不起,我没有听懂,因为找一次,MissTPS或FoundTPS其中一个必+1,
   也就是两者之和 TotalTPS必+1。那我的指标值不就是恒等于DefaultMessageStore#getMessage的调用次数了吗?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [rocketmq] odbozhou commented on issue #3800: console dashboard 页面疑问

2022-01-26 Thread GitBox


odbozhou commented on issue #3800:
URL: https://github.com/apache/rocketmq/issues/3800#issuecomment-1022916179


   > 
   
   这个展示的数据正如标题Broker 5min 
trend,主要是看broker消费tps数据趋势的,可以帮助我们查看broker是否有突发流量,broker流量是否平稳正常等,一般不用这个数据计算消息量,因为这个broker数据趋势是通过
 消费到消息请求的tps + 
没有消费请求tps计算的,所以即使没有消息,也会有拉取消息的请求,即使没有消息可以拉取到,也会有tps。如果对详细的消费感兴趣可以看一下客户端消费消息的逻辑,这更有助于了解这些数据。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org