[GitHub] [rocketmq] codecov-commenter commented on pull request #3916: [ISSUE #3915] readme add rocketmq connect link
codecov-commenter commented on pull request #3916: URL: https://github.com/apache/rocketmq/pull/3916#issuecomment-1056528411 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3916](https://codecov.io/gh/apache/rocketmq/pull/3916?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74667e9) into [develop](https://codecov.io/gh/apache/rocketmq/commit/19f99a5c6389fbc5acd9f54692cc1b1eeda1a85b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19f99a5) will **decrease** coverage by `0.06%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/rocketmq/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## develop#3916 +/- ## = - Coverage 47.55% 47.49% -0.07% + Complexity 4939 4930 -9 = Files633 633 Lines 4256042560 Branches5588 5588 = - Hits 2024120213 -28 - Misses 1980919834 +25 - Partials2510 2513 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...org/apache/rocketmq/store/ha/WaitNotifyObject.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL1dhaXROb3RpZnlPYmplY3QuamF2YQ==) | `66.07% <0.00%> (-5.36%)` | :arrow_down: | | [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (-2.57%)` | :arrow_down: | | [.../java/org/apache/rocketmq/logging/inner/Level.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9MZXZlbC5qYXZh) | `36.00% <0.00%> (-2.00%)` | :arrow_down: | | [.../rocketmq/broker/filter/ConsumerFilterManager.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyL0NvbnN1bWVyRmlsdGVyTWFuYWdlci5qYXZh) | `72.19% <0.00%> (-1.80%)` | :arrow_down: | | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `36.41% <0.00%> (-1.69%)` | :arrow_down: | | [...java/org/apache/rocketmq/logging/inner/Logger.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnZXIuamF2YQ==) | `50.23% <0.00%> (-1.44%)` | :arrow_down: | | [...etmq/client/latency/LatencyFaultToleranceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvbGF0ZW5jeS9MYXRlbmN5RmF1bHRU
[GitHub] [rocketmq] coveralls commented on pull request #3916: [ISSUE #3915] readme add rocketmq connect link
coveralls commented on pull request #3916: URL: https://github.com/apache/rocketmq/pull/3916#issuecomment-1056535546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3916: [ISSUE #3915] readme add rocketmq connect link
codecov-commenter edited a comment on pull request #3916: URL: https://github.com/apache/rocketmq/pull/3916#issuecomment-1056528411 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3916](https://codecov.io/gh/apache/rocketmq/pull/3916?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74667e9) into [develop](https://codecov.io/gh/apache/rocketmq/commit/19f99a5c6389fbc5acd9f54692cc1b1eeda1a85b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19f99a5) will **increase** coverage by `0.00%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/rocketmq/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## develop#3916 +/- ## == Coverage 47.55% 47.56% - Complexity 4939 4943+4 == Files633 633 Lines 4256042560 Branches5588 5588 == + Hits 2024120245+4 - Misses 1980919810+1 + Partials2510 2505-5 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../rocketmq/broker/filter/ConsumerFilterManager.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyL0NvbnN1bWVyRmlsdGVyTWFuYWdlci5qYXZh) | `72.19% <0.00%> (-1.80%)` | :arrow_down: | | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `36.41% <0.00%> (-1.69%)` | :arrow_down: | | [...etmq/client/latency/LatencyFaultToleranceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvbGF0ZW5jeS9MYXRlbmN5RmF1bHRUb2xlcmFuY2VJbXBsLmphdmE=) | `50.00% <0.00%> (-1.29%)` | :arrow_down: | | [...ketmq/common/protocol/body/RegisterBrokerBody.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9SZWdpc3RlckJyb2tlckJvZHkuamF2YQ==) | `83.69% <0.00%> (-1.09%)` | :arrow_down: | | [.../apache/rocketmq/logging/inner/LoggingBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnaW5nQnVpbGRlci5qYXZh) | `64.39% <0.00%> (-0.32%)` | :arrow_down: | | [...che/rocketmq/acl/plain/PlainPermissionManager.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5QZXJtaXNzaW9uTWFuYWdlci5qYXZh) | `71.72% <0.00%> (+0.26%)` | :arrow_up: | | [...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/3916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZX
[GitHub] [rocketmq] codecov-commenter commented on pull request #3919: [ISSUE #3918] readme add rocketmq dashboard link
codecov-commenter commented on pull request #3919: URL: https://github.com/apache/rocketmq/pull/3919#issuecomment-1056552178 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3919?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3919](https://codecov.io/gh/apache/rocketmq/pull/3919?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (081f23e) into [develop](https://codecov.io/gh/apache/rocketmq/commit/19f99a5c6389fbc5acd9f54692cc1b1eeda1a85b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19f99a5) will **decrease** coverage by `0.20%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/rocketmq/pull/3919?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## develop#3919 +/- ## = - Coverage 47.55% 47.35% -0.21% + Complexity 4939 4910 -29 = Files633 633 Lines 4256042560 Branches5588 5588 = - Hits 2024120155 -86 - Misses 1980919895 +86 Partials2510 2510 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3919?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==) | `20.00% <0.00%> (-14.29%)` | :arrow_down: | | [...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==) | `38.88% <0.00%> (-5.56%)` | :arrow_down: | | [...apache/rocketmq/remoting/netty/ResponseFuture.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L1Jlc3BvbnNlRnV0dXJlLmphdmE=) | `85.00% <0.00%> (-5.00%)` | :arrow_down: | | [...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh) | `46.88% <0.00%> (-4.03%)` | :arrow_down: | | [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (-2.57%)` | :arrow_down: | | [...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=) | `40.17% <0.00%> (-2.29%)` | :arrow_down: | | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmc
[GitHub] [rocketmq] coveralls commented on pull request #3919: [ISSUE #3918] readme add rocketmq dashboard link
coveralls commented on pull request #3919: URL: https://github.com/apache/rocketmq/pull/3919#issuecomment-1056558622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3919: [ISSUE #3918] readme add rocketmq dashboard link
codecov-commenter edited a comment on pull request #3919: URL: https://github.com/apache/rocketmq/pull/3919#issuecomment-1056552178 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3919?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3919](https://codecov.io/gh/apache/rocketmq/pull/3919?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (081f23e) into [develop](https://codecov.io/gh/apache/rocketmq/commit/19f99a5c6389fbc5acd9f54692cc1b1eeda1a85b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19f99a5) will **decrease** coverage by `0.08%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/rocketmq/pull/3919?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## develop#3919 +/- ## = - Coverage 47.55% 47.47% -0.09% + Complexity 4939 4925 -14 = Files633 633 Lines 4256042560 Branches5588 5588 = - Hits 2024120204 -37 - Misses 1980919848 +39 + Partials2510 2508 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3919?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...apache/rocketmq/remoting/netty/ResponseFuture.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L1Jlc3BvbnNlRnV0dXJlLmphdmE=) | `85.00% <0.00%> (-5.00%)` | :arrow_down: | | [...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh) | `46.88% <0.00%> (-4.03%)` | :arrow_down: | | [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (-2.57%)` | :arrow_down: | | [...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=) | `40.17% <0.00%> (-2.29%)` | :arrow_down: | | [.../rocketmq/broker/filter/ConsumerFilterManager.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyL0NvbnN1bWVyRmlsdGVyTWFuYWdlci5qYXZh) | `72.19% <0.00%> (-1.80%)` | :arrow_down: | | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `36.41% <0.00%> (-1.69%)` | :arrow_down: | | [...etmq/client/latency/LatencyFaultToleranceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3919/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL
[GitHub] [rocketmq-connect] zhouxinyu commented on pull request #5: add fc sink task
zhouxinyu commented on pull request #5: URL: https://github.com/apache/rocketmq-connect/pull/5#issuecomment-1056563981 It seems that we should move the directory to `connectors` instead of the root? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] duhenglucky closed issue #3918: [DOC] Readme add rocketmq dashboard link
duhenglucky closed issue #3918: URL: https://github.com/apache/rocketmq/issues/3918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] duhenglucky merged pull request #3919: [ISSUE #3918] readme add rocketmq dashboard link
duhenglucky merged pull request #3919: URL: https://github.com/apache/rocketmq/pull/3919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] duhenglucky closed issue #3915: readme add rocketmq connect link
duhenglucky closed issue #3915: URL: https://github.com/apache/rocketmq/issues/3915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] UnderTreeTech commented on issue #754: so many goroutine
UnderTreeTech commented on issue #754: URL: https://github.com/apache/rocketmq-client-go/issues/754#issuecomment-1056659064 Any updates? @wenfengwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-connect] zhouxinyu commented on a change in pull request #5: add fc sink task
zhouxinyu commented on a change in pull request #5:
URL: https://github.com/apache/rocketmq-connect/pull/5#discussion_r817453656
##
File path: aliyun/rocketmq-connect-fc/src/main/resources/log4j.properties
##
@@ -0,0 +1,28 @@
+log4j.rootCategory=INFO, console
+log4j.appender.console=org.apache.log4j.ConsoleAppender
+log4j.appender.console.target=System.err
+log4j.appender.console.layout=org.apache.log4j.PatternLayout
+log4j.appender.console.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss} %p
%c{1}: %m%n
+
+# Set the default spark-shell log level to WARN. When running the spark-shell,
the
+# log level for this class is used to overwrite the root logger's log level,
so that
Review comment:
Why there are spark-related configs?
##
File path:
aliyun/rocketmq-connect-fc/src/test/java/com/aliyun/rocketmq/connect/fc/sink/FcSinkConnectorTest.java
##
@@ -0,0 +1,14 @@
+package com.aliyun.rocketmq.connect.fc.sink;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class FcSinkConnectorTest {
+
+private final FcSinkConnector fcSinkConnector = new FcSinkConnector();
+
+@Test
+public void testTaskConfigs() {
+Assert.assertEquals(fcSinkConnector.taskConfigs(1).size(), 1);
Review comment:
Could you please add more unit tests for the core features?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq-connect] duhenglucky merged pull request #4: open issues and wiki
duhenglucky merged pull request #4: URL: https://github.com/apache/rocketmq-connect/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] panzhi33 commented on issue #3920: Consumer support message send back with origin message modified.
panzhi33 commented on issue #3920: URL: https://github.com/apache/rocketmq/issues/3920#issuecomment-1056735376 why not send the new message directly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] llIlll commented on issue #3915: readme add rocketmq connect link
llIlll commented on issue #3915: URL: https://github.com/apache/rocketmq/issues/3915#issuecomment-1056795965 Please assign this issue to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE][RIP-36] Optimize topic routing mechanism
Hi, RocketMQ Community, As discussed in the previous email, we launched a new RIP to optimize topic routing mechanism. Now the shepherds @dongeforever and @yukon are willing to support the RIP, so I think it is time to start an email thread to enter the voting process. The vote will be open for at least 72 hours or until a necessary number of votes are reached. Please vote accordingly: [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove with the reason Best Regards! xijiu links: https://shimo.im/docs/vVAXVrDNnoSrMBqm/
Re: [VOTE][RIP-36] Optimize topic routing mechanism
+1 for moving forward. On Wed, Mar 2, 2022 at 7:42 PM xijiu <422766...@qq.com.invalid> wrote: > Hi, RocketMQ Community, > > As discussed in the previous email, we launched a new RIP to optimize > topic routing mechanism. Now the shepherds @dongeforever and @yukon are > willing to support the RIP, so I think it is time to start an email thread > to enter the voting process. > > > The vote will be open for at least 72 hours or until a necessary number of > votes are reached. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > > Best Regards! > xijiu > > links: > https://shimo.im/docs/vVAXVrDNnoSrMBqm/
Re: [VOTE][RIP-36] Optimize topic routing mechanism
I read the whole plan, it is beneficial for the nameserver to actively push changes to the client, but this benefit also brings complexity. I personally think this benefit is not very big. Unless there is a better explanation, I will reject this proposal. Best regards, Xiaorui Wang 王小瑞 Apache RocketMQ PMC Chair xijiu <422766...@qq.com.invalid> 于2022年3月2日周三 19:42写道： > Hi, RocketMQ Community, > > As discussed in the previous email, we launched a new RIP to optimize > topic routing mechanism. Now the shepherds @dongeforever and @yukon are > willing to support the RIP, so I think it is time to start an email thread > to enter the voting process. > > > The vote will be open for at least 72 hours or until a necessary number of > votes are reached. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > > Best Regards! > xijiu > > links: > https://shimo.im/docs/vVAXVrDNnoSrMBqm/
[GitHub] [rocketmq] llIlll removed a comment on issue #3915: readme add rocketmq connect link
llIlll removed a comment on issue #3915: URL: https://github.com/apache/rocketmq/issues/3915#issuecomment-1056795965 Please assign this issue to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] Jacob-Jay opened a new issue #3921: let the code simple
Jacob-Jay opened a new issue #3921:
URL: https://github.com/apache/rocketmq/issues/3921
https://github.com/apache/rocketmq/blob/c840b208337b26c7529602b81d398c0a87a23888/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java#L247
` if (ackIndex >= consumeRequest.getMsgs().size())
{
ackIndex = consumeRequest.getMsgs().size() - 1;
}
int ok = ackIndex + 1;
int failed = consumeRequest.getMsgs().size() - ok;`
why not ok‘s value is consumeRequest.getMsgs().size() and failed zero
direct？ it's confusing now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] Jacob-Jay closed issue #3921: let the code simple
Jacob-Jay closed issue #3921: URL: https://github.com/apache/rocketmq/issues/3921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [rocketmq] branch develop updated: readme add rocketmq dashboard link (#3919)
Frankly speaking, I don't think it's a good way to list so many incubator projects in our main repository. We could consider keeping it simple as its previous position. You could call for a vote for other sub-projects graduation like our graduation rules. Just rethink it, maybe a better way came to our idea? 于2022年3月2日周三 16:40写道： > This is an automated email from the ASF dual-hosted git repository. > > duhengforever pushed a commit to branch develop > in repository https://gitbox.apache.org/repos/asf/rocketmq.git > > > The following commit(s) were added to refs/heads/develop by this push: > new 7276cf9 readme add rocketmq dashboard link (#3919) > 7276cf9 is described below > > commit 7276cf99264d002dd516c22970329116e52b71a2 > Author: cserwen > AuthorDate: Wed Mar 2 16:36:18 2022 +0800 > > readme add rocketmq dashboard link (#3919) > > Co-authored-by: dengzhiwen1 > --- > README.md | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/README.md b/README.md > index 41392af..b7f516f 100644 > --- a/README.md > +++ b/README.md > @@ -45,6 +45,7 @@ It offers a variety of features: > * [RocketMQ Exporter](https://github.com/apache/rocketmq-exporter) > * [RocketMQ Operator](https://github.com/apache/rocketmq-operator) > * [RocketMQ Docker](https://github.com/apache/rocketmq-docker) > +* [RocketMQ Dashboard](https://github.com/apache/rocketmq-dashboard) > * [RocketMQ Incubating Community Projects]( > https://github.com/apache/rocketmq-externals) > > -- > -- Best Regards :-)
[GitHub] [rocketmq] web1992 commented on a change in pull request #3913: fix [optimization order message example]
web1992 commented on a change in pull request #3913: URL: https://github.com/apache/rocketmq/pull/3913#discussion_r817757667 ## File path: example/src/main/java/org/apache/rocketmq/example/ordermessage/Consumer.java ## @@ -26,6 +26,35 @@ import org.apache.rocketmq.common.consumer.ConsumeFromWhere; import org.apache.rocketmq.common.message.MessageExt; + +/** + * + * This example shows RocketMq keep order message (local order not global order) Review comment: fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #3913: fix [optimization order message example]
codecov-commenter commented on pull request #3913: URL: https://github.com/apache/rocketmq/pull/3913#issuecomment-1057181371 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3913?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3913](https://codecov.io/gh/apache/rocketmq/pull/3913?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b5b97a) into [develop](https://codecov.io/gh/apache/rocketmq/commit/19f99a5c6389fbc5acd9f54692cc1b1eeda1a85b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19f99a5) will **decrease** coverage by `0.09%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/rocketmq/pull/3913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## develop#3913 +/- ## = - Coverage 47.55% 47.46% -0.10% + Complexity 4939 4928 -11 = Files633 633 Lines 4256042560 Branches5588 5588 = - Hits 2024120201 -40 - Misses 1980919849 +40 Partials2510 2510 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==) | `20.00% <0.00%> (-14.29%)` | :arrow_down: | | [...org/apache/rocketmq/store/ha/WaitNotifyObject.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL1dhaXROb3RpZnlPYmplY3QuamF2YQ==) | `66.07% <0.00%> (-5.36%)` | :arrow_down: | | [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (-2.57%)` | :arrow_down: | | [.../java/org/apache/rocketmq/logging/inner/Level.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9MZXZlbC5qYXZh) | `36.00% <0.00%> (-2.00%)` | :arrow_down: | | [.../rocketmq/broker/filter/ConsumerFilterManager.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyL0NvbnN1bWVyRmlsdGVyTWFuYWdlci5qYXZh) | `72.19% <0.00%> (-1.80%)` | :arrow_down: | | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `36.41% <0.00%> (-1.69%)` | :arrow_down: | | [...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2U
[GitHub] [rocketmq] coveralls edited a comment on pull request #3913: fix [optimization order message example]
coveralls edited a comment on pull request #3913: URL: https://github.com/apache/rocketmq/pull/3913#issuecomment-1056228937 [](https://coveralls.io/builds/47018678) Coverage increased (+0.04%) to 51.593% when pulling **0b5b97a906db0ca5d41e0462aa25cd080c5064e6 on web1992:optimization_order_message_example** into **19f99a5c6389fbc5acd9f54692cc1b1eeda1a85b on apache:develop**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3913: fix [optimization order message example]
codecov-commenter edited a comment on pull request #3913: URL: https://github.com/apache/rocketmq/pull/3913#issuecomment-1057181371 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3913?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3913](https://codecov.io/gh/apache/rocketmq/pull/3913?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b5b97a) into [develop](https://codecov.io/gh/apache/rocketmq/commit/19f99a5c6389fbc5acd9f54692cc1b1eeda1a85b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19f99a5) will **decrease** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/rocketmq/pull/3913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## develop#3913 +/- ## = - Coverage 47.55% 47.52% -0.04% Complexity 4939 4939 = Files633 633 Lines 4256042560 Branches5588 5588 = - Hits 2024120228 -13 - Misses 1980919821 +12 - Partials2510 2511 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...org/apache/rocketmq/store/ha/WaitNotifyObject.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL1dhaXROb3RpZnlPYmplY3QuamF2YQ==) | `66.07% <0.00%> (-5.36%)` | :arrow_down: | | [.../rocketmq/broker/filter/ConsumerFilterManager.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyL0NvbnN1bWVyRmlsdGVyTWFuYWdlci5qYXZh) | `72.19% <0.00%> (-1.80%)` | :arrow_down: | | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `36.41% <0.00%> (-1.69%)` | :arrow_down: | | [...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==) | `78.21% <0.00%> (-1.49%)` | :arrow_down: | | [...etmq/client/latency/LatencyFaultToleranceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvbGF0ZW5jeS9MYXRlbmN5RmF1bHRUb2xlcmFuY2VJbXBsLmphdmE=) | `50.00% <0.00%> (-1.29%)` | :arrow_down: | | [...n/java/org/apache/rocketmq/store/ha/HAService.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL0hBU2VydmljZS5qYXZh) | `71.66% <0.00%> (-0.67%)` | :arrow_down: | | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/3913/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZ
[GitHub] [rocketmq] zergduan opened a new issue #3922: ACL 多配置文件功能，导致无法通过 mqadmin 更新全局IP白名单
zergduan opened a new issue #3922: URL: https://github.com/apache/rocketmq/issues/3922 **BUG REPORT** 1. Please describe the issue you observed: 新版本 4.9.3 中提供了ACL多配置文件功能 默认配置文件从原来的 /conf/plain_acl.yml 改为 /conf/acl/plain_acl.yml 但是 mqadmin 依然只能修改 /conf/plain_acl.yml 初始部署时，如果手动创建 /conf/plain_acl.yml ，写入全局IP白名单，会导致 mqadmin 无法修改 ACL 配置，报错如下： sh /opt/paasmq/rocketmq-4.9.3/bin/mqadmin updateAclConfig -n 127.0.0.1:19876 -c AWS-NPRD-Cluster \ > --accessKey PG-E-APP-YYY \ > --secretKey 12345678 \ > --admin false \ > --defaultTopicPerm DENY \ > --defaultGroupPerm DENY \ > --topicPerms RMQ_SYS_TRACE_TOPIC=PUB,TP-E-APP-YYY=PUB RocketMQLog:WARN No appenders could be found for logger (io.netty.util.internal.InternalThreadLocalMap). RocketMQLog:WARN Please initialize the logger system properly. org.apache.rocketmq.tools.command.SubCommandException: UpdateAccessConfigSubCommand command failed at org.apache.rocketmq.tools.command.acl.UpdateAccessConfigSubCommand.execute(UpdateAccessConfigSubCommand.java:180) at org.apache.rocketmq.tools.command.MQAdminStartup.main0(MQAdminStartup.java:146) at org.apache.rocketmq.tools.command.MQAdminStartup.main(MQAdminStartup.java:97) Caused by: org.apache.rocketmq.client.exception.MQClientException: CODE: 209 DESC: null For more information, please visit the url, http://rocketmq.apache.org/docs/faq/ at org.apache.rocketmq.client.impl.MQClientAPIImpl.createPlainAccessConfig(MQClientAPIImpl.java:328) at org.apache.rocketmq.tools.admin.DefaultMQAdminExtImpl.createAndUpdatePlainAccessConfig(DefaultMQAdminExtImpl.java:205) at org.apache.rocketmq.tools.admin.DefaultMQAdminExt.createAndUpdatePlainAccessConfig(DefaultMQAdminExt.java:175) at org.apache.rocketmq.tools.command.acl.UpdateAccessConfigSubCommand.execute(UpdateAccessConfigSubCommand.java:170) 经测试，初始安装时，必须保证 /conf/plain_acl.yml 不存在，并且将全局IP白名单写入 /conf/acl/plain_acl.yml 中，才能通过 mqadmin 修改 ACL 配置：如下： sh /opt/paasmq/rocketmq-4.9.3/bin/mqadmin updateAclConfig -n 127.0.0.1:19876 -c AWS-NPRD-Cluster \ > --accessKey PG-E-APP-YYY \ > --secretKey 12345678 \ > --admin false \ > --defaultTopicPerm DENY \ > --defaultGroupPerm DENY \ > --topicPerms RMQ_SYS_TRACE_TOPIC=PUB,TP-E-APP-YYY=PUB RocketMQLog:WARN No appenders could be found for logger (io.netty.util.internal.InternalThreadLocalMap). RocketMQLog:WARN Please initialize the logger system properly. create or update plain access config to 10.155.100.164:22922 success. create or update plain access config to 10.155.101.59:22922 success. create or update plain access config to 10.155.101.112:22922 success. create or update plain access config to 10.155.100.212:22922 success. org.apache.rocketmq.common.PlainAccessConfig@5fe94a96 但是此时，ACL 规则分布在2个文件中： account 规则在 /conf/plain_acl.yml 中保存 全局IP白名单规则在 /conf/acl/plain_acl.yml 中保存 这会导致后期维护非常繁琐，所以想通过 mqadmin updateGlobalWhiteAddr 命令将全局IP白名单也迁移到 /conf/plain_acl.yml 中，然后删除 /conf/acl/plain_acl.yml 但是发现 CLI 无法更新全局IP白名单 场景1. 当/conf/plain_acl.yml存在，里面已经保存了部分account规则时，尝试通过mqadmin命令增加全局 IP 白名单规则，报错如下： sh /opt/paasmq/rocketmq-4.9.3/bin/mqadmin updateGlobalWhiteAddr -n 127.0.0.1:19876 -b 10.155.101.112:22922 -g 10.177.96.11 RocketMQLog:WARN No appenders could be found for logger (io.netty.util.internal.InternalThreadLocalMap). RocketMQLog:WARN Please initialize the logger system properly. org.apache.rocketmq.tools.command.SubCommandException: UpdateGlobalWhiteAddrSubCommand command failed at org.apache.rocketmq.tools.command.acl.UpdateGlobalWhiteAddrSubCommand.execute(UpdateGlobalWhiteAddrSubCommand.java:96) at org.apache.rocketmq.tools.command.MQAdminStartup.main0(MQAdminStartup.java:146) at org.apache.rocketmq.tools.command.MQAdminStartup.main(MQAdminStartup.java:97) Caused by: org.apache.rocketmq.client.exception.MQClientException: CODE: 211 DESC: The globalWhiteAddresses[10.177.96.11] has been updated failed. For more information, please visit the url, http://rocketmq.apache.org/docs/faq/ at org.apache.rocketmq.client.impl.MQClientAPIImpl.updateGlobalWhiteAddrsConfig(MQClientAPIImpl.java:371) at org.apache.rocketmq.tools.admin.DefaultMQAdminExtImpl.updateGlobalWhiteAddrConfig(DefaultMQAdminExtImpl.java:215) at org.apache.rocketmq.tools.admin.DefaultMQAdminExt.updateGlobalWhiteAddrConfig(DefaultMQAdminExt.java:185) at org.apache.rocketmq.tools.command.acl.UpdateGlobalWhiteAddrSubCommand.execute(UpdateGlobalWhiteAddrSubCommand.java:76) ... 2 more 场景2. 当/conf/plain_acl.yml不存在，尝试通过 mqadmin 命令创建此文件并添加全局IP白名单规则，报错如下： sh /opt/paasmq/rocketmq-4.9.3/bin/mqadmin updateGlobalWhiteAddr -n 127.0.0.1:19876 -b 10.155.101.112:22922 -g 10.177.96.111 RocketMQLog:WARN No ap
[GitHub] [rocketmq] ni-ze commented on pull request #3913: fix [optimization order message example]
ni-ze commented on pull request #3913: URL: https://github.com/apache/rocketmq/pull/3913#issuecomment-1057577815 Frankly speaking, I can not find where is partially order from output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] duhenglucky commented on issue #3922: mqadmin updateGlobalWhiteAddr failed in 4.9.3
duhenglucky commented on issue #3922: URL: https://github.com/apache/rocketmq/issues/3922#issuecomment-1057578441 @caigy @sunxi92 Would you like to resolve this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-externals] odbozhou commented on issue #867: [rocketmq-connect] Synchronize data from Mysql to Redis
odbozhou commented on issue #867: URL: https://github.com/apache/rocketmq-externals/issues/867#issuecomment-1057601329 @githublaohu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-externals] odbozhou removed a comment on issue #867: [rocketmq-connect] Synchronize data from Mysql to Redis
odbozhou removed a comment on issue #867: URL: https://github.com/apache/rocketmq-externals/issues/867#issuecomment-1057601329 @githublaohu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-externals] odbozhou commented on issue #867: [rocketmq-connect] Synchronize data from Mysql to Redis
odbozhou commented on issue #867: URL: https://github.com/apache/rocketmq-externals/issues/867#issuecomment-1057602491 @githublaohu rocketmq-connect already has an independent repository, you can go to this repository to submit PR, issue. https://github.com/apache/rocketmq-connect -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] duhenglucky merged pull request #3916: [ISSUE #3915] readme add rocketmq connect link
duhenglucky merged pull request #3916: URL: https://github.com/apache/rocketmq/pull/3916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] duhenglucky closed issue #3915: readme add rocketmq connect link
duhenglucky closed issue #3915: URL: https://github.com/apache/rocketmq/issues/3915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] duhenglucky closed issue #3900: Wrong dir is created when using mult-dirs storage.
duhenglucky closed issue #3900: URL: https://github.com/apache/rocketmq/issues/3900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] duhenglucky merged pull request #3901: [ISSUE #3900] Fix that wrong dir is created when using mult-dirs storage
duhenglucky merged pull request #3901: URL: https://github.com/apache/rocketmq/pull/3901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3916: [ISSUE #3915] readme add rocketmq connect link
coveralls edited a comment on pull request #3916: URL: https://github.com/apache/rocketmq/pull/3916#issuecomment-1056535558 [](https://coveralls.io/builds/47034127) Coverage decreased (-0.02%) to 51.619% when pulling **8d720f94973ea033f6d40ec5b6443e135e80e55d on odbozhou:readme_add_connect_link1** into **7276cf99264d002dd516c22970329116e52b71a2 on apache:develop**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] sunxi92 commented on issue #3922: mqadmin updateGlobalWhiteAddr failed in 4.9.3
sunxi92 commented on issue #3922: URL: https://github.com/apache/rocketmq/issues/3922#issuecomment-1057614501 > @caigy @sunxi92 Would you like to resolve this issue? Let me look at the problem first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] GOODBOY008 commented on issue #3902: Bump Junit4 to Junit 5.
GOODBOY008 commented on issue #3902: URL: https://github.com/apache/rocketmq/issues/3902#issuecomment-1057617867 @duhenglucky Yes,I am willing to polish it. Please assgin this issue to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-connect] zhaohai1299002788 commented on pull request #5: add fc sink task
zhaohai1299002788 commented on pull request #5: URL: https://github.com/apache/rocketmq-connect/pull/5#issuecomment-1057621222 > 看来我们应该将目录移动到`connectors`而不是根目录？ Modified engineering structure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-connect] zhaohai1299002788 commented on a change in pull request #5: add fc sink task
zhaohai1299002788 commented on a change in pull request #5:
URL: https://github.com/apache/rocketmq-connect/pull/5#discussion_r818280660
##
File path: aliyun/rocketmq-connect-fc/src/main/resources/log4j.properties
##
@@ -0,0 +1,28 @@
+log4j.rootCategory=INFO, console
+log4j.appender.console=org.apache.log4j.ConsoleAppender
+log4j.appender.console.target=System.err
+log4j.appender.console.layout=org.apache.log4j.PatternLayout
+log4j.appender.console.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss} %p
%c{1}: %m%n
+
+# Set the default spark-shell log level to WARN. When running the spark-shell,
the
+# log level for this class is used to overwrite the root logger's log level,
so that
Review comment:
Irrelevant information deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] duhenglucky merged pull request #3904: [#3903] Add topic validation, forbid sending message to system topic
duhenglucky merged pull request #3904: URL: https://github.com/apache/rocketmq/pull/3904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] duhenglucky closed issue #3903: Add topic validation, forbid sending message to system topic
duhenglucky closed issue #3903: URL: https://github.com/apache/rocketmq/issues/3903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-dashboard] zhangjidi2016 opened a new issue #74: upgrade rocketmq version
zhangjidi2016 opened a new issue #74: URL: https://github.com/apache/rocketmq-dashboard/issues/74 upgrade rocketmq version to 4.9.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] zergduan commented on issue #3922: mqadmin updateGlobalWhiteAddr failed in 4.9.3
zergduan commented on issue #3922:
URL: https://github.com/apache/rocketmq/issues/3922#issuecomment-1057631591
另外发现，/conf/plain_acl.yml 和 /conf/acl/plain_acl.yml 共存的情况下：
全局IP白名单保存在 /conf/acl/plain_acl.yml
account保存在 /conf/plain.acl.yml
此时通过 CLI 添加的 account后，虽然可以通过 mqadmin getAccessConfigSubCommand
看到设置的权限，但是使用时却无法通过ACl检测
例如：
step1. /conf/plain.acl.yml 不存在，/conf/acl/plain.yml 手动写入全局IP白名单
step2. 使用CLI mqadmin 添加 account 用于生产者，如下：
sh /opt/paasmq/rocketmq-4.9.3/bin/mqadmin updateAclConfig -n 127.0.0.1:19876
-c AWS-NPRD-Cluster \
--accessKey PG-E-APP-YYY \
--secretKey 12345678 \
--admin false \
--defaultTopicPerm DENY \
--defaultGroupPerm DENY \
--topicPerms RMQ_SYS_TRACE_TOPIC=PUB,TP-E-APP-YYY=PUB
step3. 使用 CLI mqadmin 查看新添加的account，已经成功
sh /opt/paasmq/rocketmq-4.9.3/bin/mqadmin getAccessConfigSubCommand -n
127.0.0.1:19876 -c AWS-NPRD-Cluster;
step4. 使用以下代码测试生产这者功能，可以正常消费
public class AclProducer {
public static void main(String[] args)
throws MQClientException, InterruptedException,
RemotingException, MQBrokerException {
DefaultMQProducer producer = new
DefaultMQProducer("My-Producer-YYY", getAclRPCHook(), true, null);
producer.setNamesrvAddr("10.155.100.8:19876;10.155.101.213:19876");
producer.start();
for (int i = 0; i < 10; i++) {
try {
Message msg = new Message("TP-E-APP-YYY" ,"*" , ("Hello
RocketMQ " + i).getBytes(RemotingHelper.DEFAULT_CHARSET));
//msg.setDelayTimeLevel(6);
SendResult sendResult = producer.send(msg);
System.out.printf("%s%n", sendResult);
Thread.sleep(10);
} catch (Exception e) {
e.printStackTrace();
Thread.sleep(1000);
}
}
producer.shutdown();
}
static RPCHook getAclRPCHook() {
return new AclClientRPCHook(new
SessionCredentials("PG-E-APP-YYY","12345678"));
}
}
step4. 使用CLI mqadmin 添加 account 用于消费者，如下：
sh /opt/paasmq/rocketmq-4.9.3/bin/mqadmin updateAclConfig -n 127.0.0.1:19876
-c AWS-NPRD-Cluster \
--accessKey CG-E-APP-YYY-APP-SVC \
--secretKey 12345678 \
--admin false \
--defaultTopicPerm DENY \
--defaultGroupPerm DENY \
--topicPerms RMQ_SYS_TRACE_TOPIC=PUB,TP-E-APP-YYY=SUB \
--groupPerms CG-E-APP-YYY-APP-SVC=SUB
step5. 使用和step3中相同的代码，再次测试生产，发现无法正常生产消息，报错如下：
```
org.apache.rocketmq.client.exception.MQClientException: Send [3] times,
still failed, cost [17]ms, Topic: TP-E-APP-YYY, BrokersSent:
[AWS-NPRD-Broker-a, AWS-NPRD-Broker-b, AWS-NPRD-Broker-a]
See http://rocketmq.apache.org/docs/faq/ for further details.
at
org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl.sendDefaultImpl(DefaultMQProducerImpl.java:681)
at
org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl.send(DefaultMQProducerImpl.java:1391)
at
org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl.send(DefaultMQProducerImpl.java:1335)
at
org.apache.rocketmq.client.producer.DefaultMQProducer.send(DefaultMQProducer.java:336)
at AclProducer.main(AclProducer.java:22)
Caused by: org.apache.rocketmq.client.exception.MQBrokerException: CODE: 1
DESC: java.lang.NullPointerException,
org.apache.rocketmq.acl.plain.PlainPermissionManager.validate(PlainPermissionManager.java:646)
BROKER: 10.155.100.164:22922
For more information, please visit the url,
http://rocketmq.apache.org/docs/faq/
at
org.apache.rocketmq.client.impl.MQClientAPIImpl.processSendResponse(MQClientAPIImpl.java:668)
at
org.apache.rocketmq.client.impl.MQClientAPIImpl.sendMessageSync(MQClientAPIImpl.java:507)
at
org.apache.rocketmq.client.impl.MQClientAPIImpl.sendMessage(MQClientAPIImpl.java:489)
at
org.apache.rocketmq.client.impl.MQClientAPIImpl.sendMessage(MQClientAPIImpl.java:433)
at
org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl.sendKernelImpl(DefaultMQProducerImpl.java:870)
at
org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl.sendDefaultImpl(DefaultMQProducerImpl.java:606)
... 4 more
```
step6. 使用下列代码，测试新加入的消费者 ACL，也无法正常消费
public class AclConsumer {
public static void main(String[] args) throws MQClientException {
DefaultMQPushConsumer consumer = new DefaultMQPushConsumer(
"CG-E-APP-YYY-APP-SVC", getAclRPCHook(), new
AllocateMessageQueueAveragely(), true, null);
consumer.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET);
consumer.subscribe("TP-E-APP-YYY", "*");
consumer.setNamesrvAddr("10.155.100.8:19876;10.155.101.213:19876");
consumer.registerMessageListener(new MessageListenerConcurrently() {
@Override
public ConsumeC
[GitHub] [rocketmq] zergduan edited a comment on issue #3922: mqadmin updateGlobalWhiteAddr failed in 4.9.3
zergduan edited a comment on issue #3922:
URL: https://github.com/apache/rocketmq/issues/3922#issuecomment-1057631591
另外发现，/conf/plain_acl.yml 和 /conf/acl/plain_acl.yml 共存的情况下：
全局IP白名单保存在 /conf/acl/plain_acl.yml
account保存在 /conf/plain_acl.yml
此时通过 CLI 添加的2个或者2个以上 account 规则后，虽然可以通过 mqadmin getAccessConfigSubCommand
看到设置的权限，但是ACL规则无效，生产消费时会报错。。。
只有当/conf/plain_acl.yml中只有1个account规则时，这个ACL才可以正常使用。
例如：
step1. /conf/plain.acl.yml 不存在，/conf/acl/plain.yml 手动写入全局IP白名单
step2. 使用CLI mqadmin 添加 account 用于生产者，如下：
sh /opt/paasmq/rocketmq-4.9.3/bin/mqadmin updateAclConfig -n 127.0.0.1:19876
-c AWS-NPRD-Cluster \
--accessKey PG-E-APP-YYY \
--secretKey 12345678 \
--admin false \
--defaultTopicPerm DENY \
--defaultGroupPerm DENY \
--topicPerms RMQ_SYS_TRACE_TOPIC=PUB,TP-E-APP-YYY=PUB
step3. 使用 CLI mqadmin 查看新添加的account，已经成功
sh /opt/paasmq/rocketmq-4.9.3/bin/mqadmin getAccessConfigSubCommand -n
127.0.0.1:19876 -c AWS-NPRD-Cluster;
step4. 使用以下代码测试生产这者功能，可以正常消费
public class AclProducer {
public static void main(String[] args)
throws MQClientException, InterruptedException,
RemotingException, MQBrokerException {
DefaultMQProducer producer = new
DefaultMQProducer("My-Producer-YYY", getAclRPCHook(), true, null);
producer.setNamesrvAddr("10.155.100.8:19876;10.155.101.213:19876");
producer.start();
for (int i = 0; i < 10; i++) {
try {
Message msg = new Message("TP-E-APP-YYY" ,"*" , ("Hello
RocketMQ " + i).getBytes(RemotingHelper.DEFAULT_CHARSET));
//msg.setDelayTimeLevel(6);
SendResult sendResult = producer.send(msg);
System.out.printf("%s%n", sendResult);
Thread.sleep(10);
} catch (Exception e) {
e.printStackTrace();
Thread.sleep(1000);
}
}
producer.shutdown();
}
static RPCHook getAclRPCHook() {
return new AclClientRPCHook(new
SessionCredentials("PG-E-APP-YYY","12345678"));
}
}
step4. 使用CLI mqadmin 添加 account 用于消费者，如下：
sh /opt/paasmq/rocketmq-4.9.3/bin/mqadmin updateAclConfig -n 127.0.0.1:19876
-c AWS-NPRD-Cluster \
--accessKey CG-E-APP-YYY-APP-SVC \
--secretKey 12345678 \
--admin false \
--defaultTopicPerm DENY \
--defaultGroupPerm DENY \
--topicPerms RMQ_SYS_TRACE_TOPIC=PUB,TP-E-APP-YYY=SUB \
--groupPerms CG-E-APP-YYY-APP-SVC=SUB
step5. 使用和step3中相同的代码，再次测试生产，发现无法正常生产消息，报错如下：
```
org.apache.rocketmq.client.exception.MQClientException: Send [3] times,
still failed, cost [17]ms, Topic: TP-E-APP-YYY, BrokersSent:
[AWS-NPRD-Broker-a, AWS-NPRD-Broker-b, AWS-NPRD-Broker-a]
See http://rocketmq.apache.org/docs/faq/ for further details.
at
org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl.sendDefaultImpl(DefaultMQProducerImpl.java:681)
at
org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl.send(DefaultMQProducerImpl.java:1391)
at
org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl.send(DefaultMQProducerImpl.java:1335)
at
org.apache.rocketmq.client.producer.DefaultMQProducer.send(DefaultMQProducer.java:336)
at AclProducer.main(AclProducer.java:22)
Caused by: org.apache.rocketmq.client.exception.MQBrokerException: CODE: 1
DESC: java.lang.NullPointerException,
org.apache.rocketmq.acl.plain.PlainPermissionManager.validate(PlainPermissionManager.java:646)
BROKER: 10.155.100.164:22922
For more information, please visit the url,
http://rocketmq.apache.org/docs/faq/
at
org.apache.rocketmq.client.impl.MQClientAPIImpl.processSendResponse(MQClientAPIImpl.java:668)
at
org.apache.rocketmq.client.impl.MQClientAPIImpl.sendMessageSync(MQClientAPIImpl.java:507)
at
org.apache.rocketmq.client.impl.MQClientAPIImpl.sendMessage(MQClientAPIImpl.java:489)
at
org.apache.rocketmq.client.impl.MQClientAPIImpl.sendMessage(MQClientAPIImpl.java:433)
at
org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl.sendKernelImpl(DefaultMQProducerImpl.java:870)
at
org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl.sendDefaultImpl(DefaultMQProducerImpl.java:606)
... 4 more
```
step6. 使用下列代码，测试新加入的消费者 ACL，也无法正常消费
public class AclConsumer {
public static void main(String[] args) throws MQClientException {
DefaultMQPushConsumer consumer = new DefaultMQPushConsumer(
"CG-E-APP-YYY-APP-SVC", getAclRPCHook(), new
AllocateMessageQueueAveragely(), true, null);
consumer.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET);
consumer.subscribe("TP-E-APP-YYY", "*");
consumer.setNamesrvAddr("10.155.100.8:19876;10.155.101.213:19876");
consumer.registerMessageListener(new
[GitHub] [rocketmq] 617450941 commented on issue #1508: Why is there no php sdk client?
617450941 commented on issue #1508: URL: https://github.com/apache/rocketmq/issues/1508#issuecomment-1057634749 3 year... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-dashboard] zhangjidi2016 opened a new pull request #75: [ISSUE #74]upgrade rocketmq version to 4.9.3
zhangjidi2016 opened a new pull request #75: URL: https://github.com/apache/rocketmq-dashboard/pull/75 ## What is the purpose of the change #74 ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-dashboard] codecov-commenter commented on pull request #75: [ISSUE #74]upgrade rocketmq version to 4.9.3
codecov-commenter commented on pull request #75: URL: https://github.com/apache/rocketmq-dashboard/pull/75#issuecomment-1057654954 # [Codecov](https://codecov.io/gh/apache/rocketmq-dashboard/pull/75?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#75](https://codecov.io/gh/apache/rocketmq-dashboard/pull/75?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24d42cb) into [master](https://codecov.io/gh/apache/rocketmq-dashboard/commit/0fc7ca904dd3b37bdaebb8040742e41c4bdf7f63?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0fc7ca9) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/rocketmq-dashboard/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #75 +/- ## = Coverage 76.79% 76.79% Complexity 753 753 = Files88 88 Lines 2586 2586 Branches235 235 = Hits 1986 1986 Misses 466 466 Partials134 134 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-dashboard/pull/75?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-dashboard/pull/75?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0fc7ca9...24d42cb](https://codecov.io/gh/apache/rocketmq-dashboard/pull/75?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-dashboard] codecov-commenter edited a comment on pull request #75: [ISSUE #74]upgrade rocketmq version to 4.9.3
codecov-commenter edited a comment on pull request #75: URL: https://github.com/apache/rocketmq-dashboard/pull/75#issuecomment-1057654954 # [Codecov](https://codecov.io/gh/apache/rocketmq-dashboard/pull/75?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#75](https://codecov.io/gh/apache/rocketmq-dashboard/pull/75?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24d42cb) into [master](https://codecov.io/gh/apache/rocketmq-dashboard/commit/0fc7ca904dd3b37bdaebb8040742e41c4bdf7f63?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0fc7ca9) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/rocketmq-dashboard/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #75 +/- ## = Coverage 76.79% 76.79% Complexity 753 753 = Files88 88 Lines 2586 2586 Branches235 235 = Hits 1986 1986 Misses 466 466 Partials134 134 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-dashboard/pull/75?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-dashboard/pull/75?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0fc7ca9...24d42cb](https://codecov.io/gh/apache/rocketmq-dashboard/pull/75?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] caigy commented on issue #3922: mqadmin updateGlobalWhiteAddr failed in 4.9.3
caigy commented on issue #3922: URL: https://github.com/apache/rocketmq/issues/3922#issuecomment-1057683336 I would submit a pr later, hope that the issue would be resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] minxiangli opened a new issue #3923: Requesthousekeepingservice thread leak（release-4.9.2）
minxiangli opened a new issue #3923:
URL: https://github.com/apache/rocketmq/issues/3923
1. Please describe the issue you observed:
- What did you do (The steps to reproduce)?
1.run this demo
`public void test() throws InterruptedException {
for(int i = 0; i < 100; i++) {
for (int j = 0; j < 20; j++) {
CompletableFuture.runAsync(()->{
DefaultMQProducer producer = new
DefaultMQProducer("please_rename_unique_group_name");
producer.setNamesrvAddr("localhost:9876");
try {
producer.start();
} catch (MQClientException e) {
e.printStackTrace();
}finally {
producer.shutdown();
}
});
}
}
Thread.sleep(1000*60*60*5);
}
`
- What did you see instead?
2. Please tell us about your environment:
jre : 1.8
os: mac os
rocketmq-version : release-4.9.2
3. Other information (e.g. detailed explanation, logs, related issues,
suggestions how to fix, etc):
scheduledExecutorService.scheduleAtFixedRate() and
scheduledExecutorService.shutdown() are not synchronous methods。
You can't guarantee that there is only one “RequestHouseKeepingService”。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on a change in pull request #3759: [ISSUE #3434] Consumers start slowly
Cc commented on a change in pull request #3759:
URL: https://github.com/apache/rocketmq/pull/3759#discussion_r818353002
##
File path:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
##
@@ -239,6 +243,8 @@ public void start() throws MQClientException {
this.pullMessageService.start();
// Start rebalance service
this.rebalanceService.start();
+//Start heartbeat service
+this.heartbeatService.start();
Review comment:
> no shutdown heartbeatService thread when the MQClientInstance shutdown
i will fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on pull request #3759: [ISSUE #3434] Consumers start slowly
Cc commented on pull request #3759: URL: https://github.com/apache/rocketmq/pull/3759#issuecomment-1057731297 > It seems that there are some unnecessary commits in this pr. > It seems that there are some unnecessary commits in this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] Cczzzz removed a comment on pull request #3759: [ISSUE #3434] Consumers start slowly
Cc removed a comment on pull request #3759: URL: https://github.com/apache/rocketmq/pull/3759#issuecomment-1057731297 > It seems that there are some unnecessary commits in this pr. > It seems that there are some unnecessary commits in this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] Cczzzz closed pull request #3759: [ISSUE #3434] Consumers start slowly
Cc closed pull request #3759: URL: https://github.com/apache/rocketmq/pull/3759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on pull request #3759: [ISSUE #3434] Consumers start slowly
Cc commented on pull request #3759: URL: https://github.com/apache/rocketmq/pull/3759#issuecomment-1057731575 > It seems that there are some unnecessary commits in this pr. that is because i checkout -b from master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] panzhi33 commented on issue #3923: Requesthousekeepingservice thread leak（release-4.9.2）
panzhi33 commented on issue #3923: URL: https://github.com/apache/rocketmq/issues/3923#issuecomment-1057734606 can see #3639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
