[GitHub] [rocketmq] Git-Yang opened a new pull request #4052: [ISSUE #4050] 5.0.0-alpha (Pop): Missing origin message id from dead letter message

[GitBox]

Git-Yang opened a new pull request #4052:
URL: https://github.com/apache/rocketmq/pull/4052


   ## What is the purpose of the change
   Fix #4050 
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-spring] RongtongJin closed issue #440: How to send and receive multiple rocketmq instances in a project?

[GitBox]

RongtongJin closed issue #440:
URL: https://github.com/apache/rocketmq-spring/issues/440


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #4051: [ISSUE #4050] fix origin messsage id missing from dead leetter meessage

[GitBox]

codecov-commenter edited a comment on pull request #4051:
URL: https://github.com/apache/rocketmq/pull/4051#issuecomment-1081441851


   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/4051?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#4051](https://codecov.io/gh/apache/rocketmq/pull/4051?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (30ed6c6) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/818ef2152f8e835cc907557d1e1d3da6705696ac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (818ef21) will **decrease** coverage by `0.07%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#4051  +/-   ##
   =
   - Coverage  47.93%   47.85%   -0.08% 
   + Complexity  5002 4989  -13 
   =
 Files633  633  
 Lines  4252842528  
 Branches5573 5573  
   =
   - Hits   2038620352  -34 
   - Misses 1964819678  +30 
   - Partials2494 2498   +4 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/4051?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=)
 | `49.64% <0.00%> (-0.71%)` | :arrow_down: |
   | 
[...va/org/apache/rocketmq/store/FlushDiskWatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0ZsdXNoRGlza1dhdGNoZXIuamF2YQ==)
 | `81.25% <0.00%> (-9.38%)` | :arrow_down: |
   | 
[...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==)
 | `38.88% <0.00%> (-5.56%)` | :arrow_down: |
   | 
[...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=)
 | `39.13% <0.00%> (-4.35%)` | :arrow_down: |
   | 
[...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=)
 | `40.17% <0.00%> (-2.29%)` | :arrow_down: |
   | 
[...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh)
 | `60.43% <0.00%> (-2.20%)` | :arrow_down: |
   | 
[.../rocketmq/broker/filter/ConsumerFilterManager.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyL0NvbnN1bWVyRmlsdGVyTWFuYWdlci5qYXZh)
 | `72.19% <0.00%> (-1.80%)` | :arrow_down: |
   | 
[...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2U

[GitHub] [rocketmq] coveralls commented on pull request #4051: [ISSUE #4050] fix origin messsage id missing from dead leetter meessage

[GitBox]

coveralls commented on pull request #4051:
URL: https://github.com/apache/rocketmq/pull/4051#issuecomment-1081443638






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4051: [ISSUE #4050] fix origin messsage id missing from dead leetter meessage

[GitBox]

codecov-commenter commented on pull request #4051:
URL: https://github.com/apache/rocketmq/pull/4051#issuecomment-1081441851


   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/4051?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#4051](https://codecov.io/gh/apache/rocketmq/pull/4051?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (30ed6c6) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/818ef2152f8e835cc907557d1e1d3da6705696ac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (818ef21) will **decrease** coverage by `0.20%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#4051  +/-   ##
   =
   - Coverage  47.93%   47.72%   -0.21% 
   + Complexity  5002 4970  -32 
   =
 Files633  633  
 Lines  4252842528  
 Branches5573 5573  
   =
   - Hits   2038620298  -88 
   - Misses 1964819726  +78 
   - Partials2494 2504  +10 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/4051?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=)
 | `49.64% <0.00%> (-0.71%)` | :arrow_down: |
   | 
[...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==)
 | `20.00% <0.00%> (-14.29%)` | :arrow_down: |
   | 
[...va/org/apache/rocketmq/store/FlushDiskWatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0ZsdXNoRGlza1dhdGNoZXIuamF2YQ==)
 | `81.25% <0.00%> (-9.38%)` | :arrow_down: |
   | 
[...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==)
 | `38.88% <0.00%> (-5.56%)` | :arrow_down: |
   | 
[...org/apache/rocketmq/store/ha/WaitNotifyObject.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL1dhaXROb3RpZnlPYmplY3QuamF2YQ==)
 | `66.07% <0.00%> (-5.36%)` | :arrow_down: |
   | 
[...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=)
 | `39.13% <0.00%> (-4.35%)` | :arrow_down: |
   | 
[...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==)
 | `59.82% <0.00%> (-2.57%)` | :arrow_down: |
   | 
[...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ

[GitHub] [rocketmq] Git-Yang closed issue #4048: Make storePathCommitLog base on storePathRootDir

[GitBox]

Git-Yang closed issue #4048:
URL: https://github.com/apache/rocketmq/issues/4048


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Git-Yang commented on issue #4048: Make storePathCommitLog base on storePathRootDir

[GitBox]

Git-Yang commented on issue #4048:
URL: https://github.com/apache/rocketmq/issues/4048#issuecomment-1081437895


   Merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Git-Yang merged pull request #4049: [ISSUE #4048] Make storePathCommitLog base on storePathRootDir

[GitBox]

Git-Yang merged pull request #4049:
URL: https://github.com/apache/rocketmq/pull/4049


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Git-Yang opened a new pull request #4051: [ISSUE #4050] fix origin messsage id missing from dead leetter meessage

[GitBox]

Git-Yang opened a new pull request #4051:
URL: https://github.com/apache/rocketmq/pull/4051


   ## What is the purpose of the change
   
   Fix #4050 
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
![image](https://user-images.githubusercontent.com/30995057/160542247-7c99bf32-4f41-4b72-82f5-7e465c7f821a.png)
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-mqtt] duhenglucky closed issue #40: increase code coverage

[GitBox]

duhenglucky closed issue #40:
URL: https://github.com/apache/rocketmq-mqtt/issues/40


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Git-Yang opened a new issue #4050: [Client] OriginMessageId missing from dead letter message

[GitBox]

Git-Yang opened a new issue #4050:
URL: https://github.com/apache/rocketmq/issues/4050


   **BUG REPORT**
   After sequential message consumption fails, originMessageId in 
sendMessageBack is overwritten.
   
![image](https://user-images.githubusercontent.com/30995057/160540590-026be9e0-51a5-4357-a890-d03f0bd5f4c0.png)
   
![image](https://user-images.githubusercontent.com/30995057/160540741-c60e539e-930a-478b-bd93-2fe9f83936fd.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #3989: #fix spelling mistakes about 'unknown'

[GitBox]

coveralls edited a comment on pull request #3989:
URL: https://github.com/apache/rocketmq/pull/3989#issuecomment-1070013992


   
   [![Coverage 
Status](https://coveralls.io/builds/47770435/badge)](https://coveralls.io/builds/47770435)
   
   Coverage decreased (-0.02%) to 51.836% when pulling 
**80d0c4cbcecba074484a17fd373d1c9db6accea8 on chunyizanchi:develop** into 
**818ef2152f8e835cc907557d1e1d3da6705696ac on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3989: #fix spelling mistakes about 'unknown'

[GitBox]

codecov-commenter edited a comment on pull request #3989:
URL: https://github.com/apache/rocketmq/pull/3989#issuecomment-1069972274


   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/3989?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#3989](https://codecov.io/gh/apache/rocketmq/pull/3989?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (80d0c4c) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/03c5a3d171eb8667a7d13409d45723005c4c22f5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (03c5a3d) will **decrease** coverage by `0.16%`.
   > The diff coverage is `33.33%`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#3989  +/-   ##
   =
   - Coverage  47.95%   47.78%   -0.17% 
   + Complexity  5004 4981  -23 
   =
 Files633  633  
 Lines  4252042528   +8 
 Branches5571 5573   +2 
   =
   - Hits   2039120323  -68 
   - Misses 1963319703  +70 
   - Partials2496 2502   +6 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/3989?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3989/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==)
 | `13.86% <0.00%> (ø)` | |
   | 
[...lient/impl/consumer/DefaultMQPullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3989/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdWxsQ29uc3VtZXJJbXBsLmphdmE=)
 | `29.76% <0.00%> (ø)` | |
   | 
[.../apache/rocketmq/common/protocol/ResponseCode.java](https://codecov.io/gh/apache/rocketmq/pull/3989/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvUmVzcG9uc2VDb2RlLmphdmE=)
 | `0.00% <ø> (ø)` | |
   | 
[...mq/client/impl/producer/DefaultMQProducerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3989/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==)
 | `45.21% <33.33%> (ø)` | |
   | 
[...ocketmq/client/producer/LocalTransactionState.java](https://codecov.io/gh/apache/rocketmq/pull/3989/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvcHJvZHVjZXIvTG9jYWxUcmFuc2FjdGlvblN0YXRlLmphdmE=)
 | `100.00% <100.00%> (ø)` | |
   | 
[...rg/apache/rocketmq/common/stats/StatsSnapshot.java](https://codecov.io/gh/apache/rocketmq/pull/3989/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNTbmFwc2hvdC5qYXZh)
 | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
   | 
[...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/3989/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==)
 | `20.00% <0.00%> (-14.29%)` | :arrow_down: |
   | 
[.../org/apache/rocketmq/store/PutMessageSpinLock.java](https://codecov.io/gh/apache/rocketmq/pull/3989/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1B1dE1lc3NhZ2VTcGluTG9jay5qYXZh)
 | `85.71% <0.00%> (-14.29%)` | :

[GitHub] [rocketmq-client-go] shendongsd closed pull request #750: [ISSUE #738] the first version of high-level-pull-consumer

[GitBox]

shendongsd closed pull request #750:
URL: https://github.com/apache/rocketmq-client-go/pull/750


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-mqtt] zongtanghu merged pull request #41: Increase test case and improve code coverage

[GitBox]

zongtanghu merged pull request #41:
URL: https://github.com/apache/rocketmq-mqtt/pull/41


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] li-xiao-shuang commented on pull request #4027: [Minor] NamesrvController code optimization

[GitBox]

li-xiao-shuang commented on pull request #4027:
URL: https://github.com/apache/rocketmq/pull/4027#issuecomment-1081334628


   > @li-xiao-shuang Is there an associated issue？
   
   There is no corresponding issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #4027: [Minor] NamesrvController code optimization

[GitBox]

RongtongJin commented on pull request #4027:
URL: https://github.com/apache/rocketmq/pull/4027#issuecomment-1081328656


   @li-xiao-shuang Is there an associated issue？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [DISCUSS] RIP-35 queue service framework(QSF)

[yukon]

Is anyone interested in this RIP? Please feel free to express your opinions.

About this RIP, my concern is that QSF encapsulates the details of the
producer/consumer may lead to troubleshooting complicated, although QSF is
simple.

Regards,
yukon

On Tue, Mar 29, 2022 at 1:43 AM Jason.Chen  wrote:

> QSF architecture diagram updated, please see attached.
>
>
>
> -- 原始邮件 --
> *发件人:* "Jason.Chen" ;
> *发送时间:* 2022年3月29日(星期二) 凌晨1:39
> *收件人:* "dev";
> *主题:* re： [DISCUSS] RIP-35 queue service framework(QSF)
>
> QSF architecture diagram updated here:
>
>
>
>
> — 原始邮件 —
> 发件人: “Jason.Chen” chenhua...@foxmail.com
> ;
> 发送时间: 2022年3月25日(星期五) 晚上11:35
> 收件人: “dev”dev@rocketmq.apache.org ;
> 主题: 回复： [DISCUSS] RIP-35 queue service framework(QSF)
>
> Sorry for posting a demo of an old version of QSF, the demo of the
> optimized QSF is as follows:
>
> //message producer
>
> @RestController
> @RequestMapping(“/demo/qsf”)
> @Slf4j
> public class TestController {
>
> @QSFConsumer(topic = "rocketmq_topic_qsf_demo", methodSpecials = {
> @QSFConsumer.ConsumerMethodSpecial(methodName = "testQSFCallback", 
> syncCall = true)
> })
> private QSFDemoService qsfDemoService;
>
> @GetMapping(("/basic"))
> public Map qsfBasic(HttpServletRequest request) {
> Map resultMap = new HashMap<>();
>
> // test QSF basic usage
> qsfDemoService.testQSFBasic(100L, "hello world");
>
> return resultMap;
> }
>
> @GetMapping(("/idem"))
> public Map qsfIdempotency(HttpServletRequest request) {
> Map resultMap = new HashMap<>();
>
> // test QSF idempotency, method with same parameters will be invoked 
> exactly once
> qsfDemoService.testQSFIdempotency(100L, "hello world");
> qsfDemoService.testQSFIdempotency(100L, "hello world");
>
> return resultMap;
> }
>
> }
>
> // message consumer
>
> @QSFProvider(consumerId = “rocketmq_consumer_qsf_demo”, topic =
> “rocketmq_topic_qsf_demo”)
> @Slf4j
> public class QSFDemoServiceImpl implements QSFDemoService {
>
> @Override
> public void testQSFBasic(long id, String name) {
> log.info("in service call: testQSFBasic id:{} name:{}", id, name);
> }
>
> @Override
> @QSFIdempotency(idempotentMethodExecuteTimeout = 1000)
> public void testQSFIdempotency(long id, String name) {
> log.info("in service call: testQSFIdempotency id:{} name:{}", id, name);
> }
>
> }
>
> — 原始邮件 —
> 发件人: “Jason.Chen” chenhua...@foxmail.com
> ;
> 发送时间: 2022年3月25日(星期五) 晚上9:25
> 收件人: “dev”dev@rocketmq.apache.org ;
> 主题: 回复： [DISCUSS] RIP-35 queue service framework(QSF)
>
> — 原始邮件 —
> 发件人: “Jason.Chen” chenhua...@foxmail.com
> ;
> 发送时间: 2022年3月16日(星期三) 晚上9:39
> 收件人: “dev”dev@rocketmq.apache.org ;
> 主题: 回复： [DISCUSS] RIP-35 queue service framework(QSF)
>
> Thanks Reply:)
>
> QSF is a step further than rocketmq-spring. Using QSF, users can get the
> most intuitive experience that is almost identical to that of local method
> calls; moreover, QSF reserves a good extension capability, which can easily
> provide features such as idempotent, eventual consistency and flow control
> and so on.
>
> For a simple usage example of QSF, please see the discussion above :)
>
> — 原始邮件 —
> 发件人: “dev” duhengfore...@apache.org
> ;
> 发送时间: 2022年3月16日(星期三) 晚上8:44
> 收件人: “dev”dev@rocketmq.apache.org ;
> 主题: Re: [DISCUSS] RIP-35 queue service framework(QSF)
>
> Nice to see this proposal of yours, but it seems a bit like what
> rocketmq-spring[1] does, so can you elaborate on the difference between QSF
> and rocketmq-spring?
>
> [1]https://github.com/apache/rocketmq-spring
>
> yukon yu...@apache.org  于2022年3月16日周三
> 20:23写道：
>
> Could you please provide some demos to show how we use
> QSFProducer/Consumer?
>
> On Wed, Mar 16, 2022 at 6:49 PM Jason.Chen chenhua...@foxmail.com
>  wrote:
>
> I am sorry that the RIP mail format is incorrect, and i write a
> well-formed google doc version here:
>
>
> https://docs.google.com/document/d/10wSe24TAls7J9y0Ql4MYo73FX8g1aX9guoxBxzQhJgg
>
> RIP 35 queue service framework(QSF)
>
> Status
>
> ●  Current State: Proposed
>
> ●  Authors: booom( booom (jason) · GitHub)
>
> ●  Shepherds: yukon( zhouxinyu (yukon) · GitHub)
>
> ●  Mailing List discussion: dev@rocketmq.apache.org
>
> ●  Pull Request:
>
> ●  Released:
>
> Background & Motivation
>
> What do we need to do
>
> ●  Will we add a new module? Yes.
>
> ●  Will we add new APIs? No.
>
> ●  Will we add new feature? Yes.
>
> Why should we do that
>
> ●  Are there any problems of our current project?
>
> The current mq client API is intrusive, to send message or consume
> mess

re?? [DISCUSS] RIP-35 queue service framework(QSF)

[Jason.Chen]

QSF architecture diagram updated, please see attached.







--  --
??: 
   "Jason.Chen" 
   
https://github.com/apache/rocketmq-spring
 
yukon yu...@apache.org ??2022??3??16?? 20:23??
  
Could you please provide some demos to show how we use
QSFProducer/Consumer?
 
On Wed, Mar 16, 2022 at 6:49 PM Jason.Chen chenhua...@foxmail.com wrote:
  
I am sorry that the RIP mail format is incorrect, and i write a
well-formed google doc version here:
 
https://docs.google.com/document/d/10wSe24TAls7J9y0Ql4MYo73FX8g1aX9guoxBxzQhJgg
 
RIP 35 queue service framework(QSF)
 
Status
 
??  Current State: Proposed
 
??  Authors: booom( booom (jason) ?? GitHub)
 
??  Shepherds: yukon( zhouxinyu (yukon) ?? GitHub)
 
??  Mailing List discussion: dev@rocketmq.apache.org
 
??  Pull Request:
 
??  Released: 
 
Background & Motivation
 
What do we need to do
 
??  Will we add a new module? Yes.
 
??  Will we add new APIs? No.
 
??  Will we add new feature? Yes.
 
Why should we do that
 
??  Are there any problems of our current project?
 
The current mq client API is intrusive, to send message or consume
message, we should code to manage the mq infrastructure, and mixed it up
with our business logic codes.
 
??  What can we benefit proposed changes?
  

Encapsulate mq client API to support method invoking style usage.
 
 

The encapsulation is easily extensible, to support
idempotence/eventually consistent/ fluid control extensions and so on.
 
 

Isolate the mq client manage code and the business logic code, to
help mq users improve their systems?? maintainability.
 
  
Goals
 
??  What problem is this proposal designed to solve?
 
Unobtrusive mq client usage, and easily extensible to support
idempotence/eventually consistent/ fluid control extensions and so on.
 
??  To what degree should we solve the problem?
 
100%.
 
Non-Goals
 
??  What problem is this proposal NOT designed to solve?
  

Add new features to classics mq client.
 
 

Affect compatibility.
 
  
??  Are there any limits of this proposal?
 
Only QSF(queue service framework) users will benefit.
 
Changes
 
Architecture
 
To simplify a process, we need to consider what information is essential
and must be provided by users to execute this process? How to properly
organize this information so that it is most user-friendly? 
 
Along this thinking path, we have extracted the necessary parameters for
mq calls and organized them into the java annotations @QSFConsumer and
@QSFProvider. After that, through the extension support of spring
container
in each stage of bean life cycle, we can process @QSFConsumer
@QSFProvider
annotation in BeanPostProcessor, extract method invocation information to
method invocation information object MethodInvokeInfo and send it out,
and
locate it through MethodInvokeInfo at the message receiving endpoint. The
bean where the call is made, the method where it is located, the
parameters
used, and then the method is called by reflection.
 
Interface Design/Change
 
??  Method signature changes
 
??      method name
 
??      parameter list
 
??      return value
 
Nothing.
 
??  Method behavior changes
 
Nothing.
 
??  CLI command changes
 
Nothing.
 
??  Log format or content changes
 
Nothing.
 
 Compatibility, Deprecation, and Migration Plan
 
??  Are backward and forward compatibility taken into
consideration?
 
Yes.
 
??  Are there deprecated APIs?
 
Nothing.
 
??  How do we do migration?
 
Upgrade normally, no additional migration required.
 
Implementation Outline
 
We will implement the proposed changes by 1 phase. (QSF is implemented
and
works well in our project)
 
Phase 1
 
Complete the QSF mq client encapsulation.
 
Complete the QSF idempotency support
 
Rejected Alternatives
 
There are no other alternatives.
 
??  ??
??:
  ??Jason.Chen??
  <
chenhua...@foxmail.com>;
: 2022??3??16??(??) 12:55
??: ??dev??

re?? [DISCUSS] RIP-35 queue service framework(QSF)

[Jason.Chen]

QSF architecture diagram updated here:








??  ??
??: 
   ??Jason.Chen??   
 
chenhua...@foxmail.com;
: 2022??3??25??(??) 11:35
??: ??dev??dev@rocketmq.apache.org;
: ?? [DISCUSS] RIP-35 queue service framework(QSF)
 
Sorry for posting a demo of an old version of QSF, the demo of the optimized 
QSF is as follows:
 
//message producer
 
@RestController
@RequestMapping(??/demo/qsf??)
@Slf4j
public class TestController {
 @QSFConsumer(topic = "rocketmq_topic_qsf_demo", methodSpecials = { 
@QSFConsumer.ConsumerMethodSpecial(methodName = "testQSFCallback", syncCall = 
true) }) private QSFDemoService qsfDemoService; @GetMapping(("/basic")) public 
Maphttps://github.com/apache/rocketmq-spring
 
yukon yu...@apache.org ??2022??3??16?? 20:23??
  
Could you please provide some demos to show how we use
QSFProducer/Consumer?
 
On Wed, Mar 16, 2022 at 6:49 PM Jason.Chen chenhua...@foxmail.com wrote:
  
I am sorry that the RIP mail format is incorrect, and i write a
well-formed google doc version here:
 
https://docs.google.com/document/d/10wSe24TAls7J9y0Ql4MYo73FX8g1aX9guoxBxzQhJgg
 
RIP 35 queue service framework(QSF)
 
Status
 
??  Current State: Proposed
 
??  Authors: booom( booom (jason) ?? GitHub)
 
??  Shepherds: yukon( zhouxinyu (yukon) ?? GitHub)
 
??  Mailing List discussion: dev@rocketmq.apache.org
 
??  Pull Request:
 
??  Released: 
 
Background & Motivation
 
What do we need to do
 
??  Will we add a new module? Yes.
 
??  Will we add new APIs? No.
 
??  Will we add new feature? Yes.
 
Why should we do that
 
??  Are there any problems of our current project?
 
The current mq client API is intrusive, to send message or consume
message, we should code to manage the mq infrastructure, and mixed it up
with our business logic codes.
 
??  What can we benefit proposed changes?
  

Encapsulate mq client API to support method invoking style usage.
 
 

The encapsulation is easily extensible, to support
idempotence/eventually consistent/ fluid control extensions and so on.
 
 

Isolate the mq client manage code and the business logic code, to
help mq users improve their systems?? maintainability.
 
  
Goals
 
??  What problem is this proposal designed to solve?
 
Unobtrusive mq client usage, and easily extensible to support
idempotence/eventually consistent/ fluid control extensions and so on.
 
??  To what degree should we solve the problem?
 
100%.
 
Non-Goals
 
??  What problem is this proposal NOT designed to solve?
  

Add new features to classics mq client.
 
 

Affect compatibility.
 
  
??  Are there any limits of this proposal?
 
Only QSF(queue service framework) users will benefit.
 
Changes
 
Architecture
 
To simplify a process, we need to consider what information is essential
and must be provided by users to execute this process? How to properly
organize this information so that it is most user-friendly? 
 
Along this thinking path, we have extracted the necessary parameters for
mq calls and organized them into the java annotations @QSFConsumer and
@QSFProvider. After that, through the extension support of spring
container
in each stage of bean life cycle, we can process @QSFConsumer
@QSFProvider
annotation in BeanPostProcessor, extract method invocation information to
method invocation information object MethodInvokeInfo and send it out,
and
locate it through MethodInvokeInfo at the message receiving endpoint. The
bean where the call is made, the method where it is located, the
parameters
used, and then the method is called by reflection.
 
Interface Design/Change
 
??  Method signature changes
 
??      method name
 
??      parameter list
 
??      return value
 
Nothing.
 
??  Method behavior changes
 
Nothing.
 
??  CLI command changes
 
Nothing.
 
??  Log format or content changes
 
Nothing.
 
 Compatibility, Deprecation, and Migration Plan
 
??  Are backward and forward compatibility taken into
consideration?
 
Yes.
 
??  Are there deprecated APIs?
 
Nothing.
 
??  How do we do migration?
 
Upgrade normally, no additional migration required.
 
Implementation Outline
 
We will implement the proposed changes by 1 phase. (QSF is implemented
and
works well in our project)
 
Phase 1
 
Complete the QSF mq client encapsulation.
 
Complete the QSF idempotency support
 
Rejected Alternatives
 
There are no other alternatives.
 
??  ??
??:
  ??Jason.Chen??
  <
chenhua...@f

[GitHub] [rocketmq] coveralls commented on pull request #4049: [ISSUE #4048] Make storePathCommitLog base on storePathRootDir

[GitBox]

coveralls commented on pull request #4049:
URL: https://github.com/apache/rocketmq/pull/4049#issuecomment-1080877660


   
   [![Coverage 
Status](https://coveralls.io/builds/4775/badge)](https://coveralls.io/builds/4775)
   
   Coverage increased (+0.02%) to 51.88% when pulling 
**73077545605c31e7a7d7ba11174fc122b33cccfa on HScarb:issue_4048** into 
**818ef2152f8e835cc907557d1e1d3da6705696ac on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #4049: [ISSUE #4048] Make storePathCommitLog base on storePathRootDir

[GitBox]

codecov-commenter edited a comment on pull request #4049:
URL: https://github.com/apache/rocketmq/pull/4049#issuecomment-1080794222


   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/4049?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#4049](https://codecov.io/gh/apache/rocketmq/pull/4049?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (7307754) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/818ef2152f8e835cc907557d1e1d3da6705696ac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (818ef21) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#4049  +/-   ##
   =
   - Coverage  47.88%   47.83%   -0.06% 
   + Complexity  4996 4989   -7 
   =
 Files633  633  
 Lines  4252842527   -1 
 Branches5573 5573  
   =
   - Hits   2036520343  -22 
   - Misses 1966319687  +24 
   + Partials2500 2497   -3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/4049?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ache/rocketmq/store/config/MessageStoreConfig.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2NvbmZpZy9NZXNzYWdlU3RvcmVDb25maWcuamF2YQ==)
 | `61.00% <ø> (-0.13%)` | :arrow_down: |
   | 
[...va/org/apache/rocketmq/store/FlushDiskWatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0ZsdXNoRGlza1dhdGNoZXIuamF2YQ==)
 | `81.25% <0.00%> (-9.38%)` | :arrow_down: |
   | 
[...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==)
 | `38.88% <0.00%> (-5.56%)` | :arrow_down: |
   | 
[...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=)
 | `39.13% <0.00%> (-4.35%)` | :arrow_down: |
   | 
[...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=)
 | `40.17% <0.00%> (-2.29%)` | :arrow_down: |
   | 
[...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==)
 | `79.70% <0.00%> (-1.49%)` | :arrow_down: |
   | 
[...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=)
 | `49.64% <0.00%> (-0.71%)` | :arrow_down: |
   | 
[...che/rocketmq/acl/plain/PlainPermissionManager.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vU

[GitHub] [rocketmq] codecov-commenter commented on pull request #4049: [ISSUE #4048] Make storePathCommitLog base on storePathRootDir

[GitBox]

codecov-commenter commented on pull request #4049:
URL: https://github.com/apache/rocketmq/pull/4049#issuecomment-1080794222


   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/4049?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#4049](https://codecov.io/gh/apache/rocketmq/pull/4049?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (7307754) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/818ef2152f8e835cc907557d1e1d3da6705696ac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (818ef21) will **decrease** coverage by `0.17%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#4049  +/-   ##
   =
   - Coverage  47.88%   47.71%   -0.18% 
   + Complexity  4996 4971  -25 
   =
 Files633  633  
 Lines  4252842527   -1 
 Branches5573 5573  
   =
   - Hits   2036520292  -73 
   - Misses 1966319733  +70 
   - Partials2500 2502   +2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/4049?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ache/rocketmq/store/config/MessageStoreConfig.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2NvbmZpZy9NZXNzYWdlU3RvcmVDb25maWcuamF2YQ==)
 | `61.00% <ø> (-0.13%)` | :arrow_down: |
   | 
[...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==)
 | `20.00% <0.00%> (-14.29%)` | :arrow_down: |
   | 
[...va/org/apache/rocketmq/store/FlushDiskWatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0ZsdXNoRGlza1dhdGNoZXIuamF2YQ==)
 | `81.25% <0.00%> (-9.38%)` | :arrow_down: |
   | 
[...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==)
 | `38.88% <0.00%> (-5.56%)` | :arrow_down: |
   | 
[...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=)
 | `39.13% <0.00%> (-4.35%)` | :arrow_down: |
   | 
[...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==)
 | `58.11% <0.00%> (-4.28%)` | :arrow_down: |
   | 
[...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=)
 | `40.17% <0.00%> (-2.29%)` | :arrow_down: |
   | 
[.../java/org/apache/rocketmq/logging/inner/Level.java](https://codecov.io/gh/apache/rocketmq/pull/4049/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9MZXZlbC5qYXZh)
 | `36.00% <0

[GitHub] [rocketmq] Oliverwqcwrw closed issue #4042: The 'store.log' print inaccurate message

[GitBox]

Oliverwqcwrw closed issue #4042:
URL: https://github.com/apache/rocketmq/issues/4042


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] ni-ze commented on a change in pull request #4019: [RIP-37] Add new APIs for consumer

[GitBox]

ni-ze commented on a change in pull request #4019:
URL: https://github.com/apache/rocketmq/pull/4019#discussion_r836386100



##
File path: 
apis/src/main/java/org/apache/rocketmq/apis/consumer/PullConsumer.java
##
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.apis.consumer;
+
+import java.io.Closeable;
+import java.time.Duration;
+import java.util.Collection;
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+
+import org.apache.rocketmq.apis.MessageQueue;
+import org.apache.rocketmq.apis.exception.*;
+import org.apache.rocketmq.apis.message.MessageView;
+
+/**
+ * PullConsumer is a thread-safe rocketmq client which is used to consume 
message by queue.
+ * Unlike push consumer and simple consumer, pull consumer implement load 
balance based on queue granularity.
+ *
+ * Pull consumer is lightweight consumer that better suited to streaming 
scenarios.
+ * If you want fully control the message consumption operation by yourself 
like scan by offset or reconsume repeatedly,
+ * pull consumer should be your first consideration.
+ *
+ * Pull consumer support two load balance mode. First is subscription mode, 
which full manage the rebalance
+ * operation triggered when group membership or cluster and topic metadata 
change.Another mode is manual assignment mode,which manage the load balance by 
yourself.
+ *
+ *  Pull consumer divide message consumption to 3 parts.
+ * Firstly, determine whether to continue processing from the last consumption 
or reset the consumption starting point by call seek method;
+ * Then, pull message from servers.
+ * At last, pull consumer no need to commit message by offset meta.
+ *  If there is a consumption error, consumer just call seek api to reset 
the offset for reconsume message again.
+ */
+public interface PullConsumer extends Closeable {
+/**
+ * Get metadata about the message queues for a given topic. This method 
will issue a remote call to the server if it
+ * does not already have any metadata about the given topic.
+ *
+ * @param topic message's topic
+ * @return message queues of topic.
+ */
+Collection topicMessageQueues(String topic) throws 
ClientException;
+
+/**
+ * Manually assign messageQueue collections to this consumer.
+ *  Pull consumer must enable manual assignment mode in {@link 
PullConsumerBuilder} first, then call assign api.
+ *  This interface does not allow for incremental assignment and will 
replace the previous assignment.
+ * If the given collection is empty, it's treated same as unsubscribe().
+ * Manual assignment through this interface will disable the consumerGroup 
management functionality
+ * and there will be no rebalance operation triggered when group 
membership or cluster and topic metadata change.
+ * @param messageQueues are the collection for current consumer.
+ * @throws ClientException when assign
+ */
+void assign(Collection messageQueues) throws ClientException;
+
+/**
+ * Add subscription expression dynamically when use subscription mode.
+ *
+ * If first {@link SubscriptionExpression} that contains topicA and 
tag1 is exists already in consumer, then
+ * second {@link SubscriptionExpression} which contains topicA and tag2, 
the result is that the second one
+ * replaces the first one instead of integrating them.
+ *
+ * @param subscriptionExpression new subscription expression to add.
+ * @return pull consumer instance.
+ */
+PullConsumer subscribe(SubscriptionExpression subscriptionExpression) 
throws ClientException;

Review comment:
   subscribe(HashSet subs) is need.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] HScarb opened a new pull request #4049: [ISSUE #4048] Make storePathCommitLog base on storePathRootDir

[GitBox]

HScarb opened a new pull request #4049:
URL: https://github.com/apache/rocketmq/pull/4049


   ## What is the purpose of the change
   
   #4048 
   
   ## Brief changelog
   
   Make storePathCommitLog base on storePathRootDir
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] HScarb opened a new issue #4048: Make storePathCommitLog base on storePathRootDir

[GitBox]

HScarb opened a new issue #4048:
URL: https://github.com/apache/rocketmq/issues/4048


   Currently `storePathCommitLog` and `storePathRootDir` are separately defined.
   
   
https://github.com/apache/rocketmq/blob/develop/store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java#L28-L35
   
   If I only set `storePathRootDir`, the `storePathCommitLog` will not change, 
so I must set it explicitly.
   
   It's better to make `storePathCommitLog` base on `storePathRootDir`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] ni-ze commented on a change in pull request #4019: [RIP-37] Add new APIs for consumer

[GitBox]

ni-ze commented on a change in pull request #4019:
URL: https://github.com/apache/rocketmq/pull/4019#discussion_r836357713



##
File path: 
apis/src/main/java/org/apache/rocketmq/apis/consumer/PullConsumer.java
##
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.apis.consumer;
+
+import java.io.Closeable;
+import java.time.Duration;
+import java.util.Collection;
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+
+import org.apache.rocketmq.apis.MessageQueue;
+import org.apache.rocketmq.apis.exception.*;
+import org.apache.rocketmq.apis.message.MessageView;
+
+/**
+ * PullConsumer is a thread-safe rocketmq client which is used to consume 
message by queue.
+ * Unlike push consumer and simple consumer, pull consumer implement load 
balance based on queue granularity.
+ *
+ * Pull consumer is lightweight consumer that better suited to streaming 
scenarios.
+ * If you want fully control the message consumption operation by yourself 
like scan by offset or reconsume repeatedly,
+ * pull consumer should be your first consideration.
+ *
+ * Pull consumer support two load balance mode. First is subscription mode, 
which full manage the rebalance
+ * operation triggered when group membership or cluster and topic metadata 
change.Another mode is manual assignment mode,which manage the load balance by 
yourself.
+ *
+ *  Pull consumer divide message consumption to 3 parts.
+ * Firstly, determine whether to continue processing from the last consumption 
or reset the consumption starting point by call seek method;
+ * Then, pull message from servers.
+ * At last, pull consumer no need to commit message by offset meta.
+ *  If there is a consumption error, consumer just call seek api to reset 
the offset for reconsume message again.
+ */
+public interface PullConsumer extends Closeable {
+/**
+ * Get metadata about the message queues for a given topic. This method 
will issue a remote call to the server if it
+ * does not already have any metadata about the given topic.
+ *
+ * @param topic message's topic
+ * @return message queues of topic.
+ */
+Collection topicMessageQueues(String topic) throws 
ClientException;
+
+/**
+ * Manually assign messageQueue collections to this consumer.
+ *  Pull consumer must enable manual assignment mode in {@link 
PullConsumerBuilder} first, then call assign api.
+ *  This interface does not allow for incremental assignment and will 
replace the previous assignment.
+ * If the given collection is empty, it's treated same as unsubscribe().
+ * Manual assignment through this interface will disable the consumerGroup 
management functionality
+ * and there will be no rebalance operation triggered when group 
membership or cluster and topic metadata change.
+ * @param messageQueues are the collection for current consumer.
+ * @throws ClientException when assign
+ */
+void assign(Collection messageQueues) throws ClientException;
+
+/**
+ * Add subscription expression dynamically when use subscription mode.
+ *
+ * If first {@link SubscriptionExpression} that contains topicA and 
tag1 is exists already in consumer, then
+ * second {@link SubscriptionExpression} which contains topicA and tag2, 
the result is that the second one
+ * replaces the first one instead of integrating them.
+ *
+ * @param subscriptionExpression new subscription expression to add.
+ * @return pull consumer instance.
+ */
+PullConsumer subscribe(SubscriptionExpression subscriptionExpression) 
throws ClientException;
+
+/**
+ * Remove subscription expression dynamically by topic.
+ *
+ * Nothing occurs if the specified topic does not exist in subscription 
expressions of pull consumer.
+ *
+ * @param topic the topic to remove subscription.
+ * @return pull consumer instance.
+ */
+PullConsumer unsubscribe(String topic) throws ClientException;
+
+/**
+ * Get the collection of messageQueues currently assigned to current 
consumer.
+ * @return the collection of messageQueues currently assigned to current 
consumer
+ 

[GitHub] [rocketmq] ni-ze commented on a change in pull request #4019: [RIP-37] Add new APIs for consumer

[GitBox]

ni-ze commented on a change in pull request #4019:
URL: https://github.com/apache/rocketmq/pull/4019#discussion_r836354555



##
File path: 
apis/src/main/java/org/apache/rocketmq/apis/consumer/PullConsumer.java
##
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.apis.consumer;
+
+import java.io.Closeable;
+import java.time.Duration;
+import java.util.Collection;
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+
+import org.apache.rocketmq.apis.MessageQueue;
+import org.apache.rocketmq.apis.exception.*;
+import org.apache.rocketmq.apis.message.MessageView;
+
+/**
+ * PullConsumer is a thread-safe rocketmq client which is used to consume 
message by queue.
+ * Unlike push consumer and simple consumer, pull consumer implement load 
balance based on queue granularity.
+ *
+ * Pull consumer is lightweight consumer that better suited to streaming 
scenarios.
+ * If you want fully control the message consumption operation by yourself 
like scan by offset or reconsume repeatedly,
+ * pull consumer should be your first consideration.
+ *
+ * Pull consumer support two load balance mode. First is subscription mode, 
which full manage the rebalance
+ * operation triggered when group membership or cluster and topic metadata 
change.Another mode is manual assignment mode,which manage the load balance by 
yourself.
+ *
+ *  Pull consumer divide message consumption to 3 parts.
+ * Firstly, determine whether to continue processing from the last consumption 
or reset the consumption starting point by call seek method;
+ * Then, pull message from servers.
+ * At last, pull consumer no need to commit message by offset meta.
+ *  If there is a consumption error, consumer just call seek api to reset 
the offset for reconsume message again.
+ */
+public interface PullConsumer extends Closeable {
+/**
+ * Get metadata about the message queues for a given topic. This method 
will issue a remote call to the server if it
+ * does not already have any metadata about the given topic.
+ *
+ * @param topic message's topic
+ * @return message queues of topic.
+ */
+Collection topicMessageQueues(String topic) throws 
ClientException;
+
+/**
+ * Manually assign messageQueue collections to this consumer.
+ *  Pull consumer must enable manual assignment mode in {@link 
PullConsumerBuilder} first, then call assign api.
+ *  This interface does not allow for incremental assignment and will 
replace the previous assignment.
+ * If the given collection is empty, it's treated same as unsubscribe().
+ * Manual assignment through this interface will disable the consumerGroup 
management functionality
+ * and there will be no rebalance operation triggered when group 
membership or cluster and topic metadata change.
+ * @param messageQueues are the collection for current consumer.
+ * @throws ClientException when assign
+ */
+void assign(Collection messageQueues) throws ClientException;
+
+/**
+ * Add subscription expression dynamically when use subscription mode.
+ *
+ * If first {@link SubscriptionExpression} that contains topicA and 
tag1 is exists already in consumer, then
+ * second {@link SubscriptionExpression} which contains topicA and tag2, 
the result is that the second one
+ * replaces the first one instead of integrating them.
+ *
+ * @param subscriptionExpression new subscription expression to add.
+ * @return pull consumer instance.
+ */
+PullConsumer subscribe(SubscriptionExpression subscriptionExpression) 
throws ClientException;
+
+/**
+ * Remove subscription expression dynamically by topic.
+ *
+ * Nothing occurs if the specified topic does not exist in subscription 
expressions of pull consumer.
+ *
+ * @param topic the topic to remove subscription.
+ * @return pull consumer instance.
+ */
+PullConsumer unsubscribe(String topic) throws ClientException;
+
+/**
+ * Get the collection of messageQueues currently assigned to current 
consumer.
+ * @return the collection of messageQueues currently assigned to current 
consumer
+ 

[GitHub] [rocketmq] ni-ze commented on a change in pull request #4019: [RIP-37] Add new APIs for consumer

[GitBox]

ni-ze commented on a change in pull request #4019:
URL: https://github.com/apache/rocketmq/pull/4019#discussion_r836347205



##
File path: 
apis/src/main/java/org/apache/rocketmq/apis/consumer/PushConsumer.java
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.apis.consumer;
+
+import com.google.common.util.concurrent.Service;
+import java.io.Closeable;
+import java.util.Collection;
+
+import org.apache.rocketmq.apis.exception.*;
+
+/**
+ * PushConsumer is a thread-safe rocketmq client which is used to consume 
message by group.
+ *
+ * Push consumer is fully-managed consumer, if you are confused to choose 
your consumer, push consumer should be
+ * your first consideration.
+ *
+ * Consumers belong to the same consumer group share messages from server,
+ * so consumer in the same group must have the same {@link 
SubscriptionExpression}s, otherwise the behavior is
+ * undefined. If a new consumer group's consumer is started first time, it 
consumes from the latest position. Once
+ * consumer is started, server records its consumption progress and derives it 
in subsequent startup.
+ *
+ * You may intend to maintain different consumption progress for different 
consumer, different consumer group
+ * should be set in this case.
+ *
+ * To accelerate the message consumption, push consumer applies
+ * https://en.wikipedia.org/wiki/Reactive_Streams";>reactive 
streams
+ * . Messages received from server is cached locally before consumption,
+ * {@link PushConsumerBuilder#setMaxCacheMessageCount(int)} and
+ * {@link PushConsumerBuilder#setMaxCacheMessageSizeInBytes(int)} could be 
used to set the cache threshold in
+ * different dimension.
+ */
+public interface PushConsumer extends Closeable {
+/**
+ * Get the load balancing group for consumer.
+ *
+ * @return consumer load balancing group.
+ */
+String getConsumerGroup();
+
+/**
+ * Get the existed subscription expression in push consumer.
+ *
+ * @return collections of subscription expression.
+ */
+Collection listSubscriptionExpression();
+
+/**
+ * Add subscription expression dynamically.
+ *
+ * If first {@link SubscriptionExpression} that contains topicA and 
tag1 is exists already in consumer, then
+ * second {@link SubscriptionExpression} which contains topicA and tag2, 
the result is that the second one
+ * replaces the first one instead of integrating them.
+ *
+ * @param subscriptionExpression new subscription expression to add.
+ * @return push consumer instance.
+ */
+PushConsumer subscribe(SubscriptionExpression subscriptionExpression) 
throws ClientException;
+
+/**
+ * Remove subscription expression dynamically by topic.
+ *
+ * It stops the backend task to fetch message from remote, and besides 
that, the local cached message whose topic
+ * was removed before would not be delivered to {@link MessageListener} 
anymore.
+ *
+ * Nothing occurs if the specified topic does not exist in subscription 
expressions of push consumer.
+ *
+ * @param topic the topic to remove subscription.
+ * @return push consumer instance.
+ */
+PushConsumer unsubscribe(String topic) throws ClientException;
+
+/**
+ * Close the push consumer and release all related resources.
+ *
+ * Once push consumer is closed, it could not be started once 
again. we maintained an FSM
+ * (finite-state machine) to record the different states for each 
producer, which is similar to
+ * {@link Service.State}.
+ */

Review comment:
   When we use subscribe mode, client will rebalance and poll messages from 
messageQueue into local buffer. MessageListener will be invoked after this 
relationship change, and start task to pull message.
   On the other hand,  app wants to be notify once the queue it consumes is 
determined, init app with messageQueue, messageListener will be used in this 
scene.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr.

[GitHub] [rocketmq] ni-ze commented on a change in pull request #4019: [RIP-37] Add new APIs for consumer

[GitBox]

ni-ze commented on a change in pull request #4019:
URL: https://github.com/apache/rocketmq/pull/4019#discussion_r836347205



##
File path: 
apis/src/main/java/org/apache/rocketmq/apis/consumer/PushConsumer.java
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.apis.consumer;
+
+import com.google.common.util.concurrent.Service;
+import java.io.Closeable;
+import java.util.Collection;
+
+import org.apache.rocketmq.apis.exception.*;
+
+/**
+ * PushConsumer is a thread-safe rocketmq client which is used to consume 
message by group.
+ *
+ * Push consumer is fully-managed consumer, if you are confused to choose 
your consumer, push consumer should be
+ * your first consideration.
+ *
+ * Consumers belong to the same consumer group share messages from server,
+ * so consumer in the same group must have the same {@link 
SubscriptionExpression}s, otherwise the behavior is
+ * undefined. If a new consumer group's consumer is started first time, it 
consumes from the latest position. Once
+ * consumer is started, server records its consumption progress and derives it 
in subsequent startup.
+ *
+ * You may intend to maintain different consumption progress for different 
consumer, different consumer group
+ * should be set in this case.
+ *
+ * To accelerate the message consumption, push consumer applies
+ * https://en.wikipedia.org/wiki/Reactive_Streams";>reactive 
streams
+ * . Messages received from server is cached locally before consumption,
+ * {@link PushConsumerBuilder#setMaxCacheMessageCount(int)} and
+ * {@link PushConsumerBuilder#setMaxCacheMessageSizeInBytes(int)} could be 
used to set the cache threshold in
+ * different dimension.
+ */
+public interface PushConsumer extends Closeable {
+/**
+ * Get the load balancing group for consumer.
+ *
+ * @return consumer load balancing group.
+ */
+String getConsumerGroup();
+
+/**
+ * Get the existed subscription expression in push consumer.
+ *
+ * @return collections of subscription expression.
+ */
+Collection listSubscriptionExpression();
+
+/**
+ * Add subscription expression dynamically.
+ *
+ * If first {@link SubscriptionExpression} that contains topicA and 
tag1 is exists already in consumer, then
+ * second {@link SubscriptionExpression} which contains topicA and tag2, 
the result is that the second one
+ * replaces the first one instead of integrating them.
+ *
+ * @param subscriptionExpression new subscription expression to add.
+ * @return push consumer instance.
+ */
+PushConsumer subscribe(SubscriptionExpression subscriptionExpression) 
throws ClientException;
+
+/**
+ * Remove subscription expression dynamically by topic.
+ *
+ * It stops the backend task to fetch message from remote, and besides 
that, the local cached message whose topic
+ * was removed before would not be delivered to {@link MessageListener} 
anymore.
+ *
+ * Nothing occurs if the specified topic does not exist in subscription 
expressions of push consumer.
+ *
+ * @param topic the topic to remove subscription.
+ * @return push consumer instance.
+ */
+PushConsumer unsubscribe(String topic) throws ClientException;
+
+/**
+ * Close the push consumer and release all related resources.
+ *
+ * Once push consumer is closed, it could not be started once 
again. we maintained an FSM
+ * (finite-state machine) to record the different states for each 
producer, which is similar to
+ * {@link Service.State}.
+ */

Review comment:
   When we use subscribe mode, client will rebalance and poll messages from 
messageQueue into local buffer. MessageListener will be invoked after this 
relationship change, and start task to pull message.
   On the other hand,  app wants to be notify once the queue it consumes is 
determined, init it use messageQueue, messageListener will be used in this 
scene.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...

[GitHub] [rocketmq-operator] duhenglucky closed issue #60: Add features to the broker and nameserver

[GitBox]

duhenglucky closed issue #60:
URL: https://github.com/apache/rocketmq-operator/issues/60


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] duhenglucky merged pull request #90: Fea: add imagePullSecret for Broker/Nameservice/Console

[GitBox]

duhenglucky merged pull request #90:
URL: https://github.com/apache/rocketmq-operator/pull/90


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] StevenLeiZhang commented on pull request #90: Fea: add imagePullSecret for Broker/Nameservice/Console

[GitBox]

StevenLeiZhang commented on pull request #90:
URL: https://github.com/apache/rocketmq-operator/pull/90#issuecomment-1080493294


   > @StevenLeiZhang Would you like to resolve conflicts first? we will merge 
this PR ASAP.
   
   rebased branch master and resolved conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] StevenLeiZhang removed a comment on pull request #90: Fea: add imagePullSecret for Broker/Nameservice/Console

[GitBox]

StevenLeiZhang removed a comment on pull request #90:
URL: https://github.com/apache/rocketmq-operator/pull/90#issuecomment-1080493057


   > #60
   
   rebased branch master and resolved conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] StevenLeiZhang commented on pull request #90: Fea: add imagePullSecret for Broker/Nameservice/Console

[GitBox]

StevenLeiZhang commented on pull request #90:
URL: https://github.com/apache/rocketmq-operator/pull/90#issuecomment-1080493057


   > #60
   
   rebased branch master and resolved conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-exporter] codecov-commenter commented on pull request #100: fix: ignored latency for boardcast consumer

[GitBox]

codecov-commenter commented on pull request #100:
URL: 
https://github.com/apache/rocketmq-exporter/pull/100#issuecomment-1080486642


   # 
[Codecov](https://codecov.io/gh/apache/rocketmq-exporter/pull/100?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#100](https://codecov.io/gh/apache/rocketmq-exporter/pull/100?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (e0709f5) into 
[master](https://codecov.io/gh/apache/rocketmq-exporter/commit/8bc34bcc58f36499f3a35275551bfbe9f5be183d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (8bc34bc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@ Coverage Diff @@
   ## master#100  +/-   ##
   ===
   - Coverage  0.35%   0.35%   -0.01% 
 Complexity2   2  
   ===
 Files30  30  
 Lines  22422243   +1 
 Branches195 196   +1 
   ===
 Hits  8   8  
   - Misses 22342235   +1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq-exporter/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...che/rocketmq/exporter/task/MetricsCollectTask.java](https://codecov.io/gh/apache/rocketmq-exporter/pull/100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2V4cG9ydGVyL3Rhc2svTWV0cmljc0NvbGxlY3RUYXNrLmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/rocketmq-exporter/pull/100?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/rocketmq-exporter/pull/100?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[8bc34bc...e0709f5](https://codecov.io/gh/apache/rocketmq-exporter/pull/100?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-client-cpp] bigboysun opened a new issue #411: Thread 5 "networkTP" received signal SIGABRT, Aborted.

[GitBox]

bigboysun opened a new issue #411:
URL: https://github.com/apache/rocketmq-client-cpp/issues/411


   stack as follow:
   
   #0  0x7f4044b36277 in raise () from /lib64/libc.so.6
   
   #1  0x7f4044b37968 in abort () from /lib64/libc.so.6
   
   #2  0x7f4037d5 in __gnu_cxx::__verbose_terminate_handler() () from 
/lib64/libstdc++.so.6
   
   #3  0x7f401746 in ?? () from /lib64/libstdc++.so.6
   
   #4  0x7f401773 in std::terminate() () from /lib64/libstdc++.so.6
   
   #5  0x7f4019e9 in __cxa_rethrow () from /lib64/libstdc++.so.6
   
   #6  0x7f4033b2c757 in 
boost::iostreams::detail::chain_base, std::allocator >, char, 
std::char_traits, std::allocator, boost::iostreams::output>::closer 
boost::iostreams::detail::execute_foreach>*>, 
boost::iostreams::detail::chain_base, std::allocator >, char, 
std::char_traits, std::allocator, 
boost::iostreams::output>::closer>(std::_List_iterator >*>, 
std::_List_iterator >*>, 
boost::iostreams::detail::chain_base, std::allocator >, char, 
std::char_traits, std::alloca
 tor, boost::iostreams::output>::closer) () from 
/usr/lib64/python2.7/site-packages/rocketmq/librocketmq.so
   
   #7  0x7f4033b2d030 in 
boost::iostreams::detail::chain_base, std::allocator >, char, 
std::char_traits, std::allocator, 
boost::iostreams::output>::chain_impl::close() () from 
/usr/lib64/python2.7/site-packages/rocketmq/librocketmq.so
   
   #8  0x7f4033b2d155 in 
boost::iostreams::detail::chain_base, std::allocator >, char, 
std::char_traits, std::allocator, boost::iostreams::output>::pop() 
()
   
  from /usr/lib64/python2.7/site-packages/rocketmq/librocketmq.so
   
   #9  0x7f4033b281fb in rocketmq::UtilAll::inflate(std::string&, 
std::string&) ()
   
  from /usr/lib64/python2.7/site-packages/rocketmq/librocketmq.so
   
   #10 0x7f4033b14eeb in 
rocketmq::MQDecoder::decode(rocketmq::MemoryInputStream&, bool) ()
   
  from /usr/lib64/python2.7/site-packages/rocketmq/librocketmq.so
   
   ---Type  to continue, or q  to quit---
   
   #11 0x7f4033b1508c in rocketmq::MQDecoder::decodes(rocketmq::MemoryBlock 
const*, std::vector >&, bool) () from 
/usr/lib64/python2.7/site-packages/rocketmq/librocketmq.so
   
   #12 0x7f4033b4110b in 
rocketmq::PullAPIWrapper::processPullResult(rocketmq::MQMessageQueue const&, 
rocketmq::PullResult*, rocketmq::SubscriptionData*) ()
   
  from /usr/lib64/python2.7/site-packages/rocketmq/librocketmq.so
   
   #13 0x7f4033b2f4b4 in 
rocketmq::PullCallbackWarp::operationComplete(rocketmq::ResponseFuture*, bool) 
()
   
  from /usr/lib64/python2.7/site-packages/rocketmq/librocketmq.so
   
   #14 0x7f4033b8cc64 in 
rocketmq::TcpRemotingClient::ProcessData(rocketmq::MemoryBlock const&, 
std::string const&) ()
   
  from /usr/lib64/python2.7/site-packages/rocketmq/librocketmq.so
   
   #15 0x7f4033b8daa9 in 
boost::asio::detail::completion_handler, 
boost::_bi::list3, 
boost::_bi::value, boost::_bi::value > > 
>::do_complete(boost::asio::detail::task_io_service*, 
boost::asio::detail::task_io_service_operation*, boost::system::error_code 
const&, unsigned long) () from 
/usr/lib64/python2.7/site-packages/rocketmq/librocketmq.so
   
   #16 0x7f4033b2a9f1 in 
boost::asio::detail::task_io_service::run(boost::system::error_code&) () from 
/usr/lib64/python2.7/site-packages/rocketmq/librocketmq.so
   
   #17 0x7f4033b47016 in boost::asio::io_service::run() () from 
/usr/lib64/python2.7/site-packages/rocketmq/librocketmq.so
   
   #18 0x7f4033be3c3f in thread_proxy () from 
/usr/lib64/python2.7/site-packages/rocketmq/librocketmq.so
   
   #19 0x7f40455dee25 in start_thread () from /lib64/libpthread.so.0
   
   #20 0x7f4044bfdf1d in clone () from /lib64/libc.so.6


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-apis] aaron-ai commented on a change in pull request #15: Refactor the response common

[GitBox]

aaron-ai commented on a change in pull request #15:
URL: https://github.com/apache/rocketmq-apis/pull/15#discussion_r836246155



##
File path: apache/rocketmq/v2/service.proto
##
@@ -31,13 +31,54 @@ option java_generate_equals_and_hash = true;
 option java_string_check_utf8 = true;
 option java_outer_classname = "MQService";
 
+enum ResponseCode {
+  // Success.
+  OK = 0;
+  // Aceess point in not specified in request.
+  ACCESS_POINT_NOT_SPECIFIED = 1;
+  // Format of topic is illegal.
+  ILLEGAL_TOPIC = 2;
+  // Format of consumer group is illegal.
+  ILLEGAL_CONSUMER_GROUP = 3;
+  // Format of message tag is illegal.
+  ILLEGAL_MESSAGE_TAG = 4;
+  // Format of message key is illegal.
+  ILLEGAL_MESSAGE_KEY = 5;
+  // Size of message keys exceeds the threshold.
+  MESSAGE_KEYS_TOO_LARGE = 6;
+  // Format of message group is illegal.
+  ILLEGAL_MESSAGE_GROUP = 7;
+  // Format of message property key is illegal.
+  ILLEGAL_MESSAGE_PROPERTY_KEY = 8;
+  // Message properties total size exceeds the threshold.
+  MESSAGE_PROPERTY_TOO_LARGE = 9;
+  // Message body size exceeds the threshold.
+  MESSAGE_BODY_TOO_LARGE = 10;
+  // User does have the permission to operate.
+  REQUEST_AUTHORISATION_FAILURE = 11;
+  // User's identity could not be recognized.
+  REQUEST_AUTHENTICATION_FAILURE = 12;
+  // Topic resource does not exist.
+  TOPIC_DOES_NOT_EXIST = 13;
+  // Consumer group resource does not exist.
+  CONSUMER_GROUP_DOES_NOT_EXIST = 14;
+  // Current operation is not supported by responder.
+  OPERATION_NOT_SUPPORTED = 15;
+  // Failure to consume message.
+  FAILED_TO_CONSUME_MESSAGE = 16;
+  // Message is corrupted.
+  MESSAGE_CORRUPTED = 17;
+  // Flow control.
+  FLOW_CONTROL = 18;
+  // Request is expired.
+  REQUEST_EXPIRED = 19;
+  // Message type is not matched.
+  MESSAGE_TYPE_NOT_MATCHED = 20;
+}
+
 message ResponseCommon {

Review comment:
   Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-apis] lizhanhui merged pull request #15: Refactor the response common

[GitBox]

lizhanhui merged pull request #15:
URL: https://github.com/apache/rocketmq-apis/pull/15


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-apis] lizhanhui commented on a change in pull request #15: Refactor the response common

[GitBox]

lizhanhui commented on a change in pull request #15:
URL: https://github.com/apache/rocketmq-apis/pull/15#discussion_r836160634



##
File path: apache/rocketmq/v2/service.proto
##
@@ -31,13 +31,54 @@ option java_generate_equals_and_hash = true;
 option java_string_check_utf8 = true;
 option java_outer_classname = "MQService";
 
+enum ResponseCode {
+  // Success.
+  OK = 0;
+  // Aceess point in not specified in request.
+  ACCESS_POINT_NOT_SPECIFIED = 1;
+  // Format of topic is illegal.
+  ILLEGAL_TOPIC = 2;
+  // Format of consumer group is illegal.
+  ILLEGAL_CONSUMER_GROUP = 3;
+  // Format of message tag is illegal.
+  ILLEGAL_MESSAGE_TAG = 4;
+  // Format of message key is illegal.
+  ILLEGAL_MESSAGE_KEY = 5;
+  // Size of message keys exceeds the threshold.
+  MESSAGE_KEYS_TOO_LARGE = 6;
+  // Format of message group is illegal.
+  ILLEGAL_MESSAGE_GROUP = 7;
+  // Format of message property key is illegal.
+  ILLEGAL_MESSAGE_PROPERTY_KEY = 8;
+  // Message properties total size exceeds the threshold.
+  MESSAGE_PROPERTY_TOO_LARGE = 9;
+  // Message body size exceeds the threshold.
+  MESSAGE_BODY_TOO_LARGE = 10;
+  // User does have the permission to operate.
+  REQUEST_AUTHORISATION_FAILURE = 11;
+  // User's identity could not be recognized.
+  REQUEST_AUTHENTICATION_FAILURE = 12;
+  // Topic resource does not exist.
+  TOPIC_DOES_NOT_EXIST = 13;
+  // Consumer group resource does not exist.
+  CONSUMER_GROUP_DOES_NOT_EXIST = 14;
+  // Current operation is not supported by responder.
+  OPERATION_NOT_SUPPORTED = 15;
+  // Failure to consume message.
+  FAILED_TO_CONSUME_MESSAGE = 16;
+  // Message is corrupted.
+  MESSAGE_CORRUPTED = 17;
+  // Flow control.
+  FLOW_CONTROL = 18;
+  // Request is expired.
+  REQUEST_EXPIRED = 19;
+  // Message type is not matched.
+  MESSAGE_TYPE_NOT_MATCHED = 20;
+}
+
 message ResponseCommon {

Review comment:
   Rename it to Status?

##
File path: apache/rocketmq/v2/service.proto
##
@@ -31,13 +31,54 @@ option java_generate_equals_and_hash = true;
 option java_string_check_utf8 = true;
 option java_outer_classname = "MQService";
 
+enum ResponseCode {

Review comment:
   IMO, we should divide error code into different ranges, similar to 
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-dashboard] chaoxcc commented on issue #47: maven打包报错

[GitBox]

chaoxcc commented on issue #47:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/47#issuecomment-1080434788


   你好 我也遇到相同的问题 是怎么解决的呢~
   [错误] 无法在项目 rocketmq-dashboard 上执行目标 
com.github.eirslett:frontend-maven-plugin:1.11.3:yarn (yarn 
install)：无法运行任务：“yarn install”失败。org.apache.commons.exec.ExecuteException: 
Process exited with an error: 1 (Exit value: 1) -> [Help 1]
   yurn 版本   1.22.18


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-exporter] qsrg commented on issue #99: The metric of consumer latency should ignored for boardcast consumer

[GitBox]

qsrg commented on issue #99:
URL: 
https://github.com/apache/rocketmq-exporter/issues/99#issuecomment-1080379307


   I have solved it #100 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-exporter] qsrg opened a new pull request #100: fix: ignored latency for boardcast consumer

[GitBox]

qsrg opened a new pull request #100:
URL: https://github.com/apache/rocketmq-exporter/pull/100


   Get consumer latency when messageModel is clustering


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-exporter] qsrg opened a new issue #99: The metric of consumer latency should ignored for boardcast consumer

[GitBox]

qsrg opened a new issue #99:
URL: https://github.com/apache/rocketmq-exporter/issues/99


   As boardcast consumer's offset would not report to broker，so calculate the 
latency according to the offset of the consumer's and broker's is meaningless 
for broadcast consumers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] HScarb closed pull request #4034: [ISSUE #4033] Skip resending async deliver schedule message when service is not available

[GitBox]

HScarb closed pull request #4034:
URL: https://github.com/apache/rocketmq/pull/4034


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] HScarb commented on pull request #4045: [ISSUE #4033] fix async deliver msg will resend forever when serivce not avliable

[GitBox]

HScarb commented on pull request #4045:
URL: https://github.com/apache/rocketmq/pull/4045#issuecomment-1080359065


   After testing, the problem does not occur again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-dashboard] jeasonlyo commented on issue #80: 为什么部署到Linux

[GitBox]

jeasonlyo commented on issue #80:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/80#issuecomment-1080330969


   
![image](https://user-images.githubusercontent.com/37092708/160354079-03f06fa6-106a-412a-bca1-566643d12ffa.png)
   在linux虚拟机的主机能够正常访问，另外一台机器不行。
   
![image](https://user-images.githubusercontent.com/37092708/160354759-f3ef32f9-49b5-4d89-9113-d1138b385cdf.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-dashboard] jeasonlyo opened a new issue #80: 为什么部署到Linux

[GitBox]

jeasonlyo opened a new issue #80:
URL: https://github.com/apache/rocketmq-dashboard/issues/80


   The issue tracker is **ONLY** used for bug report and feature request. 
   
   Any question or RocketMQ proposal please use our [mailing 
lists](http://rocketmq.apache.org/about/contact/).
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   - What did you do (The steps to reproduce)?
   
   - What did you expect to see?
   
   - What did you see instead?
   
   2. Please tell us about your environment:
   
   3. Other information (e.g. detailed explanation, logs, related issues, 
suggestions how to fix, etc):
   
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   2. Indicate the importance of this issue to you (blocker, must-have, 
should-have, nice-to-have). Are you currently using any workarounds to address 
this issue?
   
   4. If there are some sub-tasks using -[] for each subtask and create a 
corresponding issue to map to the sub task:
   
   - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 
description here, 
   - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 
description here,
   - ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] dongeforever commented on issue #4033: [ScheduleMessage] Async deliver message will resend forever when service not avaliable

[GitBox]

dongeforever commented on issue #4033:
URL: https://github.com/apache/rocketmq/issues/4033#issuecomment-1080316004


   Yeah, Futures are not infinitely nested.  The putMessage will create a 
future internally, and the newly created future will timeout and resend again.
   
   It seems ok to do the retry in HandlePutResultTask.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Git-Yang edited a comment on issue #4033: [ScheduleMessage] Async deliver message will resend forever when service not avaliable

[GitBox]

Git-Yang edited a comment on issue #4033:
URL: https://github.com/apache/rocketmq/issues/4033#issuecomment-1080307017


   > @HScarb Skip the message will cause message loss.
   > 
   > The root cause of this problem is the infinite recursion of handleResult().
   > 
   > PutResultProcess.thenProcess is like the below:
   > 
   > ```
   > this.future.thenAccept(result -> {
   > this.handleResult(result);
   > });
   > ```
   > 
   > The core problem is when to call the "thenAccept ".
   > 
   > If the "thenAccept" is called by the background thread(for example, in 
dledger mode, by the QuorumAckChecker) and get an error, the handleResult will 
resend the message and get a new future.
   > 
   > As the future needs to be completed one by one. At this time, the old 
future will depend on the new future to complete, and the new future depend on 
the old future too.
   > 
   > It will cause a deadlock.
   > 
   > @Git-Yang @duhengforever Please help a check.
   > 
   > The suggested solution is to use a new thread to execute the callback 
instead of in the "ack thread"(GroupCommitService or QuorumAckChecker).
   
   The handleResult will resend the message, bug not get a new future. 
Resending is via putMessage(), so Futrues are not infinitely nested.
   I think, to avoid infinite recursion, the retry logic is no longer executed 
in onException() , but in HandlePutResultTask .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Git-Yang removed a comment on issue #4033: [ScheduleMessage] Async deliver message will resend forever when service not avaliable

[GitBox]

Git-Yang removed a comment on issue #4033:
URL: https://github.com/apache/rocketmq/issues/4033#issuecomment-1080306792


   > 
   The handleResult will resend the message, bug not get a new future.
   I think, to avoid infinite recursion, the retry logic is no longer executed 
in onException() , but in HandlePutResultTask .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Git-Yang commented on issue #4033: [ScheduleMessage] Async deliver message will resend forever when service not avaliable

[GitBox]

Git-Yang commented on issue #4033:
URL: https://github.com/apache/rocketmq/issues/4033#issuecomment-1080307017


   > @HScarb Skip the message will cause message loss.
   > 
   > The root cause of this problem is the infinite recursion of handleResult().
   > 
   > PutResultProcess.thenProcess is like the below:
   > 
   > ```
   > this.future.thenAccept(result -> {
   > this.handleResult(result);
   > });
   > ```
   > 
   > The core problem is when to call the "thenAccept ".
   > 
   > If the "thenAccept" is called by the background thread(for example, in 
dledger mode, by the QuorumAckChecker) and get an error, the handleResult will 
resend the message and get a new future.
   > 
   > As the future needs to be completed one by one. At this time, the old 
future will depend on the new future to complete, and the new future depend on 
the old future too.
   > 
   > It will cause a deadlock.
   > 
   > @Git-Yang @duhengforever Please help a check.
   > 
   > The suggested solution is to use a new thread to execute the callback 
instead of in the "ack thread"(GroupCommitService or QuorumAckChecker).
   
   The handleResult will resend the message, bug not get a new future.
   I think, to avoid infinite recursion, the retry logic is no longer executed 
in onException() , but in HandlePutResultTask .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Git-Yang commented on issue #4033: [ScheduleMessage] Async deliver message will resend forever when service not avaliable

[GitBox]

Git-Yang commented on issue #4033:
URL: https://github.com/apache/rocketmq/issues/4033#issuecomment-1080306792


   > 
   The handleResult will resend the message, bug not get a new future.
   I think, to avoid infinite recursion, the retry logic is no longer executed 
in onException() , but in HandlePutResultTask .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Git-Yang commented on pull request #4045: [ISSUE #4033] fix async deliver msg will resend forever when serivce not avliable

[GitBox]

Git-Yang commented on pull request #4045:
URL: https://github.com/apache/rocketmq/pull/4045#issuecomment-1080292092


   @dongeforever I fixed it by this way, can you help me to check?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] dongeforever edited a comment on issue #4033: [ScheduleMessage] Async deliver message will resend forever when service not avaliable

[GitBox]

dongeforever edited a comment on issue #4033:
URL: https://github.com/apache/rocketmq/issues/4033#issuecomment-1080286798


   @HScarb Skip the message will cause message loss.
   
   The root cause of this problem is the infinite recursion of handleResult().
   
   PutResultProcess.thenProcess  is like the below:
   ```
   this.future.thenAccept(result -> {
   this.handleResult(result);
   });
   ```
   The core problem is when to call the "thenAccept ".
   
   If the "thenAccept"  is called by the background thread(for example, in 
dledger mode,  by the QuorumAckChecker) and get an error, the handleResult will 
resend the message and get a new future.
   
   As the future needs to be completed one by one.
   At this time, the old future will depend on the new future to complete, and 
the new future depend on the old future too.
   
   It will cause a deadlock.
   
   @Git-Yang  @duhengforever Please help a check.
   
   The suggested solution is to use a new thread to execute the callback 
instead of in the "ack thread"(GroupCommitService or QuorumAckChecker).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] dongeforever commented on issue #4033: [ScheduleMessage] Async deliver message will resend forever when service not avaliable

[GitBox]

dongeforever commented on issue #4033:
URL: https://github.com/apache/rocketmq/issues/4033#issuecomment-1080286798


   @HScarb Skip the message will cause message loss.
   
   The root cause of this problem is the infinite recursion of handleResult().
   
   PutResultProcess.thenProcess  is like the below:
   ```
   this.future.thenAccept(result -> {
   this.handleResult(result);
   });
   ```
   The core problem is when to call the "thenAccept ".
   
   If the "thenAccepth"  is called by the background thread(for example, in 
dledger mode,  by the QuorumAckChecker) and get an error, the handleResult will 
resend the message and get a new future.
   
   As the future needs to be completed one by one.
   At this time, the old future will depend on the new future to complete, and 
the new future depend on the old future too.
   
   It will cause a deadlock.
   
   @Git-Yang  @duhengforever Please help a check.
   
   The suggested solution is to use a new thread to execute the callback 
instead of in the "ack thread"(GroupCommitService or QuorumAckChecker).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] duhenglucky merged pull request #4030: [Minor] RemotingCommandException is not thrown in a method

[GitBox]

duhenglucky merged pull request #4030:
URL: https://github.com/apache/rocketmq/pull/4030


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org