[GitHub] [rocketmq] liuzongliang0202 opened a new issue, #4463: indexFile flush question
liuzongliang0202 opened a new issue, #4463: URL: https://github.com/apache/rocketmq/issues/4463 Only when the rocketmq indexfile is full can the disk be flushed. If the indexfile is not full, may the data in the indexfile be lost after normal exit? For example, after rocketmq exits normally, pagcache fails to refresh the disk in time after power failure. (I don't see the Shutdown Logic of rocketmq flush indexfile) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] MatrixHB commented on issue #4451: Question about this.lock(mq) in updateProcessQueueTableInRebalance method
MatrixHB commented on issue #4451: URL: https://github.com/apache/rocketmq/issues/4451#issuecomment-1155951974 When executing `if (isOrder && !this.lock(mq))`, the main purpose is to lock the messageQueue in the server-side, `processQueue.setLocked(true);` is secondary. ![image](https://user-images.githubusercontent.com/23614576/173732924-a8bac67e-b1ee-4805-965e-4a39b8a6e27a.png) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #4460: Update the logic of confirmOffset and recover topicQueueTable to prevent message loss when broker role change
RongtongJin commented on PR #4460: URL: https://github.com/apache/rocketmq/pull/4460#issuecomment-1155943359 > Precise changes. Meanwhile, just a reminder, I found that the quality of some comments on this branch needs to be improved. We should make them more formal and understandable in the end. Welcome to submit PRs to polish comments! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-cpp] ShannonDing commented on issue #293: consumer stuck in rebalance and doesn't consume messsages
ShannonDing commented on issue #293: URL: https://github.com/apache/rocketmq-client-cpp/issues/293#issuecomment-1155927539 see #300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-cpp] ShannonDing closed issue #293: consumer stuck in rebalance and doesn't consume messsages
ShannonDing closed issue #293: consumer stuck in rebalance and doesn't consume messsages URL: https://github.com/apache/rocketmq-client-cpp/issues/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-cpp] Jerlensu commented on issue #293: consumer stuck in rebalance and doesn't consume messsages
Jerlensu commented on issue #293: URL: https://github.com/apache/rocketmq-client-cpp/issues/293#issuecomment-1155924105 请问这个问题解决了吗 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [ANNOUNCE]New Committers of Apache RocketMQ: Lin Shen(shenlin) and Yangkun Ai(aaronai)
Congrats yukon 于2022年6月15日周三 10:10写道: > Hi Apache RocketMQ Community, > > The Project Management Committee (PMC) for Apache RocketMQ has invited Lin > Shen (apache id: shenlin, github id: 2011shenlin) and Yangkun Ai (apache > id: aaronai, github id: aaron-ai) to become committers, and we are pleased > to announce that they have accepted. > > Congrats, guys :-) > > Best regards, > Yukon >
[ANNOUNCE]New Committers of Apache RocketMQ: Lin Shen(shenlin) and Yangkun Ai(aaronai)
Hi Apache RocketMQ Community, The Project Management Committee (PMC) for Apache RocketMQ has invited Lin Shen (apache id: shenlin, github id: 2011shenlin) and Yangkun Ai (apache id: aaronai, github id: aaron-ai) to become committers, and we are pleased to announce that they have accepted. Congrats, guys :-) Best regards, Yukon
[GitHub] [rocketmq-client-go] ShannonDing merged pull request #841: [ISSUE #823]fix: panic problem caused by json-iterator in go1.18
ShannonDing merged PR #841: URL: https://github.com/apache/rocketmq-client-go/pull/841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] ShannonDing closed issue #823: go1.18 consumer failed to start
ShannonDing closed issue #823: go1.18 consumer failed to start URL: https://github.com/apache/rocketmq-client-go/issues/823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] hzh0425 commented on issue #4461: can‘t change the logger level dynamicly
hzh0425 commented on issue #4461: URL: https://github.com/apache/rocketmq/issues/4461#issuecomment-1155890471 > IMO, after changing system properties, it's needed to restart process to take effect. yes it is inconvenient -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] lizhiboo commented on issue #4461: can‘t change the logger level dynamicly
lizhiboo commented on issue #4461: URL: https://github.com/apache/rocketmq/issues/4461#issuecomment-1155861314 IMO, after changing system properties, it's needed to restart process to take effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] mahaitao617 opened a new issue, #4462: where is the isOrderTopic used?
mahaitao617 opened a new issue, #4462: URL: https://github.com/apache/rocketmq/issues/4462 public class TopicPublishInfo { private boolean orderTopic = false; private boolean haveTopicRouterInfo = false; private List messageQueueList = new ArrayList(); private volatile ThreadLocalIndex sendWhichQueue = new ThreadLocalIndex(); private TopicRouteData topicRouteData; public boolean isOrderTopic() { return orderTopic; } public void setOrderTopic(boolean orderTopic) { this.orderTopic = orderTopic; } -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] hzh0425 commented on pull request #4424: [Summer of code] Let controller inform broker that role changed.
hzh0425 commented on PR #4424: URL: https://github.com/apache/rocketmq/pull/4424#issuecomment-1155211679 问题场景: RoleChange (Controller 选出新的 Leader) 时, Broker 是通过定时任务来 Sync controller 得元数据, 也即会有一个时间间隔. 我们希望减少这个时间间隔, 所以当选出新的 Leader 后, 让 Controller 立即通知相应得 Broker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] hzh0425 commented on pull request #4460: Update the logic of confirmOffset and recover topicQueueTable to prevent message loss when broker role change
hzh0425 commented on PR #4460: URL: https://github.com/apache/rocketmq/pull/4460#issuecomment-1155188478 Still have some problems that waiting to found~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] hzh0425 commented on issue #4445: Confusion about CN documents(design)
hzh0425 commented on issue #4445: URL: https://github.com/apache/rocketmq/issues/4445#issuecomment-1155184135 感谢建议 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-connect] sunxiaojian opened a new pull request, #158: [ISSUE #155] Optimize the record converter parser
sunxiaojian opened a new pull request, #158: URL: https://github.com/apache/rocketmq-connect/pull/158 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq-connect/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] fulln opened a new issue, #4461: can‘t change the logger level dynamicly
fulln opened a new issue, #4461: URL: https://github.com/apache/rocketmq/issues/4461 need to change the log level dynamicly, we can changed by system properties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-apis] lizhanhui merged pull request #33: [ISSUE #32] add check_message_type to publishing setting.
lizhanhui merged PR #33: URL: https://github.com/apache/rocketmq-apis/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] ShannonDing closed issue #832: Client may submit wrong offset when network instability
ShannonDing closed issue #832: Client may submit wrong offset when network instability URL: https://github.com/apache/rocketmq-client-go/issues/832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] ShannonDing merged pull request #833: [ISSUE #832] Client may submit wrong offset when network instability
ShannonDing merged PR #833: URL: https://github.com/apache/rocketmq-client-go/pull/833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] yuz10 merged pull request #4038: [ISSUE #4037] Add DeleteExpiredCommitLogSubCommand
yuz10 merged PR #4038: URL: https://github.com/apache/rocketmq/pull/4038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] yuz10 closed issue #4037: Admin command to delete expired CommitLog
yuz10 closed issue #4037: Admin command to delete expired CommitLog URL: https://github.com/apache/rocketmq/issues/4037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4460: Update the logic of confirmOffset and recover topicQueueTable to prevent message loss when broker role change
coveralls commented on PR #4460: URL: https://github.com/apache/rocketmq/pull/4460#issuecomment-1154910694 [![Coverage Status](https://coveralls.io/builds/4638/badge)](https://coveralls.io/builds/4638) Coverage increased (+0.02%) to 47.477% when pulling **41ea3e67d6f648ad7d951fc2af7f0ed79c60c1ba on RongtongJin:5.0.0-beta-dledger-controller-4** into **f038cf95d72700419706861796eddf5c57f6b6b4 on apache:5.0.0-beta-dledger-controller**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-exporter] framctr opened a new issue, #105: Prometheus comments
framctr opened a new issue, #105: URL: https://github.com/apache/rocketmq-exporter/issues/105 RocketMQ exporter does not show metrics comments and some metrics are not intuitive to understand. For example, what `rocketmq_brokeruntime_pmdt_0ms` stands for? **To Reproduce** Steps to reproduce the behavior: 1. Launch rocketmq-exporter and look at the output **Expected behavior** Prometheus comments for each metric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-exporter] waney316 commented on issue #104: can't find rocketmq-exporter in hub.docker.com?
waney316 commented on issue #104: URL: https://github.com/apache/rocketmq-exporter/issues/104#issuecomment-1154898971 you can clone this project and build to docker image -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4460: Update the logic of confirmOffset and recover topicQueueTable to prevent message loss when broker role change
codecov-commenter commented on PR #4460: URL: https://github.com/apache/rocketmq/pull/4460#issuecomment-1154897812 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4460?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#4460](https://codecov.io/gh/apache/rocketmq/pull/4460?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (41ea3e6) into [5.0.0-beta-dledger-controller](https://codecov.io/gh/apache/rocketmq/commit/f038cf95d72700419706861796eddf5c57f6b6b4?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f038cf9) will **decrease** coverage by `0.07%`. > The diff coverage is `68.18%`. ```diff @@ Coverage Diff @@ ## 5.0.0-beta-dledger-controller#4460 +/- ## === - Coverage43.32% 43.25% -0.08% + Complexity6376 6363 -13 === Files 841 841 Lines5985759859 +2 Branches 8161 8159 -2 === - Hits 2593225890 -42 - Misses 3058930619 +30 - Partials 3336 3350 +14 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4460?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../rocketmq/broker/hacontroller/ReplicasManager.java](https://codecov.io/gh/apache/rocketmq/pull/4460/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvaGFjb250cm9sbGVyL1JlcGxpY2FzTWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | | | [...he/rocketmq/controller/impl/DLedgerController.java](https://codecov.io/gh/apache/rocketmq/pull/4460/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL0RMZWRnZXJDb250cm9sbGVyLmphdmE=) | `70.65% <0.00%> (+0.38%)` | :arrow_up: | | [...ketmq/store/ha/autoswitch/AutoSwitchHAService.java](https://codecov.io/gh/apache/rocketmq/pull/4460/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL2F1dG9zd2l0Y2gvQXV0b1N3aXRjaEhBU2VydmljZS5qYXZh) | `63.95% <61.53%> (-0.51%)` | :arrow_down: | | [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/4460/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `56.18% <100.00%> (+0.16%)` | :arrow_up: | | [...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java](https://codecov.io/gh/apache/rocketmq/pull/4460/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL2F1dG9zd2l0Y2gvQXV0b1N3aXRjaEhBQ2xpZW50LmphdmE=) | `75.47% <100.00%> (-0.47%)` | :arrow_down: | | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4460/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `41.79% <0.00%> (-8.96%)` | :arrow_down: | | [...etmq/namesrv/routeinfo/BatchUnRegisterService.java](https://codecov.io/gh/apache/rocketmq/pull/4460/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vQmF0Y2hVblJlZ2lzdGVyU2VydmljZS5qYXZh) | `94.73% <0.00%> (-5.27%)` | :arrow_down: | |
[GitHub] [rocketmq] dongeforever commented on pull request #4383: [ISSUE #4382]Namesrv nearby route
dongeforever commented on PR #4383: URL: https://github.com/apache/rocketmq/pull/4383#issuecomment-1154883293 @lwclover I have read all the code. This solution is simple and useful in some cases. And the same time, there are two potential problems. Firstly, in the public cloud or hybrid cloud, with SLB/PrivateLink, the network may be complicated, and we could identify the consumer by their remote address. So we may need a more common way to identify the client and broker. For example, we may abstract a config named "site", and the client/broker inject the "site" info to the extFields of RemotingCommand. Secondly, we may need a way to solve the conflict between consumers of the same group in different networks. For example, some consumers on site A, some consumers on site global. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-eventbridge] 2011shenlin merged pull request #22: Add comments and delete redundant folders
2011shenlin merged PR #22: URL: https://github.com/apache/rocketmq-eventbridge/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-spring] xixingzhe opened a new issue, #464: namespace报错
xixingzhe opened a new issue, #464: URL: https://github.com/apache/rocketmq-spring/issues/464 代码配置 `@RocketMQMessageListener(topic = "${mq.topic.test-topic}", consumerGroup = "${mq.topic.test-topic-consumer-group}", namespace = "${rocketmq.consumer.namespace}")` 报错: `[ERROR] 2022-06-14 16:07:35.125 [main] o.a.r.s.a.ListenerContainerConfiguration - Started container failed. DefaultRocketMQListenerContainer{consumerGroup='test-topic-1-consumer-group', namespace='${rocketmq.consumer.namespace}', nameServer='ip:9876', topic='test-topic-1', consumeMode=CONCURRENTLY, selectorType=TAG, selectorExpression='*', messageModel=CLUSTERING', tlsEnable=false} java.lang.IllegalStateException: Failed to start RocketMQ push consumer at org.apache.rocketmq.spring.support.DefaultRocketMQListenerContainer.start(DefaultRocketMQListenerContainer.java:334) at org.apache.rocketmq.spring.autoconfigure.ListenerContainerConfiguration.registerContainer(ListenerContainerConfiguration.java:120) at java.util.HashMap.forEach(HashMap.java:1288) at org.apache.rocketmq.spring.autoconfigure.ListenerContainerConfiguration.afterSingletonsInstantiated(ListenerContainerConfiguration.java:79) at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:972) at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918) at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583) at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:145) at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:740) at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:415) at org.springframework.boot.SpringApplication.run(SpringApplication.java:303) at org.springframework.boot.SpringApplication.run(SpringApplication.java:1312) at org.springframework.boot.SpringApplication.run(SpringApplication.java:1301) at com.ybw.rocketmq.tencent.demo.RocketmqTencentDemoApplication.main(RocketmqTencentDemoApplication.java:10) Caused by: org.apache.rocketmq.client.exception.MQClientException: the specified group[ For more information, please visit the url, http://rocketmq.apache.org/docs/faq/ at org.apache.rocketmq.client.Validators.checkGroup(Validators.java:50) at org.apache.rocketmq.client.impl.consumer.DefaultMQPushConsumerImpl.checkConfig(DefaultMQPushConsumerImpl.java:661) at org.apache.rocketmq.client.impl.consumer.DefaultMQPushConsumerImpl.start(DefaultMQPushConsumerImpl.java:581) at org.apache.rocketmq.client.consumer.DefaultMQPushConsumer.start(DefaultMQPushConsumer.java:707) at org.apache.rocketmq.spring.support.DefaultRocketMQListenerContainer.start(DefaultRocketMQListenerContainer.java:332) ... 13 common frames omitted [INFO ] 2022-06-14 16:07:35.132 [main] o.a.catalina.core.StandardService - Stopping service [Tomcat] [INFO ] 2022-06-14 16:07:35.147 [main] o.s.b.a.l.ConditionEvaluationReportLoggingListener - Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled. [INFO ] 2022-06-14 16:07:35.319 [NettyClientSelector_1] RocketmqRemoting - closeChannel: close the connection to remote address[49.232.254.16:9876] result: true [INFO ] 2022-06-14 16:07:35.324 [NettyClientSelector_1] RocketmqRemoting - closeChannel: close the connection to remote address[49.232.254.16:9876] result: true [ERROR] 2022-06-14 16:07:35.430 [main] o.s.boot.SpringApplication - Application run failed java.lang.RuntimeException: java.lang.IllegalStateException: Failed to start RocketMQ push consumer at org.apache.rocketmq.spring.autoconfigure.ListenerContainerConfiguration.registerContainer(ListenerContainerConfiguration.java:123) at java.util.HashMap.forEach(HashMap.java:1288) at org.apache.rocketmq.spring.autoconfigure.ListenerContainerConfiguration.afterSingletonsInstantiated(ListenerContainerConfiguration.java:79) at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:972) at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918) at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583) at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:145) at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:740) at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:415) at
[GitHub] [rocketmq-spring] xixingzhe closed issue #463: namespace报错
xixingzhe closed issue #463: namespace报错 URL: https://github.com/apache/rocketmq-spring/issues/463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-spring] xixingzhe opened a new issue, #463: namespace报错
xixingzhe opened a new issue, #463: URL: https://github.com/apache/rocketmq-spring/issues/463 代码配置 `@RocketMQMessageListener(topic = "${mq.topic.test-topic}", consumerGroup = "${mq.topic.test-topic-consumer-group}", namespace = "${rocketmq.consumer.namespace}")` 报错: `[ERROR] 2022-06-14 16:07:35.125 [main] o.a.r.s.a.ListenerContainerConfiguration - Started container failed. DefaultRocketMQListenerContainer{consumerGroup='test-topic-1-consumer-group', namespace='${rocketmq.consumer.namespace}', nameServer='rocketmq-vgo5q5v8gzbx.rocketmq.ap-bj.public.tencenttdmq.com:9876', topic='test-topic-1', consumeMode=CONCURRENTLY, selectorType=TAG, selectorExpression='*', messageModel=CLUSTERING', tlsEnable=false} java.lang.IllegalStateException: Failed to start RocketMQ push consumer at org.apache.rocketmq.spring.support.DefaultRocketMQListenerContainer.start(DefaultRocketMQListenerContainer.java:334) at org.apache.rocketmq.spring.autoconfigure.ListenerContainerConfiguration.registerContainer(ListenerContainerConfiguration.java:120) at java.util.HashMap.forEach(HashMap.java:1288) at org.apache.rocketmq.spring.autoconfigure.ListenerContainerConfiguration.afterSingletonsInstantiated(ListenerContainerConfiguration.java:79) at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:972) at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918) at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583) at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:145) at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:740) at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:415) at org.springframework.boot.SpringApplication.run(SpringApplication.java:303) at org.springframework.boot.SpringApplication.run(SpringApplication.java:1312) at org.springframework.boot.SpringApplication.run(SpringApplication.java:1301) at com.ybw.rocketmq.tencent.demo.RocketmqTencentDemoApplication.main(RocketmqTencentDemoApplication.java:10) Caused by: org.apache.rocketmq.client.exception.MQClientException: the specified group[${rocketmq.consumer.namespace}%test-topic-1-consumer-group] contains illegal characters, allowing only ^[%|a-zA-Z0-9_-]+$ For more information, please visit the url, http://rocketmq.apache.org/docs/faq/ at org.apache.rocketmq.client.Validators.checkGroup(Validators.java:50) at org.apache.rocketmq.client.impl.consumer.DefaultMQPushConsumerImpl.checkConfig(DefaultMQPushConsumerImpl.java:661) at org.apache.rocketmq.client.impl.consumer.DefaultMQPushConsumerImpl.start(DefaultMQPushConsumerImpl.java:581) at org.apache.rocketmq.client.consumer.DefaultMQPushConsumer.start(DefaultMQPushConsumer.java:707) at org.apache.rocketmq.spring.support.DefaultRocketMQListenerContainer.start(DefaultRocketMQListenerContainer.java:332) ... 13 common frames omitted [INFO ] 2022-06-14 16:07:35.132 [main] o.a.catalina.core.StandardService - Stopping service [Tomcat] [INFO ] 2022-06-14 16:07:35.147 [main] o.s.b.a.l.ConditionEvaluationReportLoggingListener - Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled. [INFO ] 2022-06-14 16:07:35.319 [NettyClientSelector_1] RocketmqRemoting - closeChannel: close the connection to remote address[49.232.254.16:9876] result: true [INFO ] 2022-06-14 16:07:35.324 [NettyClientSelector_1] RocketmqRemoting - closeChannel: close the connection to remote address[49.232.254.16:9876] result: true [ERROR] 2022-06-14 16:07:35.430 [main] o.s.boot.SpringApplication - Application run failed java.lang.RuntimeException: java.lang.IllegalStateException: Failed to start RocketMQ push consumer at org.apache.rocketmq.spring.autoconfigure.ListenerContainerConfiguration.registerContainer(ListenerContainerConfiguration.java:123) at java.util.HashMap.forEach(HashMap.java:1288) at org.apache.rocketmq.spring.autoconfigure.ListenerContainerConfiguration.afterSingletonsInstantiated(ListenerContainerConfiguration.java:79) at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:972) at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918) at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583) at
[GitHub] [rocketmq] RongtongJin opened a new pull request, #4460: Update the logic of confirmOffset and recover topicQueueTable to prevent message loss
RongtongJin opened a new pull request, #4460: URL: https://github.com/apache/rocketmq/pull/4460 ## What is the purpose of the change Controller模式在网络分区场景下,confirmOffset的更新,cq的构建,数据的节点要相互配合,否则会丢死后 ## Brief changelog Update the logic of confirmOffset and recover topicQueueTable to prevent message loss ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] zhouxinyu merged pull request #4459: Change PullMessageRequestHeader maxMsgNums to CFNullable
zhouxinyu merged PR #4459: URL: https://github.com/apache/rocketmq/pull/4459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] zhouxinyu commented on pull request #4459: Change PullMessageRequestHeader maxMsgNums to CFNullable
zhouxinyu commented on PR #4459: URL: https://github.com/apache/rocketmq/pull/4459#issuecomment-1154812196 LGTM~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] drpmma opened a new pull request, #4459: Change PullMessageRequestHeader maxMsgNums to CFNullable
drpmma opened a new pull request, #4459: URL: https://github.com/apache/rocketmq/pull/4459 ## What is the purpose of the change Change PullMessageRequestHeader maxMsgNums to CFNullable to ensure protocol compatibility. ## Brief changelog See https://github.com/apache/rocketmq/blob/82a48be00a6d9def14abb871a40cb68cf8a041e9/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java#L277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org