[GitHub] [rocketmq] coveralls commented on pull request #4493: Fix the default value of parameter 'sendMsgTimeout'，the default value…
coveralls commented on PR #4493: URL: https://github.com/apache/rocketmq/pull/4493#issuecomment-1161299749 [](https://coveralls.io/builds/50198764) Coverage decreased (-0.2%) to 51.854% when pulling **fcb1c42bfe2e5c1f8d4949004d3477342b3e8230 on ycfxhsw:docs_send_time_out_fix** into **32733e76747f3db761ace75cfed6d6fdcdaee81a on apache:develop**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4493: Fix the default value of parameter 'sendMsgTimeout'，the default value…
coveralls commented on PR #4493: URL: https://github.com/apache/rocketmq/pull/4493#issuecomment-1161299751 [](https://coveralls.io/builds/50198764) Coverage decreased (-0.2%) to 51.854% when pulling **fcb1c42bfe2e5c1f8d4949004d3477342b3e8230 on ycfxhsw:docs_send_time_out_fix** into **32733e76747f3db761ace75cfed6d6fdcdaee81a on apache:develop**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4493: Fix the default value of parameter 'sendMsgTimeout'，the default value…
codecov-commenter commented on PR #4493: URL: https://github.com/apache/rocketmq/pull/4493#issuecomment-1161299191 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4493?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#4493](https://codecov.io/gh/apache/rocketmq/pull/4493?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fcb1c42) into [develop](https://codecov.io/gh/apache/rocketmq/commit/32733e76747f3db761ace75cfed6d6fdcdaee81a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (32733e7) will **decrease** coverage by `0.34%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## develop#4493 +/- ## = - Coverage 48.16% 47.81% -0.35% + Complexity 5127 5079 -48 = Files649 649 Lines 4302143021 Branches5625 5625 = - Hits 2072020571 -149 - Misses 1979819936 +138 - Partials2503 2514 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4493?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rg/apache/rocketmq/common/stats/StatsSnapshot.java](https://codecov.io/gh/apache/rocketmq/pull/4493/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNTbmFwc2hvdC5qYXZh) | `84.61% <0.00%> (-15.39%)` | :arrow_down: | | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4493/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `44.77% <0.00%> (-10.45%)` | :arrow_down: | | [.../apache/rocketmq/common/stats/MomentStatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/4493/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtLmphdmE=) | `38.09% <0.00%> (-9.53%)` | :arrow_down: | | [...va/org/apache/rocketmq/store/FlushDiskWatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4493/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0ZsdXNoRGlza1dhdGNoZXIuamF2YQ==) | `81.25% <0.00%> (-9.38%)` | :arrow_down: | | [...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4493/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=) | `43.47% <0.00%> (-8.70%)` | :arrow_down: | | [...va/org/apache/rocketmq/logging/inner/Appender.java](https://codecov.io/gh/apache/rocketmq/pull/4493/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9BcHBlbmRlci5qYXZh) | `29.21% <0.00%> (-7.87%)` | :arrow_down: | | [...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/4493/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==) | `38.88% <0.00%> (-5.56%)` | :arrow_down: | | [...org/apache/rocketmq/store/ha/WaitNotifyObject.java](https://codecov.io/gh/apache/rocketmq/pull/4493/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL1dhaXROb3RpZnlPYmplY3QuamF2YQ==) | `66.07% <0.00%> (-5.36%)` | :arrow_down: | |
[GitHub] [rocketmq] ycfxhsw opened a new pull request, #4493: Fix the default value of parameter 'sendMsgTimeout'，the default value…
ycfxhsw opened a new pull request, #4493: URL: https://github.com/apache/rocketmq/pull/4493 1、Please describe the issue you observed:   As the picture above shows, the default value of the parameter sendMsgTimeout is 1, but in the code, the default value is 3000. https://github.com/apache/rocketmq/blob/bda0ae0305863cc5fa2e0578439dfa4f4d9908b3/client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java#L102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] skasj opened a new issue, #4492: Can KQueue be supported on the mac platform?
skasj opened a new issue, #4492: URL: https://github.com/apache/rocketmq/issues/4492 Can KQueue be supported on the mac platform? Looks like only a small amount of code needs to be added: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-streams] codecov-commenter commented on pull request #168: Bump mysql-connector-java from 8.0.19 to 8.0.28 in /rocketmq-streams-examples
codecov-commenter commented on PR #168: URL: https://github.com/apache/rocketmq-streams/pull/168#issuecomment-1161256080 # [Codecov](https://codecov.io/gh/apache/rocketmq-streams/pull/168?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#168](https://codecov.io/gh/apache/rocketmq-streams/pull/168?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b61d977) into [main](https://codecov.io/gh/apache/rocketmq-streams/commit/62f9a3bd7b4b01e1638beed4403f027c599b4b02?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (62f9a3b) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ##main#168 +/- ## = Coverage 0.00% 0.00% = Files712 712 Lines 35567 35567 Branches59285928 = Misses 35567 35567 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-streams/pull/168?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-streams/pull/168?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [62f9a3b...b61d977](https://codecov.io/gh/apache/rocketmq-streams/pull/168?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-streams] dependabot[bot] opened a new pull request, #168: Bump mysql-connector-java from 8.0.19 to 8.0.28 in /rocketmq-streams-examples
dependabot[bot] opened a new pull request, #168: URL: https://github.com/apache/rocketmq-streams/pull/168 Bumps [mysql-connector-java](https://github.com/mysql/mysql-connector-j) from 8.0.19 to 8.0.28. Changelog Sourced from https://github.com/mysql/mysql-connector-j/blob/release/8.0/CHANGES;>mysql-connector-java's changelog. Changelog https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/;>https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/ Version 8.0.29 Fix for Bug#21978230, COMMENT PARSING NOT PROPER IN PREPSTMT.EXECUTEBATCH(). Fix for Bug#81468 (23312764), MySQL server fails to rewrite batch insert when column name contains word select. Fix for Bug#106435 (33850099), 8.0.28 Connector/J has regressive in setAutoCommit after Bug#104067 (33054827). Fix for Bug#106240 (33781440), StringIndexOutOfBoundsException when VALUE is at the end of the query. Fix for Bug#106397 (33893591), Contribution: fix: fix LocalizedErrorMessages.properties doc: less then - ... Thanks to Jianjian Song for his contribution. Fix for Bug#77924 (25710160), JDBC SOCKS SHOULD NOT PERFORM LOCAL DNS RESOLUTION. Fix for Bug#82084 (23743938), YEAR DATA TYPE RETURNS INCORRECT VALUE FOR JDBC GETCOLUMNTYPE(). Fix for Bug#106441 (33850155), Add charset mapping for utf8mb3. WL#15048, Upgrade Protocol Buffers dependency to protobuf-java-3.19.4. Fix for Bug#106065 (33726184) Contribution: BigDecimal.toPlainString no need to check decimal exponent. Thanks to Baoyi Chen for his contribution. Fix for Bug#106171 (33757217), Contribution: Remove unnecessary boxing in ResultSetImpl. Thanks to Ningpp Ning for his contribution. Fix for Bug#25701740, STMT EXECUTION FAILS FOR REPLICATION CONNECTION WHEN USECURSORFETCH=TRUE. Fix for Bug#33723611, getDefaultTransactionIsolation must return repeatable read. Fix for Bug#38954 (11749415), DATA TRUNCATION WHILE USING BIT(1) IN STORED PROCEDURE WITH INOUT TYPE. Fix for Bug#85317 (25672958), EXECUTE BATCH WILL THROW NULL POINTER EXCEPTION WHERE THE COLUMN IS BLOB! Fix for Bug#105915 (33678490), Connector/J 8 server prepared statement precision loss in execute batch. Fix for Bug#104349 (33563548), com.mysql.cj NPE. Fix for Bug#62006 (16714956), JAVA.IO.NOTSERIALIZABLEEXCEPTION: JAVA.IO.STRINGREADER WHEN PROFILESQL=TRUE. WL#14750, Better unification of query bindings. WL#14834, Support for FIDO authentication. WL#14835, Align TLS option checking across connectors. ... (truncated) Commits https://github.com/mysql/mysql-connector-j/commit/7ff2161da3899f379fb3171b6538b191b1c5c7e2;>7ff2161 Updating copyright years https://github.com/mysql/mysql-connector-j/commit/b13af389b3e0f0afe4366ecddbe7e8c541bfb606;>b13af38 Fix for DateTimeTest according to changes in MySQL server. https://github.com/mysql/mysql-connector-j/commit/5c7b7753287e1399b3437aae2253acf611acd54d;>5c7b775 Update in test for Bug#96900 (30355150). https://github.com/mysql/mysql-connector-j/commit/e1169ee5adf5561dad2814b4ede82dd167ee6e93;>e1169ee Fix for Bug#99260 (31189960), statement.setQueryTimeout,creates a database co... https://github.com/mysql/mysql-connector-j/commit/05778ef59adc154df1a81bcfbd7b5913859f4b31;>05778ef Fix for Bug#103324 (32770013), X DevAPI Collection.replaceOne() missing match... https://github.com/mysql/mysql-connector-j/commit/48219f28f8dab9855803d2c34f9d43c3da4c5393;>48219f2 Fix for Bug#105197 (33461744), Statement.executeQuery() may return non-naviga... https://github.com/mysql/mysql-connector-j/commit/24cf7e22e8f8381d076d18bce8d569812e1a0d26;>24cf7e2 Fix for Bug#105323 (33507321), README.md contains broken links. https://github.com/mysql/mysql-connector-j/commit/ad46620321e815fb22bed3c81f278cab8fbfe891;>ad46620 Fix for Bug#96900 (30355150), STATEMENT.CANCEL()CREATE A DATABASE https://github.com/mysql/mysql-connector-j/commit/4d19ea1a60ac9e97aae9074190c08c6f097a00ed;>4d19ea1 Fix for Bug#104067 (33054827), No reset autoCommit after unknown issue occurs. https://github.com/mysql/mysql-connector-j/commit/bc45d35c2d023d2e82dc6c3e2b12745389f3c3c1;>bc45d35 Fix for Bug#85223 (25656020), MYSQLSQLXML SETSTRING CRASH. Additional commits viewable in https://github.com/mysql/mysql-connector-j/compare/8.0.19...8.0.28;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase
[GitHub] [rocketmq-eventbridge] dependabot[bot] opened a new pull request, #25: Bump mysql-connector-java from 8.0.16 to 8.0.28 in /adapter/persistence
dependabot[bot] opened a new pull request, #25: URL: https://github.com/apache/rocketmq-eventbridge/pull/25 Bumps [mysql-connector-java](https://github.com/mysql/mysql-connector-j) from 8.0.16 to 8.0.28. Changelog Sourced from https://github.com/mysql/mysql-connector-j/blob/release/8.0/CHANGES;>mysql-connector-java's changelog. Changelog https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/;>https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/ Version 8.0.29 Fix for Bug#21978230, COMMENT PARSING NOT PROPER IN PREPSTMT.EXECUTEBATCH(). Fix for Bug#81468 (23312764), MySQL server fails to rewrite batch insert when column name contains word select. Fix for Bug#106435 (33850099), 8.0.28 Connector/J has regressive in setAutoCommit after Bug#104067 (33054827). Fix for Bug#106240 (33781440), StringIndexOutOfBoundsException when VALUE is at the end of the query. Fix for Bug#106397 (33893591), Contribution: fix: fix LocalizedErrorMessages.properties doc: less then - ... Thanks to Jianjian Song for his contribution. Fix for Bug#77924 (25710160), JDBC SOCKS SHOULD NOT PERFORM LOCAL DNS RESOLUTION. Fix for Bug#82084 (23743938), YEAR DATA TYPE RETURNS INCORRECT VALUE FOR JDBC GETCOLUMNTYPE(). Fix for Bug#106441 (33850155), Add charset mapping for utf8mb3. WL#15048, Upgrade Protocol Buffers dependency to protobuf-java-3.19.4. Fix for Bug#106065 (33726184) Contribution: BigDecimal.toPlainString no need to check decimal exponent. Thanks to Baoyi Chen for his contribution. Fix for Bug#106171 (33757217), Contribution: Remove unnecessary boxing in ResultSetImpl. Thanks to Ningpp Ning for his contribution. Fix for Bug#25701740, STMT EXECUTION FAILS FOR REPLICATION CONNECTION WHEN USECURSORFETCH=TRUE. Fix for Bug#33723611, getDefaultTransactionIsolation must return repeatable read. Fix for Bug#38954 (11749415), DATA TRUNCATION WHILE USING BIT(1) IN STORED PROCEDURE WITH INOUT TYPE. Fix for Bug#85317 (25672958), EXECUTE BATCH WILL THROW NULL POINTER EXCEPTION WHERE THE COLUMN IS BLOB! Fix for Bug#105915 (33678490), Connector/J 8 server prepared statement precision loss in execute batch. Fix for Bug#104349 (33563548), com.mysql.cj NPE. Fix for Bug#62006 (16714956), JAVA.IO.NOTSERIALIZABLEEXCEPTION: JAVA.IO.STRINGREADER WHEN PROFILESQL=TRUE. WL#14750, Better unification of query bindings. WL#14834, Support for FIDO authentication. WL#14835, Align TLS option checking across connectors. ... (truncated) Commits https://github.com/mysql/mysql-connector-j/commit/7ff2161da3899f379fb3171b6538b191b1c5c7e2;>7ff2161 Updating copyright years https://github.com/mysql/mysql-connector-j/commit/b13af389b3e0f0afe4366ecddbe7e8c541bfb606;>b13af38 Fix for DateTimeTest according to changes in MySQL server. https://github.com/mysql/mysql-connector-j/commit/5c7b7753287e1399b3437aae2253acf611acd54d;>5c7b775 Update in test for Bug#96900 (30355150). https://github.com/mysql/mysql-connector-j/commit/e1169ee5adf5561dad2814b4ede82dd167ee6e93;>e1169ee Fix for Bug#99260 (31189960), statement.setQueryTimeout,creates a database co... https://github.com/mysql/mysql-connector-j/commit/05778ef59adc154df1a81bcfbd7b5913859f4b31;>05778ef Fix for Bug#103324 (32770013), X DevAPI Collection.replaceOne() missing match... https://github.com/mysql/mysql-connector-j/commit/48219f28f8dab9855803d2c34f9d43c3da4c5393;>48219f2 Fix for Bug#105197 (33461744), Statement.executeQuery() may return non-naviga... https://github.com/mysql/mysql-connector-j/commit/24cf7e22e8f8381d076d18bce8d569812e1a0d26;>24cf7e2 Fix for Bug#105323 (33507321), README.md contains broken links. https://github.com/mysql/mysql-connector-j/commit/ad46620321e815fb22bed3c81f278cab8fbfe891;>ad46620 Fix for Bug#96900 (30355150), STATEMENT.CANCEL()CREATE A DATABASE https://github.com/mysql/mysql-connector-j/commit/4d19ea1a60ac9e97aae9074190c08c6f097a00ed;>4d19ea1 Fix for Bug#104067 (33054827), No reset autoCommit after unknown issue occurs. https://github.com/mysql/mysql-connector-j/commit/bc45d35c2d023d2e82dc6c3e2b12745389f3c3c1;>bc45d35 Fix for Bug#85223 (25656020), MYSQLSQLXML SETSTRING CRASH. Additional commits viewable in https://github.com/mysql/mysql-connector-j/compare/8.0.16...8.0.28;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase
[GitHub] [rocketmq-connect] dependabot[bot] opened a new pull request, #176: Bump mysql-connector-java from 8.0.16 to 8.0.28 in /connectors/rocketmq-connect-jdbc
dependabot[bot] opened a new pull request, #176: URL: https://github.com/apache/rocketmq-connect/pull/176 Bumps [mysql-connector-java](https://github.com/mysql/mysql-connector-j) from 8.0.16 to 8.0.28. Changelog Sourced from https://github.com/mysql/mysql-connector-j/blob/release/8.0/CHANGES;>mysql-connector-java's changelog. Changelog https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/;>https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/ Version 8.0.29 Fix for Bug#21978230, COMMENT PARSING NOT PROPER IN PREPSTMT.EXECUTEBATCH(). Fix for Bug#81468 (23312764), MySQL server fails to rewrite batch insert when column name contains word select. Fix for Bug#106435 (33850099), 8.0.28 Connector/J has regressive in setAutoCommit after Bug#104067 (33054827). Fix for Bug#106240 (33781440), StringIndexOutOfBoundsException when VALUE is at the end of the query. Fix for Bug#106397 (33893591), Contribution: fix: fix LocalizedErrorMessages.properties doc: less then - ... Thanks to Jianjian Song for his contribution. Fix for Bug#77924 (25710160), JDBC SOCKS SHOULD NOT PERFORM LOCAL DNS RESOLUTION. Fix for Bug#82084 (23743938), YEAR DATA TYPE RETURNS INCORRECT VALUE FOR JDBC GETCOLUMNTYPE(). Fix for Bug#106441 (33850155), Add charset mapping for utf8mb3. WL#15048, Upgrade Protocol Buffers dependency to protobuf-java-3.19.4. Fix for Bug#106065 (33726184) Contribution: BigDecimal.toPlainString no need to check decimal exponent. Thanks to Baoyi Chen for his contribution. Fix for Bug#106171 (33757217), Contribution: Remove unnecessary boxing in ResultSetImpl. Thanks to Ningpp Ning for his contribution. Fix for Bug#25701740, STMT EXECUTION FAILS FOR REPLICATION CONNECTION WHEN USECURSORFETCH=TRUE. Fix for Bug#33723611, getDefaultTransactionIsolation must return repeatable read. Fix for Bug#38954 (11749415), DATA TRUNCATION WHILE USING BIT(1) IN STORED PROCEDURE WITH INOUT TYPE. Fix for Bug#85317 (25672958), EXECUTE BATCH WILL THROW NULL POINTER EXCEPTION WHERE THE COLUMN IS BLOB! Fix for Bug#105915 (33678490), Connector/J 8 server prepared statement precision loss in execute batch. Fix for Bug#104349 (33563548), com.mysql.cj NPE. Fix for Bug#62006 (16714956), JAVA.IO.NOTSERIALIZABLEEXCEPTION: JAVA.IO.STRINGREADER WHEN PROFILESQL=TRUE. WL#14750, Better unification of query bindings. WL#14834, Support for FIDO authentication. WL#14835, Align TLS option checking across connectors. ... (truncated) Commits https://github.com/mysql/mysql-connector-j/commit/7ff2161da3899f379fb3171b6538b191b1c5c7e2;>7ff2161 Updating copyright years https://github.com/mysql/mysql-connector-j/commit/b13af389b3e0f0afe4366ecddbe7e8c541bfb606;>b13af38 Fix for DateTimeTest according to changes in MySQL server. https://github.com/mysql/mysql-connector-j/commit/5c7b7753287e1399b3437aae2253acf611acd54d;>5c7b775 Update in test for Bug#96900 (30355150). https://github.com/mysql/mysql-connector-j/commit/e1169ee5adf5561dad2814b4ede82dd167ee6e93;>e1169ee Fix for Bug#99260 (31189960), statement.setQueryTimeout,creates a database co... https://github.com/mysql/mysql-connector-j/commit/05778ef59adc154df1a81bcfbd7b5913859f4b31;>05778ef Fix for Bug#103324 (32770013), X DevAPI Collection.replaceOne() missing match... https://github.com/mysql/mysql-connector-j/commit/48219f28f8dab9855803d2c34f9d43c3da4c5393;>48219f2 Fix for Bug#105197 (33461744), Statement.executeQuery() may return non-naviga... https://github.com/mysql/mysql-connector-j/commit/24cf7e22e8f8381d076d18bce8d569812e1a0d26;>24cf7e2 Fix for Bug#105323 (33507321), README.md contains broken links. https://github.com/mysql/mysql-connector-j/commit/ad46620321e815fb22bed3c81f278cab8fbfe891;>ad46620 Fix for Bug#96900 (30355150), STATEMENT.CANCEL()CREATE A DATABASE https://github.com/mysql/mysql-connector-j/commit/4d19ea1a60ac9e97aae9074190c08c6f097a00ed;>4d19ea1 Fix for Bug#104067 (33054827), No reset autoCommit after unknown issue occurs. https://github.com/mysql/mysql-connector-j/commit/bc45d35c2d023d2e82dc6c3e2b12745389f3c3c1;>bc45d35 Fix for Bug#85223 (25656020), MYSQLSQLXML SETSTRING CRASH. Additional commits viewable in https://github.com/mysql/mysql-connector-j/compare/8.0.16...8.0.28;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase
[GitHub] [rocketmq-streams] codecov-commenter commented on pull request #167: Bump mysql-connector-java from 5.1.40 to 8.0.28
codecov-commenter commented on PR #167: URL: https://github.com/apache/rocketmq-streams/pull/167#issuecomment-1161250496 # [Codecov](https://codecov.io/gh/apache/rocketmq-streams/pull/167?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#167](https://codecov.io/gh/apache/rocketmq-streams/pull/167?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (bd77e2d) into [main](https://codecov.io/gh/apache/rocketmq-streams/commit/62f9a3bd7b4b01e1638beed4403f027c599b4b02?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (62f9a3b) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ##main#167 +/- ## = Coverage 0.00% 0.00% = Files712 712 Lines 35567 35567 Branches59285928 = Misses 35567 35567 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-streams/pull/167?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-streams/pull/167?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [62f9a3b...bd77e2d](https://codecov.io/gh/apache/rocketmq-streams/pull/167?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-streams] dependabot[bot] closed pull request #144: Bump mysql-connector-java from 5.1.40 to 8.0.16
dependabot[bot] closed pull request #144: Bump mysql-connector-java from 5.1.40 to 8.0.16 URL: https://github.com/apache/rocketmq-streams/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-streams] dependabot[bot] commented on pull request #144: Bump mysql-connector-java from 5.1.40 to 8.0.16
dependabot[bot] commented on PR #144: URL: https://github.com/apache/rocketmq-streams/pull/144#issuecomment-1161247532 Superseded by #167. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-streams] dependabot[bot] opened a new pull request, #167: Bump mysql-connector-java from 5.1.40 to 8.0.28
dependabot[bot] opened a new pull request, #167: URL: https://github.com/apache/rocketmq-streams/pull/167 Bumps [mysql-connector-java](https://github.com/mysql/mysql-connector-j) from 5.1.40 to 8.0.28. Changelog Sourced from https://github.com/mysql/mysql-connector-j/blob/release/8.0/CHANGES;>mysql-connector-java's changelog. Changelog https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/;>https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/ Version 8.0.29 Fix for Bug#21978230, COMMENT PARSING NOT PROPER IN PREPSTMT.EXECUTEBATCH(). Fix for Bug#81468 (23312764), MySQL server fails to rewrite batch insert when column name contains word select. Fix for Bug#106435 (33850099), 8.0.28 Connector/J has regressive in setAutoCommit after Bug#104067 (33054827). Fix for Bug#106240 (33781440), StringIndexOutOfBoundsException when VALUE is at the end of the query. Fix for Bug#106397 (33893591), Contribution: fix: fix LocalizedErrorMessages.properties doc: less then - ... Thanks to Jianjian Song for his contribution. Fix for Bug#77924 (25710160), JDBC SOCKS SHOULD NOT PERFORM LOCAL DNS RESOLUTION. Fix for Bug#82084 (23743938), YEAR DATA TYPE RETURNS INCORRECT VALUE FOR JDBC GETCOLUMNTYPE(). Fix for Bug#106441 (33850155), Add charset mapping for utf8mb3. WL#15048, Upgrade Protocol Buffers dependency to protobuf-java-3.19.4. Fix for Bug#106065 (33726184) Contribution: BigDecimal.toPlainString no need to check decimal exponent. Thanks to Baoyi Chen for his contribution. Fix for Bug#106171 (33757217), Contribution: Remove unnecessary boxing in ResultSetImpl. Thanks to Ningpp Ning for his contribution. Fix for Bug#25701740, STMT EXECUTION FAILS FOR REPLICATION CONNECTION WHEN USECURSORFETCH=TRUE. Fix for Bug#33723611, getDefaultTransactionIsolation must return repeatable read. Fix for Bug#38954 (11749415), DATA TRUNCATION WHILE USING BIT(1) IN STORED PROCEDURE WITH INOUT TYPE. Fix for Bug#85317 (25672958), EXECUTE BATCH WILL THROW NULL POINTER EXCEPTION WHERE THE COLUMN IS BLOB! Fix for Bug#105915 (33678490), Connector/J 8 server prepared statement precision loss in execute batch. Fix for Bug#104349 (33563548), com.mysql.cj NPE. Fix for Bug#62006 (16714956), JAVA.IO.NOTSERIALIZABLEEXCEPTION: JAVA.IO.STRINGREADER WHEN PROFILESQL=TRUE. WL#14750, Better unification of query bindings. WL#14834, Support for FIDO authentication. WL#14835, Align TLS option checking across connectors. ... (truncated) Commits https://github.com/mysql/mysql-connector-j/commit/7ff2161da3899f379fb3171b6538b191b1c5c7e2;>7ff2161 Updating copyright years https://github.com/mysql/mysql-connector-j/commit/b13af389b3e0f0afe4366ecddbe7e8c541bfb606;>b13af38 Fix for DateTimeTest according to changes in MySQL server. https://github.com/mysql/mysql-connector-j/commit/5c7b7753287e1399b3437aae2253acf611acd54d;>5c7b775 Update in test for Bug#96900 (30355150). https://github.com/mysql/mysql-connector-j/commit/e1169ee5adf5561dad2814b4ede82dd167ee6e93;>e1169ee Fix for Bug#99260 (31189960), statement.setQueryTimeout,creates a database co... https://github.com/mysql/mysql-connector-j/commit/05778ef59adc154df1a81bcfbd7b5913859f4b31;>05778ef Fix for Bug#103324 (32770013), X DevAPI Collection.replaceOne() missing match... https://github.com/mysql/mysql-connector-j/commit/48219f28f8dab9855803d2c34f9d43c3da4c5393;>48219f2 Fix for Bug#105197 (33461744), Statement.executeQuery() may return non-naviga... https://github.com/mysql/mysql-connector-j/commit/24cf7e22e8f8381d076d18bce8d569812e1a0d26;>24cf7e2 Fix for Bug#105323 (33507321), README.md contains broken links. https://github.com/mysql/mysql-connector-j/commit/ad46620321e815fb22bed3c81f278cab8fbfe891;>ad46620 Fix for Bug#96900 (30355150), STATEMENT.CANCEL()CREATE A DATABASE https://github.com/mysql/mysql-connector-j/commit/4d19ea1a60ac9e97aae9074190c08c6f097a00ed;>4d19ea1 Fix for Bug#104067 (33054827), No reset autoCommit after unknown issue occurs. https://github.com/mysql/mysql-connector-j/commit/bc45d35c2d023d2e82dc6c3e2b12745389f3c3c1;>bc45d35 Fix for Bug#85223 (25656020), MYSQLSQLXML SETSTRING CRASH. Additional commits viewable in https://github.com/mysql/mysql-connector-j/compare/5.1.40...8.0.28;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase
[GitHub] [rocketmq-apis] aaron-ai closed pull request #43: Add delivery attempt for message tracing
aaron-ai closed pull request #43: Add delivery attempt for message tracing URL: https://github.com/apache/rocketmq-apis/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [DISCUSS][RIP-42]Support Timing Messages with Arbitrary Time Delay
The long-awaited feature for our community, this RIP will make our timer message more competitive, and make the new SimpleConsumer API `changeInvisibleDuration` more flexible. On Tue, Jun 21, 2022 at 11:42 AM dongeforever wrote: > Good Job. > > It will be nice if there are some performance test reports. > > 季俊涛 <3160102...@zju.edu.cn> 于2022年6月20日周一 17:28写道： > > > Hi, RocketMQ Community: > > > > Currently, RocketMQ's delay message feature only supports delayed > delivery > > for specific time levels. Such delay message feature(only support > specific > > levels of delay time) is no longer enough to support the flexible usage > of > > rocketmq. Therefore, we need a delay message feature that supports > > arbitrary delay time. So I would like to start an email thread to discuss > > RIP-42 Support Timing Messages with Arbitrary Time Delay. > > > > I have written my proposal and you can click on the link below： > > Google Doc: > > > https://docs.google.com/document/d/1D6XWwY39p531c2aVi5HQll9iwzTUNT1haUFHqMoRkT0/edit?usp=sharing > > Shimo:https://shimo.im/docs/gXqme9PKKpIeD7qo/ > > > > If you have any questions or suggestions, please reply to this email or > > comment on the proposal. > > > > Thanks > > Juntao Ji > > > > >
[GitHub] [rocketmq-operator] feixiaohuijava commented on issue #78: unable to recognize "deploy/crds/rocketmq_v1alpha1_broker_crd.yaml": no matches for kind "CustomResourceDefinition" in version "apie
feixiaohuijava commented on issue #78: URL: https://github.com/apache/rocketmq-operator/issues/78#issuecomment-1161226244 kubernets 1.16 will not support v1beta1 but v1 [https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/](crd) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-operator] feixiaohuijava opened a new issue, #102: golang compile bug
feixiaohuijava opened a new issue, #102: URL: https://github.com/apache/rocketmq-operator/issues/102 QUESTION 1 did you do `go mod tidy ` ? I found unused go modules! [image](https://user-images.githubusercontent.com/21102129/174711924-33112851-eb58-4d08-bd5e-4e15cfe0b1e3.png) QUESTION 2 did you compile success?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] liuzongliang0202 commented on pull request #4491: unLimit delay message
liuzongliang0202 commented on PR #4491: URL: https://github.com/apache/rocketmq/pull/4491#issuecomment-1161218449 Refer https://note.youdao.com/s/9y0kjrvJ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [DISCUSS][RIP-42]Support Timing Messages with Arbitrary Time Delay
Good Job. It will be nice if there are some performance test reports. 季俊涛 <3160102...@zju.edu.cn> 于2022年6月20日周一 17:28写道： > Hi, RocketMQ Community: > > Currently, RocketMQ's delay message feature only supports delayed delivery > for specific time levels. Such delay message feature(only support specific > levels of delay time) is no longer enough to support the flexible usage of > rocketmq. Therefore, we need a delay message feature that supports > arbitrary delay time. So I would like to start an email thread to discuss > RIP-42 Support Timing Messages with Arbitrary Time Delay. > > I have written my proposal and you can click on the link below： > Google Doc: > https://docs.google.com/document/d/1D6XWwY39p531c2aVi5HQll9iwzTUNT1haUFHqMoRkT0/edit?usp=sharing > Shimo:https://shimo.im/docs/gXqme9PKKpIeD7qo/ > > If you have any questions or suggestions, please reply to this email or > comment on the proposal. > > Thanks > Juntao Ji > >
[GitHub] [rocketmq] liuzongliang0202 opened a new pull request, #4491: unLimit delay message
liuzongliang0202 opened a new pull request, #4491: URL: https://github.com/apache/rocketmq/pull/4491 **Make sure set the target branch to `develop`** ## What is the purpose of the change Support second level delay messages at any time within two months（default） ## Brief changelog Build a chronological file in seconds of delayed messages delayTimeLine, different delay messages are mapped to the corresponding time unit of the file, Messages with the same delay time are added to the delaylinklog log and written sequentially. The asynchronous time thread looks for the delay message that has expired in the current second according to the current time seconds, reads and restores the original message and puts it back into the commitlog ## Verifying this change Refer UTs, ITs and testing report Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4490: [ISSUE #4489]Some trace messages not being sent to the broker in time before producer shutdown.
coveralls commented on PR #4490: URL: https://github.com/apache/rocketmq/pull/4490#issuecomment-1161152165 [](https://coveralls.io/builds/50196284) Coverage decreased (-0.03%) to 51.987% when pulling **b44d3268c7a5a30d92fa8700af876d1b063df646 on zhangjidi2016:fix_trace_lost** into **32733e76747f3db761ace75cfed6d6fdcdaee81a on apache:develop**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] zhangjidi2016 commented on a diff in pull request #4488: [ISSUE #4487]The trackType is wrong when the consumer in broadcasting subscription.
zhangjidi2016 commented on code in PR #4488:
URL: https://github.com/apache/rocketmq/pull/4488#discussion_r902112423
##
common/src/main/java/org/apache/rocketmq/common/protocol/ResponseCode.java:
##
@@ -80,4 +80,6 @@ public class ResponseCode extends RemotingSysResponseCode {
public static final int UPDATE_GLOBAL_WHITE_ADDRS_CONFIG_FAILED = 211;
+public static final int CONSUME_BROADCASTING = 212;
Review Comment:
Good suggestion. I'll change it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4490: [ISSUE #4489]Some trace messages not being sent to the broker in time before producer shutdown.
codecov-commenter commented on PR #4490: URL: https://github.com/apache/rocketmq/pull/4490#issuecomment-1161141639 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4490?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#4490](https://codecov.io/gh/apache/rocketmq/pull/4490?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b44d326) into [develop](https://codecov.io/gh/apache/rocketmq/commit/f34c185e05f5b1a1cc372fa72718d6b40ed6e5cc?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f34c185) will **decrease** coverage by `0.18%`. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## develop#4490 +/- ## = - Coverage 48.13% 47.95% -0.19% + Complexity 5129 5095 -34 = Files649 649 Lines 4302143026 +5 Branches5625 5626 +1 = - Hits 2070920631 -78 - Misses 1980819881 +73 - Partials2504 2514 +10 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4490?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4490/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==) | `82.38% <100.00%> (-0.06%)` | :arrow_down: | | [...rg/apache/rocketmq/common/stats/StatsSnapshot.java](https://codecov.io/gh/apache/rocketmq/pull/4490/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNTbmFwc2hvdC5qYXZh) | `84.61% <0.00%> (-15.39%)` | :arrow_down: | | [.../apache/rocketmq/common/stats/MomentStatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/4490/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtLmphdmE=) | `38.09% <0.00%> (-9.53%)` | :arrow_down: | | [...va/org/apache/rocketmq/store/FlushDiskWatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4490/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0ZsdXNoRGlza1dhdGNoZXIuamF2YQ==) | `81.25% <0.00%> (-9.38%)` | :arrow_down: | | [...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4490/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=) | `39.13% <0.00%> (-8.70%)` | :arrow_down: | | [...va/org/apache/rocketmq/logging/inner/Appender.java](https://codecov.io/gh/apache/rocketmq/pull/4490/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9BcHBlbmRlci5qYXZh) | `29.21% <0.00%> (-7.87%)` | :arrow_down: | | [...org/apache/rocketmq/store/ha/WaitNotifyObject.java](https://codecov.io/gh/apache/rocketmq/pull/4490/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL1dhaXROb3RpZnlPYmplY3QuamF2YQ==) | `66.07% <0.00%> (-7.15%)` | :arrow_down: | | [...ache/rocketmq/broker/topic/TopicConfigManager.java](https://codecov.io/gh/apache/rocketmq/pull/4490/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvdG9waWMvVG9waWNDb25maWdNYW5hZ2VyLmphdmE=) | `54.61% <0.00%> (-4.62%)` | :arrow_down: | |
[GitHub] [rocketmq] tsunghanjacktsai commented on a diff in pull request #4488: [ISSUE #4487]The trackType is wrong when the consumer in broadcasting subscription.
tsunghanjacktsai commented on code in PR #4488:
URL: https://github.com/apache/rocketmq/pull/4488#discussion_r902110450
##
common/src/main/java/org/apache/rocketmq/common/protocol/ResponseCode.java:
##
@@ -80,4 +80,6 @@ public class ResponseCode extends RemotingSysResponseCode {
public static final int UPDATE_GLOBAL_WHITE_ADDRS_CONFIG_FAILED = 211;
+public static final int CONSUME_BROADCASTING = 212;
Review Comment:
"BROADCAST_CONSUMPTION" should be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] tsunghanjacktsai commented on a diff in pull request #4488: [ISSUE #4487]The trackType is wrong when the consumer in broadcasting subscription.
tsunghanjacktsai commented on code in PR #4488:
URL: https://github.com/apache/rocketmq/pull/4488#discussion_r902108319
##
tools/src/main/java/org/apache/rocketmq/tools/admin/DefaultMQAdminExtImpl.java:
##
@@ -320,8 +321,18 @@ public ConsumeStats examineConsumeStats(String
consumerGroup,
}
if (result.getOffsetTable().isEmpty()) {
-throw new MQClientException(ResponseCode.CONSUMER_NOT_ONLINE,
-"Not found the consumer group consume stats, because return
offset table is empty, maybe the consumer not consume any message");
+ConsumerConnection connection;
+try {
+connection = this.examineConsumerConnectionInfo(consumerGroup);
+} catch (Exception e) {
+throw new MQClientException(ResponseCode.CONSUMER_NOT_ONLINE,
+"Not found the consumer group consume stats, because
return offset table is empty, maybe the consumer not online");
+}
+
+if
(connection.getMessageModel().equals(MessageModel.BROADCASTING)) {
+throw new MQClientException(ResponseCode.CONSUME_BROADCASTING,
+"Not found the consumer group consume stats, because
return offset table is empty, the consumer using in broadcast model");
Review Comment:
Hi @zhangjidi2016 ,
Thx for your contribution.
Please rephrase the "the consumer using in broadcast model" into "the
consumer is under the broadcast mode". A good exception message would make us
more perfect :-)
##
common/src/main/java/org/apache/rocketmq/common/protocol/ResponseCode.java:
##
@@ -80,4 +80,6 @@ public class ResponseCode extends RemotingSysResponseCode {
public static final int UPDATE_GLOBAL_WHITE_ADDRS_CONFIG_FAILED = 211;
+public static final int CONSUME_BROADCASTING = 212;
Review Comment:
Would prefer "BROADCAST_CONSUMPTION".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[VOTE]Release Apache RocketMQ 4.9.4 RC1
Hello RocketMQ Community, This is the vote for 4.9.4 RC1 of Apache RocketMQ. This release is to improve some features and issues for apache rocketmq,such as enhance acl , package dependency optimization, improve encode/decode performance，fix some bugs and issues and so on. The artifacts: https://dist.apache.org/repos/dist/dev/rocketmq/4.9.4-rc1/ The staging repo: https://repository.apache.org/content/repositories/orgapacherocketmq-1086/ Git tag for the release: https://github.com/apache/rocketmq/releases/tag/rocketmq-all-4.9.4 Hash for the release tag: 06f2208a34907211591114f6b0d327168c250fb3 Release Notes: https://rocketmq.apache.org/release_notes/release-notes-4.9.4 The artifacts have been signed with Key : D011F2A8C9474A34099477A5C99B3EAC6B119386, which can be found in the keys file: https://dist.apache.org/repos/dist/dev/rocketmq/KEYS Checklist for reference, Note that this is not an official policy but may help with checking releases. Fill in the following: [ ] check LICENSE, should be Apache V2 [ ] check NOTICE, should have a notice for third-party dependency if necessary [ ] extract the zip and check if the source version is correct [ ] verify the asc(PGP sign),SHA512 [ ] build the source, start nameserver and broker according to the quick-start [ ] run clusterList command to see if the version is correct The vote will be open for at least 72 hours or until the necessary number of votes are reached. Please vote accordingly: [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove with the reason Thanks The Apache RocketMQ Team
[GitHub] [rocketmq] codecov-commenter commented on pull request #4488: [ISSUE #4487]The trackType is wrong when the consumer in broadcasting subscription.
codecov-commenter commented on PR #4488: URL: https://github.com/apache/rocketmq/pull/4488#issuecomment-1161116597 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4488?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#4488](https://codecov.io/gh/apache/rocketmq/pull/4488?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8300744) into [develop](https://codecov.io/gh/apache/rocketmq/commit/f34c185e05f5b1a1cc372fa72718d6b40ed6e5cc?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f34c185) will **decrease** coverage by `0.26%`. > The diff coverage is `50.00%`. ```diff @@ Coverage Diff @@ ## develop#4488 +/- ## = - Coverage 48.13% 47.87% -0.27% + Complexity 5129 5083 -46 = Files649 649 Lines 4302143031 +10 Branches5625 5628 +3 = - Hits 2070920601 -108 - Misses 1980819916 +108 - Partials2504 2514 +10 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4488?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../apache/rocketmq/common/protocol/ResponseCode.java](https://codecov.io/gh/apache/rocketmq/pull/4488/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvUmVzcG9uc2VDb2RlLmphdmE=) | `0.00% <ø> (ø)` | | | [.../tools/command/message/QueryMsgByIdSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4488/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvbWVzc2FnZS9RdWVyeU1zZ0J5SWRTdWJDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4488/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2FkbWluL0RlZmF1bHRNUUFkbWluRXh0SW1wbC5qYXZh) | `40.81% <50.00%> (+1.83%)` | :arrow_up: | | [...org/apache/rocketmq/tools/admin/api/TrackType.java](https://codecov.io/gh/apache/rocketmq/pull/4488/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2FkbWluL2FwaS9UcmFja1R5cGUuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...rg/apache/rocketmq/common/stats/StatsSnapshot.java](https://codecov.io/gh/apache/rocketmq/pull/4488/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNTbmFwc2hvdC5qYXZh) | `84.61% <0.00%> (-15.39%)` | :arrow_down: | | [.../apache/rocketmq/common/stats/MomentStatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/4488/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtLmphdmE=) | `38.09% <0.00%> (-9.53%)` | :arrow_down: | | [...va/org/apache/rocketmq/store/FlushDiskWatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4488/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0ZsdXNoRGlza1dhdGNoZXIuamF2YQ==) | `81.25% <0.00%> (-9.38%)` | :arrow_down: | | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4488/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `44.77% <0.00%> (-8.96%)` | :arrow_down: | |
[GitHub] [rocketmq] zhangjidi2016 opened a new pull request, #4490: [ISSUE #4489]Some trace messages not being sent to the broker in time before producer shutdown.
zhangjidi2016 opened a new pull request, #4490: URL: https://github.com/apache/rocketmq/pull/4490 **Make sure set the target branch to `develop`** ## What is the purpose of the change #4489 ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-eventbridge] 2011shenlin merged pull request #24: upgrade the readme.
2011shenlin merged PR #24: URL: https://github.com/apache/rocketmq-eventbridge/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] zhangjidi2016 opened a new issue, #4489: Some trace messages not being sent to the broker in time before producer shutdown
zhangjidi2016 opened a new issue, #4489: URL: https://github.com/apache/rocketmq/issues/4489 **BUG REPORT** 1. Please describe the issue you observed: - What did you do (The steps to reproduce)? send message with trace on in Producer demo - What is expected to see? the message trace information - What did you see instead? message trace query failed  2. Please tell us about your environment: 4.9.3-SNAPSHOT 4. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc): **why this happen:**   **In both cases, shutdown the producer will result in some trace messages not being sent to the broker in time** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4482: [ISSUE #4481]lock method invoke should before try scope
coveralls commented on PR #4482: URL: https://github.com/apache/rocketmq/pull/4482#issuecomment-1161100957 [](https://coveralls.io/builds/50195872) Coverage increased (+0.08%) to 52.098% when pulling **1430c156950d6d82f356273cc559bca6d9f84964 on djl394922860:develop** into **32733e76747f3db761ace75cfed6d6fdcdaee81a on apache:develop**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-externals] dependabot[bot] opened a new pull request, #883: Bump mysql-connector-java from 6.0.6 to 8.0.28 in /rocketmq-mysql
dependabot[bot] opened a new pull request, #883: URL: https://github.com/apache/rocketmq-externals/pull/883 Bumps [mysql-connector-java](https://github.com/mysql/mysql-connector-j) from 6.0.6 to 8.0.28. Changelog Sourced from https://github.com/mysql/mysql-connector-j/blob/release/8.0/CHANGES;>mysql-connector-java's changelog. Changelog https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/;>https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/ Version 8.0.29 Fix for Bug#21978230, COMMENT PARSING NOT PROPER IN PREPSTMT.EXECUTEBATCH(). Fix for Bug#81468 (23312764), MySQL server fails to rewrite batch insert when column name contains word select. Fix for Bug#106435 (33850099), 8.0.28 Connector/J has regressive in setAutoCommit after Bug#104067 (33054827). Fix for Bug#106240 (33781440), StringIndexOutOfBoundsException when VALUE is at the end of the query. Fix for Bug#106397 (33893591), Contribution: fix: fix LocalizedErrorMessages.properties doc: less then - ... Thanks to Jianjian Song for his contribution. Fix for Bug#77924 (25710160), JDBC SOCKS SHOULD NOT PERFORM LOCAL DNS RESOLUTION. Fix for Bug#82084 (23743938), YEAR DATA TYPE RETURNS INCORRECT VALUE FOR JDBC GETCOLUMNTYPE(). Fix for Bug#106441 (33850155), Add charset mapping for utf8mb3. WL#15048, Upgrade Protocol Buffers dependency to protobuf-java-3.19.4. Fix for Bug#106065 (33726184) Contribution: BigDecimal.toPlainString no need to check decimal exponent. Thanks to Baoyi Chen for his contribution. Fix for Bug#106171 (33757217), Contribution: Remove unnecessary boxing in ResultSetImpl. Thanks to Ningpp Ning for his contribution. Fix for Bug#25701740, STMT EXECUTION FAILS FOR REPLICATION CONNECTION WHEN USECURSORFETCH=TRUE. Fix for Bug#33723611, getDefaultTransactionIsolation must return repeatable read. Fix for Bug#38954 (11749415), DATA TRUNCATION WHILE USING BIT(1) IN STORED PROCEDURE WITH INOUT TYPE. Fix for Bug#85317 (25672958), EXECUTE BATCH WILL THROW NULL POINTER EXCEPTION WHERE THE COLUMN IS BLOB! Fix for Bug#105915 (33678490), Connector/J 8 server prepared statement precision loss in execute batch. Fix for Bug#104349 (33563548), com.mysql.cj NPE. Fix for Bug#62006 (16714956), JAVA.IO.NOTSERIALIZABLEEXCEPTION: JAVA.IO.STRINGREADER WHEN PROFILESQL=TRUE. WL#14750, Better unification of query bindings. WL#14834, Support for FIDO authentication. WL#14835, Align TLS option checking across connectors. ... (truncated) Commits https://github.com/mysql/mysql-connector-j/commit/7ff2161da3899f379fb3171b6538b191b1c5c7e2;>7ff2161 Updating copyright years https://github.com/mysql/mysql-connector-j/commit/b13af389b3e0f0afe4366ecddbe7e8c541bfb606;>b13af38 Fix for DateTimeTest according to changes in MySQL server. https://github.com/mysql/mysql-connector-j/commit/5c7b7753287e1399b3437aae2253acf611acd54d;>5c7b775 Update in test for Bug#96900 (30355150). https://github.com/mysql/mysql-connector-j/commit/e1169ee5adf5561dad2814b4ede82dd167ee6e93;>e1169ee Fix for Bug#99260 (31189960), statement.setQueryTimeout,creates a database co... https://github.com/mysql/mysql-connector-j/commit/05778ef59adc154df1a81bcfbd7b5913859f4b31;>05778ef Fix for Bug#103324 (32770013), X DevAPI Collection.replaceOne() missing match... https://github.com/mysql/mysql-connector-j/commit/48219f28f8dab9855803d2c34f9d43c3da4c5393;>48219f2 Fix for Bug#105197 (33461744), Statement.executeQuery() may return non-naviga... https://github.com/mysql/mysql-connector-j/commit/24cf7e22e8f8381d076d18bce8d569812e1a0d26;>24cf7e2 Fix for Bug#105323 (33507321), README.md contains broken links. https://github.com/mysql/mysql-connector-j/commit/ad46620321e815fb22bed3c81f278cab8fbfe891;>ad46620 Fix for Bug#96900 (30355150), STATEMENT.CANCEL()CREATE A DATABASE https://github.com/mysql/mysql-connector-j/commit/4d19ea1a60ac9e97aae9074190c08c6f097a00ed;>4d19ea1 Fix for Bug#104067 (33054827), No reset autoCommit after unknown issue occurs. https://github.com/mysql/mysql-connector-j/commit/bc45d35c2d023d2e82dc6c3e2b12745389f3c3c1;>bc45d35 Fix for Bug#85223 (25656020), MYSQLSQLXML SETSTRING CRASH. Additional commits viewable in https://github.com/mysql/mysql-connector-j/compare/6.0.6...8.0.28;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase
[GitHub] [rocketmq] coveralls commented on pull request #4488: [ISSUE #4487]The trackType is wrong when the consumer in broadcasting subscription.
coveralls commented on PR #4488: URL: https://github.com/apache/rocketmq/pull/4488#issuecomment-1160396999 [](https://coveralls.io/builds/50175760) Coverage decreased (-0.2%) to 51.8% when pulling **e668c975d3212b295b2ee1cd604dd8daf8cf on zhangjidi2016:fix_boardcast_consume_status** into **32733e76747f3db761ace75cfed6d6fdcdaee81a on apache:develop**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] zhangjidi2016 opened a new pull request, #4488: [ISSUE #4487]The trackType is wrong when the consumer in broadcasting subscription.
zhangjidi2016 opened a new pull request, #4488: URL: https://github.com/apache/rocketmq/pull/4488 **Make sure set the target branch to `develop`** ## What is the purpose of the change #4487 ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] zhangjidi2016 opened a new issue, #4487: The
zhangjidi2016 opened a new issue, #4487: URL: https://github.com/apache/rocketmq/issues/4487 The consumer trackType is **NOT_ONLINE** in BROADCASTING mode, this is inaccurate and a type should be added to represent broadcast subscriptions   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-site] ShannonDing merged pull request #131: Add committer: Aaron Ai
ShannonDing merged PR #131: URL: https://github.com/apache/rocketmq-site/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-site] ShannonDing merged pull request #133: [ISSUES #132] add 4.9.4 release note
ShannonDing merged PR #133: URL: https://github.com/apache/rocketmq-site/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-site] odbozhou opened a new pull request, #133: [ISSUES #132] add 4.9.4 release note
odbozhou opened a new pull request, #133: URL: https://github.com/apache/rocketmq-site/pull/133 Please do not create a Pull Request without creating an issue first. ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-site] odbozhou opened a new issue, #132: add 4.9.4 release note
odbozhou opened a new issue, #132: URL: https://github.com/apache/rocketmq-site/issues/132 The issue tracker is **ONLY** used for bug report and feature request. Any question or RocketMQ proposal please use our [mailing lists](http://rocketmq.apache.org/about/contact/). **BUG REPORT** 1. Please describe the issue you observed: - What did you do (The steps to reproduce)? - What did you expect to see? - What did you see instead? 2. Please tell us about your environment: 3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc): **FEATURE REQUEST** 1. Please describe the feature you are requesting. 2. Provide any additional detail on your proposed use case for this feature. 2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? 4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task: - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here, - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 description here, - ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] BurningCN commented on issue #4480: Question about TopicFilterType
BurningCN commented on issue #4480: URL: https://github.com/apache/rocketmq/issues/4480#issuecomment-1160217976 OK, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] BurningCN closed issue #4480: Question about TopicFilterType
BurningCN closed issue #4480: Question about TopicFilterType URL: https://github.com/apache/rocketmq/issues/4480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[DISCUSS][RIP-42]Support Timing Messages with Arbitrary Time Delay
Hi, RocketMQ Community: Currently, RocketMQ's delay message feature only supports delayed delivery for specific time levels. Such delay message feature(only support specific levels of delay time) is no longer enough to support the flexible usage of rocketmq. Therefore, we need a delay message feature that supports arbitrary delay time. So I would like to start an email thread to discuss RIP-42 Support Timing Messages with Arbitrary Time Delay. I have written my proposal and you can click on the link below： Google Doc: https://docs.google.com/document/d/1D6XWwY39p531c2aVi5HQll9iwzTUNT1haUFHqMoRkT0/edit?usp=sharing Shimo:https://shimo.im/docs/gXqme9PKKpIeD7qo/ If you have any questions or suggestions, please reply to this email or comment on the proposal. Thanks Juntao Ji
[GitHub] [rocketmq] tsunghanjacktsai commented on issue #4480: Question about TopicFilterType
tsunghanjacktsai commented on issue #4480: URL: https://github.com/apache/rocketmq/issues/4480#issuecomment-1160149131 Hi @BurningCN , I believe it hasn't been actually used in the current RocketMQ but is supposed to be involved within the process of tag filtering (such as being calculated in the MessageExtBrokerInner#tagsString2tagsCode). Though this did not affect the main logic of filtering, you could open up a PR if you like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-spring] panzhi33 commented on issue #444: Add default consumer namespace to DefaultRocketMQListenerContainer
panzhi33 commented on issue #444: URL: https://github.com/apache/rocketmq-spring/issues/444#issuecomment-1160129891 namespace is used for logical isolation. If a default value is set for namespace, the actual resource will become namespace%topic or namespace%group, which is not friendly to users of rocketmq who are not familiar with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[DISCUSS][RIP-43]Support Timing Messages with Arbitrary Time Delay
Hi, RocketMQ Community: Currently, RocketMQ's delay message feature only supports delayed delivery for specific time levels. Such delay message feature(only support specific levels of delay time) is no longer enough to support the flexible usage of rocketmq. Therefore, we need a delay message feature that supports arbitrary delay time. So I would like to start an email thread to discuss RIP-43 Support Timing Messages with Arbitrary Time Delay. I have written my proposal and you can click on the link below： Google Doc: https://docs.google.com/document/d/1D6XWwY39p531c2aVi5HQll9iwzTUNT1haUFHqMoRkT0/edit?usp=sharing Shimo:https://shimo.im/docs/gXqme9PKKpIeD7qo/ If you have any questions or suggestions, please reply to this email or comment on the proposal. Thanks Juntao Ji
[GitHub] [rocketmq-clients] zhouxinyu opened a new issue, #10: Add a unified doc set to introduce the design and implementation of clients
zhouxinyu opened a new issue, #10: URL: https://github.com/apache/rocketmq-clients/issues/10 To help all the clients of different languages to follow the same design and limitations, we should have a doc set to describe this information, including: 1. The design philosophy, e.g., immutable API, lightweight, and so on 2. The model introduction 3. The message type and the detailed process design 4. The consumer kind, e.g., PushConsumer, SimpleConsumer, and their advanced feature set, like order, transactional 5. Error handling, retry, exception, error, and so on 6. Core message flow, producer & consumer flow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-spring] superleo-cn commented on issue #88: Consumer batch messages API.
superleo-cn commented on issue #88: URL: https://github.com/apache/rocketmq-spring/issues/88#issuecomment-1160021646 > rocketMQTemplate.receive 后，是否需要手工调用下面的代码来提交ack呢？ ```java rocketMQTemplate.getConsumer().commitSync(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
