[GitHub] [rocketmq] dependabot[bot] opened a new pull request, #4600: Bump commons-io from 2.6 to 2.7

[GitBox]

dependabot[bot] opened a new pull request, #4600:
URL: https://github.com/apache/rocketmq/pull/4600

   Bumps commons-io from 2.6 to 2.7.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-io:commons-io&package-manager=maven&previous-version=2.6&new-version=2.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/rocketmq/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] duhenglucky merged pull request #4578: The code of 5.0.0-beta merge into develop branch

[GitBox]

duhenglucky merged PR #4578:
URL: https://github.com/apache/rocketmq/pull/4578


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] duhenglucky merged pull request #4008: Merge 5.0.0 alpha to develop

[GitBox]

duhenglucky merged PR #4008:
URL: https://github.com/apache/rocketmq/pull/4008


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] shengminw opened a new issue, #4599: Optimize enableBackpressureForAsyncMode not relying on NettyRemoting

[GitBox]

shengminw opened a new issue, #4599:
URL: https://github.com/apache/rocketmq/issues/4599

   In  [#issue4554](https://github.com/apache/rocketmq/issues/4552), I suggest 
to add  asySendBlockMode to implement BackPressure in producer. And I have 
implemented this relying on backpressure in NettyRemoting.
   ```java
   if (this.defaultMQProducer.isEnableBackpressureForAsyncMode()) {
   runnable.run();
   } else {
   try {
   executor.submit(runnable);
   } catch (RejectedExecutionException e) {
   throw new MQClientException("executor rejected ", e);
   }
   }
   ```
   To make a more accurate flow control mechanism, it is neccassary to expose 
backpressure monitor parameter to the users. 
   So I consider to re-build a backpressure mechanism in async-sending message, 
 not relying on backpressure in NettyRemoting. And at the same time, add 
message sizes as a backpressure monitor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[RESULT][VOTE]The code of 5.0.0-beta merge into develop branch

[jinrongtong]

Hi RocketMQ Community,

This is the result of the vote on the proposal that the code of 5.0.0-beta 
merge into develop branch, and it has been passed with [5] binding +1s, [3] 
non-binding:

*Binding votes +1s:*

dongeforever(dongefore...@apache.org)
Du Heng(duhengfore...@apache.org)
yukon(yu...@apache.org)
ShannonDing(ding...@apache.org)
RongtongJin(jinrongt...@apache.org)


*Non-binding votes +1s:*


cserwen(cser...@163.com)
Zhangheng Huang(wuzhenhuang0...@163.com)
lixiaoshuang(644968...@qq.com)



The code of 5.0.0-beta will be merged into develop branch soon.




Thanks,
RongtongJin

[GitHub] [rocketmq-clients] lizhanhui merged pull request #39: Support client metrics exporting

[GitBox]

lizhanhui merged PR #39:
URL: https://github.com/apache/rocketmq-clients/pull/39


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-exporter] MrLYG opened a new issue, #109: not find below metrics that described in document

[GitBox]

MrLYG opened a new issue, #109:
URL: https://github.com/apache/rocketmq-exporter/issues/109

   **Describe the bug**
   not find below metrics ：
   rocketmq_client_consume_fail_msg_count   The number of messages consumed 
fail in one hour
   rocketmq_client_consume_fail_msg_tps The number of messages consumed fail 
per second
   rocketmq_client_consume_ok_msg_tps   The number of messages consumed success 
per second
   rocketmq_client_consume_rt   The average time of consuming every message
   rocketmq_client_consumer_pull_rt The average time of pulling every 
message
   rocketmq_client_consumer_pull_tpsThe number of messages pulled by client 
per second
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Go to '...'
   2. Click on ''
   3. Scroll down to ''
   4. See error
   
   **Expected behavior**
   A clear and concise description of what you expected to happen.
   
   **Screenshots**
   If applicable, add screenshots to help explain your problem.
   
   **Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
   
   **Smartphone (please complete the following information):**
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]
   
   **Additional context**
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4562: UpdateTopicRouteInfoFromNameServer method in the concurrent lack of detection

[GitBox]

coveralls commented on PR #4562:
URL: https://github.com/apache/rocketmq/pull/4562#issuecomment-1182781403

   
   [![Coverage 
Status](https://coveralls.io/builds/50818247/badge)](https://coveralls.io/builds/50818247)
   
   Coverage increased (+0.08%) to 52.084% when pulling 
**25ed8b9a83efdf0c91e7e6086920af91264f99b7 on 
15712852007:hotfix/updateTopicRouteInfo_doubleCheckLock** into 
**6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4562: UpdateTopicRouteInfoFromNameServer method in the concurrent lack of detection

[GitBox]

coveralls commented on PR #4562:
URL: https://github.com/apache/rocketmq/pull/4562#issuecomment-1182781401

   
   [![Coverage 
Status](https://coveralls.io/builds/50818247/badge)](https://coveralls.io/builds/50818247)
   
   Coverage increased (+0.08%) to 52.084% when pulling 
**25ed8b9a83efdf0c91e7e6086920af91264f99b7 on 
15712852007:hotfix/updateTopicRouteInfo_doubleCheckLock** into 
**6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4596: [ISSUE #4595] Fix setBrokerName()

[GitBox]

coveralls commented on PR #4596:
URL: https://github.com/apache/rocketmq/pull/4596#issuecomment-1182781204

   
   [![Coverage 
Status](https://coveralls.io/builds/50818206/badge)](https://coveralls.io/builds/50818206)
   
   Coverage decreased (-0.009%) to 51.999% when pulling 
**16225f7d9888cee795c08d0ff9950eee9a75e508 on 
Oliverwqcwrw:develop-fix-setMethod-25** into 
**6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4596: [ISSUE #4595] Fix setBrokerName()

[GitBox]

coveralls commented on PR #4596:
URL: https://github.com/apache/rocketmq/pull/4596#issuecomment-1182781206

   
   [![Coverage 
Status](https://coveralls.io/builds/50818206/badge)](https://coveralls.io/builds/50818206)
   
   Coverage decreased (-0.009%) to 51.999% when pulling 
**16225f7d9888cee795c08d0ff9950eee9a75e508 on 
Oliverwqcwrw:develop-fix-setMethod-25** into 
**6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4562: UpdateTopicRouteInfoFromNameServer method in the concurrent lack of detection

[GitBox]

codecov-commenter commented on PR #4562:
URL: https://github.com/apache/rocketmq/pull/4562#issuecomment-1182778344

   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/4562?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#4562](https://codecov.io/gh/apache/rocketmq/pull/4562?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (25ed8b9) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (6f5cd4a) will **decrease** coverage by `0.20%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#4562  +/-   ##
   =
   - Coverage  48.19%   47.98%   -0.21% 
   + Complexity  5132 5106  -26 
   =
 Files649  649  
 Lines  4303743040   +3 
 Branches5629 5630   +1 
   =
   - Hits   2074020653  -87 
   - Misses 1978519871  +86 
   - Partials2512 2516   +4 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/4562?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/4562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==)
 | `50.75% <100.00%> (-0.54%)` | :arrow_down: |
   | 
[...mq/client/impl/producer/DefaultMQProducerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==)
 | `44.43% <100.00%> (-0.38%)` | :arrow_down: |
   | 
[...rg/apache/rocketmq/common/stats/StatsSnapshot.java](https://codecov.io/gh/apache/rocketmq/pull/4562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNTbmFwc2hvdC5qYXZh)
 | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
   | 
[...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/4562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==)
 | `20.00% <0.00%> (-14.29%)` | :arrow_down: |
   | 
[...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=)
 | `39.13% <0.00%> (-13.05%)` | :arrow_down: |
   | 
[.../apache/rocketmq/common/stats/MomentStatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/4562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtLmphdmE=)
 | `38.09% <0.00%> (-9.53%)` | :arrow_down: |
   | 
[...a/org/apache/rocketmq/logging/inner/SysLogger.java](https://codecov.io/gh/apache/rocketmq/pull/4562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9TeXNMb2dnZXIuamF2YQ==)
 | `28.57% <0.00%> (-5.72%)` | :arrow_down: |
   | 
[...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/4562/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRt

[GitHub] [rocketmq] coveralls commented on pull request #4598: [ISSUE #4597] Fix inaccurate judgement

[GitBox]

coveralls commented on PR #4598:
URL: https://github.com/apache/rocketmq/pull/4598#issuecomment-1182777673

   
   [![Coverage 
Status](https://coveralls.io/builds/50818231/badge)](https://coveralls.io/builds/50818231)
   
   Coverage increased (+0.2%) to 52.174% when pulling 
**dd158c5b8616af66437fe1d2d0c8e021034c54ce on 
Oliverwqcwrw:develop-fix-compare-24** into 
**6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4596: [ISSUE #4595] Fix setBrokerName()

[GitBox]

codecov-commenter commented on PR #4596:
URL: https://github.com/apache/rocketmq/pull/4596#issuecomment-1182776973

   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/4596?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#4596](https://codecov.io/gh/apache/rocketmq/pull/4596?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (16225f7) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (6f5cd4a) will **decrease** coverage by `0.23%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#4596  +/-   ##
   =
   - Coverage  48.19%   47.95%   -0.24% 
   + Complexity  5132 5099  -33 
   =
 Files649  649  
 Lines  4303743037  
 Branches5629 5629  
   =
   - Hits   2074020640 -100 
   - Misses 1978519877  +92 
   - Partials2512 2520   +8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/4596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../command/consumer/GetConsumerConfigSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4596/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvY29uc3VtZXIvR2V0Q29uc3VtZXJDb25maWdTdWJDb21tYW5kLmphdmE=)
 | `37.28% <0.00%> (ø)` | |
   | 
[...rg/apache/rocketmq/common/stats/StatsSnapshot.java](https://codecov.io/gh/apache/rocketmq/pull/4596/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNTbmFwc2hvdC5qYXZh)
 | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
   | 
[...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4596/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=)
 | `39.13% <0.00%> (-13.05%)` | :arrow_down: |
   | 
[.../apache/rocketmq/common/stats/MomentStatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/4596/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtLmphdmE=)
 | `38.09% <0.00%> (-9.53%)` | :arrow_down: |
   | 
[...va/org/apache/rocketmq/logging/inner/Appender.java](https://codecov.io/gh/apache/rocketmq/pull/4596/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9BcHBlbmRlci5qYXZh)
 | `29.21% <0.00%> (-7.87%)` | :arrow_down: |
   | 
[...tmq/namesrv/processor/DefaultRequestProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4596/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9wcm9jZXNzb3IvRGVmYXVsdFJlcXVlc3RQcm9jZXNzb3IuamF2YQ==)
 | `66.04% <0.00%> (-7.48%)` | :arrow_down: |
   | 
[...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4596/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=)
 | `41.79% <0.00%> (-5.98%)` | :arrow_down: |
   | 
[...va/org/apache/rocketmq/common/stats/StatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/4596/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtLmphdmE=)
 | `50.

[GitHub] [rocketmq] codecov-commenter commented on pull request #4598: [ISSUE #4597] Fix inaccurate judgement

[GitBox]

codecov-commenter commented on PR #4598:
URL: https://github.com/apache/rocketmq/pull/4598#issuecomment-1182776680

   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/4598?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#4598](https://codecov.io/gh/apache/rocketmq/pull/4598?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (dd158c5) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (6f5cd4a) will **decrease** coverage by `0.26%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#4598  +/-   ##
   =
   - Coverage  48.19%   47.92%   -0.27% 
   + Complexity  5132 5099  -33 
   =
 Files649  649  
 Lines  4303743037  
 Branches5629 5629  
   =
   - Hits   2074020627 -113 
   - Misses 1978519893 +108 
   - Partials2512 2517   +5 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/4598?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../tools/command/queue/QueryConsumeQueueCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4598/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvcXVldWUvUXVlcnlDb25zdW1lUXVldWVDb21tYW5kLmphdmE=)
 | `0.00% <0.00%> (ø)` | |
   | 
[...rg/apache/rocketmq/common/stats/StatsSnapshot.java](https://codecov.io/gh/apache/rocketmq/pull/4598/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNTbmFwc2hvdC5qYXZh)
 | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
   | 
[...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/4598/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==)
 | `20.00% <0.00%> (-14.29%)` | :arrow_down: |
   | 
[...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4598/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=)
 | `39.13% <0.00%> (-13.05%)` | :arrow_down: |
   | 
[.../apache/rocketmq/common/stats/MomentStatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/4598/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtLmphdmE=)
 | `38.09% <0.00%> (-9.53%)` | :arrow_down: |
   | 
[...va/org/apache/rocketmq/logging/inner/Appender.java](https://codecov.io/gh/apache/rocketmq/pull/4598/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9BcHBlbmRlci5qYXZh)
 | `29.21% <0.00%> (-7.87%)` | :arrow_down: |
   | 
[...tmq/namesrv/processor/DefaultRequestProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4598/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9wcm9jZXNzb3IvRGVmYXVsdFJlcXVlc3RQcm9jZXNzb3IuamF2YQ==)
 | `66.04% <0.00%> (-7.48%)` | :arrow_down: |
   | 
[...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4598/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0Lmphd

[GitHub] [rocketmq] coveralls commented on pull request #4594: [ISSUE #4593] Fix potentially NPE

[GitBox]

coveralls commented on PR #4594:
URL: https://github.com/apache/rocketmq/pull/4594#issuecomment-1182773432

   
   [![Coverage 
Status](https://coveralls.io/builds/50817997/badge)](https://coveralls.io/builds/50817997)
   
   Coverage decreased (-0.07%) to 51.942% when pulling 
**e599134380379b24d62e4599ab9e89eb035da075 on 
Oliverwqcwrw:develop-potentially-npe-23** into 
**6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4594: [ISSUE #4593] Fix potentially NPE

[GitBox]

coveralls commented on PR #4594:
URL: https://github.com/apache/rocketmq/pull/4594#issuecomment-1182773429

   
   [![Coverage 
Status](https://coveralls.io/builds/50817997/badge)](https://coveralls.io/builds/50817997)
   
   Coverage decreased (-0.07%) to 51.942% when pulling 
**e599134380379b24d62e4599ab9e89eb035da075 on 
Oliverwqcwrw:develop-potentially-npe-23** into 
**6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4594: [ISSUE #4593] Fix potentially NPE

[GitBox]

codecov-commenter commented on PR #4594:
URL: https://github.com/apache/rocketmq/pull/4594#issuecomment-1182772559

   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/4594?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#4594](https://codecov.io/gh/apache/rocketmq/pull/4594?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (e599134) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (6f5cd4a) will **decrease** coverage by `0.28%`.
   > The diff coverage is `78.57%`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#4594  +/-   ##
   =
   - Coverage  48.19%   47.90%   -0.29% 
   + Complexity  5132 5097  -35 
   =
 Files649  649  
 Lines  4303743038   +1 
 Branches5629 5630   +1 
   =
   - Hits   2074020616 -124 
   - Misses 1978519906 +121 
   - Partials2512 2516   +4 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/4594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java](https://codecov.io/gh/apache/rocketmq/pull/4594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vUm91dGVJbmZvTWFuYWdlci5qYXZh)
 | `78.64% <78.57%> (-0.20%)` | :arrow_down: |
   | 
[...rg/apache/rocketmq/common/stats/StatsSnapshot.java](https://codecov.io/gh/apache/rocketmq/pull/4594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNTbmFwc2hvdC5qYXZh)
 | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
   | 
[...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/4594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==)
 | `20.00% <0.00%> (-14.29%)` | :arrow_down: |
   | 
[...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=)
 | `39.13% <0.00%> (-13.05%)` | :arrow_down: |
   | 
[.../apache/rocketmq/common/stats/MomentStatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/4594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtLmphdmE=)
 | `38.09% <0.00%> (-9.53%)` | :arrow_down: |
   | 
[...va/org/apache/rocketmq/logging/inner/Appender.java](https://codecov.io/gh/apache/rocketmq/pull/4594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9BcHBlbmRlci5qYXZh)
 | `29.21% <0.00%> (-7.87%)` | :arrow_down: |
   | 
[...tmq/namesrv/processor/DefaultRequestProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9wcm9jZXNzb3IvRGVmYXVsdFJlcXVlc3RQcm9jZXNzb3IuamF2YQ==)
 | `66.04% <0.00%> (-7.48%)` | :arrow_down: |
   | 
[...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVt

[GitHub] [rocketmq-site] tsunghanjacktsai opened a new pull request, #156: Add prerequisite for 02quickstart.md (CN)

[GitBox]

tsunghanjacktsai opened a new pull request, #156:
URL: https://github.com/apache/rocketmq-site/pull/156

   Please do not create a Pull Request without creating an issue first. 
   
   ## What is the purpose of the change
   
   Inform users to get the recommended environment or software. The same 
section would be added once the English-version Quickstart has been merged.
   
   ## Brief changelog
   
   1. Add prerequisite for 02quickstart.md (CN).
   
   ## Verifying this change
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
   - [x] Make sure there is a Github issue filed for the change (usually before 
you start working on it). Trivial changes like typos do not require a Github 
issue. Your pull request should address just this issue, without pulling in 
other changes - one PR resolves one issue. 
   - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add integration-test in 
[test module](https://github.com/apache/rocketmq/tree/master/test).
   - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw commented on pull request #4592: [ISSUE #4591] Add synchronized

[GitBox]

Oliverwqcwrw commented on PR #4592:
URL: https://github.com/apache/rocketmq/pull/4592#issuecomment-1182770806

   > the best way , commit message include issue id and pr id 
   
   Thanks for your advice,i will add issue id or pr id when i submit the code 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy commented on issue #110: unable to start container process: exec: "/manager": stat /manager: no such file or directory: unknown

[GitBox]

caigy commented on issue #110:
URL: 
https://github.com/apache/rocketmq-operator/issues/110#issuecomment-1182762775

   @ccctask Thanks for your report, pls also post your `docker info` output. It 
seems that the issue has something to do with OS or docker version. 
   BTW, is your operator image built on the same environment, or built on 
machine with different OS or docker version and then transferred to the 
environment where it deployed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4592: [ISSUE #4591] Add synchronized

[GitBox]

coveralls commented on PR #4592:
URL: https://github.com/apache/rocketmq/pull/4592#issuecomment-1182755866

   
   [![Coverage 
Status](https://coveralls.io/builds/50817412/badge)](https://coveralls.io/builds/50817412)
   
   Coverage decreased (-0.09%) to 51.916% when pulling 
**4464aa24da64af67d7999d5e8d5b000fc8c1ad08 on 
Oliverwqcwrw:develop-consistent-behavior-22** into 
**6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4592: [ISSUE #4591] Add synchronized

[GitBox]

coveralls commented on PR #4592:
URL: https://github.com/apache/rocketmq/pull/4592#issuecomment-1182755863

   
   [![Coverage 
Status](https://coveralls.io/builds/50817412/badge)](https://coveralls.io/builds/50817412)
   
   Coverage decreased (-0.09%) to 51.916% when pulling 
**4464aa24da64af67d7999d5e8d5b000fc8c1ad08 on 
Oliverwqcwrw:develop-consistent-behavior-22** into 
**6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4592: [ISSUE #4591] Add synchronized

[GitBox]

codecov-commenter commented on PR #4592:
URL: https://github.com/apache/rocketmq/pull/4592#issuecomment-1182754560

   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/4592?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#4592](https://codecov.io/gh/apache/rocketmq/pull/4592?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (4464aa2) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (6f5cd4a) will **decrease** coverage by `0.32%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#4592  +/-   ##
   =
   - Coverage  48.19%   47.86%   -0.33% 
   + Complexity  5132 5090  -42 
   =
 Files649  649  
 Lines  4303743037  
 Branches5629 5629  
   =
   - Hits   2074020601 -139 
   - Misses 1978519917 +132 
   - Partials2512 2519   +7 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/4592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../apache/rocketmq/logging/inner/LoggingBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/4592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnaW5nQnVpbGRlci5qYXZh)
 | `63.44% <ø> (-0.95%)` | :arrow_down: |
   | 
[...rg/apache/rocketmq/common/stats/StatsSnapshot.java](https://codecov.io/gh/apache/rocketmq/pull/4592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNTbmFwc2hvdC5qYXZh)
 | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
   | 
[...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/4592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==)
 | `20.00% <0.00%> (-14.29%)` | :arrow_down: |
   | 
[...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=)
 | `39.13% <0.00%> (-13.05%)` | :arrow_down: |
   | 
[.../apache/rocketmq/common/stats/MomentStatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/4592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtLmphdmE=)
 | `38.09% <0.00%> (-9.53%)` | :arrow_down: |
   | 
[...va/org/apache/rocketmq/logging/inner/Appender.java](https://codecov.io/gh/apache/rocketmq/pull/4592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9BcHBlbmRlci5qYXZh)
 | `29.21% <0.00%> (-7.87%)` | :arrow_down: |
   | 
[...tmq/namesrv/processor/DefaultRequestProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9wcm9jZXNzb3IvRGVmYXVsdFJlcXVlc3RQcm9jZXNzb3IuamF2YQ==)
 | `66.04% <0.00%> (-7.48%)` | :arrow_down: |
   | 
[...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=)
 |

[GitHub] [rocketmq] djl394922860 commented on issue #4591: Inconsistent behavior

[GitBox]

djl394922860 commented on issue #4591:
URL: https://github.com/apache/rocketmq/issues/4591#issuecomment-1182750234

   I looked again and found 
   1、`FileAppender` other method like 
`org.apache.rocketmq.logging.inner.LoggingBuilder.FileAppender#setFile(java.lang.String)`
 is not decorated by synchronized , Is it necessary here and other places？
   2、for `fileName` field is direct use like `this.fileName` , not use 
`getFile()` , so is there a concurrency issue here?
   Forgive me for more questionsetc , thx again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-dashboard] baiyapeng opened a new issue, #102: can not find slave in tab of cluster

[GitBox]

baiyapeng opened a new issue, #102:
URL: https://github.com/apache/rocketmq-dashboard/issues/102

   https://user-images.githubusercontent.com/20579573/178646847-f8984ae9-88aa-4e14-b37d-79a7b8fd8da8.png";>
   
   config:
   ```
   brokerClusterName=rocketmq-cluster
   #broker名字，名字一样的节点就是一组主从节点。
   brokerName=broker-a
   #brokerid,0就表示是Master，>0的都是表示Slave
   brokerId=0
   brokerIP1=1
   #nameServer地址，分号分割
   namesrvAddr=:9876
   #在发送消息时，自动创建服务器不存在的topic，默认创建的队列数
   defaultTopicQueueNums=4
   #是否允许Broker自动创建Topic，建议线下开启，线上关闭
   autoCreateTopicEnable=true
   #是否允许Broker自动创建订阅组，建议线下开启，线上关闭autoCreateSubscriptionGroup=true
   #Broker对外服务的监听端口
   listenPort=10911
   #删除文件时间点，默认凌晨4点
   deleteWhen=04
   #文件保留时间，默认48小时
   fileReservedTime=120
   #commitLog每个文件的大小默认1G
   mapedFileSizeCommitLog=1073741824
   #ConsumeQueue每个文件默认存30W条，根据业务情况调整mapedFileSizeConsumeQueue=30
   #destroyMapedFileIntervalForcibly=12
   #redeleteHangedFileInterval=12
   #检测物理文件磁盘空间
   diskMaxUsedSpaceRatio=88
   #存储路径
   storePathRootDir=/app/rocketmq/store
   #commitLog存储路径
   storePathCommitLog=/app/rocketmq/store/commitlog
   #消费队列存储路径存储路径
   storePathConsumeQueue=/app/rocketmq/store/consumequeue
   #消息索引存储路径
   storePathIndex=/app/rocketmq/store/index
   #checkpoint文件存储路径
   storeCheckpoint=/app/rocketmq/store/checkpoint
   #abort文件存储路径
   abortFile=/app/rocketmq/store/abort
   #限制的消息大小
   maxMessageSize=65536
   #flushCommitLogLeastPages=4
   #flushConsumeQueueLeastPages=2
   #flushCommitLogThoroughInterval=1
   #flushConsumeQueueThoroughInterval=6
   #Broker的角色
   #-ASYNC_MASTER异步复制Master
   #-SYNC_MASTER同步双写Master
   #-SLAVE
   brokerRole=ASYNC_MASTER
   #刷盘方式
   #-ASYNC_FLUSH异步刷盘
   #-SYNC_FLUSH同步刷盘
   flushDiskType=ASYNC_FLUSH
   #checkTransactionMessageEnable=false
   #发消息线程池数量
   #sendMessageThreadPoolNums=128
   #拉消息线程池数量
   #pullMessageThreadPoolNums=128
   ```
   
   ```
   brokerClusterName=rocketmq-cluster
   #broker名字，名字一样的节点就是一组主从节点。
   brokerName=broker-a
   #brokerid,0就表示是Master，>0的都是表示Slave
   brokerId=2
   brokerIP1=
   #nameServer地址，分号分割
   namesrvAddr=:9876
   #在发送消息时，自动创建服务器不存在的topic，默认创建的队列数
   defaultTopicQueueNums=4
   #是否允许Broker自动创建Topic，建议线下开启，线上关闭
   autoCreateTopicEnable=true
   #是否允许Broker自动创建订阅组，建议线下开启，线上关闭autoCreateSubscriptionGroup=true
   #Broker对外服务的监听端口
   listenPort=10911
   #删除文件时间点，默认凌晨4点
   deleteWhen=04
   #文件保留时间，默认48小时
   fileReservedTime=120
   #commitLog每个文件的大小默认1G
   mapedFileSizeCommitLog=1073741824
   #ConsumeQueue每个文件默认存30W条，根据业务情况调整mapedFileSizeConsumeQueue=30
   #destroyMapedFileIntervalForcibly=12
   #redeleteHangedFileInterval=12
   #检测物理文件磁盘空间
   diskMaxUsedSpaceRatio=88
   #存储路径
   storePathRootDir=/app/rocketmq/store
   #commitLog存储路径
   storePathCommitLog=/app/rocketmq/store/commitlog
   #消费队列存储路径存储路径
   storePathConsumeQueue=/app/rocketmq/store/consumequeue
   #消息索引存储路径
   storePathIndex=/app/rocketmq/store/index
   #checkpoint文件存储路径
   storeCheckpoint=/app/rocketmq/store/checkpoint
   #abort文件存储路径
   abortFile=/app/rocketmq/store/abort
   #限制的消息大小
   maxMessageSize=65536
   #flushCommitLogLeastPages=4
   #flushConsumeQueueLeastPages=2
   #flushCommitLogThoroughInterval=1
   #flushConsumeQueueThoroughInterval=6
   #Broker的角色
   #-ASYNC_MASTER异步复制Master
   #-SYNC_MASTER同步双写Master
   #-SLAVE
   brokerRole=ASYNC_MASTER
   #刷盘方式
   #-ASYNC_FLUSH异步刷盘
   #-SYNC_FLUSH同步刷盘
   flushDiskType=ASYNC_FLUSH
   #checkTransactionMessageEnable=false
   #发消息线程池数量
   #sendMessageThreadPoolNums=128
   #拉消息线程池数量
   #pullMessageThreadPoolNums=128
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw opened a new pull request, #4598: [ISSUE #4597] Fix inaccurate judgement

[GitBox]

Oliverwqcwrw opened a new pull request, #4598:
URL: https://github.com/apache/rocketmq/pull/4598

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   Close #4597 
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw opened a new issue, #4597: Incorrect judgment

[GitBox]

Oliverwqcwrw opened a new issue, #4597:
URL: https://github.com/apache/rocketmq/issues/4597

   
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   In 
`org/apache/rocketmq/tools/command/queue/QueryConsumeQueueCommand.java:107`
   
   String can not use == or != to compare
   
   - What did you do (The steps to reproduce)?
   
   - What is expected to see?
   
   - What did you see instead?
   
   3. Please tell us about your environment:
   
   4. Other information (e.g. detailed explanation, logs, related issues, 
suggestions on how to fix, etc):
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] The code of 5.0.0-beta merge into develop branch

[黄章衡]

+1



| |
wuzhenhuang0...@163.com
|
|
邮箱：wuzhenhuang0...@163.com
|




 回复的原邮件 
| 发件人 | jinrongtong |
| 日期 | 2022年07月13日 11:32 |
| 收件人 | dev@rocketmq.apache.org |
| 抄送至 | |
| 主题 | Re:Re: [VOTE] The code of 5.0.0-beta merge into develop branch |
+1
At 2022-07-13 03:50:35, "yukon"  wrote:
>+1
>
>On Tue, Jul 12, 2022 at 2:46 PM cserwen  wrote:
>
>> +1
>>
>> > 在 2022年7月12日，10:19，jinrongtong  写道：
>> >
>> > Hi, RocketMQ Community,
>> >
>> > As discussed in the previous email, we want to merge the code of the
>> 5.0-beta into develop branch. We also create a new branch 4.9.x to fix bugs
>> in the 4.9.4 LTS version.
>> > So I start this email thread to enter the voting process for the
>> previous discussion.
>> >
>> >
>> > Note: after the 5.0.0-beta code is merged into develop branch, some
>> large pull requests that have not been merged may have code conflicts,
>> which need to be resolved by yourself.
>> >
>> >
>> > The vote will be open for at least 72 hours or until a necessary number
>> of votes are reached.
>> >
>> >
>> > Please vote accordingly:
>> > [ ] +1 approve
>> > [ ] +0 no opinion
>> > [ ] -1 disapprove with the reason
>> >
>> >
>> > Best Regards!
>> > Rongtong Jin
>>
>>

[GitHub] [rocketmq] Oliverwqcwrw opened a new pull request, #4596: [ISSUE #4595] Fix setBrokerName()

[GitBox]

Oliverwqcwrw opened a new pull request, #4596:
URL: https://github.com/apache/rocketmq/pull/4596

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   Close #4595 
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw opened a new issue, #4595: Self assigns itself

[GitBox]

Oliverwqcwrw opened a new issue, #4595:
URL: https://github.com/apache/rocketmq/issues/4595

   
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   In 
`org.apache.rocketmq.tools.command.consumer.ConsumerConfigInfo#setBrokerName`
   
   Self assigns itself
   
   - What did you do (The steps to reproduce)?
   
   - What is expected to see?
   
   - What did you see instead?
   
   3. Please tell us about your environment:
   
   4. Other information (e.g. detailed explanation, logs, related issues, 
suggestions on how to fix, etc):
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-client-python] halfbottles commented on issue #86: [Master] Try to support message trace.

[GitBox]

halfbottles commented on issue #86:
URL: 
https://github.com/apache/rocketmq-client-python/issues/86#issuecomment-1182730263

   are u still update this features ?this pack haven't updated since 2020.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-client-go] duhenglucky merged pull request #852: bugfix rebalance is not paused after suspend and rebalance not trigge…

[GitBox]

duhenglucky merged PR #852:
URL: https://github.com/apache/rocketmq-client-go/pull/852


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] djl394922860 commented on issue #4591: Inconsistent behavior

[GitBox]

djl394922860 commented on issue #4591:
URL: https://github.com/apache/rocketmq/issues/4591#issuecomment-1182726675

   > Thanks for your reply IMO, I think it would be more appropriate for 
getFile to wait while setFile() is executed. Indeed, there is no place to call 
`getFile()` at present, but if someone calls it in the future, inconsistent 
behavior may occur
   
   yep , if `getFile()` need to wait for `setFile()` , u are right , i got it , 
thx your reply.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re:Re: [VOTE] The code of 5.0.0-beta merge into develop branch

[jinrongtong]

+1
At 2022-07-13 03:50:35, "yukon"  wrote:
>+1
>
>On Tue, Jul 12, 2022 at 2:46 PM cserwen  wrote:
>
>> +1
>>
>> > 在 2022年7月12日，10:19，jinrongtong  写道：
>> >
>> > Hi, RocketMQ Community,
>> >
>> > As discussed in the previous email, we want to merge the code of the
>> 5.0-beta into develop branch. We also create a new branch 4.9.x to fix bugs
>> in the 4.9.4 LTS version.
>> > So I start this email thread to enter the voting process for the
>> previous discussion.
>> >
>> >
>> > Note: after the 5.0.0-beta code is merged into develop branch, some
>> large pull requests that have not been merged may have code conflicts,
>> which need to be resolved by yourself.
>> >
>> >
>> > The vote will be open for at least 72 hours or until a necessary number
>> of votes are reached.
>> >
>> >
>> > Please vote accordingly:
>> > [ ] +1 approve
>> > [ ] +0 no opinion
>> > [ ] -1 disapprove with the reason
>> >
>> >
>> > Best Regards!
>> > Rongtong Jin
>>
>>

[GitHub] [rocketmq] Oliverwqcwrw commented on issue #4591: Inconsistent behavior

[GitBox]

Oliverwqcwrw commented on issue #4591:
URL: https://github.com/apache/rocketmq/issues/4591#issuecomment-1182717413

   Thanks for your reply 
   IMO, I think it would be more appropriate for getFile to wait while 
setFile() is executed. Indeed, there is no place to call `getFile()` at 
present, but if someone calls it in the future, inconsistent behavior may occur


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw opened a new pull request, #4594: [ISSUE #4593] Fix potentially NPE

[GitBox]

Oliverwqcwrw opened a new pull request, #4594:
URL: https://github.com/apache/rocketmq/pull/4594

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   Close #4593 
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw opened a new issue, #4593: Potentially NPE

[GitBox]

Oliverwqcwrw opened a new issue, #4593:
URL: https://github.com/apache/rocketmq/issues/4593

   
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   In `org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java:200` exists 
potentially NPE
   
   - What did you do (The steps to reproduce)?
   
   - What is expected to see?
   
   - What did you see instead?
   
   3. Please tell us about your environment:
   
   4. Other information (e.g. detailed explanation, logs, related issues, 
suggestions on how to fix, etc):
   
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   2. Indicate the importance of this issue to you (blocker, must-have, 
should-have, nice-to-have). Are you currently using any workarounds to address 
this issue?
   
   5. If there are some sub-tasks involved, use -[] for each sub-task and 
create a corresponding issue to map to the sub-task:
   
   - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 
description here, 
   - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 
description here,
   - ...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] djl394922860 commented on issue #4591: Inconsistent behavior

[GitBox]

djl394922860 commented on issue #4591:
URL: https://github.com/apache/rocketmq/issues/4591#issuecomment-1182703622

   it can use `volatile` replace `synchronized` ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE][RIP-45]RocketMQ Replicator 2.0

[tiger lee]

+1

zhibo li  于2022年7月12日周二 14:32写道：

> Hi, RocketMQ Community,
>
>
> As discussed in the previous email, we launched a new RIP 45 to enhance
> RocketMQ Replicator. Now the shepherds @duhenglucky and @dongeforever are
> willing to support the RIP, so I think it is time to start an email thread
> to enter the voting process.
>
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
>
> Please vote accordingly:
>
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
>
>
>
> Best Regards!
>
> Lizhibo
>
>
>
> links:
>
> English proposal:
>
> https://docs.google.com/document/d/1_gd3ijNW38cHQTeI_iOUX9hg4n_RVGQDLnZxLMJr0lg/edit?usp=sharing
> <
> https://docs.google.com/document/d/1tSJkor_3Js4NBaVA0UENGyM8Mh0SrRMXszRyI91hjJ8/edit?usp=sharing
> >
>
> Chinese proposal:
> https://shimo.im/file-invite/3EMTZwcWNFh8NW4Vgj4dKtlmGJXK6/
>

[GitHub] [rocketmq-operator] feiyuyitiao commented on issue #114: the 'console' create failed.

[GitBox]

feiyuyitiao commented on issue #114:
URL: 
https://github.com/apache/rocketmq-operator/issues/114#issuecomment-1182701198

   fix by change code:  pkg/controller/console/console_controller.go:201
   `//Labels: 
cr.Spec.ConsoleDeployment.Spec.Template.ObjectMeta.Labels,
Labels: 
cr.Spec.ConsoleDeployment.Spec.Selector.MatchLabels,  `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] feiyuyitiao commented on issue #111: rocketmq-operator/bin/controller-gen: No such file or directory

[GitBox]

feiyuyitiao commented on issue #111:
URL: 
https://github.com/apache/rocketmq-operator/issues/111#issuecomment-1182700605

   fix by exec command:   ` make run` first ,   which will generate 
`bin/controller-gen`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw opened a new pull request, #4592: [ISSUE #4591] Add synchronized

[GitBox]

Oliverwqcwrw opened a new pull request, #4592:
URL: https://github.com/apache/rocketmq/pull/4592

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   Close #4591 
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw opened a new issue, #4591: Inconsistent behavior

[GitBox]

Oliverwqcwrw opened a new issue, #4591:
URL: https://github.com/apache/rocketmq/issues/4591

   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   I notice the 
`org.apache.rocketmq.logging.inner.LoggingBuilder.FileAppender#setFile(java.lang.String,
 boolean, boolean, int)` is decorated by synchronized,but 
`org.apache.rocketmq.logging.inner.LoggingBuilder.FileAppender#getFile` do not 
decorated by synchronized, if someone call getName() will occur inconsistent 
behavior
   
   - What did you do (The steps to reproduce)?
   
   - What is expected to see?
   
   - What did you see instead?
   
   3. Please tell us about your environment:
   
   4. Other information (e.g. detailed explanation, logs, related issues, 
suggestions on how to fix, etc):
   
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   2. Indicate the importance of this issue to you (blocker, must-have, 
should-have, nice-to-have). Are you currently using any workarounds to address 
this issue?
   
   5. If there are some sub-tasks involved, use -[] for each sub-task and 
create a corresponding issue to map to the sub-task:
   
   - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 
description here, 
   - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 
description here,
   - ...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw opened a new pull request, #4590: [ISSUE #4589] Close stream

[GitBox]

Oliverwqcwrw opened a new pull request, #4590:
URL: https://github.com/apache/rocketmq/pull/4590

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   Close #4589 
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw opened a new issue, #4589: The stream do not close

[GitBox]

Oliverwqcwrw opened a new issue, #4589:
URL: https://github.com/apache/rocketmq/issues/4589

   
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   In 
`org.apache.rocketmq.logging.inner.LoggingBuilder.FileAppender#setFile(java.lang.String,
 boolean, boolean, int)`
   
   ostream do not close
   
   > 
try {
   ostream = new FileOutputStream(fileName, append);
   } catch (FileNotFoundException ex) {
   String parentName = new File(fileName).getParent();
   if (parentName != null) {
   File parentDir = new File(parentName);
   if (!parentDir.exists() && parentDir.mkdirs()) {
   ostream = new FileOutputStream(fileName, append);
   } else {
   throw ex;
   }
   } else {
   throw ex;
   }
   }
   Writer fw = createWriter(ostream);
   if (bufferedIO) {
   fw = new BufferedWriter(fw, bufferSize);
   }
   this.setQWForFiles(fw);
   this.fileName = fileName;
   this.fileAppend = append;
   this.bufferedIO = bufferedIO;
   this.bufferSize = bufferSize;
   writeHeader();
   SysLogger.debug("setFile ended");
   
   - What did you do (The steps to reproduce)?
   
   - What is expected to see?
   
   - What did you see instead?
   
   3. Please tell us about your environment:
   
   4. Other information (e.g. detailed explanation, logs, related issues, 
suggestions on how to fix, etc):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] ccctask commented on issue #110: unable to start container process: exec: "/manager": stat /manager: no such file or directory: unknown

[GitBox]

ccctask commented on issue #110:
URL: 
https://github.com/apache/rocketmq-operator/issues/110#issuecomment-1182686580

   same issue with me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-site] caigy commented on a diff in pull request #153: Add 02quickstart.md (en)

[GitBox]

caigy commented on code in PR #153:
URL: https://github.com/apache/rocketmq-site/pull/153#discussion_r919572789


##
docs/09-英文/01-Introduction/02quickstart.md:
##
@@ -0,0 +1,93 @@
+# Quickstart
+
+This section will introduce the method of quickly building and deploying a 
single-Master RocketMQ cluster to complete simple message sending and receiving.
+
+## 1. Get Apache RocketMQ
+
+:::tip Download RocketMQ
+
+RocketMQ's installation is divided into two types: binary and source. Click 
[here](https://www.apache.org/dyn/closer.cgi?path=rocketmq/4.9.4/rocketmq-all-4.9.4-source-release.zip)
 to download Apache RocketMQ 4.9.4 source package, or download the binary 
package from 
[here](https://www.apache.org/dyn/closer.cgi?path=rocketmq/4.9.4/rocketmq-all-4.9.4-bin-release.zip).
 The binary package can be run directly since it has been compiled, and the 
source package needs to be compiled and run.

Review Comment:
   > Great point, but this might need some work in the frontend.
   
   IMO a new issue could be created to achieve it. It's OK for the first 
version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] lizhiboo commented on issue #4587: Can rocketmq thread pool add a "bottom-up" scheme to catch exceptions

[GitBox]

lizhiboo commented on issue #4587:
URL: https://github.com/apache/rocketmq/issues/4587#issuecomment-1182662070

   @liuzongliang0202 Good catch! Do u willing to submit a pr to make it perfect?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-client-cpp] ifplusor merged pull request #432: reduce unnecessary memory malloc

[GitBox]

ifplusor merged PR #432:
URL: https://github.com/apache/rocketmq-client-cpp/pull/432


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy commented on issue #110: unable to start container process: exec: "/manager": stat /manager: no such file or directory: unknown

[GitBox]

caigy commented on issue #110:
URL: 
https://github.com/apache/rocketmq-operator/issues/110#issuecomment-1181728868

   @suuugeee Could you enter the operator container to check whether /manager 
exists?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy commented on issue #114: the 'console' create failed.

[GitBox]

caigy commented on issue #114:
URL: 
https://github.com/apache/rocketmq-operator/issues/114#issuecomment-1181731014

   @feiyuyitiao Is `spec.template.metadata.labels` defined in `console.yaml`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE][RIP-45]RocketMQ Replicator 2.0

[zhibo li]

English proposal link is error, refer to
https://docs.google.com/document/d/1_gd3ijNW38cHQTeI_iOUX9hg4n_RVGQDLnZxLMJr0lg/edit?usp=sharing

zhibo li  于2022年7月12日周二 14:31写道：

> Hi, RocketMQ Community,
>
>
> As discussed in the previous email, we launched a new RIP 45 to enhance
> RocketMQ Replicator. Now the shepherds @duhenglucky and @dongeforever are
> willing to support the RIP, so I think it is time to start an email thread
> to enter the voting process.
>
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
>
> Please vote accordingly:
>
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
>
>
>
> Best Regards!
>
> Lizhibo
>
>
>
> links:
>
> English proposal:
> https://docs.google.com/document/d/1_gd3ijNW38cHQTeI_iOUX9hg4n_RVGQDLnZxLMJr0lg/edit?usp=sharing
> 
>
> Chinese proposal:
> https://shimo.im/file-invite/3EMTZwcWNFh8NW4Vgj4dKtlmGJXK6/
>

[GitHub] [rocketmq-mqtt] DongyuanPan opened a new pull request, #122: change meta to be a consistency module implemented by JRAFT

[GitBox]

DongyuanPan opened a new pull request, #122:
URL: https://github.com/apache/rocketmq-mqtt/pull/122

   #121 
   The framework of consistency module is preliminarily realized.This PR 
implements multi-raft group management with different business processors and 
linearly consistent reads. But there's a lot of work to be done. 
   1) A snapshot management module is also required to achieve fast recovery of 
the state machine.
   2) Data fragmentation module. Implement automatic routing of data to the 
corresponding raft group.
   3) The ability for new nodes to automatically join the original raft group. 
It means that the original raft node does not need to be restarted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE][RIP-45]RocketMQ Replicator 2.0

[zhibo li]

@dongeforever, Replicator 2.0 mainly focus on at least once delivery
semantics. Offset in source cluster is different from offset destination
cluster, it's hard to implement, we can fulfill it in the future.

dongeforever  于2022年7月12日周二 14:44写道：

> +1.
>
> BTW, currently, it does not have an offset replicator for Group Offsets.
>
> zhibo li  于2022年7月12日周二 14:32写道：
>
> > Hi, RocketMQ Community,
> >
> >
> > As discussed in the previous email, we launched a new RIP 45 to enhance
> > RocketMQ Replicator. Now the shepherds @duhenglucky and @dongeforever are
> > willing to support the RIP, so I think it is time to start an email
> thread
> > to enter the voting process.
> >
> >
> > The vote will be open for at least 72 hours or until a necessary number
> of
> > votes are reached.
> >
> >
> > Please vote accordingly:
> >
> >
> > [ ] +1 approve
> >
> > [ ] +0 no opinion
> >
> > [ ] -1 disapprove with the reason
> >
> >
> >
> >
> >
> > Best Regards!
> >
> > Lizhibo
> >
> >
> >
> > links:
> >
> > English proposal:
> >
> >
> https://docs.google.com/document/d/1_gd3ijNW38cHQTeI_iOUX9hg4n_RVGQDLnZxLMJr0lg/edit?usp=sharing
> > <
> >
> https://docs.google.com/document/d/1tSJkor_3Js4NBaVA0UENGyM8Mh0SrRMXszRyI91hjJ8/edit?usp=sharing
> > >
> >
> > Chinese proposal:
> > https://shimo.im/file-invite/3EMTZwcWNFh8NW4Vgj4dKtlmGJXK6/
> >
>

[GitHub] [rocketmq] coveralls commented on pull request #4586: [ISSUE #4579] Add unit test

[GitBox]

coveralls commented on PR #4586:
URL: https://github.com/apache/rocketmq/pull/4586#issuecomment-1181881364

   
   [![Coverage 
Status](https://coveralls.io/builds/50798100/badge)](https://coveralls.io/builds/50798100)
   
   Coverage remained the same at 52.009% when pulling 
**8cb34fb7e7d512dc146c3a49579bcaf37f86f092 on Oliverwqcwrw:develop-add-ut-20** 
into **6f5cd4aa40de1a121d2d47f8b9175a86c0e7bcc2 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] The code of 5.0.0-beta merge into develop branch

[yukon]

+1

On Tue, Jul 12, 2022 at 2:46 PM cserwen  wrote:

> +1
>
> > 在 2022年7月12日，10:19，jinrongtong  写道：
> >
> > Hi, RocketMQ Community,
> >
> > As discussed in the previous email, we want to merge the code of the
> 5.0-beta into develop branch. We also create a new branch 4.9.x to fix bugs
> in the 4.9.4 LTS version.
> > So I start this email thread to enter the voting process for the
> previous discussion.
> >
> >
> > Note: after the 5.0.0-beta code is merged into develop branch, some
> large pull requests that have not been merged may have code conflicts,
> which need to be resolved by yourself.
> >
> >
> > The vote will be open for at least 72 hours or until a necessary number
> of votes are reached.
> >
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> >
> > Best Regards!
> > Rongtong Jin
>
>

[GitHub] [rocketmq-operator] feiyuyitiao commented on issue #111: rocketmq-operator/bin/controller-gen: No such file or directory

[GitBox]

feiyuyitiao commented on issue #111:
URL: 
https://github.com/apache/rocketmq-operator/issues/111#issuecomment-1181642620

   any updates? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-clients] aaron-ai merged pull request #40: Java: adapt to the latest protocol

[GitBox]

aaron-ai merged PR #40:
URL: https://github.com/apache/rocketmq-clients/pull/40


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] djl394922860 opened a new issue, #4588: Only when the force is successful can the flushedPosition be updated

[GitBox]

djl394922860 opened a new issue, #4588:
URL: https://github.com/apache/rocketmq/issues/4588

   ### 1、Please describe the issue you observed:
   https://user-images.githubusercontent.com/12888788/178465277-23dee3ad-b9b8-44a2-9064-a116d1483da1.png";>
   
   ### 2、Please tell us about your environment:
   branch：develop
   ### 3、Other information (e.g. detailed explanation, logs, related issues, 
suggestions on how to fix, etc):
   as title , If it's a problem, I'll fix it etc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-clients] aaron-ai closed pull request #42: Java: refactor MessageMeter

[GitBox]

aaron-ai closed pull request #42: Java: refactor MessageMeter
URL: https://github.com/apache/rocketmq-clients/pull/42


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-clients] aaron-ai closed issue #41: Java: refactor MessageMeter

[GitBox]

aaron-ai closed issue #41: Java: refactor MessageMeter
URL: https://github.com/apache/rocketmq-clients/issues/41


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-schema-registry] MatrixHB opened a new issue, #3: Optimize the cache refresh mechanism

[GitBox]

MatrixHB opened a new issue, #3:
URL: https://github.com/apache/rocketmq-schema-registry/issues/3

   Schema registry uses RocksDB as local cache and uses RocketMQ as remote 
storage.  Now the local cache refresh is implemented by pushConsumer consuming 
messages from RocketMQ. I found two problems with current code.
   1、Using pushConsumer in cluster mode, it must be ensured that each node is a 
different consumer group, otherwise each node cannot synchronize the complete 
data.
   2、Lack of replay mechanism. When a registry node restart with incomplete 
local cache, or cold start with empty local cache, we need to pull the complete 
data from RocketMQ storage to recover the local cache. Therefore, it's better 
to maintain checkpoint and use pullConsumer to seek specified offset, which is 
also the suggested way to consume compact topic messages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] djl394922860 commented on issue #4588: Only when the force method call is successful , that can the flushedPosition be updated

[GitBox]

djl394922860 commented on issue #4588:
URL: https://github.com/apache/rocketmq/issues/4588#issuecomment-1181688235

   I thought about it again, maybe I'm wrong, because the next time the force 
method call is successful, the flushedPosition will be updated normally...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-clients] aaron-ai merged pull request #42: Java: refactor MessageMeter

[GitBox]

aaron-ai merged PR #42:
URL: https://github.com/apache/rocketmq-clients/pull/42


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Re: [VOTE][RIP-45]RocketMQ Replicator 2.0

[周波]

+1

jinrongtong  于2022年7月12日周二 16:47写道：

> +1
> 在 2022-07-12 15:19:14，"heng du"  写道：
> >+1
> >
> >dongeforever  于2022年7月12日周二 14:44写道：
> >
> >> +1.
> >>
> >> BTW, currently, it does not have an offset replicator for Group Offsets.
> >>
> >> zhibo li  于2022年7月12日周二 14:32写道：
> >>
> >> > Hi, RocketMQ Community,
> >> >
> >> >
> >> > As discussed in the previous email, we launched a new RIP 45 to
> enhance
> >> > RocketMQ Replicator. Now the shepherds @duhenglucky and @dongeforever
> are
> >> > willing to support the RIP, so I think it is time to start an email
> >> thread
> >> > to enter the voting process.
> >> >
> >> >
> >> > The vote will be open for at least 72 hours or until a necessary
> number
> >> of
> >> > votes are reached.
> >> >
> >> >
> >> > Please vote accordingly:
> >> >
> >> >
> >> > [ ] +1 approve
> >> >
> >> > [ ] +0 no opinion
> >> >
> >> > [ ] -1 disapprove with the reason
> >> >
> >> >
> >> >
> >> >
> >> >
> >> > Best Regards!
> >> >
> >> > Lizhibo
> >> >
> >> >
> >> >
> >> > links:
> >> >
> >> > English proposal:
> >> >
> >> >
> >>
> https://docs.google.com/document/d/1_gd3ijNW38cHQTeI_iOUX9hg4n_RVGQDLnZxLMJr0lg/edit?usp=sharing
> >> > <
> >> >
> >>
> https://docs.google.com/document/d/1tSJkor_3Js4NBaVA0UENGyM8Mh0SrRMXszRyI91hjJ8/edit?usp=sharing
> >> > >
> >> >
> >> > Chinese proposal:
> >> > https://shimo.im/file-invite/3EMTZwcWNFh8NW4Vgj4dKtlmGJXK6/
> >> >
> >>
>

[GitHub] [rocketmq-operator] feiyuyitiao opened a new issue, #114: the 'console' create failed.

[GitBox]

feiyuyitiao opened a new issue, #114:
URL: https://github.com/apache/rocketmq-operator/issues/114

   operator got error when apply console.yaml
   ```
   2022-07-12T10:58:11.493ZERROR   controller.console-controller   
Reconciler error{"name": "console", "namespace": "mq", 
   "error": "Deployment.apps \"console\" is invalid: 
spec.template.metadata.labels: Invalid value: map[string]string(nil): 
`selector` does not match template `labels`"}
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] feiyuyitiao commented on issue #113: :rocketmq-operator" cannot get resource "leases

[GitBox]

feiyuyitiao commented on issue #113:
URL: 
https://github.com/apache/rocketmq-operator/issues/113#issuecomment-1181619571

   fix by add 'ClusterRole' leases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-client-go] hYuang opened a new pull request, #854: a liitle improvement use chan instead

[GitBox]

hYuang opened a new pull request, #854:
URL: https://github.com/apache/rocketmq-client-go/pull/854

   ## What is the purpose of the change
   
   use chan instead
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when a cross-module dependency exists.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] Ouroborosi commented on issue #98: No RocketMQ cluster found after deployment

[GitBox]

Ouroborosi commented on issue #98:
URL: 
https://github.com/apache/rocketmq-operator/issues/98#issuecomment-1182320069

   @caigy thanks for your reply. haven't tested it yet. I deployed helm chart 
directly as an alternative a while ago that works like a charm. I'll try to 
deploy the operator agin and get back to you soon. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] feiyuyitiao commented on issue #113: :rocketmq-operator" cannot get resource "leases

[GitBox]

feiyuyitiao commented on issue #113:
URL: 
https://github.com/apache/rocketmq-operator/issues/113#issuecomment-1181619222

   fix by add 'ClusterRole' leases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] feiyuyitiao commented on issue #113: :rocketmq-operator" cannot get resource "leases

[GitBox]

feiyuyitiao commented on issue #113:
URL: 
https://github.com/apache/rocketmq-operator/issues/113#issuecomment-1181618921

   fix by add 'ClusterRole'  leases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] feiyuyitiao closed issue #113: :rocketmq-operator" cannot get resource "leases

[GitBox]

feiyuyitiao closed issue #113: :rocketmq-operator" cannot get resource "leases
URL: https://github.com/apache/rocketmq-operator/issues/113


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-clients] aaron-ai opened a new pull request, #42: Java: refactor MessageMeter

[GitBox]

aaron-ai opened a new pull request, #42:
URL: https://github.com/apache/rocketmq-clients/pull/42

   Fixes #41 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy commented on issue #37: rbd mount /root/logs and /root/store problem when using ceph storage class

[GitBox]

caigy commented on issue #37:
URL: 
https://github.com/apache/rocketmq-operator/issues/37#issuecomment-1181740427

   @fengjian1585 Any updates?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy commented on issue #49: About code variable naming

[GitBox]

caigy commented on issue #49:
URL: 
https://github.com/apache/rocketmq-operator/issues/49#issuecomment-1181737409

   Fixed by #97 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-site] liyijuan opened a new issue, #154: Add Dashboard (.md) to new official website

[GitBox]

liyijuan opened a new issue, #154:
URL: https://github.com/apache/rocketmq-site/issues/154

   Any question or RocketMQ proposal please use our [mailing 
lists](http://rocketmq.apache.org/about/contact/).
   
   **FEATURE REQUEST**
   
   1. What did you do (The steps to reproduce)?
   
   -  Add ```17Dashboard.md``` to  ```rocketmq-site\docs\04-部署与运维\```
   
   -  Add ```17Dashboard``` to ```rocketmq-site\docs\picture```
   
   2. Please tell us about your environment:
   
  - centos 7 local virtual machine
  - centos 7 aliyun remote virtual machine
  - maven 3.8.5 jdk 1.8
  - rocketmq 4.9.3, 4.9.4
  - rocketmq dashboard 1.0.0
   
   3. Please describe the feature you are requesting.
   
  - add introduction about the rocketmq dashboard
  - add install guide and uer guide
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-site] liyijuan opened a new pull request, #155: [ISSUE #154] Add Dashboard (.md) to new official website

[GitBox]

liyijuan opened a new pull request, #155:
URL: https://github.com/apache/rocketmq-site/pull/155

   Please do not create a Pull Request without creating an issue first. 
   
   ## What is the purpose of the change
   
   Add Dashboard (.md) to new official website
   
   ## Brief changelog
   
   -  Add ```17Dashboard.md``` to  ```rocketmq-site\docs\04-部署与运维\```
   
   -  Add ```17Dashboard``` to ```rocketmq-site\docs\picture```
   
   ## Verifying this change
   
   Images can be shown normally
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
   - [x] Make sure there is a Github issue filed for the change (usually before 
you start working on it). Trivial changes like typos do not require a Github 
issue. Your pull request should address just this issue, without pulling in 
other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy closed issue #49: About code variable naming

[GitBox]

caigy closed issue #49: About code variable naming
URL: https://github.com/apache/rocketmq-operator/issues/49


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy commented on issue #98: No RocketMQ cluster found after deployment

[GitBox]

caigy commented on issue #98:
URL: 
https://github.com/apache/rocketmq-operator/issues/98#issuecomment-1181733140

   @Ouroborosi Any updates?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] feiyuyitiao opened a new issue, #113: :rocketmq-operator" cannot get resource "leases

[GitBox]

feiyuyitiao opened a new issue, #113:
URL: https://github.com/apache/rocketmq-operator/issues/113

   after `make deploy`
   
   check operator log,  which prints: 
   ```
   E0712 08:48:26.825666   1 leaderelection.go:330] error retrieving 
resource lock default/2516c052.apache.org: leases.coordination.k8s.io 
"2516c052.apache.org" is forbidden: User 
"system:serviceaccount:default:rocketmq-operator" cannot get resource "leases" 
in API group "coordination.k8s.io" in the namespace "default"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] liuzongliang0202 opened a new issue, #4587: Can rocketmq thread pool add a "bottom-up" scheme to catch exceptions

[GitBox]

liuzongliang0202 opened a new issue, #4587:
URL: https://github.com/apache/rocketmq/issues/4587

   In BrokerController#initialize(), it will create many business thread pools. 
can we add "bottom-up" scheme to catch exceptions for business thread pools?
   
   for example, class 'org.apache.rocketmq.common.ThreadFactoryImpl'
   
   
   @Override
   public Thread newThread(Runnable r) {
   Thread thread = new Thread(r, threadNamePrefix + 
this.threadIndex.incrementAndGet());
   thread.setDaemon(daemon);
   thread.setUncaughtExceptionHandler(new 
Thread.UncaughtExceptionHandler() {
   @Override
   public void uncaughtException(Thread t, Throwable e) {
   log.error("Uncaught exception in thread '" + t.getName() + 
"':", e);
   }
   });
   return thread;
   }


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re:Re: [VOTE][RIP-45]RocketMQ Replicator 2.0

[jinrongtong]

+1
在 2022-07-12 15:19:14，"heng du"  写道：
>+1
>
>dongeforever  于2022年7月12日周二 14:44写道：
>
>> +1.
>>
>> BTW, currently, it does not have an offset replicator for Group Offsets.
>>
>> zhibo li  于2022年7月12日周二 14:32写道：
>>
>> > Hi, RocketMQ Community,
>> >
>> >
>> > As discussed in the previous email, we launched a new RIP 45 to enhance
>> > RocketMQ Replicator. Now the shepherds @duhenglucky and @dongeforever are
>> > willing to support the RIP, so I think it is time to start an email
>> thread
>> > to enter the voting process.
>> >
>> >
>> > The vote will be open for at least 72 hours or until a necessary number
>> of
>> > votes are reached.
>> >
>> >
>> > Please vote accordingly:
>> >
>> >
>> > [ ] +1 approve
>> >
>> > [ ] +0 no opinion
>> >
>> > [ ] -1 disapprove with the reason
>> >
>> >
>> >
>> >
>> >
>> > Best Regards!
>> >
>> > Lizhibo
>> >
>> >
>> >
>> > links:
>> >
>> > English proposal:
>> >
>> >
>> https://docs.google.com/document/d/1_gd3ijNW38cHQTeI_iOUX9hg4n_RVGQDLnZxLMJr0lg/edit?usp=sharing
>> > <
>> >
>> https://docs.google.com/document/d/1tSJkor_3Js4NBaVA0UENGyM8Mh0SrRMXszRyI91hjJ8/edit?usp=sharing
>> > >
>> >
>> > Chinese proposal:
>> > https://shimo.im/file-invite/3EMTZwcWNFh8NW4Vgj4dKtlmGJXK6/
>> >
>>

[GitHub] [rocketmq] Oliverwqcwrw opened a new pull request, #4586: [ISSUE #4579] Add unit test

[GitBox]

Oliverwqcwrw opened a new pull request, #4586:
URL: https://github.com/apache/rocketmq/pull/4586

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   Follow #4580 Add unit test
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] suuugeee commented on issue #110: unable to start container process: exec: "/manager": stat /manager: no such file or directory: unknown

[GitBox]

suuugeee commented on issue #110:
URL: 
https://github.com/apache/rocketmq-operator/issues/110#issuecomment-1181480422

   @caigy 
   
![image](https://user-images.githubusercontent.com/42126851/178447366-1da7f103-5e84-46f0-a6f7-5a8b36584e2a.png)
   
   
![image](https://user-images.githubusercontent.com/42126851/178447282-b349864b-3897-4aaa-9f80-6cacb85b3d16.png)
   
   码头工人：20.10.17
   操作系统：Alibaba Cloud Linux 3，核心版本 5.10.84-10.4.al8.x86_64
   CPU架构：x86_64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] lwclover closed pull request #4562: UpdateTopicRouteInfoFromNameServer method in the concurrent lack of detection

[GitBox]

lwclover closed pull request #4562: UpdateTopicRouteInfoFromNameServer method 
in the concurrent lack of detection
URL: https://github.com/apache/rocketmq/pull/4562


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy closed issue #68: Operator is not usefull cross namespaces

[GitBox]

caigy closed issue #68: Operator is not usefull cross namespaces
URL: https://github.com/apache/rocketmq-operator/issues/68


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy commented on issue #71: NameService Env settings do not take effect

[GitBox]

caigy commented on issue #71:
URL: 
https://github.com/apache/rocketmq-operator/issues/71#issuecomment-1181447645

   The JVM params are generated according to the resource of container:
   
https://github.com/apache/rocketmq-operator/blob/f904c6604a58880d83444b25c4a331092737770a/images/namesrv/alpine/runserver-customize.sh#L133-L140


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy closed issue #71: NameService Env settings do not take effect

[GitBox]

caigy closed issue #71: NameService Env settings do not take effect
URL: https://github.com/apache/rocketmq-operator/issues/71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy commented on issue #72: how to use k8s.io/code-generator for generating rocketmq-operator apis

[GitBox]

caigy commented on issue #72:
URL: 
https://github.com/apache/rocketmq-operator/issues/72#issuecomment-1181438868

   The version of operator framework has been updated and the commands above 
are not available. Please try the latest version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy closed issue #72: how to use k8s.io/code-generator for generating rocketmq-operator apis

[GitBox]

caigy closed issue #72: how to use k8s.io/code-generator for  generating 
rocketmq-operator apis
URL: https://github.com/apache/rocketmq-operator/issues/72


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy commented on issue #73: How to customize the rocketmq-dashboard configuration

[GitBox]

caigy commented on issue #73:
URL: 
https://github.com/apache/rocketmq-operator/issues/73#issuecomment-1181432848

   @Euthpic `resources/application.properties` is in source code of 
[rocketmq-dashboard](https://github.com/apache/rocketmq-dashboard), please 
check if it can be injected by environment variables. For `users.properties`, 
you should create one and put it the folder `${rocketmq.config.dataPath}` 
defined.
   
   However, rocketmq operator does not support mounting a configMap to 
rocketmq-dashboard, would you like to submit a PR to solve it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy closed issue #77: Does it not support custom imagePullSecrets config

[GitBox]

caigy closed issue #77: Does it not support custom imagePullSecrets config
URL: https://github.com/apache/rocketmq-operator/issues/77


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy commented on issue #77: Does it not support custom imagePullSecrets config

[GitBox]

caigy commented on issue #77:
URL: 
https://github.com/apache/rocketmq-operator/issues/77#issuecomment-1181417144

   Fixed by #90


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] caigy commented on issue #57: add rocketmq api resource

[GitBox]

caigy commented on issue #57:
URL: 
https://github.com/apache/rocketmq-operator/issues/57#issuecomment-1181412103

   @linjiemiao Good idea! Would you like to submit a PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] ShahRishi commented on issue #4585: [Task] fulfill PlainPermissionManager test case

[GitBox]

ShahRishi commented on issue #4585:
URL: https://github.com/apache/rocketmq/issues/4585#issuecomment-1181412875

   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] suuugeee closed issue #112: Error: err: exit status 1: stderr: go: github.com/google/uuid@v1.1.2: missing go.sum entry; to add it:

[GitBox]

suuugeee closed issue #112: Error: err: exit status 1: stderr: go: 
github.com/google/uuid@v1.1.2: missing go.sum entry; to add it:
URL: https://github.com/apache/rocketmq-operator/issues/112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] suuugeee commented on issue #112: Error: err: exit status 1: stderr: go: github.com/google/uuid@v1.1.2: missing go.sum entry; to add it:

[GitBox]

suuugeee commented on issue #112:
URL: 
https://github.com/apache/rocketmq-operator/issues/112#issuecomment-1181409566

   go mod tidy


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE][RIP-45]RocketMQ Replicator 2.0

[heng du]

+1

dongeforever  于2022年7月12日周二 14:44写道：

> +1.
>
> BTW, currently, it does not have an offset replicator for Group Offsets.
>
> zhibo li  于2022年7月12日周二 14:32写道：
>
> > Hi, RocketMQ Community,
> >
> >
> > As discussed in the previous email, we launched a new RIP 45 to enhance
> > RocketMQ Replicator. Now the shepherds @duhenglucky and @dongeforever are
> > willing to support the RIP, so I think it is time to start an email
> thread
> > to enter the voting process.
> >
> >
> > The vote will be open for at least 72 hours or until a necessary number
> of
> > votes are reached.
> >
> >
> > Please vote accordingly:
> >
> >
> > [ ] +1 approve
> >
> > [ ] +0 no opinion
> >
> > [ ] -1 disapprove with the reason
> >
> >
> >
> >
> >
> > Best Regards!
> >
> > Lizhibo
> >
> >
> >
> > links:
> >
> > English proposal:
> >
> >
> https://docs.google.com/document/d/1_gd3ijNW38cHQTeI_iOUX9hg4n_RVGQDLnZxLMJr0lg/edit?usp=sharing
> > <
> >
> https://docs.google.com/document/d/1tSJkor_3Js4NBaVA0UENGyM8Mh0SrRMXszRyI91hjJ8/edit?usp=sharing
> > >
> >
> > Chinese proposal:
> > https://shimo.im/file-invite/3EMTZwcWNFh8NW4Vgj4dKtlmGJXK6/
> >
>

[GitHub] [rocketmq] lizhiboo commented on issue #4585: [Task] fulfill PlainPermissionManager test case

[GitBox]

lizhiboo commented on issue #4585:
URL: https://github.com/apache/rocketmq/issues/4585#issuecomment-1181404994

   @ShahRishi https://rocketmq.apache.org/docs/pull-request/
   this article maybe helpful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org