[GitHub] [rocketmq] RongtongJin opened a new issue, #4624: Unstable tests in acl module can not pass in the arm environment of CI

[GitBox]

RongtongJin opened a new issue, #4624:
URL: https://github.com/apache/rocketmq/issues/4624

   The issue tracker is used for bug reporting purposes **ONLY** whereas 
feature request needs to follow the [RIP 
process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal).
 To avoid unnecessary duplication, please check whether there is a previous 
issue before filing a new one.
   
   It is recommended to start a discussion thread in the [mailing 
lists](http://rocketmq.apache.org/about/contact/) in cases of discussing your 
deployment plan, API clarification, and other non-bug-reporting issues.
   We welcome any friendly suggestions, bug fixes, collaboration, and other 
improvements.
   
   Please ensure that your bug report is clear and self-contained. Otherwise, 
it would take additional rounds of communication, thus more time, to understand 
the problem itself.
   
   Generally, fixing an issue goes through the following steps:
   1. Understand the issue reported;
   1. Reproduce the unexpected behavior locally;
   1. Perform root cause analysis to identify the underlying problem;
   1. Create test cases to cover the identified problem;
   1. Work out a solution to rectify the behavior and make the newly created 
test cases pass;
   1. Make a pull request and go through peer review;
   
   As a result, it would be very helpful yet challenging if you could provide 
an isolated project reproducing your reported issue. Anyway, please ensure your 
issue report is informative enough for the community to pick up. At a minimum, 
include the following hints:
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   - What did you do (The steps to reproduce)?
   
   Unstable tests in acl module can not pass in the arm environment of CI
   
   Tests can pass smoothly locally, but it cannot pass in the arm environment 
of CI
   
   - What is expected to see?
   
   Tests  can pass  in the arm environment of CI
   
   - What did you see instead?
   
   Tests  can not pass  in the arm environment of CI
   
   2. Please tell us about your environment:
   
   3. Other information (e.g. detailed explanation, logs, related issues, 
suggestions on how to fix, etc):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] lizhiboo opened a new pull request, #4623: move access control to AccessValidator for pass test case ci

[GitBox]

lizhiboo opened a new pull request, #4623:
URL: https://github.com/apache/rocketmq/pull/4623

   for pass test case ci on arm platform.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-connect] sunxiaojian commented on issue #189: java.lang.AbstractMethodError: io.openmessaging.connector.api.component.connector.Connector.start

[GitBox]

sunxiaojian commented on issue #189:
URL: 
https://github.com/apache/rocketmq-connect/issues/189#issuecomment-1186812407

   > 
![9eda860ffc8f975d7e56afa219744af](https://user-images.githubusercontent.com/36498442/179431837-d207dca0-6a09-47e4-9746-04c125903145.png)
 @sunxiaojian 
[sunxiaojian](https://github.com/sunxiaojian)你好，就是按照demo和文档指导就行操作，看日志已经连接到broker，但是就是数据没有同步过去。
   
   OK，应该是配置有问题，我去看一下


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] zhouxinyu merged pull request #4615: [ISSUE #3905] Support bname in protocol

[GitBox]

zhouxinyu merged PR #4615:
URL: https://github.com/apache/rocketmq/pull/4615


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] zhouxinyu commented on pull request #4615: [ISSUE #3905] Support bname in protocol

[GitBox]

zhouxinyu commented on PR #4615:
URL: https://github.com/apache/rocketmq/pull/4615#issuecomment-1186811471

   Let's merge this PR first, although there is one ci failed, @RongtongJin is 
trying to fix this problem in another thread.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] suuugeee commented on issue #110: unable to start container process: exec: "/manager": stat /manager: no such file or directory: unknown

[GitBox]

suuugeee commented on issue #110:
URL: 
https://github.com/apache/rocketmq-operator/issues/110#issuecomment-1186801013

   Is there a problem with kubernetes, my kubernetes version is v1.23.8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-site] ShannonDing merged pull request #158: Fix the command to generate detach 'asc' sign file

[GitBox]

ShannonDing merged PR #158:
URL: https://github.com/apache/rocketmq-site/pull/158


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] suuugeee commented on issue #110: unable to start container process: exec: "/manager": stat /manager: no such file or directory: unknown

[GitBox]

suuugeee commented on issue #110:
URL: 
https://github.com/apache/rocketmq-operator/issues/110#issuecomment-1186790375

   
![image](https://user-images.githubusercontent.com/42126851/179451255-5a32010b-afd3-405e-90d3-5ac3b2f947d4.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] suuugeee commented on issue #110: unable to start container process: exec: "/manager": stat /manager: no such file or directory: unknown

[GitBox]

suuugeee commented on issue #110:
URL: 
https://github.com/apache/rocketmq-operator/issues/110#issuecomment-1186790086

   Client:
Context:default
Debug Mode: false
Plugins:
 app: Docker App (Docker Inc., v0.9.1-beta3)
 buildx: Docker Buildx (Docker Inc., v0.8.2-docker)
 scan: Docker Scan (Docker Inc., v0.17.0)
   
   Server:
Containers: 37
 Running: 32
 Paused: 0
 Stopped: 5
Images: 30
Server Version: 20.10.17
Storage Driver: overlay2
 Backing Filesystem: xfs
 Supports d_type: true
 Native Overlay Diff: false
 userxattr: false
Logging Driver: json-file
Cgroup Driver: systemd
Cgroup Version: 1
Plugins:
 Volume: local
 Network: bridge host ipvlan macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file local logentries 
splunk syslog
Swarm: inactive
Runtimes: io.containerd.runc.v2 io.containerd.runtime.v1.linux runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1
runc version: v1.1.2-0-ga916309
init version: de40ad0
Security Options:
 seccomp
  Profile: default
Kernel Version: 5.10.112-11.al8.x86_64
Operating System: Alibaba Cloud Linux 3 (Soaring Falcon)
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.494GiB
Name: dddmaster
ID: LQHY:R4AW:LE6F:YETD:VIM6:PWYC:GFBU:MFBR:3DX4:E4T4:5YNY:6K7V
Docker Root Dir: /var/lib/docker
Debug Mode: false
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
 127.0.0.0/8
Registry Mirrors:
 https://kn0t2bca.mirror.aliyuncs.com/
Live Restore Enabled: false
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] suuugeee commented on issue #110: unable to start container process: exec: "/manager": stat /manager: no such file or directory: unknown

[GitBox]

suuugeee commented on issue #110:
URL: 
https://github.com/apache/rocketmq-operator/issues/110#issuecomment-1186790040

   @caigy After I run the container, I found "manager", but kubectl get pod 
still prompts an error.
   
![image](https://user-images.githubusercontent.com/42126851/179451164-e1d176ef-0c92-4e16-a38e-72806185572b.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] zhouxinyu opened a new issue, #4622: Improve execution efficiency of integration tests

[GitBox]

zhouxinyu opened a new issue, #4622:
URL: https://github.com/apache/rocketmq/issues/4622

   The issue tracker is used for bug reporting purposes **ONLY** whereas 
feature request needs to follow the [RIP 
process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal).
 To avoid unnecessary duplication, please check whether there is a previous 
issue before filing a new one.
   
   It is recommended to start a discussion thread in the [mailing 
lists](http://rocketmq.apache.org/about/contact/) in cases of discussing your 
deployment plan, API clarification, and other non-bug-reporting issues.
   We welcome any friendly suggestions, bug fixes, collaboration, and other 
improvements.
   
   Please ensure that your bug report is clear and self-contained. Otherwise, 
it would take additional rounds of communication, thus more time, to understand 
the problem itself.
   
   Generally, fixing an issue goes through the following steps:
   1. Understand the issue reported;
   1. Reproduce the unexpected behavior locally;
   1. Perform root cause analysis to identify the underlying problem;
   1. Create test cases to cover the identified problem;
   1. Work out a solution to rectify the behavior and make the newly created 
test cases pass;
   1. Make a pull request and go through peer review;
   
   As a result, it would be very helpful yet challenging if you could provide 
an isolated project reproducing your reported issue. Anyway, please ensure your 
issue report is informative enough for the community to pick up. At a minimum, 
include the following hints:
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   - What did you do (The steps to reproduce)?
   
   - What is expected to see?
   
   - What did you see instead?
   
   2. Please tell us about your environment:
   
   3. Other information (e.g. detailed explanation, logs, related issues, 
suggestions on how to fix, etc):
   
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   
   3. Provide any additional detail on your proposed use case for this feature.
   
   2. Indicate the importance of this issue to you (blocker, must-have, 
should-have, nice-to-have). Are you currently using any workarounds to address 
this issue?
   
   4. If there are some sub-tasks involved, use -[] for each sub-task and 
create a corresponding issue to map to the sub-task:
   
   - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 
description here, 
   - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 
description here,
   - ...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] totalo commented on pull request #194: Use shade plugin to hide dependencies

[GitBox]

totalo commented on PR #194:
URL: https://github.com/apache/rocketmq-streams/pull/194#issuecomment-1186734848

   > However this pr do not resolve dependency conflicts, because dependency of 
RocketMQ-Streams can be depend by application which depend on RocketMQ-Streams.
   
   ok, i'll check it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-site] aaron-ai commented on pull request #158: Fix the command to generate 'asc' file

[GitBox]

aaron-ai commented on PR #158:
URL: https://github.com/apache/rocketmq-site/pull/158#issuecomment-1186734460

   > Hi @aaron-ai ,
   > 
   > Thx for pointing out our mistakes. Nice catch. Since we're now preparing 
to announce our new official website and building the new-version 
documentation, the change on the old one might be not that needed. Would you 
mind helping us correct this mistake in the branch for the new official website 
(https://github.com/apache/rocketmq-site/tree/new-official-website/docs) ?
   
   Well, I don't think this modification is not needed before the new website 
is published. There should be two independent pull requests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE]Release Apache RocketMQ APIs 2.0.0 RC1

[heng du]

+1

I checked

1.Checksums and PGP signatures are valid for source package.
2. The Apache V2 license file is included in the package;

Zhanhui Li  于2022年7月18日周一 11:21写道：

> +1 binding
>
> I checked
>
> 1. Checksum and PGP signature;
> 2. License headers are included in Protobuf files;
> 3. The Apache V2 license file is included in the package;
>
>
> On Mon, Jul 18, 2022 at 11:07 AM lollipop  wrote:
>
> > +1，checked：
> >
> > [OK ]  Checksums and PGP signatures are valid for source package.
> > [OK ]  License and Notice are correct in source package.
> >
> > On Fri, Jul 15, 2022 at 11:13 PM aaron ai  wrote:
> >
> > > Hello RocketMQ Community,
> > >
> > > This is the vote for 2.0.0 RC1 of Apache RocketMQ APIs.
> > >
> > > RocketMQ APIs use Protocol Buffers version 3 (proto3) as their
> Interface
> > > Definition Language (IDL) to define the API interface and the structure
> > of
> > > the payload messages.
> > >
> > > The artifacts:
> > >
> > > https://dist.apache.org/repos/dist/dev/rocketmq/2.0.0-rc1
> > >
> > > The staging repo:
> > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapacherocketmq-1091/
> > >
> > > Git tag for the release:
> > >
> > > https://github.com/apache/rocketmq-apis/releases/tag/v2.0
> > >
> > >
> >
> https://github.com/apache/rocketmq-apis/releases/tag/rocketmq-proto-2.0.0
> > >
> > > Hash for the release tag:
> > >
> > > 303962118171075c3a5a8c395822fecfdf492d6f
> > >
> > > Relate Notes:
> > >
> > > https://github.com/apache/rocketmq-apis/releases/tag/v2.0
> > >
> > >
> >
> https://github.com/apache/rocketmq-apis/releases/tag/rocketmq-proto-2.0.0
> > >
> > > The artifacts have been signed with Key :
> > >
> > > 3A11FEBBD64C807A233BF1F27C46C79BD4D29011, which can be found in the
> keys
> > > file: https://dist.apache.org/repos/dist/dev/rocketmq/KEYS
> > >
> > > Fill in the following:
> > >
> > > [+]  check LICENSE, should be Apache V2
> > >
> > > [+]  check NOTICE, should have a notice for third-party dependency if
> > > necessary
> > >
> > > [+]  extract the zip and check if the source version is correct
> > >
> > > [+]  verify the asc(PGP sign),SHA512
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > The vote will be open for at least 72 hours or until the necessary
> number
> > > of votes are reached.
> > >
> > > Please vote accordingly:
> > >
> > >
> > >
> > >
> > > [ ] +1 approve
> > >
> > > [ ] +0 no opinion
> > >
> > > [ ] -1 disapprove with the reason
> > >
> > >
> > >
> > >
> > > Thanks
> > >
> > > The Apache RocketMQ Team
> > >
> >
>

[GitHub] [rocketmq-client-go] WJL3333 commented on pull request #856: [ISSUE #774] Avoid cancel context too early cause trace data fail.

[GitBox]

WJL commented on PR #856:
URL: 
https://github.com/apache/rocketmq-client-go/pull/856#issuecomment-1186727756

   @duhenglucky @ShannonDing @yuz10 @maixiaohai 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-client-go] WJL3333 commented on issue #780: ConsumerSendMsgBackRequest should not send message body.

[GitBox]

WJL commented on issue #780:
URL: 
https://github.com/apache/rocketmq-client-go/issues/780#issuecomment-1186727041

   @duhenglucky @ShannonDing @yuz10 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-client-go] WJL3333 opened a new pull request, #856: Avoid cancel context too early cause trace data fail.

[GitBox]

WJL opened a new pull request, #856:
URL: https://github.com/apache/rocketmq-client-go/pull/856

   ## What is the purpose of the change
   
   current trace data can't send success.
   
   ## Brief changelog
   
   only cancel context when receive error or request finished.
   
   ## Verifying this change
   
   with this patch trace data can send succes.
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when a cross-module dependency exists.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze closed issue #196: Error when use fromCollection.

[GitBox]

ni-ze closed issue #196: Error when use fromCollection.
URL: https://github.com/apache/rocketmq-streams/issues/196


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze merged pull request #195: [ISSUE #196]fix(ChannelBuilder) add ChannelBuilder

[GitBox]

ni-ze merged PR #195:
URL: https://github.com/apache/rocketmq-streams/pull/195


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze commented on pull request #195: fix(ChannelBuilder) add ChannelBuilder

[GitBox]

ni-ze commented on PR #195:
URL: https://github.com/apache/rocketmq-streams/pull/195#issuecomment-1186722917

   https://github.com/apache/rocketmq-streams/issues/196


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze commented on issue #196: Error when use fromCollection.

[GitBox]

ni-ze commented on issue #196:
URL: 
https://github.com/apache/rocketmq-streams/issues/196#issuecomment-1186722774

   https://github.com/apache/rocketmq-streams/pull/195


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze opened a new issue, #196: Error when use fromCollection.

[GitBox]

ni-ze opened a new issue, #196:
URL: https://github.com/apache/rocketmq-streams/issues/196

   can not find IChannelBuilder implement class with IChannelBuilder.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE]Release Apache RocketMQ APIs 2.0.0 RC1

[Zhanhui Li]

+1 binding

I checked

1. Checksum and PGP signature;
2. License headers are included in Protobuf files;
3. The Apache V2 license file is included in the package;


On Mon, Jul 18, 2022 at 11:07 AM lollipop  wrote:

> +1，checked：
>
> [OK ]  Checksums and PGP signatures are valid for source package.
> [OK ]  License and Notice are correct in source package.
>
> On Fri, Jul 15, 2022 at 11:13 PM aaron ai  wrote:
>
> > Hello RocketMQ Community,
> >
> > This is the vote for 2.0.0 RC1 of Apache RocketMQ APIs.
> >
> > RocketMQ APIs use Protocol Buffers version 3 (proto3) as their Interface
> > Definition Language (IDL) to define the API interface and the structure
> of
> > the payload messages.
> >
> > The artifacts:
> >
> > https://dist.apache.org/repos/dist/dev/rocketmq/2.0.0-rc1
> >
> > The staging repo:
> >
> >
> https://repository.apache.org/content/repositories/orgapacherocketmq-1091/
> >
> > Git tag for the release:
> >
> > https://github.com/apache/rocketmq-apis/releases/tag/v2.0
> >
> >
> https://github.com/apache/rocketmq-apis/releases/tag/rocketmq-proto-2.0.0
> >
> > Hash for the release tag:
> >
> > 303962118171075c3a5a8c395822fecfdf492d6f
> >
> > Relate Notes:
> >
> > https://github.com/apache/rocketmq-apis/releases/tag/v2.0
> >
> >
> https://github.com/apache/rocketmq-apis/releases/tag/rocketmq-proto-2.0.0
> >
> > The artifacts have been signed with Key :
> >
> > 3A11FEBBD64C807A233BF1F27C46C79BD4D29011, which can be found in the keys
> > file: https://dist.apache.org/repos/dist/dev/rocketmq/KEYS
> >
> > Fill in the following:
> >
> > [+]  check LICENSE, should be Apache V2
> >
> > [+]  check NOTICE, should have a notice for third-party dependency if
> > necessary
> >
> > [+]  extract the zip and check if the source version is correct
> >
> > [+]  verify the asc(PGP sign),SHA512
> >
> >
> >
> >
> >
> >
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes are reached.
> >
> > Please vote accordingly:
> >
> >
> >
> >
> > [ ] +1 approve
> >
> > [ ] +0 no opinion
> >
> > [ ] -1 disapprove with the reason
> >
> >
> >
> >
> > Thanks
> >
> > The Apache RocketMQ Team
> >
>

[GitHub] [rocketmq] coveralls commented on pull request #4621: [ISSUE #4492] support Kqueue

[GitBox]

coveralls commented on PR #4621:
URL: https://github.com/apache/rocketmq/pull/4621#issuecomment-1186718026

   
   [![Coverage 
Status](https://coveralls.io/builds/50934089/badge)](https://coveralls.io/builds/50934089)
   
   Coverage decreased (-0.06%) to 47.52% when pulling 
**28885462ee7ea0990b1858d61ad641e83c3caca0 on skasj:develop_kqueue** into 
**3ee603a49b04c0b602ff8eb45b3ef4330293fba8 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE]Release Apache RocketMQ APIs 2.0.0 RC1

[lollipop]

+1，checked：

[OK ]  Checksums and PGP signatures are valid for source package.
[OK ]  License and Notice are correct in source package.

On Fri, Jul 15, 2022 at 11:13 PM aaron ai  wrote:

> Hello RocketMQ Community,
>
> This is the vote for 2.0.0 RC1 of Apache RocketMQ APIs.
>
> RocketMQ APIs use Protocol Buffers version 3 (proto3) as their Interface
> Definition Language (IDL) to define the API interface and the structure of
> the payload messages.
>
> The artifacts:
>
> https://dist.apache.org/repos/dist/dev/rocketmq/2.0.0-rc1
>
> The staging repo:
>
> https://repository.apache.org/content/repositories/orgapacherocketmq-1091/
>
> Git tag for the release:
>
> https://github.com/apache/rocketmq-apis/releases/tag/v2.0
>
> https://github.com/apache/rocketmq-apis/releases/tag/rocketmq-proto-2.0.0
>
> Hash for the release tag:
>
> 303962118171075c3a5a8c395822fecfdf492d6f
>
> Relate Notes:
>
> https://github.com/apache/rocketmq-apis/releases/tag/v2.0
>
> https://github.com/apache/rocketmq-apis/releases/tag/rocketmq-proto-2.0.0
>
> The artifacts have been signed with Key :
>
> 3A11FEBBD64C807A233BF1F27C46C79BD4D29011, which can be found in the keys
> file: https://dist.apache.org/repos/dist/dev/rocketmq/KEYS
>
> Fill in the following:
>
> [+]  check LICENSE, should be Apache V2
>
> [+]  check NOTICE, should have a notice for third-party dependency if
> necessary
>
> [+]  extract the zip and check if the source version is correct
>
> [+]  verify the asc(PGP sign),SHA512
>
>
>
>
>
>
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> Please vote accordingly:
>
>
>
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
>
>
> Thanks
>
> The Apache RocketMQ Team
>

[GitHub] [rocketmq] codecov-commenter commented on pull request #4621: [ISSUE #4492] support Kqueue

[GitBox]

codecov-commenter commented on PR #4621:
URL: https://github.com/apache/rocketmq/pull/4621#issuecomment-1186709520

   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/4621?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#4621](https://codecov.io/gh/apache/rocketmq/pull/4621?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (2888546) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/3ee603a49b04c0b602ff8eb45b3ef4330293fba8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (3ee603a) will **decrease** coverage by `0.06%`.
   > The diff coverage is `11.90%`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#4621  +/-   ##
   =
   - Coverage  43.46%   43.40%   -0.07% 
   - Complexity  6210 6217   +7 
   =
 Files817  817  
 Lines  5765457693  +39 
 Branches7873 7883  +10 
   =
   - Hits   2505925040  -19 
   - Misses 2935129410  +59 
   + Partials3244 3243   -1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/4621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...e/rocketmq/remoting/netty/NettyRemotingServer.java](https://codecov.io/gh/apache/rocketmq/pull/4621/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdTZXJ2ZXIuamF2YQ==)
 | `58.30% <6.66%> (-3.09%)` | :arrow_down: |
   | 
[.../apache/rocketmq/remoting/common/RemotingUtil.java](https://codecov.io/gh/apache/rocketmq/pull/4621/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL2NvbW1vbi9SZW1vdGluZ1V0aWwuamF2YQ==)
 | `12.21% <13.04%> (+0.17%)` | :arrow_up: |
   | 
[...che/rocketmq/remoting/netty/NettyServerConfig.java](https://codecov.io/gh/apache/rocketmq/pull/4621/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5U2VydmVyQ29uZmlnLmphdmE=)
 | `46.77% <25.00%> (-1.51%)` | :arrow_down: |
   | 
[...a/org/apache/rocketmq/broker/BrokerController.java](https://codecov.io/gh/apache/rocketmq/pull/4621/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh)
 | `45.76% <0.00%> (-3.41%)` | :arrow_down: |
   | 
[...ava/org/apache/rocketmq/test/util/VerifyUtils.java](https://codecov.io/gh/apache/rocketmq/pull/4621/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL1ZlcmlmeVV0aWxzLmphdmE=)
 | `46.26% <0.00%> (-2.99%)` | :arrow_down: |
   | 
[...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/4621/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh)
 | `60.43% <0.00%> (-2.20%)` | :arrow_down: |
   | 
[...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4621/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==)
 | `82.38% <0.00%> (-0.96%)` | :arrow_down: |
   | 
[.../rocketmq/broker/filter/ConsumerFilterManager.java](https://codecov.io/gh/apache/rocketmq/pull/4621/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyL0NvbnN1bWVyRmlsdGVyTWFuYWdlci5qYXZh)
 | `72

[GitHub] [rocketmq-client-go] guyinyou commented on issue #855: How to consume from last offset when create new consumer group?

[GitBox]

guyinyou commented on issue #855:
URL: 
https://github.com/apache/rocketmq-client-go/issues/855#issuecomment-1186708028

   Maybe mqadmin class can satisfy you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze commented on pull request #194: Use shade plugin to hide dependencies

[GitBox]

ni-ze commented on PR #194:
URL: https://github.com/apache/rocketmq-streams/pull/194#issuecomment-1186705473

   However this pr do not resolve dependency conflicts, because dependency of 
RocketMQ-Streams can be depend by application which depend on  
RocketMQ-Streams. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-client-nodejs] wuteng606 commented on issue #24: [Feature Request] 移除rocketmq-client-cpp依赖，纯js实现client

[GitBox]

wuteng606 commented on issue #24:
URL: 
https://github.com/apache/rocketmq-client-nodejs/issues/24#issuecomment-1186701971

   > 现在有可用的 rocketmq node 包么
   
   https://www.npmjs.com/package/nodejs-rocketmq-client 发到了npm 
，直接下载就好，编译不过，或者有其他问题，可以私我


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-client-nodejs] wuteng606 commented on issue #25: 我用 node-addon-api 封装了 rocketmq-client-cpp 如果有需要可以留言

[GitBox]

wuteng606 commented on issue #25:
URL: 
https://github.com/apache/rocketmq-client-nodejs/issues/25#issuecomment-1186701812

   https://www.npmjs.com/package/nodejs-rocketmq-client 发到了npm 
，直接下载就好，编译不过，或者有其他问题，可以私我


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze commented on pull request #194: Use shade plugin to hide dependencies

[GitBox]

ni-ze commented on PR #194:
URL: https://github.com/apache/rocketmq-streams/pull/194#issuecomment-1186700793

   @totalo Great patch!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re:[VOTE][RIP-45]RocketMQ Replicator 2.0

[ShannonDing]

+1





At 2022-07-12 14:31:48, "zhibo li"  wrote:
>Hi, RocketMQ Community,
>
>
>As discussed in the previous email, we launched a new RIP 45 to enhance
>RocketMQ Replicator. Now the shepherds @duhenglucky and @dongeforever are
>willing to support the RIP, so I think it is time to start an email thread
>to enter the voting process.
>
>
>The vote will be open for at least 72 hours or until a necessary number of
>votes are reached.
>
>
>Please vote accordingly:
>
>
>[ ] +1 approve
>
>[ ] +0 no opinion
>
>[ ] -1 disapprove with the reason
>
>
>
>
>
>Best Regards!
>
>Lizhibo
>
>
>
>links:
>
>English proposal:
>https://docs.google.com/document/d/1_gd3ijNW38cHQTeI_iOUX9hg4n_RVGQDLnZxLMJr0lg/edit?usp=sharing
>
>
>Chinese proposal:
>https://shimo.im/file-invite/3EMTZwcWNFh8NW4Vgj4dKtlmGJXK6/

[GitHub] [rocketmq] skasj opened a new pull request, #4621: [ISSUE #4492] support Kqueue

[GitBox]

skasj opened a new pull request, #4621:
URL: https://github.com/apache/rocketmq/pull/4621

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   support Kqueue
   
   ## Brief changelog
   
   support Kqueue
   
   ## Verifying this change
   
   support Kqueue
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] tsunghanjacktsai commented on a diff in pull request #4615: [ISSUE #3905] Support bname in protocol

[GitBox]

tsunghanjacktsai commented on code in PR #4615:
URL: https://github.com/apache/rocketmq/pull/4615#discussion_r922935805


##
client/src/main/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStore.java:
##
@@ -213,6 +213,7 @@ public void updateConsumeOffsetToBroker(MessageQueue mq, 
long offset, boolean is
 requestHeader.setConsumerGroup(this.groupName);
 requestHeader.setQueueId(mq.getQueueId());
 requestHeader.setCommitOffset(offset);
+requestHeader.setBname(mq.getBrokerName());

Review Comment:
   @drpmma Oh, okay. That's reasonable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] skasj closed pull request #4546: [issue#4492] support Kqueue

[GitBox]

skasj closed pull request #4546: [issue#4492] support Kqueue
URL: https://github.com/apache/rocketmq/pull/4546


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw commented on pull request #4590: [ISSUE #4589] Close stream

[GitBox]

Oliverwqcwrw commented on PR #4590:
URL: https://github.com/apache/rocketmq/pull/4590#issuecomment-1186689854

   > The last resource to be created (`Writer fw` ) should be closed,
   
   Good advice, i will solve it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] dependabot[bot] commented on pull request #188: build(deps): bump elasticsearch from 7.4.0 to 7.14.0

[GitBox]

dependabot[bot] commented on PR #188:
URL: https://github.com/apache/rocketmq-streams/pull/188#issuecomment-1186670194

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze closed pull request #188: build(deps): bump elasticsearch from 7.4.0 to 7.14.0

[GitBox]

ni-ze closed pull request #188: build(deps): bump elasticsearch from 7.4.0 to 
7.14.0
URL: https://github.com/apache/rocketmq-streams/pull/188


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] dependabot[bot] commented on pull request #192: build(deps): bump jython-standalone from 2.7.0 to 2.7.1

[GitBox]

dependabot[bot] commented on PR #192:
URL: https://github.com/apache/rocketmq-streams/pull/192#issuecomment-1186670097

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze closed pull request #192: build(deps): bump jython-standalone from 2.7.0 to 2.7.1

[GitBox]

ni-ze closed pull request #192: build(deps): bump jython-standalone from 2.7.0 
to 2.7.1
URL: https://github.com/apache/rocketmq-streams/pull/192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze commented on pull request #192: build(deps): bump jython-standalone from 2.7.0 to 2.7.1

[GitBox]

ni-ze commented on PR #192:
URL: https://github.com/apache/rocketmq-streams/pull/192#issuecomment-1186669922

   @ dependabot close


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze closed issue #178: add FileSourceExample1

[GitBox]

ni-ze closed issue #178: add FileSourceExample1
URL: https://github.com/apache/rocketmq-streams/issues/178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze closed issue #182: homework

[GitBox]

ni-ze closed issue #182: homework
URL: https://github.com/apache/rocketmq-streams/issues/182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze closed issue #180: homework

[GitBox]

ni-ze closed issue #180: homework
URL: https://github.com/apache/rocketmq-streams/issues/180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze closed pull request #177: filter scores

[GitBox]

ni-ze closed pull request #177: filter scores
URL: https://github.com/apache/rocketmq-streams/pull/177


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze closed pull request #179: add FileSourceExample1

[GitBox]

ni-ze closed pull request #179: add FileSourceExample1
URL: https://github.com/apache/rocketmq-streams/pull/179


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-streams] ni-ze closed pull request #183: homework_5

[GitBox]

ni-ze closed pull request #183: homework_5
URL: https://github.com/apache/rocketmq-streams/pull/183


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] ShannonDing merged pull request #4616: Try to make CI test more stable

[GitBox]

ShannonDing merged PR #4616:
URL: https://github.com/apache/rocketmq/pull/4616


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-connect] wongearl commented on issue #189: java.lang.AbstractMethodError: io.openmessaging.connector.api.component.connector.Connector.start

[GitBox]

wongearl commented on issue #189:
URL: 
https://github.com/apache/rocketmq-connect/issues/189#issuecomment-1186650467

   
![9eda860ffc8f975d7e56afa219744af](https://user-images.githubusercontent.com/36498442/179431837-d207dca0-6a09-47e4-9746-04c125903145.png)
   @sunxiaojian 
[sunxiaojian](https://github.com/sunxiaojian)你好，就是按照demo和文档指导就行操作，看日志已经连接到broker，但是就是数据没有同步过去。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] ShahRishi commented on issue #4585: [Task] fulfill PlainPermissionManager test case

[GitBox]

ShahRishi commented on issue #4585:
URL: https://github.com/apache/rocketmq/issues/4585#issuecomment-1186632206

   Sorry, this is a bit advanced for me. I think it will be better if someone 
else does this task, ask I'm not making too much progress. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE]Release Apache RocketMQ APIs 2.0.0 RC1

[yukon]

+1 binding

I checked:

1. The signed key can be found in the KEYs file
2. LICENSE is Apache V2, the notice of Protocol Buffers has been added to
the notice of this release.
3. gpg verify ok for both source and binary releases.
4. sha512sum ok for both source and binary releases.

Regards,
yukon



On Fri, Jul 15, 2022 at 11:13 PM aaron ai  wrote:

> Hello RocketMQ Community,
>
> This is the vote for 2.0.0 RC1 of Apache RocketMQ APIs.
>
> RocketMQ APIs use Protocol Buffers version 3 (proto3) as their Interface
> Definition Language (IDL) to define the API interface and the structure of
> the payload messages.
>
> The artifacts:
>
> https://dist.apache.org/repos/dist/dev/rocketmq/2.0.0-rc1
>
> The staging repo:
>
> https://repository.apache.org/content/repositories/orgapacherocketmq-1091/
>
> Git tag for the release:
>
> https://github.com/apache/rocketmq-apis/releases/tag/v2.0
>
> https://github.com/apache/rocketmq-apis/releases/tag/rocketmq-proto-2.0.0
>
> Hash for the release tag:
>
> 303962118171075c3a5a8c395822fecfdf492d6f
>
> Relate Notes:
>
> https://github.com/apache/rocketmq-apis/releases/tag/v2.0
>
> https://github.com/apache/rocketmq-apis/releases/tag/rocketmq-proto-2.0.0
>
> The artifacts have been signed with Key :
>
> 3A11FEBBD64C807A233BF1F27C46C79BD4D29011, which can be found in the keys
> file: https://dist.apache.org/repos/dist/dev/rocketmq/KEYS
>
> Fill in the following:
>
> [+]  check LICENSE, should be Apache V2
>
> [+]  check NOTICE, should have a notice for third-party dependency if
> necessary
>
> [+]  extract the zip and check if the source version is correct
>
> [+]  verify the asc(PGP sign),SHA512
>
>
>
>
>
>
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> Please vote accordingly:
>
>
>
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
>
>
> Thanks
>
> The Apache RocketMQ Team
>

[GitHub] [rocketmq] panzhi33 merged pull request #4619: [ISSUE #4167] Fix typo

[GitBox]

panzhi33 merged PR #4619:
URL: https://github.com/apache/rocketmq/pull/4619


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] panzhi33 merged pull request #4618: [ISSUE #4617] Correct log info

[GitBox]

panzhi33 merged PR #4618:
URL: https://github.com/apache/rocketmq/pull/4618


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] panzhi33 closed issue #4617: The old master address printed is the same as the new master address

[GitBox]

panzhi33 closed issue #4617: The old master address printed is the same as the 
new master address
URL: https://github.com/apache/rocketmq/issues/4617


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-spring] panzhi33 commented on issue #469: An error occurs when the Windows operating system starts the broadcast mode

[GitBox]

panzhi33 commented on issue #469:
URL: 
https://github.com/apache/rocketmq-spring/issues/469#issuecomment-1186499548

   @zhangjidi2016 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-spring] panzhi33 commented on pull request #466: [ISSUE #458]Fixed the problem of cannot consume previous messages in broadcast consumption mode

[GitBox]

panzhi33 commented on PR #466:
URL: https://github.com/apache/rocketmq-spring/pull/466#issuecomment-1186499461

   ping
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4619: [ISSUE #4167] Fix typo

[GitBox]

codecov-commenter commented on PR #4619:
URL: https://github.com/apache/rocketmq/pull/4619#issuecomment-1186499234

   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/4619?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#4619](https://codecov.io/gh/apache/rocketmq/pull/4619?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (c1b14b0) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/225bc42f9597cd9ff38fd01c2d5168c68a7f5cf8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (225bc42) will **decrease** coverage by `0.03%`.
   > The diff coverage is `96.15%`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#4619  +/-   ##
   =
   - Coverage  43.42%   43.39%   -0.04% 
   + Complexity  6213 6197  -16 
   =
 Files817  817  
 Lines  5765457654  
 Branches7873 7873  
   =
   - Hits   2503725019  -18 
   - Misses 2938429395  +11 
   - Partials3233 3240   +7 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/4619?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...mq/client/trace/hook/SendMessageTraceHookImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4619/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvaG9vay9TZW5kTWVzc2FnZVRyYWNlSG9va0ltcGwuamF2YQ==)
 | `70.73% <93.33%> (ø)` | |
   | 
[...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4619/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==)
 | `68.80% <100.00%> (+0.50%)` | :arrow_up: |
   | 
[...va/org/apache/rocketmq/store/FlushDiskWatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4619/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0ZsdXNoRGlza1dhdGNoZXIuamF2YQ==)
 | `81.25% <0.00%> (-9.38%)` | :arrow_down: |
   | 
[...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4619/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=)
 | `41.79% <0.00%> (-8.96%)` | :arrow_down: |
   | 
[...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4619/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=)
 | `33.20% <0.00%> (-2.21%)` | :arrow_down: |
   | 
[...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/4619/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==)
 | `45.64% <0.00%> (-1.80%)` | :arrow_down: |
   | 
[...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4619/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==)
 | `81.42% <0.00%> (-1.43%)` | :arrow_down: |
   | 
[...mq/client/impl/consumer/RebalanceLitePullImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4619/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb

[GitHub] [rocketmq] hzh0425 opened a new pull request, #4620: [Summer of code] Identify broker by uuid

[GitBox]

hzh0425 opened a new pull request, #4620:
URL: https://github.com/apache/rocketmq/pull/4620

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   Identify broker by uuid
   
   tracking issue: https://github.com/apache/rocketmq/issues/4330
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4613: [ISSUE #4612] fix trace not complete

[GitBox]

coveralls commented on PR #4613:
URL: https://github.com/apache/rocketmq/pull/4613#issuecomment-1186482038

   
   [![Coverage 
Status](https://coveralls.io/builds/50927477/badge)](https://coveralls.io/builds/50927477)
   
   Coverage decreased (-0.007%) to 47.584% when pulling 
**0bc153f7513408cec72bf50cb5cf712c1d164d09 on panzhi33:develop** into 
**00da3e7249d2339717d96f7ea2ab8e4a2fd4242c on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4613: [ISSUE #4612] fix trace not complete

[GitBox]

codecov-commenter commented on PR #4613:
URL: https://github.com/apache/rocketmq/pull/4613#issuecomment-1186470996

   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/4613?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#4613](https://codecov.io/gh/apache/rocketmq/pull/4613?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (0bc153f) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/225bc42f9597cd9ff38fd01c2d5168c68a7f5cf8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (225bc42) will **increase** coverage by `0.04%`.
   > The diff coverage is `85.18%`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#4613  +/-   ##
   =
   + Coverage  43.42%   43.47%   +0.04% 
   - Complexity  6213 6217   +4 
   =
 Files817  817  
 Lines  5765457667  +13 
 Branches7873 7874   +1 
   =
   + Hits   2503725068  +31 
   + Misses 2938429358  -26 
   - Partials3233 3241   +8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/4613?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/4613/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=)
 | `50.00% <0.00%> (-0.18%)` | :arrow_down: |
   | 
[...consumer/ConsumeMessagePopConcurrentlyService.java](https://codecov.io/gh/apache/rocketmq/pull/4613/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZVBvcENvbmN1cnJlbnRseVNlcnZpY2UuamF2YQ==)
 | `5.67% <0.00%> (-0.03%)` | :arrow_down: |
   | 
[...lient/impl/consumer/DefaultMQPullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4613/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdWxsQ29uc3VtZXJJbXBsLmphdmE=)
 | `29.32% <0.00%> (-0.09%)` | :arrow_down: |
   | 
[...apache/rocketmq/client/trace/TraceDataEncoder.java](https://codecov.io/gh/apache/rocketmq/pull/4613/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvVHJhY2VEYXRhRW5jb2Rlci5qYXZh)
 | `69.28% <75.00%> (-0.46%)` | :arrow_down: |
   | 
[...he/rocketmq/client/hook/ConsumeMessageContext.java](https://codecov.io/gh/apache/rocketmq/pull/4613/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaG9vay9Db25zdW1lTWVzc2FnZUNvbnRleHQuamF2YQ==)
 | `89.28% <100.00%> (+1.28%)` | :arrow_up: |
   | 
[...pl/consumer/ConsumeMessageConcurrentlyService.java](https://codecov.io/gh/apache/rocketmq/pull/4613/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZUNvbmN1cnJlbnRseVNlcnZpY2UuamF2YQ==)
 | `48.38% <100.00%> (+0.23%)` | :arrow_up: |
   | 
[...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4613/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==)
 | `68.18% <100.00%> (-0.12%)` | :arrow_down: |
   | 
[...org/apache/rocketmq/client/trace/TraceContext.java](https://codecov.io/gh/apache/rocketmq/pull/4613/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[GitHub] [rocketmq] drpmma commented on a diff in pull request #4615: [ISSUE #3905] Support bname in protocol

[GitBox]

drpmma commented on code in PR #4615:
URL: https://github.com/apache/rocketmq/pull/4615#discussion_r922795300


##
client/src/main/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStore.java:
##
@@ -213,6 +213,7 @@ public void updateConsumeOffsetToBroker(MessageQueue mq, 
long offset, boolean is
 requestHeader.setConsumerGroup(this.groupName);
 requestHeader.setQueueId(mq.getQueueId());
 requestHeader.setCommitOffset(offset);
+requestHeader.setBname(mq.getBrokerName());

Review Comment:
   The `bname` is not in the scope of this pr, see 
b6ff649291453d3dc2d702fbba1548d991b610ac for more information.
   
   I guess `bname` is shorter than `brokerName` thus it is more efficient in 
tranport.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org