[GitHub] [rocketmq] mxsm commented on a diff in pull request #4768: [ISSUE #4745]Check controllerDLegerPeers and controllerDLegerSelfId attributes before create DLedgerServer

[GitBox]

mxsm commented on code in PR #4768:
URL: https://github.com/apache/rocketmq/pull/4768#discussion_r936256343


##
controller/src/main/java/org/apache/rocketmq/controller/ControllerManager.java:
##
@@ -91,6 +91,12 @@ protected  RunnableFuture newTaskFor(final Runnable 
runnable, final T valu
 }
 };
 this.heartbeatManager = new 
DefaultBrokerHeartbeatManager(this.controllerConfig);
+if 
(StringUtils.isEmpty(this.controllerConfig.getControllerDLegerPeers())) {
+throw new IllegalArgumentException("Attribute value 
controllerDLegerPeers of ControllerConfig is null");
+}
+
if(StringUtils.isEmpty(this.controllerConfig.getControllerDLegerSelfId())){
+throw new IllegalArgumentException("Attribute value 
controllerDLegerSelfId of ControllerConfig is null");

Review Comment:
   > 'is null or empty' may be more accurate.
   
   OK I will modify it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-schema-registry] humkum commented on pull request #25: refine avro serde type to SpecificAvroSerde and GernericAvroSerde

[GitBox]

humkum commented on PR #25:
URL: 
https://github.com/apache/rocketmq-schema-registry/pull/25#issuecomment-1203444750

   > > > What is the relation between SpecificAvroSerde, GernericAvroSerde and 
AvroSerde？Up-down dependency, or parallel ?
   > > > If SpecificAvroSerde and GernericAvroSerde are exposed to users and 
they are dependent on AvroSerde, I think AvroSerde should be moved to common 
module, to avoid user confusion. If they are parallel, it is better to merge 
the Serde package and the Serializer package. Or I will feel a bit confused 
about which to choose.
   > > > @humkum @ferrirW
   > > 
   > > 
   > > I can't agree more with you, their relationship is an Up-down 
dependency, and I agree to move AvroSerde to common package
   > 
   > I‘m sorry. I try to move to common module but it's more unreasonable 
because AvroSerde is dependent on SchemaRegistryClient, so let's just keep this 
way. I guess you have learned kafka-schema-registry, so I agree with your 
current design.
   > 
   > _Is it better to make a "avro" package under the "serde" path, leave 
expansion room for JSON serde and Protobuf serde ?_ BTW, you can take this into 
consideration.
   
   Okay , it's a future plan.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-connect] zxhjames opened a new pull request, #229: add clickhouse jdbc insert unit test

[GitBox]

zxhjames opened a new pull request, #229:
URL: https://github.com/apache/rocketmq-connect/pull/229

   ## What is the purpose of the change
   
   To extend the Sink service test case that writes to the ClickHouse database
   
   Follow #216 
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq-connect/issues) filed for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a Github issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-connect] zxhjames commented on issue #216: Documentation for rocketmq-connector-jdbc should be updated

[GitBox]

zxhjames commented on issue #216:
URL: 
https://github.com/apache/rocketmq-connect/issues/216#issuecomment-1203434424

   Added some data writing test cases about clickhouse database on the sink 
side 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-schema-registry] MatrixHB commented on pull request #25: refine avro serde type to SpecificAvroSerde and GernericAvroSerde

[GitBox]

MatrixHB commented on PR #25:
URL: 
https://github.com/apache/rocketmq-schema-registry/pull/25#issuecomment-1203433179

   > > What is the relation between SpecificAvroSerde, GernericAvroSerde and 
AvroSerde？Up-down dependency, or parallel ?
   > > If SpecificAvroSerde and GernericAvroSerde are exposed to users and they 
are dependent on AvroSerde, I think AvroSerde should be moved to common module, 
to avoid user confusion. If they are parallel, it is better to merge the Serde 
package and the Serializer package. Or I will feel a bit confused about which 
to choose.
   > > @humkum @ferrirW
   > 
   > I can't agree more with you, their relationship is an Up-down dependency, 
and I agree to move AvroSerde to common package
   
   I‘m sorry. I try to move but it's more unreasonable because AvroSerde is 
dependent on SchemaRegistryClient, so let's just keep this way.
   I guess you have learned kafka-schema-registry, so I agree with your current 
design.
   
   --
   _Is it better to make a "avro" package under the "serde" path, leave 
expansion room for JSON serde and Protobuf serde ?_
   BTW, you can take this into consideration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-schema-registry] humkum commented on pull request #25: refine avro serde type to SpecificAvroSerde and GernericAvroSerde

[GitBox]

humkum commented on PR #25:
URL: 
https://github.com/apache/rocketmq-schema-registry/pull/25#issuecomment-1203419743

   > What is the relation between SpecificAvroSerde, GernericAvroSerde and 
AvroSerde？Up-down dependency, or parallel ?
   > 
   > If SpecificAvroSerde and GernericAvroSerde are exposed to users and they 
are dependent on AvroSerde, I think AvroSerde should be moved to common module, 
to avoid user confusion. If they are parallel, it is better to merge the Serde 
package and the Serializer package. Or I will feel a bit confused about which 
to choose.
   > 
   > @humkum @ferrirW
   
   I can't agree more with you, their relationship is an Up-down dependency, 
and I agree to move AvroSerde to common package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-spring] panzhi33 commented on issue #467: Heap memory leak caused OOM

[GitBox]

panzhi33 commented on issue #467:
URL: 
https://github.com/apache/rocketmq-spring/issues/467#issuecomment-1203417162

   Is litePull also used when using rocketmq-client ?
DefaultLitePullConsumerImpl caches a large number of ConsumeRequest 
objects, and ConsumeRequest also holds message objects,the reason is still 
consume slowly.  can search rocketmq_client.log for 'The consume request count 
exceeds'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-schema-registry] ferrirW commented on a diff in pull request #25: refine avro serde type to SpecificAvroSerde and GernericAvroSerde

[GitBox]

ferrirW commented on code in PR #25:
URL: 
https://github.com/apache/rocketmq-schema-registry/pull/25#discussion_r936183073


##
example/src/main/java/org/apache/rocketmq/schema/registry/example/serde/SpecificAvroSerdeDemo.java:
##
@@ -19,26 +19,28 @@
 
 import org.apache.rocketmq.schema.registry.client.SchemaRegistryClient;
 import org.apache.rocketmq.schema.registry.client.SchemaRegistryClientFactory;
-import org.apache.rocketmq.schema.registry.client.serializer.AvroDeserializer;
-import org.apache.rocketmq.schema.registry.client.serializer.AvroSerializer;
-import org.apache.rocketmq.schema.registry.client.serializer.Deserializer;
-import org.apache.rocketmq.schema.registry.client.serializer.Serializer;
+import org.apache.rocketmq.schema.registry.client.serde.SpecificAvroSerde;
 
-public class AvroSerdeDemo {
+import java.io.IOException;
+
+public class SpecificAvroSerdeDemo {
 
 public static void main(String[] args) {
 
 String baseUrl = "http://localhost:8080/schema-registry/v1;;

Review Comment:
   Instead, mock a SchemaRegistry in a unit test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] zyx333 closed issue #4766: No error message is logged in catch block

[GitBox]

zyx333 closed issue #4766: No error message is logged in catch block
URL: https://github.com/apache/rocketmq/issues/4766


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] zyx333 commented on issue #4766: No error message is logged in catch block

[GitBox]

zyx333 commented on issue #4766:
URL: https://github.com/apache/rocketmq/issues/4766#issuecomment-1203415058

   get it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-schema-registry] MatrixHB commented on pull request #25: refine avro serde type to SpecificAvroSerde and GernericAvroSerde

[GitBox]

MatrixHB commented on PR #25:
URL: 
https://github.com/apache/rocketmq-schema-registry/pull/25#issuecomment-1203414513

   Is it better to make a "avro" package under the "serde" path, leave 
expansion room for JSON serde and Protobuf serde.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] zyx333 closed pull request #4767: [ISSUE #4766] add error log

[GitBox]

zyx333 closed pull request #4767: [ISSUE #4766] add error log
URL: https://github.com/apache/rocketmq/pull/4767


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-schema-registry] MatrixHB commented on pull request #25: refine avro serde type to SpecificAvroSerde and GernericAvroSerde

[GitBox]

MatrixHB commented on PR #25:
URL: 
https://github.com/apache/rocketmq-schema-registry/pull/25#issuecomment-1203411734

   What is the relation between SpecificAvroSerde, GernericAvroSerde and 
AvroSerde？Up-down dependency, or parallel ?
   
   If SpecificAvroSerde and GernericAvroSerde are exposed to users and they are 
dependent on AvroSerde, I think AvroSerde should be moved to common module, to 
avoid user confusion. 
   If they are parallel, it is better to merge the Serde package and the 
Serializer package. Or I will feel a bit confused about which to choose.
   
   @humkum @ferrirW 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-clients] guyinyou closed pull request #81: Golang: implement producer and simple consumer

[GitBox]

guyinyou closed pull request #81: Golang: implement producer and simple consumer
URL: https://github.com/apache/rocketmq-clients/pull/81


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-schema-registry] caigy commented on a diff in pull request #24: [docs] modify introduction and add some detail

[GitBox]

caigy commented on code in PR #24:
URL: 
https://github.com/apache/rocketmq-schema-registry/pull/24#discussion_r936174551


##
README.md:
##
@@ -20,21 +21,13 @@ It offers a variety of features:
 Getting started
 --
 
- Installation
-
-```shell
-$ git clone g...@github.com:apache/rocketmq-schema-registry.git
-$ cd rocketmq-schema-registry
-$ mvn clean package
-```
-
  Prepare storage layer
 
-Currently, only RocketMQ is supported as the storage layer. And relies on the 
Compact Topic feature of RocketMQ 5.0,
-although previous versions can also be worked, but there is a risk of data 
loss if the machine disk fails. Similarly,
+Currently, Schema registry only support RocketMQ storage, and relies on the 
Compact Topic feature of RocketMQ-5.0.

Review Comment:
   'support' -> 'supports'



##
README.md:
##
@@ -51,24 +44,29 @@ $ nohup sh mqnamesrv &
 $ nohup sh mqbroker -n localhost:9876 &
 ```
 
- Edit configuration (Optional)
-
-* Config storage local cache path
+ Install & Running locally
 
 ```shell
-$ echo "storage.local.cache.path=${user.dir}" >> 
storage-rocketmq/src/main/resources/rocketmq.properties
+$ git clone g...@github.com:apache/rocketmq-schema-registry.git
+$ cd rocketmq-schema-registry
+$ mvn clean package
 ```
 
- Deployment & Running locally
-
 Take the build JAR in core/target/ and run `java -jar 
rocketmq-schema-registry-core-0.0.3-SNAPSHOT.jar` to start service.
 
 Then REST API can be accessed from http://localhost:8080/schema-registry/v1
 
 Swagger API documentation can be accessed from 
http://localhost:8080/swagger-ui/index.html
 
-Package management
---
+ Customize configuration (Optional)

Review Comment:
   is it 'customized configurations'?



##
README.md:
##
@@ -20,21 +21,13 @@ It offers a variety of features:
 Getting started
 --
 
- Installation
-
-```shell
-$ git clone g...@github.com:apache/rocketmq-schema-registry.git
-$ cd rocketmq-schema-registry
-$ mvn clean package
-```
-
  Prepare storage layer
 
-Currently, only RocketMQ is supported as the storage layer. And relies on the 
Compact Topic feature of RocketMQ 5.0,
-although previous versions can also be worked, but there is a risk of data 
loss if the machine disk fails. Similarly,
+Currently, Schema registry only support RocketMQ storage, and relies on the 
Compact Topic feature of RocketMQ-5.0.
+Previous rocketmq versions can also be worked, but there are some risk of data 
loss if the machine disk fails. 

Review Comment:
   'rocketmq' -> 'RocketMQ'



##
README.md:
##
@@ -119,6 +117,37 @@ $ curl -X GET 
http://localhost:8080/schema-registry/v1/cluster/{cluster-name}/te
 $ curl -X GET 
http://localhost:8080/schema-registry/v1/cluster/{cluster-name}/tenant/{tenant-name}/subject/{subject-name}/schema/versions
 ```
 
+Compatibility
+--
+Default compatibility is BACKWARD, which means that each change of Schema has 
no impact on the running programs. 
+Transitivity specifies the compatibility check scope for each change.
+
+| Compatible strategy | Permitted changes | Transitivity   
   | Upgrade order |
+|-|---|---|---|
+| BACKWARD| Delete fields Add optional fields | Last version   
   | Consumers |
+| BACKWARD_TRANSITIVE | Delete fields Add optional fields | All previous 
versions | Consumers |
+| FORWARD | Add fields Delete optional fields | Last version   
   | Producers |
+| FORWARD_TRANSITIVE  | Add fields Delete optional fields | All previous 
versions | Producers |
+| FULL| Modify optional fields| Last version   
   | Any order |
+| FULL_TRANSITIVE | Modify optional fields| All previous 
versions | Any order |
+| NONE| All changes are accepted  | Disabled   
   | Depends   |
+
+Architecture
+--
+
+Once Schema Registry enabled, the process for publish and subscribe will 
become to:

Review Comment:
   'the process for publishing and subscribing' may be more appropriate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] ni-ze commented on pull request #4752: [ISSUE #4749] make topic length , consumer group length configable

[GitBox]

ni-ze commented on PR #4752:
URL: https://github.com/apache/rocketmq/pull/4752#issuecomment-1203402182

   ```java
void setMaxTopicLength(int maxLength);
   int getMaxTopicLength();
   ```
   IMO,  Put those two method into **ClientConfig** will be better. 
MQConsumer,LitePullConsumer and MQConsumerInner contains code about 
send/consume message only.  Set/get config should use ClientConfig.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] caigy commented on a diff in pull request #4768: [ISSUE #4745]Check controllerDLegerPeers and controllerDLegerSelfId attributes before create DLedgerServer

[GitBox]

caigy commented on code in PR #4768:
URL: https://github.com/apache/rocketmq/pull/4768#discussion_r936170421


##
controller/src/main/java/org/apache/rocketmq/controller/ControllerManager.java:
##
@@ -91,6 +91,12 @@ protected  RunnableFuture newTaskFor(final Runnable 
runnable, final T valu
 }
 };
 this.heartbeatManager = new 
DefaultBrokerHeartbeatManager(this.controllerConfig);
+if 
(StringUtils.isEmpty(this.controllerConfig.getControllerDLegerPeers())) {
+throw new IllegalArgumentException("Attribute value 
controllerDLegerPeers of ControllerConfig is null");
+}
+
if(StringUtils.isEmpty(this.controllerConfig.getControllerDLegerSelfId())){
+throw new IllegalArgumentException("Attribute value 
controllerDLegerSelfId of ControllerConfig is null");

Review Comment:
   'is null or empty' may be more accurate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Cczzzz commented on issue #4720: When the broker master fails，return timeout，Client will not retry.

[GitBox]

Cc commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1203397994

   no,is different


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-site] RongtongJin merged pull request #174: Finish 4.x website

[GitBox]

RongtongJin merged PR #174:
URL: https://github.com/apache/rocketmq-site/pull/174


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #4715: [ISSUE #4698]NamesrvStartup code optimize

[GitBox]

RongtongJin commented on PR #4715:
URL: https://github.com/apache/rocketmq/pull/4715#issuecomment-1203376709

   @mxsm Could you help solve the code conflict first?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] RongtongJin closed issue #4706: Console print log incorrect format

[GitBox]

RongtongJin closed issue #4706: Console print log incorrect format
URL: https://github.com/apache/rocketmq/issues/4706


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] RongtongJin merged pull request #4716: [ISSUE #4706] fix console printed log format is incorrect

[GitBox]

RongtongJin merged PR #4716:
URL: https://github.com/apache/rocketmq/pull/4716


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on issue #4766: No error message is logged in catch block

[GitBox]

RongtongJin commented on issue #4766:
URL: https://github.com/apache/rocketmq/issues/4766#issuecomment-1203369470

   There is no need to print logs here, because rocketmq master-slave 
replication is is based on streams rather than messages , so it is common to 
dispatch half messages. If you print logs here, there will be a lot of dirty 
logs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #4767: [ISSUE #4766] add error log

[GitBox]

RongtongJin commented on code in PR #4767:
URL: https://github.com/apache/rocketmq/pull/4767#discussion_r936147879


##
store/src/main/java/org/apache/rocketmq/store/CommitLog.java:
##
@@ -532,6 +532,7 @@ public DispatchRequest 
checkMessageAndReturnSize(java.nio.ByteBuffer byteBuffer,
 
 return dispatchRequest;
 } catch (Exception e) {
+log.error("CommitLog: check message failed", e);

Review Comment:
   There is no need to print logs here, because rocketmq master-slave 
replication is is based on streams rather than messages , so it is common to 
dispatch half messages.  If you print logs here, there will be a lot of dirty 
logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #4767: [ISSUE #4766] add error log

[GitBox]

RongtongJin commented on code in PR #4767:
URL: https://github.com/apache/rocketmq/pull/4767#discussion_r936147879


##
store/src/main/java/org/apache/rocketmq/store/CommitLog.java:
##
@@ -532,6 +532,7 @@ public DispatchRequest 
checkMessageAndReturnSize(java.nio.ByteBuffer byteBuffer,
 
 return dispatchRequest;
 } catch (Exception e) {
+log.error("CommitLog: check message failed", e);

Review Comment:
   There is no need to print logs here, because rocketmq master-slave 
replication is is based on streams rather than messages , so it is common to 
dispatch half messages  If you print logs here, there will be a lot of dirty 
logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-schema-registry] codecov-commenter commented on pull request #25: refine avro serde type to SpecificAvroSerde and GernericAvroSerde

[GitBox]

codecov-commenter commented on PR #25:
URL: 
https://github.com/apache/rocketmq-schema-registry/pull/25#issuecomment-1203078565

   # 
[Codecov](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/25?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#25](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/25?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (217cc5c) into 
[main](https://codecov.io/gh/apache/rocketmq-schema-registry/commit/e85fbf7afeb7d43694f7974828e51720a1ee0645?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (e85fbf7) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@  Coverage Diff  @@
   ##main #25   +/-   ##
   =
 Coverage   0.00%   0.00%   
   =
 Files 16  16   
 Lines367 367   
 Branches  16  16   
   =
 Misses   367 367   
   ```
   
   
   
   Help us with your feedback. Take ten seconds to tell us [how you rate 
us](https://about.codecov.io/nps?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4767: [ISSUE #4766] add error log

[GitBox]

codecov-commenter commented on PR #4767:
URL: https://github.com/apache/rocketmq/pull/4767#issuecomment-1202866685

   # 
[Codecov](https://codecov.io/gh/apache/rocketmq/pull/4767?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#4767](https://codecov.io/gh/apache/rocketmq/pull/4767?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (d46f58b) into 
[develop](https://codecov.io/gh/apache/rocketmq/commit/0d1eec2b9ca5ac8e19190e96cb29d7191d14dbe5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (0d1eec2) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#4767  +/-   ##
   =
   - Coverage  45.04%   45.03%   -0.02% 
   - Complexity  7613 7621   +8 
   =
 Files977  977  
 Lines  6777867779   +1 
 Branches8959 8959  
   =
   - Hits   3053330523  -10 
   - Misses 3347833484   +6 
   - Partials3767 3772   +5 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq/pull/4767?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/4767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh)
 | `69.32% <0.00%> (+0.02%)` | :arrow_up: |
   | 
[...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=)
 | `44.77% <0.00%> (-7.47%)` | :arrow_down: |
   | 
[...a/org/apache/rocketmq/broker/BrokerController.java](https://codecov.io/gh/apache/rocketmq/pull/4767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh)
 | `43.90% <0.00%> (-2.66%)` | :arrow_down: |
   | 
[...ache/rocketmq/broker/client/ConsumerGroupInfo.java](https://codecov.io/gh/apache/rocketmq/pull/4767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY2xpZW50L0NvbnN1bWVyR3JvdXBJbmZvLmphdmE=)
 | `68.46% <0.00%> (-0.91%)` | :arrow_down: |
   | 
[...client/consumer/store/RemoteBrokerOffsetStore.java](https://codecov.io/gh/apache/rocketmq/pull/4767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvc3RvcmUvUmVtb3RlQnJva2VyT2Zmc2V0U3RvcmUuamF2YQ==)
 | `68.14% <0.00%> (-0.89%)` | :arrow_down: |
   | 
[...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://codecov.io/gh/apache/rocketmq/pull/4767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh)
 | `53.76% <0.00%> (-0.36%)` | :arrow_down: |
   | 
[...apache/rocketmq/store/timer/TimerMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/4767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3RpbWVyL1RpbWVyTWVzc2FnZVN0b3JlLmphdmE=)
 | `54.19% <0.00%> (+0.10%)` | :arrow_up: |
   | 
[...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/4767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==)
 | `62.38% <0.00%> (+0.45%)` | :arrow_up: |
   | 

[GitHub] [rocketmq] coveralls commented on pull request #4767: [ISSUE #4766] add error log

[GitBox]

coveralls commented on PR #4767:
URL: https://github.com/apache/rocketmq/pull/4767#issuecomment-1202861439

   
   [![Coverage 
Status](https://coveralls.io/builds/51355279/badge)](https://coveralls.io/builds/51355279)
   
   Coverage increased (+0.05%) to 49.319% when pulling 
**d46f58b02d1dabbf60655d8f20992c56eacdecd1 on zyx333:adderrormsg** into 
**0d1eec2b9ca5ac8e19190e96cb29d7191d14dbe5 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-site] SamanthaWangdl opened a new pull request, #174: Finish 4.x website

[GitBox]

SamanthaWangdl opened a new pull request, #174:
URL: https://github.com/apache/rocketmq-site/pull/174

   I have checked all the documentation and front-end code of the site. There 
is no problem with the test site.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [Vote] Release gRPC Client for Apache RocketMQ 5.0.0 RC1

[yukon]

+1

On Tue, Aug 2, 2022 at 8:50 PM aaron ai  wrote:

> The artifacts have been migrated to the path below:
>
> Java:
>
> https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.0-rc1/
> CPP:
>
> https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-clients/rocketmq-client-cpp/5.0.0-rc1/
>
> lollipop  于2022年8月2日周二 10:44写道：
>
> > +1
> >
> > I checked：
> > [OK ]  Checksums and PGP signatures are valid for source package.
> > [OK ]  License and Notice are correct in source package.
> >
> > On Tue, Aug 2, 2022 at 10:32 AM Zhanhui Li  wrote:
> >
> > > +1
> > >
> > > I checked the license, notice and checksum, GPG signature.
> > >
> > > I also validated compilation instructions of the CPP SDK on a clean
> > docker.
> > >
> > > On Mon, Aug 1, 2022 at 8:39 PM aaron ai  wrote:
> > >
> > > > Hello RocketMQ Community,
> > > >
> > > > This is the vote for 5.0.0 RC1 of Apache RocketMQ clients.
> > > >
> > > > Apache RocketMQ clients 5.x series follow the specs of rocketmq-apis
> > > > , and are built on top of
> > > > Protocol Buffer and gRPC.
> > > >
> > > > The artifacts:
> > > >
> > > >-
> > > >
> > > >Java:
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-client-java/5.0.0-rc1/
> > > >-
> > > >
> > > >CPP:
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-client-cpp/5.0.0-rc1/
> > > >
> > > >
> > > > The staging repo for maven:
> > > >
> > > >
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapacherocketmq-1094/
> > > >
> > > > Git tag for the release:
> > > >
> > > >-
> > > >
> > > >Java:
> > > >
> > >
> >
> https://github.com/apache/rocketmq-clients/tree/rocketmq-client-java-5.0.0
> > > >-
> > > >
> > > >CPP:
> https://github.com/apache/rocketmq-clients/tree/cpp-5.0.0-rc1
> > > >
> > > >
> > > > Hash for the release tag:
> > > >
> > > >-
> > > >
> > > >Java: db031977d2e0a1e0d64e43f3daf10eab080a13ac
> > > >-
> > > >
> > > >CPP: 6fcff3207d292d925d06f44148934b8d79c1ab4a
> > > >
> > > >
> > > > Relate Notes:
> > > >
> > > >-
> > > >
> > > >Java:
> > > >
> > >
> >
> https://github.com/apache/rocketmq-clients/releases/tag/rocketmq-client-java-5.0.0
> > > >-
> > > >
> > > >CPP:
> > > >
> > https://github.com/apache/rocketmq-clients/releases/tag/cpp-5.0.0-rc1
> > > >
> > > >
> > > > The artifacts have been signed with Key :
> > > >
> > > > 3A11FEBBD64C807A233BF1F27C46C79BD4D29011, which can be found in the
> > keys
> > > > file: https://dist.apache.org/repos/dist/dev/rocketmq/KEYS
> > > >
> > > > Fill in the following:
> > > >
> > > > [+]  check LICENSE, should be Apache V2
> > > >
> > > > [+]  check NOTICE, should have a notice for third-party dependency if
> > > > necessary
> > > >
> > > > [+]  extract the zip and check if the source version is correct
> > > >
> > > > [+]  verify the asc(PGP sign),SHA512
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > The vote will be open for at least 72 hours or until the necessary
> > number
> > > > of votes are reached.
> > > >
> > > > Please vote accordingly:
> > > >
> > > >
> > > >
> > > >
> > > > [ ] +1 approve
> > > >
> > > > [ ] +0 no opinion
> > > >
> > > > [ ] -1 disapprove with the reason
> > > >
> > > >
> > > >
> > > >
> > > > Thanks
> > > >
> > > > The Apache RocketMQ Team
> > > >
> > > >
> > > >
> > >
> >
>

[GitHub] [rocketmq] mxsm opened a new pull request, #4768: [ISSUE #4745]Check controllerDLegerPeers and controllerDLegerSelfId attributes before create DLedgerServer

[GitBox]

mxsm opened a new pull request, #4768:
URL: https://github.com/apache/rocketmq/pull/4768

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   close #4745 
   
   ## Brief changelog
   
   - Check controllerDLegerPeers and controllerDLegerSelfId attributes before 
create DLedgerServer
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-schema-registry] humkum opened a new pull request, #25: refine avro serde type to SpecificAvroSerde and GernericAvroSerde

[GitBox]

humkum opened a new pull request, #25:
URL: https://github.com/apache/rocketmq-schema-registry/pull/25

   1. provide specific avro serde & generic avro serde
   2. change some  annotation message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [Vote] Release gRPC Client for Apache RocketMQ 5.0.0 RC1

[aaron ai]

The artifacts have been migrated to the path below:

Java:
https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-clients/rocketmq-client-java/5.0.0-rc1/
CPP:
https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-clients/rocketmq-client-cpp/5.0.0-rc1/

lollipop  于2022年8月2日周二 10:44写道：

> +1
>
> I checked：
> [OK ]  Checksums and PGP signatures are valid for source package.
> [OK ]  License and Notice are correct in source package.
>
> On Tue, Aug 2, 2022 at 10:32 AM Zhanhui Li  wrote:
>
> > +1
> >
> > I checked the license, notice and checksum, GPG signature.
> >
> > I also validated compilation instructions of the CPP SDK on a clean
> docker.
> >
> > On Mon, Aug 1, 2022 at 8:39 PM aaron ai  wrote:
> >
> > > Hello RocketMQ Community,
> > >
> > > This is the vote for 5.0.0 RC1 of Apache RocketMQ clients.
> > >
> > > Apache RocketMQ clients 5.x series follow the specs of rocketmq-apis
> > > , and are built on top of
> > > Protocol Buffer and gRPC.
> > >
> > > The artifacts:
> > >
> > >-
> > >
> > >Java:
> > >
> >
> https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-client-java/5.0.0-rc1/
> > >-
> > >
> > >CPP:
> > >
> >
> https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-client-cpp/5.0.0-rc1/
> > >
> > >
> > > The staging repo for maven:
> > >
> > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapacherocketmq-1094/
> > >
> > > Git tag for the release:
> > >
> > >-
> > >
> > >Java:
> > >
> >
> https://github.com/apache/rocketmq-clients/tree/rocketmq-client-java-5.0.0
> > >-
> > >
> > >CPP: https://github.com/apache/rocketmq-clients/tree/cpp-5.0.0-rc1
> > >
> > >
> > > Hash for the release tag:
> > >
> > >-
> > >
> > >Java: db031977d2e0a1e0d64e43f3daf10eab080a13ac
> > >-
> > >
> > >CPP: 6fcff3207d292d925d06f44148934b8d79c1ab4a
> > >
> > >
> > > Relate Notes:
> > >
> > >-
> > >
> > >Java:
> > >
> >
> https://github.com/apache/rocketmq-clients/releases/tag/rocketmq-client-java-5.0.0
> > >-
> > >
> > >CPP:
> > >
> https://github.com/apache/rocketmq-clients/releases/tag/cpp-5.0.0-rc1
> > >
> > >
> > > The artifacts have been signed with Key :
> > >
> > > 3A11FEBBD64C807A233BF1F27C46C79BD4D29011, which can be found in the
> keys
> > > file: https://dist.apache.org/repos/dist/dev/rocketmq/KEYS
> > >
> > > Fill in the following:
> > >
> > > [+]  check LICENSE, should be Apache V2
> > >
> > > [+]  check NOTICE, should have a notice for third-party dependency if
> > > necessary
> > >
> > > [+]  extract the zip and check if the source version is correct
> > >
> > > [+]  verify the asc(PGP sign),SHA512
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > The vote will be open for at least 72 hours or until the necessary
> number
> > > of votes are reached.
> > >
> > > Please vote accordingly:
> > >
> > >
> > >
> > >
> > > [ ] +1 approve
> > >
> > > [ ] +0 no opinion
> > >
> > > [ ] -1 disapprove with the reason
> > >
> > >
> > >
> > >
> > > Thanks
> > >
> > > The Apache RocketMQ Team
> > >
> > >
> > >
> >
>

[GitHub] [rocketmq-clients] aaron-ai merged pull request #130: Remove coverage from readme

[GitBox]

aaron-ai merged PR #130:
URL: https://github.com/apache/rocketmq-clients/pull/130


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] zyx333 commented on issue #4766: No error message is logged in catch block

[GitBox]

zyx333 commented on issue #4766:
URL: https://github.com/apache/rocketmq/issues/4766#issuecomment-1202422311

   #4767 solved in this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-clients] aaron-ai merged pull request #129: Support codecov

[GitBox]

aaron-ai merged PR #129:
URL: https://github.com/apache/rocketmq-clients/pull/129


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] zyx333 opened a new pull request, #4767: [ISSUE #4766] add error log

[GitBox]

zyx333 opened a new pull request, #4767:
URL: https://github.com/apache/rocketmq/pull/4767

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   X
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] zyx333 opened a new issue, #4766: No error message is logged in catch block

[GitBox]

zyx333 opened a new issue, #4766:
URL: https://github.com/apache/rocketmq/issues/4766

   It's better to print error message here for the convenience of debugging.
   
   
https://github.com/apache/rocketmq/blob/0d1eec2b9ca5ac8e19190e96cb29d7191d14dbe5/store/src/main/java/org/apache/rocketmq/store/CommitLog.java#L533-L537
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-schema-registry] codecov-commenter commented on pull request #24: [docs] modify introduction and add some detail

[GitBox]

codecov-commenter commented on PR #24:
URL: 
https://github.com/apache/rocketmq-schema-registry/pull/24#issuecomment-1202381684

   # 
[Codecov](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/24?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#24](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/24?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (5540d23) into 
[main](https://codecov.io/gh/apache/rocketmq-schema-registry/commit/e85fbf7afeb7d43694f7974828e51720a1ee0645?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (e85fbf7) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@  Coverage Diff  @@
   ##main #24   +/-   ##
   =
 Coverage   0.00%   0.00%   
   =
 Files 16  16   
 Lines367 367   
 Branches  16  16   
   =
 Misses   367 367   
   ```
   
   
   
   Help us with your feedback. Take ten seconds to tell us [how you rate 
us](https://about.codecov.io/nps?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] duhenglucky merged pull request #4765: Update Description in .asf.yaml

[GitBox]

duhenglucky merged PR #4765:
URL: https://github.com/apache/rocketmq/pull/4765


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] tsunghanjacktsai opened a new pull request, #4765: Update Description in .asf.yaml

[GitBox]

tsunghanjacktsai opened a new pull request, #4765:
URL: https://github.com/apache/rocketmq/pull/4765

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   Update  info in .asf.yaml
   
   ## Brief changelog
   
   Update .asf.yaml
   
   ## Verifying this change
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-site] odbozhou merged pull request #173: Add new committer sunxiaojian

[GitBox]

odbozhou merged PR #173:
URL: https://github.com/apache/rocketmq-site/pull/173


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-site] sunxiaojian opened a new pull request, #173: Add new committer sunxiaojian

[GitBox]

sunxiaojian opened a new pull request, #173:
URL: https://github.com/apache/rocketmq-site/pull/173

   Add new committer sunxiaojian
   
   ## What is the purpose of the change
   
   X
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
   - [x] Make sure there is a Github issue filed for the change (usually before 
you start working on it). Trivial changes like typos do not require a Github 
issue. Your pull request should address just this issue, without pulling in 
other changes - one PR resolves one issue. 
   - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add integration-test in 
[test module](https://github.com/apache/rocketmq/tree/master/test).
   - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-flink] Ink00Bamboo opened a new issue, #48: Diff flink version support

[GitBox]

Ink00Bamboo opened a new issue, #48:
URL: https://github.com/apache/rocketmq-flink/issues/48

   have or not  a plan to split flink/rocketMq different version for more 
flexible version adaptation in flink and rocketMq


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] duhenglucky merged pull request #4764: Update .asf.yaml

[GitBox]

duhenglucky merged PR #4764:
URL: https://github.com/apache/rocketmq/pull/4764


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] neoguobiu opened a new pull request, #4764: Update .asf.yaml

[GitBox]

neoguobiu opened a new pull request, #4764:
URL: https://github.com/apache/rocketmq/pull/4764

description: "Apache RocketMQ is a cloud native messaging and streaming 
platform,  making it easy to build  event-driven applications." homepage: 
https://rocketmq.apache.org/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [ANNOUNCE]New Committers of Apache RocketMQ: Sun Xiaojian(apache id: sunxiaojian)

[heng du]

Congrats！@sunjiaojian929

周波  于2022年8月2日周二 17:40写道：

>- congrats
>
>
> ShannonDing  于2022年8月1日周一 15:18写道：
>
> > Hi Apache RocketMQ Community,
> >
> >
> >
> >
> > The Project Management Committee (PMC) for Apache RocketMQ has invited
> >
> > Sun Xiaojian(apache id: sunxiaojian),
> >
> > to become a committer, and we are pleased to announce that he has
> > accepted.
> >
> >
> >
> >
> > Congrats, guy :-)
> >
> >
> >
> >
> > Best Wishes,
> >
> > ShannonDing
>

Re: [ANNOUNCE]New Committers of Apache RocketMQ: Sun Xiaojian(apache id: sunxiaojian)

[Oliver]

+1 congratulation



| |
Oliver
|
|
wqdyx...@163.com
|


 Replied Message 
| From | 周波 |
| Date | 08/2/2022 17:40 |
| To |  |
| Subject | Re: [ANNOUNCE]New Committers of Apache RocketMQ: Sun 
Xiaojian(apache id: sunxiaojian) |
- congrats


ShannonDing  于2022年8月1日周一 15:18写道：

Hi Apache RocketMQ Community,




The Project Management Committee (PMC) for Apache RocketMQ has invited

Sun Xiaojian(apache id: sunxiaojian),

to become a committer, and we are pleased to announce that he has
accepted.




Congrats, guy :-)




Best Wishes,

ShannonDing

Re: [ANNOUNCE]New Committers of Apache RocketMQ: Sun Xiaojian(apache id: sunxiaojian)

[周波]

   - congrats


ShannonDing  于2022年8月1日周一 15:18写道：

> Hi Apache RocketMQ Community,
>
>
>
>
> The Project Management Committee (PMC) for Apache RocketMQ has invited
>
> Sun Xiaojian(apache id: sunxiaojian),
>
> to become a committer, and we are pleased to announce that he has
> accepted.
>
>
>
>
> Congrats, guy :-)
>
>
>
>
> Best Wishes,
>
> ShannonDing

[GitHub] [rocketmq-streams] ShannonDing commented on a diff in pull request #195: [ISSUE #196]fix(ChannelBuilder) add ChannelBuilder

[GitBox]

ShannonDing commented on code in PR #195:
URL: https://github.com/apache/rocketmq-streams/pull/195#discussion_r935329099


##
rocketmq-streams-commons/src/main/java/org/apache/rocketmq/streams/common/channel/impl/CollectionSourceBuilder.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.streams.common.channel.impl;
+
+import com.google.auto.service.AutoService;
+import 
org.apache.rocketmq.streams.common.channel.builder.AbstractSupportShuffleChannelBuilder;
+import org.apache.rocketmq.streams.common.channel.builder.IChannelBuilder;
+import org.apache.rocketmq.streams.common.channel.impl.memory.MemoryChannel;
+import org.apache.rocketmq.streams.common.channel.sink.ISink;
+import org.apache.rocketmq.streams.common.channel.source.ISource;
+import org.apache.rocketmq.streams.common.metadata.MetaData;
+import org.apache.rocketmq.streams.common.model.ServiceName;
+
+import java.util.Properties;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *

Review Comment:
   remove useless license header.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] duhenglucky commented on issue #4720: When the broker master fails，return timeout，Client will not retry.

[GitBox]

duhenglucky commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1202227663

   https://github.com/apache/rocketmq/pull/3555 @Cc Verify that this PR 
solves this issue 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] ShannonDing closed pull request #99: Update Dockerfile

[GitBox]

ShannonDing closed pull request #99: Update Dockerfile
URL: https://github.com/apache/rocketmq-operator/pull/99


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-operator] ShannonDing commented on pull request #99: Update Dockerfile

[GitBox]

ShannonDing commented on PR #99:
URL: https://github.com/apache/rocketmq-operator/pull/99#issuecomment-1202224537

   the latest rocketmq version have fix the package naming issue.
   4.9.2/4.9.3 : rocketmq-{version}
   others: rocketmq-all-{version}-bin-release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Cczzzz commented on issue #4720: When the broker master fails，return timeout，Client will not retry.

[GitBox]

Cc commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1202174042

   When I set the timeout to 10s, it still cannot be retried correctly.
   2022-08-02 16:22:05,917 WARN RocketmqClient - sendKernelImpl exception, 
resend at once, InvokeID: -2111425297163537192, RT: 10015ms, Broker: 
MessageQueue [topic=CONNECT, brokerName=broker-c, queueId=0]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] Cczzzz commented on issue #4720: When the broker master fails，return timeout，Client will not retry.

[GitBox]

Cc commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1202157957

   It will cause the client to fail when the master goes down.is this 
reasonable？I always thought the client was insensitive


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-schema-registry] codecov-commenter commented on pull request #23: [bugfix] fix some problems when testing the SchemaRegistryClient

[GitBox]

codecov-commenter commented on PR #23:
URL: 
https://github.com/apache/rocketmq-schema-registry/pull/23#issuecomment-1202132864

   # 
[Codecov](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/23?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#23](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/23?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (7aeeadd) into 
[main](https://codecov.io/gh/apache/rocketmq-schema-registry/commit/e85fbf7afeb7d43694f7974828e51720a1ee0645?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 (e85fbf7) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@  Coverage Diff  @@
   ##main #23   +/-   ##
   =
 Coverage   0.00%   0.00%   
   =
 Files 16  16   
 Lines367 369+2 
 Branches  16  17+1 
   =
   - Misses   367 369+2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/23?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...chema/registry/core/service/SchemaServiceImpl.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/23/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc2NoZW1hL3JlZ2lzdHJ5L2NvcmUvc2VydmljZS9TY2hlbWFTZXJ2aWNlSW1wbC5qYXZh)
 | `0.00% <0.00%> (ø)` | |
   
   Help us with your feedback. Take ten seconds to tell us [how you rate 
us](https://about.codecov.io/nps?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-schema-registry] MatrixHB opened a new pull request, #23: [bugfix] fix some problems when testing the SchemaRegistryClient

[GitBox]

MatrixHB opened a new pull request, #23:
URL: https://github.com/apache/rocketmq-schema-registry/pull/23

   bug1: When updating the schema, the audit info will be lost.
   
   bug2: When throwing SchemaNotFoundException, the massage cannot be parsed to 
JSON.
   
   bug3: After delete the schema by subject, we will send a message with 
_DELETE_KEY_ so that the local cache can be refreshed. But when the registry 
server restart and the local cache replay, maybe we will consume the 
_DELETE_KEY_ massage first and then consume the schema message, thus the 
deleted schema will regenerate in local cache, inconsistent with remote storage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] duhenglucky merged pull request #4756: [ISSUE #4755] Some improvement about branch management

[GitBox]

duhenglucky merged PR #4756:
URL: https://github.com/apache/rocketmq/pull/4756


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] duhenglucky closed issue #4755: Some suggestions about branch management

[GitBox]

duhenglucky closed issue #4755: Some suggestions about branch management
URL: https://github.com/apache/rocketmq/issues/4755


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] aaron-ai commented on pull request #4756: [ISSUE #4755] Some improvement about branch management

[GitBox]

aaron-ai commented on PR #4756:
URL: https://github.com/apache/rocketmq/pull/4756#issuecomment-1202075056

   > LGTM~, Maybe more labels can be attached to RocketMQ, Messaging, 
Streaming, Eventing, CloudNative, etc.
   
   done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-mqtt] DongyuanPan closed issue #108: Add a lightweight, embedded distributed KV database

[GitBox]

DongyuanPan closed issue #108: Add a lightweight, embedded distributed KV 
database
URL: https://github.com/apache/rocketmq-mqtt/issues/108


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-mqtt] DongyuanPan commented on issue #108: Add a lightweight, embedded distributed KV database

[GitBox]

DongyuanPan commented on issue #108:
URL: https://github.com/apache/rocketmq-mqtt/issues/108#issuecomment-1202068307

   it can be closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] lollipopjin merged pull request #4763: Use string as the configuration parameter type of metrics collector mode

[GitBox]

lollipopjin merged PR #4763:
URL: https://github.com/apache/rocketmq/pull/4763


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] lollipopjin closed issue #4762: Use string as the configuration parameter type of metrics collector mode

[GitBox]

lollipopjin closed issue #4762: Use string as the configuration parameter type 
of metrics collector mode
URL: https://github.com/apache/rocketmq/issues/4762


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] aaron-ai commented on pull request #4763: Use string as the configuration parameter type of metrics collector mode

[GitBox]

aaron-ai commented on PR #4763:
URL: https://github.com/apache/rocketmq/pull/4763#issuecomment-1202059971

   @lollipopjin  PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] aaron-ai opened a new pull request, #4763: Use string as the configuration parameter type of metrics collector mode

[GitBox]

aaron-ai opened a new pull request, #4763:
URL: https://github.com/apache/rocketmq/pull/4763

   Fixes #4762 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] aaron-ai opened a new issue, #4762: Use string as the configuration parameter type of metrics collector mode

[GitBox]

aaron-ai opened a new issue, #4762:
URL: https://github.com/apache/rocketmq/issues/4762

   Current parameter type of metrics  is `int` - `0/1/2` ,  which may confuse 
the developer, string type - `on/off/proxy` may make it much clearer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-connect] odbozhou merged pull request #222: [ISSUE #220] Add unit test (config module)

[GitBox]

odbozhou merged PR #222:
URL: https://github.com/apache/rocketmq-connect/pull/222


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-connect] odbozhou merged pull request #221: [ISSUE #220] Add unit test (common module)

[GitBox]

odbozhou merged PR #221:
URL: https://github.com/apache/rocketmq-connect/pull/221


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq-connect] odbozhou commented on pull request #221: [ISSUE #220] Add unit test (common module)

[GitBox]

odbozhou commented on PR #221:
URL: https://github.com/apache/rocketmq-connect/pull/221#issuecomment-1202054625

   > Please review this PR if you have time. I have upgraded `assertj-core` and 
I want to use some new assertj features to write unit tests
   
   Looks great, looking forward to more new features applied to RocketMQ Connect


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org