[GitHub] [rocketmq] Hccake commented on pull request #4903: fix-warmMappedFile：Place a safepoint before the loop, the processing effect takes precedence over sleep
Hccake commented on PR #4903: URL: https://github.com/apache/rocketmq/pull/4903#issuecomment-1229138861 > > 而 fileSize 又是 int 类型，现在把 i 改为 long 类型完全没有意义 > > @Hccake filesize是不是int类型和jvm能不能在循环前放置安全点并没有什么关系，它看的就是循环的这个i是不是long类型的 参考这篇[文章](https://juejin.cn/post/6844903878765314061#comment) 受教，学习了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] RongtongJin opened a new issue, #4906: Add required pull request reviews rule for develop branch
RongtongJin opened a new issue, #4906: URL: https://github.com/apache/rocketmq/issues/4906 The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow the [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal). To avoid unnecessary duplication, please check whether there is a previous issue before filing a new one. It is recommended to start a discussion thread in the [mailing lists](http://rocketmq.apache.org/about/contact/) in cases of discussing your deployment plan, API clarification, and other non-bug-reporting issues. We welcome any friendly suggestions, bug fixes, collaboration, and other improvements. Please ensure that your bug report is clear and self-contained. Otherwise, it would take additional rounds of communication, thus more time, to understand the problem itself. Generally, fixing an issue goes through the following steps: 1. Understand the issue reported; 1. Reproduce the unexpected behavior locally; 1. Perform root cause analysis to identify the underlying problem; 1. Create test cases to cover the identified problem; 1. Work out a solution to rectify the behavior and make the newly created test cases pass; 1. Make a pull request and go through peer review; As a result, it would be very helpful yet challenging if you could provide an isolated project reproducing your reported issue. Anyway, please ensure your issue report is informative enough for the community to pick up. At a minimum, include the following hints: **FEATURE REQUEST** 1. Please describe the feature you are requesting. Add required pull request reviews rule for develop branch. 2. Provide any additional detail on your proposed use case for this feature. 3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? 4. If there are some sub-tasks involved, use -[] for each sub-task and create a corresponding issue to map to the sub-task: - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here, - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 description here, - ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] RongtongJin opened a new pull request, #4907: [ISSUE #4906] Add required pull request reviews rule for develop branch
RongtongJin opened a new pull request, #4907: URL: https://github.com/apache/rocketmq/pull/4907 **Make sure set the target branch to `develop`** ## What is the purpose of the change Add required pull request reviews rule for develop branch ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-flink] GOODBOY008 opened a new issue, #56: []Port RocketMQSink to FLIP-143
GOODBOY008 opened a new issue, #56: URL: https://github.com/apache/rocketmq-flink/issues/56 Port RocketMQSink to FLIP-143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re:Re: [Discuss] RocketMQ-MQTT 1.0.0 LTS release
+1 for voting At 2022-08-27 13:58:30, "heng du" wrote: >+1 for voting > >yukon 于2022年8月27日周六 10:40写道： > >> +1 for releasing this version. >> >> Since this is the first version, please notice that all the source files >> should have an apache license header, it's recommended to add a GitHub >> action to check it, you can refer to here: >> >> https://github.com/apache/rocketmq-clients/blob/master/.github/workflows/license_checker.yaml >> >> And, please note the license compatibility of binary dependencies, For more >> details please refer to: https://www.apache.org/legal/resolved.html >> >> Regards, >> yukon >> >> On Sat, Aug 27, 2022 at 9:51 AM Ping Wang wrote: >> >> > Hello, RocketMQ Community, >> > >> > >> > This is the discussion for the release of RocketMQ-MQTT 1.0.0 >> LTS（long-term >> > support ） version. This is the first version. The subsequent bug fixes >> will >> > be back ported to this version from the trunk in a timely manner, and >> the >> > LTS version has a support period of 18 months. >> > >> > >> > If there are no other sounds, I would like to call for a vote for >> > RocketMQ-MQTT 1.0.0 release :-) >> > >>
Re: Re: [Discuss] RocketMQ-MQTT 1.0.0 LTS release
+1 for voting hill 于2022年8月27日 周六16:20写道： > +1 for voting > > > > > > > At 2022-08-27 13:58:30, "heng du" wrote: > >+1 for voting > > > >yukon 于2022年8月27日周六 10:40写道： > > > >> +1 for releasing this version. > >> > >> Since this is the first version, please notice that all the source files > >> should have an apache license header, it's recommended to add a GitHub > >> action to check it, you can refer to here: > >> > >> > https://github.com/apache/rocketmq-clients/blob/master/.github/workflows/license_checker.yaml > >> > >> And, please note the license compatibility of binary dependencies, For > more > >> details please refer to: https://www.apache.org/legal/resolved.html > >> > >> Regards, > >> yukon > >> > >> On Sat, Aug 27, 2022 at 9:51 AM Ping Wang wrote: > >> > >> > Hello, RocketMQ Community, > >> > > >> > > >> > This is the discussion for the release of RocketMQ-MQTT 1.0.0 > >> LTS（long-term > >> > support ） version. This is the first version. The subsequent bug fixes > >> will > >> > be back ported to this version from the trunk in a timely manner, and > >> the > >> > LTS version has a support period of 18 months. > >> > > >> > > >> > If there are no other sounds, I would like to call for a vote for > >> > RocketMQ-MQTT 1.0.0 release :-) > >> > > >> > -- Best regards, Xiaorui Wang[#] - Apache RocketMQ PMC chair [#] https://github.com/vintagewang
[GitHub] [rocketmq-connect] Oliverwqcwrw opened a new issue, #288: redis source connector adapt to new api
Oliverwqcwrw opened a new issue, #288: URL: https://github.com/apache/rocketmq-connect/issues/288 **FEATURE REQUEST** 1. Please describe the feature you are requesting. redis source connector adapt to new api 3. Provide any additional detail on your proposed use case for this feature. 2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? 4. If there are some sub-tasks involved, use -[] for each sub-task and create a corresponding issue to map to the sub-task: - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here, - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 description here, - ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-connect] Oliverwqcwrw opened a new pull request, #289: [ISSUE #288] redis source connector adapt to new api
Oliverwqcwrw opened a new pull request, #289: URL: https://github.com/apache/rocketmq-connect/pull/289 ## What is the purpose of the change Close #288 ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq-connect/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #190: Generate client's signature in ClientManager
codecov-commenter commented on PR #190: URL: https://github.com/apache/rocketmq-clients/pull/190#issuecomment-1229159138 # [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/190?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#190](https://codecov.io/gh/apache/rocketmq-clients/pull/190?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b80e47a) into [master](https://codecov.io/gh/apache/rocketmq-clients/commit/acb671e055dc715e125fb5f5531e9b4d60be6e4d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (acb671e) will **decrease** coverage by `0.62%`. > The diff coverage is `59.74%`. ```diff @@ Coverage Diff @@ ## master #190 +/- ## - Coverage 34.68% 34.06% -0.63% + Complexity 653 650 -3 Files 196 196 Lines 8660 8649 -11 Branches274 274 - Hits 3004 2946 -58 - Misses 5506 5557 +51 + Partials150 146 -4 ``` | Flag | Coverage Δ | | |---|---|---| | java | `59.44% <59.74%> (-1.35%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/rocketmq-clients/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...pache/rocketmq/client/java/impl/ClientManager.java](https://codecov.io/gh/apache/rocketmq-clients/pull/190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50TWFuYWdlci5qYXZh) | `100.00% <ø> (ø)` | | | [...mq/client/java/impl/consumer/PushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvY29uc3VtZXIvUHVzaENvbnN1bWVySW1wbC5qYXZh) | `33.61% <0.00%> (+0.69%)` | :arrow_up: | | [...cketmq/client/java/impl/producer/ProducerImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvcHJvZHVjZXIvUHJvZHVjZXJJbXBsLmphdmE=) | `32.56% <33.33%> (+0.34%)` | :arrow_up: | | [...g/apache/rocketmq/client/java/impl/ClientImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50SW1wbC5qYXZh) | `33.22% <35.71%> (-6.46%)` | :arrow_down: | | [...cketmq/client/java/impl/consumer/ConsumerImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvY29uc3VtZXIvQ29uc3VtZXJJbXBsLmphdmE=) | `73.72% <83.33%> (-0.26%)` | :arrow_down: | | [...e/rocketmq/client/java/impl/ClientManagerImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50TWFuYWdlckltcGwuamF2YQ==) | `73.26% <85.71%> (-9.28%)` | :arrow_down: | | [...apache/rocketmq/client/java/rpc/RpcClientImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+
[GitHub] [rocketmq-clients] aaron-ai merged pull request #190: Generate client's signature in ClientManager
aaron-ai merged PR #190: URL: https://github.com/apache/rocketmq-clients/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai merged pull request #191: Add more unit test for ClientImpl
aaron-ai merged PR #191: URL: https://github.com/apache/rocketmq-clients/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #4823: [ISSUE #4817] Add a command to clear broker data from controller for CLI
RongtongJin merged PR #4823: URL: https://github.com/apache/rocketmq/pull/4823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] RongtongJin closed issue #4817: Add a command to clear broker data from controller for CLI
RongtongJin closed issue #4817: Add a command to clear broker data from controller for CLI URL: https://github.com/apache/rocketmq/issues/4817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] lizhanhui merged pull request #4907: [ISSUE #4906] Add required pull request reviews rule for develop branch
lizhanhui merged PR #4907: URL: https://github.com/apache/rocketmq/pull/4907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] lizhanhui closed issue #4906: Add required pull request reviews rule for develop branch
lizhanhui closed issue #4906: Add required pull request reviews rule for develop branch URL: https://github.com/apache/rocketmq/issues/4906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #4903: fix-warmMappedFile：Place a safepoint before the loop, the processing effect takes precedence over sleep
lizhanhui commented on PR #4903: URL: https://github.com/apache/rocketmq/pull/4903#issuecomment-1229187159 The existing solution is to write one byte per page as warming. According to https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux_for_real_time/7/html/reference_guide/using_mlock_to_avoid_page_io, it looks sufficient to mlock; Another thing, actual empty write is actually preferred for some reason, it would be better to iterate from file tail to head, as the head of the file region is more likely to be written with data in the near future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4903: fix-warmMappedFile：Place a safepoint before the loop, the processing effect takes precedence over sleep
codecov-commenter commented on PR #4903: URL: https://github.com/apache/rocketmq/pull/4903#issuecomment-1229188508 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4903?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#4903](https://codecov.io/gh/apache/rocketmq/pull/4903?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8325414) into [develop](https://codecov.io/gh/apache/rocketmq/commit/c4117138367234d6cfbddcbac733ef1c34ab0aa3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c411713) will **decrease** coverage by `0.00%`. > The diff coverage is `0.00%`. ```diff @@ Coverage Diff @@ ## develop#4903 +/- ## = - Coverage 43.29% 43.28% -0.01% + Complexity 7688 7684 -4 = Files991 991 Lines 6878468776 -8 Branches9112 9111 -1 = - Hits 2977929771 -8 + Misses 3526335257 -6 - Partials3742 3748 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ache/rocketmq/store/logfile/DefaultMappedFile.java](https://codecov.io/gh/apache/rocketmq/pull/4903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2xvZ2ZpbGUvRGVmYXVsdE1hcHBlZEZpbGUuamF2YQ==) | `49.67% <0.00%> (+1.26%)` | :arrow_up: | | [...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/4903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh) | `60.43% <0.00%> (-2.20%)` | :arrow_down: | | [.../apache/rocketmq/controller/ControllerManager.java](https://codecov.io/gh/apache/rocketmq/pull/4903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9Db250cm9sbGVyTWFuYWdlci5qYXZh) | `72.82% <0.00%> (-2.18%)` | :arrow_down: | | [...mq/store/ha/autoswitch/AutoSwitchHAConnection.java](https://codecov.io/gh/apache/rocketmq/pull/4903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL2F1dG9zd2l0Y2gvQXV0b1N3aXRjaEhBQ29ubmVjdGlvbi5qYXZh) | `73.29% <0.00%> (-1.64%)` | :arrow_down: | | [...client/consumer/store/RemoteBrokerOffsetStore.java](https://codecov.io/gh/apache/rocketmq/pull/4903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvc3RvcmUvUmVtb3RlQnJva2VyT2Zmc2V0U3RvcmUuamF2YQ==) | `68.14% <0.00%> (-0.89%)` | :arrow_down: | | [...apache/rocketmq/store/queue/BatchConsumeQueue.java](https://codecov.io/gh/apache/rocketmq/pull/4903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3F1ZXVlL0JhdGNoQ29uc3VtZVF1ZXVlLmphdmE=) | `69.50% <0.00%> (-0.63%)` | :arrow_down: | | [...rocketmq/broker/processor/PopMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BvcE1lc3NhZ2VQcm9jZXNzb3IuamF2YQ==) | `37.63% <0.00%> (-0.54%)` | :arrow_down: | | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/4903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9
[GitHub] [rocketmq] lizhanhui commented on pull request #4635: [ISSUE #4634] fix code style in namesrv module
lizhanhui commented on PR #4635: URL: https://github.com/apache/rocketmq/pull/4635#issuecomment-1229189047 @PansonPanson Hi, could you push an empty commit to trigger the CI again? The CI infra has evolved and it expects new pass results to merge this pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #4635: [ISSUE #4634] fix code style in namesrv module
lizhanhui commented on PR #4635: URL: https://github.com/apache/rocketmq/pull/4635#issuecomment-1229189051 @PansonPanson Hi, could you push an empty commit to trigger the CI again? The CI infra has evolved and it expects new pass results to merge this pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] mxsm opened a new pull request, #4908: [ISSUE #4904]Optimize store module test cases to reduce execution time
mxsm opened a new pull request, #4908: URL: https://github.com/apache/rocketmq/pull/4908 **Make sure set the target branch to `develop`** ## What is the purpose of the change close #4904 ## Brief changelog -Optimize store module test cases to reduce execution time ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4908: [ISSUE #4904]Optimize store module test cases to reduce execution time
codecov-commenter commented on PR #4908: URL: https://github.com/apache/rocketmq/pull/4908#issuecomment-1229211382 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4908?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#4908](https://codecov.io/gh/apache/rocketmq/pull/4908?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53e6aa0) into [develop](https://codecov.io/gh/apache/rocketmq/commit/2a46dbed19bf3e0613c01118c6277fc9b71a3813?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a46dbe) will **decrease** coverage by `0.16%`. > The diff coverage is `n/a`. > :exclamation: Current head 53e6aa0 differs from pull request most recent head 9fee8fa. Consider uploading reports for the commit 9fee8fa to get more accurate results ```diff @@ Coverage Diff @@ ## develop#4908 +/- ## = - Coverage 43.32% 43.15% -0.17% + Complexity 7707 7676 -31 = Files994 994 Lines 6893868938 Branches9132 9132 = - Hits 2986529751 -114 - Misses 3533035450 +120 + Partials3743 3737 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4908?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `39.22% <0.00%> (-10.50%)` | :arrow_down: | | [...apache/rocketmq/store/queue/ConsumeQueueStore.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3F1ZXVlL0NvbnN1bWVRdWV1ZVN0b3JlLmphdmE=) | `53.41% <0.00%> (-5.56%)` | :arrow_down: | | [...etmq/namesrv/routeinfo/BatchUnRegisterService.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vQmF0Y2hVblJlZ2lzdGVyU2VydmljZS5qYXZh) | `94.73% <0.00%> (-5.27%)` | :arrow_down: | | [...e/rocketmq/store/ha/autoswitch/EpochFileCache.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL2F1dG9zd2l0Y2gvRXBvY2hGaWxlQ2FjaGUuamF2YQ==) | `77.08% <0.00%> (-4.17%)` | :arrow_down: | | [...ache/rocketmq/store/AllocateMappedFileService.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0FsbG9jYXRlTWFwcGVkRmlsZVNlcnZpY2UuamF2YQ==) | `39.28% <0.00%> (-2.39%)` | :arrow_down: | | [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `53.40% <0.00%> (-2.06%)` | :arrow_down: | | [...mq/store/ha/autoswitch/AutoSwitchHAConnection.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL2F1dG9zd2l0Y2gvQXV0b1N3aXRjaEhBQ29ubmVjdGlvbi5qYXZh) | `73.02% <0.00%> (-1.91%)` | :arrow_down: | | [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/4908/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm
[GitHub] [rocketmq] vintagewang commented on pull request #4756: [ISSUE #4755] Some improvement about branch management
vintagewang commented on PR #4756: URL: https://github.com/apache/rocketmq/pull/4756#issuecomment-1229347877 I was wondering if this "required_approving_review_count" would be more appropriate to set up to 2 and wanted to hear from other people. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] shengminw opened a new issue, #4909: Fix CONSUME_FROM_LAST_OFFSET mode may pull data from 0L
shengminw opened a new issue, #4909: URL: https://github.com/apache/rocketmq/issues/4909 ## Problem View When we set **CONSUME_FROM_LAST_OFFSET** to pull data, if it is the first time to start the consumer group, data may be pulled from the 0L. This is not what we expected. I built a demo to reproduce this situation. First sent the data using the producer：  Set consumer mode as **CONSUME_FROM_LAST_OFFSET**.  At the first startup, the consumption situation obtained should theoretically not pull the previous message, but the message is still pulled from the beginning:  ## Location the problem When a consumer group needs to pull messages, it obtains the initial location to be consumed according to the startup mode.  In cluster mode, the offset is read from the broker side. (cluster mode has the above problem) In broadcast mode, the offset of the local record is read, and -1 is returned if it is not read. In broker, in **ConsumerManageProcessor#queryConsumerOffset**, the broker will query the consumeoffset by consumegroup, topic and queueId. ● If the offsetTable records the consumption information of this consumer group under this topic and this queueId, return this recorded consumeoffset ● If there is no record in the offsetTable, the minimum offset in the consumequeue will be obtained. (When the minimum offset is less than or equal to 0 && offset 0 is in memory, it returns to 0) -> This leads that when consumequeue does not clean up expired files, the minimum offset is 0 and it is in memory , 0 will be returned, and the client receives an offset of 0, so it starts to consume from the starting position.  ## Solution When querying consumeoffset, set ZeroIfNotFound false in the requestHeader. So, when the previous record is not obtained, it will no longer return 0.  ## Another Question The above solution can solve this problem, but I still have some doubts about the original implementation method In **ConsumerManageProcessor#queryConsumerOffset**，why we need to set offset as 0L, when minOffset <= 0 and offset 0L is in memory. Can we return response just setCode as ResponseCode.QUERY_NOT_FOUND?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] shengminw opened a new pull request, #4910: [ISSUE#4909]Fix CONSUME_FROM_LAST_OFFSET mode may pull data from 0L
shengminw opened a new pull request, #4910: URL: https://github.com/apache/rocketmq/pull/4910 [#ISSUE4909](https://github.com/apache/rocketmq/issues/4909) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #4908: [ISSUE #4904]Optimize store module test cases to reduce execution time
RongtongJin commented on code in PR #4908:
URL: https://github.com/apache/rocketmq/pull/4908#discussion_r956654342
##
store/src/test/java/org/apache/rocketmq/store/queue/BatchConsumeMessageTest.java:
##
@@ -290,7 +295,8 @@ public void testDispatchBuildBatchConsumeQueue() throws
Exception {
timeStart =
putMessageResult.getAppendMessageResult().getStoreTimestamp();
}
if (i == 30) {
-timeMid =
putMessageResult.getAppendMessageResult().getStoreTimestamp();;
+timeMid =
putMessageResult.getAppendMessageResult().getStoreTimestamp();
+;
Review Comment:
It would be better remove this useless line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #4908: [ISSUE #4904]Optimize store module test cases to reduce execution time
RongtongJin commented on code in PR #4908:
URL: https://github.com/apache/rocketmq/pull/4908#discussion_r956654342
##
store/src/test/java/org/apache/rocketmq/store/queue/BatchConsumeMessageTest.java:
##
@@ -290,7 +295,8 @@ public void testDispatchBuildBatchConsumeQueue() throws
Exception {
timeStart =
putMessageResult.getAppendMessageResult().getStoreTimestamp();
}
if (i == 30) {
-timeMid =
putMessageResult.getAppendMessageResult().getStoreTimestamp();;
+timeMid =
putMessageResult.getAppendMessageResult().getStoreTimestamp();
+;
Review Comment:
It would be better to remove this useless line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq-schema-registry] ferrirW closed issue #40: spotless plugin conflict to rmq_checkstyle
ferrirW closed issue #40: spotless plugin conflict to rmq_checkstyle URL: https://github.com/apache/rocketmq-schema-registry/issues/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] mxsm commented on a diff in pull request #4908: [ISSUE #4904]Optimize store module test cases to reduce execution time
mxsm commented on code in PR #4908:
URL: https://github.com/apache/rocketmq/pull/4908#discussion_r956654913
##
store/src/test/java/org/apache/rocketmq/store/queue/BatchConsumeMessageTest.java:
##
@@ -290,7 +295,8 @@ public void testDispatchBuildBatchConsumeQueue() throws
Exception {
timeStart =
putMessageResult.getAppendMessageResult().getStoreTimestamp();
}
if (i == 30) {
-timeMid =
putMessageResult.getAppendMessageResult().getStoreTimestamp();;
+timeMid =
putMessageResult.getAppendMessageResult().getStoreTimestamp();
+;
Review Comment:
> It would be better to remove this useless line
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4910: [ISSUE#4909]Fix CONSUME_FROM_LAST_OFFSET mode may pull data from 0L
codecov-commenter commented on PR #4910: URL: https://github.com/apache/rocketmq/pull/4910#issuecomment-1229364584 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4910?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#4910](https://codecov.io/gh/apache/rocketmq/pull/4910?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (337cc33) into [develop](https://codecov.io/gh/apache/rocketmq/commit/c4117138367234d6cfbddcbac733ef1c34ab0aa3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c411713) will **decrease** coverage by `0.01%`. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## develop#4910 +/- ## = - Coverage 43.29% 43.27% -0.02% - Complexity 7688 7695 +7 = Files991 994 +3 Lines 6878468939 +155 Branches9112 9132 +20 = + Hits 2977929836 +57 - Misses 3526335355 +92 - Partials3742 3748 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...client/consumer/store/RemoteBrokerOffsetStore.java](https://codecov.io/gh/apache/rocketmq/pull/4910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvc3RvcmUvUmVtb3RlQnJva2VyT2Zmc2V0U3RvcmUuamF2YQ==) | `69.29% <100.00%> (+0.27%)` | :arrow_up: | | [...or/validator/DefaultTopicMessageTypeValidator.java](https://codecov.io/gh/apache/rocketmq/pull/4910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3Byb2Nlc3Nvci92YWxpZGF0b3IvRGVmYXVsdFRvcGljTWVzc2FnZVR5cGVWYWxpZGF0b3IuamF2YQ==) | `40.00% <0.00%> (-10.00%)` | :arrow_down: | | [...e/rocketmq/controller/impl/manager/BrokerInfo.java](https://codecov.io/gh/apache/rocketmq/pull/4910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL21hbmFnZXIvQnJva2VySW5mby5qYXZh) | `78.94% <0.00%> (-9.29%)` | :arrow_down: | | [...ocketmq/controller/impl/manager/SyncStateInfo.java](https://codecov.io/gh/apache/rocketmq/pull/4910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL21hbmFnZXIvU3luY1N0YXRlSW5mby5qYXZh) | `83.33% <0.00%> (-7.58%)` | :arrow_down: | | [...apache/rocketmq/remoting/netty/ResponseFuture.java](https://codecov.io/gh/apache/rocketmq/pull/4910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L1Jlc3BvbnNlRnV0dXJlLmphdmE=) | `77.55% <0.00%> (-4.09%)` | :arrow_down: | | [...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://codecov.io/gh/apache/rocketmq/pull/4910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh) | `50.00% <0.00%> (-3.96%)` | :arrow_down: | | [...ache/rocketmq/controller/impl/event/EventType.java](https://codecov.io/gh/apache/rocketmq/pull/4910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL2V2ZW50L0V2ZW50VHlwZS5qYXZh) | `73.68% <0.00%> (-2.79%)` | :arrow_down: | | [...q/controller/impl/manager/ReplicasInfoManager.java](https://codecov.io/gh/apache/rocketmq/pull/4910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2
[GitHub] [rocketmq] RongtongJin opened a new issue, #4911: Make all admin command descriptions begin with capital letters
RongtongJin opened a new issue, #4911: URL: https://github.com/apache/rocketmq/issues/4911 The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow the [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal). To avoid unnecessary duplication, please check whether there is a previous issue before filing a new one. It is recommended to start a discussion thread in the [mailing lists](http://rocketmq.apache.org/about/contact/) in cases of discussing your deployment plan, API clarification, and other non-bug-reporting issues. We welcome any friendly suggestions, bug fixes, collaboration, and other improvements. Please ensure that your bug report is clear and self-contained. Otherwise, it would take additional rounds of communication, thus more time, to understand the problem itself. Generally, fixing an issue goes through the following steps: 1. Understand the issue reported; 1. Reproduce the unexpected behavior locally; 1. Perform root cause analysis to identify the underlying problem; 1. Create test cases to cover the identified problem; 1. Work out a solution to rectify the behavior and make the newly created test cases pass; 1. Make a pull request and go through peer review; As a result, it would be very helpful yet challenging if you could provide an isolated project reproducing your reported issue. Anyway, please ensure your issue report is informative enough for the community to pick up. At a minimum, include the following hints: **BUG REPORT** 1. Please describe the issue you observed: - What did you do (The steps to reproduce) Make all admin command descriptions begin with capital letters - What is expected to see? All admin command descriptions begin with capital letters - What did you see instead?  2. Please tell us about your environment: 3. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc): **FEATURE REQUEST** 1. Please describe the feature you are requesting. 2. Provide any additional detail on your proposed use case for this feature. 2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? 4. If there are some sub-tasks involved, use -[] for each sub-task and create a corresponding issue to map to the sub-task: - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here, - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 description here, - ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] RongtongJin opened a new pull request, #4912: [ISSUE #4911] Make all admin command descriptions begin with capital letters
RongtongJin opened a new pull request, #4912: URL: https://github.com/apache/rocketmq/pull/4912 **Make sure set the target branch to `develop`** ## What is the purpose of the change Make all admin command descriptions begin with capital letters ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4912: [ISSUE #4911] Make all admin command descriptions begin with capital letters
codecov-commenter commented on PR #4912: URL: https://github.com/apache/rocketmq/pull/4912#issuecomment-1229368563 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4912?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#4912](https://codecov.io/gh/apache/rocketmq/pull/4912?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (89fbbea) into [develop](https://codecov.io/gh/apache/rocketmq/commit/2a46dbed19bf3e0613c01118c6277fc9b71a3813?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a46dbe) will **decrease** coverage by `0.10%`. > The diff coverage is `0.00%`. ```diff @@ Coverage Diff @@ ## develop#4912 +/- ## = - Coverage 43.32% 43.21% -0.11% + Complexity 7707 7689 -18 = Files994 994 Lines 6893868938 Branches9132 9132 = - Hits 2986529791 -74 - Misses 3533035393 +63 - Partials3743 3754 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4912?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...tmq/tools/command/broker/SendMsgStatusCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4912/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYnJva2VyL1NlbmRNc2dTdGF0dXNDb21tYW5kLmphdmE=) | `34.28% <0.00%> (ø)` | | | [...ols/command/consumer/SetConsumeModeSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4912/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvY29uc3VtZXIvU2V0Q29uc3VtZU1vZGVTdWJDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...nd/controller/GetControllerMetaDataSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4912/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvY29udHJvbGxlci9HZXRDb250cm9sbGVyTWV0YURhdGFTdWJDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...tmq/tools/command/export/ExportConfigsCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4912/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvZXhwb3J0L0V4cG9ydENvbmZpZ3NDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...mq/tools/command/export/ExportMetadataCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4912/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvZXhwb3J0L0V4cG9ydE1ldGFkYXRhQ29tbWFuZC5qYXZh) | `0.00% <0.00%> (ø)` | | | [...tmq/tools/command/export/ExportMetricsCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4912/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvZXhwb3J0L0V4cG9ydE1ldHJpY3NDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...q/tools/command/message/CheckMsgSendRTCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4912/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvbWVzc2FnZS9DaGVja01zZ1NlbmRSVENvbW1hbmQuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...s/command/message/QueryMsgTraceByIdSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4912/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvbWVzc2FnZS9RdWVyeU1zZ1RyYWNlQnlJZFN1Y
[GitHub] [rocketmq-schema-registry] ferrirW opened a new pull request, #50: [ISSUE #43] prevent update same schema
ferrirW opened a new pull request, #50: URL: https://github.com/apache/rocketmq-schema-registry/pull/50 close #43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-schema-registry] ferrirW opened a new pull request, #51: Fix avro parse NPE
ferrirW opened a new pull request, #51: URL: https://github.com/apache/rocketmq-schema-registry/pull/51 Fix NPE when avro schema type is not record -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-schema-registry] codecov-commenter commented on pull request #50: [ISSUE #43] prevent update same schema
codecov-commenter commented on PR #50: URL: https://github.com/apache/rocketmq-schema-registry/pull/50#issuecomment-1229369290 # [Codecov](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/50?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#50](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/50?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f986c67) into [main](https://codecov.io/gh/apache/rocketmq-schema-registry/commit/76924cdd6dc14456580a881a7669ff1ecf174077?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (76924cd) will **decrease** coverage by `0.69%`. > The diff coverage is `0.00%`. ```diff @@Coverage Diff @@ ## main #50 +/- ## == - Coverage 9.58% 8.89% -0.70% Complexity 25 25 == Files 37 40 +3 Lines 772 832 +60 Branches40 43 +3 == Hits74 74 - Misses 692 752 +60 Partials 6 6 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/50?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...gistry/core/compatibility/AvroSchemaValidator.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/50/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc2NoZW1hL3JlZ2lzdHJ5L2NvcmUvY29tcGF0aWJpbGl0eS9BdnJvU2NoZW1hVmFsaWRhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...ema/registry/client/serde/avro/AvroSerializer.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/50/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9zY2hlbWEvcmVnaXN0cnkvY2xpZW50L3NlcmRlL2F2cm8vQXZyb1NlcmlhbGl6ZXIuamF2YQ==) | `72.72% <0.00%> (ø)` | | | [...ema/registry/client/serde/json/JsonSerializer.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/50/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9zY2hlbWEvcmVnaXN0cnkvY2xpZW50L3NlcmRlL2pzb24vSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...a/registry/client/serde/json/JsonDeserializer.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/50/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9zY2hlbWEvcmVnaXN0cnkvY2xpZW50L3NlcmRlL2pzb24vSnNvbkRlc2VyaWFsaXplci5qYXZh) | `0.00% <0.00%> (ø)` | | | [...q/schema/registry/client/serde/json/JsonSerde.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/50/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9zY2hlbWEvcmVnaXN0cnkvY2xpZW50L3NlcmRlL2pzb24vSnNvblNlcmRlLmphdmE=) | `0.00% <0.00%> (ø)` | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-schema-registry] codecov-commenter commented on pull request #51: Fix avro parse NPE
codecov-commenter commented on PR #51: URL: https://github.com/apache/rocketmq-schema-registry/pull/51#issuecomment-1229369728 # [Codecov](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/51?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#51](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/51?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc76d3b) into [main](https://codecov.io/gh/apache/rocketmq-schema-registry/commit/76924cdd6dc14456580a881a7669ff1ecf174077?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (76924cd) will **decrease** coverage by `0.65%`. > The diff coverage is `n/a`. ```diff @@Coverage Diff @@ ## main #51 +/- ## == - Coverage 9.58% 8.92% -0.66% Complexity 25 25 == Files 37 40 +3 Lines 772 829 +57 Branches40 42 +2 == Hits74 74 - Misses 692 749 +57 Partials 6 6 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ema/registry/client/serde/avro/AvroSerializer.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/51/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9zY2hlbWEvcmVnaXN0cnkvY2xpZW50L3NlcmRlL2F2cm8vQXZyb1NlcmlhbGl6ZXIuamF2YQ==) | `72.72% <0.00%> (ø)` | | | [...ema/registry/client/serde/json/JsonSerializer.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/51/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9zY2hlbWEvcmVnaXN0cnkvY2xpZW50L3NlcmRlL2pzb24vSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...a/registry/client/serde/json/JsonDeserializer.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/51/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9zY2hlbWEvcmVnaXN0cnkvY2xpZW50L3NlcmRlL2pzb24vSnNvbkRlc2VyaWFsaXplci5qYXZh) | `0.00% <0.00%> (ø)` | | | [...q/schema/registry/client/serde/json/JsonSerde.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/51/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9zY2hlbWEvcmVnaXN0cnkvY2xpZW50L3NlcmRlL2pzb24vSnNvblNlcmRlLmphdmE=) | `0.00% <0.00%> (ø)` | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #192: Refine the log
codecov-commenter commented on PR #192: URL: https://github.com/apache/rocketmq-clients/pull/192#issuecomment-1229382526 # [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/192?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#192](https://codecov.io/gh/apache/rocketmq-clients/pull/192?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1b175f) into [master](https://codecov.io/gh/apache/rocketmq-clients/commit/ca42bb67175f48396fe3af96bc60f2c7fa0de34d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca42bb6) will **increase** coverage by `0.03%`. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## master #192 +/- ## + Coverage 35.04% 35.07% +0.03% - Complexity 657 658 +1 Files 196 196 Lines 8649 8653 +4 Branches274 274 + Hits 3031 3035 +4 Misses 5469 5469 Partials149 149 ``` | Flag | Coverage Δ | | |---|---|---| | java | `61.76% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/rocketmq-clients/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...cketmq/client/java/metrics/ClientMeterManager.java](https://codecov.io/gh/apache/rocketmq-clients/pull/192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL21ldHJpY3MvQ2xpZW50TWV0ZXJNYW5hZ2VyLmphdmE=) | `70.73% <100.00%> (ø)` | | | [...rg/apache/rocketmq/client/java/metrics/Metric.java](https://codecov.io/gh/apache/rocketmq-clients/pull/192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL21ldHJpY3MvTWV0cmljLmphdmE=) | `100.00% <100.00%> (ø)` | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai merged pull request #192: Refine the log
aaron-ai merged PR #192: URL: https://github.com/apache/rocketmq-clients/pull/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #193: Refine the simple consumer example
codecov-commenter commented on PR #193: URL: https://github.com/apache/rocketmq-clients/pull/193#issuecomment-1229385201 # [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#193](https://codecov.io/gh/apache/rocketmq-clients/pull/193?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b89b1c1) into [master](https://codecov.io/gh/apache/rocketmq-clients/commit/ca42bb67175f48396fe3af96bc60f2c7fa0de34d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca42bb6) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #193 +/- ## + Coverage 35.04% 35.07% +0.03% - Complexity 657 658 +1 Files 196 196 Lines 8649 8653 +4 Branches274 274 + Hits 3031 3035 +4 Misses 5469 5469 Partials149 149 ``` | Flag | Coverage Δ | | |---|---|---| | java | `61.76% <ø> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/rocketmq-clients/pull/193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rg/apache/rocketmq/client/java/metrics/Metric.java](https://codecov.io/gh/apache/rocketmq-clients/pull/193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL21ldHJpY3MvTWV0cmljLmphdmE=) | `100.00% <0.00%> (ø)` | | | [...cketmq/client/java/metrics/ClientMeterManager.java](https://codecov.io/gh/apache/rocketmq-clients/pull/193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL21ldHJpY3MvQ2xpZW50TWV0ZXJNYW5hZ2VyLmphdmE=) | `70.73% <0.00%> (ø)` | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai merged pull request #193: Refine the simple consumer example
aaron-ai merged PR #193: URL: https://github.com/apache/rocketmq-clients/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #194: Polish code
codecov-commenter commented on PR #194: URL: https://github.com/apache/rocketmq-clients/pull/194#issuecomment-1229390845 # [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#194](https://codecov.io/gh/apache/rocketmq-clients/pull/194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b8f775) into [master](https://codecov.io/gh/apache/rocketmq-clients/commit/934949c4186a5fde2eb27a9125ca8e4fe3cd38ca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (934949c) will **decrease** coverage by `0.19%`. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## master #194 +/- ## - Coverage 35.27% 35.07% -0.20% + Complexity 661 658 -3 Files 196 196 Lines 8653 8653 Branches274 274 - Hits 3052 3035 -17 - Misses 5449 5469 +20 + Partials152 149 -3 ``` | Flag | Coverage Δ | | |---|---|---| | java | `61.76% <100.00%> (-0.45%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/rocketmq-clients/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...pache/rocketmq/client/java/impl/ClientManager.java](https://codecov.io/gh/apache/rocketmq-clients/pull/194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50TWFuYWdlci5qYXZh) | `100.00% <ø> (ø)` | | | [...cketmq/client/java/impl/consumer/ConsumerImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvY29uc3VtZXIvQ29uc3VtZXJJbXBsLmphdmE=) | `73.72% <100.00%> (ø)` | | | [...g/apache/rocketmq/client/java/impl/ClientImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50SW1wbC5qYXZh) | `48.38% <0.00%> (-5.49%)` | :arrow_down: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
