Re: [VOTE] RocketMQ-Client-Go 2.1.2 Release

2023-08-07 Thread cserwen
+1

> 在 2023年8月8日,13:28,tiger lee  写道:
> 
> Hello RocketMQ Community,
> 
> This is the vote for the RocketMQ-Client-Go 2.1.2 Release.
> Github repo: https://github.com/apache/rocketmq-client-go/tree/v2.1.2.rc2
> 
> The current version updates mainly:
> 1. Add filter hooks in consumer
> 2. Add consumer and producer client add unit support (WithUnitName)
> 3. Add api GetOffsetDiffMap
> 4. Add param which like consumeThreadMin of java sdk to control consumption
> rate
> 5. Add user defined topic dimension consumer limiter
> 6. Fix goroutine leak
> 7. Fix query not found
> 8. Fix consumer doesn't consume message because of blocked on Lock
> 9. Fix the groupName takes the namespace prefix
> 10. Fix pq.mutex lock blocked
> 
> more updates to see :
> https://github.com/apache/rocketmq-client-go/releases/tag/v2.1.2.rc2
> 
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
> Please vote accordingly:
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache RocketMQ Team



Re: [VOTE][RIP-66]Support KV(Rocksdb) Storage

2023-07-20 Thread cserwen
+1

> 2023年7月20日 10:24,闽  写道:
> 
> Hi, RocketMQ Community, 
> 
> 
> As discussed in the previous email, we launched a new RIP 66 to support 
> KV(Rocksdb) storage. Now the 
> shepherds @gongyi-zmp and @hill007299 are willing to 
> support the RIP, so I think it is time to start an email thread to enter the 
> voting process.
> 
> 
> The vote will be open for at least 72 hours or until a necessary number of 
> votes are reached. 
> 
> 
> Please vote accordingly: 
> [ ] +1 approve 
> [ ] +0 no opinion 
> [ ] -1 disapprove with the reason 
> 
> 
> Best Regards! 
> Fujian Zhao 
> 
> 
> English 
> proposal: https://docs.google.com/document/d/e/2PACX-1vT3QJ8XDbKi8HQKaIDodOD4vIV0-xlERFtg8Ed3FsYUi7IfRs5JVKjElGaxpk-0ErH0xdWT0Vv-a1u5/pub ;
> 
> 
> 
> left
> 2573259...@qq.com
> 
> 
> 
>  



Re: [VOTE] RocketMQ-Client-Go 2.1.2 Release

2023-04-25 Thread cserwen
-1
IMO, some important pr should be merged firstly, for example:

https://github.com/apache/rocketmq-client-go/pull/1035
https://github.com/apache/rocketmq-client-go/pull/1014
https://github.com/apache/rocketmq-client-go/pull/1001
https://github.com/apache/rocketmq-client-go/pull/1025
https://github.com/apache/rocketmq-client-go/pull/1040

> 在 2023年4月26日,11:04,Abhijeet Mishra  写道:
> +1
> 
> On Wed, Apr 26, 2023, 6:23 AM fuyou  wrote:
> 
>> +1
>> 
>> tiger lee  于2023年4月25日周二 21:10写道:
>> 
>>> Hello RocketMQ Community,
>>> This is the vote for the RocketMQ-Client-Go 2.1.2 Release.
>>> Github repo:
>> https://github.com/apache/rocketmq-client-go/tree/v2.1.2.rc1
>>> The current version updates mainly:
>>> 1. Add filter hooks in consumer
>>> 2. Add consumer and producer client add unit support (WithUnitName)
>>> 3. Add api GetOffsetDiffMap
>>> 4. Add param which like consumeThreadMin of java sdk to control
>> consumption
>>> rate
>>> 5. Add user defined topic dimension consumer limiter
>>> 6. Fix goroutine leak
>>> 7. Fix query not found
>>> 8. Fix consumer doesn't consume message because of blocked on Lock
>>> 9. Fix the groupName takes the namespace prefix
>>> 10. Fix pq.mutex lock blocked
>>> more updates to see :
>>> https://github.com/apache/rocketmq-client-go/releases/tag/v2.1.2.rc1
>>> The vote will be open for at least 72 hours or until a necessary number
>> of
>>> votes are reached.
>>> Please vote accordingly:
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>> Thanks,
>>> The Apache RocketMQ Team
>> 
>> 
>> --
>>   =
>> 
>>  fuyou001
>> Best Regards


Re: [Discuss] Allow all users who have committed to RocketMQ to run CI without explicit approval

2023-04-12 Thread cserwen
+1

> 在 2023年4月12日,14:50,aaron ai  写道:
> 
> Recently, Apache Infra changed the trigger policy for GitHub actions from
> "requires approval for first-time contributors" to "requires approval for
> all outside collaborators". The motivation behind this change was to
> prevent the abuse of GitHub actions. However, I believe that this is a
> significant step backwards. RocketMQ has external contributors whose pull
> requests are now blocked until a maintainer manually approves the
> corresponding workflow, which creates a burden for both contributors and
> maintainers.
> 
> I have created a Jira ticket
>  to track this issue and
> request a return to the previous behavior of "requires approval for
> first-time contributors". We are willing to take responsibility for
> monitoring these workflows to prevent abuse. If you agree with my viewpoint
> and would like to see a return to the previous policy, please use "+1" to
> express your support. If you disagree, please provide your reasons. We want
> to hear from as many developers in the community as possible!
> 
> Related link:
> * https://infra.apache.org/github-actions-policy.html
> *
> https://github.blog/2021-04-22-github-actions-update-helping-maintainers-combat-bad-actors/
> 
> Thanks for your time,
> Aaron



Re: [DISCUSS][RIP-60] Support Will Message In RocketMQ-MQTT

2023-01-05 Thread cserwen
+1

> 2023年1月5日 15:21,Dongyuan Pan  写道:
> 
> Hi RocketMQ Community,
> 
> Rocketmq-mqtt was developed to support the mqtt protocol to extend the
> use of rocketmq in the field of IoT messaging. The project has
> released version 1.0.0, which supports the common features of the mqtt
> 3.1.1 protocol.
> 
> However, there are still some features that are not yet supported,
> such as will messages.
> 
> The will message can provide a way to notify the corresponding topic
> when the connection is disconnected abnormally, which is very
> practical in the IoT scenario.
> 
> The links to our (GitHub id: DongyuanPan, pingww, scutcr7,WD)
> proposal are given below (both Google Docs and Shimo Docs versions
> were provided to prevent someone cannot access the specific app):
> 
> 1.https://docs.google.com/document/d/1MqIC2iDPFrIu0cgtwfFdtx1GSSnquSEWJMepQf5EL6Q/edit?usp=sharing
> 
> 2.https://shimo.im/docs/WlArzMPne2FNoaA2/ 「[RIP-60] Support Will
> Message In RocketMQ-MQTT」



Re: [VOTE] [RIP-57] Tiered storage for RocketMQ

2022-12-14 Thread cserwen
+1

> 在 2022年12月15日,10:53,SSpirits  写道:
> 
> Hello RocketMQ Community,
> 
> As discussed in the previous email, we discussed introducing tiered storage 
> for RocketMQ, and it's time to start an email thread to enter the voting 
> process.
> 
> Links:
> https://github.com/apache/rocketmq/wiki/RIP-57-Tiered-storage-for-RocketMQ
> 
> The vote will be open for at least 72 hours or until the necessary
> number of votes are reached.
> 
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks
> 
> Your response would be highly appreciated.
> SSpirits
> Email:ad...@lv5.moe


Re: ​[VOTE]Release Apache RocketMQ Client Go Native 2.1.1.

2022-07-28 Thread cserwen
+1

> 2022年7月29日 09:51,yukon  写道:
> 
> +1, thanks.
> 
> On Thu, Jul 28, 2022 at 3:48 PM ShannonDing  wrote:
> 
>> +1, as RM of this 2.1.1 version, I has checked all issues in list.
>> 
>> At 2022-07-25 21:15:21, "ShannonDing"  wrote:
>>> Hello RocketMQ Community,
>>> 
>>> 
>>> 
>>> This is the vote for version 2.1.1 of Apache RocketMQ Client Go Native.
>>> 
>>> The main goal of this release is to improve stability, usability, and fix
>> bugs and  implement some new features mainly including request-reply mode,
>> consuming messages from slave node and supporting IPv6 and so on.
>>> 
>>> 
>>> 
>>> The artifacts:
>>> 
>>> 
>> https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-client-go/2.1.1-rc3/
>>> 
>>> Git tag for the release:
>>> 
>>> https://github.com/apache/rocketmq-client-go/releases/tag/v2.1.1
>>> 
>>> Hash for the release tag:
>>> 
>>> 129701aef56b3bf215b230ed9285ccb17dc18fe9
>>> 
>>> Release Notes:
>>> 
>>> 
>> http://rocketmq.apache.org/release_notes/release-notes-rocketmq-client-go-2.1.1/
>>> 
>>> The artifacts have been signed with Key :
>>> 
>>> BC9E172DE1BA5B24EBB4A628177B55985D75751B, which can be found in the keys
>>> 
>>> file:
>>> 
>>> https://dist.apache.org/repos/dist/dev/rocketmq/KEYS
>>> 
>>> 
>>> 
>>> 
>>> Checklist for reference,
>>> 
>>> Note that this is not official policy but may help with checking releases.
>>> 
>>> Fill in the following:
>>> 
>>> [ ]  Checksums and PGP signatures are valid for Source package.
>>> 
>>> [ ]  Source code artifacts have correct names matching the current
>> release.
>>> 
>>> [ ]  License and Notice are correct in source package.
>>> 
>>> [ ]  All files have license headers in source package if necessary.
>>> 
>>> [ ]  No compiled archives bundled in source archive.
>>> 
>>> [ ]  Hash and Tag in GitHub repo is matching the current artifacts.
>>> 
>>> As we don’t release binary package for Apache RocketMQ Go SDK, the binary
>> package checklist should not be followed.
>>> 
>>> And any other check point is welcomed and please feel free to reply to
>> this email, we sincerely hope to your feedback.
>>> 
>>> 
>>> 
>>> 
>>> The vote will be open for at least 72 hours or until necessary number of
>>> 
>>> votes are reached.
>>> 
>>> Please vote accordingly:
>>> 
>>> 
>>> 
>>> 
>>> [ ] +1 approve
>>> 
>>> [ ] +0 no opinion
>>> 
>>> [ ] -1 disapprove with the reason
>>> 
>>> 
>>> 
>>> 
>>> Thanks,
>>> 
>>> The Apache RocketMQ Team
>> 



Re: [DISCUSS]Release Apache rocketmq-client-go 2.1.1

2022-07-21 Thread cserwen
I have two PRs here, welcome to review.

1. https://github.com/apache/rocketmq-client-go/pull/844 

2. https://github.com/apache/rocketmq-client-go/pull/849 



> 2022年7月20日 09:51,ShannonDing  写道:
> 
> 
> 
> 
> Hello RocketMQ Community,
> 
> 
> 
> 
> It has been a long time since the last release. During this period, the 
> project has imported many new features, solved many issues, and made many 
> optimizations.
> 
> So,
> 
> Apache RocketMQ team is about to release Apache rocketmq-client-go 2.1.1 and  
> we will stop merge PR soon.
> 
> If your PR has not been merged and needs further attention, please reply to 
> this email and we will review it as soon as possible.
> 
> 
> 
> 
> Best Regards,
> 
> Apache RocketMQ Team.



Re: [VOTE] The code of 5.0.0-beta merge into develop branch

2022-07-11 Thread cserwen
+1

> 在 2022年7月12日,10:19,jinrongtong  写道:
> 
> Hi, RocketMQ Community, 
> 
> As discussed in the previous email, we want to merge the code of the 5.0-beta 
> into develop branch. We also create a new branch 4.9.x to fix bugs in the 
> 4.9.4 LTS version.
> So I start this email thread to enter the voting process for the previous 
> discussion.
> 
> 
> Note: after the 5.0.0-beta code is merged into develop branch, some large 
> pull requests that have not been merged may have code conflicts, which need 
> to be resolved by yourself. 
> 
> 
> The vote will be open for at least 72 hours or until a necessary number of 
> votes are reached.
> 
> 
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> 
> Best Regards!
> Rongtong Jin