[GitHub] [rocketmq] ShadowySpirits commented on issue #5184: Read Commitlogs concurrently to speed up generation of the consumeQueue

[GitBox]

ShadowySpirits commented on issue #5184:
URL: https://github.com/apache/rocketmq/issues/5184#issuecomment-1279906207

   > The core of this optimization is to process dispatchRequest concurrently
   
   Maybe a better way is to make the dispatch method asynchronous.
   
   ```java
   public interface CommitLogDispatcher {
   CompletableFuture dispatch(final DispatchRequest 
request);
   }
   ```
   
   So we don't need complex data structure to cache messages, we just need to 
handle futures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [rocketmq] ShadowySpirits commented on issue #5184: Read Commitlogs concurrently to speed up generation of the consumeQueue

[GitBox]

ShadowySpirits commented on issue #5184:
URL: https://github.com/apache/rocketmq/issues/5184#issuecomment-1279880378

   Hi @nowinkeyy,
   
   I read your proposal and have some questions.
   
   1. Under normal circumstances, the messages of same queue are ordered in the 
commitLog. So your improvement is just to execute the dispatcher 
asynchronously? It seems that the batch write you describe will not work in 
most cases.
   2. I don't see anything about recovering from fault in your proposal. eg. 
Where to start rebuilding cq after broker is down and restart.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org