Re: [VOTE] Release rc-2 as Roller 5.2.0

[Dave]

Thanks for taking a look Greg! I really appreciate it.

I'll try to address those issues this weekend at the latest, and any other
issues you uncover.

I did look at moving to Log4j2 but it looked like too large of an effort
(but mainly because of the way Roller expects Log4j properties to be in the
Roller config file).

Dave


On Wed, Aug 30, 2017 at 4:12 AM Greg Huber  wrote:

> Did a quick test from the war (will set up a dev environment so can do some
> more testing!),  here is what i found:
>
> Hard coded stuff :
>
> roller.properties
>
>
> log4j.appender.roller.File=/Applications/Java/apache-tomcat-8.5.9/logs/roller.log
>
> (maybe switch to log4j2?
> ${sys:catalina.home}/logs)
>
> ##
>
> Media upload gives this error (but works):
>
> SEVERE: Servlet.service() for servlet [jsp] threw exception
> org.apache.jasper.JasperException:
> /WEB-INF/jsps/editor/MediaFileAddSuccess.jsp (line: [83], column: [12])
> Attribute [id] invalid for tag [iterator] according to TLD
>
> 
>
> id="newFile" two of these!
>
> ###
>
> Menu preferences/maintenance
>
> Flush cache and Reset Hitcount
>
> >> Method flushCache for action maintenance is not allowed!
>
> Possibly strict-method-invocation="true" is on, so could try to add
> allowed-methods to your struts.xml for the class
>
>  Class="org.apache.roller.weblogger.ui.struts2.editor.Maintenance">
> .Maintenance
> flushCache,reset
>  
>
> (btw your previous dmi would have worked, so there was no need to change
> it!)
>
> ##
>
> Cheers Greg
>
> On 29 August 2017 at 02:10, Dave  wrote:
>
> > I've prepared a second release candidate for Roller 5.2.0. The first RC
> > depended on Struts 2.3 and this new RC-2 release depends on Struts
> 2.5.10.1
> > and no longer uses Dynamic Method Invocation (DMI). Because of this
> change,
> > a significant number of JSP pages were changed.
> >
> > I've been testing this RC-2 release locally and on rollerweblogger.org
> > for the past week and so far it seems stable.
> >
> > Apart from the Struts upgrade, Roller 5.2.0 is primarily a bug fix
> release,
> > with lots of fixes from Kohei.
> >
> > You can find the release candidate here:
> > https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-2
> >
> > And the list of issues resolved is here:
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12310906=12340980
> >
> > Please take a look at the release and vote within the next 72 hours.
> >
> > My vote is +1 to release.
> >
> > Thanks,
> > Dave
> >
>

Re: [VOTE] Release rc-2 as Roller 5.2.0

[Greg Huber]

Did a quick test from the war (will set up a dev environment so can do some
more testing!),  here is what i found:

Hard coded stuff :

roller.properties

log4j.appender.roller.File=/Applications/Java/apache-tomcat-8.5.9/logs/roller.log

(maybe switch to log4j2?
${sys:catalina.home}/logs)

##

Media upload gives this error (but works):

SEVERE: Servlet.service() for servlet [jsp] threw exception
org.apache.jasper.JasperException:
/WEB-INF/jsps/editor/MediaFileAddSuccess.jsp (line: [83], column: [12])
Attribute [id] invalid for tag [iterator] according to TLD



id="newFile" two of these!

###

Menu preferences/maintenance

Flush cache and Reset Hitcount

>> Method flushCache for action maintenance is not allowed!

Possibly strict-method-invocation="true" is on, so could try to add
allowed-methods to your struts.xml for the class


.Maintenance
flushCache,reset
 

(btw your previous dmi would have worked, so there was no need to change
it!)

##

Cheers Greg

On 29 August 2017 at 02:10, Dave  wrote:

> I've prepared a second release candidate for Roller 5.2.0. The first RC
> depended on Struts 2.3 and this new RC-2 release depends on Struts 2.5.10.1
> and no longer uses Dynamic Method Invocation (DMI). Because of this change,
> a significant number of JSP pages were changed.
>
> I've been testing this RC-2 release locally and on rollerweblogger.org
> for the past week and so far it seems stable.
>
> Apart from the Struts upgrade, Roller 5.2.0 is primarily a bug fix release,
> with lots of fixes from Kohei.
>
> You can find the release candidate here:
> https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-2
>
> And the list of issues resolved is here:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12310906=12340980
>
> Please take a look at the release and vote within the next 72 hours.
>
> My vote is +1 to release.
>
> Thanks,
> Dave
>