[GitHub] [roller] snoopdave commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
snoopdave commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150 URL: https://github.com/apache/roller/pull/37#issuecomment-527244134 Yes, I think it would be good to get those changes into 5.2.x as well and I'd be willing to help out with another 5.2.x release when we're ready. It's up to you if you want to add webjars to 5.2.x or do it the old way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [roller] adityasharma7 commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
adityasharma7 commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150 URL: https://github.com/apache/roller/pull/37#issuecomment-527137717 Thanks @snoopdave for the heads up :) I traced back, Js libraries import using webjars dependencies is available in master[1] & roller 6[2] but not in 5.2.x. [3] [4] Actually I thought to make the change as per the current code of the roller-5.2.x branch. Though it will be a good idea to get those changes to 5.2.x. Wdyt? 1. https://github.com/apache/roller/blob/master/app/pom.xml 2. https://github.com/apache/roller/blob/roller-6.0.x/app/pom.xml 3. https://markmail.org/message/zslwmmy5is23psc4 4. https://github.com/apache/roller/blob/roller-5.2.x/app/pom.xml This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [roller] snoopdave edited a comment on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
snoopdave edited a comment on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150 URL: https://github.com/apache/roller/pull/37#issuecomment-527117017 This a a good idea to update jQuery and the right way to do it is by changing the Webjars dependency the Roller app's `pom.xml` file. This is what is in the POM now: ``` org.webjars jquery 3.3.1 org.webjars jquery-ui 1.12.1 ``` The webjars dependecies are imported into the web pages via head.jsp. We should remove the jQuery files from Roller's repo by removing these direrectories `app/src/main/webapp/roller-ui/js/jquery*` and we should remove the references to that directory in all of the JSP files that you changed. All of those files should instead get the jQuery dependency from head.jsp which is included in all JSP files (via Struts / Tiles). (I should have removed those references back when I added the jQuery webjar dependency.) This will make it easier to upgrade jQuery in the future because we will only need to change `pom.xml` and `head.jsp`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [roller] snoopdave commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
snoopdave commented on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150 URL: https://github.com/apache/roller/pull/37#issuecomment-527117017 This a a good idea to update jQuery and the right way to do it is by changing the Webjars dependency the Roller app's pom.xml file. This is what is in there now: ` org.webjars jquery 3.3.1 org.webjars jquery-ui 1.12.1 ` The webjars dependecies are imported into the web pages via head.jsp. We should remove the jQuery files from Roller's repo by removing these direrectories `app/src/main/webapp/roller-ui/js/jquery*` and we should remove the references to that directory in all of the JSP files that you changed. All of those files should instead get the jQuery dependency from head.jsp which is included in all JSP files (via Struts / Tiles). This will make it easier to upgrade jQuery in the future because we will only need to change `pom.xml` and `head.jsp`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [roller] snoopdave edited a comment on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
snoopdave edited a comment on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150 URL: https://github.com/apache/roller/pull/37#issuecomment-527117017 This a a good idea to update jQuery and the right way to do it is by changing the Webjars dependency the Roller app's `pom.xml` file. This is what is in the POM now: ``` org.webjars jquery 3.3.1 org.webjars jquery-ui 1.12.1 ``` The webjars dependecies are imported into the web pages via head.jsp. We should remove the jQuery files from Roller's repo by removing these direrectories `app/src/main/webapp/roller-ui/js/jquery*` and we should remove the references to that directory in all of the JSP files that you changed. All of those files should instead get the jQuery dependency from head.jsp which is included in all JSP files (via Struts / Tiles). This will make it easier to upgrade jQuery in the future because we will only need to change `pom.xml` and `head.jsp`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [roller] snoopdave edited a comment on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
snoopdave edited a comment on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150 URL: https://github.com/apache/roller/pull/37#issuecomment-527117017 This a a good idea to update jQuery and the right way to do it is by changing the Webjars dependency the Roller app's pom.xml file. This is what is in there now: ``` org.webjars jquery 3.3.1 org.webjars jquery-ui 1.12.1 ``` The webjars dependecies are imported into the web pages via head.jsp. We should remove the jQuery files from Roller's repo by removing these direrectories `app/src/main/webapp/roller-ui/js/jquery*` and we should remove the references to that directory in all of the JSP files that you changed. All of those files should instead get the jQuery dependency from head.jsp which is included in all JSP files (via Struts / Tiles). This will make it easier to upgrade jQuery in the future because we will only need to change `pom.xml` and `head.jsp`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [roller] snoopdave edited a comment on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150
snoopdave edited a comment on issue #37: WIP: Upgrade jQuery to 3.4.1 ROL-2150 URL: https://github.com/apache/roller/pull/37#issuecomment-527117017 This a a good idea to update jQuery and the right way to do it is by changing the Webjars dependency the Roller app's pom.xml file. This is what is in there now: ``` org.webjars jquery 3.3.1 org.webjars jquery-ui 1.12.1 ``` The webjars dependecies are imported into the web pages via head.jsp. We should remove the jQuery files from Roller's repo by removing these direrectories `app/src/main/webapp/roller-ui/js/jquery*` and we should remove the references to that directory in all of the JSP files that you changed. All of those files should instead get the jQuery dependency from head.jsp which is included in all JSP files (via Struts / Tiles). This will make it easier to upgrade jQuery in the future because we will only need to change `pom.xml` and `head.jsp`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Build Roller with persisting changes
Thanks so much, Dave for sharing insights. Please see my comments inline. On Sun, Sep 1, 2019 at 5:32 PM Dave wrote: > > The problem is that the Maven-Jetty setup uses an in memory database, you > can see it in the jetty.xml file: > jdbc:derby://localhost:4224/memory:rollerdb;create=true > > Docs for Derby's in-memory are here: > https://db.apache.org/derby/docs/10.9/devguide/cdevdvlpinmemdb.html > > There are a variety of ways to fix this, one way is to write some code that > launches and embedded Derby, then add a Jetty "plugin" to launch it when > Jetty starts.That's what we used to do back in 2010 we had a DerbyLifeCycle > class that do exactly that. I'm not sure why we decided to switch to an > in-memory database. > > If we did that, we could also use the same code to launch Derby in Roller's > JUnit tests. That would be better than what we do now becuase we would be > able to run and debug tests from with an IDE and not just in Maven. Big +1 for this approach, we should include in our roadmap. Not necessarily we do it immediately but we should keep it in our future plans, since it is very critical in terms of attracting new adoptors (Devs) to Roller. > > When I do development I usually run Roller in Tomcat with a local Postgres > or MySQL database and I have Tomcat configured to point to Roller in > ./app/target/roller. I use IntelliJ's debugger and "attach" to that process > when I need to step through something. > > Hope that helps. Thanks so much for the instructions, I will have a look into this. I am sure this will be helpful. > > Dave > > > > > > > > > > > On Thu, Aug 29, 2019 at 9:41 AM Swapnil M Mane > wrote: > > > Hello team, > > > > I followed the steps mentioned in this document to build the Roller > > https://cwiki.apache.org/confluence/display/ROLLER/How+to+build+Roller > > > > Thanks for the document, everything worked as expected. > > > > Can somebody please suggest me what is the best practice to build and > > verify the changes. > > > > So, I have done something like this, > > > > 1. Start the server from command mvn jetty:run > > 2. Created admin user and some content > > 2. Edit the 'roller/app/src/main/webapp/themes/basic/_day.vm' file > > 3. To see the changes, restart the sever run mvn jetty:run > > > > These steps deleted my content which I have created earlier like user, > > blog, etc. > > Due to this, to verify my change, I have to create the above content again. > > > > As mentioned in the above document, > > mvn jetty:run starts with empty Roller database > > > > Note the blog information stored during each mvn jetty:run session > > will be lost once you stop Jetty (i.e., each mvn jetty:run starts with > > empty Roller database tables), > > > > Is there any way to persist my changes and what are the process > > generally followed by developers. > > > > > > Thanks & regards, > > Swapnil M Mane, > > www.apache.org > >
