[GitHub] [roller] mbien commented on pull request #111: bugfix: SearchServlet forgot to copy the user to WeblogPageRequest.

[GitBox]

mbien commented on pull request #111:
URL: https://github.com/apache/roller/pull/111#issuecomment-198303


   @gregh3269 this should fix the issue you mentioned on the dev list.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [roller] mbien commented on pull request #110: updated container setup.

[GitBox]

mbien commented on pull request #110:
URL: https://github.com/apache/roller/pull/110#issuecomment-148169


   @snoopdave could we get a roller-6.1.0 tag for the recent release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [ANNOUNCEMENT] Apache Roller 6.1.0 release is available

[Michael Bien]

excellent! Great job with the release Dave.

a few notes for users:

- Apache Roller supports JDK 17 now (11 is still supported)

- one db table got renamed, for automatic migration set 
installation.type=auto in your roller-custom.properties before first start


- logger config can't be put into roller-custom.properties anymore, its 
now in log4j2.xml
-- default config is here: 
https://github.com/apache/roller/blob/master/app/src/main/resources/log4j2.xml

-- instructions how to change it are in the comments
-- current used log4j2 version is 2.17

- if you are using the db for user authentication
-- default algorithm is now passwds.encryption.algorithm=bcrypt
-- configurable via roller-custom.properties (see roller.properties for 
defaults)

-- automatic migration happens on next pw change (please change it)

- some hardening and bug fixing happened in this release
-- including migration away from EOL libraries

- new editor plugin ("Pre Tag Encoder" checkbox) automatically encodes 
everything between pre tags if enabled

-- no need to escape angle brackets anymore if you post source code

thats all i remember for now :)

best regards,
michael

On 22.12.21 23:32, Dave wrote:

The Apache Roller project is pleased to announce the availability of Roller
6.1.0, a release that upgrades over a dozen dependencies (including Log4J)
and includes a number of bug fixes and improvements to the code-base. The
release and convenience binaries can be found on the Roller project
download page here:

https://roller.apache.org/downloads/downloads.html

You can find some more details about the release in the vote thread here:

https://lists.apache.org/thread/7334kfm8g5mlq1g0y8783ldfopdfc3sc

Thanks to all who helped out with this release!

[ANNOUNCEMENT] Apache Roller 6.1.0 release is available

[Dave]

The Apache Roller project is pleased to announce the availability of Roller
6.1.0, a release that upgrades over a dozen dependencies (including Log4J)
and includes a number of bug fixes and improvements to the code-base. The
release and convenience binaries can be found on the Roller project
download page here:

https://roller.apache.org/downloads/downloads.html

You can find some more details about the release in the vote thread here:

https://lists.apache.org/thread/7334kfm8g5mlq1g0y8783ldfopdfc3sc

Thanks to all who helped out with this release!

[VOTE] [RESULTS] Release RC #2 as Apache Roller 6.1.0

[Dave]

Greg H +1 b
Kohei N +1 b
Michael B +1 b
Dave +1 b

That is four binding votes so Roller 6.1 will be released.

Thanks for everybody's quick action!

Dave


On Wed, Dec 22, 2021 at 3:01 AM Greg Huber  wrote:

> Still a +1
>
> ...for some reason it does not shutdown the thread correctly, maybe its
> logging something when shutdown is called?
>
> On 21/12/2021 22:34, Dave wrote:
> > Greg, did you mean to change your vote to -1 or are you still good with
> the
> > release?
> >
> > Dave
> >
> > On Mon, Dec 20, 2021 at 1:05 AM Greg Huber  wrote:
> >
> >> It was a tomcat start and stop, no deploy/redeploy.  Seems to do it all
> >> the time.
> >>
> >> On 19/12/2021 10:46, Michael Bien wrote:
> >>> this looks like you redeployed or undeployed roller?
> >>>
> >>> App/web servers don't like it when unmanaged threads are started,
> >>> AsyncAppender uses its own thread and the server noticed this i
> suppose.
> >>>
> >>> see config:
> >>>
> >>
> https://github.com/apache/roller/blob/master/app/src/main/resources/log4j2.xml#L62-L65
> >>> If you remove this part and replace "asyncRoller" with "roller" you
> >>> shouldn't see the warning anymore.
> >>>
> >>> The eclipse persistence error is probably caused by the undeployment
> too.
> >>>
> >>> This is most likely harmless, unless you want to constantly redeploy
> >>> roller. Most web/app servers these days are used like a runtime in a
> >>> 1:1 manner and are started/stopped with the application (in a
> container).
> >>>
> >>> -michael
> >>>
> >>>
> >>> On 19.12.21 10:28, Greg Huber wrote:
>  Although I now see this in the logs (17 was a maintenance
> release?)
> 
> 
>  WARNING: An illegal reflective access operation has occurred
>  WARNING: Illegal reflective access by
>  org.apache.catalina.loader.WebappClassLoaderBase
>  (file:/../apache-tomcat-9.0.56/lib/catalina.jar) to field
>  java.io.ObjectStreamClass$Caches.localDescs
>  WARNING: Please consider reporting this to the maintainers of
>  org.apache.catalina.loader.WebappClassLoaderBase
>  WARNING: Use --illegal-access=warn to enable warnings of further
>  illegal reflective access operations
>  WARNING: All illegal access operations will be denied in a future
>  release
>  WARN  2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web
>  application [roller] appears to have started a thread named
>  [Log4j2-AsyncAppenderEventDispatcher-1-asyncRoller] but has failed to
>  stop it. This is very likely to create a memory leak. Stack trace of
>  thread:
>    java.base@11.0.12/jdk.internal.misc.Unsafe.park(Native Method)
>    java.base@11.0.12
> /java.util.concurrent.locks.LockSupport.park(LockSupport.java:194)
>    java.base@11.0.12
> /java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2081)
>    java.base@11.0.12
> /java.util.concurrent.ArrayBlockingQueue.take(ArrayBlockingQueue.java:417)
> 
> >>
>  
> org.apache.logging.log4j.core.appender.AsyncAppenderEventDispatcher.dispatchAll(AsyncAppenderEventDispatcher.java:71)
> >>
> 
> >>
>  
> org.apache.logging.log4j.core.appender.AsyncAppenderEventDispatcher.run(AsyncAppenderEventDispatcher.java:63)
> >>
>  WARN  2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web
>  application [roller] appears to have started a thread named
>  [HttpClient-1-SelectorManager] but has failed to stop it. This is
>  very likely to create a memory leak. Stack trace of thread:
>    java.base@11.0.12/sun.nio.ch.EPoll.wait(Native Method)
>    java.base@11.0.12/sun.nio.ch
> .EPollSelectorImpl.doSelect(EPollSelectorImpl.java:120)
>    java.base@11.0.12/sun.nio.ch
> .SelectorImpl.lockAndDoSelect(SelectorImpl.java:124)
>    java.base@11.0.12/sun.nio.ch
> >> .SelectorImpl.select(SelectorImpl.java:136)
>    platform/java.net.http@11.0.12
> /jdk.internal.net.http.HttpClientImpl$SelectorManager.run(HttpClientImpl.java:867)
>  ERROR 2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web
>  application [roller] created a ThreadLocal with key of type
>  [java.lang.ThreadLocal] (value [java.lang.ThreadLocal@1135abda]) and
>  a value of type
>  [org.eclipse.persistence.internal.jpa.EntityManagerImpl] (value
>  [org.eclipse.persistence.internal.jpa.EntityManagerImpl@74502929])
>  but failed to remove it when the web application was stopped. Threads
>  are going to be renewed over time to try and avoid a probable memory
>  leak.
>  INFO  2021-12-19 09:22:36 [main] Http11NioProtocol - Stopping
>  ProtocolHandler ["http-nio-8080"]
>  INFO  2021-12-19 09:22:36 [main] AjpNioProtocol - Stopping
>  ProtocolHandler ["ajp-nio-127.0.0.1-8009"]
>  INFO  2021-12-19 09:22:36 [main] Http11NioProtocol - Destroying
>  ProtocolHandler ["http-nio-8080"]
>  INFO  2021-12-19 09:22:36 [main] AjpNioProtocol - Destroying
>  ProtocolHandler 

Re: VOTE: Release Roller v6.1.0

[Michael Bien]

On 15.12.21 11:53, Greg Huber wrote:




may be worth checking:

From the docs:

The quotes are wrong ie ` possibly make users check the script??:

grant all on rollerdb.* to scott@`%' identified by `tiger';

grant all on rollerdb.* to scott@localhost identified by `tiger';



i haven't touched the doc, maybe someone else can take a look





roller-custom.properties

Does not seem to work, defaults to tomcat home /logs:

log4j.appender.roller.File=/usr/local/rollerdata/roller.log




here the old PR:

https://github.com/apache/roller/pull/68

"

changes:
- loggers can no longer be configured using roller.properties or 
roller-custom.properties.

- configuration is now in log4j2.xml.
- a custom config file can be set using the standard 
log4j.configurationFile system property.
  (can be for example in roller-custom.properties or set as JVM -D 
property)


"

default config can be used as template, see comments:

https://github.com/apache/roller/blob/master/app/src/main/resources/log4j2.xml

-michael

Re: VOTE: Release Roller v6.1.0

[Michael Bien]

On 15.12.21 11:53, Greg Huber wrote:





When doing a search, and logged, we get a login url on the bottom of 
search page.


http://localhost:8080/roller/mainpage/search?q=test

 * Front Page 
 * Weblog 
 * Login 


turns out that the SearchServlet didn't copy the user to the model. The 
search results page always thinks the user is logged out. This bug was 
likely there from the beginning.


https://github.com/apache/roller/pull/111

-michael

[GitHub] [roller] mbien opened a new pull request #111: bugfix: SearchServlet forgot to copy the user to WeblogPageRequest.

[GitBox]

mbien opened a new pull request #111:
URL: https://github.com/apache/roller/pull/111


   Template model of the search results page always thought the user was not 
logged in.
   
   fix is here f1f80002ace0c5983bb4f7437110b4216e62cba9 other commit tries to 
improve readability a little bit.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: VOTE: Release RC #2 as Apache Roller 6.1.0

[Greg Huber]

Still a +1

...for some reason it does not shutdown the thread correctly, maybe its 
logging something when shutdown is called?


On 21/12/2021 22:34, Dave wrote:

Greg, did you mean to change your vote to -1 or are you still good with the
release?

Dave

On Mon, Dec 20, 2021 at 1:05 AM Greg Huber  wrote:


It was a tomcat start and stop, no deploy/redeploy.  Seems to do it all
the time.

On 19/12/2021 10:46, Michael Bien wrote:

this looks like you redeployed or undeployed roller?

App/web servers don't like it when unmanaged threads are started,
AsyncAppender uses its own thread and the server noticed this i suppose.

see config:


https://github.com/apache/roller/blob/master/app/src/main/resources/log4j2.xml#L62-L65

If you remove this part and replace "asyncRoller" with "roller" you
shouldn't see the warning anymore.

The eclipse persistence error is probably caused by the undeployment too.

This is most likely harmless, unless you want to constantly redeploy
roller. Most web/app servers these days are used like a runtime in a
1:1 manner and are started/stopped with the application (in a container).

-michael


On 19.12.21 10:28, Greg Huber wrote:

Although I now see this in the logs (17 was a maintenance release?)


WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by
org.apache.catalina.loader.WebappClassLoaderBase
(file:/../apache-tomcat-9.0.56/lib/catalina.jar) to field
java.io.ObjectStreamClass$Caches.localDescs
WARNING: Please consider reporting this to the maintainers of
org.apache.catalina.loader.WebappClassLoaderBase
WARNING: Use --illegal-access=warn to enable warnings of further
illegal reflective access operations
WARNING: All illegal access operations will be denied in a future
release
WARN  2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web
application [roller] appears to have started a thread named
[Log4j2-AsyncAppenderEventDispatcher-1-asyncRoller] but has failed to
stop it. This is very likely to create a memory leak. Stack trace of
thread:
  java.base@11.0.12/jdk.internal.misc.Unsafe.park(Native Method)
  
java.base@11.0.12/java.util.concurrent.locks.LockSupport.park(LockSupport.java:194)
  
java.base@11.0.12/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2081)
  
java.base@11.0.12/java.util.concurrent.ArrayBlockingQueue.take(ArrayBlockingQueue.java:417)


  
org.apache.logging.log4j.core.appender.AsyncAppenderEventDispatcher.dispatchAll(AsyncAppenderEventDispatcher.java:71)




  
org.apache.logging.log4j.core.appender.AsyncAppenderEventDispatcher.run(AsyncAppenderEventDispatcher.java:63)


WARN  2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web
application [roller] appears to have started a thread named
[HttpClient-1-SelectorManager] but has failed to stop it. This is
very likely to create a memory leak. Stack trace of thread:
  java.base@11.0.12/sun.nio.ch.EPoll.wait(Native Method)
  
java.base@11.0.12/sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:120)
  
java.base@11.0.12/sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:124)
  java.base@11.0.12/sun.nio.ch

.SelectorImpl.select(SelectorImpl.java:136)

  
platform/java.net.http@11.0.12/jdk.internal.net.http.HttpClientImpl$SelectorManager.run(HttpClientImpl.java:867)
ERROR 2021-12-19 09:22:36 [main] WebappClassLoaderBase - The web
application [roller] created a ThreadLocal with key of type
[java.lang.ThreadLocal] (value [java.lang.ThreadLocal@1135abda]) and
a value of type
[org.eclipse.persistence.internal.jpa.EntityManagerImpl] (value
[org.eclipse.persistence.internal.jpa.EntityManagerImpl@74502929])
but failed to remove it when the web application was stopped. Threads
are going to be renewed over time to try and avoid a probable memory
leak.
INFO  2021-12-19 09:22:36 [main] Http11NioProtocol - Stopping
ProtocolHandler ["http-nio-8080"]
INFO  2021-12-19 09:22:36 [main] AjpNioProtocol - Stopping
ProtocolHandler ["ajp-nio-127.0.0.1-8009"]
INFO  2021-12-19 09:22:36 [main] Http11NioProtocol - Destroying
ProtocolHandler ["http-nio-8080"]
INFO  2021-12-19 09:22:36 [main] AjpNioProtocol - Destroying
ProtocolHandler ["ajp-nio-127.0.0.1-8009"]

On 18/12/2021 20:48, Dave wrote:

I propose that we release Roller v6.1.0 based on the code that is
currently
in the master branch. I have prepared a release candidate and some
release
notes, below.

Please vote in the next 72 hours to approve this release.
+1 to release
-1 not to release (with reasons)

Thanks to Michael Bien for all his work since the 6.0.1 release on bug
fixes, general improvements and dependency updates like the
important one
he made today to upgrade Log4j to 2.17.0.

The release candidate files are here:
https://dist.apache.org/repos/dist/dev/roller/roller-6.1/v6.1.0/

Release notes

This is a bug fix and dependency update release that includes all
changes
made to the master branch since August 16, 2021. It also includes
the new